Re: New features
Germán Arias schrieb: > Hi Fred, If you are agree I will add the variables > GSUseWindowFrameColorToMenu and GSMenuItemsBordered to GUI, but I don't > know in what file are seated the defaults values of the variables. > > And I don't know if you are agree to add GSTaskBar (or whatever you want > call it). To do this I need add some changes on NSApplication and > NSWindow, and add another variable for use this, maybe GSUseGSTaskBar. > Of course this need a tool that I call "gstb". Greetings. Hi German, as for the changes to the menu drawing I would prefer to see the whole drawing here moved over into GSTheme and then it would be very simple to implement everything you want to do by a new specialised theme that just draws the menu differently. There isn't much point in inventing a special mechanism to handle one specific drawing aspect when there already is a perfect concept to deal with the whole thing. Specifically for the menu item colour I am thinking about making the system extension colour list, that is already used in GSToolbarView an official GNUstep mechanism, move the code over to NSColor and to add all the other colour definitions we have scattered in GNUstep gui (I think NSTableView uses some, hints to other places are welcome). That way a theme would just need to override one extra colour list. Is this a feasible approach for you? Or do you see a reason to do things differently? As for GSTaskBar I already replied on the discussion list. What I would like to know about the implementation is what change will be required in NSApplication and NSWindow. We should try to come up with a generic way to handle application icons here, so that we don't need to change our gui code the next time somebody comes up with an idea for a task bar tool. Fred ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: New features
El dom, 01-11-2009 a las 17:29 +0100, Fred Kiefer escribió: > Germán Arias schrieb: > > Hi Fred, If you are agree I will add the variables > > GSUseWindowFrameColorToMenu and GSMenuItemsBordered to GUI, but I don't > > know in what file are seated the defaults values of the variables. > > > > And I don't know if you are agree to add GSTaskBar (or whatever you want > > call it). To do this I need add some changes on NSApplication and > > NSWindow, and add another variable for use this, maybe GSUseGSTaskBar. > > Of course this need a tool that I call "gstb". Greetings. > > Hi German, > > as for the changes to the menu drawing I would prefer to see the whole > drawing here moved over into GSTheme and then it would be very simple to > implement everything you want to do by a new specialised theme that just > draws the menu differently. There isn't much point in inventing a > special mechanism to handle one specific drawing aspect when there > already is a perfect concept to deal with the whole thing. To me this is good, the reason because I use a variable is because was the more easy way (At this moment I don't understand exactly how GSTheme work). > > Specifically for the menu item colour I am thinking about making the > system extension colour list, that is already used in GSToolbarView an > official GNUstep mechanism, move the code over to NSColor and to add all > the other colour definitions we have scattered in GNUstep gui (I think > NSTableView uses some, hints to other places are welcome). That way a > theme would just need to override one extra colour list. > > Is this a feasible approach for you? Or do you see a reason to do things > differently? in fact, that was my first intention on this. But when I saw that there wasn't a color for this, then I changed this on NSTitleView. But of course, a new color on this list is better. > > As for GSTaskBar I already replied on the discussion list. What I would > like to know about the implementation is what change will be required in > NSApplication and NSWindow. We should try to come up with a generic way > to handle application icons here, so that we don't need to change our > gui code the next time somebody comes up with an idea for a task bar tool. > > Fred ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: New features
Hi, Specifically for the menu item colour I am thinking about making the system extension colour list, that is already used in GSToolbarView an official GNUstep mechanism, move the code over to NSColor and to add all the other colour definitions we have scattered in GNUstep gui (I think NSTableView uses some, hints to other places are welcome). That way a theme would just need to override one extra colour list. Is this a feasible approach for you? Or do you see a reason to do things differently? Having a separate color for the "menu bar" and for the menus themselves would help also in making a better Windows theme, since WinXP and Vista have separate colors for that. Thank you. As for GSTaskBar I already replied on the discussion list. What I would like to know about the implementation is what change will be required in NSApplication and NSWindow. We should try to come up with a generic way to handle application icons here, so that we don't need to change our gui code the next time somebody comes up with an idea for a task bar tool. I miss to understand what's really about too. Riccardo ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
NSColor extensions (Was: New features)
Fred Kiefer schrieb: > Specifically for the menu item colour I am thinking about making the > system extension colour list, that is already used in GSToolbarView an > official GNUstep mechanism, move the code over to NSColor and to add all > the other colour definitions we have scattered in GNUstep gui (I think > NSTableView uses some, hints to other places are welcome). That way a > theme would just need to override one extra colour list. I am having second thoughts on my own proposal. The interplay between NSColor and GSTheme is already complex enough having to deal with just one colour list. Adding a second one will make it even harder to understand that code. My new idea now is to add the few additional colours we need to the "System" colour list, the one themes already override. Is this fine for everybody? Fred ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: NSColor extensions (Was: New features)
Hi, I am having second thoughts on my own proposal. The interplay between NSColor and GSTheme is already complex enough having to deal with just one colour list. Adding a second one will make it even harder to understand that code. My new idea now is to add the few additional colours we need to the "System" colour list, the one themes already override. Is this fine for everybody? That looks fine for me and that is what I originally thought. ANy arguments against that? (Richard?) Riccardo ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
Re: NSColor extensions (Was: New features)
On 1 Nov 2009, at 22:15, Fred Kiefer wrote: Fred Kiefer schrieb: Specifically for the menu item colour I am thinking about making the system extension colour list, that is already used in GSToolbarView an official GNUstep mechanism, move the code over to NSColor and to add all the other colour definitions we have scattered in GNUstep gui (I think NSTableView uses some, hints to other places are welcome). That way a theme would just need to override one extra colour list. I am having second thoughts on my own proposal. The interplay between NSColor and GSTheme is already complex enough having to deal with just one colour list. Adding a second one will make it even harder to understand that code. My new idea now is to add the few additional colours we need to the "System" colour list, the one themes already override. Is this fine for everybody? GSTheme already supports extra colors. The API is -colorNamed:state:cache: This is used for scroller slots (see GSThemeDrawing.m) and for thew color of a scrollview (NSScrollView.m) I don't see any point in changing the system colors ... they can remain as they are for OSX compatibility, but for theming our own controls we can keep things simple by using the GSTheme API directly. ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev
