windowmaker - application icon missing at first start

2020-10-16 Thread Riccardo Mottola
Hi!

I noticed we recently have a strange behaviour, which is slightly
different from setup (= installation on different computers) to setup I have

The first time I start a GNUstep application with windowmaker (I mean
the first GNUstep app started ever after X11 start essentially) it has a
bad icon.
- on some setup it has a "generic" icon by windowmaker
- on other setups it has a black looking icon, as only the "mask" of the
icon, the contours are drawn

A restart of the app and then starting any other app, fixes that.


This was not happening before. I think it is related to at least this
commit - merge:

https://github.com/mozilla/newtab-dev/raw/6be44da368fb869a3d3e1975f515857352a7d9fc/browser/modules/ProcessHangMonitor.jsm

Can you reproduce? How is it for you?

Riccardo




Re: windowmaker - application icon missing at first start

2020-10-16 Thread Wolfgang Lux
Hi Riccardo,

> I noticed we recently have a strange behaviour, which is slightly
> different from setup (= installation on different computers) to setup I have
> 
> The first time I start a GNUstep application with windowmaker (I mean
> the first GNUstep app started ever after X11 start essentially) it has a
> bad icon.
> - on some setup it has a "generic" icon by windowmaker
> - on other setups it has a black looking icon, as only the "mask" of the
> icon, the contours are drawn
> 
> A restart of the app and then starting any other app, fixes that.
> 
> 
> This was not happening before.

Actually, this has been happening before, but it was fixed about five years ago 
in this commit:
  
https://github.com/gnustep/libs-back/commit/1e1185abb364f2ffcb5f06f62c1241d419b8b697#diff-c3c9abc7461037f8abf3f590d909cff84c39bc7817b79d7dfd379b38a3756385

> I think it is related to at least this
> commit - merge:
> 
> https://github.com/mozilla/newtab-dev/raw/6be44da368fb869a3d3e1975f515857352a7d9fc/browser/modules/ProcessHangMonitor.jsm

I assume you meant this commit instead
  
https://github.com/gnustep/libs-back/commit/31b7c4ed2f8efa0127605511aaf4eafef6a3d1c8
And, yes, your suspicion is correct because it exactly comments out the earlier 
fix.

Wolfgang




Re: windowmaker - application icon missing at first start

2020-10-16 Thread Sergii Stoian
Hi,

> On Oct 17, 2020, at 00:27, Wolfgang Lux  wrote:
> 
> Hi Riccardo,
> 
>> I noticed we recently have a strange behaviour, which is slightly
>> different from setup (= installation on different computers) to setup I have
>> 
>> The first time I start a GNUstep application with windowmaker (I mean
>> the first GNUstep app started ever after X11 start essentially) it has a
>> bad icon.
>> - on some setup it has a "generic" icon by windowmaker
>> - on other setups it has a black looking icon, as only the "mask" of the
>> icon, the contours are drawn

Riccardo, could you please provide more info on your specific setups?
Do you have “UseWindowMakerIcons” set to “NO” in NSGlobalDomain?

>> 
>> A restart of the app and then starting any other app, fixes that.
>> 
>> 
>> This was not happening before.
> 
> Actually, this has been happening before, but it was fixed about five years 
> ago in this commit:
>  
> https://github.com/gnustep/libs-back/commit/1e1185abb364f2ffcb5f06f62c1241d419b8b697#diff-c3c9abc7461037f8abf3f590d909cff84c39bc7817b79d7dfd379b38a3756385
> 
>> I think it is related to at least this
>> commit - merge:
>> 
>> https://github.com/mozilla/newtab-dev/raw/6be44da368fb869a3d3e1975f515857352a7d9fc/browser/modules/ProcessHangMonitor.jsm
> 
> I assume you meant this commit instead
>  
> https://github.com/gnustep/libs-back/commit/31b7c4ed2f8efa0127605511aaf4eafef6a3d1c8
> And, yes, your suspicion is correct because it exactly comments out the 
> earlier fix.

As stated in description to this commit it fixes flickering of appicon at 
application start. Quote: “This fix based on the fact that root application 
window (ROOT) is mapped in `-orderwindow:::` and this is the event of 
application recognition by WindowMaker because it is a first application window 
that is mapped.”. That "root application window" is called “group leader” and 
saved in every application window structure (WWindow) member `main_window` 
inside WM. It holds all required properties to be detected by WM correctly.

The earlier fix probably masks other unknown problem. My WindowMaker 0.95.7 
default configuration tests work like a charm.
Wolfgang, do you observe the same behaviour as Riccardo? I yes, could you 
please share your setup?

> Wolfgang
> 
> 

Sergii


R: windowmaker - application icon missing at first start

2020-10-16 Thread Alessandro Sangiuliano
I wrote this email some days ago to Fred privately, because I was thinking that 
the problem was relative to my window manager that is young and ealyy stage, so 
i post here too bcause the problem is quite similar.

Hi Fred,

I write becaus ethe gnustep support in uroswm is almost completed, but there 
are few things to fix, actually in the miniwindow managment. Explain it with 
words would be a bit complex especially with my english, so I made a gif pic to 
share with you.

Here is the lin that will expire after one month:

https://ibb.co/3ND5Dhw

Now i explain the problem in steps amd you will noticed them in the gif:

1) First time run uroswm
2) First time a GNUstep App
3) When the App is first time started the miniwindow on the left-bottom corner 
doesn't draw the icon, or better, it draws the icon but disappers quite soon. 
The icon just appears for some instants and then disappers.
4) I close the App
5) I run again the app
6) At this point, the App is started for the second time, ll works as expecetd 
and the miniwindow draws the icon ans show it as expected.

Don't be scared by bad colors in the gif i just set low quality to the recorder.

Why at the first start of theapp the icon is not painted as we expects? Maybe 
at the first run GS is doing some particular requests or setting/asking for soe 
extended window manager hints?

Thank you,
Alex



Da: Gnustep-dev  per conto di 
Riccardo Mottola 
Inviato: venerdì 16 ottobre 2020 11:40
A: gnustep-dev@gnu.org 
Oggetto: windowmaker - application icon missing at first start

Hi!

I noticed we recently have a strange behaviour, which is slightly
different from setup (= installation on different computers) to setup I have

The first time I start a GNUstep application with windowmaker (I mean
the first GNUstep app started ever after X11 start essentially) it has a
bad icon.
- on some setup it has a "generic" icon by windowmaker
- on other setups it has a black looking icon, as only the "mask" of the
icon, the contours are drawn

A restart of the app and then starting any other app, fixes that.


This was not happening before. I think it is related to at least this
commit - merge:

https://github.com/mozilla/newtab-dev/raw/6be44da368fb869a3d3e1975f515857352a7d9fc/browser/modules/ProcessHangMonitor.jsm

Can you reproduce? How is it for you?

Riccardo