date:20110826




Thanks. I'll look through and incorporate your changes.


zhuyi, any updates on this?

http://gwt-code-reviews.appspot.com/1380807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add NoSuchMethodException to java.lang (issue1529807)


Reviewers: scottb,



Please review this at http://gwt-code-reviews.appspot.com/1529807/

Affected files:
  A user/super/com/google/gwt/emul/java/lang/NoSuchMethodException.java


Index: user/super/com/google/gwt/emul/java/lang/NoSuchMethodException.java
diff --git  
a/user/super/com/google/gwt/emul/java/lang/NoSuchMethodException.java  
b/user/super/com/google/gwt/emul/java/lang/NoSuchMethodException.java

new file mode 100644
index  
..26285ad346b52a23581dfc72d14109db51d8b1cb

--- /dev/null
+++ b/user/super/com/google/gwt/emul/java/lang/NoSuchMethodException.java
@@ -0,0 +1,31 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package java.lang;
+
+/**
+ * See a
+ *  
href=http://java.sun.com/j2se/1.5.0/docs/api/java/lang/NoSuchMethodException.html;the

+ * official Java API doc/a for details.
+ */
+public class NoSuchMethodException extends Exception {
+
+  public NoSuchMethodException() {
+  }
+
+  public NoSuchMethodException(String message) {
+super(message);
+  }
+}


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add NoSuchMethodException to java.lang (issue1529807)


I know this seems odd, given GWT doesn't support reflection, but in the
scala-library there are a few places that throw this exception even
though it's not reflection-related.

We can patch around that, but given that, in theory anyway, other users
could use this exception for non-reflection purposes as well, it doesn't
seem like a big deal to include it in the emulated java lang.

http://gwt-code-reviews.appspot.com/1529807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add NoSuchMethodException to java.lang (issue1529807)

2011-08-26 Thread jat



http://gwt-code-reviews.appspot.com/1529807/diff/1/user/super/com/google/gwt/emul/java/lang/NoSuchMethodException.java
File user/super/com/google/gwt/emul/java/lang/NoSuchMethodException.java
(right):

http://gwt-code-reviews.appspot.com/1529807/diff/1/user/super/com/google/gwt/emul/java/lang/NoSuchMethodException.java#newcode21
user/super/com/google/gwt/emul/java/lang/NoSuchMethodException.java:21:
* official Java API doc/a for details.
The doc needs to very clearly say this will never be thrown by GWT or
any GWT libraries and is only provided for compatibility with user code
that explicitly throws or catches it.

http://gwt-code-reviews.appspot.com/1529807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add NoSuchMethodException to java.lang (issue1529807)


http://gwt-code-reviews.appspot.com/1529807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add NoSuchMethodException to java.lang (issue1529807)


On 2011/08/26 16:19:51, jat wrote:

The doc needs to very clearly say this will never be thrown by GWT


Agreed; done.



http://gwt-code-reviews.appspot.com/1529807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add NoSuchMethodException to java.lang (issue1529807)


http://gwt-code-reviews.appspot.com/1529807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add NoSuchMethodException to java.lang (issue1529807)


On 2011/08/26 17:10:50, scottb wrote:

How about is not thrown present tense?  No need to tie ourselves

down for all

of time. :)


Hehe, fair enough. Done.



http://gwt-code-reviews.appspot.com/1529807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] maven source jars

2011-08-26 Thread Stephen Haberman


 David, could you send us (Stephen and me) your scripts so we could
 work together making this real? (if you're OK with this, Stephen)

Definitely. Sounds cool to me.

- Stephen

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a new CellTableHeaderBuilder API, which allows custom headers and footers in CellTable. C... (issue1499808)


committed as r10581

A follow up change is coming to merge the latest CellTableBuilder
changes into HeaderCreator.

http://gwt-code-reviews.appspot.com/1499808/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10583 committed - Integrate r10431 into GWT 2.4 branch....


Revision: 10583
Author:   gwt.mirror...@gmail.com
Date: Fri Aug 26 08:21:06 2011
Log:  Integrate r10431 into GWT 2.4 branch.

Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10583

Modified:
  
/releases/2.4/user/test/com/google/web/bindery/requestfactory/apt/RfValidatorTest.java


===
---  
/releases/2.4/user/test/com/google/web/bindery/requestfactory/apt/RfValidatorTest.java	 
Thu Aug 25 10:06:37 2011
+++  
/releases/2.4/user/test/com/google/web/bindery/requestfactory/apt/RfValidatorTest.java	 
Fri Aug 26 08:21:06 2011

@@ -154,6 +154,10 @@
*/
   private void testGeneratedMessages(boolean clientOnly, Class?...  
classes) throws IOException {

 JavaCompiler compiler = ToolProvider.getSystemJavaCompiler();
+if (compiler == null) {
+  // This test is being run without a full JDK
+  return;
+}

 // Don't spray files in random locations
 File tempFile =  
File.createTempFile(RfValidatorTest.class.getSimpleName(), .jar);


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make UmbrellaException a bit more convenient to read, and test it. (issue1532803)

2011-08-26 Thread Ray Ryan

r10584


On Thu Aug 25 23:08:59 GMT-700 2011, cromwell...@google.comgt wrote:

 lgtm

 http://gwt-code-reviews.appspot.com/1532803/http://www.google.com/url?sa=Dq=http://gwt-code-reviews.appspot.com/1532803/


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10584 committed - Make UmbrellaException a bit more convenient to read, and test it....


Revision: 10584
Author:   rj...@google.com
Date: Fri Aug 26 08:45:52 2011
Log:  Make UmbrellaException a bit more convenient to read, and test it.

Review at http://gwt-code-reviews.appspot.com/1532803

Review by: cromwell...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10584

Added:
  
/trunk/user/test/com/google/web/bindery/event/shared/UmbrellaExceptionTest.java

Modified:
 /trunk/user/src/com/google/web/bindery/event/shared/UmbrellaException.java

===
--- /dev/null
+++  
/trunk/user/test/com/google/web/bindery/event/shared/UmbrellaExceptionTest.java	 
Fri Aug 26 08:45:52 2011

@@ -0,0 +1,83 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package com.google.web.bindery.event.shared;
+
+import junit.framework.TestCase;
+
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * Unit test for {@link #UmbrellaException}.
+ */
+public class UmbrellaExceptionTest extends TestCase {
+  public void testNone() {
+// Why?
+try {
+  throw new UmbrellaException(Collections.Throwable emptySet());
+} catch (UmbrellaException e) {
+  assertNull(e.getCause());
+  assertNull(e.getMessage());
+}
+  }
+
+  public void testOne() {
+SetThrowable causes = new HashSetThrowable();
+String message = Just me;
+RuntimeException theOne = new RuntimeException(message);
+causes.add(theOne);
+
+try {
+  throw new UmbrellaException(causes);
+} catch (UmbrellaException e) {
+  assertSame(theOne, e.getCause());
+  assertEquals(UmbrellaException.ONE + message, e.getMessage());
+}
+  }
+
+  public void testSome() {
+SetThrowable causes = new HashSetThrowable();
+String oneMessage = one;
+RuntimeException oneException = new RuntimeException(oneMessage);
+causes.add(oneException);
+
+String twoMessage = two;
+RuntimeException twoException = new RuntimeException(twoMessage);
+causes.add(twoException);
+
+try {
+  throw new UmbrellaException(causes);
+} catch (UmbrellaException e) {
+  // A bit non-deterministic for a unit test, but I've checked both  
paths --

+  // rjrjr
+  if (e.getCause() == oneException) {
+assertCauseMatchesFirstMessage(e, oneMessage, twoMessage);
+  } else if (e.getCause() == twoException) {
+assertCauseMatchesFirstMessage(e, twoMessage, oneMessage);
+  } else {
+fail(Expected one of the causes and its message);
+  }
+}
+  }
+
+  private void assertCauseMatchesFirstMessage(UmbrellaException e, String  
firstMessage,

+  String otherMessage) {
+assertTrue(Cause should be first message, e.getMessage().startsWith(
+2 + UmbrellaException.MULTIPLE + firstMessage));
+assertTrue(Should also see the other message,  
e.getMessage().contains(otherMessage));

+  }
+}
===
---  
/trunk/user/src/com/google/web/bindery/event/shared/UmbrellaException.java	 
Mon Apr 18 16:25:25 2011
+++  
/trunk/user/src/com/google/web/bindery/event/shared/UmbrellaException.java	 
Fri Aug 26 08:45:52 2011

@@ -16,6 +16,7 @@
 package com.google.web.bindery.event.shared;

 import java.util.Collections;
+import java.util.Iterator;
 import java.util.Set;

 /**
@@ -26,15 +27,48 @@
  */
 public class UmbrellaException extends RuntimeException {

-  private static final String MSG =
-  One or more exceptions caught, see full set in  
UmbrellaException#getCauses;

+  // Visible for testing
+  static final String MULTIPLE =  exceptions caught: ;
+
+  // Visible for testing
+  static final String ONE = Exception caught: ;
+
+  protected static Throwable makeCause(SetThrowable causes) {
+IteratorThrowable iterator = causes.iterator();
+if (!iterator.hasNext()) {
+  return null;
+}
+
+return iterator.next();
+  }
+
+  protected static String makeMessage(SetThrowable causes) {
+int count = causes.size();
+if (count == 0) {
+  return null;
+}
+
+StringBuilder b = new StringBuilder(count == 1 ? ONE : count +  
MULTIPLE);

+boolean first = true;
+for (Throwable t : causes) {
+  if (first) {
+first = false;
+  } else {
+b.append(; );
+  }
+  b.append(t.getMessage());
+}
+
+return b.toString();
+  }
+
   /**
* The causes of the exception.
*/
   private SetThrowable causes;

   public

[gwt-contrib] Re: Firefox 6 DevMode Plugin (issue1523805)

2011-08-26 Thread conroy


On 2011/08/26 18:59:42, acleung wrote:

On 2011/08/26 18:58:34, acleung wrote:



Thanks! PTAL



BTW, how do I go about verifying the universal binary is built

correctly? Do I

need to grab an older Mac or am I missing something very obvious?


If you have an older mac, then that works. Otherwise you can always open
Firefox in 32 bit mode (in Finder, right click-Get Info-Open in 32 bit
mode)

Also, looks like you still need to make the Darwin modifications

http://gwt-code-reviews.appspot.com/1523805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10585 committed - Edited wiki page RequestFactoryInterfaceValidation through web user in...


Revision: 10585
Author:   rj...@google.com
Date: Fri Aug 26 12:09:28 2011
Log:  Edited wiki page RequestFactoryInterfaceValidation through web  
user interface.

http://code.google.com/p/google-web-toolkit/source/detail?r=10585

Modified:
 /wiki/RequestFactoryInterfaceValidation.wiki

===
--- /wiki/RequestFactoryInterfaceValidation.wikiFri Aug 19 11:42:56 2011
+++ /wiki/RequestFactoryInterfaceValidation.wikiFri Aug 26 12:09:28 2011
@@ -1,6 +1,6 @@
 #summary Provides late validation of RequestFactory interfaces

-When GWT 2.5 is released (at this writing, the current version is 2.3),  
RequestFactory interfaces must be validated before they can be used by the  
RequestFactory server code or JVM-based clients.  This document explains  
the mechanisms for validating those interfaces.
+When GWT 2.4 is released (at this writing, the current version is 2.3),  
RequestFactory interfaces must be validated before they can be used by the  
RequestFactory server code or JVM-based clients.  This document explains  
the mechanisms for validating those interfaces.


 wiki:toc /

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Modifying DefaultHeaderCreator to support null sorting indicator images. Until a recent change,... (issue1533803)


Reviewers: eschoeffler,

Description:
Modifying DefaultHeaderCreator to support null sorting indicator images.
 Until a recent change, CellTable would not throw any errors if the sort
indicators in the Resources returned null, as long as the CellTable was
never sorted.  However, DefaultHeaderCreator aggressively caches the
height and width of the icons.  While this was never officially
supported, its convenient behavior for people trying to reduce code size
by removing the inlined image.


Please review this at http://gwt-code-reviews.appspot.com/1533803/

Affected files:
  M user/src/com/google/gwt/user/cellview/client/DefaultHeaderCreator.java
  M user/test/com/google/gwt/user/cellview/client/CellTableTest.java


Index:  
user/src/com/google/gwt/user/cellview/client/DefaultHeaderCreator.java

===
--- user/src/com/google/gwt/user/cellview/client/DefaultHeaderCreator.java	 
(revision 10584)
+++ user/src/com/google/gwt/user/cellview/client/DefaultHeaderCreator.java	 
(working copy)

@@ -71,10 +71,20 @@
  */
 ImageResource asc = table.getResources().sortAscending();
 ImageResource desc = table.getResources().sortDescending();
-sortAscIconWidth = asc.getWidth() + ICON_PADDING;
-sortDescIconWidth = desc.getWidth() + ICON_PADDING;
-sortAscIconHalfHeight = (int) Math.round(asc.getHeight() / 2.0);
-sortDescIconHalfHeight = (int) Math.round(desc.getHeight() / 2.0);
+if (asc != null) {
+  sortAscIconWidth = asc.getWidth() + ICON_PADDING;
+  sortAscIconHalfHeight = (int) Math.round(asc.getHeight() / 2.0);
+} else {
+  sortAscIconWidth = 0;
+  sortAscIconHalfHeight = 0;
+}
+if (desc != null) {
+  sortDescIconWidth = desc.getWidth() + ICON_PADDING;
+  sortDescIconHalfHeight = (int) Math.round(desc.getHeight() / 2.0);
+} else {
+  sortDescIconWidth = 0;
+  sortDescIconHalfHeight = 0;
+}
   }

   @Override
Index: user/test/com/google/gwt/user/cellview/client/CellTableTest.java
===
--- user/test/com/google/gwt/user/cellview/client/CellTableTest.java	 
(revision 10584)
+++ user/test/com/google/gwt/user/cellview/client/CellTableTest.java	 
(working copy)

@@ -180,6 +180,56 @@
   }

   /**
+   * Using a null sort icon should not cause any errors if none of the  
columns

+   * are sortable.
+   */
+  public void testNullSortIcons() {
+// Create a Resources instance that does not include sort images.
+CellTable.Resources resources = new CellTable.Resources() {
+  private final CellTable.Resources defaultRes =  
GWT.create(CellTable.Resources.class);

+
+  @Override
+  public ImageResource cellTableFooterBackground() {
+return defaultRes.cellTableFooterBackground();
+  }
+
+  @Override
+  public ImageResource cellTableHeaderBackground() {
+return defaultRes.cellTableHeaderBackground();
+  }
+
+  @Override
+  public ImageResource cellTableLoading() {
+return defaultRes.cellTableLoading();
+  }
+
+  @Override
+  public ImageResource cellTableSelectedBackground() {
+return defaultRes.cellTableSelectedBackground();
+  }
+
+  @Override
+  public ImageResource cellTableSortAscending() {
+return null;
+  }
+
+  @Override
+  public ImageResource cellTableSortDescending() {
+return null;
+  }
+
+  @Override
+  public Style cellTableStyle() {
+return defaultRes.cellTableStyle();
+  }
+};
+
+CellTableString table = new CellTableString(10, resources);
+populateData(table);
+table.getPresenter().flush();
+  }
+
+  /**
* Test that removing a column sets its width to zero.
*/
   public void testRemoveColumnWithWidth() {


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Adding a test case that verifies CellTable works even if all image resources are null. Sort ico... (issue1534803)


Reviewers: eschoeffler,

Description:
Adding a test case that verifies CellTable works even if all image
resources are null.  Sort icons are only used if a column is sorted
(sorting will cause an NPE). Background icons are used in the default
styles, and are optional. The sorting icon is specially handled to allow
for null.


Please review this at http://gwt-code-reviews.appspot.com/1534803/

Affected files:
  M user/test/com/google/gwt/user/cellview/client/CellTableTest.java


Index: user/test/com/google/gwt/user/cellview/client/CellTableTest.java
===
--- user/test/com/google/gwt/user/cellview/client/CellTableTest.java	 
(revision 10584)
+++ user/test/com/google/gwt/user/cellview/client/CellTableTest.java	 
(working copy)

@@ -230,6 +230,59 @@
   }

   /**
+   * CellTable should not throw any errors if all of the icons are null.
+   *
+   * Sort icons are only used if a column is sorted. Background icons are  
not
+   * used in the default styles, and are optional. The sorting icon is  
specially

+   * handled.
+   */
+  public void testNullIcons() {
+// Create a Resources instance that does not include sort images.
+CellTable.Resources resources = new CellTable.Resources() {
+  private final CellTable.Resources defaultRes =  
GWT.create(CellTable.Resources.class);

+
+  @Override
+  public ImageResource cellTableFooterBackground() {
+return null;
+  }
+
+  @Override
+  public ImageResource cellTableHeaderBackground() {
+return null;
+  }
+
+  @Override
+  public ImageResource cellTableLoading() {
+return null;
+  }
+
+  @Override
+  public ImageResource cellTableSelectedBackground() {
+return null;
+  }
+
+  @Override
+  public ImageResource cellTableSortAscending() {
+return null;
+  }
+
+  @Override
+  public ImageResource cellTableSortDescending() {
+return null;
+  }
+
+  @Override
+  public Style cellTableStyle() {
+return defaultRes.cellTableStyle();
+  }
+};
+
+CellTableString table = new CellTableString(10, resources);
+populateData(table);
+table.getPresenter().flush();
+  }
+
+  /**
* Test that removing a column sets its width to zero.
*/
   public void testRemoveColumnWithWidth() {


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10586 committed - Modifying DefaultHeaderCreator to support null sorting indicator image...


Revision: 10586
Author:   jlaba...@google.com
Date: Fri Aug 26 09:38:28 2011
Log:  Modifying DefaultHeaderCreator to support null sorting indicator  
images.  Until a recent change, CellTable would not throw any errors if the  
sort indicators in the Resources returned null, as long as the CellTable  
was never sorted.  However, DefaultHeaderCreator aggressively caches the  
height and width of the icons.  While this was never officially supported,  
its convenient behavior for people trying to reduce code size by removing  
the inlined image.


Review at http://gwt-code-reviews.appspot.com/1533803

http://code.google.com/p/google-web-toolkit/source/detail?r=10586

Modified:
  
/trunk/user/src/com/google/gwt/user/cellview/client/DefaultHeaderCreator.java

 /trunk/user/test/com/google/gwt/user/cellview/client/CellTableTest.java

===
---  
/trunk/user/src/com/google/gwt/user/cellview/client/DefaultHeaderCreator.java	 
Fri Aug 26 07:24:39 2011
+++  
/trunk/user/src/com/google/gwt/user/cellview/client/DefaultHeaderCreator.java	 
Fri Aug 26 09:38:28 2011

@@ -71,10 +71,20 @@
  */
 ImageResource asc = table.getResources().sortAscending();
 ImageResource desc = table.getResources().sortDescending();
-sortAscIconWidth = asc.getWidth() + ICON_PADDING;
-sortDescIconWidth = desc.getWidth() + ICON_PADDING;
-sortAscIconHalfHeight = (int) Math.round(asc.getHeight() / 2.0);
-sortDescIconHalfHeight = (int) Math.round(desc.getHeight() / 2.0);
+if (asc != null) {
+  sortAscIconWidth = asc.getWidth() + ICON_PADDING;
+  sortAscIconHalfHeight = (int) Math.round(asc.getHeight() / 2.0);
+} else {
+  sortAscIconWidth = 0;
+  sortAscIconHalfHeight = 0;
+}
+if (desc != null) {
+  sortDescIconWidth = desc.getWidth() + ICON_PADDING;
+  sortDescIconHalfHeight = (int) Math.round(desc.getHeight() / 2.0);
+} else {
+  sortDescIconWidth = 0;
+  sortDescIconHalfHeight = 0;
+}
   }

   @Override
===
--- /trunk/user/test/com/google/gwt/user/cellview/client/CellTableTest.java	 
Fri Aug 26 07:24:39 2011
+++ /trunk/user/test/com/google/gwt/user/cellview/client/CellTableTest.java	 
Fri Aug 26 09:38:28 2011

@@ -178,6 +178,56 @@
 CellTableString table = new CellTableString(25, resources);
 assertNull(table.getLoadingIndicator());
   }
+
+  /**
+   * Using a null sort icon should not cause any errors if none of the  
columns

+   * are sortable.
+   */
+  public void testNullSortIcons() {
+// Create a Resources instance that does not include sort images.
+CellTable.Resources resources = new CellTable.Resources() {
+  private final CellTable.Resources defaultRes =  
GWT.create(CellTable.Resources.class);

+
+  @Override
+  public ImageResource cellTableFooterBackground() {
+return defaultRes.cellTableFooterBackground();
+  }
+
+  @Override
+  public ImageResource cellTableHeaderBackground() {
+return defaultRes.cellTableHeaderBackground();
+  }
+
+  @Override
+  public ImageResource cellTableLoading() {
+return defaultRes.cellTableLoading();
+  }
+
+  @Override
+  public ImageResource cellTableSelectedBackground() {
+return defaultRes.cellTableSelectedBackground();
+  }
+
+  @Override
+  public ImageResource cellTableSortAscending() {
+return null;
+  }
+
+  @Override
+  public ImageResource cellTableSortDescending() {
+return null;
+  }
+
+  @Override
+  public Style cellTableStyle() {
+return defaultRes.cellTableStyle();
+  }
+};
+
+CellTableString table = new CellTableString(10, resources);
+populateData(table);
+table.getPresenter().flush();
+  }

   /**
* Test that removing a column sets its width to zero.

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Integrating Peng's recent API changes to CellTableBuilder into HeaderCreator. HeaderCreator now... (issue1533804)

Reviewers: skybrian, rjrjr, peng_google.com,

Description:
Integrating Peng's recent API changes to CellTableBuilder into
HeaderCreator. HeaderCreator now includes both the rendering code and
the event handling logic, eliminating the HeaderCreator.Helper class
completely. This allows for a simpler implementation of HeaderCreator
that only supports a single row, or an application specific
implementation, either of which could be lighter weight than the default
implementation. The API is very similar to CellTableBuilder, but
slightly simpler because there is no concept of row values in a header.
Note that there are no behavioral changes here, its just a rearrangement
of API.

The one big question, which this change does not answer, is which class
to rename: HeaderCreator or CellTableBuilder. Personally, I think that
both classes are much more builder-like than they were, so maybe we can
just rename HeaderCreator to HeaderBuilder. That would certainly be the
easiest from an adoption standpoint, as CellTableBuilder already has
wide use and would be harder to rename.

Also, we could drop the Cell from CellTableBuilder to make it more
consistent with HeaderBuilder/Creator. However, that would be a pain,
so I'm happy just leaving CellTableBuilder as is.

Please review this at http://gwt-code-reviews.appspot.com/1533804/

Affected files:
M
samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java

M user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
A user/src/com/google/gwt/user/cellview/client/AbstractHeaderCreator.java
M user/src/com/google/gwt/user/cellview/client/DefaultHeaderCreator.java
M user/src/com/google/gwt/user/cellview/client/HeaderCreator.java

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Modifying DefaultHeaderCreator to support null sorting indicator images. Until a recent change,... (issue1533803)


committed as r10586

http://gwt-code-reviews.appspot.com/1533803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10587 committed - Adding a test case that verifies CellTable works even if all image res...


Revision: 10587
Author:   gwt.mirror...@gmail.com
Date: Fri Aug 26 09:55:44 2011
Log:  Adding a test case that verifies CellTable works even if all  
image resources are null.  Sort icons are only used if a column is sorted  
(sorting will cause an NPE). Background icons are used in the default  
styles, and are optional. The sorting icon is specially handled to allow  
for null.


Review at http://gwt-code-reviews.appspot.com/1534803

Review by: eschoeff...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10587

Modified:
 /trunk/user/test/com/google/gwt/user/cellview/client/CellTableTest.java

===
--- /trunk/user/test/com/google/gwt/user/cellview/client/CellTableTest.java	 
Fri Aug 26 09:38:28 2011
+++ /trunk/user/test/com/google/gwt/user/cellview/client/CellTableTest.java	 
Fri Aug 26 09:55:44 2011

@@ -207,6 +207,59 @@
   public ImageResource cellTableSelectedBackground() {
 return defaultRes.cellTableSelectedBackground();
   }
+
+  @Override
+  public ImageResource cellTableSortAscending() {
+return null;
+  }
+
+  @Override
+  public ImageResource cellTableSortDescending() {
+return null;
+  }
+
+  @Override
+  public Style cellTableStyle() {
+return defaultRes.cellTableStyle();
+  }
+};
+
+CellTableString table = new CellTableString(10, resources);
+populateData(table);
+table.getPresenter().flush();
+  }
+
+  /**
+   * CellTable should not throw any errors if all of the icons are null.
+   *
+   * Sort icons are only used if a column is sorted. Background icons are  
not
+   * used in the default styles, and are optional. The sorting icon is  
specially

+   * handled.
+   */
+  public void testNullIcons() {
+// Create a Resources instance that does not include sort images.
+CellTable.Resources resources = new CellTable.Resources() {
+  private final CellTable.Resources defaultRes =  
GWT.create(CellTable.Resources.class);

+
+  @Override
+  public ImageResource cellTableFooterBackground() {
+return null;
+  }
+
+  @Override
+  public ImageResource cellTableHeaderBackground() {
+return null;
+  }
+
+  @Override
+  public ImageResource cellTableLoading() {
+return null;
+  }
+
+  @Override
+  public ImageResource cellTableSelectedBackground() {
+return null;
+  }

   @Override
   public ImageResource cellTableSortAscending() {

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a test case that verifies CellTable works even if all image resources are null. Sort ico... (issue1534803)


committed as r10587

http://gwt-code-reviews.appspot.com/1534803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Integrating Peng's recent API changes to CellTableBuilder into HeaderCreator. HeaderCreator now... (issue1533804)

2011-08-26 Thread rjrjr


LGTM

No strong feelings on the new names.


http://gwt-code-reviews.appspot.com/1533804/diff/1/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
File user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
(right):

http://gwt-code-reviews.appspot.com/1533804/diff/1/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java#newcode1610
user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java:1610:
* Get the thead element that contains the headers.
'ark at 'im!

http://gwt-code-reviews.appspot.com/1533804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10588 committed - Properly sets FLAG32BIT in Darwin Xulrunner 6.0