Restrict PopupPanel glass size?

2013-01-14 Thread Richard
I'm trying out the PopupPanel.setGlassEnabled() functionality. So far, it 
seems to grey out the whole screen irrespective of what I do.

Is there a way I can get it to hide only one widget, or one part of the 
screen?  I'd prefer to grey out just the part that is changing, and leave 
the user with the rest so they can still manipulate the app.  I've tried 
setting the location, setting the z-order of widgets above that of the 
glass panel. No dice (yet).

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/Clynd9IYL3sJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Restrict PopupPanel glass size?

2013-01-14 Thread Richard
Aha, I might have it. Just throw out all the PopupPanel stuff, and add the 
transparent style directly to the widget that I want greyed out.  If I hit 
issues I'll just mirror whatever the PopupPanel internal code does.

On Monday, January 14, 2013 1:01:51 PM UTC+2, Richard wrote:

 I'm trying out the PopupPanel.setGlassEnabled() functionality. So far, it 
 seems to grey out the whole screen irrespective of what I do.

 Is there a way I can get it to hide only one widget, or one part of the 
 screen?  I'd prefer to grey out just the part that is changing, and leave 
 the user with the rest so they can still manipulate the app.  I've tried 
 setting the location, setting the z-order of widgets above that of the 
 glass panel. No dice (yet).


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/NtuEhM79hOMJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Force refresh of a CellTree?

2013-01-14 Thread Alex opn
Have you called yourDataProvider.refresh() after the value change?

Also the second answer from here could help: 
http://stackoverflow.com/questions/7239960/programatically-refresh-a-gwt-celltree

Am Sonntag, 13. Januar 2013 18:52:08 UTC+1 schrieb membersound:

 ListDataProvider.




-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/WwKYEIHmYTIJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Chrome 24 and GWT

2013-01-14 Thread John V Denley
Yup, same problem for me at www.DiaryBooker.com/demo - click any 
appointment location to create a new appointment and you see it right 
there! 

This has actually happened before and a few updates later it had gone away 
again!

I'm not sure what version of GWT is currently live, but my current 
development version is not showing this issue, trouble is I am halfway 
through a massive update, so cant make any changes to the current live 
version and Im getting complaints from my customers I have had to tell 
them to use Internet Explorer while we wait for Google to fix it!!

On Thursday, 10 January 2013 23:08:25 UTC, Paul wrote:

 This morning Google updated Chrome to version 24.  Now all my GWT 
 (animated) dialogs flash when opened.  They continuously open/close and 
 give a flashing effect.  I can't access the buttons to close them and have 
 to kill the browser window to stop it.  Confirmed on linux mint (13) and 
 Windoze 7 versions of Chrome.  I had another linux box that I did not allow 
 to update, and confirmed that Chrome 23 (and previous) does not do this. 
  I've seen one other person complain of this on the Chrome forum.  Just 
 thought everyone should know!

 Paul



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/e-OyQG0OojoJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Chrome 24 and GWT

2013-01-14 Thread John V Denley
Any idea how I can fix this/workaround this in a currently live product, 
that I am unable to recompile/redeploy? Can I set something in chrome to 
stop it happening or revert back to an older version?

On Sunday, 13 January 2013 22:12:20 UTC, Craig Mitchell wrote:

 Thanks Andy!  Your workaround works great!

 +1 for not happy with Google!  GWT 2.4 is supposed to be the stable build! 
  We've been deferring going to GWT 2.5 because we wanted the stability.

 Summary for workaround is to add the following to your .gwt.xml file:

 !-- TEMP FIX UNTIL GOING TO GWT 2.5 --
 !-- Fallback implementation, based on a timer --
 replace-with 
 class=com.google.gwt.animation.client.AnimationSchedulerImplTimer
   when-type-is 
 class=com.google.gwt.animation.client.AnimationScheduler/
   any
 when-property-is name=user.agent value=ie6/
 when-property-is name=user.agent value=ie8/
 when-property-is name=user.agent value=ie9/
 when-property-is name=user.agent value=safari/
 when-property-is name=user.agent value=opera/
   /any
 /replace-with

 !-- Implementation based on mozRequestAnimationFrame --
 replace-with 
 class=com.google.gwt.animation.client.AnimationSchedulerImplMozilla
   when-type-is 
 class=com.google.gwt.animation.client.AnimationScheduler/
   when-property-is name=user.agent value=gecko1_8/
 /replace-with
 !-- * END * --



 On Saturday, January 12, 2013 5:20:20 AM UTC+11, Andy wrote:

 I posted the workaround that we're using to the chromium issue thread: 
 http://code.google.com/p/chromium/issues/detail?id=158910

 We have 100s of customers with servers deployed behind firewalls so this 
 is going to be ugly.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/QctnmlGYQYkJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Chrome 24 and GWT

2013-01-14 Thread Samyem Tuladhar
Switch to Firefox!

On Monday, January 14, 2013 8:55:55 AM UTC-5, John V Denley wrote:

 Any idea how I can fix this/workaround this in a currently live product, 
 that I am unable to recompile/redeploy? Can I set something in chrome to 
 stop it happening or revert back to an older version?

 On Sunday, 13 January 2013 22:12:20 UTC, Craig Mitchell wrote:

 Thanks Andy!  Your workaround works great!

 +1 for not happy with Google!  GWT 2.4 is supposed to be the stable 
 build!  We've been deferring going to GWT 2.5 because we wanted the 
 stability.

 Summary for workaround is to add the following to your .gwt.xml file:

 !-- TEMP FIX UNTIL GOING TO GWT 2.5 --
 !-- Fallback implementation, based on a timer --
 replace-with 
 class=com.google.gwt.animation.client.AnimationSchedulerImplTimer
   when-type-is 
 class=com.google.gwt.animation.client.AnimationScheduler/
   any
 when-property-is name=user.agent value=ie6/
 when-property-is name=user.agent value=ie8/
 when-property-is name=user.agent value=ie9/
 when-property-is name=user.agent value=safari/
 when-property-is name=user.agent value=opera/
   /any
 /replace-with

 !-- Implementation based on mozRequestAnimationFrame --
 replace-with 
 class=com.google.gwt.animation.client.AnimationSchedulerImplMozilla
   when-type-is 
 class=com.google.gwt.animation.client.AnimationScheduler/
   when-property-is name=user.agent value=gecko1_8/
 /replace-with
 !-- * END * --



 On Saturday, January 12, 2013 5:20:20 AM UTC+11, Andy wrote:

 I posted the workaround that we're using to the chromium issue thread: 
 http://code.google.com/p/chromium/issues/detail?id=158910

 We have 100s of customers with servers deployed behind firewalls so this 
 is going to be ugly.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/CdbWZEG99j8J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Scroll a CellTree if expanded?

2013-01-14 Thread membersound
Hi,

I have a CellTree with few root items and each having a lot of childs. When 
I expand a node, I can click show more, which will then expand the rest 
of the data invisible down below.
I'm not getting any scrolling controls. Only thing I can do is tap down 
with the keyboard.

How can I add a ScrollPanel / scrolling ability to a expanded CellTree if 
data goes beyond the Panel borders?

Thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/KqxOLBboPl0J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Force refresh of a CellTree?

2013-01-14 Thread membersound
Ok I now created a HashMapMyItem, ListDataProviderMyItem for holding a 
reference to all subItems, and the key is the parent item.

And for each refresh I first detect the subItem, get its parent, retrieve 
the subDataProvider from the HashMap using the parent, and then forcing 
the.refresh()on that particular subdata.

I feel that's lots of boilerplate, but could not find another way...

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/na3D87FxWz8J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: RequestFactory Could not parse payload: payload[0] = N

2013-01-14 Thread Nick Siderakis
Hey Sydney, I've been seeing the same error message recently. Did you 
figure it out?


On Saturday, July 28, 2012 3:46:00 PM UTC-4, Sydney wrote:

 After deploying my app on appengine, I get the following exception: 

 com.google.web.bindery.requestfactory.server.RequestFactoryServlet doPost: 
 Unexpected error
 java.lang.RuntimeException: Could not parse payload: payload[0] = N
 at 
 com.google.web.bindery.autobean.vm.impl.JsonSplittable.create(JsonSplittable.java:70)
 at 
 com.google.web.bindery.autobean.shared.impl.StringQuoter.create(StringQuoter.java:46)
 at 
 com.google.web.bindery.autobean.shared.ValueCodex$Type$7.encode(ValueCodex.java:122)
 at 
 com.google.web.bindery.autobean.shared.ValueCodex.encode(ValueCodex.java:315)
 at 
 com.google.web.bindery.autobean.shared.impl.AutoBeanCodexImpl$ValueCoder.extractSplittable(AutoBeanCodexImpl.java:500)
 at 
 com.google.web.bindery.autobean.shared.impl.AbstractAutoBean.setProperty(AbstractAutoBean.java:277)
 at 
 com.google.web.bindery.autobean.vm.impl.ProxyAutoBean.setProperty(ProxyAutoBean.java:253)
 at 
 com.google.web.bindery.autobean.vm.impl.BeanPropertyContext.set(BeanPropertyContext.java:44)
 at 
 com.google.web.bindery.requestfactory.server.Resolver$PropertyResolver.visitValueProperty(Resolver.java:154)
 at 
 com.google.web.bindery.autobean.vm.impl.ProxyAutoBean.traverseProperties(ProxyAutoBean.java:289)
 at 
 com.google.web.bindery.autobean.shared.impl.AbstractAutoBean.traverse(AbstractAutoBean.java:166)
 at 
 com.google.web.bindery.autobean.shared.impl.AbstractAutoBean.accept(AbstractAutoBean.java:101)
 at 
 com.google.web.bindery.requestfactory.server.Resolver.resolveClientValue(Resolver.java:395)
 at 
 com.google.web.bindery.requestfactory.server.SimpleRequestProcessor.processInvocationMessages(SimpleRequestProcessor.java:483)
 at 
 com.google.web.bindery.requestfactory.server.SimpleRequestProcessor.process(SimpleRequestProcessor.java:225)
 at 
 com.google.web.bindery.requestfactory.server.SimpleRequestProcessor.process(SimpleRequestProcessor.java:127)
 at 
 com.google.web.bindery.requestfactory.server.RequestFactoryServlet.doPost(RequestFactoryServlet.java:133)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)

 Any idea of what the exception means? Thanks


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/pc74M_H6jWEJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Chrome 24 and GWT

2013-01-14 Thread Thomas Broyer


On Monday, January 14, 2013 2:53:52 PM UTC+1, John V Denley wrote:

 Yup, same problem for me at www.DiaryBooker.com/demo - click any 
 appointment location to create a new appointment and you see it right 
 there! 

 This has actually happened before and a few updates later it had gone away 
 again!

 I'm not sure what version of GWT is currently live, but my current 
 development version is not showing this issue, trouble is I am halfway 
 through a massive update, so cant make any changes to the current live 
 version


You mean that cannot even create a branch in your SCM from the commit you 
last deployed, apply the workaround and re-deploy? And you didn't plan for 
that eventuality?
 

 and Im getting complaints from my customers I have had to tell them to 
 use Internet Explorer while we wait for Google to fix it!!


You mean while they wait for you to update, right?

I don't get why people get angry here: there was a bug in GWT, it was fixed 
8 months ago in trunk and was released nearly 3 months ago (before users on 
the stable channel of Chrome could even notice). There's an easy workaround 
too for people not ready to update to GWT 2.5.
So what's the problem actually? You didn't test your apps with beta or dev 
versions of your browsers (that gives you 6 to 12 weeks to fix issues 
before your users can notice), you're 3 months late on updating to the 
latest stable release of GWT *and* you cannot deploy an updated version 
(recompiled with the workaround) quickly. You can blame GWT for using a 
beta, though rather stable, API (requestAnimationFrame) to smooth the 
rendering of your app and having made assumptions on the value it received 
as argument and the exact time it'll be called back, but GWT is not the 
only one to blame by an order of magnitude.
The Web is a moving target: browsers update and can break your code as soon 
as you (or the lib you use) a) make assumptions on browsers behaviors, b) 
use beta APIs or c) use hacks or workarounds. When working with web 
technologies (whether it's GWT, jQuery or vanilla JS), it's very important 
to regularly a) test in beta or dev versions of your browsers, b) update to 
the latest release of the libs you use and c) be prepared to re-deploy 
quickly.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/4BmvA88HyfAJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Chrome 24 and GWT

2013-01-14 Thread zarfhunter
Some of us are stuck on GWT 2.4 since the 2.5 release notes make a point of 
saying that they no longer support Chrome Frame for IE. Since we support 
hospitals and large mining corporations that still run IE6, if they don't 
use Chrome Frame, it's practically unusable. (Yes, I know there's half a 
dozen forum posts saying oh actually 2.5 still supports it, but as long 
as the release notes say it officially, management won't allow us to 
upgrade.)

I think the bigger point people here are making is that *Google* Chrome 
made a radically change that made the *Google* Web Toolkit to break. No 
backwards compatibility whatsoever. Even when Microsoft's Internet Explorer 
browser changed their rendering engines, etc, they still included the 
'Compatibility Mode' so that older webpages could be rendered correctly. 

On Monday, January 14, 2013 9:26:19 AM UTC-7, Thomas Broyer wrote:


 You mean while they wait for you to update, right?

 I don't get why people get angry here: there was a bug in GWT, it was 
 fixed 8 months ago in trunk and was released nearly 3 months ago (before 
 users on the stable channel of Chrome could even notice). There's an easy 
 workaround too for people not ready to update to GWT 2.5. 

So what's the problem actually? You didn't test your apps with beta or dev 
 versions of your browsers (that gives you 6 to 12 weeks to fix issues 
 before your users can notice), you're 3 months late on updating to the 
 latest stable release of GWT *and* you cannot deploy an updated version 
 (recompiled with the workaround) quickly. You can blame GWT for using a 
 beta, though rather stable, API (requestAnimationFrame) to smooth the 
 rendering of your app and having made assumptions on the value it received 
 as argument and the exact time it'll be called back, but GWT is not the 
 only one to blame by an order of magnitude.



Perhaps you have the resources to fully regression test all of your 
applications every week on all 8 or 9 different supported browsers, plus 
dev/beta versions, but in the real world of enterprise software, that's 
simply not feasible. Stable software should remain stable. If a customer 
upgrades his version of Windows, I shouldn't expect the new version to 
suddenly start working strangely because of a radical change in how 
animations are rendered. A similar concept should apply for web browsers.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/O7y-MTGqdRoJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Chrome 24 and GWT

2013-01-14 Thread Thomas Broyer


On Monday, January 14, 2013 5:43:36 PM UTC+1, zarfh...@gmail.com wrote:

 Some of us are stuck on GWT 2.4 since the 2.5 release notes make a point 
 of saying that they no longer support Chrome Frame for IE.


And it's plain wrong. Unfortunately, it seems to fall through the cracks 
every time we mention it back.
Actually GWT 2.5 *fixes* things re. Chrome 
Frame: https://code.google.com/p/google-web-toolkit/issues/detail?id=6665
 

 Since we support hospitals and large mining corporations that still run 
 IE6, if they don't use Chrome Frame, it's practically unusable. (Yes, I 
 know there's half a dozen forum posts saying oh actually 2.5 still 
 supports it, but as long as the release notes say it officially, 
 management won't allow us to upgrade.)


If you need an official 
statement: 
https://groups.google.com/d/topic/google-web-toolkit-contributors/wzilCaLySCU/discussion
 
rdayal and unnurg are former GWT team members at Google.
I'll ping the GWT team to get it fixed for real asap.

BTW, you can maybe tell your management that ChromeFrame has never been 
officially supported by GWT either?

Finally, I'd have preferred that you kept bugging us (or Google actually, 
since only Google can update the GWT web site) about updating the release 
notes rather than come complaining about this Chrome/GWT non-issue.
 

 I think the bigger point people here are making is that *Google* Chrome 
 made a radically change that made the *Google* Web Toolkit to break.


It broke the broken GWT 2.4. 

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/G0TewCKLBl8J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Chrome 24 and GWT

2013-01-14 Thread Thomas Broyer
Release notes updated to remove the bogus bullet point. You can now proceed to 
update to 2.5.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/zsLk9nEVK0oJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT app crashing on iOS 6

2013-01-14 Thread mkn
Hi

Could you solve your problem in the meantime?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/7k89_Qu4jloJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Errors running builder 'Google WebApp Project Validator' on project 'cobra-war'.

2013-01-14 Thread Sudar
Hi, I'm getting this error Errors running builder 'Google WebApp Project 
Validator' on project 'cobra-war'. when try to build a project using ant 
from eclipse. Can any one please help me how to resolve?

Thanks
Sudar

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/PMckw6Q47rYJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Chrome 24 and GWT

2013-01-14 Thread Craig Mitchell
Re:  +1 for not happy with Google!  GWT 2.4 is supposed to be the stable 
build!  We've been deferring going to GWT 2.5 because we wanted the 
stability.

Apologise to Google for this comment.  I thought GWT 2.5 was still a 
release candidate.  I normally get a notification in Eclipse telling me 
that a new version of GWT is available, for whatever reason, it didn't 
happen for this release.

We will update to GWT 2.5 ASAP!  And apologies again for not realising GWT 
2.5 had been released.

Cheers.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/JW2MCXB7XEsJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Errors running builder 'Google WebApp Project Validator' on project 'cobra-war'.

2013-01-14 Thread Jens
A first step would be to find the actual errors in eclipse (maybe in 
eclipse's error log) and then post them here. 

-- J.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/jW90Ke2FPjsJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Chrome 24 and GWT

2013-01-14 Thread John V Denley
Yes Thomas, you are quite correct on two very good points, firstly that my 
customers are technically waiting for ME to upgrade to 2.5 and secondly 
that I SHOULD have been using an SCM and/or should have been taking regular 
backups... thats TOTALLY on me..

I have grown organically and was not even aware of how to use an SCM when I 
started development back in 2009, its been a learning experience the whole 
way through, and the reason I chose GWT as a development platform was so 
that I would not have to worry about testing against all the possible 
browser options. (Yes it quickly became obvious that Google do not take ALL 
the cross browser pain away!)

I actually dropped my pc (attached to my backup device, while backing up 
and managed to destroy both beyond recovery - I spend over £500 trying to 
recover the data) 

I am working through the process of rebuilding the product since my last 
cloud backup in April 2012, but that was built in GWT2.4. So yes, I cant 
branch my SCM (didnt have one) and I didnt plan for that eventuality. I am 
NOW using GIT and BitBucket and SugarSync, DropBox and Google Drive to back 
EVERYTHING up constantly!

I relied too heavily on Google taking care of all browser compatibility and 
I didn't fully comprehend the dangers of not being absolutely meticulous... 
totally my fault on those two issues, but still its annoying that an 
automatic update to Chrome has broken my application. Sure, I should be 
able to  fix and be agile and maneuver  but currently I'm not, so I am 
stuck in the short them having to ask my customers to go use firefox or 
safari or god forbid even IE (v8 at least!!)


On Monday, 14 January 2013 16:26:19 UTC, Thomas Broyer wrote:



 On Monday, January 14, 2013 2:53:52 PM UTC+1, John V Denley wrote:

 Yup, same problem for me at www.DiaryBooker.com/demo - click any 
 appointment location to create a new appointment and you see it right 
 there! 

 This has actually happened before and a few updates later it had gone 
 away again!

 I'm not sure what version of GWT is currently live, but my current 
 development version is not showing this issue, trouble is I am halfway 
 through a massive update, so cant make any changes to the current live 
 version


 You mean that cannot even create a branch in your SCM from the commit you 
 last deployed, apply the workaround and re-deploy? And you didn't plan for 
 that eventuality?
  

 and Im getting complaints from my customers I have had to tell them 
 to use Internet Explorer while we wait for Google to fix it!!


 You mean while they wait for you to update, right?

 I don't get why people get angry here: there was a bug in GWT, it was 
 fixed 8 months ago in trunk and was released nearly 3 months ago (before 
 users on the stable channel of Chrome could even notice). There's an easy 
 workaround too for people not ready to update to GWT 2.5.
 So what's the problem actually? You didn't test your apps with beta or dev 
 versions of your browsers (that gives you 6 to 12 weeks to fix issues 
 before your users can notice), you're 3 months late on updating to the 
 latest stable release of GWT *and* you cannot deploy an updated version 
 (recompiled with the workaround) quickly. You can blame GWT for using a 
 beta, though rather stable, API (requestAnimationFrame) to smooth the 
 rendering of your app and having made assumptions on the value it received 
 as argument and the exact time it'll be called back, but GWT is not the 
 only one to blame by an order of magnitude.
 The Web is a moving target: browsers update and can break your code as 
 soon as you (or the lib you use) a) make assumptions on browsers behaviors, 
 b) use beta APIs or c) use hacks or workarounds. When working with web 
 technologies (whether it's GWT, jQuery or vanilla JS), it's very important 
 to regularly a) test in beta or dev versions of your browsers, b) update to 
 the latest release of the libs you use and c) be prepared to re-deploy 
 quickly.


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/bPZf01ykJbgJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Chrome 24 and GWT

2013-01-14 Thread John V Denley
Yes I have had to send an email to all my customers telling them to 
temporarily switch to firefox, safari or IEv8+

On Monday, 14 January 2013 14:02:25 UTC, Samyem Tuladhar wrote:

 Switch to Firefox!

 On Monday, January 14, 2013 8:55:55 AM UTC-5, John V Denley wrote:

 Any idea how I can fix this/workaround this in a currently live product, 
 that I am unable to recompile/redeploy? Can I set something in chrome to 
 stop it happening or revert back to an older version?

 On Sunday, 13 January 2013 22:12:20 UTC, Craig Mitchell wrote:

 Thanks Andy!  Your workaround works great!

 +1 for not happy with Google!  GWT 2.4 is supposed to be the stable 
 build!  We've been deferring going to GWT 2.5 because we wanted the 
 stability.

 Summary for workaround is to add the following to your .gwt.xml file:

 !-- TEMP FIX UNTIL GOING TO GWT 2.5 --
 !-- Fallback implementation, based on a timer --
 replace-with 
 class=com.google.gwt.animation.client.AnimationSchedulerImplTimer
   when-type-is 
 class=com.google.gwt.animation.client.AnimationScheduler/
   any
 when-property-is name=user.agent value=ie6/
 when-property-is name=user.agent value=ie8/
 when-property-is name=user.agent value=ie9/
 when-property-is name=user.agent value=safari/
 when-property-is name=user.agent value=opera/
   /any
 /replace-with

 !-- Implementation based on mozRequestAnimationFrame --
 replace-with 
 class=com.google.gwt.animation.client.AnimationSchedulerImplMozilla
   when-type-is 
 class=com.google.gwt.animation.client.AnimationScheduler/
   when-property-is name=user.agent value=gecko1_8/
 /replace-with
 !-- * END * --



 On Saturday, January 12, 2013 5:20:20 AM UTC+11, Andy wrote:

 I posted the workaround that we're using to the chromium issue thread: 
 http://code.google.com/p/chromium/issues/detail?id=158910

 We have 100s of customers with servers deployed behind firewalls so 
 this is going to be ugly.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/qNjcQHPHr4kJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



IE10 support in Gwt

2013-01-14 Thread Erik Sapir
Hello,

Are there any plans to support compilation to IE10 in GWT?
If there are such plans, when should it happen?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/ezLqrnYe0gsJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Hi suggestion needed....

2013-01-14 Thread nalini . kar
I am new to GWT... and building a prototype for a company

1.Should I stick to MVP pattern? Or without that pattern is also advisable? 
I feel that without that pattern is not a bad design as the project 
creation itself splits up into client and server code...

2.Which method of UI build is better.. with GWT widgets with Java code or 
with GWT tags using UiBinder..?



Regards,
Nalini.K

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/jOWW_uLTo24J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: SuperDev Mode Java files are not sent to the browser

2013-01-14 Thread emurmur
Unfortunately, I'm just now experiencing the same thing.  It started 
happening immediately after I update to Chrome 25.  It's not clear yet that 
Chrome 25 is the issue.  Here is what I did;

1) I was in Chrome 23, happily using code server for compiling and source 
maps and chrome dev tools for debuggging.
2) I wanted to try the new speech features in Chrome 25, so installed the 
beta, the restarted chrome (while eclipse and code server were running).
3) I opened up the html file again.  I made some changed to my source and 
compiled it in chrome using the code server bookmark. It compiled 
correctly, but only javascript source was available.  The compiler output 
shows the source maps are enabled.  I checked the chrome dev tools setting 
and they indicate source maps are still enabled in chrome.
4) I then did a bunch of stuff in various combinations,refreshing the page, 
clearing the cache, restarting chrome, restarting code server, doing full 
GWT compile then starting code servers, etc.  Still no source maps.

So, I'm not sure if it was the upgrading of the browser, or restarting the 
browser while code server was running.  I'll continue to work on this and 
let you know what I find.  If you figure this out, please reply and let me 
know what you found.  Thanks much.

Ed


On Sunday, January 13, 2013 1:06:24 AM UTC-8, ustakraharez wrote:

 Dear All,

 I have a strange problem with SuperDev mode. Sometimes it sends the java 
 files to the browser, sometimes (and sadly more times :-)) it don't.

 - SuperDev mode run configuration set, and working.
 - Superdev mode url working
 - Bookmarks are working, and when I hit Dev Mode On, compiling working 
 (console logged in Eclipse)
 - But here, nothing happens. When I follow the modulename url from the 
 browser, I can see the compiled source files, but when I open Chrome Web 
 tools, on Sources (and Profiling) tabs only the cache.js can be seen. 
 Source Maps enabled in Chrome of course.

 I also aware, that if source maps working properly, the *[WARN] : Source 
 maps sent for module : moduleName* can be seen in Eclipse logs. I only 
 don't understand, what is the reason why it is sometimes working and more 
 times not.

 Thanks a lot for your help!


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/SkUDxNvgPU4J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: SuperDev Mode Java files are not sent to the browser

2013-01-14 Thread Paul Stockley
I think the issue could be related to this:

https://gwt-review.googlesource.com/#/c/1300/1

On Monday, January 14, 2013 7:46:26 PM UTC-5, emurmur wrote:

 Unfortunately, I'm just now experiencing the same thing.  It started 
 happening immediately after I update to Chrome 25.  It's not clear yet that 
 Chrome 25 is the issue.  Here is what I did;

 1) I was in Chrome 23, happily using code server for compiling and source 
 maps and chrome dev tools for debuggging.
 2) I wanted to try the new speech features in Chrome 25, so installed the 
 beta, the restarted chrome (while eclipse and code server were running).
 3) I opened up the html file again.  I made some changed to my source and 
 compiled it in chrome using the code server bookmark. It compiled 
 correctly, but only javascript source was available.  The compiler output 
 shows the source maps are enabled.  I checked the chrome dev tools setting 
 and they indicate source maps are still enabled in chrome.
 4) I then did a bunch of stuff in various combinations,refreshing the 
 page, clearing the cache, restarting chrome, restarting code server, doing 
 full GWT compile then starting code servers, etc.  Still no source maps.

 So, I'm not sure if it was the upgrading of the browser, or restarting the 
 browser while code server was running.  I'll continue to work on this and 
 let you know what I find.  If you figure this out, please reply and let me 
 know what you found.  Thanks much.

 Ed


 On Sunday, January 13, 2013 1:06:24 AM UTC-8, ustakraharez wrote:

 Dear All,

 I have a strange problem with SuperDev mode. Sometimes it sends the java 
 files to the browser, sometimes (and sadly more times :-)) it don't.

 - SuperDev mode run configuration set, and working.
 - Superdev mode url working
 - Bookmarks are working, and when I hit Dev Mode On, compiling working 
 (console logged in Eclipse)
 - But here, nothing happens. When I follow the modulename url from the 
 browser, I can see the compiled source files, but when I open Chrome Web 
 tools, on Sources (and Profiling) tabs only the cache.js can be seen. 
 Source Maps enabled in Chrome of course.

 I also aware, that if source maps working properly, the *[WARN] : Source 
 maps sent for module : moduleName* can be seen in Eclipse logs. I only 
 don't understand, what is the reason why it is sometimes working and more 
 times not.

 Thanks a lot for your help!



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/FALdHOwn5NsJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Chrome 24 and GWT

2013-01-14 Thread Thomas Broyer
Sorry, didn't see that part of your mail:

On Monday, January 14, 2013 5:43:36 PM UTC+1, zarfh...@gmail.com wrote:


 Perhaps you have the resources to fully regression test all of your 
 applications every week on all 8 or 9 different supported browsers, plus 
 dev/beta versions, but in the real world of enterprise software, that's 
 simply not feasible.


I don't have those resources, but I'm aware that it's what I should do.
It's actually even worse: I'm paid to build webapps, not maintaining them. 
We're not proactive on browser changes because that's not part of the deal 
with our customers, but we're generally in the situation of shipping a 
fixed version (provided there's an easy fix or workaround) in a matter of 
hours. Once the warranty period is over however, I bet nobody does testing 
either and fixes can take ages.
BTW, I also know there *are* people in the real world of enterprise 
software who *do* end-to-end testing, either using Selenium/WebDriver on a 
cluster of servers, or using SaaS such as Sauce Labs, driven by a CI server 
(Jenkins/Hudson, TeamCity, Bamboo, etc.) to be run on each commit and/or 
nightly.

The root of the issue is that most people (IT deps mostly) ask for webapps 
rather than native apps (generally to replace native apps) for bad reasons 
and/or without understanding the consequences.
 

 Stable software should remain stable. If a customer upgrades his version 
 of Windows, I shouldn't expect the new version to suddenly start working 
 strangely because of a radical change in how animations are rendered. A 
 similar concept should apply for web browsers.


ROTFL!
Are you talking about that Windows OS that breaks its WebDAV support in 
almost every new version or service pack, and even sometimes hotfixes? 
http://www.greenbytes.de/tech/webdav/webdav-redirector-list.html (I had to 
do an emergency patch in a server after the SP1 was deployed on Win7 this 
fall; BTW the webapp is 4 years old 'cause nobody allocated the budget to 
maintain and update it, not even with security fixes: “if it ain't broke, 
don't fix it”, BS; this is the state of software in the real world of 
enterprise software: zombie servers on a drip of emergency fixes to keep 
them alive)
The one OS for which every IT department delays hotfix/SP deployment by 
fear of breaking their payroll or LoB apps? (which is probably the main 
reason there's still so many IE7 and IE8 out there –last year I would even 
have added IE6 to the list–).

But again, we're talking here about a bug in GWT, in the use of a beta 
API. And that bug was fixed long before the change in Chrome reached end 
users.
Also note that in a closed environment (intranet) running Windows, you can 
disable Chrome and/or ChromeFrame auto-updates using a group policy.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/TrXgVE-yio0J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: SuperDev Mode Java files are not sent to the browser

2013-01-14 Thread emurmur
That makes sense.  I just uninstalled Chrome 25 and installed latest Chrome 
(24) and still have the issue.  I probably need to back up to 23, which is 
what I had this morning when everything worked.  Thanks for finding that.

Ed


On Monday, January 14, 2013 5:16:13 PM UTC-8, Paul Stockley wrote:

 I think the issue could be related to this:

 https://gwt-review.googlesource.com/#/c/1300/1

 On Monday, January 14, 2013 7:46:26 PM UTC-5, emurmur wrote:

 Unfortunately, I'm just now experiencing the same thing.  It started 
 happening immediately after I update to Chrome 25.  It's not clear yet that 
 Chrome 25 is the issue.  Here is what I did;

 1) I was in Chrome 23, happily using code server for compiling and source 
 maps and chrome dev tools for debuggging.
 2) I wanted to try the new speech features in Chrome 25, so installed the 
 beta, the restarted chrome (while eclipse and code server were running).
 3) I opened up the html file again.  I made some changed to my source and 
 compiled it in chrome using the code server bookmark. It compiled 
 correctly, but only javascript source was available.  The compiler output 
 shows the source maps are enabled.  I checked the chrome dev tools setting 
 and they indicate source maps are still enabled in chrome.
 4) I then did a bunch of stuff in various combinations,refreshing the 
 page, clearing the cache, restarting chrome, restarting code server, doing 
 full GWT compile then starting code servers, etc.  Still no source maps.

 So, I'm not sure if it was the upgrading of the browser, or restarting 
 the browser while code server was running.  I'll continue to work on this 
 and let you know what I find.  If you figure this out, please reply and let 
 me know what you found.  Thanks much.

 Ed


 On Sunday, January 13, 2013 1:06:24 AM UTC-8, ustakraharez wrote:

 Dear All,

 I have a strange problem with SuperDev mode. Sometimes it sends the java 
 files to the browser, sometimes (and sadly more times :-)) it don't.

 - SuperDev mode run configuration set, and working.
 - Superdev mode url working
 - Bookmarks are working, and when I hit Dev Mode On, compiling working 
 (console logged in Eclipse)
 - But here, nothing happens. When I follow the modulename url from the 
 browser, I can see the compiled source files, but when I open Chrome Web 
 tools, on Sources (and Profiling) tabs only the cache.js can be seen. 
 Source Maps enabled in Chrome of course.

 I also aware, that if source maps working properly, the *[WARN] : 
 Source maps sent for module : moduleName* can be seen in Eclipse logs. 
 I only don't understand, what is the reason why it is sometimes working and 
 more times not.

 Thanks a lot for your help!



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/il6xSyKpqBQJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: IE10 support in Gwt

2013-01-14 Thread Thomas Broyer


On Monday, January 14, 2013 9:43:48 PM UTC+1, Erik Sapir wrote:

 Hello,

 Are there any plans to support compilation to IE10 in GWT?


Yes.
 

 If there are such plans, when should it happen?


I'm not aware of anyone working on it (which doesn't necessarily mean 
nobody is working on it currently); so no ETA yet.
We're preparing the 2.5.1 release and we'll start building a roadmap (with 
versions, not necessarily dates) for the future versions.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/Lb6irf0aY0MJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: SuperDev Mode Java files are not sent to the browser

2013-01-14 Thread emurmur
Well, I'm not sure how to rollback to Chrome 23.  I tried updating my GWT 
plugin and SDK to latest (SDK 2.5.0 from 12/12/12 I think), but no dice. 
 Now I'm really stuck.  I depend on code server and chrome dev tools.  Code 
server was supposed to be the way to avoid issues with browser upgrades. 
 Does anyone from the GWT team have a suggestion?  Is anyone out there 
successfully using Chrome 24/25 and Code Server and Source Maps?  Thanks 
for your help.

Ed


On Monday, January 14, 2013 5:23:02 PM UTC-8, emurmur wrote:

 That makes sense.  I just uninstalled Chrome 25 and installed latest 
 Chrome (24) and still have the issue.  I probably need to back up to 23, 
 which is what I had this morning when everything worked.  Thanks for 
 finding that.

 Ed


 On Monday, January 14, 2013 5:16:13 PM UTC-8, Paul Stockley wrote:

 I think the issue could be related to this:

 https://gwt-review.googlesource.com/#/c/1300/1

 On Monday, January 14, 2013 7:46:26 PM UTC-5, emurmur wrote:

 Unfortunately, I'm just now experiencing the same thing.  It started 
 happening immediately after I update to Chrome 25.  It's not clear yet that 
 Chrome 25 is the issue.  Here is what I did;

 1) I was in Chrome 23, happily using code server for compiling and 
 source maps and chrome dev tools for debuggging.
 2) I wanted to try the new speech features in Chrome 25, so installed 
 the beta, the restarted chrome (while eclipse and code server were running).
 3) I opened up the html file again.  I made some changed to my source 
 and compiled it in chrome using the code server bookmark. It compiled 
 correctly, but only javascript source was available.  The compiler output 
 shows the source maps are enabled.  I checked the chrome dev tools setting 
 and they indicate source maps are still enabled in chrome.
 4) I then did a bunch of stuff in various combinations,refreshing the 
 page, clearing the cache, restarting chrome, restarting code server, doing 
 full GWT compile then starting code servers, etc.  Still no source maps.

 So, I'm not sure if it was the upgrading of the browser, or restarting 
 the browser while code server was running.  I'll continue to work on this 
 and let you know what I find.  If you figure this out, please reply and let 
 me know what you found.  Thanks much.

 Ed


 On Sunday, January 13, 2013 1:06:24 AM UTC-8, ustakraharez wrote:

 Dear All,

 I have a strange problem with SuperDev mode. Sometimes it sends the 
 java files to the browser, sometimes (and sadly more times :-)) it don't.

 - SuperDev mode run configuration set, and working.
 - Superdev mode url working
 - Bookmarks are working, and when I hit Dev Mode On, compiling working 
 (console logged in Eclipse)
 - But here, nothing happens. When I follow the modulename url from the 
 browser, I can see the compiled source files, but when I open Chrome Web 
 tools, on Sources (and Profiling) tabs only the cache.js can be seen. 
 Source Maps enabled in Chrome of course.

 I also aware, that if source maps working properly, the *[WARN] : 
 Source maps sent for module : moduleName* can be seen in Eclipse logs. 
 I only don't understand, what is the reason why it is sometimes working 
 and 
 more times not.

 Thanks a lot for your help!



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/-h3Z_oXSSe8J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: SuperDev Mode Java files are not sent to the browser

2013-01-14 Thread Thomas Broyer
We'll release 2.5.1 in the coming weeks, and it will have the fix. If you 
really need it, then either patch your GWT 2.5.0 or build GWT from trunk 
(we'll cut 2.5.1 from trunk)

On Tuesday, January 15, 2013 3:14:06 AM UTC+1, emurmur wrote:

 Well, I'm not sure how to rollback to Chrome 23.  I tried updating my GWT 
 plugin and SDK to latest (SDK 2.5.0 from 12/12/12 I think), but no dice. 
  Now I'm really stuck.  I depend on code server and chrome dev tools.  Code 
 server was supposed to be the way to avoid issues with browser upgrades. 
  Does anyone from the GWT team have a suggestion?  Is anyone out there 
 successfully using Chrome 24/25 and Code Server and Source Maps?  Thanks 
 for your help.

 Ed


 On Monday, January 14, 2013 5:23:02 PM UTC-8, emurmur wrote:

 That makes sense.  I just uninstalled Chrome 25 and installed latest 
 Chrome (24) and still have the issue.  I probably need to back up to 23, 
 which is what I had this morning when everything worked.  Thanks for 
 finding that.

 Ed


 On Monday, January 14, 2013 5:16:13 PM UTC-8, Paul Stockley wrote:

 I think the issue could be related to this:

 https://gwt-review.googlesource.com/#/c/1300/1

 On Monday, January 14, 2013 7:46:26 PM UTC-5, emurmur wrote:

 Unfortunately, I'm just now experiencing the same thing.  It started 
 happening immediately after I update to Chrome 25.  It's not clear yet 
 that 
 Chrome 25 is the issue.  Here is what I did;

 1) I was in Chrome 23, happily using code server for compiling and 
 source maps and chrome dev tools for debuggging.
 2) I wanted to try the new speech features in Chrome 25, so installed 
 the beta, the restarted chrome (while eclipse and code server were 
 running).
 3) I opened up the html file again.  I made some changed to my source 
 and compiled it in chrome using the code server bookmark. It compiled 
 correctly, but only javascript source was available.  The compiler output 
 shows the source maps are enabled.  I checked the chrome dev tools setting 
 and they indicate source maps are still enabled in chrome.
 4) I then did a bunch of stuff in various combinations,refreshing the 
 page, clearing the cache, restarting chrome, restarting code server, doing 
 full GWT compile then starting code servers, etc.  Still no source maps.

 So, I'm not sure if it was the upgrading of the browser, or restarting 
 the browser while code server was running.  I'll continue to work on this 
 and let you know what I find.  If you figure this out, please reply and 
 let 
 me know what you found.  Thanks much.

 Ed


 On Sunday, January 13, 2013 1:06:24 AM UTC-8, ustakraharez wrote:

 Dear All,

 I have a strange problem with SuperDev mode. Sometimes it sends the 
 java files to the browser, sometimes (and sadly more times :-)) it don't.

 - SuperDev mode run configuration set, and working.
 - Superdev mode url working
 - Bookmarks are working, and when I hit Dev Mode On, compiling working 
 (console logged in Eclipse)
 - But here, nothing happens. When I follow the modulename url from the 
 browser, I can see the compiled source files, but when I open Chrome Web 
 tools, on Sources (and Profiling) tabs only the cache.js can be seen. 
 Source Maps enabled in Chrome of course.

 I also aware, that if source maps working properly, the *[WARN] : 
 Source maps sent for module : moduleName* can be seen in Eclipse 
 logs. I only don't understand, what is the reason why it is sometimes 
 working and more times not.

 Thanks a lot for your help!



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/ljeW_XNcY-8J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: SuperDev Mode Java files are not sent to the browser

2013-01-14 Thread emurmur
Looks like it is fixed in SDK 2.5.1, which is not yet released; 
http://code.google.com/p/google-web-toolkit/issues/detail?id=7725q=sourcemapscolspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Stars
There is no 2.5.1RC available yet.  Does anyone know when that may appear? 
 Anyone have a process for rolling back to Chrome 23?

Ed

On Monday, January 14, 2013 6:14:06 PM UTC-8, emurmur wrote:

 Well, I'm not sure how to rollback to Chrome 23.  I tried updating my GWT 
 plugin and SDK to latest (SDK 2.5.0 from 12/12/12 I think), but no dice. 
  Now I'm really stuck.  I depend on code server and chrome dev tools.  Code 
 server was supposed to be the way to avoid issues with browser upgrades. 
  Does anyone from the GWT team have a suggestion?  Is anyone out there 
 successfully using Chrome 24/25 and Code Server and Source Maps?  Thanks 
 for your help.

 Ed


 On Monday, January 14, 2013 5:23:02 PM UTC-8, emurmur wrote:

 That makes sense.  I just uninstalled Chrome 25 and installed latest 
 Chrome (24) and still have the issue.  I probably need to back up to 23, 
 which is what I had this morning when everything worked.  Thanks for 
 finding that.

 Ed


 On Monday, January 14, 2013 5:16:13 PM UTC-8, Paul Stockley wrote:

 I think the issue could be related to this:

 https://gwt-review.googlesource.com/#/c/1300/1

 On Monday, January 14, 2013 7:46:26 PM UTC-5, emurmur wrote:

 Unfortunately, I'm just now experiencing the same thing.  It started 
 happening immediately after I update to Chrome 25.  It's not clear yet 
 that 
 Chrome 25 is the issue.  Here is what I did;

 1) I was in Chrome 23, happily using code server for compiling and 
 source maps and chrome dev tools for debuggging.
 2) I wanted to try the new speech features in Chrome 25, so installed 
 the beta, the restarted chrome (while eclipse and code server were 
 running).
 3) I opened up the html file again.  I made some changed to my source 
 and compiled it in chrome using the code server bookmark. It compiled 
 correctly, but only javascript source was available.  The compiler output 
 shows the source maps are enabled.  I checked the chrome dev tools setting 
 and they indicate source maps are still enabled in chrome.
 4) I then did a bunch of stuff in various combinations,refreshing the 
 page, clearing the cache, restarting chrome, restarting code server, doing 
 full GWT compile then starting code servers, etc.  Still no source maps.

 So, I'm not sure if it was the upgrading of the browser, or restarting 
 the browser while code server was running.  I'll continue to work on this 
 and let you know what I find.  If you figure this out, please reply and 
 let 
 me know what you found.  Thanks much.

 Ed


 On Sunday, January 13, 2013 1:06:24 AM UTC-8, ustakraharez wrote:

 Dear All,

 I have a strange problem with SuperDev mode. Sometimes it sends the 
 java files to the browser, sometimes (and sadly more times :-)) it don't.

 - SuperDev mode run configuration set, and working.
 - Superdev mode url working
 - Bookmarks are working, and when I hit Dev Mode On, compiling working 
 (console logged in Eclipse)
 - But here, nothing happens. When I follow the modulename url from the 
 browser, I can see the compiled source files, but when I open Chrome Web 
 tools, on Sources (and Profiling) tabs only the cache.js can be seen. 
 Source Maps enabled in Chrome of course.

 I also aware, that if source maps working properly, the *[WARN] : 
 Source maps sent for module : moduleName* can be seen in Eclipse 
 logs. I only don't understand, what is the reason why it is sometimes 
 working and more times not.

 Thanks a lot for your help!



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/fSjEBbNSUDcJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: SuperDev Mode Java files are not sent to the browser

2013-01-14 Thread emurmur
I think we posted on top of each other.  Thanks for the timetable on 2.5.1. 
 I have not been building from source, so that is a big time-suck for me to 
setup and then patch.  I'll try to rollback to Chrome 23 first.  Thanks 
again.

Ed


On Monday, January 14, 2013 6:23:24 PM UTC-8, Thomas Broyer wrote:

 We'll release 2.5.1 in the coming weeks, and it will have the fix. If you 
 really need it, then either patch your GWT 2.5.0 or build GWT from trunk 
 (we'll cut 2.5.1 from trunk)

 On Tuesday, January 15, 2013 3:14:06 AM UTC+1, emurmur wrote:

 Well, I'm not sure how to rollback to Chrome 23.  I tried updating my GWT 
 plugin and SDK to latest (SDK 2.5.0 from 12/12/12 I think), but no dice. 
  Now I'm really stuck.  I depend on code server and chrome dev tools.  Code 
 server was supposed to be the way to avoid issues with browser upgrades. 
  Does anyone from the GWT team have a suggestion?  Is anyone out there 
 successfully using Chrome 24/25 and Code Server and Source Maps?  Thanks 
 for your help.

 Ed


 On Monday, January 14, 2013 5:23:02 PM UTC-8, emurmur wrote:

 That makes sense.  I just uninstalled Chrome 25 and installed latest 
 Chrome (24) and still have the issue.  I probably need to back up to 23, 
 which is what I had this morning when everything worked.  Thanks for 
 finding that.

 Ed


 On Monday, January 14, 2013 5:16:13 PM UTC-8, Paul Stockley wrote:

 I think the issue could be related to this:

 https://gwt-review.googlesource.com/#/c/1300/1

 On Monday, January 14, 2013 7:46:26 PM UTC-5, emurmur wrote:

 Unfortunately, I'm just now experiencing the same thing.  It started 
 happening immediately after I update to Chrome 25.  It's not clear yet 
 that 
 Chrome 25 is the issue.  Here is what I did;

 1) I was in Chrome 23, happily using code server for compiling and 
 source maps and chrome dev tools for debuggging.
 2) I wanted to try the new speech features in Chrome 25, so installed 
 the beta, the restarted chrome (while eclipse and code server were 
 running).
 3) I opened up the html file again.  I made some changed to my source 
 and compiled it in chrome using the code server bookmark. It compiled 
 correctly, but only javascript source was available.  The compiler output 
 shows the source maps are enabled.  I checked the chrome dev tools 
 setting 
 and they indicate source maps are still enabled in chrome.
 4) I then did a bunch of stuff in various combinations,refreshing the 
 page, clearing the cache, restarting chrome, restarting code server, 
 doing 
 full GWT compile then starting code servers, etc.  Still no source maps.

 So, I'm not sure if it was the upgrading of the browser, or restarting 
 the browser while code server was running.  I'll continue to work on this 
 and let you know what I find.  If you figure this out, please reply and 
 let 
 me know what you found.  Thanks much.

 Ed


 On Sunday, January 13, 2013 1:06:24 AM UTC-8, ustakraharez wrote:

 Dear All,

 I have a strange problem with SuperDev mode. Sometimes it sends the 
 java files to the browser, sometimes (and sadly more times :-)) it don't.

 - SuperDev mode run configuration set, and working.
 - Superdev mode url working
 - Bookmarks are working, and when I hit Dev Mode On, compiling 
 working (console logged in Eclipse)
 - But here, nothing happens. When I follow the modulename url from 
 the browser, I can see the compiled source files, but when I open Chrome 
 Web tools, on Sources (and Profiling) tabs only the cache.js can be 
 seen. 
 Source Maps enabled in Chrome of course.

 I also aware, that if source maps working properly, the *[WARN] : 
 Source maps sent for module : moduleName* can be seen in Eclipse 
 logs. I only don't understand, what is the reason why it is sometimes 
 working and more times not.

 Thanks a lot for your help!



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/2J5YdGJeZvsJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Fwd:

2013-01-14 Thread Sampath Kumar
http://fabbricadeisogni2012.it/z1enr1.php

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: datagrid body is disappeared!! height is zero!!

2013-01-14 Thread tong123123
I see the following link
http://code.google.com/p/google-web-toolkit/issues/detail?can=2start=0num=100q=colspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Starsgroupby=sort=id=7065

and I follow the suggestion to add a SelectionHandler to the 
TabLayoutPanel, but the result is the datagrid scrollbar is not shown. I 
also add the comment to the above link.

I am using GWT 2.4

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/OmjAuqnAJZkJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: datagrid body is disappeared!! height is zero!!

2013-01-14 Thread ashwin.desi...@gmail.com
do you place your grid directly on the layoutPanel or is it inside other
panels like HTMLPanel etc?

I have had similar issues with loosing the size of the panel, In my case
since I was using absolute positioning, I forced position of my grid on
code to over come the issue.
myGrid.getElement().getStyle().setPosition(Position.ABSOLUTE);

Regards
Ashwin


On Tue, Jan 15, 2013 at 12:37 PM, tong123123 tong123...@gmail.com wrote:

 I see the following link

 http://code.google.com/p/google-web-toolkit/issues/detail?can=2start=0num=100q=colspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Starsgroupby=sort=id=7065

 and I follow the suggestion to add a SelectionHandler to the
 TabLayoutPanel, but the result is the datagrid scrollbar is not shown. I
 also add the comment to the above link.

 I am using GWT 2.4

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To view this discussion on the web visit
 https://groups.google.com/d/msg/google-web-toolkit/-/OmjAuqnAJZkJ.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



onbeforeunload / onWindfowClosing only if the user leaves the page

2013-01-14 Thread Dominic Warzok
Hello, 

I have a little problem with my webapp. I want to log out the user if he 
leaves the page. 

So I tried it with onWindowClosing but this method is also called, if the 
user reload the page. 

Is there a way to get information if the user leave or reload the page ? 


Thanks Dominic  

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/lFN7Q64xHDYJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: SuperDev Mode Java files are not sent to the browser

2013-01-14 Thread ustakraharez
Dear All,

For me, if is a big help already, that I'm not completely crazy :-)

Thanks a lot, and waiting for the fixed release.

Best:
Gabor

2013. január 15., kedd 3:28:01 UTC+1 időpontban emurmur a következőt írta:

 I think we posted on top of each other.  Thanks for the timetable on 
 2.5.1.  I have not been building from source, so that is a big time-suck 
 for me to setup and then patch.  I'll try to rollback to Chrome 23 first. 
  Thanks again.

 Ed


 On Monday, January 14, 2013 6:23:24 PM UTC-8, Thomas Broyer wrote:

 We'll release 2.5.1 in the coming weeks, and it will have the fix. If you 
 really need it, then either patch your GWT 2.5.0 or build GWT from trunk 
 (we'll cut 2.5.1 from trunk)

 On Tuesday, January 15, 2013 3:14:06 AM UTC+1, emurmur wrote:

 Well, I'm not sure how to rollback to Chrome 23.  I tried updating my 
 GWT plugin and SDK to latest (SDK 2.5.0 from 12/12/12 I think), but no 
 dice.  Now I'm really stuck.  I depend on code server and chrome dev tools. 
  Code server was supposed to be the way to avoid issues with browser 
 upgrades.  Does anyone from the GWT team have a suggestion?  Is anyone out 
 there successfully using Chrome 24/25 and Code Server and Source Maps? 
  Thanks for your help.

 Ed


 On Monday, January 14, 2013 5:23:02 PM UTC-8, emurmur wrote:

 That makes sense.  I just uninstalled Chrome 25 and installed latest 
 Chrome (24) and still have the issue.  I probably need to back up to 23, 
 which is what I had this morning when everything worked.  Thanks for 
 finding that.

 Ed


 On Monday, January 14, 2013 5:16:13 PM UTC-8, Paul Stockley wrote:

 I think the issue could be related to this:

 https://gwt-review.googlesource.com/#/c/1300/1

 On Monday, January 14, 2013 7:46:26 PM UTC-5, emurmur wrote:

 Unfortunately, I'm just now experiencing the same thing.  It started 
 happening immediately after I update to Chrome 25.  It's not clear yet 
 that 
 Chrome 25 is the issue.  Here is what I did;

 1) I was in Chrome 23, happily using code server for compiling and 
 source maps and chrome dev tools for debuggging.
 2) I wanted to try the new speech features in Chrome 25, so installed 
 the beta, the restarted chrome (while eclipse and code server were 
 running).
 3) I opened up the html file again.  I made some changed to my source 
 and compiled it in chrome using the code server bookmark. It compiled 
 correctly, but only javascript source was available.  The compiler 
 output 
 shows the source maps are enabled.  I checked the chrome dev tools 
 setting 
 and they indicate source maps are still enabled in chrome.
 4) I then did a bunch of stuff in various combinations,refreshing the 
 page, clearing the cache, restarting chrome, restarting code server, 
 doing 
 full GWT compile then starting code servers, etc.  Still no source maps.

 So, I'm not sure if it was the upgrading of the browser, or 
 restarting the browser while code server was running.  I'll continue to 
 work on this and let you know what I find.  If you figure this out, 
 please 
 reply and let me know what you found.  Thanks much.

 Ed


 On Sunday, January 13, 2013 1:06:24 AM UTC-8, ustakraharez wrote:

 Dear All,

 I have a strange problem with SuperDev mode. Sometimes it sends the 
 java files to the browser, sometimes (and sadly more times :-)) it 
 don't.

 - SuperDev mode run configuration set, and working.
 - Superdev mode url working
 - Bookmarks are working, and when I hit Dev Mode On, compiling 
 working (console logged in Eclipse)
 - But here, nothing happens. When I follow the modulename url from 
 the browser, I can see the compiled source files, but when I open 
 Chrome 
 Web tools, on Sources (and Profiling) tabs only the cache.js can be 
 seen. 
 Source Maps enabled in Chrome of course.

 I also aware, that if source maps working properly, the *[WARN] : 
 Source maps sent for module : moduleName* can be seen in Eclipse 
 logs. I only don't understand, what is the reason why it is sometimes 
 working and more times not.

 Thanks a lot for your help!



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/uNvXigxq8wUJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: datagrid body is disappeared!! height is zero!!

2013-01-14 Thread tong123123
DataGrid inside a FlexTable which is then inside a DockLayoutPanel.
it seem it is a bug of DataGrid inside a DockLayoutPanel as mentioned in 
http://code.google.com/p/google-web-toolkit/issues/detail?can=2start=0num=100q=colspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Starsgroupby=sort=id=7065
but the provided workaround (add a selectionHandler in TabLayoutPanel and 
then redraw the DataGrid) is not worked properly, the scrollbar inside the 
DataGrid is not shown.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/1zTaWe9wARQJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



[gwt-contrib] Developing a new remote RunStyle for PhantomJS

2013-01-14 Thread Maik Riechert
Hi all,

As htmlunit isn't suited for all testing scenarios (in particular layout 
specific ones), I'd like to use PhantomJS as an alternative (production 
mode only). It is a headless webkit engine and can be easily controlled 
with JS files, meaning that the new RunStyle would fork a shell process 
phantomjs pageload.js where pageload.js would be written to disk 
beforehand containing:

var page = require('webpage').create();
var url = 'http://host/gwt...';
page.open(url, function (status) {
  //Page is loaded!
  phantom.exit(); 
});

This is particularly great for CI, in my case Travis CI, as it already has 
phantomjs installed. Is there a way that I can write a new RunStyle class 
and make it available as a kind of plugin? Or do I really have to submit it 
as a patch and hope that it gets included in the official GWT distribution?

Thanks for your support!
Maik

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Developing a new remote RunStyle for PhantomJS

2013-01-14 Thread Matthew Dempsky
You can write your own RunStyle class and then run the JUnit shell with
-runStyle your.fully.qualified.PhantomJSRunStyle.


On Mon, Jan 14, 2013 at 11:59 AM, Maik Riechert 
neothemach...@googlemail.com wrote:

 Hi all,

 As htmlunit isn't suited for all testing scenarios (in particular layout
 specific ones), I'd like to use PhantomJS as an alternative (production
 mode only). It is a headless webkit engine and can be easily controlled
 with JS files, meaning that the new RunStyle would fork a shell process
 phantomjs pageload.js where pageload.js would be written to disk
 beforehand containing:

 var page = require('webpage').create();
 var url = 'http://host/gwt...';
 page.open(url, function (status) {
   //Page is loaded!
   phantom.exit();
 });

 This is particularly great for CI, in my case Travis CI, as it already has
 phantomjs installed. Is there a way that I can write a new RunStyle class
 and make it available as a kind of plugin? Or do I really have to submit it
 as a patch and hope that it gets included in the official GWT distribution?

 Thanks for your support!
 Maik

 --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix issue 6959. (issue1587803)

2013-01-14 Thread goktug

On 2013/01/13 19:28:16, tbroyer wrote:

Ping; would be great to have it in 2.5.1! (IIRC, we initially talked

about

including it in 2.5.0 and finally decided to postpone it to the next

release)

This looks like a breaking change but it is hard for me to guess how
likely it is going to break things. What do you think?

http://gwt-code-reviews.appspot.com/1587803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


Re: [gwt-contrib] Developing a new remote RunStyle for PhantomJS

2013-01-14 Thread Maik Riechert

Ah, great! Someone should document that, at least I didn't find it anywhere.

Am 14.01.2013 21:12, schrieb Matthew Dempsky:
You can write your own RunStyle class and then run the JUnit shell 
with -runStyle your.fully.qualified.PhantomJSRunStyle.



On Mon, Jan 14, 2013 at 11:59 AM, Maik Riechert 
neothemach...@googlemail.com mailto:neothemach...@googlemail.com 
wrote:


Hi all,

As htmlunit isn't suited for all testing scenarios (in particular
layout specific ones), I'd like to use PhantomJS as an alternative
(production mode only). It is a headless webkit engine and can be
easily controlled with JS files, meaning that the new RunStyle
would fork a shell process phantomjs pageload.js where
pageload.js would be written to disk beforehand containing:

var page = require('webpage').create();
var url = 'http://host/gwt...';
page.open(url, function (status) {
  //Page is loaded!
  phantom.exit();
});

This is particularly great for CI, in my case Travis CI, as it
already has phantomjs installed. Is there a way that I can write a
new RunStyle class and make it available as a kind of plugin? Or
do I really have to submit it as a patch and hope that it gets
included in the official GWT distribution?

Thanks for your support!
Maik
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors 


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Developing a new remote RunStyle for PhantomJS

2013-01-14 Thread Matthew Dempsky
Technically, it's documented in JUnitShell's -help information for
-runStyle:

  return Selects the runstyle to use for this test.  The name
is   + a suffix of com.google.gwt.junit.RunStyle or is a
fully   + qualified class name, and may be followed with
a colon and   + an argument for this runstyle.  The
specified class must  + extend RunStyle.;


But admittedly that's pretty hidden since users don't really directly pass
command-line options to JUnitShell. Suggestions welcome on where to add a
note to this effect.



On Mon, Jan 14, 2013 at 12:42 PM, Maik Riechert 
neothemach...@googlemail.com wrote:

  Ah, great! Someone should document that, at least I didn't find it
 anywhere.

 Am 14.01.2013 21:12, schrieb Matthew Dempsky:

  You can write your own RunStyle class and then run the JUnit shell with
 -runStyle your.fully.qualified.PhantomJSRunStyle.


 On Mon, Jan 14, 2013 at 11:59 AM, Maik Riechert 
 neothemach...@googlemail.com wrote:

 Hi all,

 As htmlunit isn't suited for all testing scenarios (in particular layout
 specific ones), I'd like to use PhantomJS as an alternative (production
 mode only). It is a headless webkit engine and can be easily controlled
 with JS files, meaning that the new RunStyle would fork a shell process
 phantomjs pageload.js where pageload.js would be written to disk
 beforehand containing:

 var page = require('webpage').create();
 var url = 'http://host/gwt...';
 page.open(url, function (status) {
   //Page is loaded!
   phantom.exit();
 });

 This is particularly great for CI, in my case Travis CI, as it already
 has phantomjs installed. Is there a way that I can write a new RunStyle
 class and make it available as a kind of plugin? Or do I really have to
 submit it as a patch and hope that it gets included in the official GWT
 distribution?

 Thanks for your support!
 Maik
 --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors


  --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors


  --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix issue 6959. (issue1587803)

2013-01-14 Thread skybrian

I'm not all that familiar with the editor framework but perhaps there's
a cleaner way to do this? (See comments.)


http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):

http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java#newcode42
user/src/com/google/gwt/editor/client/adapters/EditorSource.java:42:
public abstract E create(int index);
Instead of using -1 to indicate a synthetic editor, it seems cleaner to
add a new createEditorForTraversal() method. The default implementation
could just call create(0) for backward compatibility, but HasDataEditor
could implement it to either set a flag on IndexedEditor or alternately
use a different subclass altogether.

http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
File user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
(right):

http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode56
user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:56:
((IndexedEditorT) editor).setIndex(index);
assert index =0?

http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode60
user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:60:
static class IndexedEditorQ implements LeafValueEditorQ {
Perhaps IndexedEditor should be private? I see no usages other than in
this class.

http://gwt-code-reviews.appspot.com/1587803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: Takes enum constants into account in types' serialization si...

2013-01-14 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Takes enum constants into account in types' serialization  
signature in RPC

..


Patch Set 2:

(1 comment)


File user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java
Line 877:   Enum?[] constants =  
instanceType.asSubclass(Enum.class).getEnumConstants();

No need to sort here like in SerializationUtils?


--
To view, visit https://gwt-review.googlesource.com/1590
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d7eb618021f0a6d08a2e0ec6fc686e3fd5fc2c1
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: Fixes IE's http status code mangling from 204 to 1223

2013-01-14 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Fixes IE's http status code mangling from 204 to 1223
..


Patch Set 6:

FYI, we had to revert this change because we had some internal unit tests  
that depended on being able to create a mock Request object in server-side  
code.  Changing Request's class-initializer to call GWT.create() caused  
these tests to start failing.


We resubmitted the change with a variation to lazily call GWT.create() so  
that it should only actually get run in strictly client-side code.


Updated commit at  
https://gwt.googlesource.com/gwt/+/593e31fd6ee5205ced66232d18d351182e94244c


--
To view, visit https://gwt-review.googlesource.com/1440
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97b9094ef702cd852cc4d918183b394ffc853c32
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Johannes Barop j...@barop.de
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Johannes Barop j...@barop.de
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: Takes enum constants into account in types' serialization si...

2013-01-14 Thread Brian Slesinsky

Brian Slesinsky has posted comments on this change.

Change subject: Takes enum constants into account in types' serialization  
signature in RPC

..


Patch Set 2:

(1 comment)


File user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java
Line 877:   Enum?[] constants =  
instanceType.asSubclass(Enum.class).getEnumConstants();
java.lang.Class.getEnumConstants() guarantees they're in the order they  
were declared.


http://docs.oracle.com/javase/6/docs/api/java/lang/Class.html#getEnumConstants()


--
To view, visit https://gwt-review.googlesource.com/1590
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d7eb618021f0a6d08a2e0ec6fc686e3fd5fc2c1
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: Takes enum constants into account in types' serialization si...

2013-01-14 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Takes enum constants into account in types' serialization  
signature in RPC

..


Patch Set 2: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/1590
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d7eb618021f0a6d08a2e0ec6fc686e3fd5fc2c1
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Fix issue 6959. (issue1587803)

2013-01-14 Thread t . broyer


http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):

http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java#newcode42
user/src/com/google/gwt/editor/client/adapters/EditorSource.java:42:
public abstract E create(int index);
On 2013/01/14 21:16:49, skybrian wrote:

Instead of using -1 to indicate a synthetic editor, it seems cleaner

to add a

new createEditorForTraversal() method. The default implementation

could just

call create(0) for backward compatibility, but HasDataEditor could

implement it

to either set a flag on IndexedEditor or alternately use a different

subclass

altogether.


Indeed! Why didn't I think of that?!

Thanks Brian, will update the patch soon.

http://gwt-code-reviews.appspot.com/1587803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: use java.net.HttpCookie instead of Crockfords json.org

2013-01-14 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: use java.net.HttpCookie instead of Crockfords json.org
..


Patch Set 2: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/1600
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3568a459f7a196140fa7af5b38850716a71fdd6
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Koch tho...@koch.ro
Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Thomas Koch tho...@koch.ro
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: Fix compiler error for class extending an inner class.

2013-01-14 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Fix compiler error for class extending an inner class.
..


Patch Set 3:

(1 comment)


File user/test/com/google/gwt/dev/jjs/test/InnerClassTest.java
Line 181: assertEquals(o.new ESInner().value, 1);
These are still backwards.


--
To view, visit https://gwt-review.googlesource.com/1690
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1c5ababe332efad7b58b98b85a150b83d659f2
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: Remove mysterious Hack for Google I/O comment.

2013-01-14 Thread Matthew Dempsky

Matthew Dempsky has abandoned this change.

Change subject: Remove mysterious Hack for Google I/O comment.
..


Abandoned

Submitted.

--
To view, visit https://gwt-review.googlesource.com/1710
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I94e1efcab338cf6ffa3879068a302fe04b32c560
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: Takes enum constants into account in types' serialization si...

2013-01-14 Thread Brian Slesinsky

Brian Slesinsky has abandoned this change.

Change subject: Takes enum constants into account in types' serialization  
signature in RPC

..


Abandoned

Internally submitted.

--
To view, visit https://gwt-review.googlesource.com/1590
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2d7eb618021f0a6d08a2e0ec6fc686e3fd5fc2c1
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: increased zIndex of compile dialog to avoid it being hidden

2013-01-14 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: increased zIndex of compile dialog to avoid it being hidden
..


Patch Set 1: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/1530
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1a541fc108e0a9087276a3fe104f5ec129e56cf
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Tom Carchrae carch...@gmail.com
Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: Fixes compiler error for class extending an inner class.

2013-01-14 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Fixes compiler error for class extending an inner class.
..


Patch Set 5: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/1690
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1c5ababe332efad7b58b98b85a150b83d659f2
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Developing a new remote RunStyle for PhantomJS

2013-01-14 Thread Thomas Broyer
Note that, while probably not applicable to Travis CI, there's GhostDriver 
(WebDriver for PhantomJS) which should allow you to use the Selenium 
RunStyle to drive PhantomJS.

On Monday, January 14, 2013 8:59:14 PM UTC+1, Maik Riechert wrote:

 Hi all,

 As htmlunit isn't suited for all testing scenarios (in particular layout 
 specific ones), I'd like to use PhantomJS as an alternative (production 
 mode only). It is a headless webkit engine and can be easily controlled 
 with JS files, meaning that the new RunStyle would fork a shell process 
 phantomjs pageload.js where pageload.js would be written to disk 
 beforehand containing:

 var page = require('webpage').create();
 var url = 'http://host/gwt...';
 page.open(url, function (status) {
   //Page is loaded!
   phantom.exit(); 
 });

 This is particularly great for CI, in my case Travis CI, as it already has 
 phantomjs installed. Is there a way that I can write a new RunStyle class 
 and make it available as a kind of plugin? Or do I really have to submit it 
 as a patch and hope that it gets included in the official GWT distribution?

 Thanks for your support!
 Maik


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Devmode broken with elemental (#7481) (issue1801804)

2013-01-14 Thread mdempsky


http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java
File core/src/com/google/gwt/dev/shell/DispatchClassInfo.java (right):

http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java#newcode86
core/src/com/google/gwt/dev/shell/DispatchClassInfo.java:86: Integer id
= memberIdByMember.get(m);
Is this a very heavily used function and/or does memberBy[Member]Id get
very large normally?  If not, would it be simpler to just do:

  int id = memberById.indexOf(m);
  if (id == -1) {
id = memberById.size();
memberById.add(m);
  }
  memberIdByName.put(StringInterner.get().intern(name), id);

http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java#newcode90
core/src/com/google/gwt/dev/shell/DispatchClassInfo.java:90:
memberIdByName.put(StringInterner.get().intern(name), id);
I know this was preexisting practice, but why are we interning strings
here?  It doesn't seem to serve any purpose except to use use
interned-strings storage.

http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java#newcode237
core/src/com/google/gwt/dev/shell/DispatchClassInfo.java:237:
memberByMemberId = new HashMapInteger, Member(32767);
Why 32767?  Won't it size up appropriately, or will the table very
frequently have 32767 members?

http://gwt-code-reviews.appspot.com/1801804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: Issue 7713 - Float/Double parsing of NaN/Infinity

2013-01-14 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity
..


Patch Set 3: Code-Review+1

(1 comment)


File user/super/com/google/gwt/emul/java/lang/Number.java
Line 348
Any idea why this used to be case-insensitive?


--
To view, visit https://gwt-review.googlesource.com/1670
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc14d48df05e2029d4bcc780c77883f07b7f07f4
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: Issue 7713 - Float/Double parsing of NaN/Infinity

2013-01-14 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity
..


Patch Set 3:

(1 comment)


File user/super/com/google/gwt/emul/java/lang/Number.java
Line 348
More precisely, I understand why it needs to be case-sensitive now, but the  
old regex looks like it was already explicitly case-insensitive by using  
[eE] and [dDfF].  Just wondering if there was some reason for still using  
/i then.



--
To view, visit https://gwt-review.googlesource.com/1670
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc14d48df05e2029d4bcc780c77883f07b7f07f4
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: AbstractMap.remove() is incorrect, accessing entry after del...

2013-01-14 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: AbstractMap.remove() is incorrect, accessing entry after  
deletion fixes issue 7856

..


Patch Set 1: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/1740
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d3d92d7aaf13e499c8e12b680ecae66864f8a3a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Devmode broken with elemental (#7481) (issue1801804)

2013-01-14 Thread jat


http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java
File core/src/com/google/gwt/dev/shell/DispatchClassInfo.java (right):

http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java#newcode86
core/src/com/google/gwt/dev/shell/DispatchClassInfo.java:86: Integer id
= memberIdByMember.get(m);
On 2013/01/15 01:38:37, mdempsky wrote:

Is this a very heavily used function and/or does memberBy[Member]Id

get very

large normally?  If not, would it be simpler to just do:



   int id = memberById.indexOf(m);
   if (id == -1) {
 id = memberById.size();
 memberById.add(m);
   }
   memberIdByName.put(StringInterner.get().intern(name), id);


I believe that was essentially the implementation I originally wrote,
and was changed as part of a modification for performance and memory
usage (which is where the StringInterner calls came in).  At the time,
AdWords was having trouble running DevMode in a 32bit JVM.

I wasn't involved in that, but I presume there were lots of duplicate
strings which led to this being a win.

http://gwt-code-reviews.appspot.com/1801804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Fix issue 6959. (issue1587803)

2013-01-14 Thread t . broyer


http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):

http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java#newcode42
user/src/com/google/gwt/editor/client/adapters/EditorSource.java:42:
public abstract E create(int index);
On 2013/01/14 21:16:49, skybrian wrote:

Instead of using -1 to indicate a synthetic editor, it seems cleaner

to add a

new createEditorForTraversal() method. The default implementation

could just

call create(0) for backward compatibility, but HasDataEditor could

implement it

to either set a flag on IndexedEditor or alternately use a different

subclass

altogether.


Done.

http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
File user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
(right):

http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode56
user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:56:
((IndexedEditorT) editor).setIndex(index);
On 2013/01/14 21:16:49, skybrian wrote:

assert index =0?


Done.

http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode60
user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:60:
static class IndexedEditorQ implements LeafValueEditorQ {
On 2013/01/14 21:16:49, skybrian wrote:

Perhaps IndexedEditor should be private? I see no usages other than in

this

class.


Done.

http://gwt-code-reviews.appspot.com/1587803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Change in gwt[master]: Issue 7713 - Float/Double parsing of NaN/Infinity

2013-01-14 Thread Thomas Broyer

Thomas Broyer has posted comments on this change.

Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity
..


Patch Set 3:

(1 comment)


File user/super/com/google/gwt/emul/java/lang/Number.java
Line 348
Most likely an oversight.

https://code.google.com/p/google-web-toolkit/source/detail?r=7344 changes  
an 'e' to [eE] and the commit message talks about now accepting both 'e'  
and 'E' for the exponent, but that was already the case with /i, which was  
retained.
I guess rice and fabbott just didn't see the flag back then (as well as  
everyone who later updated the regexp, including me)



--
To view, visit https://gwt-review.googlesource.com/1670
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc14d48df05e2029d4bcc780c77883f07b7f07f4
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Fix issue 6959. (issue1587803)

2013-01-14 Thread skybrian


http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):

http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/EditorSource.java#newcode60
user/src/com/google/gwt/editor/client/adapters/EditorSource.java:60: *
For backwards compatibility with GWT 2.5.0 and earlier, the default
implemtation calls
sp: implementation

http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
File user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
(right):

http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode44
user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:44:
return new IndexedEditorT(-1, null);
If IndexedEditor's index is -1 then getValue() always returns null and
setValue() probably throws an exception eventually in data.setRowData (I
didn't trace it). It seems like it would be clearer to return an
anonymous subclass of LeafValueEditor that implements getValue() and
setValue() to do this directly? I'm assuming setValue() shouldn't be
called at all, not sure about getValue.

Then dispose() can do an instanceof check and ignore this instance. Or
perhaps keep it in a constant and use ==.

http://gwt-code-reviews.appspot.com/1587803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors