http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java
File user/src/com/google/gwt/editor/client/adapters/EditorSource.java
(right):

http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java#newcode42
user/src/com/google/gwt/editor/client/adapters/EditorSource.java:42:
public abstract E create(int index);
On 2013/01/14 21:16:49, skybrian wrote:
Instead of using -1 to indicate a synthetic editor, it seems cleaner
to add a
new createEditorForTraversal() method. The default implementation
could just
call create(0) for backward compatibility, but HasDataEditor could
implement it
to either set a flag on IndexedEditor or alternately use a different
subclass
altogether.

Indeed! Why didn't I think of that?!

Thanks Brian, will update the patch soon.

http://gwt-code-reviews.appspot.com/1587803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to