Hover Functionality

2013-04-05 Thread bongy_Cabs
Hi,

I extend a gwt celltable to create a custom celltable, i register the 
sinkevents ie onmouseover/onmouseout.
when you hover on the row of the table the row data is populated on the 
hover widget(custom hover popup panel).
its works as it supose to do on development mode but once deployed on 
tomcat when you move the mouse over different rows on the celltable it
does not update the hover data on the popup panel unless you click away 
from the table(loose focus) and the hover again on the row.



Thanks,
Bongy


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Error in Totoe XML Parser.

2013-04-05 Thread Harald Pehl
Why do you setup namespaces? Your XML does not seem to use them?

- Harald

Am Donnerstag, 4. April 2013 19:54:04 UTC+2 schrieb skippy:

 This code works fine for me in IE but fails in Firefox. 
 I get the error Bad format on namespace decleration(s) given. 

 String namespaces = xmlns:default=\http://code.google.com/p/totoe\; 
 + xmlns:Group=\http://code.google.com/p/totoe/Group\; 
  
 + xmlns:Item=\http://code.google.com/p/totoe/Item\; ; 

 dataGroupDocument = new XmlParser().parse(dataGroup,namespaces); 

 XML us like this: 
 Group Name=ACCT00305 
   ITEM 
 ACCT000 31MEB0009/ACCT000  
 NAME055 Miss Taylor R Williams/NAME055  
 REMT000 1/REMT000  
 REMT001 BANTMEK/REMT001  
 NAME002 987-00-0082/NAME002  
 REMT027 /REMT027  
 REMT018 /REMT018  
   /ITEM 
 /Group 


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: GWT Designer - MenuBar

2013-04-05 Thread Marco
Yes, this issue has been fixed. 

The fix is in eclipse gwt plugin and not in gwt itself.
You have to update your eclipse plugin.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: How to create deep copy of list on client side?

2013-04-05 Thread Marco
He problem is already described here:

https://groups.google.com/forum/#!msg/google-web-toolkit/Y0bN9QGsspQ/roqeVR7ryhcJ
https://groups.google.com/forum/?fromgroups=#!topic/Google-Web-Toolkit/MvLCaqJ2MBQ

but also with no solution.

GWT-RPC is already serializing and deserializing objects, therefore i 
thought there is a build in support in GWT.

I also contacted Christian Goudreau (steering committee member) but it 
seems that there is really no way.  :-(

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




DialogBox - modify animation time?

2013-04-05 Thread membersound
Hi,

how can I change the animation time of a DialogBox popup? I only found 
methods to enable/disable the animation completely.

Thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: DialogBox - modify animation time?

2013-04-05 Thread Jens
You can't without copying PopupPanel or maybe creating a sub class of it in 
the same com.google.gwt. package so you have access to package private 
ResizeAnimation class.

Alternative could be to disable animation and use CSS3 transitions instead.

-- J.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: How to create deep copy of list on client side?

2013-04-05 Thread membersound
Damn, no solution will cause me do write lot's of boilerplate code for 
cloning objects myself...

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Growl / Notification messages?

2013-04-05 Thread membersound
Hi,

does GWT have any build in Widgets that supply a growl/notification message 
that can be displayed to the user?
(eg: fades in, shows some error text, and fades out again after some 
seconds or on click).

I know I can probably build this myself using PopupPanel, but maybe there 
is already an implementation you know of?

Thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Growl / Notification messages?

2013-04-05 Thread Thomas Broyer
There's NotificationMole. Quite limited but still useful.

On Friday, April 5, 2013 3:30:56 PM UTC+2, membersound wrote:

 Hi,

 does GWT have any build in Widgets that supply a growl/notification 
 message that can be displayed to the user?
 (eg: fades in, shows some error text, and fades out again after some 
 seconds or on click).

 I know I can probably build this myself using PopupPanel, but maybe there 
 is already an implementation you know of?

 Thanks


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: How to create deep copy of list on client side?

2013-04-05 Thread monkeyboy
You could try using https://code.google.com/p/gwt-serialization/
gwt-serialization https://code.google.com/p/gwt-serialization/. If you 
have any questions feel free to ask.

On Wednesday, April 3, 2013 11:55:26 PM UTC+2, membersound wrote:

 Hi,

 how can I (if possible) best create a deep copy of an ArrayList on the 
 client side?
 I just need a list that when objects are changed does not reflect the 
 changes to the source list.

 How could this be done clientside?


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Repainting a canvas - clear or create new object?

2013-04-05 Thread Thad
Without timing this, I can't say for sure. However I 
suspect ctx.clearRect(0, 0, clientWidth(), clientHeight()) is faster as it 
calls clearRect on the JavaScriptObject while creating a new Canvas 
requires the DOM to create a new object.

On Wednesday, April 3, 2013 10:13:34 AM UTC-4, membersound wrote:

 Hi,

 when a Canvas is often cleared and redrawn (for example during a drag and 
 drop action): would it be better to call ctx.clearRect(0, 0, 
 clientWidth(), clientHeight())?
 Or just create a new Canvas by Canvas.createIfSupported() and replace the 
 currently drawn canvas by the new one?

 Thanks


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: PopupPanel.center() not centering content?

2013-04-05 Thread Ed Bras
I tried to isolate it to some GWT-only code, but didn't manage to get it
isolated with the centering problem :( (at least not within some acceptable
time).
I use many own widgets/panels with own resource bundles and style imports.
I removed all the animations, but even when using a simple HeaderPanel (own
widget) with some textboxes I see the centering problem, which consists of
straight forwards div's with no deferred command actions... but still... if
I use s simple FlowPanel with some textboxes it all looks fine :(...
For now, I leave it like this but I am almost sure it's a bug that only
show it's self in some weird situation... Maybe due to using style imports
and using css resources, some style is set a bit too late, I don't know...
For now, my working around works, so I leave it for now.
Thanks,
- Ed



On Sat, Mar 30, 2013 at 2:40 PM, Ed Bras post2edb...@gmail.com wrote:

 I will do, I just have to isolate the code, such that it's useful. I will
 post it here in a few days.


 On Sat, Mar 30, 2013 at 2:34 PM, Jens jens.nehlme...@gmail.com wrote:

 Can you share code for a popup content that reproduces the problem?

 -- J.

 --
 You received this message because you are subscribed to a topic in the
 Google Groups Google Web Toolkit group.
 To unsubscribe from this topic, visit
 https://groups.google.com/d/topic/google-web-toolkit/RWjYAPGq9xw/unsubscribe?hl=en
 .
 To unsubscribe from this group and all its topics, send an email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 Visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.
 For more options, visit https://groups.google.com/groups/opt_out.






-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Hover Functionality

2013-04-05 Thread Michael Prentice
In your dev mode, do you see any errors in the console (might need to send 
a sever request to see it) like this?

[WARN] Server class 'com.x.x.Class' could not be found in the web app, but 
was found on the system classpath
   [WARN] Adding classpath entry 'file:/D:/librarydir/library.jar' to the 
web app classpath for this session
   For additional info see: 
file:/D:/Eclipse_4.2.2/eclipse/plugins/com.google.gwt.eclipse.sdkbundle_2.5.1/gwt-2.5.1/doc/helpInfo/webAppClassPath.html

If so, then you might have a library that is accessible (via GWT fixing 
your classpath for you) in dev mode, but not in production.


On Friday, April 5, 2013 2:46:24 AM UTC-4, bongy_Cabs wrote:

 Hi,

 I extend a gwt celltable to create a custom celltable, i register the 
 sinkevents ie onmouseover/onmouseout.
 when you hover on the row of the table the row data is populated on the 
 hover widget(custom hover popup panel).
 its works as it supose to do on development mode but once deployed on 
 tomcat when you move the mouse over different rows on the celltable it
 does not update the hover data on the popup panel unless you click away 
 from the table(loose focus) and the hover again on the row.



 Thanks,
 Bongy




-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




GWT App -- Firefox 20 regression?

2013-04-05 Thread Geoffrey Wiseman
I hit an issue this afternoon where I have an unexplained issue with a 
select where I can't select any of the options in it, and it seems like the 
handler isn't even being called (or isn't triggering the debugger in 
Eclipse, anyway), in either dev mode or after deployment in regular browser 
usage (including in FF safe mode, which disables all the plugins). This is 
true in FF20, but not in FF19. 

It's only one select out of many in our application, so there are clearly 
complicating circumstances, it's not just select controls don't work in 
FF20/GWT, but it's odd to me that it works in FF19 and doesn't work in 
FF20. Since I don't have any idea of the cause yet, I'm not sounding 
alarms, but I thought I'd put a placeholder in here in case anyone else is 
experiencing a FF19/FF20 regression and is farther along in their analysis 
than I am.


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Problems adding Click Handler to Grid

2013-04-05 Thread Michael Prentice
I just tried this:

grid.addClickHandler(new ClickHandler() {
public void onClick(ClickEvent event) {
System.out.println(Grid Clicked!);
}
});

And it works just fine. 

What Window class are you importing? I just tried it with import 
com.google.gwt.user.client.Window; and it worked fine in dev mode.


On Thursday, April 4, 2013 1:27:43 PM UTC-4, skippy wrote:

 I am using GWT 2,4 if that helps. 


 On Apr 4, 10:35 am, skippy al.leh...@fisglobal.com wrote: 
  I am trying to add a Click Handler to a Grid object, but it never 
  fires. 
  
  tableData.addClickHandler(new ClickHandler() 
  { 
   public void onClick(ClickEvent event) 
   { 
  Window.alert(I am here); 
} 
  
  }); 
  
  Any ideas would be great. 
  
  Thanks 


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




GWT designer in Eclipse Juno

2013-04-05 Thread Rallou Perroti
Hey everybody. I'm having a problem creating a new GWT User Interface with 
window builder in Eclipse Juno. I followed the installation instructions 
and still  get a popup window that says I've got to load additional 
WindowBuilder toolkits everytime I try to create a new project. I click 
finish to install the toolikit as it suggests, and it shows the tools I've 
already successfully downloaded and a Google Plugin for Eclipse 3.7. Am I 
missing something? I didn't encounter any issues during the installation, 
and everything is up to date, so what is it? 

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Suggestions for displaying a list of clickable items

2013-04-05 Thread Anthony Richir
Hi,

In my application, I have to display a list of items in a modal window.
Each item will be made of 3 text zones, a message and 2 dates, and a link, 
which could be a picture, to delete the item. The message should be 
clickable to allow editing in a separate modal.

I need to display almost the same list in a popover but without the links 
and with the message being truncated.

As I'm quite new to GWT and that I'm coming from the Wicket world, I'm a 
little bit confused about how to achieve this.

What would you suggest for my case ?

Thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Vaadin 7 to include GWT

2013-04-05 Thread LPD
Hi,

   What is the specific advantages of using Vaadin over GWT? If even 
the client side logic is written in the server side, wont this be a too 
much of lag specially in cloud based systems?

LPD

On Tuesday, 3 July 2012 13:57:58 UTC+5:30, Joonas Lehtinen wrote:

 As announced at Google IO, the upcoming Vaadin Framework 7 will include 
 GWT as its core component and will be fully compatible with GWT. 
 This way Vaadin will allow user interface development both on the 
 server-side and on the client-side. Server-side development is optimized 
 for productivity with fully automated communications and browser-side. 
 Client-side development gives a full control of rendering and 
 communications to the developer who can still use Java as the programming 
 language. 

 Vaadin 7 release is expected in the beginning of October. The first 
 developer preview version (alpha 3) with GWT built-in was released today.

 More info about this can be found at https://vaadin.com/gwt


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Displaying an image from Couchdb

2013-04-05 Thread jb9845982
I would like to display images stored as attachment in a Couchdb database 
on my website.
 

https://lh4.googleusercontent.com/-q2y6lUrq41Y/UV-CV_q98zI/AAM/499UT50qh_0/s1600/attachment.jpg
I can retrieve the attachment from Couchdb, but I am not sure how 
to display the image received on my website. Here is what I receive when I 
get the attachment on my if what I am receiving make sense.
 
*Response received from Couchdb:*
*00:00:26.928 [INFO] response = �PNG*
* *
* IHDR  ��a gAMA��7 �� tEXtSoftwareAdobe 
ImageReadyq�e �IDAT8�ݑ�N Q �y�y  
-  ��  ��4�@���b*`��Ŧ kK=���$:H �(�)�� 
e.��]/V��^��V�/ U�� C  C�� �g ��f�� ,�o^`�6�`y� 8�0#'n4B��  }�� !Z 
R �� E�Y��4 W� ��1t�+  �*
* ���( +I; ��a���hy@�� V~���S!p���J �J � �`Y7�دz��aK�  *
*�C`�p�@� {� �i w0��#�� �� �  �V �7 ��`3z�}֡.���_ ny�dM$i۶ V֨ �7� 
�� � ��J�A�N�;DW��xr  fO_~ �I7*
*zj1� ET �a* �� ��x.� ;��kj t˓#b �M7�V��Q T��1U 
��4 �Y��[�Ki�g  � џf�0�,��-�  � �{a��P�a�K!�XԠ}��i�Wל�  
��� M m��z%ӗ;=`Z��Uu�I$�_�/��.�p%IEND�B`�* 
 
I have tried to create an Image with this data and add the Image widget to 
an HtmlPanel but it didn't worked. I also tried to setUrl to an existing 
image with the data received from Couchdb but it also failed. 
 
Does anyone know if I need to process the data before trying to display it 
on my website???
 
Thanks 
 

**

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Suggestion for displaying a list of items

2013-04-05 Thread Anthony Richir
Hi,

For my application, I need to display a list of items in a modal window.
Those items are made of 3 text zones, one being a message, clickable to 
open a modal which will edit the item, 2 others being dates and next to 
each item, a clickable cross to delete the item.

I need to achieve almost the same thing in a popover, the difference is 
that there won't be links and that the message will be truncated.

I'm a bit confused with GWT with the way to display lists, I come from 
Wicket and the mechanism seems completely different.
What would you suggest in my case ?

Note: I'm using gwt-bootstrap

Thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: GWT , Highcharts not working

2013-04-05 Thread Andrei-Stefan Ifrim
On a first view JQuery is also needed. 
take a look at step 
3 http://www.moxiegroup.com/moxieapps/gwt-highcharts/quickstart.jsp

script type=text/javascript 
   src=http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js; 
/script
script type=text/javascript src=js/highcharts.js/script

I also got this exception, but in my case it was caused by the fact that 
this js files were not placed in the head of the HTML file.

Best regards!

marți, 24 ianuarie 2012, 21:24:16 UTC+2, junaidp a scris:

 I am trying to run a simple High chart in my GWT Application but getting 
 this error

  '$wnd.Highcharts' is null or not an object

 my OnModule

  public void onModuleLoad() {
   RootPanel.get().add(createChart());  
 }  

 public Chart createChart() {  

 Chart chart = new Chart()
.setType(Series.Type.SPLINE)
.setChartTitleText(Lawn Tunnels)
.setMarginRight(10);
 Series series = chart.createSeries()
.setName(Moles per Yard)
.setPoints(new Number[] { 163, 203, 276, 408, 547, 729, 628 });
 chart.addSeries(series);
 return chart;  
 }  

 }

 my xml

  !-- Inherit the core Web Toolkit stuff.--
 inherits name='com.google.gwt.user.User'/
inherits name=org.moxieapps.gwt.highcharts.Highcharts/

 my HTML

/script
 script type=text/javascript src=js/highcharts.js/script
 script type=text/javascript src=js/themes/dark-blue.js/script
  script type=text/javascript src=js/modules/exporting.js/script

 /script

  included this jar file in my classpath

  org.moxieapps.gwt.highcharts-1.1.3.jar

 Any suggestion

 Thanks


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Allow strong name to be omitted.

2013-04-05 Thread Matthew Dempsky

Matthew Dempsky has abandoned this change.

Change subject: Allow strong name to be omitted.
..


Abandoned

Submitted.

--
To view, visit https://gwt-review.googlesource.com/2420
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie9d4ae13a9fdf188bfacb2caabb0b5b136dc342a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Re: Fixes #8036, properly sorting of places in PlaceHistoryGeneratorContext (issue1895803)

2013-04-05 Thread larsaaslin

Reviewers: tbroyer,

Message:
On 2013/02/26 13:51:10, tbroyer wrote:

LGTM


Is there anything more I should provide regarding this issue, like
additional unit tests, more examples proving the issue, etc?

Description:
Given the following places:

public class A extends Place {

  @Prefix(placeA)
  public static class Tokenizer implements PlaceTokenizerA {
...
  }
}

public class B extends Place {

  @Prefix(placeB)
  public static class Tokenizer implements PlaceTokenizerB {
...
  }
}

public class C extends A {

  @Prefix(placeC)
  public static class Tokenizer implements PlaceTokenizerC {
...
  }
}

... and the following PlaceHistoryMapper definition:

@WithTokenizers({B.Tokenizer.class, A.Tokenizer.class,
C.Tokenizer.class})
interface AppPlaceHistoryMapper extends PlaceHistoryMapper {
};

PlaceHistoryMapper.getToken will return the following tokens for
respective place

A - placeA
B - placeB
C - placeA -- Should be placeC

The reason for this is the way the places are sorted in
PlaceHistoryGeneratorContext, later used in PlaceHistoryMapperGenerator
(line:108) for generating the implementing class. In
PlaceHistoryGeneratorContext, the usage of
MostToLeastDerivedPlaceTypeComparator in conjuction with a TreeMap
creates a possibility for related places to end up in different
branches in the TreeMap. Therefor, the correctness of the sorting
depends on in which order the places are added to the TreeMap, which
depends on in which order the PlaceTokenizers are declared in
@WithTokenizers.

To make MostToLeastDerivedPlaceTypeComparator work properly in
conjuction with a TreeMap the comparission should be done on the depth
of each place's inheritance hierarchy instead of whether they are
assignable to/from each other or not.

Please review this at http://gwt-code-reviews.appspot.com/1895803/

Affected files:
  M  
user/src/com/google/gwt/place/rebind/MostToLeastDerivedPlaceTypeComparator.java
  M  
user/test/com/google/gwt/place/impl/PlaceHistoryMapperGeneratorTest.java



Index:  
user/test/com/google/gwt/place/impl/PlaceHistoryMapperGeneratorTest.java

===
---  
user/test/com/google/gwt/place/impl/PlaceHistoryMapperGeneratorTest.java	 
(revision 11523)
+++  
user/test/com/google/gwt/place/impl/PlaceHistoryMapperGeneratorTest.java	 
(working copy)

@@ -44,6 +44,11 @@
   interface LocalNoFactory extends PlaceHistoryMapper {
   };

+  @WithTokenizers({Tokenizer2.class, Place1.Tokenizer.class,  
Tokenizer3.class,

+  Tokenizer4.class, Place6.Tokenizer.class})
+  interface LocalTokenizersInUnexpectedOrder extends PlaceHistoryMapper {
+  };
+
   @WithTokenizers({Tokenizer4.class, Place6.Tokenizer.class})
   interface LocalWithFactory extends
   PlaceHistoryMapperWithFactoryTokenizerFactory {
@@ -93,7 +98,13 @@

 doTest(subject, null);
   }
+
+  public void testTokenizersInUnexpectedOrder() {
+AbstractPlaceHistoryMapper? subject =  
GWT.create(LocalTokenizersInUnexpectedOrder.class);


+doTest(subject, null);
+  }
+
   public void testNestedWithFactory() {
 AbstractPlaceHistoryMapperTokenizerFactory subject =  
GWT.create(LocalWithFactory.class);

 TokenizerFactory factory = new TokenizerFactory();
Index:  
user/src/com/google/gwt/place/rebind/MostToLeastDerivedPlaceTypeComparator.java

===
---  
user/src/com/google/gwt/place/rebind/MostToLeastDerivedPlaceTypeComparator.java	 
(revision 11523)
+++  
user/src/com/google/gwt/place/rebind/MostToLeastDerivedPlaceTypeComparator.java	 
(working copy)

@@ -29,10 +29,10 @@
 if (o1.equals(o2)) {
   return 0;
 }
-if (o1.isAssignableFrom(o2)) {
+if (o1.getFlattenedSupertypeHierarchy().size()   
o2.getFlattenedSupertypeHierarchy().size()) {

   return 1;
 }
-if (o1.isAssignableTo(o2)) {
+if (o1.getFlattenedSupertypeHierarchy().size()   
o2.getFlattenedSupertypeHierarchy().size()) {

   return -1;
 }
 return  
o1.getQualifiedSourceName().compareTo(o2.getQualifiedSourceName());



--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Avoid implicit inter-dependencies between DOM, History, Wind...

2013-04-05 Thread Matthew Dempsky

Matthew Dempsky has posted comments on this change.

Change subject: Avoid implicit inter-dependencies between DOM, History,  
Window and Widgets through BaseListenerWrapper by moving things to where  
they're used.

..


Patch Set 8: Verified-1

Boo, this patch set FAILED the build and/or checkstyle tests. :(

Build details: http://gwt-ci.dempsky.org:8080/job/gwt.checkstyle/23/

--
To view, visit https://gwt-review.googlesource.com/1241
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44ea5f26c96716879b2a23331cafc26a63644e89
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Removed unnecessary whitespace in JSONObject.toString.

2013-04-05 Thread Daniel Kurka

Daniel Kurka has uploaded a new change for review.

  https://gwt-review.googlesource.com/2430


Change subject: Removed unnecessary whitespace in JSONObject.toString.
..

Removed unnecessary whitespace in JSONObject.toString.

Change-Id: Ie87abe91c1bcc57285a6d749d3a2dd6081daaa9a
---
M user/src/com/google/gwt/json/client/JSONObject.java
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/user/src/com/google/gwt/json/client/JSONObject.java  
b/user/src/com/google/gwt/json/client/JSONObject.java

index 7bc225c..f83b7fa 100644
--- a/user/src/com/google/gwt/json/client/JSONObject.java
+++ b/user/src/com/google/gwt/json/client/JSONObject.java
@@ -176,7 +176,7 @@
   if (first) {
 first = false;
   } else {
-sb.append(, );
+sb.append(,);
   }
   sb.append(JsonUtils.escapeValue(key));
   sb.append(:);

--
To view, visit https://gwt-review.googlesource.com/2430
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie87abe91c1bcc57285a6d749d3a2dd6081daaa9a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka danku...@google.com

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Cut dependency from c.g.g.http on c.g.g.user by no longer us...

2013-04-05 Thread Goktug Gokdogan

Goktug Gokdogan has abandoned this change.

Change subject: Cut dependency from c.g.g.http on c.g.g.user by no longer  
using Timer

..


Abandoned

Submitted.

--
To view, visit https://gwt-review.googlesource.com/1160
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I66217980de084dd27e91d3930034ea03931ffe74
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.