Re: Apache ProxyPass does not return errors, only 500 (Internal Server Error)
I'm using RequestHeader edit X-GWT-Module-Base ^(http)://([^/]+)/(.*)$ $1://$2/babyCenter/$3 and it works. :) Thanks a lot. Dne petek, 19. april 2013 23:39:19 UTC+2 je oseba Thomas Broyer napisala: On Friday, April 19, 2013 9:20:49 AM UTC+2, Gregor Kovač wrote: I have two ProxyPass directives: ProxyPass /client/ http://10.0.0.8:8080/client/Location /client/ RequestHeader edit X-GWT-Module-Base ^(.*)/client/(.*)$ $1/client/$2/Location ProxyPass / http://10.0.0.8:8080/client/Location / RequestHeader edit X-GWT-Module-Base ^(.*)/(.*)$ $1/client/$2/Location 10.0.0.8 is running Glassfish on port 8080 and http://10.0.0.8:8080/client/ is URL to a GWT based application. Both proxy's work OK ,except when it comes to an error on the Glassfish side. If I go via /cllient/ proxy then I see the actual error that was produced on the Glassfish side. If I go via / proxy then I only see Error 500 The call failed on the server, please see server log. I've tried settingProxyErrorOverride Off, but it didn't help. Why don't I see the error via / proxy? I think that the X-GWT-Module-Base header gets edited wrong. This apache configuration is done by https://code.google.com/p/google-web-toolkit/issues/detail?id=4817#c4 Assuming X-GWT-Module-Base contains http://myserver/foo/bar, there's no reason it wouldn't be rewritten as http:/client//myserver/foo/bar, http://client/myserver/foo/bar or http://myserver/foo/client/bar instead of the http://myserver/client/foo/bar you're expecting. You have to rework your regexp. Maybe mapping something like ^(https?)://([^/]+)/(.*)$ to $1://$2/client/$3 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
is jsPDF required flash player
I want to generate pdf at client side so I want achieve this using jspdf http://jspdf.com/ . when I create sample , it is working fine in chrome but not in Mozilla and ie 10. I have one doubt that is this required flash player to generate pdf? My system does not having flash player. if it required flash player, it is not usefull me. is there any other way to produce pdf using client script? Thanks in advance. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
The app is not loading in Safari?
When I test the compiled application in Safari (on Windows 7 AND Max OSX) it hangs and only displays a white blank page, and Safari hangs on loading. In the developer-tools in Safari, nothing seems to be downloaded under the Network tab. It works in Firefox, Chrome, IE 8, IE 9 without no problem. Someone had a similar problem or any idea what the problem might be? I'm using gwt-2.5.1. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: How to execute periodic timers on the server side GAE?
This is not a GWT question so you better check for info herehttps://groups.google.com/forum/?fromgroups=#!forum/google-appengine. I can suggest to read thishttps://developers.google.com/appengine/docs/java/config/cron?hl=en . On Friday, April 26, 2013 9:09:15 PM UTC+2, membersound wrote: Hi, how can I schedule a periodic timer (every X minutes) on the serverside? I have a ScheduledExecutorService, but discovered that I cannot use this on GAE serverside. Is there any possibility to create a schedule task that just runs in the background, without having to trigger it explicit from the client side? Thnx -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Re-deployment on appengine sometimes breaks GWT app (Module.Cache.html not found)
Yes, changing the version is the best way. GAE seems to fail its uploads fairly regularly in my experience. Just use a build number along with your version, upload, smoke test to verify it is working, and then mark as current version in the GAE console. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: is jsPDF required flash player
What you are looking for I think is https://github.com/mozilla/pdf.js jspdf generetes PDF, not render it. On Monday, April 29, 2013 2:40:57 AM UTC-4, Bhumika Thaker wrote: I want to generate pdf at client side so I want achieve this using jspdf http://jspdf.com/ . when I create sample , it is working fine in chrome but not in Mozilla and ie 10. I have one doubt that is this required flash player to generate pdf? My system does not having flash player. if it required flash player, it is not usefull me. is there any other way to produce pdf using client script? Thanks in advance. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: is jsPDF required flash player
On Monday, April 29, 2013 8:40:57 AM UTC+2, Bhumika Thaker wrote: I want to generate pdf at client side so I want achieve this using jspdf http://jspdf.com/ . when I create sample , it is working fine in chrome but not in Mozilla and ie 10. I have one doubt that is this required flash player to generate pdf? My system does not having flash player. if it required flash player, it is not usefull me. is there any other way to produce pdf using client script? The web site says Flash is only needed for IE 9 and below. But I actually wonder how this is related to GWT… -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
GWT Image editing
Hi all, I’m using GWT 2.5.1, and I’m trying to create a component that allows the application user to edit an image, the workflow is: 1. User can perform a mouse click on a certain part of the image “A” (that was previously uploaded); 2. This event will put in the image clicked coordinates (X and Y) another image “B”, the final image “C” (“A” + “B”) can then be saved. Can anyone give me some feedback about what will be the best approach to do this? Many thanks, Luis. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Cannot read property java_lang_Object_typeMarker$ of null
Hey guys! I hope that you could shed some light on my current issue I'm having. I use GWT 2.5.1 and I've noticed that some of my code works in hosted mode but when I compile it if throws exception in subject: *Cannot read property java_lang_Object_typeMarker$ of null* * * The scenario is next: - Fetch necessary data from database (using OpenJPA hydration) - Remove proxies from objects (serialize/deserialize) - Send response back If I create new objects instead in my server controller (and not fetch them from DB) everything seems to work just fine. But the moment I decide to use DB data it starts to act weird. The really weird part is that is works in hosted mode (as I said above) both ways. Googling for this issue didn't do much good because, as it seems, it's really rare problem and no solution was found. Hope you could give me some hint about this issue. Thanks! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: The app is not loading in Safari?
Are you certain you did not disable the permutation for Safari ? I made that mistake multiple times already :-) David On Mon, Apr 29, 2013 at 1:27 PM, Fille filip.lin...@gmail.com wrote: When I test the compiled application in Safari (on Windows 7 AND Max OSX) it hangs and only displays a white blank page, and Safari hangs on loading. In the developer-tools in Safari, nothing seems to be downloaded under the Network tab. It works in Firefox, Chrome, IE 8, IE 9 without no problem. Someone had a similar problem or any idea what the problem might be? I'm using gwt-2.5.1. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory
If I remove the scopeprovided/scope it is still not going in the WEB-INF/lib. But should it, maven doesn't know about putting it there... If I add the jar file to the classpath of the run configuration the problem is still there.. The reason why it is provided is that I use JBoss that has the jar file. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory
On Monday, April 29, 2013 5:50:30 PM UTC+2, Kris wrote: If I remove the scopeprovided/scope it is still not going in the WEB-INF/lib. But should it, maven doesn't know about putting it there... The maven-war-plugin's war mojo (called by default in the package phase when packaging=war) will put it there. If I add the jar file to the classpath of the run configuration the problem is still there.. The reason why it is provided is that I use JBoss that has the jar file. Then use JBoss for your dev, and run the DevMode in -noserver mode. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Unable to read from byte cache
Hi, I get this in dev mode en eclipse Juno, get 2.5.1 java.util.concurrent.ExecutionException: java.lang.RuntimeException: Unable to read from byte cache at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:252) at java.util.concurrent.FutureTask.get(FutureTask.java:111) at com.google.gwt.dev.javac.PersistentUnitCache.awaitUnitCacheMapLoad(PersistentUnitCache.java:466) at com.google.gwt.dev.javac.PersistentUnitCache.find(PersistentUnitCache.java:391) at com.google.gwt.dev.javac.CompilationStateBuilder.addArchive(CompilationStateBuilder.java:365) at com.google.gwt.dev.ArchivePreloader.preloadArchives(ArchivePreloader.java:65) at com.google.gwt.dev.DevModeBase$UiBrowserWidgetHostImpl.createModuleSpaceHost(DevModeBase.java:106) at com.google.gwt.dev.shell.OophmSessionHandler.loadModule(OophmSessionHandler.java:197) at com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:526) at com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:364) at java.lang.Thread.run(Thread.java:722) Caused by: java.lang.RuntimeException: Unable to read from byte cache at com.google.gwt.dev.util.DiskCache.transferFromStream(DiskCache.java:171) at com.google.gwt.dev.util.DiskCacheToken.readObject(DiskCacheToken.java:87) at sun.reflect.GeneratedMethodAccessor3.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1004) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1872) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1777) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1347) at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1970) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1894) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1777) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1347) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:369) at java.util.ArrayList.readObject(ArrayList.java:733) at sun.reflect.GeneratedMethodAccessor1.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1004) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1872) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1777) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1347) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:369) at com.google.gwt.dev.javac.CachedCompilationUnit.readObject(CachedCompilationUnit.java:205) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1004) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1872) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1777) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1347) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:369) at com.google.gwt.dev.javac.PersistentUnitCache.loadUnitMap(PersistentUnitCache.java:517) at com.google.gwt.dev.javac.PersistentUnitCache.access$800(PersistentUnitCache.java:96) at com.google.gwt.dev.javac.PersistentUnitCache$4.run(PersistentUnitCache.java:222) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) ... 1 more Caused by: java.io.StreamCorruptedException: unexpected EOF in middle of data block at java.io.ObjectInputStream$BlockDataInputStream.refill(ObjectInputStream.java:2518) at java.io.ObjectInputStream$BlockDataInputStream.read(ObjectInputStream.java:2681) at java.io.ObjectInputStream.read(ObjectInputStream.java:862) at java.io.InputStream.read(InputStream.java:101) at com.google.gwt.dev.util.DiskCache.transferFromStream(DiskCache.java:159) I did delete the unit cache, recompile... etc. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit
Re: Determining if user is using a tablet
On 04/28/2013 12:31 PM, bvt wrote: Does anybody have any advice on how to determine whether somebody is using a tablet to access my GWT application? If I understand https://code.google.com/p/google-web-toolkit/issues/detail?id=4911 correctly, it would appear that GWT 2.5.1 supports only CSS2 media queries, which don't seem particularly useful in this regard. I'd like to adjust spacing of items to make selection easier for tablet users, but compact items on small screens. -- There are a variety of Javascript solutions out there that effectively return the results of CSS3's min/max width. They can be adopted to GWT without too much trouble. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Chrome plugin
In the 2.51. there was a note about the plugin being available from the Chrome Store. It is there but is disabled. Is there plugin for Chrome going to be made available anytime soon? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Smartgwt - layout - setimage
Hey! I put on the surface of a VLayout and was a HLayout cent. I copied the project-em \ war \ images \ icons directory containing a file-hatter.jpg. After that, I would have the following method to this picture layout on display, but the following error message is shown: HLayout: isc_HLayout_0: setImage: image 'hatter' could not be found I do not see why you can not find ... Thanks in advance, Csaba -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
showing byteArray as image in DialogBox
hi, I would like to know how or if it is possible to show a camera image in aGWT DialogBox?! There is a running thread, shooting an image every 100 ms. I want the DailogBox to refresh the image everytime. The method that is in charge of showing the image returns a byte array! I am aware of the setRGB(..) Method but I never worked with it. At the moment the Dialogbox showas an image, saved on my disk and shows it by relating to the relative path of it. Is it possible to overwrite this path everxy 100ms so that I have only 1 image file saved at the same time that is shown in the dialog box? educated guesses and help much apprecciated! Thanks a lot -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
CellTable created in onModuleLoad() doesn't draw until mouse moves over the browser window
Hey all,
I'm working with some code that was modeled after the StockWatch sample for
JSONP. A key difference between that code and mine is that the JSON data is
loaded immediately on module load rather than on a button click.
I'm finding that my CellTable doesn't render completely until I move the
mouse over the page. A workaround is to schedule a timer for 100
milliseconds after the table is added to the page that just calls redraw()
on the table, but this seems like a hack.
Anyone know why the table demonstrates this behavior?
The code is attached.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
package com.redbottledesign.continuum.timer.client.json;
import java.util.Date;
import com.google.gwt.core.client.JavaScriptObject;
import com.google.gwt.core.client.JsArray;
import com.google.gwt.i18n.shared.DateTimeFormat;
public class TimeEntry
extends JavaScriptObject
{
private static final DateTimeFormat DRUPAL_DATE_FORMAT = DateTimeFormat.getFormat(y-M-d H:m:s z);
public static final native JsArrayTimeEntry fromJavascriptObject(JavaScriptObject object)
/*-{
return object;
}-*/;
public static final native JsArrayTimeEntry fromJsonArray(String json)
/*-{
return eval(json);
}-*/;
public static final native TimeEntry fromJson(String json)
/*-{
return eval('(' + json + ')');
}-*/;
protected TimeEntry()
{
}
/* JSNI methods. */
public final native int getId()
/*-{
return parseInt(this.nid);
}-*/;
public final native int getRevision()
/*-{
return parseInt(this.vid);
}-*/;
public final native int getUserId()
/*-{
return parseInt(this.uid);
}-*/;
public final native String getTitle()
/*-{
return this.title;
}-*/;
public final Date getStartTime()
{
return parseDrupalDate(this.getStartTimeRaw());
}
public final Date getStopTime()
{
return parseDrupalDate(this.getStopTimeRaw());
}
protected static Date parseDrupalDate(String drupalDate)
{
Date result = null;
if ((drupalDate != null) !drupalDate.isEmpty())
result = DRUPAL_DATE_FORMAT.parse(drupalDate + UTC);
return result;
}
protected final native String getStartTimeRaw()
/*-{
var language = @com.redbottledesign.continuum.timer.shared.DrupalConstants::LANGUAGE_NONE;
return this.field_time_entry_date[language][0].value;
}-*/;
protected final native String getStopTimeRaw()
/*-{
var language = @com.redbottledesign.continuum.timer.shared.DrupalConstants::LANGUAGE_NONE;
return this.field_time_entry_date[language][0].value2;
}-*/;
}
package com.redbottledesign.continuum.timer.client;
import java.util.Comparator;
import java.util.List;
import com.google.gwt.core.client.EntryPoint;
import com.google.gwt.core.client.JavaScriptObject;
import com.google.gwt.core.client.JsArray;
import com.google.gwt.user.cellview.client.CellTable;
import com.google.gwt.user.cellview.client.Column;
import com.google.gwt.user.cellview.client.ColumnSortEvent.ListHandler;
import com.google.gwt.user.cellview.client.TextColumn;
import com.google.gwt.user.client.ui.FlowPanel;
import com.google.gwt.user.client.ui.Label;
import com.google.gwt.user.client.ui.RootPanel;
import com.google.gwt.view.client.ListDataProvider;
import com.redbottledesign.continuum.timer.client.json.TimeEntry;
public class Timer
implements EntryPoint
{
private static final String JSON_URL = http://continuum.localhost:8082/timer/1.0/entry.jsonp?parameters[type]=time_entryfields=title,nid,vid,uid,field_time_entry_date;;
private Label errorMsgLabel;
private FlowPanel mainPanel;
private CellTableTimeEntry timeEntryTable;
@Override
public void onModuleLoad()
{
this.setupComponents();
this.getJson(0, JSON_URL);
}
protected void setupComponents()
{
this.errorMsgLabel = new Label();
this.errorMsgLabel.setStyleName(errorMessage);
this.errorMsgLabel.setVisible(false);
this.mainPanel = new FlowPanel();
mainPanel.add(errorMsgLabel);
// Associate the Main panel with the HTML host page.
RootPanel.get(time-entry-list).add(mainPanel);
}
protected void setupTable(JsArrayTimeEntry timeEntries)
{
ColumnTimeEntry,StringtitleColumn,
startTimeColumn,
stopTimeColumn;
ListDataProviderTimeEntry dataProvider;
ListTimeEntry entryList;
ListHandlerTimeEntry titleSortHandler,
startTimeSortHandler,
stopTimeSortHandler;
if (this.timeEntryTable
Installing GWT 2.5.1 through Eclipse
I'm trying to install GWT plugin for Eclipse. I go to 'Help Install new software... ' through menus and I have added http://dl.google.com/eclipse/plugin/4.2 as Available Software Site. I choose to install Google Web Toolkit SDK 2.5.1, accept the agreements. Installing software dialog window appears and I see the progress bar which immediately gets stuck at 48% and never proceeds from there. System information: Arch Linux 3.8.10-1 x86_64 Eclipse SDK 4.2.2 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: CellTable created in onModuleLoad() doesn't draw until mouse moves over the browser window
In which browsers? 2013/4/28 Guy Paddock guy.padd...@gmail.com Hey all, I'm working with some code that was modeled after the StockWatch sample for JSONP. A key difference between that code and mine is that the JSON data is loaded immediately on module load rather than on a button click. I'm finding that my CellTable doesn't render completely until I move the mouse over the page. A workaround is to schedule a timer for 100 milliseconds after the table is added to the page that just calls redraw() on the table, but this seems like a hack. Anyone know why the table demonstrates this behavior? The code is attached. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Chrome plugin
It's is available in Chrome Web Store: https://chrome.google.com/webstore/detail/gwt-developer-plugin/jpjpnpmbddbjkfaccnmhnkdgjideieim It's working fine with latest Chrome and GWT 2.5.1. What do you mean it's disabled? On Monday, April 29, 2013 8:02:26 PM UTC+3, Norman Viands wrote: In the 2.51. there was a note about the plugin being available from the Chrome Store. It is there but is disabled. Is there plugin for Chrome going to be made available anytime soon? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Chrome plugin
On Monday, April 29, 2013 7:02:26 PM UTC+2, Norman Viands wrote: In the 2.51. there was a note about the plugin being available from the Chrome Store. It is there but is disabled. Is there plugin for Chrome going to be made available anytime soon? I suppose you're running Windows 8? https://code.google.com/p/google-web-toolkit/issues/detail?id=7778 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Installing GWT 2.5.1 through Eclipse
That's weird, it might be a networking issue. Try to follow this page: https://developers.google.com/eclipse/docs/install-from-zip It's shows you how to install from a local repos. On Monday, April 29, 2013 7:44:23 PM UTC+3, Anssi Lappalainen wrote: I'm trying to install GWT plugin for Eclipse. I go to 'Help Install new software... ' through menus and I have added http://dl.google.com/eclipse/plugin/4.2 as Available Software Site. I choose to install Google Web Toolkit SDK 2.5.1, accept the agreements. Installing software dialog window appears and I see the progress bar which immediately gets stuck at 48% and never proceeds from there. System information: Arch Linux 3.8.10-1 x86_64 Eclipse SDK 4.2.2 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: I want to use Apache Commons on the server, but the code is using the packages in gwt-dev.jar.
The thig is whenever I use a class from that package the IDE would link to the gwt-dev.jar. It's seem to be a conflict issue, there might be an easy solution but I have no knowledge of it. On Monday April 29. 2013 at 4:18 AM, Patrick Tucker tucker...@gmail.com wrote: Once on the server the jars in a directory are loaded in alphabetic order if not specified otherwise. You can try renaming the jar to make it come first. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/v5UhdnWvyQA/unsubscribe?hl=en. To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. Sent from Mailbird [http://www.getmailbird.com/?utm_source=signatureutm_medium=emailutm_campaign=SentWithMailbird_Faster] - it's faster -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: CellTable created in onModuleLoad() doesn't draw until mouse moves over the browser window
All browsers, in both dev and compiled versions. On Apr 29, 2013 2:20 PM, Juan Pablo Gardella gardellajuanpa...@gmail.com wrote: In which browsers? 2013/4/28 Guy Paddock guy.padd...@gmail.com Hey all, I'm working with some code that was modeled after the StockWatch sample for JSONP. A key difference between that code and mine is that the JSON data is loaded immediately on module load rather than on a button click. I'm finding that my CellTable doesn't render completely until I move the mouse over the page. A workaround is to schedule a timer for 100 milliseconds after the table is added to the page that just calls redraw() on the table, but this seems like a hack. Anyone know why the table demonstrates this behavior? The code is attached. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: CellTable created in onModuleLoad() doesn't draw until mouse moves over the browser window
1.) GWT can load JSON via JSONP by using JsonpRequestBuilder, in case you didn't know it. 2.) Try moving dataProvider.addDataDisplay() at the end of your setupTable code, so it gets executed after the table is actually added to the DOM (mainPanel.add(table)). As soon as you call dataProvider.addDataDisplay() the table will be rendered and once the table is attached to a data provider the table will update as soon as the data provider updates. So I would do: a.) setup table and add it to the main panel When JSON data is available b.) fill ListDataProvider c.) attach table to data provider Alternatively you could also use/extend AsyncDataProvider which allows you do load your JSON data and fill the table asynchronously right inside the data provider. -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Theme GWT, how does it works?
Thank you for your answer. I choose a theme and I have the same result. When I look the network requests, all seems OK. My WebContent folder contain: - folder myproject (with the theme GWT/clean ) - folder META-INF - folder WEB-INF -flavicon.ico -Myproject.css -Myproject.html Le jeudi 25 avril 2013 14:49:39 UTC-4, sebastie...@isen-lille.fr a écrit : Hi, My web application has serveral widgets like datePicker, dynamicDecorator... If I run my project with eclipse, widgets are ok. I want to build my project on lighthttpd, so I just copy my folder on my server. When I open website with a web broswer, it works but all my widgets have no style. ( for example, there are only the numbers for the datePicker: no color, no background...). I guess that the theme doesn't work without eclipse but in my gwt.xml I have: inherits name='com.google.gwt.user.theme.clean.Clean'/ inherits name='com.google.gwt.user.theme.standard.Standard'/ Do I really need to fill my CSS file to do the same thing with or without eclipse? Can I use the GWT theme without eclipse? I don't really understand the connections between the themes and the CSS.. Thank you in advance! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Theme GWT, how does it works?
I'm using lighthttpd, is it possible that it's the problem? Le jeudi 25 avril 2013 14:49:39 UTC-4, sebastie...@isen-lille.fr a écrit : Hi, My web application has serveral widgets like datePicker, dynamicDecorator... If I run my project with eclipse, widgets are ok. I want to build my project on lighthttpd, so I just copy my folder on my server. When I open website with a web broswer, it works but all my widgets have no style. ( for example, there are only the numbers for the datePicker: no color, no background...). I guess that the theme doesn't work without eclipse but in my gwt.xml I have: inherits name='com.google.gwt.user.theme.clean.Clean'/ inherits name='com.google.gwt.user.theme.standard.Standard'/ Do I really need to fill my CSS file to do the same thing with or without eclipse? Can I use the GWT theme without eclipse? I don't really understand the connections between the themes and the CSS.. Thank you in advance! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: CellTable created in onModuleLoad() doesn't draw until mouse moves over the browser window
Hi, I think you should try this while instantiating the Cell table timeEntryTable = new CellTableTimeEntry(pageSize, CellTableResource.INSTANCE); Please let me know, once you try this out. Regards, Kartik I think you On Monday, 29 April 2013 01:20:53 UTC+5:30, Guy Paddock wrote: Hey all, I'm working with some code that was modeled after the StockWatch sample for JSONP. A key difference between that code and mine is that the JSON data is loaded immediately on module load rather than on a button click. I'm finding that my CellTable doesn't render completely until I move the mouse over the page. A workaround is to schedule a timer for 100 milliseconds after the table is added to the page that just calls redraw() on the table, but this seems like a hack. Anyone know why the table demonstrates this behavior? The code is attached. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
TabLayoutPanel not visible in IE - old bug still unsolved?
Hi, my app uses a TabLayoutPanel as the center of a DockLayoutPanel. It's all created manually in Java, while the contents of the different tabs are created with UIBinder. (I don't touch barUnit.) The problem is that the tabs are not visible in IE. (Everything is fine in FF or Chrome). I found an old bug here: https://code.google.com/p/google-web-toolkit/issues/detail?id=6506 But this bug report is 2 years old. How can I fix this? (GWT 2.5.1) Thanks Magnus -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
GWT compilation failed
Hi, after upgrading the eclipse plugin (Help - Check for Updates) I cannot compile my project anymore. I receive the message GWT compilation failed (see below). What can I do? (GWT 2.5.1) Thank you Magnus - Compiling module bcs.bcs [ERROR] An internal compiler exception occurred com.google.gwt.dev.jjs.InternalCompilerException: Unexpected error during visit. at com.google.gwt.dev.jjs.ast.JVisitor.translateException(JVisitor.java:109) at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:276) at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:265) at com.google.gwt.dev.jjs.ast.JVisitor.accept(JVisitor.java:116) at com.google.gwt.dev.jjs.ast.JCastOperation.traverse(JCastOperation.java:65) at com.google.gwt.dev.jjs.ast.JModVisitor.traverse(JModVisitor.java:361) at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:273) at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:265) at com.google.gwt.dev.jjs.ast.JVisitor.accept(JVisitor.java:116) at com.google.gwt.dev.jjs.ast.JDeclarationStatement.traverse(JDeclarationStatement.java:48) at com.google.gwt.dev.jjs.ast.JModVisitor$ListContextImmutable.traverse(JModVisitor.java:170) at com.google.gwt.dev.jjs.ast.JModVisitor.acceptWithInsertRemoveImmutable(JModVisitor.java:336) at com.google.gwt.dev.jjs.ast.JBlock.traverse(JBlock.java:83) at com.google.gwt.dev.jjs.ast.JModVisitor.traverse(JModVisitor.java:361) at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:273) at com.google.gwt.dev.jjs.ast.JVisitor.accept(JVisitor.java:137) at com.google.gwt.dev.jjs.ast.JVisitor.accept(JVisitor.java:133) at com.google.gwt.dev.jjs.ast.JMethodBody.traverse(JMethodBody.java:82) at com.google.gwt.dev.jjs.ast.JModVisitor.traverse(JModVisitor.java:361) at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:273) at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:265) at com.google.gwt.dev.jjs.ast.JMethod.visitChildren(JMethod.java:434) at com.google.gwt.dev.jjs.ast.JMethod.traverse(JMethod.java:403) at com.google.gwt.dev.jjs.ast.JModVisitor.traverse(JModVisitor.java:361) at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:273) at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:265) at com.google.gwt.dev.jjs.impl.UnifyAst.mainLoop(UnifyAst.java:900) at com.google.gwt.dev.jjs.impl.UnifyAst.exec(UnifyAst.java:625) at com.google.gwt.dev.jjs.JavaToJavaScriptCompiler.precompile(JavaToJavaScriptCompiler.java:640) at com.google.gwt.dev.jjs.JavaScriptCompiler.precompile(JavaScriptCompiler.java:33) at com.google.gwt.dev.Precompile.precompile(Precompile.java:278) at com.google.gwt.dev.Precompile.precompile(Precompile.java:229) at com.google.gwt.dev.Precompile.precompile(Precompile.java:141) at com.google.gwt.dev.Compiler.run(Compiler.java:232) at com.google.gwt.dev.Compiler.run(Compiler.java:198) at com.google.gwt.dev.Compiler$1.run(Compiler.java:170) at com.google.gwt.dev.CompileTaskRunner.doRun(CompileTaskRunner.java:88) at com.google.gwt.dev.CompileTaskRunner.runWithAppropriateLogger(CompileTaskRunner.java:82) at com.google.gwt.dev.Compiler.main(Compiler.java:177) Caused by: java.lang.RuntimeException: Unexpected IOException on in-memory stream at com.google.gwt.dev.javac.CompilationUnit.getTypes(CompilationUnit.java:360) at com.google.gwt.dev.jjs.impl.UnifyAst.assimilateUnit(UnifyAst.java:670) at com.google.gwt.dev.jjs.impl.UnifyAst.searchForTypeBySource(UnifyAst.java:983) at com.google.gwt.dev.jjs.impl.UnifyAst.access$1500(UnifyAst.java:120) at com.google.gwt.dev.jjs.impl.UnifyAst$UnifyVisitor.handleGwtCreate(UnifyAst.java:364) at com.google.gwt.dev.jjs.impl.UnifyAst$UnifyVisitor.handleMagicMethodCall(UnifyAst.java:433) at com.google.gwt.dev.jjs.impl.UnifyAst$UnifyVisitor.endVisit(UnifyAst.java:237) at com.google.gwt.dev.jjs.ast.JMethodCall.traverse(JMethodCall.java:243) at com.google.gwt.dev.jjs.ast.JModVisitor.traverse(JModVisitor.java:361) at com.google.gwt.dev.jjs.ast.JModVisitor.accept(JModVisitor.java:273) ... 37 more Caused by: java.io.InvalidClassException: com.google.gwt.dev.jjs.ast.JDeclaredType; local class incompatible: stream classdesc serialVersionUID = -1052417216019896795, local class serialVersionUID = -8155793964565947646 at java.io.ObjectStreamClass.initNonProxy(ObjectStreamClass.java:579) at java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1600) at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1513) at java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1600) at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1513) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1749) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1346) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:368) at java.util.ArrayList.readObject(ArrayList.java:696) at sun.reflect.GeneratedMethodAccessor17.invoke(Unknown Source) at
Re: [gwt-contrib] Re: Genericizing com.google.gwt.user.client.ui.Composite for type safe extends
As an experiment, perhaps someone can come up with another patch that adds type parameters to Composite and ResizeComposite and we can run Google's tests to see what the damage is. We can start on it now, but before making a final decision we should probably wait until Roberto is done upgrading the JDT, since type-checking is stricter in Java 7 and it might make a difference. On Sat, Apr 27, 2013 at 4:32 AM, Jens jens.nehlme...@gmail.com wrote: So what is the gotcha? First of all old code will give warnings due to missing generic type in Composite. Also classes that doesn't need to enhance the type information will still need to provide a type for Composite, this includes most of the Composite uses with the UIBinder. GPE should be updated to use extends CompositeUiBinderRootWidgetTypeHere if it detects a GWT SDK that supports it. And IntelliJ's generated code for UiBinder files current doesn't even add extends Composite out of the box. You would need to configure IntelliJ's UiBinder File Template for doing so and thus you could easily change it to at least CompositeWidget or maybe even CompositeUiBinderRootWidgetTypeHere. We can get mitigate these problems by introducing a separate 'TypedComposite' and 'TypedResizeComposite' class that uses generics. Of course this means more classes that will potentially cause more confusion. I am against TypedComposite, TypedResizeComposite. Beside the fact that they confuse a bit you probably will make Composite and ResizeComposite deprecated either now or in the future. And once you remove deprecated Composite/ResizeComposite from the code base you end up with two classes with bad names. I would expect Composite and ResizeComposite to be typed and not having classes with names that tell me that they are typed. So I am with Thomas here and would vote for just making Composite/ResizeComposite generic even if it means a lot of warnings in current code bases. IMHO these warnings are better than having two strangely named classes in the future. -- J. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Genericizing com.google.gwt.user.client.ui.Composite for type safe extends
On Sat, Apr 27, 2013 at 1:57 AM, Thomas Broyer t.bro...@gmail.com wrote:
On Friday, April 26, 2013 6:59:32 AM UTC+2, Goktug Gokdogan wrote:
I would like to get your feedback for fixing following issue:
https://code.google.com/p/**google-web-toolkit/issues/**detail?id=4665https://code.google.com/p/google-web-toolkit/issues/detail?id=4665
With generic Composite classes we can introduce other type-safe helper
composites like FocusComposite or PanelComposite (see the patch). This will
reduce boilerplate when people need to add more functionality to their
widgets extending composite. For example
ValueListBoxhttps://code.google.com/p/google-web-toolkit/source/browse/trunk/user/src/com/google/gwt/user/client/ui/ValueListBox.javacan
provide all FocusWidget API by just extending FocusComposite.
Otherwise it would have needed to add delegate for all methods in the
FocusWidget API (20+ methods).
Similarly, if you are developing widgets using UIBinder then you can use
PanelComposite instead of Composite to make the widget work like a real
panel in other templates as PanelComposite implements HasWidgets.
We cannot introduce these helper classes with current Composite in a type
safe way. The reason is initWidget can be called with any parameter and we
can't override it to make it more specific. This issue can be easily seen
in
ResizeCompositehttps://code.google.com/p/google-web-toolkit/source/browse/trunk/user/src/com/google/gwt/user/client/ui/ResizeComposite.javaclass
where the check need to be done in runtime. However with the proposed
change, ResizeComposite becomes just a one liner and type is checked in
compile time.
Another minor advantage is classes extending composite will not
necessarily need to keep a reference to the widget passed to the composite
as getWidget will retain the type.
…or cast the result of getWidget().
So what is the gotcha?
First of all old code will give warnings due to missing generic type in
Composite.
I think we can live with this. It has (should have) no impact on the
compiled JS anyway.
When Java 5 added generics, java.util.List and java.util.Map (among others)
have been genericized, rather than introducing TypedList and TypedMap.
That is true, though there is a small difference. List/Map are real
container types. If something is a container, it is easy to justify forcing
generics.
The reason I was reluctant in Composite case was, usually it isn't used
like a real container. In most scenarios, it is just the way to convert
your UIBinder template to widget class (more about this below).
There's only one, technically speaking, breaking change: the following
code would no longer compile as Label is not a RequiresResize, but it'd
fail at runtime anyway with the current non-generic class, so it's not a
breaking change in practice:
public class MyComposite extends ResizeComposite {
public MyComposite() {
initWidget(new Label());
}
}
Also classes that doesn't need to enhance the type information will still
need to provide a type for Composite, this includes most of the Composite
uses with the UIBinder.
What do you mean by Composite uses with the UiBinder?
Composite is meant to be extended, so that it's mostly an implementation
detail and you never reference the Composite type outside of the extends
Composite clause.
Are you using Composite differently?
There are 2 common patterns with Composite.
One which is less common (but very likely was the original intention), is
to hide APIs of a base class by using composition instead of extension.
This is how ValueListBox works. Instead of extending Listbox, it 'composes'
listbox with the help of Composite to add a new set of api/features.
Similarly, if in order to develop a new widget that uses FlowPanel as
starting point, now you no longer need to extend FlowPanel which would have
cause you to inherit and expose all the API. In libraries like Swing, this
was a huge pain. In GWT, you can use a Composite and hide FlowPanel APIs.
In this case, it makes sense to have Generics as the type the delegate
object (i.e. the widget passed to initWidget) has significance. Also you
are more likely need to forward more APIs, hence classes like
FocusComposite, PanelComposite makes sense.
A small implication to note here is, now the base class extending
composite, will start exposing its delegate type to child classes. i.e.
when ValueListBox extends CompositeListBox and if it is not a final
class, it needs to keep that type forever.
The second scenario is developing a view with UIBinder (most of the user
code) where there is a template and developer tries to convert it into a
GWT Widget. In these scenarios, usually, the root element in the template
is insignificant (the first type in UIBinder generics) and java code
doesn't really care. We will be forcing a type to be defined for the
composite.
We can get mitigate these problems by introducing a separate
Re: [gwt-contrib] Re: Genericizing com.google.gwt.user.client.ui.Composite for type safe extends
I experimented with Composite last week. There was no damage in Google3 - at least I didn't notice any. ResizeComposite might have a few but should be easy to fix. I'll coordinate with Roberto though there shouldn't be any implications related Java 7 as this change is only relates to raw types. On Mon, Apr 29, 2013 at 10:51 AM, Brian Slesinsky skybr...@google.comwrote: As an experiment, perhaps someone can come up with another patch that adds type parameters to Composite and ResizeComposite and we can run Google's tests to see what the damage is. We can start on it now, but before making a final decision we should probably wait until Roberto is done upgrading the JDT, since type-checking is stricter in Java 7 and it might make a difference. On Sat, Apr 27, 2013 at 4:32 AM, Jens jens.nehlme...@gmail.com wrote: So what is the gotcha? First of all old code will give warnings due to missing generic type in Composite. Also classes that doesn't need to enhance the type information will still need to provide a type for Composite, this includes most of the Composite uses with the UIBinder. GPE should be updated to use extends CompositeUiBinderRootWidgetTypeHere if it detects a GWT SDK that supports it. And IntelliJ's generated code for UiBinder files current doesn't even add extends Composite out of the box. You would need to configure IntelliJ's UiBinder File Template for doing so and thus you could easily change it to at least CompositeWidget or maybe even CompositeUiBinderRootWidgetTypeHere. We can get mitigate these problems by introducing a separate 'TypedComposite' and 'TypedResizeComposite' class that uses generics. Of course this means more classes that will potentially cause more confusion. I am against TypedComposite, TypedResizeComposite. Beside the fact that they confuse a bit you probably will make Composite and ResizeComposite deprecated either now or in the future. And once you remove deprecated Composite/ResizeComposite from the code base you end up with two classes with bad names. I would expect Composite and ResizeComposite to be typed and not having classes with names that tell me that they are typed. So I am with Thomas here and would vote for just making Composite/ResizeComposite generic even if it means a lot of warnings in current code bases. IMHO these warnings are better than having two strangely named classes in the future. -- J. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: preparation for turning off Dataflow Optimizer to speed up o...
Roberto Lublinerman has posted comments on this change. Change subject: preparation for turning off Dataflow Optimizer to speed up optimized compiles (at optimization levels less than 9) .. Patch Set 1: Code-Review+1 LGTM. -- To view, visit https://gwt-review.googlesource.com/2610 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f33700566e97672b2e570fc5f75293bd6b2fb9f Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: preparation for turning off Dataflow Optimizer to speed up o...
Brian Slesinsky has posted comments on this change. Change subject: preparation for turning off Dataflow Optimizer to speed up optimized compiles (at optimization levels less than 9) .. Patch Set 1: (1 comment) File dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java Line 43: OptionClusterSimilarFunctions, OptionDisableClassMetadata, OptionDisableCastChecking, I know you're just following convention, but I'm not sure we need an interface and implementation for every flag. It seems like one interface and implementation for all the optimizer tweaking flags would be enough? -- To view, visit https://gwt-review.googlesource.com/2610 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f33700566e97672b2e570fc5f75293bd6b2fb9f Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added -optimize option to JUnitShell.
Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/2611
Change subject: Added -optimize option to JUnitShell.
..
Added -optimize option to JUnitShell.
Added JUnitShellTest to JUnitSuite.
Change-Id: I5a4c3747bedaf5db84b0c7ffefdd83da64d060d7
---
M user/src/com/google/gwt/junit/JUnitShell.java
M user/test/com/google/gwt/junit/JUnitShellTest.java
M user/test/com/google/gwt/junit/JUnitSuite.java
3 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/user/src/com/google/gwt/junit/JUnitShell.java
b/user/src/com/google/gwt/junit/JUnitShell.java
index 2555991..8d1dd1d 100644
--- a/user/src/com/google/gwt/junit/JUnitShell.java
+++ b/user/src/com/google/gwt/junit/JUnitShell.java
@@ -48,6 +48,7 @@
import com.google.gwt.dev.util.arg.ArgHandlerLocalWorkers;
import com.google.gwt.dev.util.arg.ArgHandlerLogLevel;
import com.google.gwt.dev.util.arg.ArgHandlerMaxPermsPerPrecompile;
+import com.google.gwt.dev.util.arg.ArgHandlerOptimize;
import com.google.gwt.dev.util.arg.ArgHandlerScriptStyle;
import com.google.gwt.dev.util.arg.ArgHandlerWarDir;
import com.google.gwt.dev.util.arg.ArgHandlerWorkDirOptional;
@@ -190,6 +191,7 @@
registerHandler(new ArgHandlerDraftCompile(options));
registerHandler(new ArgHandlerMaxPermsPerPrecompile(options));
registerHandler(new ArgHandlerLocalWorkers(options));
+ registerHandler(new ArgHandlerOptimize(options));
/*
* - Options specific to JUnitShell -
diff --git a/user/test/com/google/gwt/junit/JUnitShellTest.java
b/user/test/com/google/gwt/junit/JUnitShellTest.java
index 3b8dc48..9d89dca 100644
--- a/user/test/com/google/gwt/junit/JUnitShellTest.java
+++ b/user/test/com/google/gwt/junit/JUnitShellTest.java
@@ -47,6 +47,11 @@
shell.getModuleUrl(localhost, 1234, example, 456));
}
+
+ public void testArgOptimize() throws Exception {
+parseGoodArgs(-optimize,8);
+ }
+
private void parseGoodArgs(String... argsToUse) {
JUnitShell.ArgProcessor processor = new JUnitShell.ArgProcessor(shell);
assertTrue(didn't accept good args,
processor.processArgs(argsToUse));
diff --git a/user/test/com/google/gwt/junit/JUnitSuite.java
b/user/test/com/google/gwt/junit/JUnitSuite.java
index 9d2a7b4..cbadd31 100644
--- a/user/test/com/google/gwt/junit/JUnitSuite.java
+++ b/user/test/com/google/gwt/junit/JUnitSuite.java
@@ -60,6 +60,9 @@
suite.addTestSuite(PropertyDefiningStrategyTest.class);
suite.addTestSuite(PropertyDefiningGWTTest.class);
+
+suite.addTestSuite(JUnitShellTest.class);
+
return suite;
}
}
--
To view, visit https://gwt-review.googlesource.com/2611
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a4c3747bedaf5db84b0c7ffefdd83da64d060d7
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added -optimize option to JUnitShell.
John Stalcup has posted comments on this change. Change subject: Added -optimize option to JUnitShell. .. Patch Set 1: Verified+1 Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2611 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a4c3747bedaf5db84b0c7ffefdd83da64d060d7 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added -optimize option to JUnitShell.
Matthew Dempsky has posted comments on this change. Change subject: Added -optimize option to JUnitShell. .. Patch Set 1: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://gwt-ci.dempsky.org:8080/job/gwt.presubmit/38 -- To view, visit https://gwt-review.googlesource.com/2611 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a4c3747bedaf5db84b0c7ffefdd83da64d060d7 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added -optimize option to JUnitShell.
Roberto Lublinerman has uploaded a new patch set (#2). Change subject: Added -optimize option to JUnitShell. .. Added -optimize option to JUnitShell. Added JUnitShellTest to JUnitSuite. Change-Id: I5a4c3747bedaf5db84b0c7ffefdd83da64d060d7 Review-Link: https://gwt-review.googlesource.com/#/c/2611/ --- M user/src/com/google/gwt/junit/JUnitShell.java M user/test/com/google/gwt/junit/JUnitShellTest.java M user/test/com/google/gwt/junit/JUnitSuite.java 3 files changed, 23 insertions(+), 1 deletion(-) -- To view, visit https://gwt-review.googlesource.com/2611 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5a4c3747bedaf5db84b0c7ffefdd83da64d060d7 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added missing compiler options to JUnitShell.
Roberto Lublinerman has uploaded a new patch set (#3). Change subject: Added missing compiler options to JUnitShell. .. Added missing compiler options to JUnitShell. Added JUnitShellTest to JUnitSuite. Change-Id: I5a4c3747bedaf5db84b0c7ffefdd83da64d060d7 Review-Link: https://gwt-review.googlesource.com/#/c/2611/ --- M user/src/com/google/gwt/junit/JUnitShell.java M user/test/com/google/gwt/junit/JUnitShellTest.java M user/test/com/google/gwt/junit/JUnitSuite.java 3 files changed, 23 insertions(+), 1 deletion(-) -- To view, visit https://gwt-review.googlesource.com/2611 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5a4c3747bedaf5db84b0c7ffefdd83da64d060d7 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added missing compiler options to JUnitShell.
Matthew Dempsky has posted comments on this change. Change subject: Added missing compiler options to JUnitShell. .. Patch Set 2: Verified-1 Oops, this change failed the build and/or style presubmit. :( More details at http://gwt-ci.dempsky.org:8080/job/gwt.presubmit/39 -- To view, visit https://gwt-review.googlesource.com/2611 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a4c3747bedaf5db84b0c7ffefdd83da64d060d7 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added missing compiler options to JUnitShell.
Matthew Dempsky has posted comments on this change. Change subject: Added missing compiler options to JUnitShell. .. Patch Set 3: Verified-1 Oops, this change failed the build and/or style presubmit. :( More details at http://gwt-ci.dempsky.org:8080/job/gwt.presubmit/40 -- To view, visit https://gwt-review.googlesource.com/2611 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a4c3747bedaf5db84b0c7ffefdd83da64d060d7 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added missing compiler options to JUnitShell.
Roberto Lublinerman has abandoned this change. Change subject: Added missing compiler options to JUnitShell. .. Abandoned Submitted, thanks!!! -- To view, visit https://gwt-review.googlesource.com/2611 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I5a4c3747bedaf5db84b0c7ffefdd83da64d060d7 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added missing compiler options to JUnitShell.
Goktug Gokdogan has posted comments on this change. Change subject: Added missing compiler options to JUnitShell. .. Patch Set 3: (3 comments) Woaw so fast! You guys should leave it here for a while so that other people can have time to comment on it :) File user/test/com/google/gwt/junit/JUnitSuite.java Line 45: suite.addTestSuite(BatchingStrategyTest.class); Missing RunStyleSeleniumTest Line 47: Missing FakeCssMakerTest Line 49: suite.addTestSuite(GWTMockUtilitiesTest.class); Please move next Junitshelltest -- To view, visit https://gwt-review.googlesource.com/2611 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a4c3747bedaf5db84b0c7ffefdd83da64d060d7 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added missing JUnit tests to JUnitSuite.
Roberto Lublinerman has uploaded a new change for review. https://gwt-review.googlesource.com/2620 Change subject: Added missing JUnit tests to JUnitSuite. .. Added missing JUnit tests to JUnitSuite. Change-Id: I18b51bdfbe9141535a8e0f47306ea73791aec4b4 --- M user/test/com/google/gwt/junit/JUnitSuite.java 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/user/test/com/google/gwt/junit/JUnitSuite.java b/user/test/com/google/gwt/junit/JUnitSuite.java index 8b556b7..05f9879 100644 --- a/user/test/com/google/gwt/junit/JUnitSuite.java +++ b/user/test/com/google/gwt/junit/JUnitSuite.java @@ -45,9 +45,14 @@ suite.addTestSuite(BatchingStrategyTest.class); suite.addTestSuite(CompileStrategyTest.class); +// TODO(rluble): Make Selenium tests work or deprecate. They are missing the Selenium +// dependency. + +// suite.addTestSuite(RunStyleSeleniumTest.class); + +suite.addTestSuite(FakeCssMakerTest.class); suite.addTestSuite(FakeMessagesMakerTest.class); suite.addTestSuite(GWTMockUtilitiesTest.class); -suite.addTestSuite(JUnitMessageQueueTest.class); suite.addTestSuite(GWTTestCaseNoClientTest.class); // Intended only to be run manually. See class comments @@ -60,6 +65,7 @@ suite.addTestSuite(PropertyDefiningStrategyTest.class); suite.addTestSuite(PropertyDefiningGWTTest.class); +suite.addTestSuite(JUnitMessageQueueTest.class); suite.addTestSuite(JUnitShellTest.class); return suite; -- To view, visit https://gwt-review.googlesource.com/2620 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I18b51bdfbe9141535a8e0f47306ea73791aec4b4 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added missing JUnit tests to JUnitSuite.
Matthew Dempsky has posted comments on this change. Change subject: Added missing JUnit tests to JUnitSuite. .. Patch Set 1: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://gwt-ci.dempsky.org:8080/job/gwt.presubmit/41 -- To view, visit https://gwt-review.googlesource.com/2620 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18b51bdfbe9141535a8e0f47306ea73791aec4b4 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Added missing JUnit tests to JUnitSuite.
Goktug Gokdogan has posted comments on this change. Change subject: Added missing JUnit tests to JUnitSuite. .. Patch Set 1: Code-Review+1 Thanks! -- To view, visit https://gwt-review.googlesource.com/2620 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18b51bdfbe9141535a8e0f47306ea73791aec4b4 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
