Re: Russian GWT tutorial

2014-01-23 Thread Andrey
Ссылка не работает(((

среда, 5 ноября 2008 г., 14:01:20 UTC+4 пользователь GoCha написал:

 Русское ководство GWT 
 http://gocha.org/index.php?option=com_contenttask=viewid=16Itemid=28

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/groups/opt_out.


Make my custome class work with XML UiBinder

2013-12-09 Thread Andrey Damintsev
Hello! 
In our project we doesn`t use UiBinder and Xml. Whole interface we write by 
java code. I dont like this approach. I want to do it with Xml (I think 
there is less code because all forms are similar).
So I have a class UiForm. That has an method whitch create FieldLabel and 
cover Witdget withch I send to it.

public final X extends Field? X add(String key, String title, X 
 field) {

 return add(key, title, field, 1);

 }

  
This looks like this:
 

 SimpleComboBoxSettingsProfileType type = new 
 SimpleComboBoxSettingsProfileType(new 
 LabelProviderSettingsProfileType() {

@Override

public String getLabel(SettingsProfileType item) {

return item.name();

}

});

form.setLabelWidth(100);

form.add(profileType, Тип профиля, type);

 

 textField = new TextField();

textField.setAllowBlank(false);

form.setLabelWidth(60);

form.add(name, Имя,  textField);

 
I want to made all of this work using XML and UiBinder
1) I mark methood as @UiChild
2) I write XML like this

!DOCTYPE ui:UiBinder SYSTEM http://dl.google.com/gwt/DTD/xhtml.ent;

 ui:UiBinder xmlns:ui='urn:ui:com.google.gwt.uibinder' 
 xmlns:gxt=urn:import:com.sencha.gxt.widget.core.client

  xmlns:form=urn:import:com.google.gwt.user.client.ui


 ui:with type=com.sigma.utility.web.gxt.main.ui.UIForm 
 field=uiform

 /ui:with

 gxt:Window ui:field=window modal=true blinkModal=true 
 headingText=Hello Window


 uiform ui:field=form

 add key=test title=help!

 form:TextField/

 /add

 /uiform

 /gxt:Window

 /ui:UiBinder


But I have an error like this:

com.google.gwt.event.shared.UmbrellaException: Exception caught: null

 at 
 com.google.gwt.event.shared.HandlerManager.fireEvent(HandlerManager.java:129)

 at 
 com.sencha.gxt.cell.core.client.AbstractEventCell.fireEvent(AbstractEventCell.java:89)

 at com.sencha.gxt.cell.core.client.ButtonCell.onClick(ButtonCell.java:428)

 at 
 com.sencha.gxt.cell.core.client.ButtonCell.onBrowserEvent(ButtonCell.java:289)

 at 
 com.sencha.gxt.widget.core.client.cell.CellComponent.onBrowserEvent(CellComponent.java:221)

 at 
 com.sencha.gxt.widget.core.client.button.CellButtonBase.onBrowserEvent(CellButtonBase.java:163)

 at com.google.gwt.user.client.DOM.dispatchEventImpl(DOM.java:1351)

 at com.google.gwt.user.client.DOM.dispatchEvent(DOM.java:1307)

 at sun.reflect.GeneratedMethodAccessor286.invoke(Unknown Source)

 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

 at java.lang.reflect.Method.invoke(Method.java:597)

 at com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103)

 at com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)

 at 
 com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:172)

 at 
 com.google.gwt.dev.shell.BrowserChannelServer.reactToMessagesWhileWaitingForReturn(BrowserChannelServer.java:338)

 at 
 com.google.gwt.dev.shell.BrowserChannelServer.invokeJavascript(BrowserChannelServer.java:219)

 at 
 com.google.gwt.dev.shell.ModuleSpaceOOPHM.doInvoke(ModuleSpaceOOPHM.java:136)

 at com.google.gwt.dev.shell.ModuleSpace.invokeNative(ModuleSpace.java:571)

 at 
 com.google.gwt.dev.shell.ModuleSpace.invokeNativeObject(ModuleSpace.java:279)

 at 
 com.google.gwt.dev.shell.JavaScriptHost.invokeNativeObject(JavaScriptHost.java:91)

 at com.google.gwt.core.client.impl.Impl.apply(Impl.java)

 at com.google.gwt.core.client.impl.Impl.entry0(Impl.java:242)

 at sun.reflect.GeneratedMethodAccessor284.invoke(Unknown Source)

 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

 at java.lang.reflect.Method.invoke(Method.java:597)

 at com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103)

 at com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)

 at 
 com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:172)

 at 
 com.google.gwt.dev.shell.BrowserChannelServer.reactToMessages(BrowserChannelServer.java:293)

 at 
 com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:547)

 at 
 com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:364)

 at java.lang.Thread.run(Thread.java:662)

 Caused by: java.lang.ExceptionInInitializerError

 at 
 com.sigma.ascip.v2.office.errorconversion.ErrorConversion$3.onClick(ErrorConversion.java:67)

 at 
 com.sigma.utility.web.gxt.main.ui.button.UIButton.onClick(UIButton.java:192)

 at 
 com.sigma.utility.web.gxt.main.ui.button.UIButton.access$1(UIButton.java:185)

 at 
 com.sigma.utility.web.gxt.main.ui.button.UIButton$2.onSelect(UIButton.java:161)

 at 
 com.sencha.gxt.widget.core.client.event.SelectEvent.dispatch(SelectEvent.java:65)

 at 
 

What happend after GWT.create()

2013-10-25 Thread Andrey Damintsev
Hello!
I use GWT about half year.  But I cant understand what happens after 
GWT.create().  I read some FAQs articles and there said that occurs a 
deferred bindings. Ok! But how It realised from Java.

I start to read sources of ServerGwtBridge class, but cannot understand.
Can somebody advice any articles or something, that can explain this for me/

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/groups/opt_out.


[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-12 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Emulate java.util.Objects
..


Patch Set 9:

@Thomas: I'll submit fixes for failing tests asap

--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Failing tests for java.util.Objects

2013-06-12 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new change for review.

  https://gwt-review.googlesource.com/3400


Change subject: Failing tests for java.util.Objects
..

Failing tests for java.util.Objects

Fixes issue 8193

Change-Id: I394c80559ce4e872826f832f0aca24fcd0e156ba
---
M user/super/com/google/gwt/emul/java/util/Objects.java
M user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
2 files changed, 7 insertions(+), 9 deletions(-)



diff --git a/user/super/com/google/gwt/emul/java/util/Objects.java  
b/user/super/com/google/gwt/emul/java/util/Objects.java

index ca0f5e1..ec5e9a4 100644
--- a/user/super/com/google/gwt/emul/java/util/Objects.java
+++ b/user/super/com/google/gwt/emul/java/util/Objects.java
@@ -29,7 +29,13 @@
   }

   public static boolean deepEquals(Object a, Object b) {
-if (equals(a, b)) {
+if (a == b) {
+  return true;
+}
+if (a == null || b == null) {
+  return false;
+}
+if (a.equals(b)) {
   return true;
 }

diff --git a/user/test/com/google/gwt/emultest/java/util/ObjectsTest.java  
b/user/test/com/google/gwt/emultest/java/util/ObjectsTest.java

index 96cd788..f6416e2 100644
--- a/user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
+++ b/user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
@@ -82,14 +82,6 @@

 Object obj = new Object();
 assertTrue(Objects.equals(obj, obj));
-
-assertFalse(Objects.equals(new Object() {
-  @Override
-  public boolean equals(Object other) {
-fail(Shouldn't call equals if second argument is null);
-return false;
-  }
-}, null));
   }

   public void testHashCode() {

--
To view, visit https://gwt-review.googlesource.com/3400
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I394c80559ce4e872826f832f0aca24fcd0e156ba
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-12 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Emulate java.util.Objects
..


Patch Set 9:

Filed  
https://code.google.com/p/google-web-toolkit/issues/detail?can=2start=0num=100q=colspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Starsgroupby=sort=id=8193

and patch https://gwt-review.googlesource.com/3400

--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Support standardized DOM WheelEvent https://developer.mozill...

2013-06-08 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has abandoned this change.

Change subject: Support standardized DOM WheelEvent  
https://developer.mozilla.org/en-US/docs/Web/Reference/Events/wheel

..


Abandoned

DOMMouseScroll event is not broken in gwt. Found error in my code.

--
To view, visit https://gwt-review.googlesource.com/3171
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia6e8cb62ea195ca9e0253a74b4fc6fafbe6183da
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: elemental.dom.Node.addEventListener throws Uncaught Referenc...

2013-06-08 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new change for review.

  https://gwt-review.googlesource.com/3330


Change subject: elemental.dom.Node.addEventListener throws Uncaught  
ReferenceError

..

elemental.dom.Node.addEventListener throws Uncaught ReferenceError

Fixes issue 7518

Change-Id: I1aef7a553866431a2d153a4696e8bb5a82cd2022
---
M elemental/idl/templates/jso_impl_ElementalMixinBase.darttemplate
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git  
a/elemental/idl/templates/jso_impl_ElementalMixinBase.darttemplate  
b/elemental/idl/templates/jso_impl_ElementalMixinBase.darttemplate

index b3e199a..73851fe 100644
--- a/elemental/idl/templates/jso_impl_ElementalMixinBase.darttemplate
+++ b/elemental/idl/templates/jso_impl_ElementalMixinBase.darttemplate
@@ -154,7 +154,7 @@
   var handler =  
@elemental.js.dom.JsElementalMixinBase::getHandlerFor(Lelemental/events/EventListener;)(listener);

   this.addEventListener(type, handler);
   return  
@elemental.js.dom.JsElementalMixinBase.Remover::create(Lelemental/events/EventTarget;Ljava/lang/String;Lcom/google/gwt/core/client/JavaScriptObject;Z)

-  (this, type, handler, useCapture);
+  (this, type, handler, false);
 }-*/;

 @Deprecated

--
To view, visit https://gwt-review.googlesource.com/3330
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1aef7a553866431a2d153a4696e8bb5a82cd2022
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Wrong JavaDoc for MouseWheelEvent.getDeltaY()

2013-06-06 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new change for review.

  https://gwt-review.googlesource.com/3187


Change subject: Wrong JavaDoc for MouseWheelEvent.getDeltaY()
..

Wrong JavaDoc for MouseWheelEvent.getDeltaY()

Fixes issue 6400

Change-Id: I445111ab363a89aafb0f23a72de1bdc4971bae1c
---
M user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java  
b/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java

index 33fc5ca..647c07f 100644
--- a/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
+++ b/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
@@ -61,8 +61,8 @@
   }

   /**
-   * Get the change in the mouse wheel position along the Y-axis; positive  
if
-   * the mouse wheel is moving north (toward the top of the screen) or  
negative
+   * Get the change in the mouse wheel position along the Y-axis; negative  
if
+   * the mouse wheel is moving north (toward the top of the screen) or  
positive

* if the mouse wheel is moving south (toward the bottom of the screen).
*
* Note that delta values are not normalized across browsers or OSes.

--
To view, visit https://gwt-review.googlesource.com/3187
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I445111ab363a89aafb0f23a72de1bdc4971bae1c
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-05 Thread Andrey Korzhevskiy

Hello John A. Tamplin,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3184

to look at the new patch set (#8).

Change subject: Emulate java.util.Objects
..

Emulate java.util.Objects

Fixes issue 8173

Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
---
M user/super/com/google/gwt/emul/java/util/Arrays.java
A user/super/com/google/gwt/emul/java/util/Objects.java
M user/test/com/google/gwt/emultest/EmulSuite.java
A user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
4 files changed, 213 insertions(+), 58 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Support standardized DOM WheelEvent

2013-06-05 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new change for review.

  https://gwt-review.googlesource.com/3171


Change subject: Support standardized DOM WheelEvent
..

Support standardized DOM WheelEvent

Fixes issue 8012

Change-Id: Ia6e8cb62ea195ca9e0253a74b4fc6fafbe6183da
---
M user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
M user/src/com/google/gwt/user/client/impl/DOMImpl.java
M user/src/com/google/gwt/user/client/impl/DOMImplMozilla.java
3 files changed, 14 insertions(+), 3 deletions(-)



diff --git a/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java  
b/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java

index 33fc5ca..539cb25 100644
--- a/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
+++ b/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
@@ -31,6 +31,13 @@

   static {
 /**
+ * Hidden type used to ensure wheel event gets registered in the type  
map.
+ * This is the standard event in DOM L3 which deprecates legacy  
mousewheel and DOMMouseScroll events.

+ * https://developer.mozilla.org/en-US/docs/Web/Reference/Events/wheel
+ */
+new TypeMouseWheelHandler(wheel, new MouseWheelEvent());
+
+/**
  * Hidden type used to ensure DOMMouseScroll gets registered in the  
type map.
  * This is the special name used on Mozilla browsers for what everyone  
else

  * calls 'mousewheel'.
diff --git a/user/src/com/google/gwt/user/client/impl/DOMImpl.java  
b/user/src/com/google/gwt/user/client/impl/DOMImpl.java

index c5b8187..bf482d9 100644
--- a/user/src/com/google/gwt/user/client/impl/DOMImpl.java
+++ b/user/src/com/google/gwt/user/client/impl/DOMImpl.java
@@ -129,6 +129,7 @@
 case scroll: return 0x04000;
 case error: return 0x1;
 case mousewheel: return 0x2;
+case wheel: return 0x2;
 case DOMMouseScroll: return 0x2;
 case contextmenu: return 0x4;
 case paste: return 0x8;
diff --git a/user/src/com/google/gwt/user/client/impl/DOMImplMozilla.java  
b/user/src/com/google/gwt/user/client/impl/DOMImplMozilla.java

index eb08c98..4332af0 100644
--- a/user/src/com/google/gwt/user/client/impl/DOMImplMozilla.java
+++ b/user/src/com/google/gwt/user/client/impl/DOMImplMozilla.java
@@ -29,7 +29,8 @@
   }

   public native void disposeEventsMozilla(Element elem) /*-{
-elem.removeEventListener('DOMMouseScroll',  
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchEvent, false);

+var wheelEventName = 'onwheel' in $doc ? 'wheel' : 'DOMMouseScroll';
+elem.removeEventListener(wheelEventName,  
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchEvent, false);

   }-*/;

   @Override
@@ -40,7 +41,8 @@

   public native void sinkEventsMozilla(Element elem, int bits) /*-{
 if (bits  0x2) {
-  elem.addEventListener('DOMMouseScroll',  
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchEvent, false);

+  var wheelEventName = 'onwheel' in $doc ? 'wheel' : 'DOMMouseScroll';
+  elem.addEventListener(wheelEventName,  
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchEvent, false);

 }
   }-*/;

@@ -83,7 +85,8 @@
   true
 );

-$wnd.addEventListener('DOMMouseScroll',  
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchCapturedMouseEvent,

+var wheelEventName = 'onwheel' in $doc ? 'wheel' : 'DOMMouseScroll';
+$wnd.addEventListener(wheelEventName,  
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchCapturedMouseEvent,

   true);
   }-*/;


--
To view, visit https://gwt-review.googlesource.com/3171
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6e8cb62ea195ca9e0253a74b4fc6fafbe6183da
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Support standardized DOM WheelEvent https://developer.mozill...

2013-06-05 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new patch set (#2).

Change subject: Support standardized DOM WheelEvent  
https://developer.mozilla.org/en-US/docs/Web/Reference/Events/wheel

..

Support standardized DOM WheelEvent
https://developer.mozilla.org/en-US/docs/Web/Reference/Events/wheel

Fixes issue 8012

Change-Id: Ia6e8cb62ea195ca9e0253a74b4fc6fafbe6183da
---
M user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
M user/src/com/google/gwt/user/client/impl/DOMImpl.java
M user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
3 files changed, 11 insertions(+), 1 deletion(-)


--
To view, visit https://gwt-review.googlesource.com/3171
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia6e8cb62ea195ca9e0253a74b4fc6fafbe6183da
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Support standardized DOM WheelEvent https://developer.mozill...

2013-06-05 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Support standardized DOM WheelEvent  
https://developer.mozilla.org/en-US/docs/Web/Reference/Events/wheel

..


Patch Set 2:

Yes, it's Firefox. For now, gwt 2.5.1 doesn't fire mouse wheel events. I  
tested this patch in Firefox in MacOs and it works.


--
To view, visit https://gwt-review.googlesource.com/3171
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6e8cb62ea195ca9e0253a74b4fc6fafbe6183da
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Support standardized DOM WheelEvent https://developer.mozill...

2013-06-05 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Support standardized DOM WheelEvent  
https://developer.mozilla.org/en-US/docs/Web/Reference/Events/wheel

..


Patch Set 2:

(1 comment)


File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
Line 329: if (chMask  0x2) elem.onwheel = elem.onmousewheel  =  
(bits  0x2) ?
I think it's ok for Firefox because on MDN it is said if wheel event is  
consumed then DOMMouseScroll would not be fired.

As for Microsoft, existing code should work as before


--
To view, visit https://gwt-review.googlesource.com/3171
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6e8cb62ea195ca9e0253a74b4fc6fafbe6183da
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Support standardized DOM WheelEvent https://developer.mozill...

2013-06-05 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Support standardized DOM WheelEvent  
https://developer.mozilla.org/en-US/docs/Web/Reference/Events/wheel

..


Patch Set 2:

I mean, I cannot get mouse wheel event on gwt widget.
I created issue back in February when I wanted to listen mousewheel events  
on canvas.


--
To view, visit https://gwt-review.googlesource.com/3171
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6e8cb62ea195ca9e0253a74b4fc6fafbe6183da
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Support standardized DOM WheelEvent https://developer.mozill...

2013-06-05 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Support standardized DOM WheelEvent  
https://developer.mozilla.org/en-US/docs/Web/Reference/Events/wheel

..


Patch Set 2:

(1 comment)


File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
Line 329: if (chMask  0x2) elem.onwheel = elem.onmousewheel  =  
(bits  0x2) ?

You mean, there could be problem with firing two events instead of one?
Maybe there should be a check to test if browser supports standard wheel  
event?



--
To view, visit https://gwt-review.googlesource.com/3171
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6e8cb62ea195ca9e0253a74b4fc6fafbe6183da
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Support standardized DOM WheelEvent https://developer.mozill...

2013-06-05 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Support standardized DOM WheelEvent  
https://developer.mozilla.org/en-US/docs/Web/Reference/Events/wheel

..


Patch Set 2:

I agree but what about future versions of browsers?
As for now webkit has open bug report, opera moving to blink.
Someday they will get support for standard wheel event and
we can provide consistent getMouseWheelVelocityY through e.deltaY

--
To view, visit https://gwt-review.googlesource.com/3171
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6e8cb62ea195ca9e0253a74b4fc6fafbe6183da
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Support standardized DOM WheelEvent https://developer.mozill...

2013-06-05 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Support standardized DOM WheelEvent  
https://developer.mozilla.org/en-US/docs/Web/Reference/Events/wheel

..


Patch Set 2:

Ok

--
To view, visit https://gwt-review.googlesource.com/3171
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6e8cb62ea195ca9e0253a74b4fc6fafbe6183da
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-04 Thread Andrey Korzhevskiy

Hello John A. Tamplin,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3184

to look at the new patch set (#7).

Change subject: Emulate java.util.Objects
..

Emulate java.util.Objects

Fixes issue 8173

Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
---
M user/super/com/google/gwt/emul/java/util/Arrays.java
A user/super/com/google/gwt/emul/java/util/Objects.java
M user/test/com/google/gwt/emultest/EmulSuite.java
A user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
4 files changed, 213 insertions(+), 58 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 7
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-04 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Emulate java.util.Objects
..


Patch Set 3:

(2 comments)


File user/super/com/google/gwt/emul/java/util/Arrays.java
Line 414:   static boolean deepEquals0(Object obj1, Object obj2) {
Done


Line 414:   static boolean deepEquals0(Object obj1, Object obj2) {
Done


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-03 Thread Andrey Korzhevskiy

Hello John A. Tamplin,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3184

to look at the new patch set (#4).

Change subject: Emulate java.util.Objects
..

Emulate java.util.Objects

Fixes issue 8173

Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
---
M user/super/com/google/gwt/emul/java/util/Arrays.java
A user/super/com/google/gwt/emul/java/util/Objects.java
M user/test/com/google/gwt/emultest/EmulSuite.java
A user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
4 files changed, 203 insertions(+), 55 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

2013-06-03 Thread Andrey Korzhevskiy

Hello Daniel Kurka, John A. Tamplin,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3183

to look at the new patch set (#5).

Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..

Emulate Boolean.compare(boolean,boolean), Character.compare(char,char)

Fixes issue 8172

Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
---
M user/super/com/google/gwt/emul/java/lang/Boolean.java
M user/super/com/google/gwt/emul/java/lang/Character.java
M user/test/com/google/gwt/emultest/java/lang/BooleanTest.java
M user/test/com/google/gwt/emultest/java/lang/CharacterTest.java
4 files changed, 26 insertions(+), 5 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-03 Thread Andrey Korzhevskiy

Hello John A. Tamplin,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3184

to look at the new patch set (#5).

Change subject: Emulate java.util.Objects
..

Emulate java.util.Objects

Fixes issue 8173

Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
---
M user/super/com/google/gwt/emul/java/util/Arrays.java
A user/super/com/google/gwt/emul/java/util/Objects.java
M user/test/com/google/gwt/emultest/EmulSuite.java
A user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
4 files changed, 203 insertions(+), 55 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-03 Thread Andrey Korzhevskiy

Hello John A. Tamplin,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3184

to look at the new patch set (#6).

Change subject: Emulate java.util.Objects
..

Emulate java.util.Objects

Fixes issue 8173

Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
---
M user/super/com/google/gwt/emul/java/util/Arrays.java
A user/super/com/google/gwt/emul/java/util/Objects.java
M user/test/com/google/gwt/emultest/EmulSuite.java
A user/test/com/google/gwt/emultest/java/util/ObjectsTest.java
4 files changed, 227 insertions(+), 55 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

2013-06-03 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..


Patch Set 5:

(1 comment)

There's been a lot of questions about signum usage in Character.compare:

It was suggested to use signum in Integer.compare  
(https://gwt-review.googlesource.com/3180). If all reviewers agree to use  
simple substract (x-y) then I will make this change here too.



File user/super/com/google/gwt/emul/java/lang/Character.java
Line 175: return Integer.signum(x - y);
It was suggested to use signum in Integer.compare  
(https://gwt-review.googlesource.com/3180)

So we need decision to change this in two issues at once


--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

2013-06-03 Thread Andrey Korzhevskiy

Hello Daniel Kurka, John A. Tamplin,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3183

to look at the new patch set (#6).

Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..

Emulate Boolean.compare(boolean,boolean), Character.compare(char,char)

Fixes issue 8172

Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
---
M user/super/com/google/gwt/emul/java/lang/Boolean.java
M user/super/com/google/gwt/emul/java/lang/Character.java
M user/test/com/google/gwt/emultest/java/lang/BooleanTest.java
M user/test/com/google/gwt/emultest/java/lang/CharacterTest.java
4 files changed, 26 insertions(+), 5 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-03 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Emulate java.util.Objects
..


Patch Set 6:

@Thomas: Objects.equals has the same code as Objects.equals in JDK 7 and  
Google Guava library. May be we should keep it the same?


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-03 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Emulate java.util.Objects
..


Patch Set 6:

Oh, I'm sorry, I just dont know why gerrit doesn't show you my comments. I  
replied and saved comments. After that gerrit showed them as draft but i  
didnt find any button to publish it so i thought my comments appeared  
visible to everyone.


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-03 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Emulate java.util.Objects
..


Patch Set 3:

(3 comments)


File user/super/com/google/gwt/emul/java/util/Arrays.java
Line 414:   static boolean deepEquals0(Object obj1, Object obj2) {
Yes, I thought about that. It would gracefully solve issue of code reuse  
and readability. But the code with multiple instanceof looks like it  
belongs to Arrays, doesn't it?




File user/super/com/google/gwt/emul/java/util/Objects.java
Line 32: return Arrays.deepEquals0(a, b);
I disagree, it handles non-array objects.
I extracted common method to deepEquals0 but now I see
that Arrays.deepEquals0 is semantically wrong here.
Will fix it


Line 36: return (a == b) || (a != null  a.equals(b));
This code is the same as in Java 7 and in Guava Objects.equals.
I think Oracle guys copied it from Google and I then copied it to GWT :)


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

2013-06-02 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..


Patch Set 7:

Sorry for intrusion, can we also get Java 7 compare methods for Boolean and  
Character classes?


--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 7
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

2013-06-02 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: adding compare for several number types  -Byte.compare  
-Short.compare -Integer.compare -Long.compare -Float.compare  (Double  
already exists)  fixes issue 7998

..


Patch Set 8:

@Daniel: Sure

--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

2013-06-02 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new change for review.

  https://gwt-review.googlesource.com/3183


Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..

Emulate Boolean.compare(boolean,boolean), Character.compare(char,char)

Fixes issue 8172

Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
---
M user/super/com/google/gwt/emul/java/lang/Boolean.java
M user/super/com/google/gwt/emul/java/lang/Character.java
M user/test/com/google/gwt/emultest/java/lang/BooleanTest.java
M user/test/com/google/gwt/emultest/java/lang/CharacterTest.java
4 files changed, 26 insertions(+), 5 deletions(-)



diff --git a/user/super/com/google/gwt/emul/java/lang/Boolean.java  
b/user/super/com/google/gwt/emul/java/lang/Boolean.java

index b8d8c1a..1b1b673 100644
--- a/user/super/com/google/gwt/emul/java/lang/Boolean.java
+++ b/user/super/com/google/gwt/emul/java/lang/Boolean.java
@@ -33,6 +33,10 @@

   public static final ClassBoolean TYPE = boolean.class;

+  public static int compare(boolean x, boolean y) {
+return (x == y) ? 0 : (x ? 1 : -1);
+  }
+
   public static boolean parseBoolean(String s) {
 return true.equalsIgnoreCase(s);
   }
@@ -63,8 +67,8 @@
 return value;
   }

-  public int compareTo(Boolean other) {
-return (this.value == other.value) ? 0 : (this.value ? 1 : -1);
+  public int compareTo(Boolean b) {
+return compare(value, b.value);
   }

   @Override
diff --git a/user/super/com/google/gwt/emul/java/lang/Character.java  
b/user/super/com/google/gwt/emul/java/lang/Character.java

index 21ae92a..4a25737 100644
--- a/user/super/com/google/gwt/emul/java/lang/Character.java
+++ b/user/super/com/google/gwt/emul/java/lang/Character.java
@@ -170,6 +170,11 @@
 return count;
   }

+  public static int compare(char x, char y) {
+// JLS specifies that the chars are promoted to int before subtraction.
+return x - y;
+  }
+
   /*
* TODO: correct Unicode handling.
*/
@@ -446,8 +451,7 @@
   }

   public int compareTo(Character c) {
-// JLS specifies that the chars are promoted to int before subtraction.
-return value - c.value;
+return compare(value, c.value);
   }

   @Override
diff --git a/user/test/com/google/gwt/emultest/java/lang/BooleanTest.java  
b/user/test/com/google/gwt/emultest/java/lang/BooleanTest.java

index c12b931..917ea15 100644
--- a/user/test/com/google/gwt/emultest/java/lang/BooleanTest.java
+++ b/user/test/com/google/gwt/emultest/java/lang/BooleanTest.java
@@ -49,6 +49,12 @@
 assertFalse(new Boolean(false4));
   }

+  public void testCompare() {
+assertTrue(Boolean.compare failed for false  true,  
Boolean.compare(false, true)  0);
+assertTrue(Boolean.compare failed for true  false,  
Boolean.compare(true, false)  0);

+assertEquals(0, Boolean.compare(true, true));
+  }
+
   public void testParseBoolean() {
 assertTrue(Boolean.parseBoolean(true1));
 assertTrue(Boolean.parseBoolean(true2));
diff --git a/user/test/com/google/gwt/emultest/java/lang/CharacterTest.java  
b/user/test/com/google/gwt/emultest/java/lang/CharacterTest.java

index 6a24ce6..79579d6 100644
--- a/user/test/com/google/gwt/emultest/java/lang/CharacterTest.java
+++ b/user/test/com/google/gwt/emultest/java/lang/CharacterTest.java
@@ -233,7 +233,14 @@
 assertEquals(0x10346, Character.codePointAt(nonBmpChar, 0));
 assertEquals(1, Character.codePointCount(nonBmpChar, 0, 2));
   }
-
+
+  public void testCompare() {
+assertTrue(Character.compare failed for 'A'  'B',  
Character.compare(Character.valueOf('A'), Character.valueOf('B'))  0);
+assertTrue(Character.compare failed for 'B'  'A',  
Character.compare(Character.valueOf('B'), Character.valueOf('A'))  0);
+assertEquals(0, Character.compare(Character.valueOf('C'),  
Character.valueOf('C')));
+assertTrue(Character.compare failed for '\uA001'  '\uA000',  
Character.compare(Character.valueOf('\uA001'), Character.valueOf('\uA000'))  

0);

+  }
+
   public void testCompareTo() {
 assertTrue(Character.valueOf('A').compareTo('B')  0);
 assertTrue(Character.valueOf('B').compareTo('A')  0);

--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

2013-06-02 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new patch set (#2).

Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..

Emulate Boolean.compare(boolean,boolean), Character.compare(char,char)

Fixes issue 8172

Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
---
M user/super/com/google/gwt/emul/java/lang/Boolean.java
M user/super/com/google/gwt/emul/java/lang/Character.java
M user/test/com/google/gwt/emultest/java/lang/BooleanTest.java
M user/test/com/google/gwt/emultest/java/lang/CharacterTest.java
4 files changed, 30 insertions(+), 5 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

2013-06-02 Thread Andrey Korzhevskiy

Hello John A. Tamplin,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3183

to look at the new patch set (#3).

Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..

Emulate Boolean.compare(boolean,boolean), Character.compare(char,char)

Fixes issue 8172

Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
---
M user/super/com/google/gwt/emul/java/lang/Boolean.java
M user/super/com/google/gwt/emul/java/lang/Character.java
M user/test/com/google/gwt/emultest/java/lang/BooleanTest.java
M user/test/com/google/gwt/emultest/java/lang/CharacterTest.java
4 files changed, 30 insertions(+), 5 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

2013-06-02 Thread Andrey Korzhevskiy

Hello Daniel Kurka, John A. Tamplin,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3183

to look at the new patch set (#4).

Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..

Emulate Boolean.compare(boolean,boolean), Character.compare(char,char)

Fixes issue 8172

Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
---
M user/super/com/google/gwt/emul/java/lang/Boolean.java
M user/super/com/google/gwt/emul/java/lang/Character.java
M user/test/com/google/gwt/emultest/java/lang/BooleanTest.java
M user/test/com/google/gwt/emultest/java/lang/CharacterTest.java
4 files changed, 30 insertions(+), 5 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

2013-06-02 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Emulate Boolean.compare(boolean,boolean),  
Character.compare(char,char)

..


Patch Set 4:

patch set 4: i made Character.compare use Integer.signum

--
To view, visit https://gwt-review.googlesource.com/3183
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00df601b33cb5e270be45819c1ad54ae9c955869
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-02 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new change for review.

  https://gwt-review.googlesource.com/3184


Change subject: Emulate java.util.Objects
..

Emulate java.util.Objects

Fixes issue 8173

Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
---
M user/super/com/google/gwt/emul/java/util/Arrays.java
A user/super/com/google/gwt/emul/java/util/Objects.java
2 files changed, 113 insertions(+), 55 deletions(-)



diff --git a/user/super/com/google/gwt/emul/java/util/Arrays.java  
b/user/super/com/google/gwt/emul/java/util/Arrays.java

index 644d607..0858ad3 100644
--- a/user/super/com/google/gwt/emul/java/util/Arrays.java
+++ b/user/super/com/google/gwt/emul/java/util/Arrays.java
@@ -399,66 +399,56 @@
 }

 for (int i = 0, n = a1.length; i  n; ++i) {
-
-  Object obj1 = a1[i];
-  Object obj2 = a2[i];
-  if (obj1 == obj2) {
-continue;
-  }
-  if (obj1 == null || obj2 == null) {
+  if (!deepEquals0(a1[i], a2[i])) {
 return false;
   }
-  if (obj1.equals(obj2)) {
-continue;
-  }
-  Class? class1 = obj1.getClass();
-  Class? class2 = obj2.getClass();
+}

-  // We have to test and see if these are two arrays of the same type,
-  // then see what types of arrays they are and dispatch to the
-  // appropriate equals
+return true;
+  }

-  if (!class1.isArray() || !class1.equals(class2)) {
-return false;
-  }
+  /**
+   * Helper function for {@link Arrays#deepEquals(Object[], Object[])}
+   * and {@link Objects#deepEquals(Object[], Object[])}.
+   */
+  static boolean deepEquals0(Object obj1, Object obj2) {
+if (obj1 == obj2) {
+  return true;
+} else if (obj1 == null || obj2 == null) {
+  return false;
+} else if (obj1.equals(obj2)) {
+  return true;
+}

-  if (obj1 instanceof Object[]) {
-if (!deepEquals((Object[]) obj1, (Object[]) obj2)) {
-  return false;
-}
-  } else if (obj1 instanceof boolean[]) {
-if (!equals((boolean[]) obj1, (boolean[]) obj2)) {
-  return false;
-}
-  } else if (obj1 instanceof byte[]) {
-if (!equals((byte[]) obj1, (byte[]) obj2)) {
-  return false;
-}
-  } else if (obj1 instanceof char[]) {
-if (!equals((char[]) obj1, (char[]) obj2)) {
-  return false;
-}
-  } else if (obj1 instanceof short[]) {
-if (!equals((short[]) obj1, (short[]) obj2)) {
-  return false;
-}
-  } else if (obj1 instanceof int[]) {
-if (!equals((int[]) obj1, (int[]) obj2)) {
-  return false;
-}
-  } else if (obj1 instanceof long[]) {
-if (!equals((long[]) obj1, (long[]) obj2)) {
-  return false;
-}
-  } else if (obj1 instanceof float[]) {
-if (!equals((float[]) obj1, (float[]) obj2)) {
-  return false;
-}
-  } else if (obj1 instanceof double[]) {
-if (!equals((double[]) obj1, (double[]) obj2)) {
-  return false;
-}
-  }
+Class? class1 = obj1.getClass();
+Class? class2 = obj2.getClass();
+
+// We have to test and see if these are two arrays of the same type,
+// then see what types of arrays they are and dispatch to the
+// appropriate equals
+
+if (!class1.isArray() || !class1.equals(class2)) {
+  return false;
+}
+
+if (obj1 instanceof Object[]) {
+  return deepEquals((Object[]) obj1, (Object[]) obj2);
+} else if (obj1 instanceof boolean[]) {
+  return equals((boolean[]) obj1, (boolean[]) obj2);
+} else if (obj1 instanceof byte[]) {
+  return equals((byte[]) obj1, (byte[]) obj2);
+} else if (obj1 instanceof char[]) {
+  return equals((char[]) obj1, (char[]) obj2);
+} else if (obj1 instanceof short[]) {
+  return equals((short[]) obj1, (short[]) obj2);
+} else if (obj1 instanceof int[]) {
+  return equals((int[]) obj1, (int[]) obj2);
+} else if (obj1 instanceof long[]) {
+  return equals((long[]) obj1, (long[]) obj2);
+} else if (obj1 instanceof float[]) {
+  return equals((float[]) obj1, (float[]) obj2);
+} else if (obj1 instanceof double[]) {
+  return equals((double[]) obj1, (double[]) obj2);
 }

 return true;
diff --git a/user/super/com/google/gwt/emul/java/util/Objects.java  
b/user/super/com/google/gwt/emul/java/util/Objects.java

new file mode 100644
index 000..1b25730
--- /dev/null
+++ b/user/super/com/google/gwt/emul/java/util/Objects.java
@@ -0,0 +1,68 @@
+/*
+ * Copyright 2008 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License

[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-02 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new patch set (#2).

Change subject: Emulate java.util.Objects
..

Emulate java.util.Objects

Fixes issue 8173

Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
---
M user/super/com/google/gwt/emul/java/util/Arrays.java
A user/super/com/google/gwt/emul/java/util/Objects.java
2 files changed, 113 insertions(+), 55 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-02 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new patch set (#3).

Change subject: Emulate java.util.Objects
..

Emulate java.util.Objects

Fixes issue 8173

Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
---
M user/super/com/google/gwt/emul/java/util/Arrays.java
A user/super/com/google/gwt/emul/java/util/Objects.java
2 files changed, 113 insertions(+), 55 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-31 Thread Andrey Korzhevskiy

Hello Colin Alworth, Thomas Broyer, Goktug Gokdogan,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3070

to look at the new patch set (#5).

Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..

Add hasClassName method in com.google.gwt.dom.client.Element

Fixes issue 7550

Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
---
M user/src/com/google/gwt/dom/client/Element.java
M user/test/com/google/gwt/dom/client/ElementTest.java
2 files changed, 87 insertions(+), 67 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Colin Alworth niloc...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-31 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has abandoned this change.

Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..


Abandoned

broken style

--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Colin Alworth niloc...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-31 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has restored this change.

Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..


Restored

--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Colin Alworth niloc...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-31 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..


Patch Set 5:

Uploaded patch set 5: sorted methods according gwt code style.

--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Colin Alworth niloc...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-31 Thread Andrey Korzhevskiy

Hello Colin Alworth, Thomas Broyer, Goktug Gokdogan,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3070

to look at the new patch set (#6).

Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..

Add hasClassName method in com.google.gwt.dom.client.Element

Fixes issue 7550

Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
---
M user/src/com/google/gwt/dom/client/Element.java
M user/test/com/google/gwt/dom/client/ElementTest.java
2 files changed, 29 insertions(+), 9 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Colin Alworth niloc...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-30 Thread Andrey Korzhevskiy

Hello Colin Alworth, Thomas Broyer, Goktug Gokdogan,

I'd like you to reexamine a change.  Please visit

https://gwt-review.googlesource.com/3070

to look at the new patch set (#4).

Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..

Add hasClassName method in com.google.gwt.dom.client.Element

Fixes issue 7550

Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
---
M user/src/com/google/gwt/dom/client/Element.java
M user/test/com/google/gwt/dom/client/ElementTest.java
2 files changed, 29 insertions(+), 9 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Colin Alworth niloc...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-30 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..


Patch Set 4:

Uploaded patch set 4:
  I removed javadoc for trimClassName

--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Colin Alworth niloc...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-29 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new change for review.

  https://gwt-review.googlesource.com/3070


Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..

Add hasClassName method in com.google.gwt.dom.client.Element

Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
---
M user/src/com/google/gwt/dom/client/Element.java
M user/test/com/google/gwt/dom/client/ElementTest.java
2 files changed, 36 insertions(+), 9 deletions(-)



diff --git a/user/src/com/google/gwt/dom/client/Element.java  
b/user/src/com/google/gwt/dom/client/Element.java

index 7d1fd5b..dd0abd5 100644
--- a/user/src/com/google/gwt/dom/client/Element.java
+++ b/user/src/com/google/gwt/dom/client/Element.java
@@ -89,10 +89,7 @@
* @see #setClassName(String)
*/
   public final boolean addClassName(String className) {
-assert (className != null) : Unexpectedly null class name;
-
-className = className.trim();
-assert (className.length() != 0) : Unexpectedly empty class name;
+className = checkClassName(className);

 // Get the current style string.
 String oldClassName = getClassName();
@@ -108,6 +105,18 @@
   return true;
 }
 return false;
+  }
+
+  /**
+   * Checks if this element's class property contains specified class name.
+   *
+   * @param className the class name to be added
+   * @return codetrue/code if this element has the specified class name
+   */
+  public final boolean hasClassName(String className) {
+className = checkClassName(className);
+int idx = indexOfName(getClassName(), className);
+return idx != -1;
   }

   /**
@@ -524,10 +533,7 @@
* @see #setClassName(String)
*/
   public final boolean removeClassName(String className) {
-assert (className != null) : Unexpectedly null class name;
-
-className = className.trim();
-assert (className.length() != 0) : Unexpectedly empty class name;
+className = checkClassName(className);

 // Get the current style string.
 String oldStyle = getClassName();
@@ -582,6 +588,21 @@
   }

   /**
+   * Checks if className is valid and trims it.
+   *
+   * @param className a non-empty string
+   * @return trimmed class name string
+   */
+  static String checkClassName(String className) {
+assert (className != null) : Unexpectedly null class name;
+
+className = className.trim();
+assert (className.length() != 0) : Unexpectedly empty class name;
+
+return className;
+  }
+
+  /**
* Replace one class name with another.
*
* @param oldClassName the class name to be replaced
diff --git a/user/test/com/google/gwt/dom/client/ElementTest.java  
b/user/test/com/google/gwt/dom/client/ElementTest.java

index a1e6145..b79a784 100644
--- a/user/test/com/google/gwt/dom/client/ElementTest.java
+++ b/user/test/com/google/gwt/dom/client/ElementTest.java
@@ -34,7 +34,7 @@
 return com.google.gwt.dom.DOMTest;
   }

-  public void testAddRemoveReplaceClassName() {
+  public void testAddRemoveReplaceHasClassName() {
 DivElement div = Document.get().createDivElement();

 div.setClassName(foo);
@@ -64,6 +64,12 @@

 assertTrue(div.removeClassName(foo));
 assertEquals(, div.getClassName());
+
+div.setClassName(foo bar);
+assertTrue(div.hasClassName(bar));
+assertTrue(div.hasClassName(foo));
+div.removeClassName(foo);
+assertFalse(div.hasClassName(foo));
   }

   public void testIndexOfName() {

--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-29 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new change for review.

  https://gwt-review.googlesource.com/3071


Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..

Add hasClassName method in com.google.gwt.dom.client.Element

Change-Id: Ibe9a1aacb3530c9c688ab321e64f6dff95eb2b20
---
M user/src/com/google/gwt/dom/client/Element.java
M user/test/com/google/gwt/dom/client/ElementTest.java
2 files changed, 7 insertions(+), 8 deletions(-)



diff --git a/user/src/com/google/gwt/dom/client/Element.java  
b/user/src/com/google/gwt/dom/client/Element.java

index dd0abd5..c9c9592 100644
--- a/user/src/com/google/gwt/dom/client/Element.java
+++ b/user/src/com/google/gwt/dom/client/Element.java
@@ -89,7 +89,7 @@
* @see #setClassName(String)
*/
   public final boolean addClassName(String className) {
-className = checkClassName(className);
+className = trimClassName(className);

 // Get the current style string.
 String oldClassName = getClassName();
@@ -114,7 +114,7 @@
* @return codetrue/code if this element has the specified class name
*/
   public final boolean hasClassName(String className) {
-className = checkClassName(className);
+className = trimClassName(className);
 int idx = indexOfName(getClassName(), className);
 return idx != -1;
   }
@@ -533,7 +533,7 @@
* @see #setClassName(String)
*/
   public final boolean removeClassName(String className) {
-className = checkClassName(className);
+className = trimClassName(className);

 // Get the current style string.
 String oldStyle = getClassName();
@@ -588,17 +588,15 @@
   }

   /**
-   * Checks if className is valid and trims it.
+   * Trim class name.
*
* @param className a non-empty string
* @return trimmed class name string
*/
-  static String checkClassName(String className) {
+  private static String trimClassName(String className) {
 assert (className != null) : Unexpectedly null class name;
-
 className = className.trim();
-assert (className.length() != 0) : Unexpectedly empty class name;
-
+assert !className.isEmpty() : Unexpectedly empty class name;
 return className;
   }

diff --git a/user/test/com/google/gwt/dom/client/ElementTest.java  
b/user/test/com/google/gwt/dom/client/ElementTest.java

index b79a784..907f736 100644
--- a/user/test/com/google/gwt/dom/client/ElementTest.java
+++ b/user/test/com/google/gwt/dom/client/ElementTest.java
@@ -70,6 +70,7 @@
 assertTrue(div.hasClassName(foo));
 div.removeClassName(foo);
 assertFalse(div.hasClassName(foo));
+assertTrue(div.hasClassName(bar));
   }

   public void testIndexOfName() {

--
To view, visit https://gwt-review.googlesource.com/3071
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe9a1aacb3530c9c688ab321e64f6dff95eb2b20
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-29 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has posted comments on this change.

Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..


Patch Set 2:

Sorry, i accidently pushed to a new review  
https://gwt-review.googlesource.com/3071


Should i do anything about that?

--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-HasComments: No

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-29 Thread Andrey Korzhevskiy

Andrey Korzhevskiy has uploaded a new patch set (#3).

Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..

Add hasClassName method in com.google.gwt.dom.client.Element

Fixes issue 7550

Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
---
M user/src/com/google/gwt/dom/client/Element.java
M user/test/com/google/gwt/dom/client/ElementTest.java
2 files changed, 35 insertions(+), 9 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups GWT Contributors group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: Servlet Response formatting in IE

2013-05-01 Thread Andrey
servlet side:

private String encodeXMLContent(String encodedContent) {
encodedContent = encodedContent.replace(, lt;);
encodedContent = encodedContent.replace(, gt;);
return encodedContent;
}

On the client side 
private String decodeUploadContent(String xml) {
String result = xml.toLowerCase();
result = result.replace(amp;lt;, );
result = result.replace(amp;gt;, );
result = result.replace(pre, );
result = result.replace(/pre, );
return result;
}

суббота, 20 декабря 2008 г., 1:05:42 UTC+3 пользователь D L H написал:

 Hello. 

 I have a Java servlet that reads an xml-based file and sends the 
 contents to my gwt application as an HttpServletResponse. I have the 
 content type set to text/plain in the servlet. On the client side I 
 use event.getResults() inside the onSubmitComplete method of the form 
 handler. 

 Everything runs smoothly in Firefox, but when I tested in IE7, it 
 would not work properly. I used a Label for debugging to see what 
 exactly the application was reading from the servlet, and in IE i'm 
 getting a buncha HTML stuff like this: 

 DIV class=eSPAN class=bnbsp;/SPAN SPAN class=mlt;?/ 
 SPANSPAN class=pixml version=1.0 /SPANSPAN class=m?gt;/ 
 SPAN /DIV 

 How do I get IE7 to format my servlet response as plain text instead 
 of html?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




Re: empty ghost place token getting created

2013-02-20 Thread Andrey Nemchenko
The same situation. I removed handlers but it didn't help.
The problem 
in com.google.gwt.place.shared.PlaceHistoryHandler#tokenForPlace:

if (defaultPlace.equals(newPlace)) {
return ;
}

Solution in using empty () token for default place.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.




embed web font just like @sprite

2012-08-21 Thread Andrey Korzhevskiy
Is there a way to embed font file into css via data-uri just like @sprite 
does it to embed images?
i mean if i write this:

@font-face {
font-family: 'MyFont';
src: url(MySuperWebFont.otf);
}

then gwt would generate css like this:

@font-face {
font-family: ' MyFont ';
src: url(data:font/opentype;base64,[base-encoded font here]);
}

Thanks.


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/5VxBdBko4y0J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: embed web font just like @sprite

2012-08-21 Thread Andrey Korzhevskiy
Yeah, right, thank you but...

One can use @sprite images without explicit declaring in DataResources etc.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/mtZwgLwR7CYJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT 2.5.0-rc1 and eclipse (3.7 and 4.2) problems

2012-07-06 Thread Andrey Korzhevskiy
I had that problem. The solution is to clean cache/cookies/etc in your 
browser (i use firefox for devmode).

среда, 4 июля 2012 г., 9:36:51 UTC+4 пользователь Juan Pablo Gardella 
написал:

 Hi folks,

 I tried with eclipse 3.7 and eclipse 4.2 run inside eclipse with GWT 
 2.5.0-rc1 and had the same error in both. If I compile with maven the 
 application run well, but in dev mode fails. I'm using FF13 with the last 
 plugin.

 Could any tell me some tips to use GWT 2.5.0-rc1 inside eclipse?

 Thanks in advance.

 I paste the stacktrace here:

 02:32:43.765 [ERROR] [myapp] Unable to load module entry point class 
 com.google.gwt.useragent.client.UserAgentAsserter (see associated exception 
 for details)

 java.lang.RuntimeException: Deferred binding failed for 
 'com.google.gwt.useragent.client.UserAgentAsserter$UserAgentProperty' (did 
 you forget to inherit a required module?)
 at com.google.gwt.dev.shell.GWTBridgeImpl.create(GWTBridgeImpl.java:53)
 at com.google.gwt.core.shared.GWT.create(GWT.java:57)
 at com.google.gwt.core.client.GWT.create(GWT.java:85)
 at 
 com.google.gwt.useragent.client.UserAgentAsserter.onModuleLoad(UserAgentAsserter.java:66)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at com.google.gwt.dev.shell.ModuleSpace.onLoad(ModuleSpace.java:405)
 at 
 com.google.gwt.dev.shell.OophmSessionHandler.loadModule(OophmSessionHandler.java:200)
 at 
 com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:526)
 at 
 com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:364)
 at java.lang.Thread.run(Thread.java:619)
 Caused by: com.google.gwt.core.ext.UnableToCompleteException: (see 
 previous log entries)
 at com.google.gwt.dev.shell.ModuleSpace.rebind(ModuleSpace.java:604)
 at 
 com.google.gwt.dev.shell.ModuleSpace.rebindAndCreate(ModuleSpace.java:464)
 at com.google.gwt.dev.shell.GWTBridgeImpl.create(GWTBridgeImpl.java:49)
 at com.google.gwt.core.shared.GWT.create(GWT.java:57)
 at com.google.gwt.core.client.GWT.create(GWT.java:85)
 at 
 com.google.gwt.useragent.client.UserAgentAsserter.onModuleLoad(UserAgentAsserter.java:66)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at com.google.gwt.dev.shell.ModuleSpace.onLoad(ModuleSpace.java:405)
 at 
 com.google.gwt.dev.shell.OophmSessionHandler.loadModule(OophmSessionHandler.java:200)
 at 
 com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:526)
 at 
 com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:364)
 at java.lang.Thread.run(Thread.java:619)




-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/hcvJz-Gt-ogJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Editor onPropertyChange

2012-04-08 Thread Andrey Minogin
How can I handle property change event on an editor?
Is this feature implemented? It seems that 
com.google.gwt.editor.client.ValueAwareEditor.onPropertyChange(String... 
paths) is not being called from anywhere.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/db8XvUEanQIJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Editor onPropertyChange

2012-04-08 Thread Andrey Minogin
How can I handle property change in an Editor?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/5Csx6ivfQ24J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT strange code generation on float numbers

2012-02-20 Thread Andrey Korzhevskiy
.01 can be expressed in JS floating number. The thing is not in IEEE 
and runtime number representation. The thing is in that literal constant 
should not be changed.
I mean if in Java code I see   'float myNum = 0.01', I expect to see it 
in generated JS as 'var myNum = 0.01'

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/i999wNTvMx0J.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



GWT strange code generation on float numbers

2012-02-08 Thread Andrey Korzhevskiy
Hello everyone,

I found interesting issue. Suppose I have this java code:

float f = 0.01f;
someFunc(f)

which is generated by GWT into js code, something like that

someFunc(9.9534e-7) 


So my question is: if GWT sees constant in code why it processes this 
constant so strange? I expect to see in generated js this call: 
someFunc(0.01)
Is there some complex float numbers processing in gwt-dev?


Thank you, 
Andrew

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/google-web-toolkit/-/Xu_5RbBiR5cJ.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



The data in Sub-Editors not saved in the database with using Editors and RequestFactory

2011-10-04 Thread Andrey Kadatsky
Hi all!
I am beginning programmer, learning GWT, the first link on request
GWT forum led here, so I decided to ask here. English is not my
native language, but I hope that you will understand the essence.
Individually each simple Editor successfully stored in the database:
(http://pastebin.com/S2UrzAGG)

BaseEditor extends LayoutPanel implements EditorOrderProxy {
private OrderPresenterClientProxy listener;
protected void saveButtonClick() {
listener.persist();
}
}


public class OrderClientActivity implements Activity, OrderPresenter {

private OrderClientWorkArea view;
private OrderClientDriver driver; // public interface
OrderClientDriver extends RequestFactoryEditorDriverOrderProxy,
OrderClientEditor
private OrderProxy currentItem; // public interface OrderProxy
extends EntityProxy
private OrderServiceRF currentContext; // public interface
OrderServiceRF extends RequestContext

public void persist() {
driver.flush();
currentContext.persist(currentItem).fire(new
ReceiverOrderProxy() {
@Override
public void onSuccess(OrderProxy response) {
History.back();
}
});
}

public void start(AcceptsOneWidget panel, EventBus eventBus) {
driver = GWT.create(OrderClientDriver.class);
driver.initialize(view.getEditor());
currentContext =
clientFactory.getEdocRequestFactory().getOrderService();

final OrderServiceRF service =
clientFactory.getEdocRequestFactory().getOrderService();
service.getAll().with( driver.getPaths() ).fire(new
ReceiverListOrderProxy() {
@Override
public void onSuccess(ListOrderProxy response) {
itemEditCurrent(response);
}
});
}

protected void itemEditCurrent(ListOrderProxy items) {
currentItem = findItemById(id,items);
view.showEditor(true);
driver.edit(currentItem, currentContext);
}
}

I want dynamically add Sub-Editors, for example on VerticalPanel, some
Sub-Editors have CellTable with a list of related objects, and I can
edit Sub-Editors fields and  theys CellTable. How to do that when I
clicked the Save button on Top-Level Editor all changes save to
database?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



GWT checkbox widget with custom id atribute for checkbox input

2011-07-20 Thread Andrey
Hi All,

GWT checkbox widget generates the code below:
span id=row_number_1 
  input type=checkbox id=gwt-uid-XXX disabled=
  label for=gwt-uid-70.../label
/span

gwt-uid-XXX, where XXX is auto generated values.
Is it possible to assign custom IDs (or pattern) to checkbox input for
example:

span
  input type=checkbox id=row_number_1 disabled=
  label for=row_number_1.../label
/span

Or

span
  input type=checkbox id=gwt-uid-XXX_row_number_1 disabled=
  label for= gwt-uid-XXX_row_number_1.../label
/span


Best regards,
Andrey.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: problema de integracion con Eclipse

2011-03-28 Thread Andrey
Dear Author and others: please, write in English! Because it is
mentioned that this group is in English!
I suppose i have same problem with Eclipse-GWT integration and i cant
read your message!(((

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Error when installing GWT plugin for Eclipse 3.6

2011-03-28 Thread Andrey
Hi all!

When i'm installing and it is already half a progress bar i recieve
following error message:

An error occurred while collecting items to be installed
session context was:(profile=epp.package.java,
phase=org.eclipse.equinox.internal.p2.engine.phases.Collect, operand=,
action=).
Unable to read repository at
http://dl.google.com/eclipse/plugin/3.6/plugins/com.google.gwt.eclipse.sdkbundle.2.2.0_2.2.0.v201102111811.jar.
Read timed out

King Google, do something! =)

PS Please, do not post messages like check your internet connection

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Error when installing GWT plugin for Eclipse 3.6

2011-03-28 Thread Andrey
Already used that variant (your links are equal) - it havn't helped:
there is another kind of error like There is no repository in your
archive file.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Error when installing GWT plugin for Eclipse 3.6

2011-03-28 Thread Andrey
Sorry for my last post: i've downloaded GWT from another link before
and it didn't work. Now i tried your link and all is fine!
At last i'm ready for tutorials and quick start! Hooray! =)

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Cannot change CSS in dev mode

2011-03-04 Thread Andrey
When running GWT app in dev mode static web resources such as css-
files cannot be changed.
To change a line in css I must stop server, change and run again.
That's really inconvenient.

Is there any workaround?

Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Cannot change CSS in dev mode

2011-03-04 Thread Andrey
 Ben
They are not caching. They are locked by Jetty and eclipse cannot save
the changes (File is not writeable).

 Brian
This doesn't concern GWT ClientBundles. It concerns dev mode Jetty
behaviour.
Jetty locks all static resources while running. That's really strange.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Multi url GWT app

2010-12-16 Thread Andrey
Hello!

Consider we have a web site with static pages like:
/index
/products
/contacts
...

And we want to add dynamic GWT pages like:
/request (a request form)
/register (register form)
/price (price calculator)
...

What is the best way to perform this?

I don't want to create a separate GWT module for every url because it
takes too much time to compile them all.

Thanks in advance!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



MVP docs/tutorials/examples

2010-12-07 Thread Andrey
Hello,

We are going to use GWT 2.1 MVP in our projects.
The problem is that there seems to be too little information about
this framework. This doc is very poor:

http://code.google.com/webtoolkit/doc/latest/DevGuideMvpActivitiesAndPlaces.html

For example it tells nothing about how to use EventBus, where to place
event handlers, how to register activities/controllers and so on. The
HelloMVP example doesn't even contain any custom Event.

Are there any additional docs/examples/tutorials concerning GWT 2.1
MVP with its Activities, Places, etc.?

Thanks in advance!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



TOOLTIPS FOR HEADER GRID !!!

2010-10-07 Thread Andrey H.
I set tooltip text for header grid (ColumnConfig.setToolTip), BUT I
CAN'T SET TOOLTIP CONFIGURATION!!!
I need for set ToolTipConfig.dismissDelay property, because
dismissDelay by default 5000ms. Tooltips disappeared after 5sec and
it's look very ugly!!!

It's bug or may be I mistake? How I can set ToolTipConfig.dismissDelay?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Problem with call Window.open inside AsyncCallback.onSuccess for IE

2010-10-06 Thread Andrey H.
Hi All!
I have strange problem: When I call Window.open function(servlet,
which return file for download) inside AsyncCallback.onSuccess,  then
new tab opens and immediately closed, the file isn't downloaded. For
Fierfox it's work fine, for IE - bad.

This part of code:

new AsyncCallbackBeanModel()
{
   public void onSuccess(BeanModel model)
   {
  Window.open(GWT.getModuleBaseURL() + SomeServlet,
_blank, );
   }
});

I need for a help.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Can we run selenium tests in GWT dev mode?

2010-09-17 Thread Andrey
That doesn't work. My question is: how should we run selenium in dev
mode?

On Sep 16, 6:13 pm, András Csányi sayusi.a...@gmail.com wrote:
 On 16 September 2010 16:07, Andrey mino...@gmail.com wrote:

  Or we should compile the app first?

 I think you can run the test because dev mode uses the browser.
 Basicly you can see in the browser. But - this is my opinion - this
 way not so effective. You can check that the test are okay or not for
 example, but hard to use in a real testing environment.

 --
 - -
 --  Csanyi Andras (Sayusi Ando)  
 --http://sayusi.hu--http://facebook.com/andras.csanyi
 --  Bízzál Istenben és tartsd szárazon a puskaport!.-- Cromwell

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Can we run selenium tests in GWT dev mode?

2010-09-16 Thread Andrey
Or we should compile the app first?

Thanks in advance!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



How to emulate a class with field of type Object

2010-03-07 Thread Andrey
Hi GWT guru-s,
I've got a class (which I cannot modify) with a field of
java.lang.Object type. I want instances of this type to be avaliable
at client. For that, I wrote GWT-emulated implementation and attached
it with super-source. The problem is that GWT uses signature
checking policy to ensure that all fields are the same in original and
emulated versions of the class, so I have to define Object field in
emulated version too - and this breaks the compile. Is there a way for
me to somehow transfer this class to client?

Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Custom class emulation problem.

2010-03-05 Thread Andrey
Hello,

I'm using GWT 2.0 and now playing with custom emulation and
serializers.
I've got a complex class CDO which has many imports and cannot be
explicitly RPC-serialized in any way. So, I created its emulation with
only few methods and added super-source to my gwt.xml. Also I
created CDO_CustomFieldSerializer (which didn't help anyway). Now,
serializing the object goes just fine (and my custom serializer in
invoked) but deserializing never happens with exception:
Caused by: com.google.gwt.user.client.rpc.SerializationException:
foo.CDO/122702870
at
com.google.gwt.user.client.rpc.impl.SerializerBase.check(SerializerBase.java:
161)
at
com.google.gwt.user.client.rpc.impl.SerializerBase.instantiate(SerializerBase.java:
138)
 ...and so on

I suspect the problem's root is that my emulation class' and original
class source code are different, but the exception is too
uninformative and I've been unable to find a solution.
Why this is not working and what are the laws of creating emulation
source codes?

Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Custom class emulation problem.

2010-03-05 Thread Andrey
OK, some more tests:

I defined java class (in main classpath) as follows
public class X implements Serializable {
protected Map values = new HashMap();
}

Now, if I define its emulated version with same code, X can be
(de)serialized through RPC, but if fails e.g. if I define X in my
emulating package as
public class X implements Serializable {
}

So does it mean that emulated and original versions of classes must
have same methods and fields signature? (it can be pain for me since
original class has a lot of complex methods). If so, if class Y is
referenced from X as method parameter, should its emulated version
have same methods and fields signature too? If this is also true, does
this mean that if I want to emulate one class from a library, there
are great chances that i will have to emulate whole library?

On 5 мар, 12:10, Andrey razumovsky.and...@gmail.com wrote:
 Hello,

 I'm using GWT 2.0 and now playing with custom emulation and
 serializers.
 I've got a complex class CDO which has many imports and cannot be
 explicitly RPC-serialized in any way. So, I created its emulation with
 only few methods and added super-source to my gwt.xml. Also I
 created CDO_CustomFieldSerializer (which didn't help anyway). Now,
 serializing the object goes just fine (and my custom serializer in
 invoked) but deserializing never happens with exception:
 Caused by: com.google.gwt.user.client.rpc.SerializationException:
 foo.CDO/122702870
         at
 com.google.gwt.user.client.rpc.impl.SerializerBase.check(SerializerBase.java:
 161)
         at
 com.google.gwt.user.client.rpc.impl.SerializerBase.instantiate(SerializerBase.java:
 138)
          ...and so on

 I suspect the problem's root is that my emulation class' and original
 class source code are different, but the exception is too
 uninformative and I've been unable to find a solution.
 Why this is not working and what are the laws of creating emulation
 source codes?

 Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Validating ClientBundles ?

2010-02-18 Thread Andrey
Hi there,

Are there any news about this issue? I've got two GWT installations -
1.7.0 and 2.0.0 and NO (!) google projects in my workspace. Still,
when opening a large non-gwt project always crashes eclipse. This is
definitely a show-stopper!

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Is OOPHM single threaded?

2010-01-10 Thread Andrey
Hello!

Is OOPHM built-in server single threaded?
I wanted to test two simultaneous users log into my service and it
doesn't work in OOPHM but works on standalone server.

Is it true that I cannot test server multithreading with OOPHM?

Thanks in advance!
-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




GWTShell dev mode problem

2009-12-19 Thread Andrey
Hello!

I have war/WEB-INF/web.xml in my project but GWT-plugin still launches
GWTShell instead of DevMode.
What should I do?

Thanks!

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




Re: Chrome loading indicator

2009-12-18 Thread Andrey
I found the solutuion.
Chrome shows the loading indicator if connection was made immediately
from the body onload(), i.e. from onModuleLoad().
Do not connect to the server immediately but schedule a timer and
connect after a second or more.
This works for me:

Timer timer = new Timer() {
@Override
public void run() {
connect(sessionId, cometCallback);
}
};
timer.schedule(1000);

It seems that the pause shouldn't be too small. 1 sec seems to be
enough, but it should be checked on slow machines too.

On 11 дек, 19:44, Andrey mino...@gmail.com wrote:
 Hello!

 I am using comet (server push) in my application. When user logs in a
 secondary connection being created. It is an ordinary GWT RPC call
 with 50 sec timeout and retry.

 Everything is OK except that Chrome and the Chrome only shows loading
 indicator as if the page is loading.
 How can I get rid of it?

 Thanks in advance!

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




How to embed one gwt app in another?

2009-12-18 Thread Andrey
Hello,

i'm using GWT 1.7
I have a gwt app which is already deployed to external server. Now I
want to include that app in my new GWT application. I tried that using
iframe, but now Hosted Mode fails with
 [ERROR] Unable to find 'xxx.gwt.xml' on your classpath

where xxx is from my other application. Turns out, it tries to
resolve module from another server!
How can I properly embed one gwt app in another without direct gwt
inherits?

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




Re: Disable backspace

2009-12-17 Thread Andrey
Hello!

Yes, I just added:

Window.addWindowClosingHandler(new ClosingHandler() {
@Override
public void onWindowClosing(ClosingEvent event) {
event.setMessage(My program);
}
});

as Ian Bambury advised.
That solves the problem and it seems to be necessary for most of the
GWT applications as it is easy to:
1. press backspace when focus is lost from the input field;
2. press back button on the mouse if you have one.

On 15 дек, 08:32, Joe Cole profilercorporat...@gmail.com wrote:
 Hi Andrey,

 Did you ever resolve this? We have had reports of people losing data
 in this way but have never been able to replicate it.

 On Dec 13, 2:35 am, Andrey mino...@gmail.com wrote:

  Hello!

  My application is desktop-like, so it does not need any history
  support.
  The problem is that when I edit a form and accidentally lose focus and
  then press Backspace key to delete a character browser performs
  history.back() and the whole application is unloaded losing all the
  data.

  How can I disable this?

  Thanks!

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




Disable backspace

2009-12-12 Thread Andrey
Hello!

My application is desktop-like, so it does not need any history
support.
The problem is that when I edit a form and accidentally lose focus and
then press Backspace key to delete a character browser performs
history.back() and the whole application is unloaded losing all the
data.

How can I disable this?

Thanks!

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




Chrome loading indicator

2009-12-11 Thread Andrey
Hello!

I am using comet (server push) in my application. When user logs in a
secondary connection being created. It is an ordinary GWT RPC call
with 50 sec timeout and retry.

Everything is OK except that Chrome and the Chrome only shows loading
indicator as if the page is loading.
How can I get rid of it?

Thanks in advance!

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




Re: GWT Developer Plugin not working IE8

2009-12-09 Thread Andrey
The same problem. And it was reported a few times before.

On 9 дек, 07:50, ksachdeva ksachdev...@gmail.com wrote:
 Same issue for me also.

 Windows Vista SP2 / IE 8.

 Works fine in Firefox.

 Regards
 Kapil

 On Dec 8, 3:00 pm, Sekhar Ravinutala sek...@allurefx.com wrote:

  Thanks, see my responses below.

  On Tue, Dec 8, 2009 at 12:29 PM, Chris Ramsdale cramsd...@google.com

   wrote:
   1. Have you attempted to restart IE and test after installing theplugin?

  Yes.

   2. Can you verify that the following registry entries are available (UID
   being the unique identifier assigned to your account):

   HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\UserData\UID\Components\50E8C0062FB69AB5399BEF4DAE291BB6

  No

   HKEY_USERS\UID\Software\Classes\AppID\oophm.DLL

  Yes

   HKEY_USERS\UID\Software\Classes\CLSID\{1A2A78F4-B5A4-4208-B520-BDDA0A7EC5CB}\InprocServer32

  No

   HKEY_USERS\UID\Software\Classes\CLSID\{1D6156B6-002B-49E7-B5CA-C138FB843B4E}\InprocServer32

  No

   HKEY_USERS\UID\Software\Classes\CLSID\{1D6156B6-002B-49E7-B5CA-C138FB843B4E}\ToolboxBitmap32

  Yes

   HKEY_USERS\UID\Software\Classes\CLSID\{644FD769-8B9D-4AC4-A79E-AAAF5CD751C1}\InprocServer32

  No

   HKEY_USERS\UID\Software\Classes\TypeLib\{9259F105-BE55-4BF6-B7CE-D0AA878C1BA6}\1.0\0\win32

  Yes

   HKEY_USERS\UID_Classes\AppID\oophm.DLL

  Yes

   HKEY_USERS\UID_Classes\CLSID\{1A2A78F4-B5A4-4208-B520-BDDA0A7EC5CB}\InprocServer32

  No

   HKEY_USERS\UID_Classes\CLSID\{1D6156B6-002B-49E7-B5CA-C138FB843B4E}\InprocServer32

  No

   HKEY_USERS\UID_Classes\CLSID\{1D6156B6-002B-49E7-B5CA-C138FB843B4E}\ToolboxBitmap32

  Yes

   HKEY_USERS\UID_Classes\CLSID\{644FD769-8B9D-4AC4-A79E-AAAF5CD751C1}\InprocServer32

  No

   HKEY_USERS\UID_Classes\TypeLib\{9259F105-BE55-4BF6-B7CE-D0AA878C1BA6}\1.0\0\win32

  Yes

   On Mon, Dec 7, 2009 at 9:13 PM, Sekhar sek...@allurefx.com wrote:

   Guys, I'm not able to get the devpluginwork in IE8. I uninstalled it
   in Control Panel as suggested and re-installed it in IE8. It installs
   fine and I can see it in Control Panel, but the next time I try with
   IE8, it asks for thepluginagain. I've tried it several times now
   with no success. Could someone help?

   --

   You received this message because you are subscribed to the Google Groups
   Google Web Toolkit group.
   To post to this group, send email to google-web-tool...@googlegroups.com.
   To unsubscribe from this group, send email to
   google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
   .
   For more options, visit this group at
  http://groups.google.com/group/google-web-toolkit?hl=en.

    --
   You received this message because you are subscribed to the Google Groups
   Google Web Toolkit group.
   To post to this group, send email to google-web-tool...@googlegroups.com.
   To unsubscribe from this group, send email to
   google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2bunsubscr...@googlegroups.com
   .
   For more options, visit this group at
  http://groups.google.com/group/google-web-toolkit?hl=en.

  --
  AllureFX LLChttp://www.allurefx.com

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




Re: GWT 2.0 - startupUrl field

2009-12-02 Thread Andrey
But what if I have two .html pages:
index.html - the gwt entry page and
error.html - for servlet errors like 404.
Plugin may erroneously choose error.html as a start page.

It is not difficult to set -startupUrl of course, but it would be more
conveinent to have a field for a main page.

On 30 ноя, 21:45, Rajeev Dayal rda...@google.com wrote:
 Previously, specifying the startupURL would cause the Hosted Browser to open
 up and navigate to this address by default. With the new Development Mode,
 the Development Mode debugging session is started by having the user enter
 the URL in their (real) brower's address bar. So, the startupURL is really
 no longer as useful as a first-class launch configuration option.



 On Sat, Nov 28, 2009 at 6:39 AM, Filipe Sousa nat...@gmail.com wrote:
  On Nov 28, 11:03 am, Andrey mino...@gmail.com wrote:
   Hello!

   Why is startupUrl field removed from run configuration in RC2?
   For example, I use a servlet as a main page, GWT plugin obviously
   cannot determine the servlet's url itself and gives me incorrect url
   by default.
   Now I need to set -startupUrl in program arguments.

   It would be better if your return the field back - it was very
   convenient.

   Thanks in advance!

  +1

  --

  You received this message because you are subscribed to the Google Groups
  Google Web Toolkit group.
  To post to this group, send email to google-web-tool...@googlegroups.com.
  To unsubscribe from this group, send email to
  google-web-toolkit+unsubscr...@googlegroups.comgoogle-web-toolkit%2Bunsubs 
  cr...@googlegroups.com
  .
  For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




GWT 2.0 - startupUrl field

2009-11-28 Thread Andrey
Hello!

Why is startupUrl field removed from run configuration in RC2?
For example, I use a servlet as a main page, GWT plugin obviously
cannot determine the servlet's url itself and gives me incorrect url
by default.
Now I need to set -startupUrl in program arguments.

It would be better if your return the field back - it was very
convenient.

Thanks in advance!

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.




Ant test

2009-11-16 Thread Andrey
Hello!

Is it normal that SVN build doesn't pass tests?
Every time I build GWT from SVN I get errors while executing ant
test.

--

You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-tool...@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=.




Re: How to RPC-serialize data manually on client?

2009-11-10 Thread Andrey

Actually right now I'm doing just that. First call shares the file
(and contains in the path sessionID, so no other user can access it)
and returns URL to access it. Why I want to rewrite the function is
because file is copied two times (once from source to disk then from
disk to servlet stream).
Guess I'll rewrite it so that first call will store parameters in some
session storage and return an id. This is much easier that trying to
pass complex RPC parameters through normal POST.
Thanks!

On 9 ноя, 16:25, Paul Robinson ukcue...@gmail.com wrote:
 You can achieve the same result a different way, but with two network
 calls. The first, a regular RPC call that uploads the data and returns
 some unique ID. The second is an HTTP call that goes to your non-GWT
 servlet and passes in the ID from the first call as a parameter, and the
 file is returned for the browser to handle as normal.

 HTH
 Paul

 Andrey wrote:
  Jason,

  this is exactly what I was thinking of. My question is how to do this
  part: have a field that contained the serialized rpc style data? How
  can I rpc-serialize it?
  BTW I want to download the file not to upload it. So I will not need
  to decode on client, only encode on client and decode on server

  On 6 ноя, 20:16, Jason Essington jas...@greenrivercomputing.com
  wrote:

  Actually, the process would be to construct a form post (not a XHR)  
  since that is the only way in Javascript/html to upload a file. you  
  could have a field that contained the serialized rpc style data ...

  then on the server break out the fields ... handle the files and  
  deserialize the other bits. then serialize a response and return it.

  on the client, the target iframe would have to handle the returned  
  text as RPC data and deserialize it.

  I don't think that any of this is built into GWT at the moment, but it  
  would be possible to create it.

  I have created form posts with RPC responses in the past, so it is a  
  short hop to add the rpc style request parameters.

  -jason

  On Nov 6, 2009, at 6:48 AM, Sripathi Krishnan wrote:

  Can't do it via GWT RPC. As you said, you can bypass things on the  
  server, but GWT doesn't have any client side hooks to get raw bytes.

  In fact, I am not sure if you can do that using a XmlHttpRequest.  
  How will the user save the file, if the data is available as a  
  javascript variable?

  There is an older discussion on this group - someone wanted to  
  download an image from the servlet but pass in parameters using GWTs  
  RPC request. The conclusion was similar - it can't be done.

  --Sri

  2009/11/6 Andrey razumovsky.and...@gmail.com

  I'm using GWT 1.7

  On 6 ноя, 14:15, Andrey razumovsky.and...@gmail.com wrote:

  Hi,

  I want to create a servlet that is downloading some file to client.
  So, I cannot use RPC services for that. Servlet will take a lot of
  data from client, so request should be POST. I want to use built-in
  RPC serialization mechanizm to encode my parameters. On server, I  

  can

  use com.google.gwt.user.server.rpc.RPC class to decode the request  

  and

  get the parameters. But how can I encode them on client? I've been
  unable to fetch SerializationStreamWriter instances or something.

  In short, I want RPC-request without RPC-response (servlet will be
  writing a file in output stream instead).

  Hope, I've been clear enough..

  Thanks in advance,
  Andrey
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en
-~--~~~~--~~--~--~---



OOPHM is slow

2009-11-08 Thread Andrey

Hello!

Why OOPHM (and in before hosted mode) is so slow?
My application takes about 30-40 sec to start in OOPHM.

I am using GXT. System is: Intel Core 2 Duo 2.4 GHz, 4 Gb RAM.
I've reduced number of remote services from 20 to 3, but it didn't
help a lot.

What takes so much time?

Am I right that is verification of the code to conform GWT's Java
language subset?
So, why not make a checkbox don't verify code to give an opportunity
to run code fast and check it only periodically, say once a day.

Thanks in advance!

Andrey


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en
-~--~~~~--~~--~--~---



Unit testing problem with widgets

2009-11-01 Thread Andrey

Hello!

Widgets mocking as

Button button = createMock(Button.class);

doesn't work because of this code:

UIObject.java:140
private static DebugIdImpl debugIdImpl = GWT.create
(DebugIdImpl.class);

Why is it there? Why not make a lazy initializer?
GWT.create throws an Exception and I don't know how to workaround
this.
I don't need this debugIdImpl. I just want to create a mock.

Thanks in advance!

Andrey
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en
-~--~~~~--~~--~--~---



OOPHM - another port

2009-10-25 Thread Andrey

Hello!

I want to run two apps in OOPHM simultaneously (one is main site, and
other is admin editor)
How can I change OOPHM bind port 9997 ?

Currently I see

[ERROR] Unable to bind socket on port 9997 -- is another session
active?

when running second app.

Thanks in advance!
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en
-~--~~~~--~~--~--~---



OOPHM IE plugin doesn't work

2009-10-24 Thread Andrey

Hello!

When I open dev mode url in IE a message appears:
No GWT Browser Plugin Detected

I've downloaded and installed GWT Dev Mode Plugin for IE but the
message appears again.
Tried to repair and reinstall without success.

In FireFox everything is OK.

Does this plugin work?
I must add that I don't see this plugin in Service - Plugins menu in
IE. Should it be there?

Windows Vista
IE 8 with last updates

Andrey
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en
-~--~~~~--~~--~--~---



JSP version problem

2009-10-21 Thread Andrey

Hello!

There is a big problem with JSP in Development mode. It uses java 1.4
and I cannot change the version.

I thought this problem was eliminated, because I hadn't been facing it
for long time using builds from SVN.
Today after updating from SVN I met it again.

Could this problem be solved somehow?

Thanks in advance!
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en
-~--~~~~--~~--~--~---



Re: Caching and SSL

2009-10-20 Thread Andrey

I found the answers.
If you use Tomcat, you can speed up your GWT app as follows:

Caching:
1. Turn off pragma: no-cache by adding:
Valve
className=org.apache.catalina.authenticator.BasicAuthenticator
disableProxyCaching=false /
to your Context in server.xml

2. Add Cache-control: public and Expires: ~1 year to headers by
creating Filter as shown here:
http://www.infoq.com/articles/gwt-high-ajax

Compression:
3. Add
compression=force
to your Connector in server.xml

Check your modifications with:
http://www.whatsmyip.org/http_headers/
http://www.whatsmyip.org/http_compression/

On Oct 16, 10:36 am, Andrey mino...@gmail.com wrote:
 Hello!

 I want to cache javascript (it is in .html files, right?). As I see
 now in Forefox 3.5 application loads every time and it takes a lot, as
 scripts are rather big.

 Andrey

 On Oct 14, 3:39 pm, Austen awconsta...@gmail.com wrote:

  I believe that the no-cache issue is only a problem for IE?

  Does this help?http://www.symphonious.net/2007/06/19/caching-in-tomcat/

  Austen

  On Oct 14, 11:20 am, Andrey mino...@gmail.com wrote:

   Hello!

   I am using Tomcat with SSL and it seems that my GWT app is not cached.
   I've read some posts here but still don't have clear understanding.

   My questions are:
   1. How can I check whethercachingfor my app is enabled or not?
   2. Why GWT http headers contain cache-control: no-cache by default?
   3. How can I change cache-control with Tomcat?
   4. Why do we needcaching-filters for tomcat? Isn't it enough to set
   cache-control, max-age and something else?

   Maybe there is some kind of FAQ on SSL andcaching?

   Thanks in advance!


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en
-~--~~~~--~~--~--~---



Re: Caching and SSL

2009-10-16 Thread Andrey

Hello!

I want to cache javascript (it is in .html files, right?). As I see
now in Forefox 3.5 application loads every time and it takes a lot, as
scripts are rather big.

Andrey

On Oct 14, 3:39 pm, Austen awconsta...@gmail.com wrote:
 I believe that the no-cache issue is only a problem for IE?

 Does this help?http://www.symphonious.net/2007/06/19/caching-in-tomcat/

 Austen

 On Oct 14, 11:20 am, Andrey mino...@gmail.com wrote:

  Hello!

  I am using Tomcat with SSL and it seems that my GWT app is not cached.
  I've read some posts here but still don't have clear understanding.

  My questions are:
  1. How can I check whether caching for my app is enabled or not?
  2. Why GWT http headers contain cache-control: no-cache by default?
  3. How can I change cache-control with Tomcat?
  4. Why do we need caching-filters for tomcat? Isn't it enough to set
  cache-control, max-age and something else?

  Maybe there is some kind of FAQ on SSL and caching?

  Thanks in advance!


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en
-~--~~~~--~~--~--~---



Caching and SSL

2009-10-14 Thread Andrey

Hello!

I am using Tomcat with SSL and it seems that my GWT app is not cached.
I've read some posts here but still don't have clear understanding.

My questions are:
1. How can I check whether caching for my app is enabled or not?
2. Why GWT http headers contain cache-control: no-cache by default?
3. How can I change cache-control with Tomcat?
4. Why do we need caching-filters for tomcat? Isn't it enough to set
cache-control, max-age and something else?

Maybe there is some kind of FAQ on SSL and caching?

Thanks in advance!
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en
-~--~~~~--~~--~--~---



Hosted mode windows position

2009-09-07 Thread Andrey

Hello!

Is there any way to restore previous hosted mode windows position and
size.

Every time I start a hosted mode server I need to:
1. move hosted mode server window to the second monitor;
2. expand hosted mode browser, because it opens very small by default.

It would be much better if they restore previous position and size.

Thanks in advance!
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en
-~--~~~~--~~--~--~---



1.7 NoSuchMethodError IncompatibleRemoteServiceException

2009-08-01 Thread Andrey

Hello!

I have got a really strange issue.
When I run my application I get server-side errors like:

java.lang.NoSuchMethodError: ru.aml.client.database.Row.set(Ljava/lang/
String;Ljava/lang/String;Ljava/lang/Object;)V
...
com.google.gwt.user.client.rpc.IncompatibleRemoteServiceException:
This application is out of date, please click the ref resh button on
your browser.
...

The method set(String, String, Object) exists of cause and I have been
using it for a few months on the server-side. Eclipse shows no errors.
There is also no other Row classes.

And the really weird thing:
When I rename class Row for example to Row2 everythning is OK (!)

I also removed all older gwt-servlet.jar but it doesn't help.

I have another project which has the similar server-side code and it
works allright without renaming.

What can it be?
Thanks in advance!

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



How to include js scripts from JAR?

2009-07-28 Thread Andrey

Hi,

I'm looking for something like Spring's ResourceServlet , a way to get
static JS files from packaged jar in lib/ directory of  my Tomcat
server. I'm using GWT-Ext and currently all ext-JS files are copied to
my GWT App WAR, so it becomes heavy.

I tried to write my own servlet, but it never seems  to intercept
script requests, at least in hosted mode.

E.g.
I map my servlet in *.gwt.xml as
servlet class='ResourceServlet' path='/resource/*/

And try to mention script in HTML:
script type='...' src='resources/js/ext-all.js'/

My servlet never gains control; looking at the log, everything is
managed by some development shell servlet.
Is there a way to load JS files from a predefined JAR?

Thanks,
Andrey
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to Google-Web-Toolkit@googlegroups.com
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/Google-Web-Toolkit?hl=en
-~--~~~~--~~--~--~---



  1   2   >