[gwt-contrib] Re: Code Review: Visualization API, improved hello world example
LGTM except for resizing code below. If you don't want the resizing behavior
after all, just expunge it.
On Mon, Oct 20, 2008 at 3:11 PM, Uwe Maurer <[EMAIL PROTECTED]> wrote:
> Hi Eric,
>
> thanks for the review! The new patch is attached.
>
> On Mon, Oct 20, 2008 at 3:24 PM, Eric Ayers <[EMAIL PROTECTED]> wrote:
> > General:
> >
> > I see this coming out a lot in the hosted mode shell window - do you
> think
> > it is from our visualization wrappers?
> >
> > [WARN] Malformed JSNI reference 'length'; expect subsequent failures
> > java.lang.NoSuchFieldError: length
> > ...
> > at
> >
> com.google.gwt.visualization.client.Visualization$.draw$(Visualization.java)
>
> The problem was passing an int[] to a JSNI method.
> I changed it to use JsArrayInteger.
>
> > HelloVisualization.html
> > Regarding the margin around the label:
> > While we are at it, do we want to add margin around the entire app? We
> > can do this by putting the app inside a single div and styling that div
> in
> > the host page, or by putting the entire app inside a VerticalPanel and
> > styling it like this:
> >
> >VerticalPanel vp = new VerticalPanel
> >// I've used a 15 px margin in other gwt-google-api demos
> >vp.getElement().getStyle().setPropertyPx("margin", 15);
> >RootPanel.get().add(vp);
>
> I added this code.
>
> >
> > If you really want to get fancy, there is a hack to hook into the window
> > resize listener and set the size of the tab Panel dynamically based on
> the
> > size of the browser:
> >
> >
> >
> http://code.google.com/docreader/#p=google-web-toolkit-doc-1-5&s=google-web-toolkit-doc-1-5&t=FAQ_UIVerticalFillApp
> >
>
> I added this too :)
It isn't working the way I expected. I expected the entire table border to
resize:
Window.addWindowResizeListener(new WindowResizeListener() {
public void onWindowResized(int width, int height) {
table.setWidth((width - margin * 2) + "px");
table.setHeight((height - (margin * 2 + roomForLabel))+ "px");
}
>
>
>
> > VisualizationDemo.java:
> > 84: chart.draw(table, Table.DrawOptions.create());
> > If folks will be calling draw() regularly w/ setting any options, should
> we
> > add an overload: chart.draw(table) to AbstractVisualization?
>
> I think this is a good idea. I added it to AbstractVisualization.
>
> > I only see one table in the DataView tab (the new view). The labels seem
> to
> > imply that there should be two tables visible. The problem is that you
> are
> > overwriting flowPanel with a new instance before adding it.
> > In this case, you might want to use a Grid or FlexTable to hold your 2
> > visualizations and labels side by side.
> >
>
> The problem was the setColumn method with the int[] parameter. It
> works fine now.
>
> Thanks,
> Uwe
>
--
Eric Z. Ayers - GWT Team - Atlanta, GA USA
http://code.google.com/webtoolkit/
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: Code Review: Visualization API, improved hello world example
Hi Eric,
thanks for the review! The new patch is attached.
On Mon, Oct 20, 2008 at 3:24 PM, Eric Ayers <[EMAIL PROTECTED]> wrote:
> General:
>
> I see this coming out a lot in the hosted mode shell window - do you think
> it is from our visualization wrappers?
>
> [WARN] Malformed JSNI reference 'length'; expect subsequent failures
> java.lang.NoSuchFieldError: length
> ...
> at
> com.google.gwt.visualization.client.Visualization$.draw$(Visualization.java)
The problem was passing an int[] to a JSNI method.
I changed it to use JsArrayInteger.
> HelloVisualization.html
> Regarding the margin around the label:
> While we are at it, do we want to add margin around the entire app? We
> can do this by putting the app inside a single div and styling that div in
> the host page, or by putting the entire app inside a VerticalPanel and
> styling it like this:
>
>VerticalPanel vp = new VerticalPanel
>// I've used a 15 px margin in other gwt-google-api demos
>vp.getElement().getStyle().setPropertyPx("margin", 15);
>RootPanel.get().add(vp);
I added this code.
>
> If you really want to get fancy, there is a hack to hook into the window
> resize listener and set the size of the tab Panel dynamically based on the
> size of the browser:
>
>
> http://code.google.com/docreader/#p=google-web-toolkit-doc-1-5&s=google-web-toolkit-doc-1-5&t=FAQ_UIVerticalFillApp
>
I added this too :)
> VisualizationDemo.java:
> 84: chart.draw(table, Table.DrawOptions.create());
> If folks will be calling draw() regularly w/ setting any options, should we
> add an overload: chart.draw(table) to AbstractVisualization?
I think this is a good idea. I added it to AbstractVisualization.
> I only see one table in the DataView tab (the new view). The labels seem to
> imply that there should be two tables visible. The problem is that you are
> overwriting flowPanel with a new instance before adding it.
> In this case, you might want to use a Grid or FlexTable to hold your 2
> visualizations and labels side by side.
>
The problem was the setColumn method with the int[] parameter. It
works fine now.
Thanks,
Uwe
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Index: visualization/src/com/google/gwt/visualization/client/DataView.java
===
--- visualization/src/com/google/gwt/visualization/client/DataView.java
(revision 920)
+++ visualization/src/com/google/gwt/visualization/client/DataView.java
(working copy)
@@ -15,6 +15,9 @@
*/
package com.google.gwt.visualization.client;
+import com.google.gwt.core.client.JsArrayInteger;
+
+
/**
* This class represents the DataView.
*
@@ -39,7 +42,15 @@
return this.getViewColumnIndex(tableColumnIndex);
}-*/;
- public final native void setColumns(int[] columnIndices) /*-{
+ public final void setColumns(int[] columnIndices) {
+JsArrayInteger array = (JsArrayInteger) createArray();
+for (int i = 0; i < columnIndices.length; i++) {
+ array.set(i, columnIndices[i]);
+}
+setColumns(array);
+ };
+
+ private native void setColumns(JsArrayInteger columnIndices) /*-{
this.setColumns(columnIndices);
}-*/;
}
Index:
visualization/src/com/google/gwt/visualization/client/AbstractVisualizationContainer.java
===
---
visualization/src/com/google/gwt/visualization/client/AbstractVisualizationContainer.java
(revision 920)
+++
visualization/src/com/google/gwt/visualization/client/AbstractVisualizationContainer.java
(working copy)
@@ -68,6 +68,15 @@
}
/**
+ * Draws the visualization.
+ *
+ * @param dataTable the data table.
+ */
+ public void draw(AbstractDataTable dataTable) {
+visualization.draw(dataTable, null);
+ }
+
+ /**
* This method creates the Visualization.
* @param elem parent element of the visualization.
* @return the visualization.
Index:
samples/hellovisualization/src/com/google/gwt/visualization/sample/hellovisualization/client/VisualizationDemo.java
===
---
samples/hellovisualization/src/com/google/gwt/visualization/sample/hellovisualization/client/VisualizationDemo.java
(revision 920)
+++
samples/hellovisualization/src/com/google/gwt/visualization/sample/hellovisualization/client/VisualizationDemo.java
(working copy)
@@ -17,10 +17,18 @@
import com.google.gwt.core.client.EntryPoint;
import com.google.gwt.user.client.Window;
+import com.google.gwt.user.client.WindowResizeListener;
+import com.google.gwt.user.client.ui.FlowPanel;
+import com.google.gwt.user.client.ui.HorizontalPanel;
import com.google.gwt.user.client.ui.Label;
+import com.google.gwt.user.client.ui.Panel;
import com.google.gwt.user.client.ui.RootPanel;
+import com.google.gwt.user.client.ui.TabPa
[gwt-contrib] Re: Code Review: Visualization API, improved hello world example
On Mon, Oct 20, 2008 at 8:15 PM, Eric Ayers <[EMAIL PROTECTED]> wrote:
> One other cleanup: When running under the command line, I found an error:
>
> [gwt.javac]
> /usr/local/google/home/zundel/workspace/gwt-google-apis/visualization/samples/hellovisualization/src/com/google/gwt/visualization/sample/hellovisualization/client/VisualizationDemo.java:38:
> import requires canonical name for
> com.google.gwt.visualization.client.AbstractDataTable.ColumnType
> [gwt.javac] import com.google.gwt.visualization.client.DataTable.ColumnType;
> [gwt.javac] ^
>
>
> the import s/b:
> import com.google.gwt.visualization.client.AbstractDataTable.ColumnType;
Yes, this is fixed in the patch.
Thanks,
Uwe
> On Mon, Oct 20, 2008 at 9:24 AM, Eric Ayers <[EMAIL PROTECTED]> wrote:
>>
>> General:
>>
>> I see this coming out a lot in the hosted mode shell window - do you think
>> it is from our visualization wrappers?
>>
>> [WARN] Malformed JSNI reference 'length'; expect subsequent failures
>> java.lang.NoSuchFieldError: length
>> ...
>> at
>> com.google.gwt.visualization.client.Visualization$.draw$(Visualization.java)
>>
>>
>> HelloVisualization.html
>> Regarding the margin around the label:
>> While we are at it, do we want to add margin around the entire app? We
>> can do this by putting the app inside a single div and styling that div in
>> the host page, or by putting the entire app inside a VerticalPanel and
>> styling it like this:
>>
>>VerticalPanel vp = new VerticalPanel
>>// I've used a 15 px margin in other gwt-google-api demos
>>vp.getElement().getStyle().setPropertyPx("margin", 15);
>>RootPanel.get().add(vp);
>>
>> If you really want to get fancy, there is a hack to hook into the window
>> resize listener and set the size of the tab Panel dynamically based on the
>> size of the browser:
>>
>>
>> http://code.google.com/docreader/#p=google-web-toolkit-doc-1-5&s=google-web-toolkit-doc-1-5&t=FAQ_UIVerticalFillApp
>>
>> VisualizationDemo.java:
>> 84: chart.draw(table, Table.DrawOptions.create());
>> If folks will be calling draw() regularly w/ setting any options, should
>> we add an overload: chart.draw(table) to AbstractVisualization?
>>
>> I only see one table in the DataView tab (the new view). The labels seem
>> to imply that there should be two tables visible. The problem is that you
>> are overwriting flowPanel with a new instance before adding it.
>> In this case, you might want to use a Grid or FlexTable to hold your 2
>> visualizations and labels side by side.
>>
>>
>>
>> 2008/10/14 Uwe Maurer <[EMAIL PROTECTED]>
>> >
>> > Hi,
>> >
>> > I added a TabPanel to the hello world example, with a tab for each
>> > example. I added an example for the new DataView.
>> >
>> > Thanks,
>> > Uwe
>>
>>
>>
>> --
>> Eric Z. Ayers - GWT Team - Atlanta, GA USA
>> http://code.google.com/webtoolkit/
>
>
>
> --
> Eric Z. Ayers - GWT Team - Atlanta, GA USA
> http://code.google.com/webtoolkit/
>
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Code Review: visualization Adds launch scripts to the HelloVisualization demo
Hello Uwe, Attached is a patch that adds launch scripts to the HelloVisualization sample. You have to build the project with 'ant', then the launch scripts get bundled into the staging directory and build/dist/gwt-visualization-0.0.0.tar.gz. If you decompress the tar file, the launch scripts are all setup to run in place. You can then copy the launch file and modify it for your development environment if you so choose. (Another option for launching hosted mode in devleopment is to look at the eclipse/README.txt file in the GWT source tree which tells you how to setup a launch config using GWT) A samples/hellovisualization/launch-scripts A samples/hellovisualization/launch-scripts/linux A samples/hellovisualization/launch-scripts/linux/HelloVisualization-shell A samples/hellovisualization/launch-scripts/linux/HelloVisualization-compile A samples/hellovisualization/launch-scripts/mac A samples/hellovisualization/launch-scripts/mac/HelloVisualization-shell A samples/hellovisualization/launch-scripts/mac/HelloVisualization-compile A samples/hellovisualization/launch-scripts/windows A samples/hellovisualization/launch-scripts/windows/HelloVisualization-shell.cmd A samples/hellovisualization/launch-scripts/windows/HelloVisualization-compile.cmd M samples/build.xml -Eric. -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~--- Index: samples/hellovisualization/launch-scripts/linux/HelloVisualization-shell === --- samples/hellovisualization/launch-scripts/linux/HelloVisualization-shell (revision 0) +++ samples/hellovisualization/launch-scripts/linux/HelloVisualization-shell (revision 0) @@ -0,0 +1,8 @@ +#!/bin/sh +APPDIR=../.. +if [ "$GWT_HOME" == "" ]; then + echo "The environment variable GWT_HOME is not defined, it should point to a valid GWT installation." + exit +fi + +java -cp "$APPDIR/src:$APPDIR/bin:$GWT_HOME/gwt-user.jar:$GWT_HOME/gwt-dev-linux.jar:../../../../gwt-visualization.jar" com.google.gwt.dev.GWTShell -out "$APPDIR/www" "$@" com.google.gwt.visualization.sample.hellovisualization.HelloMaps/HelloVisualization.html; Index: samples/hellovisualization/launch-scripts/linux/HelloVisualization-compile === --- samples/hellovisualization/launch-scripts/linux/HelloVisualization-compile (revision 0) +++ samples/hellovisualization/launch-scripts/linux/HelloVisualization-compile (revision 0) @@ -0,0 +1,8 @@ +#!/bin/sh +APPDIR=../.. +if [ "$GWT_HOME" == "" ]; then + echo "The environment variable GWT_HOME is not defined, it should point to a valid GWT installation." + exit +fi + +java -Xmx128M -cp "$APPDIR/src:$APPDIR/bin:$GWT_HOME/gwt-user.jar:$GWT_HOME/gwt-dev-linux.jar:../../../../gwt-visualization.jar" com.google.gwt.dev.GWTCompiler -out "$APPDIR/www" "$@" com.google.gwt.visualization.sample.hellovisualization.HelloVisualization; Index: samples/hellovisualization/launch-scripts/mac/HelloVisualization-shell === --- samples/hellovisualization/launch-scripts/mac/HelloVisualization-shell (revision 0) +++ samples/hellovisualization/launch-scripts/mac/HelloVisualization-shell (revision 0) @@ -0,0 +1,8 @@ +#!/bin/sh +APPDIR=../.. +if [ "$GWT_HOME" == "" ]; then + echo "The environment variable GWT_HOME is not defined, it should point to a valid GWT installation." + exit +fi + +java -Xmx128m -XstartOnFirstThread -cp "$APPDIR/src:$APPDIR/bin:$GWT_HOME/gwt-user.jar:$GWT_HOME/gwt-dev-mac.jar:../../../../gwt-visualization.jar" com.google.gwt.dev.GWTShell -out "$APPDIR/www" "$@" com.google.gwt.visualization.sample.hellovisualization.HelloMaps/HelloVisualization.html; Index: samples/hellovisualization/launch-scripts/mac/HelloVisualization-compile === --- samples/hellovisualization/launch-scripts/mac/HelloVisualization-compile (revision 0) +++ samples/hellovisualization/launch-scripts/mac/HelloVisualization-compile (revision 0) @@ -0,0 +1,8 @@ +#!/bin/sh +APPDIR=../.. +if [ "$GWT_HOME" == "" ]; then + echo "The environment variable GWT_HOME is not defined, it should point to a valid GWT installation." + exit +fi + +java -Xmx128M -XstartOnFirstThread -cp "$APPDIR/src:$APPDIR/bin:$GWT_HOME/gwt-user.jar:$GWT_HOME/gwt-dev-mac.jar:../../../../gwt-visualization.jar" com.google.gwt.dev.GWTCompiler -out "$APPDIR/www" "$@" com.google.gwt.visualization.sample.hellovisualization.HelloVisualization; Index: samples/hellovisualization/launch-scripts/windows/HelloVisualization-shell.cmd === --- samples/hellovisualization/launch-scripts/windows/HelloVisualization-shell.cmd (revision 0) +++ samples
[gwt-contrib] Re: Code Review: Visualization API, improved hello world example
One other cleanup: When running under the command line, I found an error:
[gwt.javac]
/usr/local/google/home/zundel/workspace/gwt-google-apis/visualization/samples/hellovisualization/src/com/google/gwt/visualization/sample/hellovisualization/client/VisualizationDemo.java:38:
import requires canonical name for
com.google.gwt.visualization.client.AbstractDataTable.ColumnType
[gwt.javac] import com.google.gwt.visualization.client.DataTable.ColumnType;
[gwt.javac] ^
the import s/b:
import com.google.gwt.visualization.client.AbstractDataTable.ColumnType;
On Mon, Oct 20, 2008 at 9:24 AM, Eric Ayers <[EMAIL PROTECTED]> wrote:
> General:
>
> I see this coming out a lot in the hosted mode shell window - do you think
> it is from our visualization wrappers?
>
> [WARN] Malformed JSNI reference 'length'; expect subsequent failures
> java.lang.NoSuchFieldError: length
> ...
> at
> com.google.gwt.visualization.client.Visualization$.draw$(Visualization.java)
>
>
> HelloVisualization.html
> Regarding the margin around the label:
> While we are at it, do we want to add margin around the entire app? We
> can do this by putting the app inside a single div and styling that div in
> the host page, or by putting the entire app inside a VerticalPanel and
> styling it like this:
>
>VerticalPanel vp = new VerticalPanel
>// I've used a 15 px margin in other gwt-google-api demos
>vp.getElement().getStyle().setPropertyPx("margin", 15);
>RootPanel.get().add(vp);
>
> If you really want to get fancy, there is a hack to hook into the window
> resize listener and set the size of the tab Panel dynamically based on the
> size of the browser:
>
>
> http://code.google.com/docreader/#p=google-web-toolkit-doc-1-5&s=google-web-toolkit-doc-1-5&t=FAQ_UIVerticalFillApp
>
> VisualizationDemo.java:
> 84: chart.draw(table, Table.DrawOptions.create());
> If folks will be calling draw() regularly w/ setting any options, should
> we add an overload: chart.draw(table) to AbstractVisualization?
>
> I only see one table in the DataView tab (the new view). The labels seem
> to imply that there should be two tables visible. The problem is that you
> are overwriting flowPanel with a new instance before adding it.
> In this case, you might want to use a Grid or FlexTable to hold your 2
> visualizations and labels side by side.
>
>
>
> 2008/10/14 Uwe Maurer <[EMAIL PROTECTED]>
>
> >
> > Hi,
> >
> > I added a TabPanel to the hello world example, with a tab for each
> > example. I added an example for the new DataView.
> >
> > Thanks,
> > Uwe
>
>
>
> --
> Eric Z. Ayers - GWT Team - Atlanta, GA USA
> http://code.google.com/webtoolkit/
>
--
Eric Z. Ayers - GWT Team - Atlanta, GA USA
http://code.google.com/webtoolkit/
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: Code Review: Visualization API, added DataView
OK, thanks for setting me straight. LGTM. On Mon, Oct 20, 2008 at 11:44 AM, Uwe Maurer <[EMAIL PROTECTED]> wrote: > On Mon, Oct 20, 2008 at 4:15 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: > > LGTM, just address the issue in DataView: > > > > M > > visualization/src/com/google/gwt/visualization/client/Visualization.java > > LG > > > > A > visualization/src/com/google/gwt/visualization/client/DataView.java > > > > I don't see any real problem, but there is something that needs some > kind > > of documentation, I think. The DataView inherits the setXXX methods from > > DataTable, but those should not be valid with DataView. What will happen > if > > you invoke these methods? (I assume nothing or you'll get a > > JavaScriptException thrown) Unfortunately, we can't use interfaces as a > > tool to get around this because we're extending JavaScriptObject. > > There are no setters in AbstractDataTable. The setters are in DataTable. > I have only the common methods of DataTable and DataView in > AbstractDataTable. > > Maybe AbstractDataTable is not the best name for this parent class. > Unfortunately there is no corresponding class in the Visualization API, > it is just documented which methods are in common between DataTable > and DataView. > > Uwe > -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Code Review: Visualization API, added DataView
On Mon, Oct 20, 2008 at 4:15 PM, Eric Ayers <[EMAIL PROTECTED]> wrote: > LGTM, just address the issue in DataView: > > M > visualization/src/com/google/gwt/visualization/client/Visualization.java > LG > > A visualization/src/com/google/gwt/visualization/client/DataView.java > > I don't see any real problem, but there is something that needs some kind > of documentation, I think. The DataView inherits the setXXX methods from > DataTable, but those should not be valid with DataView. What will happen if > you invoke these methods? (I assume nothing or you'll get a > JavaScriptException thrown) Unfortunately, we can't use interfaces as a > tool to get around this because we're extending JavaScriptObject. There are no setters in AbstractDataTable. The setters are in DataTable. I have only the common methods of DataTable and DataView in AbstractDataTable. Maybe AbstractDataTable is not the best name for this parent class. Unfortunately there is no corresponding class in the Visualization API, it is just documented which methods are in common between DataTable and DataView. Uwe --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Code Review: Visualization API, added DataView
LGTM, just address the issue in DataView: M visualization/src/com/google/gwt/visualization/client/Visualization.java LG A visualization/src/com/google/gwt/visualization/client/DataView.java I don't see any real problem, but there is something that needs some kind of documentation, I think. The DataView inherits the setXXX methods from DataTable, but those should not be valid with DataView. What will happen if you invoke these methods? (I assume nothing or you'll get a JavaScriptException thrown) Unfortunately, we can't use interfaces as a tool to get around this because we're extending JavaScriptObject. A visualization/src/com/google/gwt/visualization/client/AbstractDataTable.java LG M visualization/src/com/google/gwt/visualization/client/DataTable.java LG M visualization/src/com/google/gwt/visualization/client/AbstractVisualizationContainer.java LG On Tue, Oct 14, 2008 at 10:50 AM, Uwe Maurer <[EMAIL PROTECTED]> wrote: > Hi, > > I added the new DataView class that allows read only access to a > DataTable for selected columns. > > Thanks, > Uwe > -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Code Review: gwt-google-apis maps Formatting and comment cleanup
LGTM On Fri, Oct 17, 2008 at 11:35 AM, Eric Ayers <[EMAIL PROTECTED]> wrote: > Hello Miguel, > > Would you mind reviewing the attached patch? It only changes comments > and formatting. > > The API suffered through a long bout of build breakage. While > debugging it, I ran across some comments that were not at all clear in > the Maps Test. > > relative to releases/maps/1.0 branch in subversion: > > maps/test/com/google/gwt/maps/client/MapWidgetEventsTest.java > > Thanks, > -Eric. > -- > Eric Z. Ayers - GWT Team - Atlanta, GA USA > http://code.google.com/webtoolkit/ > -- Miguel --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Code Review: Visualization API, improved hello world example
General:
I see this coming out a lot in the hosted mode shell window - do you think
it is from our visualization wrappers?
[WARN] Malformed JSNI reference 'length'; expect subsequent failures
java.lang.NoSuchFieldError: length
...
at
com.google.gwt.visualization.client.Visualization$.draw$(Visualization.java)
HelloVisualization.html
Regarding the margin around the label:
While we are at it, do we want to add margin around the entire app? We
can do this by putting the app inside a single div and styling that div in
the host page, or by putting the entire app inside a VerticalPanel and
styling it like this:
VerticalPanel vp = new VerticalPanel
// I've used a 15 px margin in other gwt-google-api demos
vp.getElement().getStyle().setPropertyPx("margin", 15);
RootPanel.get().add(vp);
If you really want to get fancy, there is a hack to hook into the window
resize listener and set the size of the tab Panel dynamically based on the
size of the browser:
http://code.google.com/docreader/#p=google-web-toolkit-doc-1-5&s=google-web-toolkit-doc-1-5&t=FAQ_UIVerticalFillApp
VisualizationDemo.java:
84: chart.draw(table, Table.DrawOptions.create());
If folks will be calling draw() regularly w/ setting any options, should we
add an overload: chart.draw(table) to AbstractVisualization?
I only see one table in the DataView tab (the new view). The labels seem to
imply that there should be two tables visible. The problem is that you are
overwriting flowPanel with a new instance before adding it.
In this case, you might want to use a Grid or FlexTable to hold your 2
visualizations and labels side by side.
2008/10/14 Uwe Maurer <[EMAIL PROTECTED]>
>
> Hi,
>
> I added a TabPanel to the hello world example, with a tab for each
> example. I added an example for the new DataView.
>
> Thanks,
> Uwe
--
Eric Z. Ayers - GWT Team - Atlanta, GA USA
http://code.google.com/webtoolkit/
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: Code Review: Visualization API, improved hello world example
Hi Uwe, I can't get the entire patch to apply because I'm missing a file named AbstractDataTable.java from http://gwt-google-apis.googlecode.com/svn/branches/uwe/visualization Did I miss an earlier commit? On Tue, Oct 14, 2008 at 10:51 AM, Uwe Maurer <[EMAIL PROTECTED]> wrote: > Hi, > > I added a TabPanel to the hello world example, with a tab for each > example. I added an example for the new DataView. > > Thanks, > Uwe > -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: r3781 - in releases/1.6/events: . dev eclipse/dev/windows eclipse/samples/DynaTable eclipse/sampl...
> On Sun, Oct 19, 2008 at 12:38 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote: > > I was trying to make it clear that the code was on the 1.6 release branch > > rather then being branched off trunk, however that may not have been the > > correct way to do that. Would branches/1.6/events be better? The problem was that checking-out releases/1.6 gave you releases/1.6/ events which doesn't come for free (as far as bytes count are concerned). I experienced it while switching my working-copy from trunk/ to releases/1.6, and in case I'd want to switch back to trunk and back again to releases/1.6 I would have to download the whole GWT code base once again (as part of the releases/1.6/events copy) On 19 oct, 19:38, "Emily Crutcher" <[EMAIL PROTECTED]> wrote: > Moved the events to branch\1_6_events. Thanks Emily. > Thanks Thomas! You're welcome ;-) --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
