[gwt-contrib] Re: default GWT version in Maven central repo wrong
Should probably use -Dversion=1.6-M1 for that rather than -Dversion=1.6.0 -Ray On Fri, Feb 6, 2009 at 11:03 PM, nicolas de loof wrote: > Allready there : > http://repo2.maven.org/maven2/com/google/gwt/gwt-dev/1.6.0/ > > > On Fri, Feb 6, 2009 at 10:36 PM, Arthur Kalmenson > wrote: >> >> Yep, that's what I meant, so if you don't include a version and let >> Maven pick up the latest version, it'll pick up 1.5-RC1. You can also >> see from the size graph that 1.5-RC1 is considered newer then 1.5.3. >> This might be a problem for some people. >> >> P.S. Will 1.6-M1 hit central or will it be just the final release? >> >> -- >> Arthur Kalmenson >> >> >> >> On Fri, Feb 6, 2009 at 10:57 AM, nicolas de loof >> wrote: >> > AFAIK, mvnrepository "latest" is based on textual version comparison, so >> > 1.5-RC* > 1.5.3 >> > >> > On Fri, Feb 6, 2009 at 4:54 PM, nicolas de loof >> > >> > wrote: >> >> >> >> What make you say ths is the default one ? >> >> Index of /maven2/com/google/gwt/gwt-user/ >> >> ../ >> >> 1.4.60/17-Sep-2007 17:57 >> >> - >> >> 1.4.62/23-Mar-2008 09:10 >> >> - >> >> 1.5-M1/01-Apr-2008 10:29 >> >> - >> >> 1.5-M2/13-May-2008 13:20 >> >> - >> >> 1.5-RC1/ 29-May-2008 10:40 >> >> - >> >> 1.5.1/ 11-Aug-2008 08:35 >> >> - >> >> 1.5.2/ 01-Sep-2008 11:59 >> >> - >> >> 1.5.3/ 20-Oct-2008 14:19 >> >> - >> >> >> >> As there is no metadata.xml file, there is no default ! >> >> >> >> PS : I'm the guy who uploads those artifacts >> >> On Fri, Feb 6, 2009 at 4:40 PM, Arthur Kalmenson >> >> >> >> wrote: >> >>> >> >>> Hello everyone, >> >>> >> >>> I'm not sure who rsyncs GWT releases to Maven central, but if you look >> >>> at: http://mvnrepository.com/artifact/com.google.gwt/gwt-user you can >> >>> see that the default GWT version is 1.5-RC1 and not 1.5.3. >> >>> >> >>> -- >> >>> Arthur Kalmenson >> >>> >> >>> >> >> >> > >> > >> > > >> > >> >> > > > > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: default GWT version in Maven central repo wrong
Allready there : http://repo2.maven.org/maven2/com/google/gwt/gwt-dev/1.6.0/ On Fri, Feb 6, 2009 at 10:36 PM, Arthur Kalmenson wrote: > > Yep, that's what I meant, so if you don't include a version and let > Maven pick up the latest version, it'll pick up 1.5-RC1. You can also > see from the size graph that 1.5-RC1 is considered newer then 1.5.3. > This might be a problem for some people. > > P.S. Will 1.6-M1 hit central or will it be just the final release? > > -- > Arthur Kalmenson > > > > On Fri, Feb 6, 2009 at 10:57 AM, nicolas de loof > wrote: > > AFAIK, mvnrepository "latest" is based on textual version comparison, so > > 1.5-RC* > 1.5.3 > > > > On Fri, Feb 6, 2009 at 4:54 PM, nicolas de loof < > nicolas.del...@gmail.com> > > wrote: > >> > >> What make you say ths is the default one ? > >> Index of /maven2/com/google/gwt/gwt-user/ > >> ../ > >> 1.4.60/17-Sep-2007 17:57 > >> - > >> 1.4.62/23-Mar-2008 09:10 > >> - > >> 1.5-M1/01-Apr-2008 10:29 > >> - > >> 1.5-M2/13-May-2008 13:20 > >> - > >> 1.5-RC1/ 29-May-2008 10:40 > >> - > >> 1.5.1/ 11-Aug-2008 08:35 > >> - > >> 1.5.2/ 01-Sep-2008 11:59 > >> - > >> 1.5.3/ 20-Oct-2008 14:19 > >> - > >> > >> As there is no metadata.xml file, there is no default ! > >> > >> PS : I'm the guy who uploads those artifacts > >> On Fri, Feb 6, 2009 at 4:40 PM, Arthur Kalmenson > > >> wrote: > >>> > >>> Hello everyone, > >>> > >>> I'm not sure who rsyncs GWT releases to Maven central, but if you look > >>> at: http://mvnrepository.com/artifact/com.google.gwt/gwt-user you can > >>> see that the default GWT version is 1.5-RC1 and not 1.5.3. > >>> > >>> -- > >>> Arthur Kalmenson > >>> > >>> > >> > > > > > > > > > > > > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r4667 - in trunk/dev/core/src/com/google/gwt/dev: . js resource/impl
Author: j...@google.com Date: Fri Feb 6 21:06:26 2009 New Revision: 4667 Modified: trunk/dev/core/src/com/google/gwt/dev/ArgHandlerOutDirDeprecated.java trunk/dev/core/src/com/google/gwt/dev/Link.java trunk/dev/core/src/com/google/gwt/dev/Precompile.java trunk/dev/core/src/com/google/gwt/dev/js/EvalFunctionsAtTopScope.java trunk/dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java Log: Clean up checkstyle warnings and formatting. Patch by: jat Unreviewed Modified: trunk/dev/core/src/com/google/gwt/dev/ArgHandlerOutDirDeprecated.java == --- trunk/dev/core/src/com/google/gwt/dev/ArgHandlerOutDirDeprecated.java (original) +++ trunk/dev/core/src/com/google/gwt/dev/ArgHandlerOutDirDeprecated.java Fri Feb 6 21:06:26 2009 @@ -1,5 +1,17 @@ -/** +/* + * Copyright 2008 Google Inc. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. */ package com.google.gwt.dev; @@ -14,15 +26,17 @@ public class ArgHandlerOutDirDeprecated extends ArgHandlerOutDir { OptionOutDir option; - + public ArgHandlerOutDirDeprecated(OptionOutDir option) { this.option = option; } - + + @Override public String getPurpose() { return super.getPurpose() + " (deprecated)"; } + @Override public boolean isUndocumented() { return true; } @@ -31,5 +45,5 @@ public void setDir(File dir) { option.setOutDir(dir); } - + } Modified: trunk/dev/core/src/com/google/gwt/dev/Link.java == --- trunk/dev/core/src/com/google/gwt/dev/Link.java (original) +++ trunk/dev/core/src/com/google/gwt/dev/Link.java Fri Feb 6 21:06:26 2009 @@ -99,6 +99,11 @@ return extraDir; } +@Deprecated +public File getOutDir() { + return outDir; +} + public File getWarDir() { return warDir; } @@ -107,18 +112,13 @@ this.extraDir = extraDir; } -public void setWarDir(File warDir) { - this.warDir = warDir; -} - -@Deprecated -public File getOutDir() { - return outDir; -} - @Deprecated public void setOutDir(File outDir) { this.outDir = outDir; +} + +public void setWarDir(File warDir) { + this.warDir = warDir; } } Modified: trunk/dev/core/src/com/google/gwt/dev/Precompile.java == --- trunk/dev/core/src/com/google/gwt/dev/Precompile.java (original) +++ trunk/dev/core/src/com/google/gwt/dev/Precompile.java Fri Feb 6 21:06:26 2009 @@ -159,12 +159,12 @@ jjsOptions.setAggressivelyOptimize(aggressivelyOptimize); } -public void setDraftCompile(boolean draft) { - jjsOptions.setDraftCompile(draft); -} - public void setDisableUpdateCheck(boolean disabled) { disableUpdateCheck = disabled; +} + +public void setDraftCompile(boolean draft) { + jjsOptions.setDraftCompile(draft); } public void setEnableAssertions(boolean enableAssertions) { Modified: trunk/dev/core/src/com/google/gwt/dev/js/EvalFunctionsAtTopScope.java == --- trunk/dev/core/src/com/google/gwt/dev/js/EvalFunctionsAtTopScope.java (original) +++ trunk/dev/core/src/com/google/gwt/dev/js/EvalFunctionsAtTopScope.java Fri Feb 6 21:06:26 2009 @@ -1,3 +1,18 @@ +/* + * Copyright 2009 Google Inc. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ package com.google.gwt.dev.js; import com.google.gwt.dev.js.ast.JsBlock; @@ -15,15 +30,23 @@ import java.util.Stack; /** - * Force all functions to be evaluated at the top of the lexical scope in - * which they reside. This makes {...@link StaticEvalVisitor} simpler in that we - * no l
[gwt-contrib] Re: code review requested - merge OOPHM hosted.html
Please also include my one liner patch here http://code.google.com/p/google-web-toolkit/issues/detail?id=3291&q=reporter:cbraid Cam On Sat, Feb 7, 2009 at 8:20 AM, John Tamplin wrote: > Updated patch -- I had tested only on my local machine, so I didn't notice > it wasn't picking up gwt.hosted from the URL properly. > > > -- > John A. Tamplin > Software Engineer (GWT), Google > > > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r4666 - changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac
Author: j...@google.com Date: Fri Feb 6 16:44:33 2009 New Revision: 4666 Modified: changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/BinaryCompilationUnitBuilder.java changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/BinaryCompiledClass.java changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java Log: Initial support for building TypeOracle from BinaryCompiledClass -- still need generics, local types, and the resolve step. Scott also suggested it might be better to scrap all of TypeOracle and always generate it from bytecode rather than maintaining code for using JDT type bindings in addition. Modified: changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/BinaryCompilationUnitBuilder.java == --- changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/BinaryCompilationUnitBuilder.java (original) +++ changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/BinaryCompilationUnitBuilder.java Fri Feb 6 16:44:33 2009 @@ -180,6 +180,7 @@ private byte[] bytes; private Resource classResource; private List methods = new ArrayList(); +private int access; public BinaryCompiledClassVisitor(Resource classResource, byte[] bytes) { this.classResource = classResource; @@ -189,8 +190,8 @@ public BinaryCompiledClass getBinaryCompiledClass() { CompiledClass enclosingClass = null; // TODO(jat): compute enclosingClass - return new BinaryCompiledClass(classResource, bytes, enclosingClass, name, signature, superName, - interfaces, innerClasses); + return new BinaryCompiledClass(classResource, bytes, enclosingClass, + access, name, signature, superName, interfaces, innerClasses); } /** @@ -270,6 +271,7 @@ public void visit(int version, int access, String name, String signature, String superName, String[] interfaces) { // Is there anything we should check here, such as if it implements a JSO? + this.access = access; this.name = name; this.signature = signature; this.superName = superName; Modified: changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/BinaryCompiledClass.java == --- changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/BinaryCompiledClass.java (original) +++ changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/BinaryCompiledClass.java Fri Feb 6 16:44:33 2009 @@ -28,46 +28,59 @@ public class BinaryCompiledClass extends CompiledClass { private String name; + private String signature; - private Object superName; + + private String superName; + private String[] interfaces; + private List innerClasses; + private Resource classResource; private byte[] bytes; + private int access; + public BinaryCompiledClass(Resource classResource, byte[] bytes, - CompiledClass enclosingClass, String name, String signature, + CompiledClass enclosingClass, int access, String name, String signature, String superName, String[] interfaces, List innerClasses) { super(null, enclosingClass); this.classResource = classResource; this.bytes = bytes; +this.access = access; this.name = name; this.signature = signature; this.superName = superName; this.interfaces = interfaces; this.innerClasses = innerClasses; } - + BinaryCompiledClass(CompiledClass enclosingClass) { super(null, enclosingClass); } - + public int getAccess() { +return access; + } @Override public String getBinaryName() { return name; } - /* - * (non-Javadoc) - * - * @see com.google.gwt.dev.javac.CompiledClass#getBytes() - */ @Override public byte[] getBytes() { return bytes; } + public List getInnerClasses() { +return innerClasses; + } + + public String[] getInterfaces() { +return interfaces; + } + @Override public List getJsniMethods(JsProgram program, JnsiErrorCallback callback) { @@ -75,18 +88,30 @@ return Collections.emptyList(); } + public String getName() { +return name; + } + @Override public String getPackageName() { int idx = name.lastIndexOf('/'); if (idx < 0) { return ""; } -return name.substring(0, idx - 1); +return name.substring(0, idx).replace('/', '.'); + } + + public String getSignature() { +return signature; } @Override public String getSourceName() { return name.replaceAll("[$/]", "."); + } + + public String getSuperName() { +return superName; } public void setUnit(BinaryCompilationUnit unit) { Modified: changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java == --- chan
[gwt-contrib] [google-web-toolkit commit] r4665 - in trunk/dev: core/src/com/google/gwt/core/ext/linker/impl oophm/overlay/com/google/gwt/c...
Author: j...@google.com Date: Fri Feb 6 16:43:08 2009 New Revision: 4665 Removed: trunk/dev/oophm/overlay/com/google/gwt/core/ext/linker/impl/hosted.html Modified: trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Log: Merge OOPHM hosted.html into standard one. Patch by: jat Review by: rjrjr Modified: trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html == --- trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (original) +++ trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Fri Feb 6 16:43:08 2009 @@ -4,37 +4,242 @@ var $doc = $wnd.document; var $moduleName, $moduleBase ,$stats = $wnd.__gwtStatsEvent ? function(a) {return $wnd.__gwtStatsEvent(a);} : null; +// Lightweight metrics if ($stats) { var moduleFuncName = location.search.substr(1); var moduleFunc = $wnd[moduleFuncName]; var moduleName = moduleFunc ? moduleFunc.moduleName : "unknown"; $stats({moduleName:moduleName,subSystem:'startup',evtGroup:'moduleStartup',millis:(new Date()).getTime(),type:'moduleEvalStart'}); } - - -This html file is for hosted mode support. -