[gwt-contrib] apicheck should run on Windows
Reviewers: amitmanjhi, Description: the old form got confused by a refJar "path" of 'C:\GWT\tools\api-checker\reference\gwt-dev-modified.jar:C:\GWT\tools\api-checker\reference\gwt-user-modified.jar' because splitting on colons was wrong. Worse, ant thought that it had succeeded because an arg-parsing error was caught, help printed, and ultimately 0 exited. The new form splits on the path.separator system propery instead, uses ant's to input either a : or ; separated value depending on OS, and catches arg parse failures as non-zero return. Please review this at http://gwt-code-reviews.appspot.com/51801 Affected files: build.xml tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5717 - More ant tweaks, this time to speed dev and jni tests by not attempting to test the OS'es...
Author: fabb...@google.com Date: Fri Jul 10 19:19:32 2009 New Revision: 5717 Modified: trunk/dev/build.xml trunk/jni/build.xml Log: More ant tweaks, this time to speed dev and jni tests by not attempting to test the OS'es we're not on. Review by: rjrjr Modified: trunk/dev/build.xml == --- trunk/dev/build.xml (original) +++ trunk/dev/build.xml Fri Jul 10 19:19:32 2009 @@ -3,6 +3,13 @@ + + + + + + + Modified: trunk/jni/build.xml == --- trunk/jni/build.xml (original) +++ trunk/jni/build.xml Fri Jul 10 19:19:32 2009 @@ -2,4 +2,9 @@ + + + + + --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5716 - Ant changes to make top-level "test" also exercise checkstyle and apicheck. This thus su...
Author: fabb...@google.com Date: Fri Jul 10 19:18:10 2009 New Revision: 5716 Modified: trunk/build.xml trunk/common.ant.xml Log: Ant changes to make top-level "test" also exercise checkstyle and apicheck. This thus subsumes "prebuild", which people don't know to use and is thus doomed to go away. Review by: rjrjr Modified: trunk/build.xml == --- trunk/build.xml (original) +++ trunk/build.xml Fri Jul 10 19:18:10 2009 @@ -118,7 +118,8 @@ - + @@ -130,7 +131,8 @@ - + - Modified: trunk/common.ant.xml == --- trunk/common.ant.xml(original) +++ trunk/common.ant.xmlFri Jul 10 19:18:10 2009 @@ -276,6 +276,7 @@ + --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: "test" in dev & jni are overly aggressive
LGTM http://gwt-code-reviews.appspot.com/47812 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: allow checkstyle to work in unbuilt samples
LGTM
And I'll give you a yell when it's succeeded in my client.
On Fri, Jul 10, 2009 at 4:23 PM, Freeland Abbott wrote:
> Revised for the slightly larger goal of "allow 'ant clean presubmit'" to
> work, not merely checkstyle... apicheck requires that tools be built, and
> the more minimalist targets buildonly and dist-dev do not do that.
>
>
>
> On Fri, Jul 10, 2009 at 3:25 PM, Freeland Abbott wrote:
>
>> As people use dist-dev, they're more likely to have samples unbuilt (i.e.
>> no build/out/samples/...).As checkstyle is now fatal, and becoming part
>> of top-level tests, checkstyle will tend to run in unbuilt samples.
>> Today, this is Bad. But with this fix, it may become Happy. Or it may
>> Explode.
>>
>> All eyes are on you, Ray... no pressure.
>>
>>
>>
>> Index: common.ant.xml
>> ===
>> --- common.ant.xml (revision 5714)
>> +++ common.ant.xml (working copy)
>> @@ -276,6 +276,7 @@
>>
>>
>>> classpath="${gwt.tools.antlib}/checkstyle-all-4.2.jar;${gwt.build.lib}/gwt-customchecks.jar"
>> />
>> +
>>> config="${gwt.root}/eclipse/settings/code-style/gwt-checkstyle.xml"
>> maxErrors="0" failOnViolation="false"
>> failureProperty="gwt.checkstyle.failed">
>> > toFile="@{outputdirectory}/checkstyle_log.xml"/>
>> > file="${gwt.root}/eclipse/settings/code-style/google.header" />
>>
>>
>
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: allow checkstyle to work in unbuilt samples
Revised for the slightly larger goal of "allow 'ant clean presubmit'" to
work, not merely checkstyle... apicheck requires that tools be built, and
the more minimalist targets buildonly and dist-dev do not do that.
On Fri, Jul 10, 2009 at 3:25 PM, Freeland Abbott wrote:
> As people use dist-dev, they're more likely to have samples unbuilt (i.e.
> no build/out/samples/...).As checkstyle is now fatal, and becoming part of
> top-level tests, checkstyle will tend to run in unbuilt samples.
> Today, this is Bad. But with this fix, it may become Happy. Or it may
> Explode.
>
> All eyes are on you, Ray... no pressure.
>
>
>
> Index: common.ant.xml
> ===
> --- common.ant.xml (revision 5714)
> +++ common.ant.xml (working copy)
> @@ -276,6 +276,7 @@
>
>
> classpath="${gwt.tools.antlib}/checkstyle-all-4.2.jar;${gwt.build.lib}/gwt-customchecks.jar"
> />
> +
> config="${gwt.root}/eclipse/settings/code-style/gwt-checkstyle.xml"
> maxErrors="0" failOnViolation="false"
> failureProperty="gwt.checkstyle.failed">
> toFile="@{outputdirectory}/checkstyle_log.xml"/>
> file="${gwt.root}/eclipse/settings/code-style/google.header" />
>
>
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
clean-presub.patch
Description: Binary data
[gwt-contrib] "test" in dev & jni are overly aggressive
Reviewers: Ray Ryan, Description: As long as it's ant day... this is a performance tweak. Right now, when we test in the native-code directories (dev and jni), we nominally test all three operating systems, which can result in triplicate builds of alldeps.jar. Since we, in fact, can only test for *this* OS that we're on, there's no reason to pretend we can "-do" the full fanout. Please review this at http://gwt-code-reviews.appspot.com/47812 Affected files: dev/build.xml jni/build.xml Index: dev/build.xml === --- dev/build.xml (revision 5695) +++ dev/build.xml (working copy) @@ -3,6 +3,13 @@ + + + + + + + Index: jni/build.xml === --- jni/build.xml (revision 5695) +++ jni/build.xml (working copy) @@ -2,4 +2,9 @@ + + + + + --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] allow checkstyle to work in unbuilt samples
As people use dist-dev, they're more likely to have samples unbuilt (i.e. no build/out/samples/...).As checkstyle is now fatal, and becoming part of top-level tests, checkstyle will tend to run in unbuilt samples. Today, this is Bad. But with this fix, it may become Happy. Or it may Explode. All eyes are on you, Ray... no pressure. Index: common.ant.xml === --- common.ant.xml (revision 5714) +++ common.ant.xml (working copy) @@ -276,6 +276,7 @@ + --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Incubator API - Date/Time Handling
BTW, when you start working on the TimePicker, I would be happy to lend a hand. I would start right away, but I have never sent patches to GWT. So I would prefer to pair-code with someone who has, first. On Jul 10, 3:03 pm, Carver wrote: > The TimePicker Demo in the following project has a pretty elegant two- > click solution: (it claims to be modeling jquery) > > http://code.google.com/p/gwt-incubator-lib/ > > Note that this seems unaffiliated with the "main" gwt incubator. I am > not involved with it, and the code looks dormant (no edits since > February). If nothing else, I would love to see the UI design > borrowed. I find the current incubator time picker to be fairly > frustrating because of how much "mouse -> keyboard -> mouse" is > required. > > On Jul 9, 6:18 pm, dflorey wrote: > > > > > I don't remember if I already ported the spinner widgets to the new > > handler system...but I guess so. > > The TimePicker is a very simple widget that simply combines different > > spinners to enter or display a given time. > > While it is working well I'm not quite sure if it is the best way to > > enter a time in general. > > It would be worth to have a look at different webapps to find the best > > approach how to enter dates / times and adjust the affected widgets > > (DatePicker,TimePicker,DateTimePicker). > > In Google contacts the birthday can be selected by simple dropdown > > boxes (and this is very easy compared to enter your birthday with gwt > > datepicker...). > > In a few weeks I'll have some time to take a look at these widgets if > > appreciated. > > > On Jul 9, 5:16 pm, Joel Webber wrote: > > > > Anyone know what the status of the incubator TimePicker is? I haven't > > > looked > > > in a while. > > > > On Thu, Jul 9, 2009 at 10:59 AM, Paul Siml wrote: > > > > Hi, > > > > > I am looking for some information on the TimePicker in the incubator. > > > > Reading tacking issues I found a time picker but there does not appear > > > > to be > > > > a corresponding Incubator API entry. In addition, the depreciated > > > > widgetideas DateTimePicker API links are broken in the API as well. > > > > > com.google.gwt.gen2.picker.client.TimePicker; > > > > Please let me know who I should contact. > > > > > Thanks Paul > > > > Siml Systems, LLC --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Incubator API - Date/Time Handling
The TimePicker Demo in the following project has a pretty elegant two- click solution: (it claims to be modeling jquery) http://code.google.com/p/gwt-incubator-lib/ Note that this seems unaffiliated with the "main" gwt incubator. I am not involved with it, and the code looks dormant (no edits since February). If nothing else, I would love to see the UI design borrowed. I find the current incubator time picker to be fairly frustrating because of how much "mouse -> keyboard -> mouse" is required. On Jul 9, 6:18 pm, dflorey wrote: > I don't remember if I already ported the spinner widgets to the new > handler system...but I guess so. > The TimePicker is a very simple widget that simply combines different > spinners to enter or display a given time. > While it is working well I'm not quite sure if it is the best way to > enter a time in general. > It would be worth to have a look at different webapps to find the best > approach how to enter dates / times and adjust the affected widgets > (DatePicker,TimePicker,DateTimePicker). > In Google contacts the birthday can be selected by simple dropdown > boxes (and this is very easy compared to enter your birthday with gwt > datepicker...). > In a few weeks I'll have some time to take a look at these widgets if > appreciated. > > On Jul 9, 5:16 pm, Joel Webber wrote: > > > > > Anyone know what the status of the incubator TimePicker is? I haven't looked > > in a while. > > > On Thu, Jul 9, 2009 at 10:59 AM, Paul Siml wrote: > > > Hi, > > > > I am looking for some information on the TimePicker in the incubator. > > > Reading tacking issues I found a time picker but there does not appear to > > > be > > > a corresponding Incubator API entry. In addition, the depreciated > > > widgetideas DateTimePicker API links are broken in the API as well. > > > > com.google.gwt.gen2.picker.client.TimePicker; > > > Please let me know who I should contact. > > > > Thanks Paul > > > Siml Systems, LLC --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5714 - Added warning that latest CheckStyle doesn't work
Author: rj...@google.com Date: Fri Jul 10 09:14:42 2009 New Revision: 5714 Modified: trunk/eclipse/README.txt Log: Added warning that latest CheckStyle doesn't work for us. Modified: trunk/eclipse/README.txt == --- trunk/eclipse/README.txt(original) +++ trunk/eclipse/README.txtFri Jul 10 09:14:42 2009 @@ -1,4 +1,4 @@ -Eclipse 3.3.X instructions +Eclipse 3.X instructions These instructions are intended for contributors to the GWT source code repository that want to run the Eclipse IDE. It describes how to @@ -105,7 +105,7 @@ Checkstyle is used to enforce good programming style. -1. Install Checkstyle +1. Install Checkstyle version 4.4.2 (newer versions will not work) The Eclipse Checkstyle plugin can be found at: http://eclipse-cs.sourceforge.net/ --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5713 - Revert c5711 due to check style failures.
Author: rj...@google.com
Date: Fri Jul 10 08:13:58 2009
New Revision: 5713
Removed:
trunk/user/src/com/google/gwt/junit/FakeMessagesMaker.java
trunk/user/test/com/google/gwt/junit/FakeMessagesMakerTest.java
trunk/user/test/com/google/gwt/junit/JUnitSuite.java
Modified:
trunk/user/src/com/google/gwt/user/client/ui/HTMLPanel.java
trunk/user/test/com/google/gwt/user/client/ui/HTMLPanelTest.java
Log:
Revert c5711 due to check style failures.
Modified: trunk/user/src/com/google/gwt/user/client/ui/HTMLPanel.java
==
--- trunk/user/src/com/google/gwt/user/client/ui/HTMLPanel.java (original)
+++ trunk/user/src/com/google/gwt/user/client/ui/HTMLPanel.java Fri Jul 10
08:13:58 2009
@@ -40,29 +40,16 @@
}
/**
- * Creates an HTML panel with the specified HTML contents inside a DIV
- * element. Any element within this HTML that has a specified id can
contain a
- * child widget.
+ * Creates an HTML panel with the specified HTML contents. Any element
within
+ * this HTML that has a specified id can contain a child widget.
*
* @param html the panel's HTML
*/
public HTMLPanel(String html) {
-this("div", html);
- }
-
- /**
- * Creates an HTML panel whose root element has the given tag, and with
the
- * specified HTML contents. Any element within this HTML that has a
specified
- * id can contain a child widget.
- *
- * @param tag the tag of the root element
- * @param html the panel's HTML
- */
- public HTMLPanel(String tag, String html) {
-setElement(DOM.createElement(tag));
+setElement(DOM.createDiv());
DOM.setInnerHTML(getElement(), html);
}
-
+
/**
* Adds a child widget to the panel, contained within the HTML element
* specified by a given id.
Modified: trunk/user/test/com/google/gwt/user/client/ui/HTMLPanelTest.java
==
--- trunk/user/test/com/google/gwt/user/client/ui/HTMLPanelTest.java
(original)
+++ trunk/user/test/com/google/gwt/user/client/ui/HTMLPanelTest.javaFri
Jul 10 08:13:58 2009
@@ -1,12 +1,12 @@
/*
* Copyright 2008 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the "License"); you may
not
* use this file except in compliance with the License. You may obtain a
copy of
* the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -117,28 +117,6 @@
Node next = button.getElement().getNextSibling();
assertEquals("bar", next.getNodeValue());
- }
-
- /**
- * Tests arbitrary root tag
- */
- public void testCustomRootTag() {
-HTMLPanel hp = new HTMLPanel("table", "Hello ");
-InlineLabel label = new InlineLabel("World");
-hp.addAndReplaceElement(label, "labelHere");
-
-Element parent = label.getElement().getParentElement();
-assertEquals("td", parent.getTagName().toLowerCase());
-
-parent = parent.getParentElement();
-assertEquals("tr", parent.getTagName().toLowerCase());
-
-while (parent != null && parent != hp.getElement()) {
- parent = parent.getParentElement();
-}
-
-assertNotNull(parent);
-assertEquals("table", parent.getTagName().toLowerCase());
}
/**
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Comment on OophmForMacBasedGwtContributors in google-web-toolkit
Comment by tamplinjohn: Typo -- the correct target is dist-dev, not dev-dist. See eclipse/README.txt for setting up Eclipse for working with GWT. The Google Eclipse plugin doesn't have any support for using an Eclipse project for GWT currently (you have to point it at a GWT distribution directory), so I believe you will have to actually unjar gwt-dev-mac.jar, rm -rf org/eclipse/swt, and rejar it. I don't use a Mac so I haven't tested it. For more information: http://code.google.com/p/google-web-toolkit/wiki/OophmForMacBasedGwtContributors --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5712 - Edited wiki page through web user interface.
Author: tamplinjohn Date: Fri Jul 10 07:11:25 2009 New Revision: 5712 Modified: wiki/OophmForMacBasedGwtContributors.wiki Log: Edited wiki page through web user interface. Modified: wiki/OophmForMacBasedGwtContributors.wiki == --- wiki/OophmForMacBasedGwtContributors.wiki (original) +++ wiki/OophmForMacBasedGwtContributors.wiki Fri Jul 10 07:11:25 2009 @@ -11,7 +11,7 @@ * Make sure your oophm jar is up to date * cd trunk * ant clean - * ant dev-dist + * ant dist-dev * Back in eclipse, go to the Package Explorer, right click gwt-dev-mac and choose Properties * Java Build Path / Libraries * Delete the GWT_TOOLS/lib/eclipse/org.eclipse.swt.carbon-macosx... jar --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Custom tag constructor for HTMLPanel
Committed revision 5711.
On 2009/07/09 00:02:01, Ray Ryan wrote:
> Forgot about this during my vacation. In it goes.
> Committed revision 5694.
> On 2009/06/12 21:22:50, jgw wrote:
> > On 2009/06/12 21:20:50, jgw wrote:
> > > Ray:
> > > That won't really protect anyone from anything, as they could just
call
> > > DOM.createElement("bugger") and hand that in. Also, accepting an
existing
> > > element is another way to say HTMLPanel.wrap(), which we haven't
provided
> so
> > > far--you really want to go there?
> > >
> > > Anyhow, does any browser not accept
> > >
> >
> > Well, we *do* have lots of methods to try and keep people 'on the
rails', such
> > as createDivElement(), etc. which I believe reduces the risk of
errors in
> > practice (they can always call createElement("bugger"), but usually
don't).
> But
> > I think I'm ok with it, as it at least reduces the probability that
someone
> will
> > try and use this as a back-door wrap() method, which would lead to
much
> wailing
> > and gnashing of teeth on my part.
> >
> > LGTM.
http://gwt-code-reviews.appspot.com/39802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5711 - HTMLPanel now allows an arbitrary element to be set as its root, new
Author: rj...@google.com
Date: Fri Jul 10 07:02:01 2009
New Revision: 5711
Added:
trunk/user/src/com/google/gwt/junit/FakeMessagesMaker.java
trunk/user/test/com/google/gwt/junit/FakeMessagesMakerTest.java
trunk/user/test/com/google/gwt/junit/JUnitSuite.java
Modified:
trunk/user/src/com/google/gwt/user/client/ui/HTMLPanel.java
trunk/user/test/com/google/gwt/user/client/ui/HTMLPanelTest.java
Log:
HTMLPanel now allows an arbitrary element to be set as its root, new
constructor HTMLPanel(String tag, String html)
http://gwt-code-reviews.appspot.com/39802
Introduces FakeMessagesMaker, to allow JUnit (non-GWTTestCase) testing
of objects that rely on generated Messages objects.
http://gwt-code-reviews.appspot.com/48809
Added: trunk/user/src/com/google/gwt/junit/FakeMessagesMaker.java
==
--- (empty file)
+++ trunk/user/src/com/google/gwt/junit/FakeMessagesMaker.java Fri Jul 10
07:02:01 2009
@@ -0,0 +1,48 @@
+package com.google.gwt.junit;
+
+import com.google.gwt.i18n.client.Messages;
+
+import java.lang.reflect.InvocationHandler;
+import java.lang.reflect.Method;
+import java.lang.reflect.Proxy;
+import java.util.Arrays;
+
+/**
+ * Helper to make a fake implementation of any {...@link Messages} interface
via
+ * reflection, for use in JUnit tests. (This will not work in
GWTTestCase.) All
+ * calls to the returned object return the method name followed by the
passed
+ * parameters as a list surrounded by [].
+ *
+ * Note that the default message text is very consciously not made
available
+ * through the fake, to help tests ensure that specific translations of
+ * localized text are not relied upon.
+ *
+ * Sample use:
+ *
+ * interface MyMessages extends Messages {
+ * @DefaultMessage("Isn''t this the fakiest?")
+ * @Description("A sample message to be tested.")
+ * String myMessage();
+ * }
+ *
+ * public void testSimple() {
+ * MyMessages messages = FakeMessagesMaker.create(MyMessages.class);
+ * assertEquals("myMessage", messages.myMessage());
+ * }
+ *
+ */
+public class FakeMessagesMaker implements InvocationHandler {
+ public static T create(Class messagesClass) {
+return messagesClass.cast(Proxy.newProxyInstance(
+FakeMessagesMaker.class.getClassLoader(), new Class[]
{messagesClass},
+new FakeMessagesMaker()));
+ }
+
+ public Object invoke(Object proxy, Method method, Object[] args)
+ throws Throwable {
+String name = method.getName();
+
+return (args == null || args.length == 0) ? name : name
++ Arrays.asList(args);
+ }
+}
Modified: trunk/user/src/com/google/gwt/user/client/ui/HTMLPanel.java
==
--- trunk/user/src/com/google/gwt/user/client/ui/HTMLPanel.java (original)
+++ trunk/user/src/com/google/gwt/user/client/ui/HTMLPanel.java Fri Jul 10
07:02:01 2009
@@ -40,16 +40,29 @@
}
/**
- * Creates an HTML panel with the specified HTML contents. Any element
within
- * this HTML that has a specified id can contain a child widget.
+ * Creates an HTML panel with the specified HTML contents inside a DIV
+ * element. Any element within this HTML that has a specified id can
contain a
+ * child widget.
*
* @param html the panel's HTML
*/
public HTMLPanel(String html) {
-setElement(DOM.createDiv());
-DOM.setInnerHTML(getElement(), html);
+this("div", html);
}
+ /**
+ * Creates an HTML panel whose root element has the given tag, and with
the
+ * specified HTML contents. Any element within this HTML that has a
specified
+ * id can contain a child widget.
+ *
+ * @param tag the tag of the root element
+ * @param html the panel's HTML
+ */
+ public HTMLPanel(String tag, String html) {
+setElement(DOM.createElement(tag));
+DOM.setInnerHTML(getElement(), html);
+ }
+
/**
* Adds a child widget to the panel, contained within the HTML element
* specified by a given id.
Added: trunk/user/test/com/google/gwt/junit/FakeMessagesMakerTest.java
==
--- (empty file)
+++ trunk/user/test/com/google/gwt/junit/FakeMessagesMakerTest.java Fri Jul
10 07:02:01 2009
@@ -0,0 +1,29 @@
+package com.google.gwt.junit;
+
+import com.google.gwt.i18n.client.Messages;
+
+import junit.framework.TestCase;
+
+public class FakeMessagesMakerTest extends TestCase {
+ interface MyMessages extends Messages {
+@DefaultMessage("Isn''t this the fakiest?")
+@Description("A sample message to be tested.")
+String myMessage();
+
+@DefaultMessage("Isn''t this the fakiest? Pick one: {1} or {2}?")
+@Description("A sample message with parameters.")
+String myArgumentedMessage(@Example("yes") String yes,
+@Example("no") String no);
+ }
+
+ public void testSimple() {
+MyMessages messages = FakeMessag
[gwt-contrib] Re: suboptimal obfuscation for compression?
Good find. It sounds like a pretty simple change to allocate these more
sensibly.
On Fri, Jul 10, 2009 at 4:49 AM, Ray Cromwell wrote:
>
> Looking at the output of the compiled Mail application, I noticed the
> following property of function declarations:
>
> function dM(d,b){var a,c;if(b<0){throw AZ(new
> zZ(),ij+b)}c=d.a.rows.length;for(a=c;a<=b;++a){pN(d,a)}}
> function eM(f,d,c){var e=f.rows[d];for(var b=0;b a=$doc.createElement(gi);e.appendChild(a)}}
> function pM(a){while(++a.a function qZ(){return this.$H||(this.$H=++mp)}
> function
> oU(d,a,c,b){if(!b||b==c){return}oU(d,a,c,mq((Ep(),b)));ey(a.a,a.b++,b)}
> function rU(i,a,e,h)
>
> note that the function params are assigned single character symbols, but
> they are not consistently assigned and in the same order. If instead, the
> first arguments of any function were a, b, c, ... appear in order (they
> could be any reserved sequence), then characters sequences like
>
> (a){
> (a,b){
> (a,b,c){
> (a,b,c,d){
>
> would appear frequently and yield more backreferences in the LZ77 portion
> of the DEFLATE algorithm, plus, they would occur far more frequently, giving
> a smaller bit representation in the huffman tables. This might lead to
> significant savings when gzipping.
>
> -Ray
>
>
> >
>
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Comment on OophmForMacBasedGwtContributors in google-web-toolkit
Comment by brett.wooldridge: I should note that it kind of works on my Mac. However, over the GWT Hosted Mode window is a constant pinwheel cursor. I can't click on anything. I would have thought maybe this is due to the Swing client, but there certainly is no -XstartOnFirstThread? in my arguments. Is it because of SWT (e.g. step 4 was not possible because I don't have GWT in my workspace)? Is there a guide anywhere to setting up the GWT source in Eclipse itself. There don't appear to be top-level eclipse projects. Do I need to generate projects form ant files etc? For more information: http://code.google.com/p/google-web-toolkit/wiki/OophmForMacBasedGwtContributors --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Comment on OophmForMacBasedGwtContributors in google-web-toolkit
Comment by brett.wooldridge: I should note that it kind of works on my Mac. However, over the GWT Hosted Mode window is a constant pinwheel cursor. I can't click on anything. I would have thought maybe this is due to the Swing client, but there certainly is no -XstartOnFirstThread in my arguments. Is it because of SWT (e.g. step 4 was not possible because I don't have GWT in my workspace)? Is there a guide anywhere to setting up the GWT source in Eclipse itself. There don't appear to be top-level eclipse projects. So I need to generate projects form ant files etc? For more information: http://code.google.com/p/google-web-toolkit/wiki/OophmForMacBasedGwtContributors --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Comment on OophmForMacBasedGwtContributors in google-web-toolkit
Comment by brett.wooldridge: Thanks for the write-up. Couple of things. I'm checked out from the truck, but there is no "dev-dist" target. A simple 'ant' seems to suffice for building gwt, though possibly building more than necessary. I'm using the Eclipse plugin from the main site. Should I be building this too? Missing step above? Go to Preferences->Google->Web Toolkit and add the toolkit from the trunk. GWT itself is not checked out in my Eclipse workspace. Should it be? I checked it out and built on the command line only. As a result, step 2,3,4 don't make much sense, making me think your recipe is indeed describing a workspace where GWT is checked out along-side my project. Correct? For more information: http://code.google.com/p/google-web-toolkit/wiki/OophmForMacBasedGwtContributors --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] suboptimal obfuscation for compression?
Looking at the output of the compiled Mail application, I noticed the
following property of function declarations:
function dM(d,b){var a,c;if(b<0){throw AZ(new
zZ(),ij+b)}c=d.a.rows.length;for(a=c;a<=b;++a){pN(d,a)}}
function eM(f,d,c){var e=f.rows[d];for(var b=0;bhttp://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
