[gwt-contrib] Comment on OophmForMacBasedGwtContributors in google-web-toolkit
Comment by tamplinjohn: The WebKit code is current there (and I think IE as well), but that branch does not contain the latest XPCOM code. I thought we had decided on where the plugin code should go, but recent discussions about how the 2.0 release is going to work appear to have changed that, so it hasn't been checked into trunk yet. If you do fix a problem with the WebKit plugin, post it on that issue and someone will look at it. For more information: http://code.google.com/p/google-web-toolkit/wiki/OophmForMacBasedGwtContributors --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: GWT 1.7 Now Available
Excellent, thanks for that. Cheers On Jul 15, 4:43 pm, nicolas de loof wrote: > I'm back from holliday and will publish it ASAP > cheers, > Nicolas > > 2009/7/15 Andrew Pietsch > > > > > Howdy, > > > Is there any plan to upload 1.7 to a public maven repository? > > > Cheers > > Andrew > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Comment on OophmForMacBasedGwtContributors in google-web-toolkit
Comment by colesbury: The OOPHM browser plugin code is at: http://google-web-toolkit.googlecode.com/svn/changes/jat/oophm-plugins-trunk For more information: http://code.google.com/p/google-web-toolkit/wiki/OophmForMacBasedGwtContributors --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Comment on OophmForMacBasedGwtContributors in google-web-toolkit
Comment by brett.wooldridge: I've posted an issue on this, but thought I would cite it here in case anyone wanders by. Safari 4 (and probably Safari 3, I haven't tested) crashes frequently with OOPHM. http://code.google.com/p/google-web-toolkit/issues/detail?id=3837 This appears to be a "simple" disconnection problem (the plugin disconnecting/reconnecting) to OOPHM. If one of you google guys could look at it, it would be great. Better yet, if you can check-in the browser plugin code into SVN, I'll fix it! :-) Yes, it's really annoying me. For more information: http://code.google.com/p/google-web-toolkit/wiki/OophmForMacBasedGwtContributors --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Moving PagingScrollTable & Friends to Trunk
Bump again? Any status? thanks... jay On Jul 7, 8:40 am, jay wrote: > bump. Anything? > > On Jun 24, 10:31 am, jay wrote: > > > > > Just curious if the effort has been resumed? Regardless, is there > > anyway for you to commit what you do have somewhere we could look and > > provide feedback? > > > thanks, > > > jay > > > On Jun 10, 8:28 am, John LaBanca wrote: > > > > @jay - I got side tracked with other tasks, but I'll pick up the > > > PagingScrollTable effort within a couple of weeks. The main goal when we > > > transfer the PagingScrollTable to GWT trunk is to separate the concept of > > > scrolling (with three distinct tables) from the rest of the code. That > > > way, > > > we can bulk render a single table element that includes the header,data, > > > and > > > footer and have it layout naturally. > > > > @dflorey - I definitely plan to include all three of your points into the > > > scroll table. Thanks again for all your contributions. > > > > I don't know exactly how long it will take to integrate everything into > > > the > > > GWT trunk, but its one of my highest priorities. > > > > Thanks, > > > John LaBanca > > > jlaba...@google.com > > > > On Wed, Jun 10, 2009 at 10:15 AM, dflorey wrote: > > > > > Hi, > > > > I'd like to support this effort and would be glad if some of my > > > > changes would make it into trunk: > > > > - filters > > > > - column types for most frequently used column types > > > > (numbers,dates,text) including proper filtering, editing and sorting > > > > capabilities > > > > - simplified table generation ( see > > > >http://code.google.com/p/google-web-toolkit-incubator/wiki/TreeTable > > > > ) > > > > > (TreeTable is not ready for prime time yet) > > > > > Daniel > > > > > On 10 Jun., 05:34, jay wrote: > > > > > I saw the initial commit of these classes into your branch, but I > > > > > haven't seen any additional commits. I'd love to take a look at the > > > > > current direction, and see what other input I can provide. > > > > > > jay > > > > > > On Jun 9, 7:12 am, John LaBanca wrote: > > > > > > > We'll definitely keep these things in mind when moving stuff over to > > > > GWT > > > > > > trunk. We've also found a lot of general usability problems, such > > > > > > as > > > > the > > > > > > fact the the table doesn't layout naturally, which means apps > > > > > > require > > > > active > > > > > > layout. During the transfer, we'll refactor quite a few things to > > > > > > make > > > > them > > > > > > more usable. Specifically, we'd like to provide a version that > > > > > > allows > > > > you > > > > > > to bulk renderer the header and footer into the same table element, > > > > > > eliminated the three separate tables and fixed layout. You would > > > > > > lose > > > > the > > > > > > scrolling feature, but you would not have to use active layout. > > > > > > > When we start moving stuff into trunk or while its in my branch (as > > > > > > in > > > > right > > > > > > now), thats a good time to point out specific problems or requests. > > > > Its > > > > > > much harder to change the API after we make an official release. > > > > > > > Thanks, > > > > > > John LaBanca > > > > > > jlaba...@google.com > > > > > > > On Tue, Jun 9, 2009 at 5:01 AM, David wrote: > > > > > > > > Jay, > > > > > > > > We are experiencing the same ideas here. We store column ordering > > > > > > > and > > > > > > > widths on the server but we have no way of getting events in the > > > > > > > UI > > > > to > > > > > > > know when changes have been complete. > > > > > > > > wouldn't it be nice that the dnd was included as well, I could > > > > > > > really > > > > > > > use the DND of columns! Was it hard to implement ? We did not yet > > > > > > > bother to investigate since we have to focus on getting > > > > > > > functionality > > > > > > > complete first. > > > > > > > > David > > > > > > > > On Tue, Jun 9, 2009 at 10:00 AM, jay wrote: > > > > > > > > > As I see that this has begun (yeah), I'd like to throw out a > > > > few > > > > > > > > requests: > > > > > > > > > * Please, please, please -- ensure that this is as extensible > > > > > > > > as > > > > > > > > possible. Here's just one example--I've integrated the gwt-dnd > > > > library > > > > > > > > to allow drag-n-drop re-ordering of columns. There are a couple > > > > > > > > of > > > > > > > > funny corner cases, though, because I have no way of knowing > > > > > > > > when a > > > > > > > > column resize has completed. Obviously, if you're resizing the > > > > column, > > > > > > > > you're not interested in dragging it to a new location. I > > > > > > > > strongly > > > > > > > > encourage you to think three, four, five times about making a > > > > method > > > > > > > > private or package protected. Liberal use of JavaDoc with > > > > > > > > strongly > > > > > > > > worded warnings to those of us who need to customize the > > > > > > > > widgets. I > > > > > > > > know this cut
[gwt-contrib] Re: Fix import order and param type warnings in TestSetValidator
LGTM with adding the ToDo to replace by a type variable, wherever possible. http://gwt-code-reviews.appspot.com/51803 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Fix import order and param type warnings in TestSetValidator
LGTM -- I made the same change recently in my workspace. http://gwt-code-reviews.appspot.com/51803 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Fix import order and param type warnings in TestSetValidator
Reviewers: amitmanjhi, Description: Fix bad import order in TestSetValidator.java, and update gwt.import order to ensure it stays fixed. Also fix param type warnings. Please review this at http://gwt-code-reviews.appspot.com/51803 Affected files: eclipse/settings/code-style/gwt.importorder user/test/com/google/gwt/user/client/rpc/TestSetValidator.java --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] gwt-servlet's build rules
So, today we build user, and then make gwt-servlet.jar from a fairly random subset of the compiled class files from user. I say "fairly random" because we exclude things that are required by other classes we include, e.g. resources/rg needs StringSourceWriter which is excluded by a **/rebind/** pattern. So if the resources classes were touched server-side (which seems nonsensical), they'd fall over without some additional stuff. Do we think we can make a (practical) whilelist definition of what *should*be in gwt-servlet? --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5739 - Tagging the 1.7.0 release
Author: rj...@google.com Date: Wed Jul 15 12:30:59 2009 New Revision: 5739 Added: tags/1.7.0/ - copied from r5738, /releases/1.7/ Log: Tagging the 1.7.0 release --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: test fixes for issue 47802, assertions in all (esp. web mode) tests
LGTM. I only reviewed the two requested files -- let me know if I should review anything else. http://gwt-code-reviews.appspot.com/47817/diff/1/9 File user/test/com/google/gwt/dev/jjs/test/CoverageTest.java (right): http://gwt-code-reviews.appspot.com/47817/diff/1/9#newcode199 Line 199: assertTrue(0.01 > Math.abs(1.2f - val)); I find ordering it this way to be less clear -- I would prefer Math.abs() < EPSILON (and defining EPSILON appropriately) as it seems to clearly indicate what is being done. http://gwt-code-reviews.appspot.com/47817 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] test fixes for issue 47802, assertions in all (esp. web mode) tests
Reviewers: Ray Ryan, jat, Description: CoverageTest.java and HandlerManagerTest.java need new review. The other files are welcome to be re-reviewed, but are by flin and reviewed by me already. The change in CoverageTest is to do a more correct epsilon-compare of floating point; apparently IE's JS engine is looser than Linux's for web mode tests. I have a harder time explaining how the HandlerManager one apparently passed linux web mode, while failing IE. Please review this at http://gwt-code-reviews.appspot.com/47817 Affected files: dev/core/src/com/google/gwt/dev/GWTShell.java dev/core/src/com/google/gwt/dev/HostedModeBase.java dev/core/src/com/google/gwt/dev/Precompile.java dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerDisableAssertions.java dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableAssertions.java dev/core/test/com/google/gwt/dev/GWTShellTest.java user/src/com/google/gwt/junit/JUnitShell.java user/test/com/google/gwt/dev/jjs/test/CoverageTest.java user/test/com/google/gwt/event/shared/HandlerManagerTest.java --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5738 - More cleanups.
Author: j...@google.com
Date: Wed Jul 15 08:39:35 2009
New Revision: 5738
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/BinaryCompiledClass.java
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/CompilationState.java
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/impl/SourceFileCompilationUnit.java
Log:
More cleanups.
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/BinaryCompiledClass.java
==
---
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/BinaryCompiledClass.java
(original)
+++
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/BinaryCompiledClass.java
Wed Jul 15 08:39:35 2009
@@ -43,8 +43,6 @@
private String name;
- private List innerClasses;
-
private Resource classResource;
private byte[] bytes;
@@ -52,14 +50,12 @@
private String source;
public BinaryCompiledClass(Resource classResource, byte[] bytes,
- CompiledClass enclosingClass, String name, List
innerClasses,
- String source) {
+ CompiledClass enclosingClass, String name, String source) {
super(null, enclosingClass);
this.classResource = classResource;
this.bytes = bytes;
assert Name.isInternalName(name);
this.name = name;
-this.innerClasses = innerClasses;
this.source = source;
}
@@ -72,13 +68,6 @@
return bytes;
}
- /**
- * @return the innerClasses
- */
- public List getInnerClasses() {
-return innerClasses;
- }
-
@Override
public String getInternalName() {
return name;
@@ -119,7 +108,7 @@
@Override
void checked() {
-// TODO(jat): implement
+// TODO(jat): anything we can/should free up?
}
Resource getClassResource() {
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/CompilationState.java
==
---
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/CompilationState.java
(original)
+++
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/CompilationState.java
Wed Jul 15 08:39:35 2009
@@ -91,7 +91,7 @@
/**
* Unmodifiable view of all units.
*/
- private Collection exposedUnits =
Collections.unmodifiableCollection(unitMap.values());
+ private final Collection exposedUnits =
Collections.unmodifiableCollection(unitMap.values());
private CompilationUnitInvalidator.InvalidatorState invalidatorState =
new CompilationUnitInvalidator.InvalidatorState();
@@ -434,20 +434,6 @@
private void refreshFromOracles(TreeLogger logger) {
long startTimestamp = System.currentTimeMillis();
-// See if the source oracle has changed.
-// TODO(jat): do we need to consider binaries here?
-Set newSourceFiles = sourceOracle.getResources();
-if (cachedSourceFiles == newSourceFiles) {
- return;
-}
-
-// Divide sources into changed and unchanged.
-Set unchangedSrc = new HashSet(
-cachedSourceFiles);
-unchangedSrc.retainAll(newSourceFiles);
-Set changedSrc = new HashSet(newSourceFiles);
-changedSrc.removeAll(unchangedSrc);
-
// Invalidate binaries depending on changed sources, get new binaries
Set newBinaries;
Map newBinaryMap;
@@ -460,6 +446,19 @@
newBinaries = Collections.emptySet();
newBinaryMap = Collections.emptyMap();
}
+// See if the oracles have changed.
+Set newSourceFiles = sourceOracle.getResources();
+if (cachedSourceFiles == newSourceFiles && cachedBinaries ==
newBinaries) {
+ return;
+}
+
+// Divide sources into changed and unchanged.
+Set unchangedSrc = new HashSet(
+cachedSourceFiles);
+unchangedSrc.retainAll(newSourceFiles);
+Set changedSrc = new HashSet(newSourceFiles);
+changedSrc.removeAll(unchangedSrc);
+
// Divide binaries into changed and unchanged.
Set unchangedBin = new HashSet(
@@ -540,12 +539,5 @@
it.remove();
}
}
- }
-
- private void updateExposedUnits() {
-exposedUnits = Collections.unmodifiableSet(new
HashSet(
-unitMap.values()));
-exposedClassFileMap = null;
-exposedClassFileMapBySource = null;
}
}
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/impl/SourceFileCompilationUnit.java
==
---
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/impl/SourceFileCompilationUnit.java
(original)
+++
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/impl/SourceFileCompilationUnit.java
Wed Jul 15 08:39:35 2009
@@ -77,9 +77,8 @@
}
public BinaryCompiledClass getBinaryCompiledClass() {
- // TODO(jat): !! fix null
return new BinaryCompiledClass(classResource, bytes, enclosingClass,
- name, null, source);
+ name, source);
}
[gwt-contrib] Re: GWT 1.7 Now Available
Hi, Well, I guess you tend to focus too much on the internet side of things - which I understand since I am talking to Google :-). Maybe we should all be focusing on Android and iPhone since those browsers will certainly have a huge impact on browser usage on the internet. But in enterprise environments, which is also big if you look at it on a worldwide scale, the demographics are more biased towards IE7 right now. I would have liked it differently but things move more slowely in corporates due to the cost and risks of always upgrading to the latest fab. As for providing a patch myself, well I kinda have one in my environment but it has an impact on the build time since I had to declare a new variable that detects if ie6 is actually ie7. Which basically doubles the number of permutations :-(. I decided to do it this way since I could implement this change in our own application without the need to patch GWT. Ideally I guess the IE6 impl classes should fall back to the default implementation when the browser is IE7. That should not be hard to implement... if only I had access to the svn sourcetree at work (corporate policy!). David On Wed, Jul 15, 2009 at 3:40 PM, Joel Webber wrote: > I'm sorry you're disappointed, but we had to strike a balance between adding > these optimizations, and getting support for IE8 and Safari4 out the door. > The lack of such support was becoming an extremely important blocking issue > for many users, and while I very much want to get to the issues you cite as > soon as possible, they are optimizations (albeit important ones). > As to IE7 vs. IE8, there are two important things to consider: > 1. IE7 users are upgrading to IE8 at a reasonable pace (while IE6 users are > *not*, for various reasons). > 2. IE7 isn't going to evolve anymore, whereas IE8 is. Other than some CSS > issues, and the two issues below, IE7 is practically identical to IE6. > Adding two new user agents would have had a significant impact on compile > times. So it made more sense to make the split between IE6/7 and IE8. > Either way, these issues should be addressed in trunk fairly soon. > On Wed, Jul 15, 2009 at 9:29 AM, stuckagain wrote: >> >> GWT contribs, >> >> I must say I am a bit disappointed with the support for IE7 in GWT >> 1.7.0. >> In an enterprise environment IE7 is used a lot more than IE8, but GWT >> still treats it as ie6 and ie8 gets first class support. >> >> Take a look at these 2 issues: >> http://code.google.com/p/google-web-toolkit/issues/detail?id=3589 >> http://code.google.com/p/google-web-toolkit/issues/detail?id=3588 >> >> Both were marked for Milestone 1_6_1 but do not seem to be fixed in >> this release. >> >> The IE6 workarounds really have a huge impact on IE7: big memory leaks >> when using ImageBundles or very bad performance when you use a lot of >> popup panels in an SSL environment. I hacked GWT 1.5 a bit to disable >> these 2 tricks on IE7 and it makes a huge difference. >> >> Will these bugs be fixed in GWT 2.0 or do I have to wait until IE8 or >> something else becomes mainstream in enterprise environments (in 3 >> years or so ?) >> >> David >> >> On Jul 14, 3:01 am, Bruce Johnson wrote: >> > Hi everyone, >> > >> > GWT 1.7 is a minor update that adds better support for Internet Explorer >> > 8, >> > Firefox 3.5, and Safari 4. Each of these new browser versions introduced >> > at >> > least one change that negatively impacted compiled GWT modules, so we >> > recommend that you do update to GWT 1.7 and recompile your existing >> > applications to ensure that they work with the latest versions of >> > browsers. >> > No source code changes on your part should be required. >> > >> > Normally, a minor update such as this would have been named 1.6.5 (the >> > previous latest version of GWT was 1.6.4), but we did add the value >> > "ie8" to >> > the "user.agent" deferred binding property, which could impact projects >> > using custom deferred binding rules that are sensitive to that property. >> > Thus, we went with GWT 1.7 rather than GWT 1.6.5, to indicate that you >> > may >> > need to pay attention to that change. Details are in the release notes. >> > >> > In every other respect, this is just a bugfix release, so in the vast >> > majority of cases, the update-recompile process should be nearly >> > effortless. >> > >> > Download >> > here:http://code.google.com/p/google-web-toolkit/downloads/list?can=1&q=GW... >> > >> > Cheers, >> > Bruce, on behalf of your friendly GWT Team >> > > > > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5737 - Cleanup TODOs, remove unneeded code.
Author: j...@google.com
Date: Wed Jul 15 07:37:51 2009
New Revision: 5737
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JSORestrictionsChecker.java
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JavaBinary.java
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JavaBinaryOracleImpl.java
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/asm/CollectClassData.java
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/asm/ResolveMethodSignature.java
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/asm/ResolveTypeSignature.java
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/impl/SourceFileCompilationUnit.java
changes/jat/ihm/dev/core/test/com/google/gwt/dev/javac/asm/ResolveGenericsTest.java
Log:
Cleanup TODOs, remove unneeded code.
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java
==
---
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java
(original)
+++
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java
Wed Jul 15 07:37:51 2009
@@ -268,34 +268,6 @@
protected static final DiskCache diskCache = new DiskCache();
-// private static Set computeFileNameRefs(
-// CompilationUnitDeclaration cud,
-// final Map binaryTypeToSourceFileMap) {
-//final Set result = new HashSet();
-//cud.traverse(new TypeRefVisitor() {
-// @Override
-// protected void onBinaryTypeRef(BinaryTypeBinding referencedType,
-// CompilationUnitDeclaration unitOfReferrer, Expression
expression) {
-//// TODO(jat): clean up
-//char[] fname = referencedType.getFileName();
-//if (fname != null) {
-// String fileName =
binaryTypeToSourceFileMap.get(String.valueOf(fname));
-// if (fileName != null) {
-//result.add(fileName);
-// }
-//}
-// }
-//
-// @Override
-// protected void onTypeRef(SourceTypeBinding referencedType,
-// CompilationUnitDeclaration unitOfReferrer) {
-//// Map the referenced type to the target compilation unit file.
-//result.add(String.valueOf(referencedType.getFileName()));
-// }
-//}, cud.scope);
-//return Sets.normalize(result);
-// }
-
protected Set exposedCompiledClasses;
/**
@@ -496,7 +468,7 @@
}
}
} else {
- // TODO(jat): error here?
+ // TODO(jat): how to report error here?
}
return referencedTypes;
}
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JSORestrictionsChecker.java
==
---
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JSORestrictionsChecker.java
(original)
+++
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JSORestrictionsChecker.java
Wed Jul 15 07:37:51 2009
@@ -158,7 +158,7 @@
Type[] argTypes = Type.getArgumentTypes(desc);
boolean isCtor = false;
if ("".equals(name)) {
- // TODO(jat): ?
+ // TODO(jat): is there anything to do for clinits?
} else if ("".equals(name)) {
isCtor = true;
if (argTypes.length > 0) {
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JavaBinary.java
==
--- changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JavaBinary.java
(original)
+++ changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JavaBinary.java
Wed Jul 15 07:37:51 2009
@@ -61,11 +61,6 @@
public abstract Resource getSourceFile();
/**
- * @return class files for types not contained in another type
- */
- public abstract Set getTopClassFiles();
-
- /**
* Returns the fully-qualified binary name of the top level public type.
*/
public abstract String getTypeName();
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JavaBinaryOracleImpl.java
==
---
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JavaBinaryOracleImpl.java
(original)
+++
changes/jat/ihm/dev/core/src/com/google/gwt/dev/javac/JavaBinaryOracleImpl.java
Wed Jul 15 07:37:51 2009
@@ -102,12 +102,6 @@
}
@Override
-public Set getTopClassFiles() {
- // TODO(jat): !! implement getTopClassFiles
- return null;
-}
-
-@Override
public String getTypeName() {
return typeName;
}
@@ -274,7 +268,8 @@
}
/**
- * TODO(jat): is this actually needed?
+ * TODO(jat): is this actually needed, or will they get invalidated
+ * automatically by the source dependency check?
*/
public void invalidate(Se
[gwt-contrib] Re: GWT 1.7 Now Available
> In an enterprise environment > Will these bugs be fixed in GWT 2.0 or do I have to wait until IE8 or > something else becomes mainstream in enterprise environments (in 3 > years or so ?) Notting stopping you from fixing them yourself and submitting patches --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: GWT 1.7 Now Available
I'm sorry you're disappointed, but we had to strike a balance between adding these optimizations, and getting support for IE8 and Safari4 out the door. The lack of such support was becoming an extremely important blocking issue for many users, and while I very much want to get to the issues you cite as soon as possible, they are optimizations (albeit important ones). As to IE7 vs. IE8, there are two important things to consider: 1. IE7 users are upgrading to IE8 at a reasonable pace (while IE6 users are *not*, for various reasons). 2. IE7 isn't going to evolve anymore, whereas IE8 is. Other than some CSS issues, and the two issues below, IE7 is practically identical to IE6. Adding two new user agents would have had a significant impact on compile times. So it made more sense to make the split between IE6/7 and IE8. Either way, these issues should be addressed in trunk fairly soon. On Wed, Jul 15, 2009 at 9:29 AM, stuckagain wrote: > > GWT contribs, > > I must say I am a bit disappointed with the support for IE7 in GWT > 1.7.0. > In an enterprise environment IE7 is used a lot more than IE8, but GWT > still treats it as ie6 and ie8 gets first class support. > > Take a look at these 2 issues: > http://code.google.com/p/google-web-toolkit/issues/detail?id=3589 > http://code.google.com/p/google-web-toolkit/issues/detail?id=3588 > > Both were marked for Milestone 1_6_1 but do not seem to be fixed in > this release. > > The IE6 workarounds really have a huge impact on IE7: big memory leaks > when using ImageBundles or very bad performance when you use a lot of > popup panels in an SSL environment. I hacked GWT 1.5 a bit to disable > these 2 tricks on IE7 and it makes a huge difference. > > Will these bugs be fixed in GWT 2.0 or do I have to wait until IE8 or > something else becomes mainstream in enterprise environments (in 3 > years or so ?) > > David > > On Jul 14, 3:01 am, Bruce Johnson wrote: > > Hi everyone, > > > > GWT 1.7 is a minor update that adds better support for Internet Explorer > 8, > > Firefox 3.5, and Safari 4. Each of these new browser versions introduced > at > > least one change that negatively impacted compiled GWT modules, so we > > recommend that you do update to GWT 1.7 and recompile your existing > > applications to ensure that they work with the latest versions of > browsers. > > No source code changes on your part should be required. > > > > Normally, a minor update such as this would have been named 1.6.5 (the > > previous latest version of GWT was 1.6.4), but we did add the value "ie8" > to > > the "user.agent" deferred binding property, which could impact projects > > using custom deferred binding rules that are sensitive to that property. > > Thus, we went with GWT 1.7 rather than GWT 1.6.5, to indicate that you > may > > need to pay attention to that change. Details are in the release notes. > > > > In every other respect, this is just a bugfix release, so in the vast > > majority of cases, the update-recompile process should be nearly > effortless. > > > > Download here: > http://code.google.com/p/google-web-toolkit/downloads/list?can=1&q=GW... > > > > Cheers, > > Bruce, on behalf of your friendly GWT Team > > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: GWT 1.7 Now Available
GWT contribs, I must say I am a bit disappointed with the support for IE7 in GWT 1.7.0. In an enterprise environment IE7 is used a lot more than IE8, but GWT still treats it as ie6 and ie8 gets first class support. Take a look at these 2 issues: http://code.google.com/p/google-web-toolkit/issues/detail?id=3589 http://code.google.com/p/google-web-toolkit/issues/detail?id=3588 Both were marked for Milestone 1_6_1 but do not seem to be fixed in this release. The IE6 workarounds really have a huge impact on IE7: big memory leaks when using ImageBundles or very bad performance when you use a lot of popup panels in an SSL environment. I hacked GWT 1.5 a bit to disable these 2 tricks on IE7 and it makes a huge difference. Will these bugs be fixed in GWT 2.0 or do I have to wait until IE8 or something else becomes mainstream in enterprise environments (in 3 years or so ?) David On Jul 14, 3:01 am, Bruce Johnson wrote: > Hi everyone, > > GWT 1.7 is a minor update that adds better support for Internet Explorer 8, > Firefox 3.5, and Safari 4. Each of these new browser versions introduced at > least one change that negatively impacted compiled GWT modules, so we > recommend that you do update to GWT 1.7 and recompile your existing > applications to ensure that they work with the latest versions of browsers. > No source code changes on your part should be required. > > Normally, a minor update such as this would have been named 1.6.5 (the > previous latest version of GWT was 1.6.4), but we did add the value "ie8" to > the "user.agent" deferred binding property, which could impact projects > using custom deferred binding rules that are sensitive to that property. > Thus, we went with GWT 1.7 rather than GWT 1.6.5, to indicate that you may > need to pay attention to that change. Details are in the release notes. > > In every other respect, this is just a bugfix release, so in the vast > majority of cases, the update-recompile process should be nearly effortless. > > Download > here:http://code.google.com/p/google-web-toolkit/downloads/list?can=1&q=GW... > > Cheers, > Bruce, on behalf of your friendly GWT Team --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: GWT 1.7 Now Available
I notice there is not tag in SVN for this release : http://google-web-toolkit.googlecode.com/svn/tags/ 2009/7/15 nicolas de loof > I'm back from holliday and will publish it ASAP > cheers, > Nicolas > > 2009/7/15 Andrew Pietsch > > >> Howdy, >> >> Is there any plan to upload 1.7 to a public maven repository? >> >> Cheers >> Andrew >> >> >> > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: GWT 1.7 Now Available
Thanks for the fast reaction! Now it works perfectly! Markus On Jul 15, 1:07 am, Ray Ryan wrote: > Okay, it's > up:http://code.google.com/p/google-web-toolkit-incubator/wiki/Downloads?... > > All better? > > rjrjr > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
