[gwt-contrib] Re: Code Review Request: Add better handling of failure to connect to remote UI
LGTM http://gwt-code-reviews.appspot.com/111802 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Code Review Request: Add Info Message To Indicate When a Module Load is Complete
LGTM http://gwt-code-reviews.appspot.com/112802/diff/1/2 File dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java (right): http://gwt-code-reviews.appspot.com/112802/diff/1/2#newcode185 Line 185: moduleHandle.getLogger().log(TreeLogger.INFO, Nit: Should this be Module XXX was loaded? http://gwt-code-reviews.appspot.com/112802 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7104 committed - Makes compile report handle collapsed permutations (rather than swallo...
Revision: 7104
Author: kpro...@google.com
Date: Mon Nov 23 06:46:03 2009
Log: Makes compile report handle collapsed permutations (rather than
swallowing them)
Review by: spoon
http://code.google.com/p/google-web-toolkit/source/detail?r=7104
Modified:
/trunk/dev/core/src/com/google/gwt/core/linker/SoycReportLinker.java
/trunk/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
/trunk/dev/core/src/com/google/gwt/soyc/SoycDashboard.java
===
--- /trunk/dev/core/src/com/google/gwt/core/linker/SoycReportLinker.java
Wed Oct 28 09:10:53 2009
+++ /trunk/dev/core/src/com/google/gwt/core/linker/SoycReportLinker.java
Mon Nov 23 06:46:03 2009
@@ -29,7 +29,11 @@
import com.google.gwt.soyc.io.ArtifactsOutputDirectory;
import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
import java.util.Map;
+import java.util.SortedMap;
+import java.util.SortedSet;
import java.util.TreeMap;
/**
@@ -65,22 +69,22 @@
return results;
}
- private MapString, String extractPermutationDescriptions(
+ private MapString, ListString extractPermutationDescriptions(
ArtifactSet artifacts) {
-MapString, String permDescriptions = new TreeMapString, String();
+MapString, ListString permutationDescriptions = new
TreeMapString, ListString();
for (CompilationResult res : artifacts.find(CompilationResult.class)) {
String permId = Integer.toString(res.getPermutationId());
- /*
- * TODO(kprobst,spoon) support permutations that collapsed to the
same
- * compilation result
- */
- MapSelectionProperty, String propertyMap =
res.getPropertyMap().iterator().next();
- String permDesc = SymbolMapsLinker.propertyMapToString(propertyMap);
- permDescriptions.put(permId, permDesc);
+ ListString permDescList = new ArrayListString();
+ SortedSetSortedMapSelectionProperty, String allPropertiesMap =
res.getPropertyMap();
+ for (SortedMapSelectionProperty, String propertyMap :
allPropertiesMap) {
+ String permDesc =
SymbolMapsLinker.propertyMapToString(propertyMap);
+ permDescList.add(permDesc);
+ }
+ permutationDescriptions.put(permId, permDescList);
}
-return permDescriptions;
+return permutationDescriptions;
}
private boolean includesReports(ArtifactSet artifacts) {
===
--- /trunk/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
Mon Nov 9 06:20:12 2009
+++ /trunk/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
Mon Nov 23 06:46:03 2009
@@ -113,18 +113,21 @@
}
public static void makeTopLevelHtmlForAllPerms(
- MapString, String allPermsInfo, OutputDirectory outDir)
+ MapString, ListString allPermsInfo, OutputDirectory outDir)
throws IOException {
PrintWriter outFile = new
PrintWriter(outDir.getOutputStream(index.html));
addStandardHtmlProlog(outFile, Compile report, Compile report,
Overview of permutations);
outFile.println(ul);
for (String permutationId : allPermsInfo.keySet()) {
- String permutationInfo = allPermsInfo.get(permutationId);
+ ListString permutationInfoList = allPermsInfo.get(permutationId);
outFile.print(lia href=\SoycDashboard + - + permutationId
- + -index.html\Permutation + permutationId);
- if (permutationInfo.length() 0) {
-outFile.println( ( + permutationInfo + ) + /a/li);
++ -index.html\Permutation + permutationId);
+ if (permutationInfoList.size() 0) {
+for (String desc : permutationInfoList) {
+ outFile.println( ( + desc + ) );
+}
+outFile.println(/a/li);
} else {
outFile.println(/a);
}
===
--- /trunk/dev/core/src/com/google/gwt/soyc/SoycDashboard.java Wed Oct 28
09:10:53 2009
+++ /trunk/dev/core/src/com/google/gwt/soyc/SoycDashboard.java Mon Nov 23
06:46:03 2009
@@ -87,7 +87,7 @@
settings.out.get()));
try {
- MapString, String permInfo = readPermutationInfo(settings);
+ MapString, ListString permInfo = readPermutationInfo(settings);
SoycDashboard dashboard = new SoycDashboard(outDir);
for (String permutationId : permInfo.keySet()) {
dashboard.startNewPermutation(permutationId);
@@ -227,14 +227,13 @@
return handler;
}
- private static MapString, String readPermutationInfo(Settings settings)
+ private static MapString, ListString readPermutationInfo(Settings
settings)
throws FileNotFoundException {
-MapString, String allPermsInfo = new TreeMapString, String();
+MapString, ListString allPermsInfo = new TreeMapString,
ListString();
if (settings.symbolMapsDir.get() == null) {
String permutationId = settings.storiesFileName;
permutationId = permutationId.replaceAll(.*/stories,
[gwt-contrib] Re: Move setStartupURLs earlier, add launch support in Swing UI
http://gwt-code-reviews.appspot.com/111801/diff/1/3
File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):
http://gwt-code-reviews.appspot.com/111801/diff/1/3#newcode1053
Line 1053: for (String prenormalized : options.getStartupURLs()) {
If no startupURLs are specified on the command line, would it be
possible to compute them here? That way GPE won't need to and all UIs
would benefit.
http://gwt-code-reviews.appspot.com/111801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Move setStartupURLs earlier, add launch support in Swing UI
http://gwt-code-reviews.appspot.com/111801/diff/1/3
File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):
http://gwt-code-reviews.appspot.com/111801/diff/1/3#newcode1053
Line 1053: for (String prenormalized : options.getStartupURLs()) {
On 2009/11/23 14:57:09, mmendez wrote:
If no startupURLs are specified on the command line, would it be
possible to
compute them here? That way GPE won't need to and all UIs would
benefit.
Where would it get them from?
For GPE, Rajeev (in a separate thread) said that it would now synthesize
-startupUrl args if none were supplied by the user rather than trying to
merge them in later. That seems a better solution to me.
Also, consider the -noserver case where it has no idea where your server
is or what web pages it has access to.
http://gwt-code-reviews.appspot.com/111801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7105 committed - Update the gwt-user widgets XSD to support LayoutPanel...
Revision: 7105 Author: jasonpar...@google.com Date: Mon Nov 23 07:12:55 2009 Log: Update the gwt-user widgets XSD to support LayoutPanel Review by: rjrjr http://code.google.com/p/google-web-toolkit/source/detail?r=7105 Modified: /trunk/user/src/com/google/gwt/uibinder/resources/com.google.gwt.user.client.ui.xsd === --- /trunk/user/src/com/google/gwt/uibinder/resources/com.google.gwt.user.client.ui.xsd Wed Nov 11 08:10:49 2009 +++ /trunk/user/src/com/google/gwt/uibinder/resources/com.google.gwt.user.client.ui.xsd Mon Nov 23 07:12:55 2009 @@ -249,12 +249,17 @@ /xs:complexType !-- Used for north, south, west, and east in the DockLayoutPanel. -- -xs:complexType name=DockDirectionType - xs:complexContent - xs:extension base=SingleChildWidgetType - xs:attribute name=size type=xs:string use=required / - /xs:extension - /xs:complexContent +xs:complexType +name=DockDirectionType +xs:complexContent +xs:extension +base=SingleChildWidgetType +xs:attribute +name=size +type=xs:string +use=required / +/xs:extension +/xs:complexContent /xs:complexType xs:complexType @@ -302,6 +307,65 @@ /xs:complexType /xs:element +xs:element +name=LayoutPanel +xs:complexType + +!-- Allow any number of layer children -- +xs:choice +minOccurs=0 +maxOccurs=unbounded +xs:element +name=layer +type=LayoutPanelLayer +/xs:element +/xs:choice + +xs:anyAttribute +processContents=lax / + +/xs:complexType +/xs:element + +xs:complexType +name=LayoutPanelLayer +xs:complexContent +!-- Each layer element contains one child widget -- +xs:extension +base=SingleChildWidgetType + +!-- +...and can contain any of these attributes. We do not +express the pair constraints here. +-- +xs:attribute +name=left +type=xs:string / + +xs:attribute +name=right +type=xs:string / + +xs:attribute +name=width +type=xs:string / + +xs:attribute +name=top +type=xs:string / + +xs:attribute +name=bottom +type=xs:string / + +xs:attribute +name=height +type=xs:string / + +/xs:extension +/xs:complexContent +/xs:complexType + xs:complexType name=MenuBarType -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7106 committed - Merge from tr...@r7105 to release/gwt-2.0:...
Revision: 7106 Author: jasonpar...@google.com Date: Mon Nov 23 07:17:28 2009 Log: Merge from tr...@r7105 to release/gwt-2.0: svn merge --ignore-ancestry -c 7105 https://google-web-toolkit.googlecode.com/svn/trunk . http://code.google.com/p/google-web-toolkit/source/detail?r=7106 Modified: /releases/2.0/user/src/com/google/gwt/uibinder/resources/com.google.gwt.user.client.ui.xsd === --- /releases/2.0/user/src/com/google/gwt/uibinder/resources/com.google.gwt.user.client.ui.xsd Wed Nov 11 08:22:19 2009 +++ /releases/2.0/user/src/com/google/gwt/uibinder/resources/com.google.gwt.user.client.ui.xsd Mon Nov 23 07:17:28 2009 @@ -249,12 +249,17 @@ /xs:complexType !-- Used for north, south, west, and east in the DockLayoutPanel. -- -xs:complexType name=DockDirectionType - xs:complexContent - xs:extension base=SingleChildWidgetType - xs:attribute name=size type=xs:string use=required / - /xs:extension - /xs:complexContent +xs:complexType +name=DockDirectionType +xs:complexContent +xs:extension +base=SingleChildWidgetType +xs:attribute +name=size +type=xs:string +use=required / +/xs:extension +/xs:complexContent /xs:complexType xs:complexType @@ -302,6 +307,65 @@ /xs:complexType /xs:element +xs:element +name=LayoutPanel +xs:complexType + +!-- Allow any number of layer children -- +xs:choice +minOccurs=0 +maxOccurs=unbounded +xs:element +name=layer +type=LayoutPanelLayer +/xs:element +/xs:choice + +xs:anyAttribute +processContents=lax / + +/xs:complexType +/xs:element + +xs:complexType +name=LayoutPanelLayer +xs:complexContent +!-- Each layer element contains one child widget -- +xs:extension +base=SingleChildWidgetType + +!-- +...and can contain any of these attributes. We do not +express the pair constraints here. +-- +xs:attribute +name=left +type=xs:string / + +xs:attribute +name=right +type=xs:string / + +xs:attribute +name=width +type=xs:string / + +xs:attribute +name=top +type=xs:string / + +xs:attribute +name=bottom +type=xs:string / + +xs:attribute +name=height +type=xs:string / + +/xs:extension +/xs:complexContent +/xs:complexType + xs:complexType name=MenuBarType -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7108 committed - Merges trunk revision 7104 into this branch: Makes compile report hand...
Revision: 7108
Author: kpro...@google.com
Date: Mon Nov 23 07:38:58 2009
Log: Merges trunk revision 7104 into this branch: Makes compile report
handle collapsed permutations (rather than swallowing them).
svn merge --ignore-ancestry -c 7104
https://google-web-toolkit.googlecode.com/svn/trunk .
Review by: spoon
http://code.google.com/p/google-web-toolkit/source/detail?r=7108
Modified:
/releases/2.0/dev/core/src/com/google/gwt/core/linker/SoycReportLinker.java
/releases/2.0/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
/releases/2.0/dev/core/src/com/google/gwt/soyc/SoycDashboard.java
===
---
/releases/2.0/dev/core/src/com/google/gwt/core/linker/SoycReportLinker.java
Mon Nov 2 12:44:54 2009
+++
/releases/2.0/dev/core/src/com/google/gwt/core/linker/SoycReportLinker.java
Mon Nov 23 07:38:58 2009
@@ -29,7 +29,11 @@
import com.google.gwt.soyc.io.ArtifactsOutputDirectory;
import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
import java.util.Map;
+import java.util.SortedMap;
+import java.util.SortedSet;
import java.util.TreeMap;
/**
@@ -81,21 +85,21 @@
return results;
}
- private MapString, String extractPermutationDescriptions(
+ private MapString, ListString extractPermutationDescriptions(
ArtifactSet artifacts) {
-MapString, String permDescriptions = new TreeMapString, String();
+MapString, ListString permutationDescriptions = new
TreeMapString, ListString();
for (CompilationResult res : artifacts.find(CompilationResult.class)) {
String permId = Integer.toString(res.getPermutationId());
- /*
- * TODO(kprobst,spoon) support permutations that collapsed to the
same
- * compilation result
- */
- MapSelectionProperty, String propertyMap =
res.getPropertyMap().iterator().next();
- String permDesc = SymbolMapsLinker.propertyMapToString(propertyMap);
- permDescriptions.put(permId, permDesc);
+ ListString permDescList = new ArrayListString();
+ SortedSetSortedMapSelectionProperty, String allPropertiesMap =
res.getPropertyMap();
+ for (SortedMapSelectionProperty, String propertyMap :
allPropertiesMap) {
+ String permDesc =
SymbolMapsLinker.propertyMapToString(propertyMap);
+ permDescList.add(permDesc);
+ }
+ permutationDescriptions.put(permId, permDescList);
}
-return permDescriptions;
+return permutationDescriptions;
}
}
===
---
/releases/2.0/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
Mon Nov 9 06:28:57 2009
+++
/releases/2.0/dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
Mon Nov 23 07:38:58 2009
@@ -113,18 +113,21 @@
}
public static void makeTopLevelHtmlForAllPerms(
- MapString, String allPermsInfo, OutputDirectory outDir)
+ MapString, ListString allPermsInfo, OutputDirectory outDir)
throws IOException {
PrintWriter outFile = new
PrintWriter(outDir.getOutputStream(index.html));
addStandardHtmlProlog(outFile, Compile report, Compile report,
Overview of permutations);
outFile.println(ul);
for (String permutationId : allPermsInfo.keySet()) {
- String permutationInfo = allPermsInfo.get(permutationId);
+ ListString permutationInfoList = allPermsInfo.get(permutationId);
outFile.print(lia href=\SoycDashboard + - + permutationId
- + -index.html\Permutation + permutationId);
- if (permutationInfo.length() 0) {
-outFile.println( ( + permutationInfo + ) + /a/li);
++ -index.html\Permutation + permutationId);
+ if (permutationInfoList.size() 0) {
+for (String desc : permutationInfoList) {
+ outFile.println( ( + desc + ) );
+}
+outFile.println(/a/li);
} else {
outFile.println(/a);
}
===
--- /releases/2.0/dev/core/src/com/google/gwt/soyc/SoycDashboard.java Mon
Nov 2 12:44:54 2009
+++ /releases/2.0/dev/core/src/com/google/gwt/soyc/SoycDashboard.java Mon
Nov 23 07:38:58 2009
@@ -87,7 +87,7 @@
settings.out.get()));
try {
- MapString, String permInfo = readPermutationInfo(settings);
+ MapString, ListString permInfo = readPermutationInfo(settings);
SoycDashboard dashboard = new SoycDashboard(outDir);
for (String permutationId : permInfo.keySet()) {
dashboard.startNewPermutation(permutationId);
@@ -227,14 +227,13 @@
return handler;
}
- private static MapString, String readPermutationInfo(Settings settings)
+ private static MapString, ListString readPermutationInfo(Settings
settings)
throws FileNotFoundException {
-MapString, String allPermsInfo = new TreeMapString, String();
+MapString, ListString allPermsInfo = new TreeMapString,
ListString();
if
[gwt-contrib] Make compiler log start counting permutations at 0 (again)
Reviewers: scottb,
Description:
Scott,
could you review this simple patch for me? It reverts an earlier
change, so that the compiler log starts counting permutations at 0
again. While less pretty, it's consistent with everything else.
Thanks,
kathrin
Please review this at http://gwt-code-reviews.appspot.com/112803
Affected files:
dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
Index: dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
===
--- dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(revision 7071)
+++ dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(working copy)
@@ -216,8 +216,7 @@
PropertyOracle[] propertyOracles = permutation.getPropertyOracles();
int permutationId = permutation.getId();
MapString, String rebindAnswers = permutation.getRebindAnswers();
-int printId = permutationId + 1;
-logger.log(TreeLogger.INFO, Compiling permutation + printId
+ ...);
+logger.log(TreeLogger.INFO, Compiling permutation + permutationId
+ ...);
long permStart = System.currentTimeMillis();
try {
if (JProgram.isTracingEnabled()) {
Index: dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
===
--- dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
(revision
7071)
+++ dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
(working
copy)
@@ -249,9 +249,8 @@
ListWork work = new ArrayListWork(permutations.length);
for (int i = 0; i permutations.length; ++i) {
Permutation perm = permutations[i];
- int printId = perm.getId() + 1;
logger.log(TreeLogger.DEBUG,
- Creating worker permutation + printId + of +
permutations.length);
+ Creating worker permutation + perm.getId() + of +
permutations.length);
work.add(new Work(logger, perm, resultFiles.get(i)));
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Move setStartupURLs earlier, add launch support in Swing UI
http://gwt-code-reviews.appspot.com/111801/diff/1/3
File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):
http://gwt-code-reviews.appspot.com/111801/diff/1/3#newcode1053
Line 1053: for (String prenormalized : options.getStartupURLs()) {
In the event that no -startupURLs were provided couldn't GWT compute a
set of startup URLs? The plugin would not need to have any logic for
adding additional -startupURLs on the commandline and all UIs would
benefit. All UIs are going to have to help the user determine the URLs.
-noserver is interesting, and you are right that it would not know how
to compute the URLs, but in that case GPE would not know how to compute
them either unless a user specified the -startupURLs on the command
line. The 90% case is local server so I'd think that GWT could compute
these.
On 2009/11/23 15:07:42, jat wrote:
On 2009/11/23 14:57:09, mmendez wrote:
If no startupURLs are specified on the command line, would it be
possible to
compute them here? That way GPE won't need to and all UIs would
benefit.
Where would it get them from?
For GPE, Rajeev (in a separate thread) said that it would now
synthesize
-startupUrl args if none were supplied by the user rather than trying
to merge
them in later. That seems a better solution to me.
Also, consider the -noserver case where it has no idea where your
server is or
what web pages it has access to.
http://gwt-code-reviews.appspot.com/111801/diff/1/3#newcode1053
Line 1053: for (String prenormalized : options.getStartupURLs()) {
It is the same issue for the plugin, but I think that the SDK would, by
definition, do a better job. As the algorithm improves everyone would
benefit (all UI implementations).
I'm not a big fan of the magic arguments in the plugin generated command
line because they hinder understanding.
As far as -noserver is concerned, the plugin has the same issue. In
that case, it can't generate a proper startup URL unless the user tells
it. The common case is not -noserver, so I'm not sure it is a good idea
to strike this idea based on that one case.
On 2009/11/23 15:07:42, jat wrote:
On 2009/11/23 14:57:09, mmendez wrote:
If no startupURLs are specified on the command line, would it be
possible to
compute them here? That way GPE won't need to and all UIs would
benefit.
Where would it get them from?
For GPE, Rajeev (in a separate thread) said that it would now
synthesize
-startupUrl args if none were supplied by the user rather than trying
to merge
them in later. That seems a better solution to me.
Also, consider the -noserver case where it has no idea where your
server is or
what web pages it has access to.
http://gwt-code-reviews.appspot.com/111801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Incubator's GlassPanel to GWT trunk
Thanks for your answer Thomas. Actually I was interested in having the GlassPanel as a separate widget and with the possibility of applying it to any absolutePanel. I already implemented my own widget for that based on the patch I mentioned before but wanted to know if those features would make it to the trunk in any upcoming release. Thanks, Martin On Sun, Nov 22, 2009 at 5:18 PM, Thomas Broyer t.bro...@gmail.com wrote: On 22 nov, 18:24, MartinGoros martin.goroste...@gmail.com wrote: Hi people, After downloading GWT 2.0 RC I thought that the Incubator's GlassPanel modified as stated inhttp://gwt-code-reviews.appspot.com/39806/show would be there but didn't find it... Any comments in the status of the that patch? may it make it to the GWT 2.0 final release? any blocking issue for promoting this? GlassPanel isn't there, but PopupPanel::setGlassEnabled is: http://code.google.com/p/google-web-toolkit/source/detail?r=6709 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Code Review Request: Add Info Message To Indicate When a Module Load is Complete
http://gwt-code-reviews.appspot.com/112802/diff/1/2 File dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java (right): http://gwt-code-reviews.appspot.com/112802/diff/1/2#newcode186 Line 186: Module + moduleName + loaded); Lets go with Module xxx has been started.. Truly, that is what has really happened here. http://gwt-code-reviews.appspot.com/112802 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make compiler log start counting permutations at 0 (again)
LVGTM http://gwt-code-reviews.appspot.com/112803 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Code Review Request: Add Info Message To Indicate When a Module Load is Complete
Ended up going with Module xxx has been loaded. John, I agree with your point, but I think those other messages should be changed to be more specific. http://gwt-code-reviews.appspot.com/112802 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7109 committed - Adds an info message to indicate when a module has loaded successfully...
Revision: 7109
Author: rda...@google.com
Date: Mon Nov 23 08:55:43 2009
Log: Adds an info message to indicate when a module has loaded successfully.
Review by: mmendez, jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7109
Modified:
/trunk/dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java
===
--- /trunk/dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java
Fri Nov 20 18:59:36 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java
Mon Nov 23 08:55:43 2009
@@ -43,6 +43,7 @@
/**
* Listens for new connections from browsers.
+ *
* @param topLogger logger to use for non-module-related messages
* @param host BrowserWidgetHost instance
*/
@@ -182,6 +183,8 @@
moduleMap.put(serverChannel, moduleSpace);
PerfLogger.start(ModuleSpace.onLoad);
moduleSpace.onLoad(logger);
+ moduleHandle.getLogger().log(TreeLogger.INFO,
+ Module + moduleName + has been loaded);
} catch (Throwable e) {
// We do catch Throwable intentionally because there are a ton of
things
// that can go wrong trying to load a module, including Error-derived
@@ -245,8 +248,10 @@
null);
return;
}
-moduleHandle.getLogger().log(TreeLogger.INFO, Unloading module
-+ moduleSpace.getModuleName() + ( + moduleName + ), null);
+moduleHandle.getLogger().log(
+TreeLogger.INFO,
+Unloading module + moduleSpace.getModuleName() + ( +
moduleName
++ ), null);
moduleSpace.dispose();
moduleHandle.unload();
moduleMap.remove(serverChannel);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7110 committed - Merged tr...@r7109 into releases/2.0. Merge was performed with the fol...
Revision: 7110
Author: rda...@google.com
Date: Mon Nov 23 08:58:37 2009
Log: Merged tr...@r7109 into releases/2.0. Merge was performed with the
following command:
svn merge --ignore-ancestry -c 7105
http://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=7110
Modified:
/releases/2.0/dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java
===
---
/releases/2.0/dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java
Fri Nov 20 19:14:08 2009
+++
/releases/2.0/dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java
Mon Nov 23 08:58:37 2009
@@ -43,6 +43,7 @@
/**
* Listens for new connections from browsers.
+ *
* @param topLogger logger to use for non-module-related messages
* @param host BrowserWidgetHost instance
*/
@@ -182,6 +183,8 @@
moduleMap.put(serverChannel, moduleSpace);
PerfLogger.start(ModuleSpace.onLoad);
moduleSpace.onLoad(logger);
+ moduleHandle.getLogger().log(TreeLogger.INFO,
+ Module + moduleName + has been loaded);
} catch (Throwable e) {
// We do catch Throwable intentionally because there are a ton of
things
// that can go wrong trying to load a module, including Error-derived
@@ -245,8 +248,10 @@
null);
return;
}
-moduleHandle.getLogger().log(TreeLogger.INFO, Unloading module
-+ moduleSpace.getModuleName() + ( + moduleName + ), null);
+moduleHandle.getLogger().log(
+TreeLogger.INFO,
+Unloading module + moduleSpace.getModuleName() + ( +
moduleName
++ ), null);
moduleSpace.dispose();
moduleHandle.unload();
moduleMap.remove(serverChannel);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Code Review Request: Add Info Message To Indicate When a Module Load is Complete
Committed as tr...@r7109 and cherry-picked into releases/2.0 at r7110. http://gwt-code-reviews.appspot.com/112802 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7111 committed - Updated branch-info.txt to reflect merge of tr...@r7109 into releases/...
Revision: 7111 Author: rda...@google.com Date: Mon Nov 23 09:00:15 2009 Log: Updated branch-info.txt to reflect merge of tr...@r7109 into releases/2.0 at r7110. http://code.google.com/p/google-web-toolkit/source/detail?r=7111 Modified: /releases/2.0/branch-info.txt === --- /releases/2.0/branch-info.txt Mon Nov 23 07:19:24 2009 +++ /releases/2.0/branch-info.txt Mon Nov 23 09:00:15 2009 @@ -970,3 +970,7 @@ Update the gwt-user widgets XSD to support LayoutPanel. svn merge --ignore-ancestry -c 7105 https://google-web-toolkit.googlecode.com/svn/trunk . +tr...@7109 was merged into this branch + Adds INFO mesage to indcate when a module has been loaded. + svn merge --ignore-ancestry -c 7109 https://google-web-toolkit.googlecode.com/svn/trunk . + -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7112 committed - Improved error handling of failure to connect to remote UI....
Revision: 7112
Author: rda...@google.com
Date: Mon Nov 23 09:03:48 2009
Log: Improved error handling of failure to connect to remote UI.
Review by: mmendez
http://code.google.com/p/google-web-toolkit/source/detail?r=7112
Modified:
/trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java
===
--- /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java Fri Nov 20
09:15:40 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java Mon Nov 23
09:03:48 2009
@@ -311,7 +311,7 @@
public String[] getTagArgs() {
return new String[] {port-number:client-id-string |
host-string:port-number:client-id-string};
}
-
+
@Override
public boolean isUndocumented() {
return true;
@@ -575,8 +575,7 @@
private static final AtomicLong uniqueId = new AtomicLong();
- public static String normalizeURL(String unknownUrlText, int port,
- String host) {
+ public static String normalizeURL(String unknownUrlText, int port,
String host) {
if (unknownUrlText.indexOf(:) != -1) {
// Assume it's a full url.
return unknownUrlText;
@@ -993,10 +992,16 @@
newUI = new HeadlessUI(options);
} else {
if (options.useRemoteUI()) {
-newUI = new RemoteUI(options.getRemoteUIHost(),
-options.getRemoteUIHostPort(), options.getClientId(),
-options.getPort(), options.getCodeServerPort());
-baseLogLevelForUI = TreeLogger.Type.TRACE;
+try {
+ newUI = new RemoteUI(options.getRemoteUIHost(),
+ options.getRemoteUIHostPort(), options.getClientId(),
+ options.getPort(), options.getCodeServerPort());
+ baseLogLevelForUI = TreeLogger.Type.TRACE;
+} catch (Throwable t) {
+ System.err.println(Could not connect to remote UI listening at
+ + options.getRemoteUIHost() + : +
options.getRemoteUIHostPort()
+ + . Using default UI instead.);
+}
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Code Review Request: Add better handling of failure to connect to remote UI
Thanks for the review. Committed as tr...@r7112 and cherry-picked into releases/2.0 at r7113. http://gwt-code-reviews.appspot.com/111802 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7113 committed - Merged tr...@r7112 into releases/2.0. Merge was performed with the fol...
Revision: 7113
Author: rda...@google.com
Date: Mon Nov 23 09:05:16 2009
Log: Merged tr...@r7112 into releases/2.0. Merge was performed with the
following command:
svn merge --ignore-ancestry -c 7112
http://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=7113
Modified:
/releases/2.0/dev/core/src/com/google/gwt/dev/DevModeBase.java
===
--- /releases/2.0/dev/core/src/com/google/gwt/dev/DevModeBase.java Fri Nov
20 11:47:11 2009
+++ /releases/2.0/dev/core/src/com/google/gwt/dev/DevModeBase.java Mon Nov
23 09:05:16 2009
@@ -311,7 +311,7 @@
public String[] getTagArgs() {
return new String[] {port-number:client-id-string |
host-string:port-number:client-id-string};
}
-
+
@Override
public boolean isUndocumented() {
return true;
@@ -575,8 +575,7 @@
private static final AtomicLong uniqueId = new AtomicLong();
- public static String normalizeURL(String unknownUrlText, int port,
- String host) {
+ public static String normalizeURL(String unknownUrlText, int port,
String host) {
if (unknownUrlText.indexOf(:) != -1) {
// Assume it's a full url.
return unknownUrlText;
@@ -993,10 +992,16 @@
newUI = new HeadlessUI(options);
} else {
if (options.useRemoteUI()) {
-newUI = new RemoteUI(options.getRemoteUIHost(),
-options.getRemoteUIHostPort(), options.getClientId(),
-options.getPort(), options.getCodeServerPort());
-baseLogLevelForUI = TreeLogger.Type.TRACE;
+try {
+ newUI = new RemoteUI(options.getRemoteUIHost(),
+ options.getRemoteUIHostPort(), options.getClientId(),
+ options.getPort(), options.getCodeServerPort());
+ baseLogLevelForUI = TreeLogger.Type.TRACE;
+} catch (Throwable t) {
+ System.err.println(Could not connect to remote UI listening at
+ + options.getRemoteUIHost() + : +
options.getRemoteUIHostPort()
+ + . Using default UI instead.);
+}
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make compiler log start counting permutations at 0 (again)
On 2009/11/23 16:40:11, scottb wrote: LVGTM Thanks, committed to trunk at r7115. http://gwt-code-reviews.appspot.com/112803 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7114 committed - Updating branch-info.txt to reflect merge of tr...@r7112 into releases...
Revision: 7114 Author: rda...@google.com Date: Mon Nov 23 09:06:36 2009 Log: Updating branch-info.txt to reflect merge of tr...@r7112 into releases/2.0 at r7113. http://code.google.com/p/google-web-toolkit/source/detail?r=7114 Modified: /releases/2.0/branch-info.txt === --- /releases/2.0/branch-info.txt Mon Nov 23 09:00:15 2009 +++ /releases/2.0/branch-info.txt Mon Nov 23 09:06:36 2009 @@ -974,3 +974,7 @@ Adds INFO mesage to indcate when a module has been loaded. svn merge --ignore-ancestry -c 7109 https://google-web-toolkit.googlecode.com/svn/trunk . +tr...@7112 was merged into this branch + Improves error handling when there is a failure to connect to the remote UI. + svn merge --ignore-ancestry -c 7112 http://google-web-toolkit.googlecode.com/svn/trunk . + -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7115 committed - Make compiler log start counting permutations at 0 (again). This make...
Revision: 7115
Author: kpro...@google.com
Date: Mon Nov 23 09:14:03 2009
Log: Make compiler log start counting permutations at 0 (again). This
makes it consistend with everything else.
Review by: scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=7115
Modified:
/trunk/dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
/trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
===
--- /trunk/dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
Fri Oct 23 13:15:54 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
Mon Nov 23 09:14:03 2009
@@ -249,9 +249,8 @@
ListWork work = new ArrayListWork(permutations.length);
for (int i = 0; i permutations.length; ++i) {
Permutation perm = permutations[i];
- int printId = perm.getId() + 1;
logger.log(TreeLogger.DEBUG,
- Creating worker permutation + printId + of +
permutations.length);
+ Creating worker permutation + perm.getId() + of +
permutations.length);
work.add(new Work(logger, perm, resultFiles.get(i)));
}
===
---
/trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
Wed Nov 18 12:17:07 2009
+++
/trunk/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
Mon Nov 23 09:14:03 2009
@@ -216,8 +216,7 @@
PropertyOracle[] propertyOracles = permutation.getPropertyOracles();
int permutationId = permutation.getId();
MapString, String rebindAnswers = permutation.getRebindAnswers();
-int printId = permutationId + 1;
-logger.log(TreeLogger.INFO, Compiling permutation + printId
+ ...);
+logger.log(TreeLogger.INFO, Compiling permutation + permutationId
+ ...);
long permStart = System.currentTimeMillis();
try {
if (JProgram.isTracingEnabled()) {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7116 committed - Merges trunk revision 7115 into this branch: Make compiler log start c...
Revision: 7116
Author: kpro...@google.com
Date: Mon Nov 23 09:21:44 2009
Log: Merges trunk revision 7115 into this branch: Make compiler log start
counting permutations at 0 (again). This makes it consistend with
everything else.
Review by: scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=7116
Modified:
/releases/2.0/dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
/releases/2.0/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
===
---
/releases/2.0/dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
Thu Oct 29 07:49:45 2009
+++
/releases/2.0/dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
Mon Nov 23 09:21:44 2009
@@ -249,9 +249,8 @@
ListWork work = new ArrayListWork(permutations.length);
for (int i = 0; i permutations.length; ++i) {
Permutation perm = permutations[i];
- int printId = perm.getId() + 1;
logger.log(TreeLogger.DEBUG,
- Creating worker permutation + printId + of +
permutations.length);
+ Creating worker permutation + perm.getId() + of +
permutations.length);
work.add(new Work(logger, perm, resultFiles.get(i)));
}
===
---
/releases/2.0/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
Wed Nov 11 17:18:27 2009
+++
/releases/2.0/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
Mon Nov 23 09:21:44 2009
@@ -212,8 +212,7 @@
PropertyOracle[] propertyOracles, int permutationId)
throws UnableToCompleteException {
-int printId = permutationId + 1;
-logger.log(TreeLogger.INFO, Compiling permutation + printId
+ ...);
+logger.log(TreeLogger.INFO, Compiling permutation + permutationId
+ ...);
long permStart = System.currentTimeMillis();
try {
if (JProgram.isTracingEnabled()) {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add -prod flag, deprecate -web flag
Also need to update things produced by webAppCreator, such as the template project.ant.xmlsrc http://gwt-code-reviews.appspot.com/112805/diff/1/2 File user/src/com/google/gwt/junit/JUnitShell.java (right): http://gwt-code-reviews.appspot.com/112805/diff/1/2#newcode180 Line 180: return true; Also implement isUndocumented to return true, so it won't show up in the help. http://gwt-code-reviews.appspot.com/112805 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] TypeOracle allTypes including types not in a source path
I'm getting closer to figuring out exactly what happened here. The
extra classes that were getting included were all under root-package/
client. I've restructured our half-dozen GWT modules so that they all
inherit source paths and imports from a basic set of root modules.
For modules that differ only in entry point, the module XML looks
something like this:
module
inherits name='rootpackage.Common' /
entry-point class='rootpackage.othermodule.Module' /
/module
When GWT loads a module without any source elements in a module, it
adds an implicit source path=client / in ModuleDefSchema. After
some module refactoring that took place in my GWT 2.0 porting work,
the modules that no longer had source paths after I had modified the
modules were causing extra source to be silently imported:
(from ModuleDefSchema):
// Maybe infer source and public.
//
if (!foundExplicitSourceOrSuperSource) {
bodySchema.addSourcePackage(modulePackageAsPath, client,
Empty.STRINGS,
Empty.STRINGS, true, true, false);
}
I can no longer reproduce the specific crash below, but I strongly
suspect it was related to the other compiler errors.
I'll work around the implicit source path issue for now by using fake
source paths in modules that don't have any additional source
imports. If possible, it would be useful if there were a log warning
explaining that the source path is defaulting to client.
After fixing this, I managed to get my first GWT 2.0 build working
from the command line with a free 4% savings on final code size. :)
Thanks,
Matt.
On 20-Nov-09, at 11:05 AM, Scott Blum wrote:
Hi Matt,
I need more information, because on the face of it, I don't see how
we can be pulling in all types in all cases. We have specific type
oracle tests that check how many types total end up in type oracle.
If it was a fundamental problem, these tests should be blowing up.
Example:
http://code.google.com/p/google-web-toolkit/source/browse/trunk/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTest.java#1060
So, I stuck added the following code at the end of
TypeOracleMediator.addNewUnits() and compiled the Hello sample:
StringBuilder sb = new StringBuilder();
for (JClassType type : typeOracle.getTypes()) {
String sn = type.getQualifiedSourceName();
if (sn.contains(.client.)) {
continue;
}
if (sn.contains(.shared.)) {
continue;
}
if (sn.startsWith(java.)) {
continue;
}
if (sn.startsWith(com.google.gwt.lang.)) {
continue;
}
sb.append(sn);
sb.append('\n');
}
PerfLogger.end(); breakpoint here
I didn't see anything get added that shouldn't be there. Can you
dig into this a little or put together a small sample?
Thanks,
Scott
On Thu, Nov 19, 2009 at 10:40 PM, Matt Mastracci matt...@mastracci.com
wrote:
Hey all,
Sorry to keep spamming GWT 2.0 issues.
I've run into a difference in how TypeOracle works that seems to have
changed in GWT 2.0. In previous versions, calling
context.getTypeOracle().getTypes() from a generator would limit itself
to types available on the source paths. I have some code that took
advantage of that to build a quick-and-dirty annotation-based
dependency-injection framework. It generates a single factory class
which contains methods to initialize all of the injectable classes
(and injectee) classes available on the source path.
It seems that getTypeOracle().getTypes() is now returning all classes
available on the classpath, rather than limiting itself to source-
specified classes. These classes are picked up by the factory and
generated into the new class, which then ends up causing a
java.lang.NoClassDefFoundError
when this class is instantiated:
Caused by: java.lang.NoClassDefFoundError: XXX
at java.lang.Class.getDeclaredConstructors0(Native Method)
at java.lang.Class.privateGetDeclaredConstructors(Class.java:2357)
at java.lang.Class.getDeclaredConstructors(Class.java:1808)
at
com
.google
.gwt
.dev
.shell
.DispatchClassInfo
.lazyInitTargetMembersUsingReflectionHelper(DispatchClassInfo.java:
163)
at
com
.google
.gwt
.dev
.shell.DispatchClassInfo.lazyInitTargetMembers(DispatchClassInfo.java:
146)
at
com
.google
.gwt.dev.shell.DispatchClassInfo.getMemberId(DispatchClassInfo.java:
55)
at com.google.gwt.dev.shell.CompilingClassLoader
$DispatchClassInfoOracle.getDispId(CompilingClassLoader.java:166)
at
com
.google
.gwt
.dev.shell.CompilingClassLoader.getDispId(CompilingClassLoader.java:
930)
at com.google.gwt.dev.shell.Jsni
$JsSourceGenWithJsniIdentFixup.visit(Jsni.java:105)
The exception itself is probably a bug (not sure why it didn't trigger
a compiler error), but I'm not sure if TypeOracle.getTypes() returning
all types is by design.
I've been looking for an excuse to ditch the custom IoC code
[gwt-contrib] Re: Add -prod flag, deprecate -web flag
On Mon, Nov 23, 2009 at 1:29 PM, Daniel Rice (דניאל רייס) r...@google.comwrote: Yes, project.ant.xmlsrc is already included. Doh. Nevermind that part of the comment. LGTM with the other change. -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7117 committed - Wrapping selenium hosts in quotes so we can use spaces in the host nam...
Revision: 7117
Author: jlaba...@google.com
Date: Mon Nov 23 10:39:00 2009
Log: Wrapping selenium hosts in quotes so we can use spaces in the host
names.
Patch by: jlabanca
Review by: fabbott
http://code.google.com/p/google-web-toolkit/source/detail?r=7117
Modified:
/trunk/user/build.xml
===
--- /trunk/user/build.xml Mon Nov 16 12:53:32 2009
+++ /trunk/user/build.xml Mon Nov 23 10:39:00 2009
@@ -224,7 +224,7 @@
includes=${gwt.junit.testcase.dev.includes}
excludes=${gwt.junit.testcase.dev.excludes} /
gwt.junit test.name=test.emma.selenium
-test.args=${test.emma.selenium.args} -out www -runStyle
Selenium:${gwt.hosts.dev.selenium} -batch module
+test.args='${test.emma.selenium.args} -out www
-runStyle Selenium:${gwt.hosts.dev.selenium} -batch module'
test.out=${junit.out}/emma-selenium
test.cases=test.emma.selenium.tests
extraclasspaths
@@ -288,7 +288,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.web.selenium
-test.args=${test.web.selenium.args} -web -out www -runStyle
Selenium:${gwt.hosts.web.selenium} -batch module
+test.args='${test.web.selenium.args} -web -out www
-runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
test.out=${junit.out}/web-selenium
test.cases=test.web.selenium.tests
extraclasspaths
@@ -328,7 +328,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.nometa.selenium
-test.args=${test.nometa.selenium.args} -XdisableClassMetadata
-web -out www -runStyle Selenium:${gwt.hosts.web.selenium} -batch module
+test.args='${test.nometa.selenium.args} -XdisableClassMetadata
-web -out www -runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
test.out=${junit.out}/nometa-selenium
test.cases=test.nometa.selenium.tests
extraclasspaths
@@ -348,7 +348,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.draft.selenium
-test.args=${test.draft.selenium.args} -draftCompile -web -out www
-runStyle Selenium:${gwt.hosts.web.selenium} -batch module
+test.args='${test.draft.selenium.args} -draftCompile -web -out www
-runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
test.out=${junit.out}/draft-selenium
test.cases=test.draft.selenium.tests
extraclasspaths
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] TypeOracle allTypes including types not in a source path
On Mon, Nov 23, 2009 at 1:33 PM, Matt Mastracci matt...@mastracci.comwrote: I'll work around the implicit source path issue for now by using fake source paths in modules that don't have any additional source imports. If possible, it would be useful if there were a log warning explaining that the source path is defaulting to client. I don't think that warning there would be good, as that is a pretty common default - basically if you are using the recommended package setup and you don't have server-shared code, the common case is not needing any source tag in your module. -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7118 committed - tr...@7117 was merged into this branch...
Revision: 7118
Author: jlaba...@google.com
Date: Mon Nov 23 10:40:40 2009
Log: tr...@7117 was merged into this branch
Allows spaces in test targets in user/build.xml.
svn merge --ignore-ancestry -c 7117
http://google-web-toolkit.googlecode.com/svn/trunk .
Patch by: jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=7118
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/build.xml
===
--- /releases/2.0/branch-info.txt Mon Nov 23 09:06:36 2009
+++ /releases/2.0/branch-info.txt Mon Nov 23 10:40:40 2009
@@ -978,3 +978,7 @@
Improves error handling when there is a failure to connect to the remote
UI.
svn merge --ignore-ancestry -c 7112
http://google-web-toolkit.googlecode.com/svn/trunk .
+tr...@7117 was merged into this branch
+ Allows spaces in test targets in user/build.xml.
+ svn merge --ignore-ancestry -c 7117
http://google-web-toolkit.googlecode.com/svn/trunk .
+
===
--- /releases/2.0/user/build.xmlMon Nov 16 12:57:41 2009
+++ /releases/2.0/user/build.xmlMon Nov 23 10:40:40 2009
@@ -218,7 +218,7 @@
includes=${gwt.junit.testcase.dev.includes}
excludes=${gwt.junit.testcase.dev.excludes} /
gwt.junit test.name=test.emma.selenium
-test.args=${test.emma.selenium.args} -out www -runStyle
Selenium:${gwt.hosts.dev.selenium} -batch module
+test.args='${test.emma.selenium.args} -out www
-runStyle Selenium:${gwt.hosts.dev.selenium} -batch module'
test.out=${junit.out}/emma-selenium
test.cases=test.emma.selenium.tests
extraclasspaths
@@ -282,7 +282,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.web.selenium
-test.args=${test.web.selenium.args} -web -out www -runStyle
Selenium:${gwt.hosts.web.selenium} -batch module
+test.args='${test.web.selenium.args} -web -out www
-runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
test.out=${junit.out}/web-selenium
test.cases=test.web.selenium.tests
extraclasspaths
@@ -322,7 +322,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.nometa.selenium
-test.args=${test.nometa.selenium.args} -XdisableClassMetadata
-web -out www -runStyle Selenium:${gwt.hosts.web.selenium} -batch module
+test.args='${test.nometa.selenium.args} -XdisableClassMetadata
-web -out www -runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
test.out=${junit.out}/nometa-selenium
test.cases=test.nometa.selenium.tests
extraclasspaths
@@ -342,7 +342,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.draft.selenium
-test.args=${test.draft.selenium.args} -draftCompile -web -out www
-runStyle Selenium:${gwt.hosts.web.selenium} -batch module
+test.args='${test.draft.selenium.args} -draftCompile -web -out www
-runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
test.out=${junit.out}/draft-selenium
test.cases=test.draft.selenium.tests
extraclasspaths
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] TypeOracle allTypes including types not in a source path
Maybe not a warning, but maybe an INFO-level log entry, or perhaps a TRACE-level one. I think the default introduction of source path=client is net confusing. Forcing people to specify it would have helped (forced?) people to understand what is going on. On Mon, Nov 23, 2009 at 1:40 PM, John Tamplin j...@google.com wrote: On Mon, Nov 23, 2009 at 1:33 PM, Matt Mastracci matt...@mastracci.comwrote: I'll work around the implicit source path issue for now by using fake source paths in modules that don't have any additional source imports. If possible, it would be useful if there were a log warning explaining that the source path is defaulting to client. I don't think that warning there would be good, as that is a pretty common default - basically if you are using the recommended package setup and you don't have server-shared code, the common case is not needing any source tag in your module. -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Add deprecation warning to SoycDashboard
Reviewers: Lex,
Description:
Users should no longer use the SoycDashboard directly, because the
compiler option -compileReport will already cause all compile report
files to be written to the extras directory. This patch adds a simple
warning to users of the dashboard.
For people who use -soyc, the particular wording of the warning seems to
imply that they're to use -compileReport if they want the files written
directly. This is a bit misleading, but its only effect will be to move
more people to using -compileReport rather than the deprecated -soyc,
which I think is ok.
Please review this at http://gwt-code-reviews.appspot.com/111803
Affected files:
dev/core/src/com/google/gwt/soyc/SoycDashboard.java
Index: dev/core/src/com/google/gwt/soyc/SoycDashboard.java
===
--- dev/core/src/com/google/gwt/soyc/SoycDashboard.java (revision 7116)
+++ dev/core/src/com/google/gwt/soyc/SoycDashboard.java (working copy)
@@ -65,7 +65,14 @@
}
}
- public static void main(final String[] args) {
+ public static void main(final String[] args) throws InterruptedException
{
+
+System.out.println(WARNING: The direct use of the SoycDashboard is
deprecated and will be removed. +
+ The preferred usage is to invoke the compiler with the
-compileReport option, which +
+ writes the compile report directly to the extra directory.);
+Thread.currentThread();
+Thread.sleep(1000);
+
Settings settings;
try {
settings = Settings.fromArgumentList(args);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Remove TODOs from hosted.html
Reviewers: bruce,
Description:
These have been moved to bug entries.
Please review this at http://gwt-code-reviews.appspot.com/112806
Affected files:
dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
Index: dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
===
--- dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
(revision
7118)
+++ dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
(working
copy)
@@ -1,7 +1,5 @@
html
headscript
-// TODO(jat): wrap these to reduce namespace issues, and refactor code into
-//separate functions.
var $wnd = parent;
var $doc = $wnd.document;
var $moduleName, $moduleBase, $entry
@@ -51,7 +49,6 @@
var ua = navigator.userAgent.toLowerCase();
if (ua.indexOf(gecko) != -1) {
// install eval wrapper on FF to avoid EvalError problem
- // TODO(jat): should this UA check be more specific (this hits chrome
too)?
var __eval = window.eval;
window.eval = function(s) {
return __eval(s);
@@ -226,21 +223,7 @@
$moduleName = modName;
$moduleBase = modBase;
- /*
- * NOTE: this presently sucks and is the only formulation I can find
that will
- * work across browsers. On a Windows box where both plugins are
registered,
- * FF will instantiate the (non-working) IE plugin. But plugins have
problems
- * that prevent making this easy.
- *
- * The IE plugin will throw an exception in FF if you try to resolve
- * pluginObject.connect as a value. Thus the try/catch below.
- *
- * The FF plugin will actually do illegal crashy things in IE if you try
to
- * resolve pluginEmbed.connect as a value. Thus we have to try the IE
- * plugin first.
- *
- * Both plugins need some work to make them truly safe.
- */
+ // Note that the order is important
var pluginFinders = [
findPluginXPCOM,
findPluginObject,
@@ -304,8 +287,6 @@
}
window.onunload = function() {
- // TODO: do we need to do anything here or just rely on the plugins
- // unload call?
};
// Lightweight metrics
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] TypeOracle allTypes including types not in a source path
FWIW, this confusion is exactly why webAppCreator no longer generates projects that use the implicit include. I wonder if we shouldn't flat out deprecate it--in which case a warning would be the right thing. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] TypeOracle allTypes including types not in a source path
+1 deprecate and warn. On Mon, Nov 23, 2009 at 2:24 PM, Ray Ryan rj...@google.com wrote: FWIW, this confusion is exactly why webAppCreator no longer generates projects that use the implicit include. I wonder if we shouldn't flat out deprecate it--in which case a warning would be the right thing. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add deprecation warning to SoycDashboard
LGTM http://gwt-code-reviews.appspot.com/111803/diff/1/2 File dev/core/src/com/google/gwt/soyc/SoycDashboard.java (right): http://gwt-code-reviews.appspot.com/111803/diff/1/2#newcode74 Line 74: Thread.sleep(1000); One second is very short. Maybe 5? http://gwt-code-reviews.appspot.com/111803 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7119 committed - Fix Arrays.equals(Object[], Object[]) to handle nulls....
Revision: 7119
Author: j...@google.com
Date: Mon Nov 23 11:36:05 2009
Log: Fix Arrays.equals(Object[], Object[]) to handle nulls.
Patch by: hhc...@google.com
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7119
Modified:
/trunk/user/super/com/google/gwt/emul/java/util/Arrays.java
/trunk/user/test/com/google/gwt/emultest/java/util/ArraysTest.java
===
--- /trunk/user/super/com/google/gwt/emul/java/util/Arrays.java Mon May 18
11:47:32 2009
+++ /trunk/user/super/com/google/gwt/emul/java/util/Arrays.java Mon Nov 23
11:36:05 2009
@@ -680,7 +680,7 @@
for (int i = 0; i array1.length; ++i) {
Object val1 = array1[i];
Object val2 = array2[i];
- if (!val1.equals(val2)) {
+ if (Utility.equalsWithNullCheck(val1, val2)) {
return false;
}
}
===
--- /trunk/user/test/com/google/gwt/emultest/java/util/ArraysTest.java Tue
Jul 8 12:08:40 2008
+++ /trunk/user/test/com/google/gwt/emultest/java/util/ArraysTest.java Mon
Nov 23 11:36:05 2009
@@ -70,6 +70,40 @@
String[] a = new String[] { foo, null, bar, baz };
Arrays.hashCode(a);
}
+
+ public void testArraysEqualsWithEmptyArrays() {
+assertTrue(Arrays.equals(new String[0], new String[0]));
+ }
+
+ public void testArraysEqualsWithoutNullElementsEqual() {
+assertTrue(Arrays.equals(
+new String[] { foo }, new String[]{ foo }));
+ }
+
+ public void testArraysEqualsWithoutNullElementsNotEqual() {
+assertFalse(Arrays.equals(
+new String[] { foo }, new String[]{ bar }));
+ }
+
+ public void testArraysEqualsWithNullElementsEqual() {
+assertTrue(Arrays.equals(new String[2], new String[2]));
+ }
+
+ public void testArraysEqualsWithNullElementsNotEqual() {
+assertFalse(Arrays.equals(new String[2], new String[1]));
+ }
+
+ public void testArraysEqualsWithNullAndNonNullElementsEqual() {
+assertTrue(Arrays.equals(
+new String[]{ null, foo, null, bar },
+new String[]{ null, foo, null, bar }));
+ }
+
+ public void testArraysEqualsWithNullAndNonNullElementsNotEqual() {
+assertFalse(Arrays.equals(
+new String[]{ null, bar, null, foo },
+new String[]{ null, foo, null, foo }));
+ }
/**
* Tests {...@link Arrays#asList(Object[])}.
@@ -606,7 +640,7 @@
* Advance the permutation to the next value. It leaves the first index
set to
* -1 if the range has been exceeded.
*
- * @param permutation array of indices -- see {...@link getPermutation} for
+ * @param permutation array of indices -- see {...@link #getPermutation} for
* details.
*/
private void nextPermutation(int[] permutation) {
@@ -621,7 +655,7 @@
/**
* Checks to see if this permutation is valid; ie, if all of the indices
are
- * between 0 and n-i (see {...@link getPermutation} for details).
+ * between 0 and n-i (see {...@link #getPermutation} for details).
*
* @param permutations array of indices
* @param n length of source array.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7120 committed - Merge trunk r7119 into this branch...
Revision: 7120
Author: j...@google.com
Date: Mon Nov 23 11:42:02 2009
Log: Merge trunk r7119 into this branch
Fix Arrays.equals(Object[], Object[]) for nulls.
svn merge --ignore-ancestry -c7119 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=7120
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/super/com/google/gwt/emul/java/util/Arrays.java
/releases/2.0/user/test/com/google/gwt/emultest/java/util/ArraysTest.java
===
--- /releases/2.0/branch-info.txt Mon Nov 23 10:40:40 2009
+++ /releases/2.0/branch-info.txt Mon Nov 23 11:42:02 2009
@@ -982,3 +982,7 @@
Allows spaces in test targets in user/build.xml.
svn merge --ignore-ancestry -c 7117
http://google-web-toolkit.googlecode.com/svn/trunk .
+tr...@7119 was merged into this branch
+ Fix Arrays.equals(Object[], Object[]) for nulls.
+svn merge --ignore-ancestry -c7119 \
+ https://google-web-toolkit.googlecode.com/svn/trunk/ .
===
--- /releases/2.0/user/super/com/google/gwt/emul/java/util/Arrays.java Mon
May 18 11:47:32 2009
+++ /releases/2.0/user/super/com/google/gwt/emul/java/util/Arrays.java Mon
Nov 23 11:42:02 2009
@@ -680,7 +680,7 @@
for (int i = 0; i array1.length; ++i) {
Object val1 = array1[i];
Object val2 = array2[i];
- if (!val1.equals(val2)) {
+ if (Utility.equalsWithNullCheck(val1, val2)) {
return false;
}
}
===
---
/releases/2.0/user/test/com/google/gwt/emultest/java/util/ArraysTest.java
Tue Jul 8 12:08:40 2008
+++
/releases/2.0/user/test/com/google/gwt/emultest/java/util/ArraysTest.java
Mon Nov 23 11:42:02 2009
@@ -70,6 +70,40 @@
String[] a = new String[] { foo, null, bar, baz };
Arrays.hashCode(a);
}
+
+ public void testArraysEqualsWithEmptyArrays() {
+assertTrue(Arrays.equals(new String[0], new String[0]));
+ }
+
+ public void testArraysEqualsWithoutNullElementsEqual() {
+assertTrue(Arrays.equals(
+new String[] { foo }, new String[]{ foo }));
+ }
+
+ public void testArraysEqualsWithoutNullElementsNotEqual() {
+assertFalse(Arrays.equals(
+new String[] { foo }, new String[]{ bar }));
+ }
+
+ public void testArraysEqualsWithNullElementsEqual() {
+assertTrue(Arrays.equals(new String[2], new String[2]));
+ }
+
+ public void testArraysEqualsWithNullElementsNotEqual() {
+assertFalse(Arrays.equals(new String[2], new String[1]));
+ }
+
+ public void testArraysEqualsWithNullAndNonNullElementsEqual() {
+assertTrue(Arrays.equals(
+new String[]{ null, foo, null, bar },
+new String[]{ null, foo, null, bar }));
+ }
+
+ public void testArraysEqualsWithNullAndNonNullElementsNotEqual() {
+assertFalse(Arrays.equals(
+new String[]{ null, bar, null, foo },
+new String[]{ null, foo, null, foo }));
+ }
/**
* Tests {...@link Arrays#asList(Object[])}.
@@ -606,7 +640,7 @@
* Advance the permutation to the next value. It leaves the first index
set to
* -1 if the range has been exceeded.
*
- * @param permutation array of indices -- see {...@link getPermutation} for
+ * @param permutation array of indices -- see {...@link #getPermutation} for
* details.
*/
private void nextPermutation(int[] permutation) {
@@ -621,7 +655,7 @@
/**
* Checks to see if this permutation is valid; ie, if all of the indices
are
- * between 0 and n-i (see {...@link getPermutation} for details).
+ * between 0 and n-i (see {...@link #getPermutation} for details).
*
* @param permutations array of indices
* @param n length of source array.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] TypeOracle allTypes including types not in a source path
let's remember to talk about this more for the release after 2.0 On Mon, Nov 23, 2009 at 2:26 PM, Isaac Truett itru...@gmail.com wrote: +1 deprecate and warn. On Mon, Nov 23, 2009 at 2:24 PM, Ray Ryan rj...@google.com wrote: FWIW, this confusion is exactly why webAppCreator no longer generates projects that use the implicit include. I wonder if we shouldn't flat out deprecate it--in which case a warning would be the right thing. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7122 committed - Replace JUnit's -web command-line flag with -prod (keeping -web as a d...
Revision: 7122
Author: r...@google.com
Date: Mon Nov 23 12:05:34 2009
Log: Replace JUnit's -web command-line flag with -prod (keeping -web as a
deprecated synonym)
Review by: jlabanca, jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7122
Modified:
/trunk/user/build.xml
/trunk/user/src/com/google/gwt/junit/JUnitShell.java
/trunk/user/src/com/google/gwt/user/tools/JUnit-prod.launchsrc
/trunk/user/src/com/google/gwt/user/tools/project.ant.xmlsrc
===
--- /trunk/user/build.xml Mon Nov 23 10:39:00 2009
+++ /trunk/user/build.xml Mon Nov 23 12:05:34 2009
@@ -164,7 +164,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.web.remote
-test.args=${test.web.remote.args} -out www -web -runStyle
RemoteWeb:${gwt.hosts.web.remote} -batch module
+test.args=${test.web.remote.args} -out www -prod -runStyle
RemoteWeb:${gwt.hosts.web.remote} -batch module
test.out=${junit.out}/web-remote
test.cases=test.web.remote.tests
extraclasspaths
@@ -245,7 +245,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.draft.remote
-test.args=${test.draft.remote.args} -draftCompile -web -out www
-runStyle RemoteWeb:${gwt.hosts.web.remote} -batch module
+test.args=${test.draft.remote.args} -draftCompile -prod -out www
-runStyle RemoteWeb:${gwt.hosts.web.remote} -batch module
test.out=${junit.out}/draft-remote
test.cases=test.draft.remote.tests
extraclasspaths
@@ -264,7 +264,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.nometa.remote
-test.args=${test.nometa.remote.args} -XdisableClassMetadata -web
-out www -runStyle RemoteWeb:${gwt.hosts.web.remote} -batch module
+test.args=${test.nometa.remote.args} -XdisableClassMetadata -prod
-out www -runStyle RemoteWeb:${gwt.hosts.web.remote} -batch module
test.out=${junit.out}/nometa-remote
test.cases=test.nometa.remote.tests
extraclasspaths
@@ -288,7 +288,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.web.selenium
-test.args='${test.web.selenium.args} -web -out www
-runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
+test.args='${test.web.selenium.args} -prod -out www
-runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
test.out=${junit.out}/web-selenium
test.cases=test.web.selenium.tests
extraclasspaths
@@ -328,7 +328,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.nometa.selenium
-test.args='${test.nometa.selenium.args} -XdisableClassMetadata
-web -out www -runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
+test.args='${test.nometa.selenium.args} -XdisableClassMetadata
-prod -out www -runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
test.out=${junit.out}/nometa-selenium
test.cases=test.nometa.selenium.tests
extraclasspaths
@@ -348,7 +348,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.draft.selenium
-test.args='${test.draft.selenium.args} -draftCompile -web -out www
-runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
+test.args='${test.draft.selenium.args} -draftCompile -prod -out
www -runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
test.out=${junit.out}/draft-selenium
test.cases=test.draft.selenium.tests
extraclasspaths
@@ -406,7 +406,7 @@
includes=${gwt.junit.testcase.noserver.includes}
excludes=${gwt.junit.testcase.noserver.excludes} /
gwt.junit test.name=test.noserver
-test.args=${test.args} -web -noserver
+test.args=${test.args} -prod -noserver
test.out=${junit.out}/noserver test.cases=test.noserver.tests
extraclasspaths
path refid=test.extraclasspath /
@@ -422,7 +422,7 @@
includes=${gwt.junit.testcase.standards.includes}
excludes=${gwt.junit.testcase.standards.excludes} /
gwt.junit test.name=test.standards
-test.args=${test.args} -web -XstandardsMode
+test.args=${test.args} -prod -XstandardsMode
test.out=${junit.out}/standards
test.cases=test.standards.tests
extraclasspaths
path refid=test.extraclasspath /
@@ -438,7 +438,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit
[gwt-contrib] [google-web-toolkit] r7123 committed - Adds deprecation warning to direct use of SoycDashboard. Review by: sp...
Revision: 7123
Author: kpro...@google.com
Date: Mon Nov 23 12:28:27 2009
Log: Adds deprecation warning to direct use of SoycDashboard. Review by:
spoon
http://code.google.com/p/google-web-toolkit/source/detail?r=7123
Modified:
/trunk/dev/core/src/com/google/gwt/soyc/SoycDashboard.java
===
--- /trunk/dev/core/src/com/google/gwt/soyc/SoycDashboard.java Mon Nov 23
06:46:03 2009
+++ /trunk/dev/core/src/com/google/gwt/soyc/SoycDashboard.java Mon Nov 23
12:28:27 2009
@@ -65,7 +65,14 @@
}
}
- public static void main(final String[] args) {
+ public static void main(final String[] args) throws InterruptedException
{
+
+System.out.println(WARNING: The direct use of the SoycDashboard is
deprecated and will be removed. +
+ The preferred usage is to invoke the compiler with the
-compileReport option, which +
+ writes the compile report directly to the extra directory.);
+Thread.currentThread();
+Thread.sleep(5000);
+
Settings settings;
try {
settings = Settings.fromArgumentList(args);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7124 committed - Merging trunk revision 7123 into this branch: Adds deprecation warning...
Revision: 7124
Author: kpro...@google.com
Date: Mon Nov 23 12:38:56 2009
Log: Merging trunk revision 7123 into this branch: Adds deprecation warning
to direct use of SoycDashboard. Review by: spoon
svn merge --ignore-ancestry -c 7123
https://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=7124
Modified:
/releases/2.0/dev/core/src/com/google/gwt/soyc/SoycDashboard.java
===
--- /releases/2.0/dev/core/src/com/google/gwt/soyc/SoycDashboard.java Mon
Nov 23 07:38:58 2009
+++ /releases/2.0/dev/core/src/com/google/gwt/soyc/SoycDashboard.java Mon
Nov 23 12:38:56 2009
@@ -65,7 +65,14 @@
}
}
- public static void main(final String[] args) {
+ public static void main(final String[] args) throws InterruptedException
{
+
+System.out.println(WARNING: The direct use of the SoycDashboard is
deprecated and will be removed. +
+ The preferred usage is to invoke the compiler with the
-compileReport option, which +
+ writes the compile report directly to the extra directory.);
+Thread.currentThread();
+Thread.sleep(5000);
+
Settings settings;
try {
settings = Settings.fromArgumentList(args);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7125 committed - Reverting r7119 due to test failure, will investigate later.
Revision: 7125
Author: j...@google.com
Date: Mon Nov 23 12:40:55 2009
Log: Reverting r7119 due to test failure, will investigate later.
http://code.google.com/p/google-web-toolkit/source/detail?r=7125
Modified:
/trunk/user/super/com/google/gwt/emul/java/util/Arrays.java
/trunk/user/test/com/google/gwt/emultest/java/util/ArraysTest.java
===
--- /trunk/user/super/com/google/gwt/emul/java/util/Arrays.java Mon Nov 23
11:36:05 2009
+++ /trunk/user/super/com/google/gwt/emul/java/util/Arrays.java Mon Nov 23
12:40:55 2009
@@ -680,7 +680,7 @@
for (int i = 0; i array1.length; ++i) {
Object val1 = array1[i];
Object val2 = array2[i];
- if (Utility.equalsWithNullCheck(val1, val2)) {
+ if (!val1.equals(val2)) {
return false;
}
}
===
--- /trunk/user/test/com/google/gwt/emultest/java/util/ArraysTest.java Mon
Nov 23 11:36:05 2009
+++ /trunk/user/test/com/google/gwt/emultest/java/util/ArraysTest.java Mon
Nov 23 12:40:55 2009
@@ -70,40 +70,6 @@
String[] a = new String[] { foo, null, bar, baz };
Arrays.hashCode(a);
}
-
- public void testArraysEqualsWithEmptyArrays() {
-assertTrue(Arrays.equals(new String[0], new String[0]));
- }
-
- public void testArraysEqualsWithoutNullElementsEqual() {
-assertTrue(Arrays.equals(
-new String[] { foo }, new String[]{ foo }));
- }
-
- public void testArraysEqualsWithoutNullElementsNotEqual() {
-assertFalse(Arrays.equals(
-new String[] { foo }, new String[]{ bar }));
- }
-
- public void testArraysEqualsWithNullElementsEqual() {
-assertTrue(Arrays.equals(new String[2], new String[2]));
- }
-
- public void testArraysEqualsWithNullElementsNotEqual() {
-assertFalse(Arrays.equals(new String[2], new String[1]));
- }
-
- public void testArraysEqualsWithNullAndNonNullElementsEqual() {
-assertTrue(Arrays.equals(
-new String[]{ null, foo, null, bar },
-new String[]{ null, foo, null, bar }));
- }
-
- public void testArraysEqualsWithNullAndNonNullElementsNotEqual() {
-assertFalse(Arrays.equals(
-new String[]{ null, bar, null, foo },
-new String[]{ null, foo, null, foo }));
- }
/**
* Tests {...@link Arrays#asList(Object[])}.
@@ -640,7 +606,7 @@
* Advance the permutation to the next value. It leaves the first index
set to
* -1 if the range has been exceeded.
*
- * @param permutation array of indices -- see {...@link #getPermutation} for
+ * @param permutation array of indices -- see {...@link getPermutation} for
* details.
*/
private void nextPermutation(int[] permutation) {
@@ -655,7 +621,7 @@
/**
* Checks to see if this permutation is valid; ie, if all of the indices
are
- * between 0 and n-i (see {...@link #getPermutation} for details).
+ * between 0 and n-i (see {...@link getPermutation} for details).
*
* @param permutations array of indices
* @param n length of source array.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7126 committed - Merge trunk r7125 into this branch....
Revision: 7126
Author: j...@google.com
Date: Mon Nov 23 12:44:09 2009
Log: Merge trunk r7125 into this branch.
Revert r7119.
svn merge --ignore-ancestry -c7125 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=7126
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/super/com/google/gwt/emul/java/util/Arrays.java
/releases/2.0/user/test/com/google/gwt/emultest/java/util/ArraysTest.java
===
--- /releases/2.0/branch-info.txt Mon Nov 23 11:42:02 2009
+++ /releases/2.0/branch-info.txt Mon Nov 23 12:44:09 2009
@@ -982,7 +982,9 @@
Allows spaces in test targets in user/build.xml.
svn merge --ignore-ancestry -c 7117
http://google-web-toolkit.googlecode.com/svn/trunk .
-tr...@7119 was merged into this branch
+tr...@7119 was merged into this branch, then its reversion in r7125
Fix Arrays.equals(Object[], Object[]) for nulls.
svn merge --ignore-ancestry -c7119 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
+svn merge --ignore-ancestry -c7125 \
+ https://google-web-toolkit.googlecode.com/svn/trunk/ .
===
--- /releases/2.0/user/super/com/google/gwt/emul/java/util/Arrays.java Mon
Nov 23 11:42:02 2009
+++ /releases/2.0/user/super/com/google/gwt/emul/java/util/Arrays.java Mon
Nov 23 12:44:09 2009
@@ -680,7 +680,7 @@
for (int i = 0; i array1.length; ++i) {
Object val1 = array1[i];
Object val2 = array2[i];
- if (Utility.equalsWithNullCheck(val1, val2)) {
+ if (!val1.equals(val2)) {
return false;
}
}
===
---
/releases/2.0/user/test/com/google/gwt/emultest/java/util/ArraysTest.java
Mon Nov 23 11:42:02 2009
+++
/releases/2.0/user/test/com/google/gwt/emultest/java/util/ArraysTest.java
Mon Nov 23 12:44:09 2009
@@ -70,40 +70,6 @@
String[] a = new String[] { foo, null, bar, baz };
Arrays.hashCode(a);
}
-
- public void testArraysEqualsWithEmptyArrays() {
-assertTrue(Arrays.equals(new String[0], new String[0]));
- }
-
- public void testArraysEqualsWithoutNullElementsEqual() {
-assertTrue(Arrays.equals(
-new String[] { foo }, new String[]{ foo }));
- }
-
- public void testArraysEqualsWithoutNullElementsNotEqual() {
-assertFalse(Arrays.equals(
-new String[] { foo }, new String[]{ bar }));
- }
-
- public void testArraysEqualsWithNullElementsEqual() {
-assertTrue(Arrays.equals(new String[2], new String[2]));
- }
-
- public void testArraysEqualsWithNullElementsNotEqual() {
-assertFalse(Arrays.equals(new String[2], new String[1]));
- }
-
- public void testArraysEqualsWithNullAndNonNullElementsEqual() {
-assertTrue(Arrays.equals(
-new String[]{ null, foo, null, bar },
-new String[]{ null, foo, null, bar }));
- }
-
- public void testArraysEqualsWithNullAndNonNullElementsNotEqual() {
-assertFalse(Arrays.equals(
-new String[]{ null, bar, null, foo },
-new String[]{ null, foo, null, foo }));
- }
/**
* Tests {...@link Arrays#asList(Object[])}.
@@ -640,7 +606,7 @@
* Advance the permutation to the next value. It leaves the first index
set to
* -1 if the range has been exceeded.
*
- * @param permutation array of indices -- see {...@link #getPermutation} for
+ * @param permutation array of indices -- see {...@link getPermutation} for
* details.
*/
private void nextPermutation(int[] permutation) {
@@ -655,7 +621,7 @@
/**
* Checks to see if this permutation is valid; ie, if all of the indices
are
- * between 0 and n-i (see {...@link #getPermutation} for details).
+ * between 0 and n-i (see {...@link getPermutation} for details).
*
* @param permutations array of indices
* @param n length of source array.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] TypeOracle allTypes including types not in a source path
Filed a bug on this: http://code.google.com/p/google-web-toolkit/issues/detail?id=4268 On 23-Nov-09, at 12:40 PM, Bruce Johnson wrote: let's remember to talk about this more for the release after 2.0 On Mon, Nov 23, 2009 at 2:26 PM, Isaac Truett itru...@gmail.com wrote: +1 deprecate and warn. On Mon, Nov 23, 2009 at 2:24 PM, Ray Ryan rj...@google.com wrote: FWIW, this confusion is exactly why webAppCreator no longer generates projects that use the implicit include. I wonder if we shouldn't flat out deprecate it--in which case a warning would be the right thing. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7127 committed - Fixing an NPE in StackPanel that occurs very rarely in IE....
Revision: 7127
Author: jlaba...@google.com
Date: Mon Nov 23 13:01:27 2009
Log: Fixing an NPE in StackPanel that occurs very rarely in IE.
Patch by: jlabanca
Review by: jat (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=7127
Modified:
/trunk/user/src/com/google/gwt/user/client/ui/StackPanel.java
===
--- /trunk/user/src/com/google/gwt/user/client/ui/StackPanel.java Tue Sep
1 19:11:26 2009
+++ /trunk/user/src/com/google/gwt/user/client/ui/StackPanel.java Mon Nov
23 13:01:27 2009
@@ -264,7 +264,7 @@
}
private int findDividerIndex(Element elem) {
-while (elem != getElement()) {
+while (elem != null elem != getElement()) {
String expando = DOM.getElementProperty(elem, __index);
if (expando != null) {
// Make sure it belongs to me!
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7129 committed - IE, Chrome, Firefox plugins: gracefully disconnect when server connect...
Revision: 7129
Author: sco...@google.com
Date: Mon Nov 23 13:18:40 2009
Log: IE, Chrome, Firefox plugins: gracefully disconnect when server
connection drops.
1) Plugins fails gracefully in the face of a disconnect, returning
undefined instead of making lots of noise.
2) Plugins invokes hosted.html's __gwt_disconnected() method the first time
the session is detected as dropped. This glasspanels the app.
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7129
Modified:
/trunk/plugins/common/HostChannel.cpp
/trunk/plugins/common/HostChannel.h
/trunk/plugins/common/SessionHandler.h
/trunk/plugins/ie/oophm/oophm/IESessionHandler.cpp
/trunk/plugins/ie/oophm/oophm/IESessionHandler.h
/trunk/plugins/ie/oophm/oophm/JavaObject.cpp
/trunk/plugins/npapi/LocalObjectTable.h
/trunk/plugins/npapi/ScriptableInstance.cpp
/trunk/plugins/npapi/ScriptableInstance.h
/trunk/plugins/xpcom/FFSessionHandler.cpp
/trunk/plugins/xpcom/FFSessionHandler.h
/trunk/plugins/xpcom/JavaObject.cpp
===
--- /trunk/plugins/common/HostChannel.cpp Thu Sep 3 15:22:56 2009
+++ /trunk/plugins/common/HostChannel.cpp Mon Nov 23 13:18:40 2009
@@ -68,6 +68,7 @@
bool HostChannel::init(SessionHandler* handler, int minProtoVers,
int maxProtoVers, const std::string hostedHtmlVers) {
+ this-handler = handler;
Debug::log(Debug::Debugging)
negotiating versions - we support protocol minProtoVers
through maxProtoVers , hostedHtmlVersion=
hostedHtmlVers
===
--- /trunk/plugins/common/HostChannel.h Thu Sep 3 15:22:56 2009
+++ /trunk/plugins/common/HostChannel.h Mon Nov 23 13:18:40 2009
@@ -33,6 +33,7 @@
class HostChannel {
Socket sock;
static ByteOrder byteOrder;
+ SessionHandler* handler;
public:
~HostChannel() {
@@ -95,10 +96,12 @@
bool readByte(char data) {
if (!isConnected()) {
+ handler-disconnectDetected();
return false;
}
int c = sock.readByte();
if (c 0) {
+ handler-disconnectDetected();
return false;
}
data = static_castchar(c);
@@ -107,9 +110,14 @@
bool sendByte(const char data) {
if (!isConnected()) {
+ handler-disconnectDetected();
return false;
}
-return sock.writeByte(data);
+if (!sock.writeByte(data)) {
+ handler-disconnectDetected();
+ return false;
+}
+return true;
}
bool readStringLength(uint32_t data);
@@ -133,7 +141,15 @@
}
bool flush() {
-return sock.flush();
+if (!sock.isConnected()) {
+ handler-disconnectDetected();
+ return false;
+}
+if (!sock.flush()) {
+ handler-disconnectDetected();
+ return false;
+}
+return true;
}
ReturnMessage* reactToMessagesWhileWaitingForReturn(SessionHandler*
handler) {
===
--- /trunk/plugins/common/SessionHandler.h Sat Aug 22 16:59:24 2009
+++ /trunk/plugins/common/SessionHandler.h Mon Nov 23 13:18:40 2009
@@ -49,6 +49,24 @@
SetProperty = SPECIAL_SET_PROPERTY
};
protected:
+ SessionHandler(): alreadyDisconnected(false) {
+ }
+
+ /**
+ * Called by the server socket when it cannot read, write, or flush.
+ */
+ void disconnectDetected() {
+if (!alreadyDisconnected) {
+ alreadyDisconnected = true;
+ disconnectDetectedImpl();
+}
+ }
+
+ /**
+ * Implementors should invoke __gwt_disconnected() in the hosted.html
window
+ * to glass the screen with a disconnect message.
+ */
+ virtual void disconnectDetectedImpl() = 0;
/**
* Report a fatal error -- the channel will be closed after this method
@@ -84,6 +102,9 @@
virtual void sendFreeValues(HostChannel channel) = 0;
virtual ~SessionHandler() {}
+
+private:
+ bool alreadyDisconnected;
};
#endif
===
--- /trunk/plugins/ie/oophm/oophm/IESessionHandler.cpp Tue Nov 17 12:12:15
2009
+++ /trunk/plugins/ie/oophm/oophm/IESessionHandler.cpp Mon Nov 23 13:18:40
2009
@@ -44,6 +44,22 @@
channel-disconnectFromHost();
}
+
+void IESessionHandler::disconnectDetectedImpl() {
+ DISPID dispId;
+ LPOLESTR gwtDisconnectedName = L__gwt_disconnected;
+ if (!SUCCEEDED(getWindow()-GetIDsOfNames(IID_NULL,
gwtDisconnectedName, 1,
+LOCALE_SYSTEM_DEFAULT, dispId))) {
+ Debug::log(Debug::Error) Unable to get dispId for
__gwt_disconnected Debug::flush;
+ return;
+ }
+
+ DISPPARAMS dispParams = {NULL, NULL, 0, 0};
+ CComPtrIDispatchEx dispEx;
+ getWindow()-QueryInterface(dispEx);
+ dispEx-InvokeEx(dispId, LOCALE_SYSTEM_DEFAULT, DISPATCH_METHOD,
+dispParams, NULL, NULL, NULL);
+}
void IESessionHandler::fatalError(HostChannel channel,
const std::string message) {
===
--- /trunk/plugins/ie/oophm/oophm/IESessionHandler.hThu Sep 3 15:22:56
2009
+++
[gwt-contrib] [google-web-toolkit] r7130 committed - Merged tr...@7122 into this branch...
Revision: 7130
Author: r...@google.com
Date: Mon Nov 23 13:19:22 2009
Log: Merged tr...@7122 into this branch
Replace JUnit's -web command-line flag with -prod (keeping -web as a
deprecated synonym)
svn merge --ignore-ancestry -c 7122
http://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=7130
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/build.xml
/releases/2.0/user/src/com/google/gwt/junit/JUnitShell.java
/releases/2.0/user/src/com/google/gwt/user/tools/JUnit-prod.launchsrc
/releases/2.0/user/src/com/google/gwt/user/tools/project.ant.xmlsrc
===
--- /releases/2.0/branch-info.txt Mon Nov 23 12:44:09 2009
+++ /releases/2.0/branch-info.txt Mon Nov 23 13:19:22 2009
@@ -988,3 +988,7 @@
https://google-web-toolkit.googlecode.com/svn/trunk/ .
svn merge --ignore-ancestry -c7125 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
+
+tr...@7122 was merged into this branch
+ Replace JUnit's -web command-line flag with -prod (keeping -web as a
deprecated synonym)
+ svn merge --ignore-ancestry -c 7122
http://google-web-toolkit.googlecode.com/svn/trunk .
===
--- /releases/2.0/user/build.xmlMon Nov 23 10:40:40 2009
+++ /releases/2.0/user/build.xmlMon Nov 23 13:19:22 2009
@@ -158,7 +158,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.web.remote
-test.args=${test.web.remote.args} -out www -web -runStyle
RemoteWeb:${gwt.hosts.web.remote} -batch module
+test.args=${test.web.remote.args} -out www -prod -runStyle
RemoteWeb:${gwt.hosts.web.remote} -batch module
test.out=${junit.out}/web-remote
test.cases=test.web.remote.tests
extraclasspaths
@@ -239,7 +239,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.draft.remote
-test.args=${test.draft.remote.args} -draftCompile -web -out www
-runStyle RemoteWeb:${gwt.hosts.web.remote} -batch module
+test.args=${test.draft.remote.args} -draftCompile -prod -out www
-runStyle RemoteWeb:${gwt.hosts.web.remote} -batch module
test.out=${junit.out}/draft-remote
test.cases=test.draft.remote.tests
extraclasspaths
@@ -258,7 +258,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.nometa.remote
-test.args=${test.nometa.remote.args} -XdisableClassMetadata -web
-out www -runStyle RemoteWeb:${gwt.hosts.web.remote} -batch module
+test.args=${test.nometa.remote.args} -XdisableClassMetadata -prod
-out www -runStyle RemoteWeb:${gwt.hosts.web.remote} -batch module
test.out=${junit.out}/nometa-remote
test.cases=test.nometa.remote.tests
extraclasspaths
@@ -282,7 +282,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.web.selenium
-test.args='${test.web.selenium.args} -web -out www
-runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
+test.args='${test.web.selenium.args} -prod -out www
-runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
test.out=${junit.out}/web-selenium
test.cases=test.web.selenium.tests
extraclasspaths
@@ -322,7 +322,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.nometa.selenium
-test.args='${test.nometa.selenium.args} -XdisableClassMetadata
-web -out www -runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
+test.args='${test.nometa.selenium.args} -XdisableClassMetadata
-prod -out www -runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
test.out=${junit.out}/nometa-selenium
test.cases=test.nometa.selenium.tests
extraclasspaths
@@ -342,7 +342,7 @@
includes=${gwt.junit.testcase.web.includes}
excludes=${gwt.junit.testcase.web.excludes} /
gwt.junit test.name=test.draft.selenium
-test.args='${test.draft.selenium.args} -draftCompile -web -out www
-runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
+test.args='${test.draft.selenium.args} -draftCompile -prod -out
www -runStyle Selenium:${gwt.hosts.web.selenium} -batch module'
test.out=${junit.out}/draft-selenium
test.cases=test.draft.selenium.tests
extraclasspaths
@@ -400,7 +400,7 @@
includes=${gwt.junit.testcase.noserver.includes}
excludes=${gwt.junit.testcase.noserver.excludes} /
gwt.junit test.name=test.noserver
-test.args=${test.args} -web -noserver
+
[gwt-contrib] Re: Fix PrefixTree implementation on Chrome
LGTM, thanks http://gwt-code-reviews.appspot.com/111804 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7131 committed - Merged tr...@7121 into this branch...
Revision: 7131
Author: r...@google.com
Date: Mon Nov 23 13:20:43 2009
Log: Merged tr...@7121 into this branch
Remove obsolete documentation.
svn merge --ignore-ancestry -c 7121
http://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=7131
Deleted:
/releases/2.0/doc/src/com/google/gwt/doc/DeveloperGuide.java
Modified:
/releases/2.0/branch-info.txt
===
--- /releases/2.0/doc/src/com/google/gwt/doc/DeveloperGuide.javaMon May
18
11:47:32 2009
+++ /dev/null
@@ -1,3498 +0,0 @@
-/*
- * Copyright 2007 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the License); you may
not
- * use this file except in compliance with the License. You may obtain a
copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations
under
- * the License.
- */
-package com.google.gwt.doc;
-
-import com.google.gwt.core.client.GWT;
-import com.google.gwt.core.client.JavaScriptException;
-import com.google.gwt.core.client.JavaScriptObject;
-import com.google.gwt.junit.client.GWTTestCase;
-import com.google.gwt.user.client.rpc.AsyncCallback;
-import com.google.gwt.user.client.rpc.IsSerializable;
-import com.google.gwt.user.client.rpc.RemoteService;
-import com.google.gwt.user.client.rpc.ServiceDefTarget;
-import com.google.gwt.user.client.ui.AbstractImagePrototype;
-import com.google.gwt.user.client.ui.Button;
-import com.google.gwt.user.client.ui.CellPanel;
-import com.google.gwt.user.client.ui.ClickListener;
-import com.google.gwt.user.client.ui.Composite;
-import com.google.gwt.user.client.ui.FlowPanel;
-import com.google.gwt.user.client.ui.HorizontalPanel;
-import com.google.gwt.user.client.ui.Image;
-import com.google.gwt.user.client.ui.ImageBundle;
-import com.google.gwt.user.client.ui.KeyboardListenerAdapter;
-import com.google.gwt.user.client.ui.RootPanel;
-import com.google.gwt.user.client.ui.TextBox;
-import com.google.gwt.user.client.ui.Widget;
-import com.google.gwt.user.server.rpc.RemoteServiceServlet;
-import com.google.gwt.i18n.client.Localizable;
-
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-
-/**
- * The GWT Developer Guide contains a variety of topics that explain the
various
- * moving parts of the toolkit.
- *
- * @title Developer Guide
- * @index Developer Guide
- * @index Google Web Toolkit, developer guide
- * @index GWT, developer's guide
- * @childIntro Topic Guide
- * @tip For a list of JRE classes that GWT can translate out of the box,
see the
- * a href=jre.htmldocumentation for the GWT JRE emulation
library/a.
- */
-public class DeveloperGuide {
-
- static class BogusImports {
-RootPanel rp;
-CellPanel cp;
-GWTTestCase gtc;
-JavaScriptObject jso;
-JavaScriptException jse;
-Image img;
- }
-
- /**
- * @title Fundamentals
- *
- * @synopsis Core GWT concepts such as
- * {...@link Fundamentals.JavaToJavaScriptCompiler compiling Java
source into JavaScript},
- * {...@link Fundamentals.HostedMode debugging},
- * {...@link Fundamentals.CrossBrowserSupport cross-browser
support},
- * and {...@link Fundamentals.Modules defining modules}.
- * @childIntro
- */
- public static class Fundamentals {
-
-/**
- * The heart of GWT is a compiler that converts Java source into
JavaScript,
- * transforming your working Java application into an equivalent
JavaScript
- * application. Generally speaking,
- * ol
- * liIf your GWT application compiles and runs in
- * {...@link DeveloperGuide.Fundamentals.HostedMode hosted mode} as you
expect/li
- * liAnd GWT compiles your application into JavaScript output without
- * complaint,/li
- * liThen your application will work the same way in a web browser
as it
- * did in hosted mode./li
- * /ol
- * The GWT compiler supports the vast majority of the Java language
itself.
- * The GWT runtime library emulates a relevant subset of the Java
runtime
- * library.
- *
- * @title GWT Compiler
- * @synopsis A compiler that transforms your working Java application
into
- * an equivalent JavaScript application.
- * @childIntro Specifics
- */
-public static class JavaToJavaScriptCompiler {
-
- /**
- * GWT compiles Java source that is compatible with J2SE 1.4.2 or
earlier.
- *
- * ul class=featurelist
- *
- * lidiv class=headingIntrinsic types/div
- *
- * divcodebyte/code, codechar/code, codeshort/code,
- * codeint/code, codelong/code, codefloat/code,
- *
[gwt-contrib] [google-web-toolkit] r7133 committed - Merge tr...@7132 into this branch...
Revision: 7133
Author: r...@google.com
Date: Mon Nov 23 13:35:16 2009
Log: Merge tr...@7132 into this branch
Fix PrefixTree implementation on Chrome
svn merge --ignore-ancestry -c 7132
http://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=7133
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/src/com/google/gwt/user/client/ui/PrefixTree.java
===
--- /releases/2.0/branch-info.txt Mon Nov 23 13:20:43 2009
+++ /releases/2.0/branch-info.txt Mon Nov 23 13:35:16 2009
@@ -996,3 +996,7 @@
tr...@7122 was merged into this branch
Replace JUnit's -web command-line flag with -prod (keeping -web as a
deprecated synonym)
svn merge --ignore-ancestry -c 7122
http://google-web-toolkit.googlecode.com/svn/trunk .
+
+tr...@7132 was merged into this branch
+ Fix PrefixTree implementation on Chrome
+ svn merge --ignore-ancestry -c 7132
http://google-web-toolkit.googlecode.com/svn/trunk .
===
--- /releases/2.0/user/src/com/google/gwt/user/client/ui/PrefixTree.java
Wed Nov 4 06:59:39 2009
+++ /releases/2.0/user/src/com/google/gwt/user/client/ui/PrefixTree.java
Mon Nov 23 13:35:16 2009
@@ -102,7 +102,10 @@
private native void addTree(PrefixTree tree, String prefix) /*-{
var suffixes = [];
for (var suffix in
tr...@com.google.gwt.user.client.ui.prefixtree::suffixes) {
-suffixes.push(suffix);
+// Ignore object properties that aren't colon-prepended keys
+if (suffix.indexOf(':') == 0) {
+ suffixes.push(suffix);
+}
}
var frame = {
@@ -154,6 +157,9 @@
// Otherwise, put all of the subtrees on the stack.
} else {
for (key in frame.subtrees) {
+ if (key.indexOf(':') != 0) {
+continue;
+ }
var target = frame.prefix + unsafe(key);
var subtree = frame.subtrees[key];
th...@com.google.gwt.user.client.ui.prefixtree$prefixtreeiterator::addTree(Lcom/google/gwt/user/client/ui/PrefixTree;Ljava/lang/String;)(subtree,
target);
@@ -165,6 +171,9 @@
// Put all subframes on the stack, and return to top of loop.
} else {
for (var key in frame.subtrees) {
+ if (key.indexOf(':') != 0) {
+ continue;
+ }
var target = frame.prefix + unsafe(key);
var subtree = frame.subtrees[key];
@@ -416,6 +425,9 @@
} else {
// Check local suffixes.
for (var suffix in suffixes) {
+ if (suffix.indexOf(':') != 0) {
+ continue;
+ }
var target = prefix +
@com.google.gwt.user.client.ui.PrefixTree::unsafe(Ljava/lang/String;)(suffix);
if (target.indexOf(search) == 0) {
outp...@java.util.collection::add(Ljava/lang/Object;)(target);
@@ -429,6 +441,9 @@
// Check the subtree keys. If the key matches, that implies that all
// elements of the subtree would match.
for (var key in subtrees) {
+ if (key.indexOf(':') != 0) {
+ continue;
+ }
var target = prefix +
@com.google.gwt.user.client.ui.PrefixTree::unsafe(Ljava/lang/String;)(key);
var subtree = subtrees[key];
@@ -446,12 +461,16 @@
// Always fully-specify suffixes.
for (var suffix in
subtr...@com.google.gwt.user.client.ui.prefixtree::suffixes) {
- outp...@java.util.collection::add(Ljava/lang/Object;)(target
+
@com.google.gwt.user.client.ui.PrefixTree::unsafe(Ljava/lang/String;)(suffix));
+ if (suffix.indexOf(':') == 0) {
+
outp...@java.util.collection::add(Ljava/lang/Object;)(target +
@com.google.gwt.user.client.ui.PrefixTree::unsafe(Ljava/lang/String;)(suffix));
+ }
}
// Give the keys of the subtree.
for (var subkey in
subtr...@com.google.gwt.user.client.ui.prefixtree::subtrees) {
- outp...@java.util.collection::add(Ljava/lang/Object;)(target
+
@com.google.gwt.user.client.ui.PrefixTree::unsafe(Ljava/lang/String;)(subkey)
+ ...);
+ if (subkey.indexOf(':') == 0) {
+
outp...@java.util.collection::add(Ljava/lang/Object;)(target +
@com.google.gwt.user.client.ui.PrefixTree::unsafe(Ljava/lang/String;)(subkey)
+ ...);
+ }
}
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7134 committed - A variety of build and cosmetic updates to the Safari plugin....
Revision: 7134
Author: b...@google.com
Date: Mon Nov 23 13:36:18 2009
Log: A variety of build and cosmetic updates to the Safari plugin.
Patch by: bobv
Review by: scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=7134
Deleted:
/trunk/plugins/webkit/oophm.pmdoc/01oophm-contents.xml
/trunk/plugins/webkit/oophm.pmdoc/01oophm.xml
/trunk/plugins/webkit/oophm.pmdoc/index.xml
Modified:
/trunk/plugins/webkit/Info.plist
/trunk/plugins/webkit/Plugin/English.lproj/crash.html
/trunk/plugins/webkit/Plugin/OophmPlugin.mm
/trunk/plugins/webkit/Plugin/OophmWebScriptObject.h
/trunk/plugins/webkit/Plugin/OophmWebScriptObject.mm
/trunk/plugins/webkit/gwtlogo.icns
/trunk/plugins/webkit/oophm.xcodeproj/project.pbxproj
===
--- /trunk/plugins/webkit/oophm.pmdoc/01oophm-contents.xml Thu Sep 3
15:22:56 2009
+++ /dev/null
@@ -1,1 +0,0 @@
-pkg-contents spec=1.12f n=oophm.webplugin o=root g=admin
p=16893
pt=/Users/jat/s/gwt-trunk/plugins/webkit/build/Release/oophm.webplugin
m=true t=filef n=Contents o=root g=admin p=16893f
n=Info.plist o=root g=admin p=33204modmode/mod/ff n=MacOS
o=root g=admin p=16893f n=oophm o=root g=admin
p=33277modmode/mod/fmodmode/mod/ff n=Resources o=root
g=admin p=16893f n=English.lproj o=root g=admin p=16893f
n=crash.html o=root g=admin p=33204modmode/mod/ff
n=InfoPlist.strings o=root g=admin
p=33204modmode/mod/fmodmode/mod/ff n=gwtlogo.icns
o=root g=admin p=33204modmode/mod/ff n=README.google
o=root g=admin
p=33204modmode/mod/fmodmode/mod/fmodmode/mod/fmodmode/mod/f/pkg-contents
===
--- /trunk/plugins/webkit/oophm.pmdoc/01oophm.xml Thu Sep 3 15:22:56 2009
+++ /dev/null
@@ -1,1 +0,0 @@
-pkgref spec=1.12
uuid=417BF300-1147-478E-9359-100836B507EEconfigidentifiercom.google.gwt.oophm.pkg/identifierversion1/versiondescription/descriptionpost-install
type=none/requireAuthorization/installFrom relative=true mod=true
includeRoot=truebuild/Release/oophm.webplugin/installFrominstallTo
mod=true/Library/Internet
Plug-Ins/installToflagsfollowSymbolicLinks/modoverwriteDirectoryPermissions/mod/flagspackageStore
type=internal/packageStoremodparent/modmodinstallTo/modmodrequireAuthorization/modmodinstallFrom.isRelativeType/modmodinstallTo.path/modmodinstallFrom.path/modmodidentifier/modmodincludeRoot/mod/configcontentsfile-list01oophm-contents.xml/file-listcomponent
id=com.google.gwt.oophm
path=/Users/jat/s/gwt-trunk/plugins/webkit/build/Release/oophm.webplugin
version=0.1/filter/CVS$/filterfilter/\.svn$/filterfilter/\.cvsignore$/filterfilter/\.cvspass$/filterfilter/\.DS_Store$/filter/contents/pkgref
===
--- /trunk/plugins/webkit/oophm.pmdoc/index.xml Thu Sep 3 15:22:56 2009
+++ /dev/null
@@ -1,15 +0,0 @@
-pkmkdoc spec=1.12propertiestitleGWT Out-of-Process Hosted Mode
Plugins/titlebuild/Users/jat/Desktop/GWT Out-of-Process Hosted Mode
Plugin.mpkg/buildorganizationcom.google.gwt/organizationuserSees
ui=custom/min-target os=2/domain
system=true//propertiesdistributionversions
min-spec=1.00/scripts/scripts/distributioncontentschoice
title=WebKit Plugin id=webkit description=This plugin support
WebKit-based browsers, such as Safari and Shiira. Any other application
that makes use of WebKit will also be able to load this plugin.
starts_selected=true starts_enabled=true starts_hidden=falsepkgref
id=com.google.gwt.oophm.pkg//choice/contentsresources
bg-scale=none bg-align=bottomleftlocale lang=enresource
relative=true mod=true
type=backgroundgwtlogo.icns/resourceresource relative=true
mod=true
type=license../../distro-source/core/src/COPYING.html/resourceresource
relative=true mod=true
type=readme../../distro-source/core/src/index.html/resourceresource
mime-type=text/rtf kind=embedded
type=welcome![CDATA[{\rtf1\ansi\ansicpg1252\cocoartf949\cocoasubrtf270
-{\fonttbl\f0\fnil\fcharset0 LucidaGrande;}
-{\colortbl;\red255\green255\blue255;}
-\pard\tx560\tx1120\tx1680\tx2240\tx2800\tx3360\tx3920\tx4480\tx5040\tx5600\tx6160\tx6720\ql\qnatural\pardirnatural
-
-\f0\fs26 \cf0 This package contains browser plugins that allow the Google
Web Toolkit hosted-mode system to interact with various browsers installed
on your computer.\
-\
-These plugins
-\b are not required
-\b0 to view web pages with GWT modules; they are only necessary if you
are writing GWT applications and wish to debug
them.}]]/resourceresource mime-type=text/rtf kind=embedded
type=conclusion![CDATA[{\rtf1\ansi\ansicpg1252\cocoartf949\cocoasubrtf270
-{\fonttbl\f0\fnil\fcharset0 LucidaGrande;}
-{\colortbl;\red255\green255\blue255;}
-\pard\tx560\tx1120\tx1680\tx2240\tx2800\tx3360\tx3920\tx4480\tx5040\tx5600\tx6160\tx6720\ql\qnatural\pardirnatural
-
-\f0\fs26 \cf0 Restart any WebKit-based browsers in order to use the
plugin.}]]/resource/locale/resourcesflags/item
[gwt-contrib] [google-web-toolkit] r7135 committed - Add support for disconnection glass panel in Safari plugin....
Revision: 7135
Author: b...@google.com
Date: Mon Nov 23 13:36:41 2009
Log: Add support for disconnection glass panel in Safari plugin.
Patch by: bobv
Review by: scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=7135
Modified:
/trunk/plugins/webkit/Core/WebScriptSessionHandler.cpp
/trunk/plugins/webkit/Core/WebScriptSessionHandler.h
/trunk/plugins/webkit/Plugin/OophmWebScriptObject.mm
===
--- /trunk/plugins/webkit/Core/WebScriptSessionHandler.cpp Thu Sep 3
15:22:56 2009
+++ /trunk/plugins/webkit/Core/WebScriptSessionHandler.cpp Mon Nov 23
13:36:41 2009
@@ -90,6 +90,10 @@
JSGarbageCollect(contextRef);
pthread_mutex_destroy(javaObjectsLock);
}
+
+void WebScriptSessionHandler::disconnectDetectedImpl() {
+ crashHandler-crash(__PRETTY_FUNCTION__, Server disconnect detected);
+}
void WebScriptSessionHandler::fatalError(HostChannel channel,
const std::string message) {
@@ -269,48 +273,53 @@
*/
Debug::log(Debug::Debugging) Java method dispatchId
invoked Debug::flush;
- /*
- * If a JS function is evaluated without an meaningful this object or
the global
- * object is implicitly used as the this object, we'll assume that the
- * Java-derived method is static, and send a null this object to the
server
- */
- Value thisValue;
- if (JSValueIsEqual(contextRef, thisObject,
JSContextGetGlobalObject(contextRef), NULL)) {
-thisValue = Value();
-thisValue.setNull();
+ JSValueRef toReturn;
+ if (crashHandler-hasCrashed()) {
+Debug::log(Debug::Debugging) Not executing method since we have
crashed Debug::flush;
+toReturn = JSValueMakeUndefined(contextRef);
} else {
-makeValue(thisValue, thisObject);
- }
-
- // Argument conversion is straightforward
- Value args[argumentCount];
- for (int i = 0; i argumentCount; i++) {
-makeValue(args[i], arguments[i]);
- }
-
- if (!InvokeMessage::send(*channel, thisValue, dispatchId,
- argumentCount, args)) {
-initiateAutodestructSequence(__PRETTY_FUNCTION__, Unable to send
invocation message);
-*exception = makeException(Unable to send invocation message);
-return JSValueMakeUndefined(contextRef);
- }
-
- scoped_ptrReturnMessage
ret(channel-reactToMessagesWhileWaitingForReturn(sessionHandler));
-
- if (!ret.get()) {
-initiateAutodestructSequence(__PRETTY_FUNCTION__, Unable to receive
return message);
-*exception = makeException(Unable to receive return message);
-return JSValueMakeUndefined(contextRef);
- }
-
- Value v = ret-getReturnValue();
-
- JSValueRef toReturn;
- if (ret-isException()) {
-*exception = makeValueRef(v);
-toReturn = JSValueMakeUndefined(contextRef);
- } else {
-toReturn = makeValueRef(v);
+/*
+ * If a JS function is evaluated without an meaningful this object or
the global
+ * object is implicitly used as the this object, we'll assume that the
+ * Java-derived method is static, and send a null this object to the
server
+ */
+Value thisValue;
+if (JSValueIsEqual(contextRef, thisObject,
JSContextGetGlobalObject(contextRef), NULL)) {
+ thisValue = Value();
+ thisValue.setNull();
+} else {
+ makeValue(thisValue, thisObject);
+}
+
+// Argument conversion is straightforward
+Value args[argumentCount];
+for (int i = 0; i argumentCount; i++) {
+ makeValue(args[i], arguments[i]);
+}
+
+if (!InvokeMessage::send(*channel, thisValue, dispatchId,
+ argumentCount, args)) {
+ initiateAutodestructSequence(__PRETTY_FUNCTION__, Unable to send
invocation message);
+ *exception = makeException(Unable to send invocation message);
+ return JSValueMakeUndefined(contextRef);
+}
+
+scoped_ptrReturnMessage
ret(channel-reactToMessagesWhileWaitingForReturn(sessionHandler));
+
+if (!ret.get()) {
+ initiateAutodestructSequence(__PRETTY_FUNCTION__, Unable to receive
return message);
+ *exception = makeException(Unable to receive return message);
+ return JSValueMakeUndefined(contextRef);
+}
+
+Value v = ret-getReturnValue();
+
+if (ret-isException()) {
+ *exception = makeValueRef(v);
+ toReturn = JSValueMakeUndefined(contextRef);
+} else {
+ toReturn = makeValueRef(v);
+}
}
JSValueRef makeResultArguments[] = {JSValueMakeBoolean(contextRef,
false), toReturn};
@@ -334,6 +343,11 @@
JSValueRef WebScriptSessionHandler::javaObjectGetPropertyImpl
(TrackingDataRef tracker, JSObjectRef object,
JSStringRef
propertyName, JSValueRef* exception) {
*exception = NULL;
+
+ if (crashHandler-hasCrashed()) {
+Debug::log(Debug::Debugging) Not executing since we have crashed
Debug::flush;
+return JSValueMakeUndefined(contextRef);
+ }
// Convert the name
int maxLength =
[gwt-contrib] [google-web-toolkit] r7136 committed - Plugins: update prebuilt binaries to r7135 (graceful disconnect)....
Revision: 7136 Author: sco...@google.com Date: Mon Nov 23 14:00:51 2009 Log: Plugins: update prebuilt binaries to r7135 (graceful disconnect). Patch by: me, bobv http://code.google.com/p/google-web-toolkit/source/detail?r=7136 Added: /trunk/plugins/webkit/prebuilt/gwt-dev-plugin.dmg Deleted: /trunk/plugins/webkit/prebuilt/oophm.dmg Modified: /trunk/plugins/ie/prebuilt/oophm.dll /trunk/plugins/npapi/prebuilt/gwt-dev-plugin/WINNT_x86-msvc/npGwtDevPlugin.dll /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff3/libgwt_dev_ff3.so /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff3+/libgwt_dev_ff3+.so /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff35/libgwt_dev_ff35.so /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86_64-gcc3/ff3/libgwt_dev_ff3.so /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86_64-gcc3/ff3+/libgwt_dev_ff3+.so /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86_64-gcc3/ff35/libgwt_dev_ff35.so /trunk/plugins/xpcom/prebuilt/extension/lib/WINNT_x86-msvc/ff3/xpGwtDevPlugin.dll /trunk/plugins/xpcom/prebuilt/extension/lib/WINNT_x86-msvc/ff35/xpGwtDevPlugin.dll === --- /dev/null +++ /trunk/plugins/webkit/prebuilt/gwt-dev-plugin.dmg Mon Nov 23 14:00:51 2009 Binary file, no diff available. === --- /trunk/plugins/webkit/prebuilt/oophm.dmgThu Sep 3 15:22:56 2009 +++ /dev/null Binary file, no diff available. === --- /trunk/plugins/ie/prebuilt/oophm.dllWed Sep 30 09:53:45 2009 +++ /trunk/plugins/ie/prebuilt/oophm.dllMon Nov 23 14:00:51 2009 Binary file, no diff available. === --- /trunk/plugins/npapi/prebuilt/gwt-dev-plugin/WINNT_x86-msvc/npGwtDevPlugin.dll Tue Nov 10 16:09:56 2009 +++ /trunk/plugins/npapi/prebuilt/gwt-dev-plugin/WINNT_x86-msvc/npGwtDevPlugin.dll Mon Nov 23 14:00:51 2009 Binary file, no diff available. === --- /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff3/libgwt_dev_ff3.so Tue Nov 10 15:51:47 2009 +++ /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff3/libgwt_dev_ff3.so Mon Nov 23 14:00:51 2009 File is too large to display a diff. === --- /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff3+/libgwt_dev_ff3+.so Tue Nov 10 14:35:28 2009 +++ /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff3+/libgwt_dev_ff3+.so Mon Nov 23 14:00:51 2009 File is too large to display a diff. === --- /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff35/libgwt_dev_ff35.so Tue Nov 10 15:51:47 2009 +++ /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff35/libgwt_dev_ff35.so Mon Nov 23 14:00:51 2009 File is too large to display a diff. === --- /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86_64-gcc3/ff3/libgwt_dev_ff3.so Tue Nov 10 15:51:47 2009 +++ /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86_64-gcc3/ff3/libgwt_dev_ff3.so Mon Nov 23 14:00:51 2009 File is too large to display a diff. === --- /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86_64-gcc3/ff3+/libgwt_dev_ff3+.so Tue Nov 10 14:35:28 2009 +++ /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86_64-gcc3/ff3+/libgwt_dev_ff3+.so Mon Nov 23 14:00:51 2009 File is too large to display a diff. === --- /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86_64-gcc3/ff35/libgwt_dev_ff35.so Tue Nov 10 15:51:47 2009 +++ /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86_64-gcc3/ff35/libgwt_dev_ff35.so Mon Nov 23 14:00:51 2009 File is too large to display a diff. === --- /trunk/plugins/xpcom/prebuilt/extension/lib/WINNT_x86-msvc/ff3/xpGwtDevPlugin.dll Tue Nov 10 14:29:41 2009 +++ /trunk/plugins/xpcom/prebuilt/extension/lib/WINNT_x86-msvc/ff3/xpGwtDevPlugin.dll Mon Nov 23 14:00:51 2009 Binary file, no diff available. === --- /trunk/plugins/xpcom/prebuilt/extension/lib/WINNT_x86-msvc/ff35/xpGwtDevPlugin.dll Tue Nov 10 14:29:41 2009 +++ /trunk/plugins/xpcom/prebuilt/extension/lib/WINNT_x86-msvc/ff35/xpGwtDevPlugin.dll Mon Nov 23 14:00:51 2009 Binary file, no diff available. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7137 committed - Use a css expression for hosted.html's disconnect screen in IE6 standa...
Revision: 7137
Author: sco...@google.com
Date: Mon Nov 23 14:17:52 2009
Log: Use a css expression for hosted.html's disconnect screen in IE6
standards mode.
We can't set a resize handler from the inner frame, and it's a minute
enough case that it's not worth adding in extra plumbing just to wedge the
resize handler in there.
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7137
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
===
--- /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Sat
Nov 21 18:00:26 2009
+++ /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Mon
Nov 23 14:17:52 2009
@@ -148,7 +148,7 @@
function __gwt_disconnected() {
// Prevent double-invocation.
- __gwt_disconnected = new Function();
+ window.__gwt_disconnected = new Function();
// Do it in a timeout so we can be sure we have a clean stack.
window.setTimeout(__gwt_disconnected_impl, 1);
}
@@ -180,21 +180,16 @@
// Steal focus.
glass.focus();
- // Setup resize handler for IE6.
if (navigator.userAgent.indexOf(MSIE 6) = 0) {
+glassStyle.width = 125%; // Get past scroll bar area.
if (topDoc.compatMode == BackCompat) {
+ // Works in quirks mode.
glassStyle.height = 100%;
- var resizeFunc = function () {
-glassStyle.width = topDoc.body.clientWidth + 'px';
- }
} else {
- var resizeFunc = function () {
-glassStyle.width = topDoc.documentElement.clientWidth + 'px';
-glassStyle.height = topDoc.documentElement.clientHeight + 'px';
- }
-}
-topWin.onresize = resizeFunc;
-resizeFunc();
+ // Use a nasty CSS expression in standards mode; ideally we'd use the
+ // onresize event, but the outer window won't let us add one in IE6.
+
glassStyle.setExpression(height, document.documentElement.clientHeight);
+}
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7138 committed - tr...@7137 was merged into this branch...
Revision: 7138
Author: sco...@google.com
Date: Mon Nov 23 14:19:49 2009
Log: tr...@7137 was merged into this branch
Use a css expression for hosted.html's disconnect screen in IE6 standards
mode.
svn merge --ignore-ancestry -c7137
http://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?r=7138
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
===
--- /releases/2.0/branch-info.txt Mon Nov 23 13:35:16 2009
+++ /releases/2.0/branch-info.txt Mon Nov 23 14:19:49 2009
@@ -1000,3 +1000,7 @@
tr...@7132 was merged into this branch
Fix PrefixTree implementation on Chrome
svn merge --ignore-ancestry -c 7132
http://google-web-toolkit.googlecode.com/svn/trunk .
+
+tr...@7137 was merged into this branch
+ Use a css expression for hosted.html's disconnect screen in IE6
standards mode.
+ svn merge --ignore-ancestry -c7137
http://google-web-toolkit.googlecode.com/svn/trunk .
===
---
/releases/2.0/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
Sat Nov 21 18:10:06 2009
+++
/releases/2.0/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
Mon Nov 23 14:19:49 2009
@@ -148,7 +148,7 @@
function __gwt_disconnected() {
// Prevent double-invocation.
- __gwt_disconnected = new Function();
+ window.__gwt_disconnected = new Function();
// Do it in a timeout so we can be sure we have a clean stack.
window.setTimeout(__gwt_disconnected_impl, 1);
}
@@ -180,21 +180,16 @@
// Steal focus.
glass.focus();
- // Setup resize handler for IE6.
if (navigator.userAgent.indexOf(MSIE 6) = 0) {
+glassStyle.width = 125%; // Get past scroll bar area.
if (topDoc.compatMode == BackCompat) {
+ // Works in quirks mode.
glassStyle.height = 100%;
- var resizeFunc = function () {
-glassStyle.width = topDoc.body.clientWidth + 'px';
- }
} else {
- var resizeFunc = function () {
-glassStyle.width = topDoc.documentElement.clientWidth + 'px';
-glassStyle.height = topDoc.documentElement.clientHeight + 'px';
- }
-}
-topWin.onresize = resizeFunc;
-resizeFunc();
+ // Use a nasty CSS expression in standards mode; ideally we'd use the
+ // onresize event, but the outer window won't let us add one in IE6.
+
glassStyle.setExpression(height, document.documentElement.clientHeight);
+}
}
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] RR: UiBinder javadoc, including UiObject, CellPanel
Reviewers: jlabanca, Message: John, can you take point on this? And, everybody, this is how I'm planning to document UiBinder's custom parsing. There will be similar changes for the layout panels, CustomButton, MenuBar, DisclosurePanel, DialogBox, and perhaps others. Are we good with the general direction? Please review this at http://gwt-code-reviews.appspot.com/111805 Affected files: M user/src/com/google/gwt/uibinder/client/UiBinder.java M user/src/com/google/gwt/uibinder/elementparsers/AttributeMessageParser.java M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java M user/src/com/google/gwt/user/client/ui/CellPanel.java M user/src/com/google/gwt/user/client/ui/UIObject.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Remove TODOs from hosted.html
LGTM http://gwt-code-reviews.appspot.com/112806 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7139 committed - Disconnected plugin glasspanel lightened to 75% opacity....
Revision: 7139 Author: sco...@google.com Date: Mon Nov 23 14:39:18 2009 Log: Disconnected plugin glasspanel lightened to 75% opacity. Review by: bruce, abowers http://code.google.com/p/google-web-toolkit/source/detail?r=7139 Modified: /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html === --- /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Mon Nov 23 14:17:52 2009 +++ /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Mon Nov 23 14:39:18 2009 @@ -159,7 +159,7 @@ var outer = topDoc.createElement(div); // Do not insert whitespace or outer.firstChild will get a text node. outer.innerHTML = -'div style=position:absolute;z-index:2147483646;left:0px;top:0px;right:0px;bottom:0px;filter:alpha(opacity=80);opacity:0.80;background-color:#00;/div' + +'div style=position:absolute;z-index:2147483646;left:0px;top:0px;right:0px;bottom:0px;filter:alpha(opacity=75);opacity:0.75;background-color:#00;/div' + 'div style=position:absolute;z-index:2147483647;left:50px;top:50px;width:600px;color:#FF;font-family:verdana;' + 'div style=font-size:30px;font-weight:bold;GWT Code Server Disconnected/div' + 'p style=font-size:15px; Most likely, you closed GWT development mode. Or you might have lost network connectivity. To fix this, try restarting GWT Development Mode and a style=color: #FF; font-weight: bold; href=javascript:location.reload()REFRESH/a this page./p' + -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7140 committed - tr...@7139 was merged into this branch...
Revision: 7140 Author: sco...@google.com Date: Mon Nov 23 14:42:20 2009 Log: tr...@7139 was merged into this branch Disconnected plugin glasspanel lightened to 75% opacity. svn merge --ignore-ancestry -c7139 https://google-web-toolkit.googlecode.com/svn/trunk . http://code.google.com/p/google-web-toolkit/source/detail?r=7140 Modified: /releases/2.0/branch-info.txt /releases/2.0/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html === --- /releases/2.0/branch-info.txt Mon Nov 23 14:19:49 2009 +++ /releases/2.0/branch-info.txt Mon Nov 23 14:42:20 2009 @@ -976,11 +976,11 @@ tr...@7112 was merged into this branch Improves error handling when there is a failure to connect to the remote UI. - svn merge --ignore-ancestry -c 7112 http://google-web-toolkit.googlecode.com/svn/trunk . + svn merge --ignore-ancestry -c 7112 https://google-web-toolkit.googlecode.com/svn/trunk . tr...@7117 was merged into this branch Allows spaces in test targets in user/build.xml. - svn merge --ignore-ancestry -c 7117 http://google-web-toolkit.googlecode.com/svn/trunk . + svn merge --ignore-ancestry -c 7117 https://google-web-toolkit.googlecode.com/svn/trunk . tr...@7119 was merged into this branch, then its reversion in r7125 Fix Arrays.equals(Object[], Object[]) for nulls. @@ -991,16 +991,20 @@ tr...@7121 was merged into this branch Remove obsolete documentation. - svn merge --ignore-ancestry -c 7121 http://google-web-toolkit.googlecode.com/svn/trunk . + svn merge --ignore-ancestry -c 7121 https://google-web-toolkit.googlecode.com/svn/trunk . tr...@7122 was merged into this branch Replace JUnit's -web command-line flag with -prod (keeping -web as a deprecated synonym) - svn merge --ignore-ancestry -c 7122 http://google-web-toolkit.googlecode.com/svn/trunk . + svn merge --ignore-ancestry -c 7122 https://google-web-toolkit.googlecode.com/svn/trunk . tr...@7132 was merged into this branch Fix PrefixTree implementation on Chrome - svn merge --ignore-ancestry -c 7132 http://google-web-toolkit.googlecode.com/svn/trunk . + svn merge --ignore-ancestry -c 7132 https://google-web-toolkit.googlecode.com/svn/trunk . tr...@7137 was merged into this branch Use a css expression for hosted.html's disconnect screen in IE6 standards mode. - svn merge --ignore-ancestry -c7137 http://google-web-toolkit.googlecode.com/svn/trunk . + svn merge --ignore-ancestry -c7137 https://google-web-toolkit.googlecode.com/svn/trunk . + +tr...@7139 was merged into this branch + Disconnected plugin glasspanel lightened to 75% opacity. + svn merge --ignore-ancestry -c7139 https://google-web-toolkit.googlecode.com/svn/trunk . === --- /releases/2.0/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Mon Nov 23 14:19:49 2009 +++ /releases/2.0/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Mon Nov 23 14:42:20 2009 @@ -159,7 +159,7 @@ var outer = topDoc.createElement(div); // Do not insert whitespace or outer.firstChild will get a text node. outer.innerHTML = -'div style=position:absolute;z-index:2147483646;left:0px;top:0px;right:0px;bottom:0px;filter:alpha(opacity=80);opacity:0.80;background-color:#00;/div' + +'div style=position:absolute;z-index:2147483646;left:0px;top:0px;right:0px;bottom:0px;filter:alpha(opacity=75);opacity:0.75;background-color:#00;/div' + 'div style=position:absolute;z-index:2147483647;left:50px;top:50px;width:600px;color:#FF;font-family:verdana;' + 'div style=font-size:30px;font-weight:bold;GWT Code Server Disconnected/div' + 'p style=font-size:15px; Most likely, you closed GWT development mode. Or you might have lost network connectivity. To fix this, try restarting GWT Development Mode and a style=color: #FF; font-weight: bold; href=javascript:location.reload()REFRESH/a this page./p' + -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7141 committed - Remove TODOs from hosted.html, captured in issues instead....
Revision: 7141
Author: j...@google.com
Date: Mon Nov 23 15:04:10 2009
Log: Remove TODOs from hosted.html, captured in issues instead.
Patch by: jat
Review by: bruce
http://code.google.com/p/google-web-toolkit/source/detail?r=7141
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
===
--- /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Mon
Nov 23 14:39:18 2009
+++ /trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html Mon
Nov 23 15:04:10 2009
@@ -1,7 +1,5 @@
html
headscript
-// TODO(jat): wrap these to reduce namespace issues, and refactor code into
-//separate functions.
var $wnd = parent;
var $doc = $wnd.document;
var $moduleName, $moduleBase, $entry
@@ -51,7 +49,6 @@
var ua = navigator.userAgent.toLowerCase();
if (ua.indexOf(gecko) != -1) {
// install eval wrapper on FF to avoid EvalError problem
- // TODO(jat): should this UA check be more specific (this hits chrome
too)?
var __eval = window.eval;
window.eval = function(s) {
return __eval(s);
@@ -221,21 +218,7 @@
$moduleName = modName;
$moduleBase = modBase;
- /*
- * NOTE: this presently sucks and is the only formulation I can find
that will
- * work across browsers. On a Windows box where both plugins are
registered,
- * FF will instantiate the (non-working) IE plugin. But plugins have
problems
- * that prevent making this easy.
- *
- * The IE plugin will throw an exception in FF if you try to resolve
- * pluginObject.connect as a value. Thus the try/catch below.
- *
- * The FF plugin will actually do illegal crashy things in IE if you try
to
- * resolve pluginEmbed.connect as a value. Thus we have to try the IE
- * plugin first.
- *
- * Both plugins need some work to make them truly safe.
- */
+ // Note that the order is important
var pluginFinders = [
findPluginXPCOM,
findPluginObject,
@@ -299,8 +282,6 @@
}
window.onunload = function() {
- // TODO: do we need to do anything here or just rely on the plugins
- // unload call?
};
// Lightweight metrics
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Extend tiemout of ImageResourceTest#testDedup
Reviewers: fabbott,
Description:
ImageResourceTest#testDedup sometimes fails because the timeout is only
1 second.
Fix:
Increased timeout to 10s, in line with other tests.
Please review this at http://gwt-code-reviews.appspot.com/112807
Affected files:
user/test/com/google/gwt/resources/client/ImageResourceTest.java
Index: user/test/com/google/gwt/resources/client/ImageResourceTest.java
===
--- user/test/com/google/gwt/resources/client/ImageResourceTest.java
(revision 7140)
+++ user/test/com/google/gwt/resources/client/ImageResourceTest.java
(working copy)
@@ -107,7 +107,7 @@
assertEquals(a.getLeft(), b.getTop());
assertEquals(a.getLeft(), c.getTop());
-delayTestFinish(1000);
+delayTestFinish(1);
// See if the size of the image strip is what we expect
Image i = new Image(a.getURL());
i.addLoadHandler(new LoadHandler() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7142 committed - Merge trunk r7141 into this branch...
Revision: 7142
Author: j...@google.com
Date: Mon Nov 23 15:06:45 2009
Log: Merge trunk r7141 into this branch
Remove TODOs from hosted.html
svn merge --ignore-ancestry -c7141 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=7142
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
===
--- /releases/2.0/branch-info.txt Mon Nov 23 14:42:20 2009
+++ /releases/2.0/branch-info.txt Mon Nov 23 15:06:45 2009
@@ -1008,3 +1008,8 @@
tr...@7139 was merged into this branch
Disconnected plugin glasspanel lightened to 75% opacity.
svn merge --ignore-ancestry -c7139
https://google-web-toolkit.googlecode.com/svn/trunk .
+
+tr...@7141 was merged into this branch
+ Remove TODOs from hosted.html
+svn merge --ignore-ancestry -c7141 \
+ https://google-web-toolkit.googlecode.com/svn/trunk/ .
===
---
/releases/2.0/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
Mon Nov 23 14:42:20 2009
+++
/releases/2.0/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html
Mon Nov 23 15:06:45 2009
@@ -1,7 +1,5 @@
html
headscript
-// TODO(jat): wrap these to reduce namespace issues, and refactor code into
-//separate functions.
var $wnd = parent;
var $doc = $wnd.document;
var $moduleName, $moduleBase, $entry
@@ -51,7 +49,6 @@
var ua = navigator.userAgent.toLowerCase();
if (ua.indexOf(gecko) != -1) {
// install eval wrapper on FF to avoid EvalError problem
- // TODO(jat): should this UA check be more specific (this hits chrome
too)?
var __eval = window.eval;
window.eval = function(s) {
return __eval(s);
@@ -221,21 +218,7 @@
$moduleName = modName;
$moduleBase = modBase;
- /*
- * NOTE: this presently sucks and is the only formulation I can find
that will
- * work across browsers. On a Windows box where both plugins are
registered,
- * FF will instantiate the (non-working) IE plugin. But plugins have
problems
- * that prevent making this easy.
- *
- * The IE plugin will throw an exception in FF if you try to resolve
- * pluginObject.connect as a value. Thus the try/catch below.
- *
- * The FF plugin will actually do illegal crashy things in IE if you try
to
- * resolve pluginEmbed.connect as a value. Thus we have to try the IE
- * plugin first.
- *
- * Both plugins need some work to make them truly safe.
- */
+ // Note that the order is important
var pluginFinders = [
findPluginXPCOM,
findPluginObject,
@@ -299,8 +282,6 @@
}
window.onunload = function() {
- // TODO: do we need to do anything here or just rely on the plugins
- // unload call?
};
// Lightweight metrics
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7143 committed - Improve debug logging to help track down crash....
Revision: 7143
Author: j...@google.com
Date: Mon Nov 23 15:38:51 2009
Log: Improve debug logging to help track down crash.
Patch by: jat
Review by: scottb (TBR)
http://code.google.com/p/google-web-toolkit/source/detail?r=7143
Modified:
/trunk/plugins/xpcom/ExternalWrapper.cpp
/trunk/plugins/xpcom/FFSessionHandler.cpp
===
--- /trunk/plugins/xpcom/ExternalWrapper.cppTue Nov 10 14:14:58 2009
+++ /trunk/plugins/xpcom/ExternalWrapper.cppMon Nov 23 15:38:51 2009
@@ -45,8 +45,8 @@
NS_IMPL_ISUPPORTS2_CI(ExternalWrapper, IOOPHM, nsISecurityCheckedComponent)
ExternalWrapper::ExternalWrapper() {
- Debug::log(Debug::Spam) ExternalWrapper::ExternalWrapper()
- Debug::flush;
+ Debug::log(Debug::Debugging) ExternalWrapper::ExternalWrapper(this=
+ this ) Debug::flush;
preferences = new Preferences();
windowWatcher = do_GetService(NS_WINDOWWATCHER_CONTRACTID);
if (!windowWatcher) {
@@ -57,7 +57,8 @@
}
ExternalWrapper::~ExternalWrapper() {
- Debug::log(Debug::Spam) ExternalWrapper::~ExternalWrapper
Debug::flush;
+ Debug::log(Debug::Debugging) ExternalWrapper::~ExternalWrapper(this=
+ this ) Debug::flush;
}
// define the CID for nsIHttpProtocolHandler
===
--- /trunk/plugins/xpcom/FFSessionHandler.cpp Mon Nov 23 13:18:40 2009
+++ /trunk/plugins/xpcom/FFSessionHandler.cpp Mon Nov 23 15:38:51 2009
@@ -57,6 +57,8 @@
FFSessionHandler::FFSessionHandler(HostChannel* channel)
: SessionData(channel, this, getJSContext()), jsObjectId(0),
jsObjectsById(NULL), stringObjectClass(NULL) {
+ Debug::log(Debug::Debugging)
FFSessionHandler::FFSessionHandler(this=
+ this ) Debug::flush;
// TODO(jat): is there a way to avoid calling this twice, without keeping
// JSContext in an instance field?
JSContext* ctx = getJSContext();
@@ -118,7 +120,8 @@
}
FFSessionHandler::~FFSessionHandler(void) {
- Debug::log(Debug::Debugging) FFSessionHandler::~FFSessionHandler
Debug::flush;
+ Debug::log(Debug::Debugging)
FFSessionHandler::~FFSessionHandler(this=
+ this ) Debug::flush;
disconnect();
if (runtime) {
JS_RemoveRootRT(runtime, jsObjectsById);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7144 committed - Update Fedora/etc shared libraries....
Revision: 7144 Author: j...@google.com Date: Mon Nov 23 15:41:57 2009 Log: Update Fedora/etc shared libraries. Patch by: jat Unreviewed http://code.google.com/p/google-web-toolkit/source/detail?r=7144 Modified: /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff3+/libgwt_dev_ff3+.so /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86_64-gcc3/ff3+/libgwt_dev_ff3+.so === --- /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff3+/libgwt_dev_ff3+.so Mon Nov 23 14:00:51 2009 +++ /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff3+/libgwt_dev_ff3+.so Mon Nov 23 15:41:57 2009 File is too large to display a diff. === --- /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86_64-gcc3/ff3+/libgwt_dev_ff3+.so Mon Nov 23 14:00:51 2009 +++ /trunk/plugins/xpcom/prebuilt/extension/lib/Linux_x86_64-gcc3/ff3+/libgwt_dev_ff3+.so Mon Nov 23 15:41:57 2009 File is too large to display a diff. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7145 committed - Update Mac FF shared libraries....
Revision: 7145 Author: j...@google.com Date: Mon Nov 23 16:17:33 2009 Log: Update Mac FF shared libraries. Patch by: jat Unreviewed http://code.google.com/p/google-web-toolkit/source/detail?r=7145 Modified: /trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff3/libgwt_dev_ff3.dylib /trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff35/libgwt_dev_ff35.dylib === --- /trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff3/libgwt_dev_ff3.dylib Tue Nov 10 14:13:03 2009 +++ /trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff3/libgwt_dev_ff3.dylib Mon Nov 23 16:17:33 2009 Binary file, no diff available. === --- /trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff35/libgwt_dev_ff35.dylib Tue Nov 10 14:13:03 2009 +++ /trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff35/libgwt_dev_ff35.dylib Mon Nov 23 16:17:33 2009 Binary file, no diff available. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7146 committed - Nukes svn:merginfo over all of trunk....
Revision: 7146 Author: sco...@google.com Date: Mon Nov 23 16:21:36 2009 Log: Nukes svn:merginfo over all of trunk. Review by: jat http://code.google.com/p/google-web-toolkit/source/detail?r=7146 Modified: /trunk /trunk/dev/core/src/com/google/gwt/core/ext/ServletContainer.java /trunk/dev/core/src/com/google/gwt/core/ext/ServletContainerLauncher.java /trunk/dev/core/src/com/google/gwt/dev/BootStrapPlatform.java /trunk/dev/core/src/com/google/gwt/dev/DevMode.java /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java /trunk/dev/core/src/com/google/gwt/dev/DevelModeTabKey.java /trunk/dev/core/src/com/google/gwt/dev/Disconnectable.java /trunk/dev/core/src/com/google/gwt/dev/GWTShell.java /trunk/dev/core/src/com/google/gwt/dev/ModulePanel.java /trunk/dev/core/src/com/google/gwt/dev/ModuleTabPanel.java /trunk/dev/core/src/com/google/gwt/dev/SessionModule.java /trunk/dev/core/src/com/google/gwt/dev/WebServerPanel.java /trunk/dev/core/src/com/google/gwt/dev/shell/BrowserChannel.java /trunk/dev/core/src/com/google/gwt/dev/shell/BrowserChannelClient.java /trunk/dev/core/src/com/google/gwt/dev/shell/BrowserChannelException.java /trunk/dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java /trunk/dev/core/src/com/google/gwt/dev/shell/BrowserListener.java /trunk/dev/core/src/com/google/gwt/dev/shell/CloseButton.java /trunk/dev/core/src/com/google/gwt/dev/shell/HostedModePluginObject.java /trunk/dev/core/src/com/google/gwt/dev/shell/HtmlUnitSessionHandler.java /trunk/dev/core/src/com/google/gwt/dev/shell/Icons.java /trunk/dev/core/src/com/google/gwt/dev/shell/JavaObject.java /trunk/dev/core/src/com/google/gwt/dev/shell/JsValue.java /trunk/dev/core/src/com/google/gwt/dev/shell/JsValueGlue.java /trunk/dev/core/src/com/google/gwt/dev/shell/JsValueOOPHM.java /trunk/dev/core/src/com/google/gwt/dev/shell/Jsni.java /trunk/dev/core/src/com/google/gwt/dev/shell/MethodDispatch.java /trunk/dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java /trunk/dev/core/src/com/google/gwt/dev/shell/OophmSessionHandler.java /trunk/dev/core/src/com/google/gwt/dev/shell/RemoteObjectTable.java /trunk/dev/core/src/com/google/gwt/dev/shell/ServerMethods.java /trunk/dev/core/src/com/google/gwt/dev/shell/ServerObjectsTable.java /trunk/dev/core/src/com/google/gwt/dev/shell/SessionData.java /trunk/dev/core/src/com/google/gwt/dev/shell/ShellMainWindow.java /trunk/dev/core/src/com/google/gwt/dev/shell/close.png /trunk/dev/core/src/com/google/gwt/dev/shell/ie /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingTreeLogger.java /trunk/dev/core/src/com/google/gwt/dev/shell/log/icon-close.png /trunk/dev/core/src/com/google/gwt/dev/shell/rewrite/RewriteSingleJsoImplDispatches.java /trunk/dev/core/src/com/google/gwt/dev/util/BrowserInfo.java /trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerDisableAggressiveOptimization.java /trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableAssertions.java /trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerOutDir.java /trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerWorkDirOptional.java /trunk/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerWorkDirRequired.java /trunk/dev/core/test/com/google/gwt/dev/AboutTest.java /trunk/dev/core/test/com/google/gwt/dev/DevelModeTabKeyTest.java /trunk/dev/core/test/com/google/gwt/dev/SessionModuleTest.java /trunk/dev/core/test/com/google/gwt/dev/shell/BrowserChannelTest.java /trunk/dev/core/test/com/google/gwt/dev/shell/RemoteObjectTableTest.java /trunk/dev/core/test/com/google/gwt/dev/util/TemporaryBufferStream.java /trunk/distro-source/src/benchmarkViewer /trunk/distro-source/src/benchmarkViewer.cmd /trunk/distro-source/src/i18nCreator /trunk/distro-source/src/i18nCreator.cmd /trunk/distro-source/src/webAppCreator /trunk/distro-source/src/webAppCreator.cmd /trunk/eclipse/samples/Hello/Hello-gwtc.launch /trunk/jni /trunk/plugins/xpcom/xpGwtDevPlugin.def /trunk/plugins/xpcom/xpGwtDevPlugin.rc /trunk/samples/dynatable/war/DynaTable.css /trunk/samples/dynatable/war/DynaTable.html /trunk/samples/hello/war/Hello.html /trunk/samples/json/war/JSON.css /trunk/samples/json/war/JSON.html /trunk/samples/mail/src/com/google/gwt/sample/mail/client/global.css /trunk/samples/mail/war/Mail.html /trunk/samples/showcase/war/Showcase.html /trunk/samples/simplerpc/war/SimpleRPC.css /trunk/samples/simplerpc/war/SimpleRPC.html /trunk/samples/simplexml/war/SimpleXML.css /trunk/samples/simplexml/war/SimpleXML.html /trunk/user/src/com/google/gwt/core/client/HttpThrowableReporter.java /trunk/user/src/com/google/gwt/core/client/JsonUtils.java /trunk/user/src/com/google/gwt/event/dom/client/HandlesAllFocusEvents.java /trunk/user/src/com/google/gwt/event/dom/client/HandlesAllKeyEvents.java
[gwt-contrib] Re: RR: UiBinder javadoc, including UiObject, CellPanel
http://gwt-code-reviews.appspot.com/111805/diff/1/4 File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (left): http://gwt-code-reviews.appspot.com/111805/diff/1/4#oldcode923 Line 923: // automagically, according to http://b/issue?id=1867118 Yes, that's why I deleted it. http://gwt-code-reviews.appspot.com/111805/diff/1/5 File user/src/com/google/gwt/user/client/ui/CellPanel.java (right): http://gwt-code-reviews.appspot.com/111805/diff/1/5#newcode29 Line 29: * That's not needed http://gwt-code-reviews.appspot.com/111805/diff/1/6 File user/src/com/google/gwt/user/client/ui/UIObject.java (right): http://gwt-code-reviews.appspot.com/111805/diff/1/6#newcode84 Line 84: * h3In UiBinder templates/h3 I was trying for how you use this thing IN a UiBinder Template, preferably in a form I could copy and paste. How about Use in UiBinder templates http://gwt-code-reviews.appspot.com/111805/diff/1/6#newcode112 Line 112: * lt;g:Label pixelSize='100, 100'Hello therelt;/g:Label/pre I tried, but there is no place in our widget set that actually has such a method (though there should be). I suppose I could make something up. http://gwt-code-reviews.appspot.com/111805 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: RR: UiBinder javadoc, including UiObject, CellPanel
http://gwt-code-reviews.appspot.com/111805/diff/1/5 File user/src/com/google/gwt/user/client/ui/CellPanel.java (right): http://gwt-code-reviews.appspot.com/111805/diff/1/5#newcode29 Line 29: * Oh, yes it is. :-) http://gwt-code-reviews.appspot.com/111805 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7147 committed - Updating Chrome, IE, and Firefox plugin installers with glasspanel-on-...
Revision: 7147
Author: sco...@google.com
Date: Mon Nov 23 16:38:01 2009
Log: Updating Chrome, IE, and Firefox plugin installers with
glasspanel-on-disconnect feature.
- gwtdmp.crx is updated also, but we should delete it later
- Also deleted old files.
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7147
Added:
/trunk/plugins/npapi/prebuilt/gwt-dev-plugin.crx
Deleted:
/trunk/plugins/npapi/extension/chrome.manifest
/trunk/plugins/npapi/extension/platform/Darwin_x86-gcc3/plugins/oophm.plugin/Contents/Info.plist
/trunk/plugins/npapi/extension/platform/Darwin_x86-gcc3/plugins/oophm.plugin/Contents/MacOS/liboophm
/trunk/plugins/npapi/extension/platform/Darwin_x86-gcc3/plugins/oophm.plugin/Contents/Resources/liboophm.rsrc
/trunk/plugins/npapi/extension/skin/icon.png
Modified:
/trunk/plugins/ie/installer/installer.wxs.xml
/trunk/plugins/ie/prebuilt/gwt-dev-plugin.msi
/trunk/plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json
/trunk/plugins/npapi/prebuilt/gwtdmp.crx
/trunk/plugins/xpcom/prebuilt/gwt-dev-plugin.xpi
===
--- /dev/null
+++ /trunk/plugins/npapi/prebuilt/gwt-dev-plugin.crxMon Nov 23 16:38:01
2009
Binary file, no diff available.
===
--- /trunk/plugins/npapi/extension/chrome.manifest Mon Aug 3 08:30:11 2009
+++ /dev/null
@@ -1,2 +0,0 @@
-content gwt-oophm content/
-skin gwt-oophm classic/1.0 skin/
===
---
/trunk/plugins/npapi/extension/platform/Darwin_x86-gcc3/plugins/oophm.plugin/Contents/Info.plist
Mon Aug 3 08:30:11 2009
+++ /dev/null
@@ -1,20 +0,0 @@
-plist version=1.0
-dict
- keyCFBundleDevelopmentRegion/key
- stringEnglish/string
- keyCFBundleExecutable/key
- stringliboophm/string
- keyCFBundleIdentifier/key
- stringcom.google.gwt.oophm/string
- keyCFBundleName/key
- stringoophm/string
- keyCFBundleInfoDictionaryVersion/key
- string6.0/string
- keyCFBundlePackageType/key
- stringNSPL/string
- keyCFBundleSignature/key
- stringMOSS/string
- keyCFBundleVersion/key
- string1.0/string
-/dict
-/plist
===
---
/trunk/plugins/npapi/extension/platform/Darwin_x86-gcc3/plugins/oophm.plugin/Contents/MacOS/liboophm
Mon Aug 3 08:30:11 2009
+++ /dev/null
File is too large to display a diff.
===
---
/trunk/plugins/npapi/extension/platform/Darwin_x86-gcc3/plugins/oophm.plugin/Contents/Resources/liboophm.rsrc
Mon Aug 3 08:30:11 2009
+++ /dev/null
@@ -1,3 +0,0 @@
- 4 4 2
0 GWT
Hosted-mode
plugin GWT Hosted-mode plugin
- 2 STR#
- ~ÿÿ
===
--- /trunk/plugins/npapi/extension/skin/icon.pngMon Aug 3 08:30:11 2009
+++ /dev/null
Binary file, no diff available.
===
--- /trunk/plugins/ie/installer/installer.wxs.xml Fri Nov 20 09:49:22 2009
+++ /trunk/plugins/ie/installer/installer.wxs.xml Mon Nov 23 16:38:01 2009
@@ -4,7 +4,7 @@
!-- Variables. --
?define appName = Google Web Toolkit Developer Plugin for IE ?
- ?define version = 0.9.2.0 ?
+ ?define version = 0.9.7135.0 ?
?define upgradeCode = 9a5e649a-ec63-4c7d-99bf-75adb345e7e5 ?
?define updateRegKey
= SOFTWARE\Google\Update\Clients\{$(var.upgradeCode)} ?
?define gwtRegKey = SOFTWARE\Google\Google Web Toolkit\Installer ?
===
--- /trunk/plugins/ie/prebuilt/gwt-dev-plugin.msi Fri Nov 20 09:49:22 2009
+++ /trunk/plugins/ie/prebuilt/gwt-dev-plugin.msi Mon Nov 23 16:38:01 2009
Binary file, no diff available.
===
--- /trunk/plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json Tue Nov 10
16:50:19 2009
+++ /trunk/plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json Mon Nov 23
16:38:01 2009
@@ -1,6 +1,6 @@
{
name: GWT Developer Plugin,
- version: 0.9.6820.20091110,
+ version: 0.9.7135,
description: A plugin to enable debugging with GWT's Development
Mode,
update_url: https://dl-ssl.google.com/gwt/plugins/chrome/updates.xml;,
icons: {
===
--- /trunk/plugins/npapi/prebuilt/gwtdmp.crxTue Nov 10 08:09:43 2009
+++ /trunk/plugins/npapi/prebuilt/gwtdmp.crxMon Nov 23 16:38:01 2009
Binary file, no diff available.
===
--- /trunk/plugins/xpcom/prebuilt/gwt-dev-plugin.xpiTue Nov 10 15:51:47
2009
+++ /trunk/plugins/xpcom/prebuilt/gwt-dev-plugin.xpiMon Nov 23 16:38:01
2009
File is too large to display a diff.
--
[gwt-contrib] [google-web-toolkit] r7148 committed - Improve the DevMode UI, both for GPE and Swing:...
Revision: 7148
Author: j...@google.com
Date: Mon Nov 23 18:34:09 2009
Log: Improve the DevMode UI, both for GPE and Swing:
- startup URLs are specified separately from launching them, allowing them
to be displayed earlier
- if no startup URLs are supplied, they are inferred from the contents of
the war directory
- the Swing UI is change to better allow launching of the URLs and to give
feedback while processing modules
- Ctrl-Key mappings are now Command-Key on the Mac
Patch by: jat
Review by: rdayal
http://code.google.com/p/google-web-toolkit/source/detail?r=7148
Modified:
/trunk/dev/core/src/com/google/gwt/dev/BootStrapPlatform.java
/trunk/dev/core/src/com/google/gwt/dev/DevMode.java
/trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java
/trunk/dev/core/src/com/google/gwt/dev/GWTShell.java
/trunk/dev/core/src/com/google/gwt/dev/SwingUI.java
/trunk/dev/core/src/com/google/gwt/dev/shell/ShellMainWindow.java
/trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
/trunk/dev/core/src/com/google/gwt/dev/ui/DevModeUI.java
===
--- /trunk/dev/core/src/com/google/gwt/dev/BootStrapPlatform.java Mon Nov
23 16:21:36 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/BootStrapPlatform.java Mon Nov
23 18:34:09 2009
@@ -48,6 +48,14 @@
public static void initHostedMode() {
// nothing required
}
+
+ /**
+ * Return true if we are running on a Mac.
+ */
+ public static boolean isMac() {
+String lcOSName =
System.getProperty(os.name).toLowerCase(Locale.ENGLISH);
+return lcOSName.startsWith(mac );
+ }
/**
* This works around apple radr:5569300. When -XstartOnFirstThread is
passed
@@ -61,14 +69,6 @@
BootStrapPlatform.class.getClassLoader());
}
}
-
- /**
- * Return true if we are running on a Mac.
- */
- private static boolean isMac() {
-String lcOSName =
System.getProperty(os.name).toLowerCase(Locale.ENGLISH);
-return lcOSName.startsWith(mac );
- }
/**
* Sets platform specific system properties. Currently, this disables
===
--- /trunk/dev/core/src/com/google/gwt/dev/DevMode.java Mon Nov 23 16:21:36
2009
+++ /trunk/dev/core/src/com/google/gwt/dev/DevMode.java Mon Nov 23 18:34:09
2009
@@ -36,6 +36,7 @@
import com.google.gwt.util.tools.Utility;
import java.io.File;
+import java.io.FilenameFilter;
import java.io.IOException;
import java.net.BindException;
import java.util.HashMap;
@@ -227,6 +228,11 @@
}
}
+ /**
+ * Startup development mode.
+ *
+ * @param args command line arguments
+ */
public static void main(String[] args) {
/*
* NOTE: main always exits with a call to System.exit to terminate any
@@ -302,10 +308,7 @@
}
@Override
- protected boolean doStartup() {
-if (!super.doStartup()) {
- return false;
-}
+ protected boolean doSlowStartup() {
tempWorkDir = options.getWorkDir() == null;
if (tempWorkDir) {
try {
@@ -390,6 +393,19 @@
protected String getWebServerName() {
return options.getServletContainerLauncher().getName();
}
+
+ @Override
+ protected void inferStartupUrls() {
+// Look for any HTML files directly under war
+File warDir = options.getWarDir();
+for (File htmlFile : warDir.listFiles(new FilenameFilter() {
+ public boolean accept(File dir, String name) {
+return name.matches(.*\\.html);
+ }
+})) {
+ options.addStartupURL(htmlFile.getName());
+}
+ }
@Override
protected ModuleDef loadModule(TreeLogger logger, String moduleName,
===
--- /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java Mon Nov 23
16:21:36 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java Mon Nov 23
18:34:09 2009
@@ -674,6 +674,8 @@
* Gets the base log level recommended by the UI for INFO-level
messages. This
* method can only be called once {...@link #createUI()} has been called.
Please
* do not depend on this method, as it is subject to change.
+ *
+ * @return the log level to use for INFO-level messages
*/
public TreeLogger.Type getBaseLogLevelForUI() {
if (baseLogLevelForUI == null) {
@@ -691,29 +693,6 @@
public TreeLogger getTopLogger() {
return topLogger;
}
-
- /**
- * Launch the arguments as Urls in separate windows.
- *
- * @param logger TreeLogger instance to use
- */
- public void launchStartupUrls(final TreeLogger logger) {
-ensureCodeServerListener();
-String startupURL = ;
-MapString, URL startupUrls = new HashMapString, URL();
-for (String prenormalized : options.getStartupURLs()) {
- startupURL = normalizeURL(prenormalized, getPort(), getHost());
- logger.log(TreeLogger.TRACE, Starting URL: + startupURL, null);
- try {
-URL url = processUrl(startupURL);
-
[gwt-contrib] JUnit breaks over proxy
Reviewers: jat, jlabanca, amitmanjhi, Description: Hi John, Please review, commit, merge if you can. This fixes a problem where clients are seen to have unstable IP addresses when coming through a proxy. Also fixes a problem where two browsers with the same user agent string look like the same browser. Please review this at http://gwt-code-reviews.appspot.com/111806 Affected files: user/src/com/google/gwt/junit/JUnitMessageQueue.java user/src/com/google/gwt/junit/JUnitShell.java user/src/com/google/gwt/junit/server/JUnitHostImpl.java user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java user/test/com/google/gwt/junit/JUnitMessageQueueTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7149 committed - Merge trunk r7148 into this branch...
Revision: 7149
Author: j...@google.com
Date: Mon Nov 23 19:54:09 2009
Log: Merge trunk r7148 into this branch
DevMode UI improvements
svn merge --ignore-ancestry -c7148 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=7149
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/dev/core/src/com/google/gwt/dev/BootStrapPlatform.java
/releases/2.0/dev/core/src/com/google/gwt/dev/DevMode.java
/releases/2.0/dev/core/src/com/google/gwt/dev/DevModeBase.java
/releases/2.0/dev/core/src/com/google/gwt/dev/GWTShell.java
/releases/2.0/dev/core/src/com/google/gwt/dev/SwingUI.java
/releases/2.0/dev/core/src/com/google/gwt/dev/shell/ShellMainWindow.java
/releases/2.0/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
/releases/2.0/dev/core/src/com/google/gwt/dev/ui/DevModeUI.java
===
--- /releases/2.0/branch-info.txt Mon Nov 23 15:06:45 2009
+++ /releases/2.0/branch-info.txt Mon Nov 23 19:54:09 2009
@@ -1013,3 +1013,8 @@
Remove TODOs from hosted.html
svn merge --ignore-ancestry -c7141 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
+
+tr...@7148 was merged into this branch
+ DevMode UI improvements
+svn merge --ignore-ancestry -c7148 \
+ https://google-web-toolkit.googlecode.com/svn/trunk/ .
===
--- /releases/2.0/dev/core/src/com/google/gwt/dev/BootStrapPlatform.java
Wed Nov 18 09:09:47 2009
+++ /releases/2.0/dev/core/src/com/google/gwt/dev/BootStrapPlatform.java
Mon Nov 23 19:54:09 2009
@@ -48,6 +48,14 @@
public static void initHostedMode() {
// nothing required
}
+
+ /**
+ * Return true if we are running on a Mac.
+ */
+ public static boolean isMac() {
+String lcOSName =
System.getProperty(os.name).toLowerCase(Locale.ENGLISH);
+return lcOSName.startsWith(mac );
+ }
/**
* This works around apple radr:5569300. When -XstartOnFirstThread is
passed
@@ -61,14 +69,6 @@
BootStrapPlatform.class.getClassLoader());
}
}
-
- /**
- * Return true if we are running on a Mac.
- */
- private static boolean isMac() {
-String lcOSName =
System.getProperty(os.name).toLowerCase(Locale.ENGLISH);
-return lcOSName.startsWith(mac );
- }
/**
* Sets platform specific system properties. Currently, this disables
===
--- /releases/2.0/dev/core/src/com/google/gwt/dev/DevMode.java Fri Nov 20
11:47:11 2009
+++ /releases/2.0/dev/core/src/com/google/gwt/dev/DevMode.java Mon Nov 23
19:54:09 2009
@@ -35,6 +35,7 @@
import com.google.gwt.util.tools.Utility;
import java.io.File;
+import java.io.FilenameFilter;
import java.io.IOException;
import java.net.BindException;
import java.util.HashMap;
@@ -226,6 +227,11 @@
}
}
+ /**
+ * Startup development mode.
+ *
+ * @param args command line arguments
+ */
public static void main(String[] args) {
/*
* NOTE: main always exits with a call to System.exit to terminate any
@@ -301,10 +307,7 @@
}
@Override
- protected boolean doStartup() {
-if (!super.doStartup()) {
- return false;
-}
+ protected boolean doSlowStartup() {
tempWorkDir = options.getWorkDir() == null;
if (tempWorkDir) {
try {
@@ -389,6 +392,19 @@
protected String getWebServerName() {
return options.getServletContainerLauncher().getName();
}
+
+ @Override
+ protected void inferStartupUrls() {
+// Look for any HTML files directly under war
+File warDir = options.getWarDir();
+for (File htmlFile : warDir.listFiles(new FilenameFilter() {
+ public boolean accept(File dir, String name) {
+return name.matches(.*\\.html);
+ }
+})) {
+ options.addStartupURL(htmlFile.getName());
+}
+ }
@Override
protected ModuleDef loadModule(TreeLogger logger, String moduleName,
===
--- /releases/2.0/dev/core/src/com/google/gwt/dev/DevModeBase.java Mon Nov
23 09:05:16 2009
+++ /releases/2.0/dev/core/src/com/google/gwt/dev/DevModeBase.java Mon Nov
23 19:54:09 2009
@@ -674,6 +674,8 @@
* Gets the base log level recommended by the UI for INFO-level
messages. This
* method can only be called once {...@link #createUI()} has been called.
Please
* do not depend on this method, as it is subject to change.
+ *
+ * @return the log level to use for INFO-level messages
*/
public TreeLogger.Type getBaseLogLevelForUI() {
if (baseLogLevelForUI == null) {
@@ -691,29 +693,6 @@
public TreeLogger getTopLogger() {
return topLogger;
}
-
- /**
- * Launch the arguments as Urls in separate windows.
- *
- * @param logger TreeLogger instance to use
- */
- public void launchStartupUrls(final TreeLogger logger) {
-
[gwt-contrib] Code Review Request: Send startup URLs over the wire to GPE
Reviewers: jat, mmendez, Description: Send startup URLs over the wire to GPE. The initialization code has now been moved from RemoteUI.initialize to RemoteUI.setStartupURLs. Please review this at http://gwt-code-reviews.appspot.com/111807 Affected files: M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteMessageProto.java M dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java M dev/core/src/com/google/gwt/dev/shell/remoteui/ViewerServiceClient.java M dev/core/src/com/google/gwt/dev/shell/remoteui/remotemessage.proto -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Code Review Request: Send startup URLs over the wire to GPE
LGTM
http://gwt-code-reviews.appspot.com/111807/diff/1/5
File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
(right):
http://gwt-code-reviews.appspot.com/111807/diff/1/5#newcode169
Line 169: public void setStartupUrls(MapString, URL urls) {
Nit: why was this a Map again?
http://gwt-code-reviews.appspot.com/111807
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Code Review Request: Send startup URLs over the wire to GPE
Thanks for the review!
http://gwt-code-reviews.appspot.com/111807/diff/1/5
File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
(right):
http://gwt-code-reviews.appspot.com/111807/diff/1/5#newcode169
Line 169: public void setStartupUrls(MapString, URL urls) {
On 2009/11/24 05:14:07, mmendez wrote:
Nit: why was this a Map again?
That's a good question. I think the intent was that that String value in
the map would be the URL fragment - i.e. Test.html. The URL would be the
fully-qualified URL, such as
http://localhost:/Test.html?gwt.codesvr=
http://gwt-code-reviews.appspot.com/111807
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Code Review Request: Send startup URLs over the wire to GPE
On Tue, Nov 24, 2009 at 12:17 AM, rda...@google.com wrote:
Thanks for the review!
http://gwt-code-reviews.appspot.com/111807/diff/1/5
File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
(right):
http://gwt-code-reviews.appspot.com/111807/diff/1/5#newcode169
Line 169: public void setStartupUrls(MapString, URL urls) {
On 2009/11/24 05:14:07, mmendez wrote:
Nit: why was this a Map again?
That's a good question. I think the intent was that that String value in
the map would be the URL fragment - i.e. Test.html. The URL would be the
fully-qualified URL, such as
http://localhost:/Test.html?gwt.codesvr=
http://gwt-code-reviews.appspot.com/111807
It would be good to confirm this at some point.
--
Miguel
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7150 committed - Got rid of port-guessing logic. We now use setStartupURLs as our init ...
Revision: 7150
Author: rda...@google.com
Date: Mon Nov 23 21:20:12 2009
Log: Got rid of port-guessing logic. We now use setStartupURLs as our init
hook. We no longer send over the dev mode query params. We send over the
startup URLs.
Review by: mmendez
http://code.google.com/p/google-web-toolkit/source/detail?r=7150
Modified:
/trunk/dev/core/src/com/google/gwt/dev/DevMode.java
/trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java
/trunk/dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteMessageProto.java
/trunk/dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
/trunk/dev/core/src/com/google/gwt/dev/shell/remoteui/ViewerServiceClient.java
/trunk/dev/core/src/com/google/gwt/dev/shell/remoteui/remotemessage.proto
===
--- /trunk/dev/core/src/com/google/gwt/dev/DevMode.java Mon Nov 23 18:34:09
2009
+++ /trunk/dev/core/src/com/google/gwt/dev/DevMode.java Mon Nov 23 21:20:12
2009
@@ -41,6 +41,7 @@
import java.net.BindException;
import java.util.HashMap;
import java.util.Map;
+import java.util.regex.Pattern;
/**
* The main executable class for the hosted mode shell. NOTE: the public
API for
@@ -227,6 +228,12 @@
this.warDir = warDir;
}
}
+
+ /**
+ * The pattern for files usable as startup URLs.
+ */
+ private static final Pattern STARTUP_FILE_PATTERN = Pattern.compile(
+ .*\\.(html|jsp), Pattern.CASE_INSENSITIVE);
/**
* Startup development mode.
@@ -396,11 +403,11 @@
@Override
protected void inferStartupUrls() {
-// Look for any HTML files directly under war
+// Look for launchable files directly under war
File warDir = options.getWarDir();
for (File htmlFile : warDir.listFiles(new FilenameFilter() {
public boolean accept(File dir, String name) {
-return name.matches(.*\\.html);
+return STARTUP_FILE_PATTERN.matcher(name).matches();
}
})) {
options.addStartupURL(htmlFile.getName());
===
--- /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java Mon Nov 23
18:34:09 2009
+++ /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java Mon Nov 23
21:20:12 2009
@@ -47,9 +47,7 @@
import com.google.gwt.util.tools.ArgHandlerString;
import java.io.File;
-import java.io.IOException;
import java.net.MalformedURLException;
-import java.net.ServerSocket;
import java.net.URL;
import java.util.ArrayList;
import java.util.Collections;
@@ -170,7 +168,7 @@
@Override
public boolean setString(String value) {
if (value.equals(auto)) {
-options.setCodeServerPort(getFreeSocketPort());
+options.setCodeServerPort(0);
} else {
try {
options.setCodeServerPort(Integer.parseInt(value));
@@ -276,7 +274,7 @@
@Override
public boolean setString(String value) {
if (value.equals(auto)) {
-options.setPort(getFreeSocketPort());
+options.setPort(0);
} else {
try {
options.setPort(Integer.parseInt(value));
@@ -595,27 +593,6 @@
return http://; + host + / + unknownUrlText;
}
}
-
- /**
- * Returns a free port. The returned port should not be returned again
unless
- * the ephemeral port range is exhausted.
- */
- protected static int getFreeSocketPort() {
-ServerSocket socket = null;
-try {
- socket = new ServerSocket(0);
- return socket.getLocalPort();
-} catch (IOException e) {
-} finally {
- if (socket != null) {
-try {
- socket.close();
-} catch (IOException e) {
-}
- }
-}
-return -1;
- }
/**
* Produce a random string that has low probability of collisions.
@@ -1003,8 +980,7 @@
if (options.useRemoteUI()) {
try {
newUI = new RemoteUI(options.getRemoteUIHost(),
- options.getRemoteUIHostPort(), options.getClientId(),
- options.getPort(), options.getCodeServerPort());
+ options.getRemoteUIHostPort(), options.getClientId());
baseLogLevelForUI = TreeLogger.Type.TRACE;
} catch (Throwable t) {
System.err.println(Could not connect to remote UI listening at
===
---
/trunk/dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteMessageProto.java
Mon Nov 9 07:26:40 2009
+++
/trunk/dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteMessageProto.java
Mon Nov 23 21:20:12 2009
@@ -3929,19 +3929,17 @@
public boolean hasClientId() { return hasClientId; }
public java.lang.String getClientId() { return clientId_; }
- // optional string devModeQueryParam = 2;
- public static final int DEVMODEQUERYPARAM_FIELD_NUMBER = 2;
- private boolean hasDevModeQueryParam;
- private java.lang.String devModeQueryParam_ = ;
- public boolean
[gwt-contrib] Re: Code Review Request: Send startup URLs over the wire to GPE
Ok, I did confirm it - check out the documentation on
DevModeUI.setStartupURLs - that defines the values in the map.
2009/11/24 Miguel Méndez mmen...@google.com
On Tue, Nov 24, 2009 at 12:17 AM, rda...@google.com wrote:
Thanks for the review!
http://gwt-code-reviews.appspot.com/111807/diff/1/5
File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
(right):
http://gwt-code-reviews.appspot.com/111807/diff/1/5#newcode169
Line 169: public void setStartupUrls(MapString, URL urls) {
On 2009/11/24 05:14:07, mmendez wrote:
Nit: why was this a Map again?
That's a good question. I think the intent was that that String value in
the map would be the URL fragment - i.e. Test.html. The URL would be the
fully-qualified URL, such as
http://localhost:/Test.html?gwt.codesvr=
http://gwt-code-reviews.appspot.com/111807
It would be good to confirm this at some point.
--
Miguel
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Code Review Request: Send startup URLs over the wire to GPE
Thanks for the clarification.
2009/11/24 Rajeev Dayal rda...@google.com
Ok, I did confirm it - check out the documentation on
DevModeUI.setStartupURLs - that defines the values in the map.
2009/11/24 Miguel Méndez mmen...@google.com
On Tue, Nov 24, 2009 at 12:17 AM, rda...@google.com wrote:
Thanks for the review!
http://gwt-code-reviews.appspot.com/111807/diff/1/5
File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
(right):
http://gwt-code-reviews.appspot.com/111807/diff/1/5#newcode169
Line 169: public void setStartupUrls(MapString, URL urls) {
On 2009/11/24 05:14:07, mmendez wrote:
Nit: why was this a Map again?
That's a good question. I think the intent was that that String value in
the map would be the URL fragment - i.e. Test.html. The URL would be the
fully-qualified URL, such as
http://localhost:/Test.html?gwt.codesvr=
http://gwt-code-reviews.appspot.com/111807
It would be good to confirm this at some point.
--
Miguel
--
Miguel
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Code Review Request: Send startup URLs over the wire to GPE
Thanks for the review. Committed as tr...@r7150 and cherry-picked into releases/2.0 at r7151. http://gwt-code-reviews.appspot.com/111807 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r7152 committed - Updated branch-info.txt to reflect merge of tr...@r7150 into releases/...
Revision: 7152 Author: rda...@google.com Date: Mon Nov 23 21:26:14 2009 Log: Updated branch-info.txt to reflect merge of tr...@r7150 into releases/2.0 at r7151. http://code.google.com/p/google-web-toolkit/source/detail?r=7152 Modified: /releases/2.0/branch-info.txt === --- /releases/2.0/branch-info.txt Mon Nov 23 19:54:09 2009 +++ /releases/2.0/branch-info.txt Mon Nov 23 21:26:14 2009 @@ -1018,3 +1018,8 @@ DevMode UI improvements svn merge --ignore-ancestry -c7148 \ https://google-web-toolkit.googlecode.com/svn/trunk/ . + +tr...@7150 was merged into this branch + Got rid of port-guessing logic. We now use setStartupURLs as our init hook. + svn merge --ignore-ancestry -c7150 https://google-web-toolkit.googlecode.com/svn/trunk . + -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Comment on GWT_2_0_RC in google-web-toolkit
Comment by neo.huma...@gmail.com:
YES! You CANNOT use the google g-icon web app run menu, you need a plain
jane java application runner, with main class com.google.gwt.dev.DevMode
Make sure you have the usual program arguments for a gwt project; mine are:
-port
-startupUrl /
ai.yx.xSeed
I have / set to a welcome servlet in web.xml, and my gwt project is
ai.yx.xSeed
If you want to use appengine, you will also need to add the program
arguments and vm arguments I mentioned in the post above. ALSO, if you do
NOT use appengine, leave the working directory at default. If you DO use
appengine, add /war to whatever your default directory is... My project
xBook uses ${workspace_loc:xBook}/war
If you absolutely can't get it to go, just download ms2 from the deprecated
dl page, and you can go ahead and use the old google-plugin launch
configuration.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/GWT_2_0_RC
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Comment on GWT_2_0_RC in google-web-toolkit
Comment by a.revolution.ultra.blue:
YES! You CANNOT use the google g-icon web app run menu, you need a plain
jane java application runner, with main class com.google.gwt.dev.DevMode?
Make sure you have the usual program arguments for a gwt project; mine are:
-port -startupUrl / ai.yx.xSeed
I have / set to a welcome servlet in web.xml, and my gwt project is
ai.yx.xSeed
If you want to use appengine, you will also need to add the program
arguments and vm arguments I mentioned in the post above. ALSO, if you do
NOT use appengine, leave the working directory at default. If you DO use
appengine, add /war to whatever your default directory is... My project
xBook uses ${workspace_loc:xBook}/war
If you absolutely can't get it to go, just download ms2 from the deprecated
dl page, and you can go ahead and use the old google-plugin launch
configuration.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/GWT_2_0_RC
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Comment on GWT_2_0_RC in google-web-toolkit
Comment by neo.huma...@gmail.com: Oh ya, I also have a 1.2 release candidate of the google plugin installed. It's mentioned somewhere above, and I deinstalled the old one before dropping the new one in... But it didn't fully uninstall so I'm not really sure. If you still have issues after switching runner types, check this wiki for the rc plugin link. For more information: http://code.google.com/p/google-web-toolkit/wiki/GWT_2_0_RC -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
