[gwt-contrib] Re: Add ProxySerializer API to provide EntityProxy persistence primitives. (issue1148801)
The change to AbstractRequestContext is almost entirely code-moves. Several private methods were made package-protected and makePayload() was split into smaller methods. In order to exercise the ProxySerializer as much as possible, all return values in RequestFactoryTest are serialized locally and then a new instance is reconstructed from the saved data. http://gwt-code-reviews.appspot.com/1148801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Add ProxySerializer API to provide EntityProxy persistence primitives. (issue1148801)
Reviewers: rchandia, cramsdale, Description: Add ProxySerializer API to provide EntityProxy persistence primitives. Issue 5523. http://code.google.com/p/google-web-toolkit/wiki/RequestFactory_2_1_1 Patch by: bobv Review by: rchandia, cramsdale Please review this at http://gwt-code-reviews.appspot.com/1148801/show Affected files: M user/src/com/google/gwt/autobean/server/SimpleBeanHandler.java M user/src/com/google/gwt/autobean/shared/AutoBeanUtils.java A user/src/com/google/gwt/requestfactory/shared/DefaultProxyStore.java A user/src/com/google/gwt/requestfactory/shared/ProxySerializer.java A user/src/com/google/gwt/requestfactory/shared/ProxyStore.java M user/src/com/google/gwt/requestfactory/shared/RequestFactory.java M user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java M user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestFactory.java M user/src/com/google/gwt/requestfactory/shared/impl/IdFactory.java A user/src/com/google/gwt/requestfactory/shared/impl/ProxySerializerImpl.java M user/src/com/google/gwt/requestfactory/shared/impl/ValueProxyCategory.java M user/super/com/google/gwt/requestfactory/super/com/google/gwt/requestfactory/shared/impl/MessageFactoryHolder.java M user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java M user/test/com/google/gwt/requestfactory/client/RequestFactoryTestBase.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9275 committed - Edited wiki page RequestFactory_2_1_1 through web user interface.
Revision: 9275 Author: b...@google.com Date: Tue Nov 23 18:08:23 2010 Log: Edited wiki page RequestFactory_2_1_1 through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=9275 Modified: /wiki/RequestFactory_2_1_1.wiki === --- /wiki/RequestFactory_2_1_1.wiki Mon Nov 22 12:27:50 2010 +++ /wiki/RequestFactory_2_1_1.wiki Tue Nov 23 18:08:23 2010 @@ -32,17 +32,22 @@ * (Issue 5111) Improve integration with arbitrary backends * *New API* The `ServiceLayer` API used by the request processor can be arbitrarily decorated via a `ServiceLayerDecorator`. * *New API* A `Locator` can be specified for individual proxy types to remove the need for `findFoo()`, `getId()`, and `getVersion()` methods on the domain type. - -= What's in review = - * (Issue 5111) Bulk operations in ServiceLayer API * This should allow for better datastore query planning. * (Issue 5512) Fix for covariant return types in the domain API * (Issue 5134) Ensure that RequestFactory interfaces can be extended + += What's in review = + + * (Issue 5523) Client-side EntityProxy persistence +* *New API* A `ProxySerializer` can be retrieved from the `RequestFactory` interface to allow `EntityProxy` and `ValueProxy` objects to be serialized into a `ProxyStore`. + * The `ProxyStore` API is essentially a string:string map and it would be trivial to write a implementation based on an HTML `Storage` object. +* *New API* The `DefaultProxyStore` is a simple in-memory store that can encode its contents into a JSON object literal. + * It would be possible to pre-seed a host page using this store. + = What's coming = * (Issue 5550) Refactor the Codex types to make them injectable. - * (Issue 5523) Client-side caching of requests and EntityProxy persistence = Add to 2.1.1 smoke testing = * The server components of RequestFactory have been completely rewritten. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update JUnit from DeferredCommand to Scheduler. (issue1145801)
Sorry, should be fixed now. http://gwt-code-reviews.appspot.com/1145801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix to allow devmode exceptions to be reported back from a client. (issue1147801)
http://gwt-code-reviews.appspot.com/1147801/diff/1/2 File user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java (right): http://gwt-code-reviews.appspot.com/1147801/diff/1/2#newcode252 user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java:252: SerializationStreamFactory fac = (SerializationStreamFactory) junitHost; This is client code, that's a server-side class. http://gwt-code-reviews.appspot.com/1147801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Factors out TypeOracleMediator.computeBinaryClassName() into a separate class file. (issue1144801)
http://gwt-code-reviews.appspot.com/1144801/diff/6001/7001
File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right):
http://gwt-code-reviews.appspot.com/1144801/diff/6001/7001#newcode33
dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:33: public
String computeBinaryClassName() {
So... my comment was going to be to rename this to getBinaryName().
Then I saw getQualfiedBinaryName(), and I was like... wait, what?
Shouldn't these basically be the same thing? Our API makes me cry.
http://gwt-code-reviews.appspot.com/1144801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix to allow devmode exceptions to be reported back from a client. (issue1147801)
http://gwt-code-reviews.appspot.com/1147801/diff/1/2 File user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java (right): http://gwt-code-reviews.appspot.com/1147801/diff/1/2#newcode252 user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java:252: SerializationStreamFactory fac = (SerializationStreamFactory) junitHost; wouldn't it be better to query the corresponding SerilizationPolicy.validateSerialize(ex.getClass())? http://gwt-code-reviews.appspot.com/1147801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update JUnit from DeferredCommand to Scheduler. (issue1145801)
LGTM.
FYI rietveld is unhappy with the patch for some reason: it's giving me
"error: old chunk mismatch" if I try to view the diff there.
On Tue, Nov 23, 2010 at 5:31 PM, wrote:
> Reviewers: conroy,
>
> Message:
> Because DeferredCommand is deprecated.
>
>
>
> Please review this at http://gwt-code-reviews.appspot.com/1145801/show
>
> Affected files:
>
>
> user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
>
>
> Index:
> user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
> diff --git
> a/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
> b/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
> index
> 4bcca0b7790ce6da85364c676615381e963cfc02..882a22a82e957fcfa1d919acfd11764dede08ed4
> 100644
> ---
> a/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
> +++
> b/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
> @@ -17,14 +17,13 @@ package com.google.gwt.junit.client.impl;
>
> import com.google.gwt.core.client.EntryPoint;
> import com.google.gwt.core.client.GWT;
> +import com.google.gwt.core.client.Scheduler;
> import com.google.gwt.http.client.UrlBuilder;
> import com.google.gwt.junit.client.GWTTestCase;
> import com.google.gwt.junit.client.impl.JUnitHost.ClientInfo;
> import com.google.gwt.junit.client.impl.JUnitHost.InitialResponse;
> import com.google.gwt.junit.client.impl.JUnitHost.TestBlock;
> import com.google.gwt.junit.client.impl.JUnitHost.TestInfo;
> -import com.google.gwt.user.client.Command;
> -import com.google.gwt.user.client.DeferredCommand;
> import com.google.gwt.user.client.Timer;
> import com.google.gwt.user.client.Window;
> import com.google.gwt.user.client.rpc.AsyncCallback;
> @@ -252,7 +251,7 @@ public abstract class GWTRunner implements EntryPoint {
> ++currentTestIndex;
> if (currentTestIndex < currentBlock.getTests().length) {
> // Run the next test after a short delay.
> - DeferredCommand.addCommand(new Command() {
> + Scheduler.get().scheduleDeferred(new Scheduler.ScheduledCommand() {
> public void execute() {
> doRunTest();
> }
>
>
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Factors out TypeOracleMediator.computeBinaryClassName() into a separate class file. (issue1144801)
updated patch
http://gwt-code-reviews.appspot.com/1144801/diff/1/3
File dev/core/src/com/google/gwt/dev/javac/TypeUtils.java (right):
http://gwt-code-reviews.appspot.com/1144801/diff/1/3#newcode28
dev/core/src/com/google/gwt/dev/javac/TypeUtils.java:28: public class
TypeUtils {
On 2010/11/23 21:40:30, scottb wrote:
Shouldn't this be in com.google.gwt.core.ext(.typeinfo?) if it's meant
to be
called from Generators?
Yes, but we don't need a utility class anymore...
http://gwt-code-reviews.appspot.com/1144801/diff/1/3#newcode37
dev/core/src/com/google/gwt/dev/javac/TypeUtils.java:37: public static
String computeBinaryClassName(JType type) {
On 2010/11/23 21:40:30, scottb wrote:
Should this just be an instance method on JType?
Done.
http://gwt-code-reviews.appspot.com/1144801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Factors out TypeOracleMediator.computeBinaryClassName() into a separate class file. (issue1144801)
http://gwt-code-reviews.appspot.com/1144801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fix to allow devmode exceptions to be reported back from a client. (issue1147801)
Reviewers: conroy,
Message:
When I converted JUnit to use normal serialization to transmit
exceptions, I introduced a problem. In DevMode, exceptions can get into
the client space from the hosting environment, such as
HostedModeException. Because these types are not visible to the client,
they can't be serialized. This works around the issue by using a
known-good exception type.
Please review this at http://gwt-code-reviews.appspot.com/1147801/show
Affected files:
M
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
Index:
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
diff --git
a/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
b/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
index
882a22a82e957fcfa1d919acfd11764dede08ed4..1b174211ff36a1f5fb05be864579fe0881f66908
100644
---
a/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
+++
b/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
@@ -27,6 +27,9 @@ import
com.google.gwt.junit.client.impl.JUnitHost.TestInfo;
import com.google.gwt.user.client.Timer;
import com.google.gwt.user.client.Window;
import com.google.gwt.user.client.rpc.AsyncCallback;
+import com.google.gwt.user.client.rpc.SerializationException;
+import com.google.gwt.user.client.rpc.SerializationStreamFactory;
+import com.google.gwt.user.client.rpc.SerializationStreamWriter;
import com.google.gwt.user.client.rpc.ServiceDefTarget;
import java.util.HashMap;
@@ -245,7 +248,23 @@ public abstract class GWTRunner implements EntryPoint {
if (result != null && failureMessage != null) {
RuntimeException ex = new RuntimeException(failureMessage);
result.setException(ex);
-}
+} else if (!GWT.isProdMode() && result.getException() != null) {
+ SerializationStreamFactory fac = (SerializationStreamFactory)
junitHost;
+ SerializationStreamWriter writer = fac.createStreamWriter();
+ Throwable ex = result.getException();
+ try {
+writer.writeObject(ex);
+ } catch (SerializationException e) {
+/*
+ * Probably a dev mode exception that isn't client-side
serializable.
+ * Send it as a plain old Exception instead.
+ */
+StackTraceElement[] st = ex.getStackTrace();
+ex = new Exception(ex.toString());
+ex.setStackTrace(st);
+result.setException(ex);
+ }
+}
TestInfo currentTest = getCurrentTest();
currentResults.put(currentTest, result);
++currentTestIndex;
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Remove the implementation from GWTTestCase checkpoints. (issue1146801)
Reviewers: conroy, Message: Been deprecated for a while, time to remove the implementation. Please review this at http://gwt-code-reviews.appspot.com/1146801/show Affected files: M user/src/com/google/gwt/junit/client/GWTTestCase.java M user/src/com/google/gwt/junit/client/impl/JUnitResult.java M user/src/com/google/gwt/junit/server/JUnitHostImpl.java M user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/GWTTestCase.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Update JUnit from DeferredCommand to Scheduler. (issue1145801)
Reviewers: conroy,
Message:
Because DeferredCommand is deprecated.
Please review this at http://gwt-code-reviews.appspot.com/1145801/show
Affected files:
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
Index:
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
diff --git
a/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
b/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
index
4bcca0b7790ce6da85364c676615381e963cfc02..882a22a82e957fcfa1d919acfd11764dede08ed4
100644
---
a/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
+++
b/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
@@ -17,14 +17,13 @@ package com.google.gwt.junit.client.impl;
import com.google.gwt.core.client.EntryPoint;
import com.google.gwt.core.client.GWT;
+import com.google.gwt.core.client.Scheduler;
import com.google.gwt.http.client.UrlBuilder;
import com.google.gwt.junit.client.GWTTestCase;
import com.google.gwt.junit.client.impl.JUnitHost.ClientInfo;
import com.google.gwt.junit.client.impl.JUnitHost.InitialResponse;
import com.google.gwt.junit.client.impl.JUnitHost.TestBlock;
import com.google.gwt.junit.client.impl.JUnitHost.TestInfo;
-import com.google.gwt.user.client.Command;
-import com.google.gwt.user.client.DeferredCommand;
import com.google.gwt.user.client.Timer;
import com.google.gwt.user.client.Window;
import com.google.gwt.user.client.rpc.AsyncCallback;
@@ -252,7 +251,7 @@ public abstract class GWTRunner implements EntryPoint {
++currentTestIndex;
if (currentTestIndex < currentBlock.getTests().length) {
// Run the next test after a short delay.
- DeferredCommand.addCommand(new Command() {
+ Scheduler.get().scheduleDeferred(new Scheduler.ScheduledCommand() {
public void execute() {
doRunTest();
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add support for touch events for supported mobile webkit platforms. (issue867801)
On 2010/11/23 21:08:03, fredsa wrote: LGTM http://gwt-code-reviews.appspot.com/867801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Factors out TypeOracleMediator.computeBinaryClassName() into a separate class file. (issue1144801)
http://gwt-code-reviews.appspot.com/1144801/diff/1/3
File dev/core/src/com/google/gwt/dev/javac/TypeUtils.java (right):
http://gwt-code-reviews.appspot.com/1144801/diff/1/3#newcode28
dev/core/src/com/google/gwt/dev/javac/TypeUtils.java:28: public class
TypeUtils {
Shouldn't this be in com.google.gwt.core.ext(.typeinfo?) if it's meant
to be called from Generators?
http://gwt-code-reviews.appspot.com/1144801/diff/1/3#newcode37
dev/core/src/com/google/gwt/dev/javac/TypeUtils.java:37: public static
String computeBinaryClassName(JType type) {
Should this just be an instance method on JType?
http://gwt-code-reviews.appspot.com/1144801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Factors out TypeOracleMediator.computeBinaryClassName() into a separate class file. (issue1144801)
This is a mechanical change - I am working on an alternate implementation of TypeOracleMediator and this static method is needed in lots of places, not just in building the type oracle. http://gwt-code-reviews.appspot.com/1144801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Factors out TypeOracleMediator.computeBinaryClassName() into a separate class file. (issue1144801)
Reviewers: tobyr, jbrosenberg, scottb, Description: Factors out TypeOracleMediator.computeBinaryClassName() into a separate class file. This function doesn't really have anything to do with the type oracle mediator. Moving it gets rid of most code references to the TypeOracleMediator class. This change is in preparation for some refactoring TypeOracleMediator and friends. Please review this at http://gwt-code-reviews.appspot.com/1144801/show Affected files: M dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java A dev/core/src/com/google/gwt/dev/javac/TypeUtils.java M user/src/com/google/gwt/rpc/rebind/RpcProxyCreator.java M user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java M user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java M user/src/com/google/gwt/user/rebind/rpc/SerializationUtils.java M user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add support for touch events for supported mobile webkit platforms. (issue867801)
http://gwt-code-reviews.appspot.com/867801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes two DevMode issues: (issue1140801)
http://gwt-code-reviews.appspot.com/1140801/diff/6001/7002 File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java (right): http://gwt-code-reviews.appspot.com/1140801/diff/6001/7002#newcode687 dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:687: JMethod found = cls.findMethod(meth.getName(), meth.getParameterTypes()); On 2010/11/23 18:11:48, scottb wrote: Should this be comparing based on erased types of both? That's a great question. I don't know without investigating. I'll poke around soon. http://gwt-code-reviews.appspot.com/1140801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes two DevMode issues: (issue1140801)
LGTM http://gwt-code-reviews.appspot.com/1140801/diff/6001/7002 File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java (right): http://gwt-code-reviews.appspot.com/1140801/diff/6001/7002#newcode687 dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:687: JMethod found = cls.findMethod(meth.getName(), meth.getParameterTypes()); Should this be comparing based on erased types of both? http://gwt-code-reviews.appspot.com/1140801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Comment on Editors in google-web-toolkit
On Tue, Nov 23, 2010 at 11:18 AM, wrote:
> Comment by vinays.work:
>
> I am seriously disappointed with the Editor framework. What we need is a
> Bean Binding framework much like those that have existed in Swing. You just
> associate the bean property with the widget and the interchange of UI value
> with the bean needs to be automatic. JSF has a pretty effective Bean Binding
> framework as well. As a developer, your work needs to get minimized. Here,
> it is a silly mapping scheme that results in little benefit. I was expecting
> more from Google.
the values you have in your beans and the UI are bound. It's just by
default the paths to the properties are matched with what's in the UI
by default. When you call driver.edit(someObjectGraph);, or
display(), those values are filled in the UI. If you save from the
driver, all the values from the UI will make it back to your beans.
>
> The framework must also have bindings with tables, where in, you specify the
> List as associated with a Table and the information exchange is automatic
> - much the same way as:
This is already possible. See ListEditor and HasDataEditor.
HasDataEditor is an adapter for any HasData implementer. CellTable
being an implementation of HasData, you already have that.
interface User extends EntityProxy {
// ...
List addresses;
}
interface Address extends EntityProxy {
//...
}
class UserEditor extends Composite {
// ...
HasDataEditor addresses = HasDataEditor.of(cellTable); //
named the same otherwise use @Path, assuming cellTable here is from
uibinder
}
When you bind an instance of a UserEditor to a user, addresses in
UserEditor will have the data from the user address list. If you
modify this list via its CellTable, when you save, the entity proxy
will have the modifications too.
>
> http://publicobject.com/glazedlists/
>
>
> Vaadin Toolkit - build on the top of GWT - has data binding containers,
> which can be used as datasources in ... that the way of programming is like
> programming any Swing application
>
I think the editor framework is still missing a bit of
documentation/samples, mainly dealing with how you pull in object
graphs using information provided by the editor driver, but yes, what
you're talking about is all possible.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: IE devmode plugin: 64 bits support end-to-end, build fixes & cleanup, other polishing items. (issue1116801)
On 2010/11/23 17:07:10, fabiomfv wrote: LGTM if LGT jat&knorton http://gwt-code-reviews.appspot.com/1116801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: IE devmode plugin: 64 bits support end-to-end, build fixes & cleanup, other polishing items. (issue1116801)
http://gwt-code-reviews.appspot.com/1116801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Comment on Editors in google-web-toolkit
Comment by vinays.work: I am seriously disappointed with the Editor framework. What we need is a Bean Binding framework much like those that have existed in Swing. You just associate the bean property with the widget and the interchange of UI value with the bean needs to be automatic. JSF has a pretty effective Bean Binding framework as well. As a developer, your work needs to get minimized. Here, it is a silly mapping scheme that results in little benefit. I was expecting more from Google. The framework must also have bindings with tables, where in, you specify the List as associated with a Table and the information exchange is automatic - much the same way as: http://publicobject.com/glazedlists/ Vaadin Toolkit - build on the top of GWT - has data binding containers, which can be used as datasources in ... that the way of programming is like programming any Swing application For more information: http://code.google.com/p/google-web-toolkit/wiki/Editors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixing JavaDoc warnings in Cell Widgets. (issue1143801)
LGTM With the theme of fixing translater->translator, could CheckboxEventTranslater be changed to CheckboxEventTranslator as well? http://gwt-code-reviews.appspot.com/1143801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: First-pass for adding HTML5's Canvas. (issue1082801)
http://gwt-code-reviews.appspot.com/1082801/diff/101001/102006 File user/src/com/google/gwt/canvas/dom/client/CanvasPixelArray.java (right): http://gwt-code-reviews.appspot.com/1082801/diff/101001/102006#newcode54 user/src/com/google/gwt/canvas/dom/client/CanvasPixelArray.java:54: * Most browsers will clamp this value to the range 0...255 that is not enforced here. On 2010/11/20 23:22:14, jlabanca wrote: "Most browser will clamp this value to the range 0...255, but that is not enforced by this implementation. Done. http://gwt-code-reviews.appspot.com/1082801/diff/101001/102006#newcode57 user/src/com/google/gwt/canvas/dom/client/CanvasPixelArray.java:57: this[i] = value; On 2010/11/20 23:22:14, jlabanca wrote: Add comment explaining why we don't limit the range: // FF35 doesn't clamp the range. We don't clamp it manually to maximize performance. Done. http://gwt-code-reviews.appspot.com/1082801/diff/101001/102020 File user/test/com/google/gwt/canvas/dom/client/Context2dTest.java (right): http://gwt-code-reviews.appspot.com/1082801/diff/101001/102020#newcode242 user/test/com/google/gwt/canvas/dom/client/Context2dTest.java:242: // are disabled for FF 3.0 and before. On 2010/11/20 23:22:14, jlabanca wrote: From what I read, this only happens if the image is from a different domain than the page. Still, I don't know of any way around it. You are right, it was a relic of a deleted test that pulled an external image. That said, I re-ran the test in FF3.0 and the createImageData method is not available, so I've kept the gate but updated the comments. (https://developer.mozilla.org/En/HTML/Canvas/Pixel_manipulation_with_canvas#Creating_an_ImageData_object) http://gwt-code-reviews.appspot.com/1082801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: First-pass for adding HTML5's Canvas. (issue1082801)
http://gwt-code-reviews.appspot.com/1082801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Enum Ordinalization Optimization (revised) (issue1133801)
Ok, lgtm ( :) ) On Mon, Nov 22, 2010 at 1:09 PM, Jason Rosenberg wrote: > Ray, > > Good question, but yeah, that case will be handled too. Leaf types > don't get visited for arrays at all (thus the root cause of this > problem). I have added another test case with the Enum[][] > reference, I'll commit that and add to the patch shortly. > > Jason > > On Mon, Nov 22, 2010 at 3:15 PM, wrote: >> >> http://gwt-code-reviews.appspot.com/1133801/diff/1/5 >> File dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java >> (right): >> >> http://gwt-code-reviews.appspot.com/1133801/diff/1/5#newcode650 >> dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java:650: JType >> leafType = aType.getLeafType(); >> Does this handle Enum[][]? I'm forgot how the type remapper works, but >> will it visit the innermost Enum[] separately? >> >> http://gwt-code-reviews.appspot.com/1133801/show >> > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add support for RpcTokens, which, if set, are sent with each RPCRequest to (issue1107801)
LGTM http://gwt-code-reviews.appspot.com/1107801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fixing JavaDoc warnings in Cell Widgets. (issue1143801)
Reviewers: pdr, Description: Fixing JavaDoc warnings in Cell Widgets. Please review this at http://gwt-code-reviews.appspot.com/1143801/show Affected files: M user/src/com/google/gwt/user/cellview/client/AbstractHasData.java M user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImpl.java M user/src/com/google/gwt/view/client/CellPreviewEvent.java M user/src/com/google/gwt/view/client/DefaultSelectionEventManager.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Reduces the size of the soyc report by combining many s (issue1139801)
LGTM.
This is another great change - thanks!
http://gwt-code-reviews.appspot.com/1139801/diff/1/2
File dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
(right):
http://gwt-code-reviews.appspot.com/1139801/diff/1/2#newcode789
dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java:789:
outFile.println("" +
className + "");
Longer than 100 chars?
http://gwt-code-reviews.appspot.com/1139801/diff/1/2#newcode1445
dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java:1445:
String drillDownFileName = classesInPackageFileName(breakdown,
getPermutationId()) + "#" + filename(packageName);
100 chars?
http://gwt-code-reviews.appspot.com/1139801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes two DevMode issues: (issue1140801)
http://gwt-code-reviews.appspot.com/1140801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add support for RpcTokens, which, if set, are sent with each RPCRequest to (issue1107801)
http://gwt-code-reviews.appspot.com/1107801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add support for RpcTokens, which, if set, are sent with each RPCRequest to (issue1107801)
http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005 File user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java (right): http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005#newcode43 user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java:43: RpcToken getRpcToken(); On 2010/11/23 00:17:28, jat wrote: Ok, how about extracting the new methods into an interface HasRpcToken. It shouldn't be much of a burden on calling code anyway. Done. http://gwt-code-reviews.appspot.com/1107801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
