http://gwt-code-reviews.appspot.com/1082801/diff/101001/102006 File user/src/com/google/gwt/canvas/dom/client/CanvasPixelArray.java (right):
http://gwt-code-reviews.appspot.com/1082801/diff/101001/102006#newcode54 user/src/com/google/gwt/canvas/dom/client/CanvasPixelArray.java:54: * Most browsers will clamp this value to the range 0...255 that is not enforced here. On 2010/11/20 23:22:14, jlabanca wrote:
"Most browser will clamp this value to the range 0...255, but that is
not
enforced by this implementation.
Done. http://gwt-code-reviews.appspot.com/1082801/diff/101001/102006#newcode57 user/src/com/google/gwt/canvas/dom/client/CanvasPixelArray.java:57: this[i] = value; On 2010/11/20 23:22:14, jlabanca wrote:
Add comment explaining why we don't limit the range: // FF35 doesn't clamp the range. We don't clamp it manually to
maximize
performance.
Done. http://gwt-code-reviews.appspot.com/1082801/diff/101001/102020 File user/test/com/google/gwt/canvas/dom/client/Context2dTest.java (right): http://gwt-code-reviews.appspot.com/1082801/diff/101001/102020#newcode242 user/test/com/google/gwt/canvas/dom/client/Context2dTest.java:242: // are disabled for FF 3.0 and before. On 2010/11/20 23:22:14, jlabanca wrote:
From what I read, this only happens if the image is from a different
domain
than the page. Still, I don't know of any way around it.
You are right, it was a relic of a deleted test that pulled an external image. That said, I re-ran the test in FF3.0 and the createImageData method is not available, so I've kept the gate but updated the comments. (https://developer.mozilla.org/En/HTML/Canvas/Pixel_manipulation_with_canvas#Creating_an_ImageData_object) http://gwt-code-reviews.appspot.com/1082801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
