Re: [gwt-contrib] Re: Add README step to use the Google Web Toolkit SDK in the gwt-user project so that users can run ... (issue966802)
Actually, I'm not sure that this is accurate. I just tried it out against gwt-user and gwt-dev with natures and builders on in a clean eclipse Helios install (no GPE) and I did not see any exceptions thrown. There were no visible exceptions and the error log was not updated. It seems worth it to take a look and see if it is eclipse version specific. On Wed, Nov 24, 2010 at 10:31 AM, rda...@google.com wrote: I think that jat is right - if you have a builder defined on your project that Eclipse does not know about, it will throw an exception. For now, let's go with this update to the README. I think, as a future step, we should add the natures and builders to the gwt-user and gwt-dev project, and make it a necessary step for them to install GPE. http://gwt-code-reviews.appspot.com/966802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- Miguel -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Issue 5474: RequestFactory response encoding (issue1154801)
Reviewers: bobv, Description: Fix for RequestFactoryServlet and unit test. Also fixed testUserInfo in RequestFactoryTest, which was not asynchronous (and therefore, I believe, wasn't actually testing anything). The tests use finishTest and not finishTestAndReset because they don't use SimpleFooRequest and SimpleBarRequest, so they don't need the extra reset() requests. Please review this at http://gwt-code-reviews.appspot.com/1154801/show Affected files: user/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java user/test/com/google/gwt/requestfactory/server/Simple.java user/test/com/google/gwt/requestfactory/shared/SimpleRequest.java user/test/com/google/gwt/requestfactory/shared/SimpleRequestFactory.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Comment on OverlayTypes in google-web-toolkit
Comment by ltearno: This is too bad (at the end of the document) : The implementation of overlay types in GWT 1.5 does not support Generators defining new JSO subtypes (due to the need to redefine or otherwise extend JavaScriptObject$ during subsequent compilation). This restriction is still in place. Being able to generate sub classes of JavaScriptObject would be so coool For more information: http://code.google.com/p/google-web-toolkit/wiki/OverlayTypes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: r9277 committed - Removing reference to designTime.getProvidedField()
Konstantin, we have a separate release branch for 2.1.1 that is forked from
trunk. Your change has not been integrated into that branch, so when I
picked up a piece of your code in UiBinderWriter it broke testing in the
release branch. This change was only applied to the release branch, not to
trunk, so your code should be intact. Please let me know if you're seeing
any issues with trunk.
Thanks,
Stephanie
On Thu, Nov 25, 2010 at 3:22 PM, Konstantin.Scheglov
konstantin.scheg...@gmail.com wrote:
Then other pieces of the change were not integrated, as this was
preventing
the 2.1 branch from building.
I see method getProvidedField() in DesignTimeUtils in SVN trunk, so
I'm not sure what could be missed.
I also regularly build GWT from project in SVN without build
problems.
On Nov 25, 2010 8:12 AM, Konstantin.Scheglov
konstantin.scheg...@gmail.com wrote:
No!
This change breaks @UiField(provided=true) support in GWT Designer,
important feature which we want to support for GWT 2.1.1.
On 24 ноя, 19:55, codesite-nore...@google.com wrote:
Revision: 9277
Author: gwt.mirror...@gmail.com
Date: Wed Nov 24 08:54:59 2010
Log: Removing reference to designTime.getProvidedField()
http://code.google.com/p/google-web-toolkit/source/detail?r=9277
Modified:
/releases/2.1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
===
---
/releases/2.1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
Fri Nov 19 05:49:25 2010
+++
/releases/2.1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
Wed Nov 24 08:54:59 2010
@@ -1093,15 +1093,8 @@
// TODO why can this be null?
if (fieldWriter != null) {
- String initializer;
- if (designTime.isDesignTime()) {
-String typeName =
ownerField.getType().getRawType().getQualifiedSourceName();
-initializer = designTime.getProvidedField(typeName,
-ownerField.getName());
- } else {
-initializer = formatCode(owner.%1$s, fieldName);
- }
- fieldManager.lookup(fieldName).setInitializer(initializer);
+ fieldManager.lookup(fieldName).setInitializer(
+ formatCode(owner.%1$s, fieldName));
}
}
}
@@ -1215,4 +1208,3 @@
designTime.addDeclarations(w);
}
}
-
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: r9277 committed - Removing reference to designTime.getProvidedField()
Konstantin, we have a separate release branch for 2.1.1 that is forked from
trunk. Your change has not been integrated into that branch, so when I
picked up a piece of your code in UiBinderWriter it broke testing in the
release branch. This change was only applied to the release branch, not to
trunk, so your code should be intact. Please let me know if you're seeing
any issues with trunk.
Current state in trunk is valid.
Will final version of GWT 2.1.1 which users will download still have
design time tweaks of UiBinderWriter?
Thanks,
Stephanie
On Thu, Nov 25, 2010 at 3:22 PM, Konstantin.Scheglov
konstantin.scheg...@gmail.com wrote:
Then other pieces of the change were not integrated, as this was
preventing
the 2.1 branch from building.
I see method getProvidedField() in DesignTimeUtils in SVN trunk, so
I'm not sure what could be missed.
I also regularly build GWT from project in SVN without build
problems.
On Nov 25, 2010 8:12 AM, Konstantin.Scheglov
konstantin.scheg...@gmail.com wrote:
No!
This change breaks @UiField(provided=true) support in GWT Designer,
important feature which we want to support for GWT 2.1.1.
On 24 ноя, 19:55, codesite-nore...@google.com wrote:
Revision: 9277
Author: gwt.mirror...@gmail.com
Date: Wed Nov 24 08:54:59 2010
Log: Removing reference to designTime.getProvidedField()
http://code.google.com/p/google-web-toolkit/source/detail?r=9277
Modified:
/releases/2.1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
===
---
/releases/2.1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
Fri Nov 19 05:49:25 2010
+++
/releases/2.1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
Wed Nov 24 08:54:59 2010
@@ -1093,15 +1093,8 @@
// TODO why can this be null?
if (fieldWriter != null) {
- String initializer;
- if (designTime.isDesignTime()) {
-String typeName =
ownerField.getType().getRawType().getQualifiedSourceName();
-initializer = designTime.getProvidedField(typeName,
-ownerField.getName());
- } else {
-initializer = formatCode(owner.%1$s, fieldName);
- }
-
fieldManager.lookup(fieldName).setInitializer(initializer);
+ fieldManager.lookup(fieldName).setInitializer(
+ formatCode(owner.%1$s, fieldName));
}
}
}
@@ -1215,4 +1208,3 @@
designTime.addDeclarations(w);
}
}
-
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
Konstantin Scheglov,
Google, Inc.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
