[gwt-contrib] Add Traversable Resolver and UnknownProviderBootstrapCompile tests (issue1510804)

[nchalko]

Reviewers: rchandia,

Description:
Add Traversable Resolver and UnknownProviderBootstrapCompile tests
[JSR 303 TCK Result] 154 of 257 (59.92%) Pass with 26 Failures and 7
Errors.

Please review this at http://gwt-code-reviews.appspot.com/1510804/

Affected files:
  A user/test/com/google/gwt/validation/tck/TraversableResolverGwtSuite.java
  M user/test/com/google/gwt/validation/tck/ValidationGwtSuite.java
  A  
user/test/org/hibernate/jsr303/tck/tests/traversableresolver/TckTest.gwt.xml
  A  
user/test/org/hibernate/jsr303/tck/tests/traversableresolver/TckTestValidatorFactory.java
  A  
user/test/org/hibernate/jsr303/tck/tests/traversableresolver/TraversableResolverGwtTest.java
  A  
user/test/org/hibernate/jsr303/tck/tests/validation/UnknownProviderBootstrapCompileTest.gwt.xml
  A  
user/test/org/hibernate/jsr303/tck/tests/validation/UnknownProviderBootstrapCompileTest.java



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] GWT Code Review [Rietveld]: Better, faster stronger

[Ray Ryan]

In the last couple of hours we migrated
http://gwt-code-reviews.appspot.com/to a High
Replication 
Datastore.
This should be transparent to you, except for much reduced latency.[1]

Huge thanks to Fred Sauer, who did all the work.

Enjoy!

rjrjr

[1] Actually, users of the chat notification feature will need to reset that
preference to make it go again. So far this is the only hiccup we've
noticed.

   - visit http://gwt-code-reviews.appspot.com/settings
   - uncheck Notify by chat, save settings
   - recheck Notify by chat, save settings
   - accept the new chat invite from the new app id

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: GWT Code Review planned outage Thursday 4 Aug 2011 5pm ET

[Ray Ryan]

The outage is over. I'll start a new thread explaining what we were up to.

On Thu, Aug 4, 2011 at 1:56 PM, Ray Ryan  wrote:

> http://gwt-code-reviews.appspot.com/ will be read only in five minutes or
> so.
>
>
> On Wed, Aug 3, 2011 at 12:09 PM, Ray Ryan  wrote:
>
>> We will be putting the Rietveld server at
>> http://gwt-code-reviews.appspot.com/ into read-only mode for a few hours
>> at about 5pm Eastern Time tomorrow, Thursday August 4th, to deal with some
>> maintenance.
>>
>> rjrjr
>>
>>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix typo (issue1497807)

[Fred Sauer]

reply-all from to (using old address re...@gwt-code-reviews.appspotmail.com)

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix typo (issue1497807)

[Fred Sauer]

reply-all from to (using new address
re...@gwt-code-reviews-hr.appspotmail.com)

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix typo (issue1497807)

[fredsa]

2nd test message.


http://gwt-code-reviews.appspot.com/1497807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix typo (issue1497807)

[fredsa]

Test message. Please ignore.

http://gwt-code-reviews.appspot.com/1497807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10496 committed - Add test for Invalid Constraint Definitions....

[codesite-noreply]

Revision: 10496
Author:   gwt.mirror...@gmail.com
Date: Thu Aug  4 14:49:14 2011
Log:  Add test for Invalid Constraint Definitions.

[JSR 303 TCK Result] 152 of 257 (59.14%) Pass with 23 Failures and 7 Errors.

Review at http://gwt-code-reviews.appspot.com/1505806

Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10496

Added:
  
/trunk/user/test/com/google/gwt/validation/tck/InvalidConstraintDefinitionsGwtSuite.java
  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions
  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithParameterStartingWithValidFactory.java
  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithWrongDefaultGroupValueFactory.java
  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithWrongDefaultPayloadValueFactory.java
  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithWrongGroupTypeFactory.java
  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithWrongMessageTypeFactory.java
  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithWrongPayloadClassFactory.java
  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithoutGroupParameterFactory.java
  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithoutMessageParameterFactory.java
  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithoutPayloadParameterFactory.java
  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/InvalidConstraintDefinitionsCompileTest.java
  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/TckTest.gwt.xml

Modified:
 /trunk/user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java

===
--- /dev/null
+++  
/trunk/user/test/com/google/gwt/validation/tck/InvalidConstraintDefinitionsGwtSuite.java	 
Thu Aug  4 14:49:14 2011

@@ -0,0 +1,33 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package com.google.gwt.validation.tck;
+
+import junit.framework.Test;
+
+import  
org.hibernate.jsr303.tck.tests.constraints.invalidconstraintdefinitions.InvalidConstraintDefinitionsCompileTest;

+import org.hibernate.jsr303.tck.util.TckTestSuiteWrapper;
+
+/**
+ * Tck Tests for the {@code constraints invalidconstraintdefinitions}  
package.

+ */
+public class InvalidConstraintDefinitionsGwtSuite {
+  public static Test suite() {
+TckTestSuiteWrapper suite = new TckTestSuiteWrapper(
+"TCK for GWT Validation, constraints invalidconstraintdefinitions  
package");

+suite.addTestSuite(InvalidConstraintDefinitionsCompileTest.class);
+return suite;
+  }
+}
===
--- /dev/null
+++  
/trunk/user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithParameterStartingWithValidFactory.java	 
Thu Aug  4 14:49:14 2011

@@ -0,0 +1,48 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package  
org.hibernate.jsr303.tck.tests.constraints.invalidconstraintdefinitions;

+
+import com.google.gwt.core.client.GWT;
+import com.google.gwt.validation.client.AbstractGwtValidatorFactory;
+import com.google.gwt.validation.client.GwtValidation;
+import com.google.gwt.validation.client.impl.AbstractGwtValidator;
+
+import  
org.hibernate.jsr303.tck.tests.constraints.invalidconstraintdefinit

[gwt-contrib] Re: Add test for Invalid Constraint Definitions. (issue1505806)

[rchandia]

On 2011/08/04 21:02:46, Nick Chalko wrote:

LGTM

http://gwt-code-reviews.appspot.com/1505806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add test for Invalid Constraint Definitions. (issue1505806)

[rchandia]

On 2011/08/04 21:02:46, Nick Chalko wrote:

LGTM

http://gwt-code-reviews.appspot.com/1505806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add test for Invalid Constraint Definitions. (issue1505806)

[rchandia]

On 2011/08/04 21:02:46, Nick Chalko wrote:

LGTM

http://gwt-code-reviews.appspot.com/1505806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add test for Invalid Constraint Definitions. (issue1505806)

[rchandia]

LGTM

http://gwt-code-reviews.appspot.com/1505806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add test for Invalid Constraint Definitions. (issue1505806)

[nchalko]

Reviewers: rchandia,

Description:
Add test for Invalid Constraint Definitions.

[JSR 303 TCK Result] 152 of 257 (59.14%) Pass with 23 Failures and 7
Errors.


Please review this at http://gwt-code-reviews.appspot.com/1505806/

Affected files:
  A  
user/test/com/google/gwt/validation/tck/InvalidConstraintDefinitionsGwtSuite.java
  A  
user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithParameterStartingWithValidFactory.java
  A  
user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithWrongDefaultGroupValueFactory.java
  A  
user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithWrongDefaultPayloadValueFactory.java
  A  
user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithWrongGroupTypeFactory.java
  A  
user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithWrongMessageTypeFactory.java
  A  
user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithWrongPayloadClassFactory.java
  A  
user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithoutGroupParameterFactory.java
  A  
user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithoutMessageParameterFactory.java
  A  
user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/ConstraintDefinitionWithoutPayloadParameterFactory.java
  A  
user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/InvalidConstraintDefinitionsCompileTest.java
  A  
user/test/org/hibernate/jsr303/tck/tests/constraints/invalidconstraintdefinitions/TckTest.gwt.xml

  M user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Support chained requests where the returned proxy type is not reachable from the canonical Reque... (issue1499810)

[rjrjr]

LGTM

http://gwt-code-reviews.appspot.com/1499810/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: GWT Code Review planned outage Thursday 4 Aug 2011 5pm ET

[Ray Ryan]

http://gwt-code-reviews.appspot.com/ will be read only in five minutes or
so.

On Wed, Aug 3, 2011 at 12:09 PM, Ray Ryan  wrote:

> We will be putting the Rietveld server at
> http://gwt-code-reviews.appspot.com/ into read-only mode for a few hours
> at about 5pm Eastern Time tomorrow, Thursday August 4th, to deal with some
> maintenance.
>
> rjrjr
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Support chained requests where the returned proxy type is not reachable from the canonical Reque... (issue1499810)

[bobv]

PTAL


http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java
File
user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java
(right):

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java#newcode54
user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java:54:
return method.invoke(this, args);
On 2011/08/04 18:30:33, rjrjr wrote:

Is this really related to this patch? What's it fixing?


Removed.

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
File
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
(right):

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java#newcode505
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java:505:
AutoBean created;
On 2011/08/04 18:30:33, rjrjr wrote:

So when I append the a CarService request context to a DogService

context, the

car context will know how to make dogs, yes? Are we sure that's

desirable?


I guess I'm asking if it's a side effect of the fix that is not worth

the work

of masking, or if you're taking extra effort to make it happen.



Presuming this side effect is happening because it needs to happen, we

should

explicitly test for it.


Changed createProxy() so that the user-accessible create() method isn't
subject to cross-contamination.  However, there are implementation
limitations in the jre implementation that currently make this
impractical.  Filed issue 6658, since the difference in behavior can be
eliminated after the RfValidator patch lands.

I also changed createProxy() to be a protected method.

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java
File
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java
(right):

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java#newcode38
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java:38:
* rechable proxy types.
On 2011/08/04 18:30:33, rjrjr wrote:

reachable


Done.

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java#newcode91
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java:91:
SimpleFooRequest c3 = c2.append(req.simpleFooRequest());
On 2011/08/04 18:30:33, rjrjr wrote:

Would be easier to read of the context names reflected their type.

barRc1,

fooRc1


Done.

http://gwt-code-reviews.appspot.com/1499810/diff/3002/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
File
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
(right):

http://gwt-code-reviews.appspot.com/1499810/diff/3002/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java#newcode107
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java:107:
public Set appendedContexts;
Changed this to track the RequestContext instances since it's more
general.

http://gwt-code-reviews.appspot.com/1499810/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

[Jeff Larsen]

With my minimal spare time right now I'm working on getting a new library 
based around these Grids, adding more functionality. 

What I've ended up doing is Extending DataGrid and maintaining my own List 
of my own Column implementation. I have a bunch more data that lives in 
Column, its size, some events, if it is visible,  the headers, footers, etc. 
Then I've extended DataGrid to only really accept a List of my own column 
implementation. That way I can easily maintain my own list of Columns and it 
allows for easier state management as eventually my goal will be to allow 
reordering and persisting the Columns. Eventually using gwtquery to allow 
for drag/drop column reordering. 

The reason I bring this up is there is potentially a lot of information that 
could belong inside of Column, especially with the new Table/Header 
builders. I don't really have a problem with sticking the databaseName 
inside Column, my question is why should we just stop databaseColumn, and if 
it continues to get expanded, where does it stop?


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10495 committed - Remove temporary support of deprecated ui:baseInterface attribute....

[codesite-noreply]

Revision: 10495
Author:   gwt.mirror...@gmail.com
Date: Thu Aug  4 12:48:44 2011
Log:  Remove temporary support of deprecated ui:baseInterface attribute.

Review by: rjrjr

http://code.google.com/p/google-web-toolkit/source/detail?r=10495

Modified:
 /trunk/user/src/com/google/gwt/uibinder/rebind/messages/MessagesWriter.java

===
---  
/trunk/user/src/com/google/gwt/uibinder/rebind/messages/MessagesWriter.java	 
Thu Jun  9 09:49:05 2011
+++  
/trunk/user/src/com/google/gwt/uibinder/rebind/messages/MessagesWriter.java	 
Thu Aug  4 12:48:44 2011

@@ -185,13 +185,6 @@
 if (prefix != null) {
   messagesPrefix = prefix;
   String baseInterfaceAttr =  
consumeMessageAttribute("baseMessagesInterface", elem, null);

-  if (baseInterfaceAttr == null) {
-// TODO(jat): temporary compatibility, remove next week
-baseInterfaceAttr = consumeMessageAttribute("baseInterface", elem,  
null);

-if (baseInterfaceAttr != null) {
-  logger.warn(elem, "baseInterface is deprecated, use  
baseMessagesInterface instead");

-}
-  }
   if (baseInterfaceAttr != null) {
 JClassType baseInterfaceType = oracle.findType(baseInterfaceAttr);
 if (baseInterfaceType == null) {

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding a spot for database column name in Column. Allows us to create an updated SQL statement w... (issue1503806)

[Ray Ryan]

You don't have to add a param type if the app data slot is simply of type
object. No one will die if they have to cast the thing. But if the people
who originally requested this feature are willing to back off and maintain a
map instead, is even that much api clutter really warranted?

@portersi, what stopped you from using a custom column class instead of a
map?

On Tue, Aug 2, 2011 at 1:53 PM,  wrote:

> This came up before, and here is the rationale.
>
> If you add an app specific data object to Column, you have to add
> another parameterized type to Column.  That's more verbose, somewhat
> confusing, and it will be Void for most users anyway.  I'm a big fan of
> parameterized types because they make the API feels more bulletproof,
> but I also think parameterized types can be cumbersome if they aren't
> intended to support the most common use cases.
>
> Subclassing Column is good option if you need a lot of app specific
> data.  Yes you have to cast it, but who cares if you're in control of
> which columns go into your table.  In the original design, we envisioned
> people subclassing Column for app specific data.
>
> So, now we're special casing the data store field as a string. But MANY
> databases use String names to describe columns, and its just so
> convenient to have that field accessible from the Column itself. I've
> seen more than a few requests for this feature.  If you are using an SQL
> database, this will probably come in handy.  If you don't need it, don't
> use it, and the compiler should compile it out.
>
>
> On 2011/08/02 20:13:12, rjrjr wrote:
>
>> It's John L's call, but that's certainly my preference.
>>
>
>  On Tue, Aug 2, 2011 at 1:10 PM, John Porter Simons
>>
> wrote:
>
>  > The other way we (me and dramos@) discussed doing this was, in our
>> > CellTable subclass, have a map from Column to String to store these
>>
> database
>
>> > column names. I can update to that and revert this if you like.
>> >
>> >
>> > On Tue, Aug 2, 2011 at 1:01 PM, Ray Ryan 
>>
> wrote:
>
>> >
>> >> I was biting my tongue on this one, but I guess I'll jump in and
>>
> agree,
>
>> >> this smells bad.
>> >>
>> >> @jlabanca, is there no hook in Column or maybe Cell.Context where
>>
> this
>
>> >> kind of app-specific data can be added?
>> >>
>> >> On Tue, Aug 2, 2011 at 12:32 PM, Jeff Larsen
>>
>  wrote:
>
>> >>
>> >>>  I'm inclined to agree with Stephen here. No where else in GWT
>>
> widgetry
>
>> >>> is there a reference to database related things. I don't think
>>
> this is a big
>
>> >>> deal either, but it seems like a more application specific thing
>>
> rather than
>
>> >>> something that belongs inside GWT proper.
>> >>>
>> >>> --
>> >>> http://groups.google.com/**group/Google-Web-Toolkit-**Contributors
>> >>>
>> >>
>> >>
>> >
>>
>
>
>
> http://gwt-code-reviews.**appspot.com/1503806/
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Replace RequestFactoryInterfaceValidator with an annotation-processor-based approach. (issue1503804)

[rjrjr]

LGTM

http://gwt-code-reviews.appspot.com/1503804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Changed the interface used to send metrics to a dashboard application. The (issue1499811)

[tobyr]

LGTM

http://gwt-code-reviews.appspot.com/1499811/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Changed the interface used to send metrics to a dashboard application. The (issue1499811)

[jhumphries]

Reviewers: tobyr,

Description:
Changed the interface used to send metrics to a dashboard application.
The
change allows the notifier implementation to do something at the start
of an
event.

Review by: to...@google.com

Please review this at http://gwt-code-reviews.appspot.com/1499811/

Affected files:
  M dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
  M  
dev/core/src/com/google/gwt/dev/util/log/dashboard/DashboardNotifier.java
  M  
dev/core/src/com/google/gwt/dev/util/log/dashboard/NoOpDashboardNotifier.java
  M  
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java

  M dev/core/test/com/google/gwt/dev/shell/BrowserChannelServerTest.java
  M  
dev/core/test/com/google/gwt/dev/util/log/dashboard/DashboardNotifierFactoryTest.java
  M  
dev/core/test/com/google/gwt/dev/util/log/dashboard/SpeedTracerLoggerTestMockNotifier.java



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix typo (issue1497807)

[fredsa]

committed in r10494

http://gwt-code-reviews.appspot.com/1497807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Support chained requests where the returned proxy type is not reachable from the canonical Reque... (issue1499810)

[rjrjr]

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java
File
user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java
(right):

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java#newcode54
user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java:54:
return method.invoke(this, args);
Is this really related to this patch? What's it fixing?

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
File
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
(right):

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java#newcode505
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java:505:
AutoBean created;
So when I append the a CarService request context to a DogService
context, the car context will know how to make dogs, yes? Are we sure
that's desirable?

I guess I'm asking if it's a side effect of the fix that is not worth
the work of masking, or if you're taking extra effort to make it happen.

Presuming this side effect is happening because it needs to happen, we
should explicitly test for it.

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java
File
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java
(right):

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java#newcode38
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java:38:
* rechable proxy types.
reachable

http://gwt-code-reviews.appspot.com/1499810/diff/1/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java#newcode91
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java:91:
SimpleFooRequest c3 = c2.append(req.simpleFooRequest());
Would be easier to read of the context names reflected their type.
barRc1, fooRc1

http://gwt-code-reviews.appspot.com/1499810/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10494 committed - Fix typo...

[codesite-noreply]

Revision: 10494
Author:   gwt.mirror...@gmail.com
Date: Thu Aug  4 11:18:23 2011
Log:  Fix typo

Fixes issues: 5912

Review at http://gwt-code-reviews.appspot.com/1497807

Review by: unn...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10494

Modified:
 /trunk/user/src/com/google/gwt/regexp/shared/RegExp.java

===
--- /trunk/user/src/com/google/gwt/regexp/shared/RegExp.java	Fri Oct  8  
06:15:38 2010
+++ /trunk/user/src/com/google/gwt/regexp/shared/RegExp.java	Thu Aug  4  
11:18:23 2011

@@ -32,7 +32,7 @@
  * There are a few small incompatibilities between the two implementations.
  * Java-specific constructs in the regular expression syntax (e.g.  
[a-z&&[^bc]],

  * (?<=foo), \A, \Q) work only in the pure Java implementation, not the GWT
- * implementation, and are not rejected by either. Also, the  
Javscript-specific
+ * implementation, and are not rejected by either. Also, the  
Javascript-specific

  * constructs $` and $' in the replacement expression work only in the GWT
  * implementation, not the pure Java implementation, which rejects them.
  */

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10493 committed - Remove CompilationUnit.getSource()....

[codesite-noreply]

Revision: 10493
Author:   gwt.mirror...@gmail.com
Date: Thu Aug  4 11:07:02 2011
Log:  Remove CompilationUnit.getSource().

No longer needed with GwtAstBuidler.

http://gwt-code-reviews.appspot.com/1462807/
Review by: zun...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10493

Modified:
 /trunk/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java
  
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java

 /trunk/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
 /trunk/dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java
 /trunk/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
 /trunk/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
 /trunk/dev/core/test/com/google/gwt/dev/javac/CompilationStateTest.java
  
/trunk/dev/core/test/com/google/gwt/dev/javac/CompilationUnitArchiveTest.java

 /trunk/dev/core/test/com/google/gwt/dev/javac/MockCompilationUnit.java

===
--- /trunk/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java	 
Tue Jun 14 05:20:58 2011
+++ /trunk/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java	 
Thu Aug  4 11:07:02 2011

@@ -41,7 +41,6 @@
   private final CategorizedProblem[] problems;
   private final String resourceLocation;
   private final String resourcePath;
-  private final DiskCacheToken sourceToken;
   private final String typeName;

   /**
@@ -67,7 +66,6 @@
 this.problems = unit.problems;
 this.astToken = unit.astToken;
 this.astVersion = unit.astVersion;
-this.sourceToken = unit.sourceToken;

 // Override these fields
 this.lastModified = lastModified;
@@ -85,7 +83,7 @@
*  serialized AST types.
*/
   @SuppressWarnings("deprecation")
-  CachedCompilationUnit(CompilationUnit unit, long sourceToken, long  
astToken) {

+  CachedCompilationUnit(CompilationUnit unit, long astToken) {
 assert unit != null;
 this.compiledClasses = unit.getCompiledClasses();
 this.contentId = unit.getContentId();
@@ -110,7 +108,6 @@
 }
 this.astToken = new DiskCacheToken(astToken);
 this.astVersion = GwtAstBuilder.getSerializationVersion();
-this.sourceToken = new DiskCacheToken(sourceToken);
   }

   @Override
@@ -147,12 +144,6 @@
   public String getResourcePath() {
 return resourcePath;
   }
-
-  @Override
-  @Deprecated
-  public String getSource() {
-return sourceToken.readString();
-  }

   @Override
   public String getTypeName() {
===
---  
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java	 
Wed Jun  8 16:44:32 2011
+++  
/trunk/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java	 
Thu Aug  4 11:07:02 2011

@@ -19,6 +19,7 @@
 import com.google.gwt.core.ext.TreeLogger.HelpInfo;
 import com.google.gwt.core.ext.TreeLogger.Type;
 import com.google.gwt.core.ext.UnableToCompleteException;
+import  
com.google.gwt.dev.javac.CompilationUnitBuilder.GeneratedCompilationUnit;

 import com.google.gwt.dev.jjs.InternalCompilerException;
 import com.google.gwt.dev.jjs.InternalCompilerException.NodeInfo;
 import com.google.gwt.dev.jjs.SourceInfo;
@@ -29,7 +30,6 @@

 import java.io.File;
 import java.io.IOException;
-import java.net.MalformedURLException;
 import java.net.URL;
 import java.util.HashSet;
 import java.util.LinkedList;
@@ -43,13 +43,6 @@
  * console.
  */
 public class CompilationProblemReporter {
-
-  /**
-   * Used to lazily retrieve source if needed for reporting an error.
-   */
-  public interface SourceFetcher {
-String getSource();
-  }

   /**
* Used as a convenience to catch all exceptions thrown by the compiler.  
For

@@ -144,40 +137,24 @@
   }

   /**
-   * Walk the compilation state and report errors if they exist.
+   * Logs errors to the console.
*
* @param logger logger for reporting errors to the console
-   * @param compilationState contains units that might contain errors
-   * @param suppressErrors See {@link #reportErrors(TreeLogger,  
CompilationUnit, boolean)}

+   * @param unit Compilation unit that may have errors
+   * @param suppressErrors Controls he log level for logging errors. If
+   *  false is passed, compilation errors are logged  
at

+   *  TreeLogger.ERROR and warnings logged at TreeLogger.WARN. If
+   *  true is passed, compilation errors are logged at
+   *  TreeLogger.TRACE and TreeLogger.DEBUG.
+   * @return true if an error was logged.
*/
-  public static void reportAllErrors(TreeLogger logger, CompilationState  
compilationState,

-  boolean suppressErrors) {
-for (CompilationUnit unit : compilationState.getCompilationUnits()) {
-  if (unit.isError()) {
-reportErrors(logger, unit, suppressErrors);
-  }
-}
-  }
-
-  /**
-   * Report an error in a compilation unit to the console.
-   *
-   * @param logger logger for reporting errors to the

[gwt-contrib] Re: Fix typo (issue1497807)

[unnurg]

On 2011/08/04 16:22:03, fredsa wrote:

LGTM

http://gwt-code-reviews.appspot.com/1497807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] XMLHttpRequest2

[Allahbaksh Asadullah]

HI,
We are trying to implement XMLHttpRequest2. Whether there is already
some contribution made in this regards to the GWT? If yes can you
point out to the location of the source code.
If there is no contribution what is best way specify different
response type like ArrayBuffer, Blob etc. Whether GWT has already some
implementation of the same? If know can you people suggest what is
best way to have this done.
Regards,
Allahbaksh

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix typo (issue1497807)

[fredsa]

Reviewers: unnurg,

Description:
Fix typo

Fixes issues: 5912

Review by: unn...@google.com

Please review this at http://gwt-code-reviews.appspot.com/1497807/

Affected files:
  M user/src/com/google/gwt/regexp/shared/RegExp.java


Index: user/src/com/google/gwt/regexp/shared/RegExp.java
===
--- user/src/com/google/gwt/regexp/shared/RegExp.java   (revision 10471)
+++ user/src/com/google/gwt/regexp/shared/RegExp.java   (working copy)
@@ -32,7 +32,7 @@
  * There are a few small incompatibilities between the two implementations.
  * Java-specific constructs in the regular expression syntax (e.g.  
[a-z&&[^bc]],

  * (?<=foo), \A, \Q) work only in the pure Java implementation, not the GWT
- * implementation, and are not rejected by either. Also, the  
Javscript-specific
+ * implementation, and are not rejected by either. Also, the  
Javascript-specific

  * constructs $` and $' in the replacement expression work only in the GWT
  * implementation, not the pure Java implementation, which rejects them.
  */


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Support chained requests where the returned proxy type is not reachable from the canonical Reque... (issue1499810)

[bobv]

Reviewers: rjrjr,

Description:
Support chained requests where the returned proxy type is not reachable
from the canonical RequestContext.
Issue 6641.
Patch by: bobv
Review by: rjrjr


Please review this at http://gwt-code-reviews.appspot.com/1499810/

Affected files:
  M user/src/com/google/web/bindery/autobean/vm/impl/FactoryHandler.java
  M  
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
  M  
user/test/com/google/web/bindery/requestfactory/gwt/RequestFactorySuite.java
  A  
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryChainedContextTest.java
  M  
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
  A  
user/test/com/google/web/bindery/requestfactory/server/RequestFactoryChainedContextJreTest.java
  M  
user/test/com/google/web/bindery/requestfactory/vm/RequestFactoryJreSuite.java



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on CssResource in google-web-toolkit

[codesite-noreply]

Comment by a.korzhe...@gmail.com:

Would really like to see smth like that:

@sprite .myClass {
  gwt-image: url("image.png");
}

because if i have external css with this class i would like to define image  
there and not in UiBinder via 


For more information:
http://code.google.com/p/google-web-toolkit/wiki/CssResource

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors