[gwt-contrib] Re: Make UmbrellaException a bit more convenient to read, and test it. (issue1532803)

[cromwellian]

lgtm

http://gwt-code-reviews.appspot.com/1532803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make UmbrellaException a bit more convenient to read, and test it. (issue1532803)

[Ray Ryan]

How's that?

On Thu Aug 25 17:04:18 GMT-700 2011, 
>
> http://gwt-code-reviews.appspot.com/1532803/diff/1/user/src/com/google/web/bindery/event/shared/UmbrellaException.java
> File user/src/com/google/web/bindery/event/shared/UmbrellaException.java
> (right):
>
>
> http://gwt-code-reviews.appspot.com/1532803/diff/1/user/src/com/google/web/bindery/event/shared/UmbrellaException.java#newcode53
> user/src/com/google/web/bindery/event/shared/UmbrellaException.java:53
> :
> return causes.size() == 1 ? ONE + message : MULTIPLE + message;
> Couldn't we tack on the rest of the exception messages here when there's
> multiple instead of just the first?
>
> http://gwt-code-reviews.appspot.com/1532803/
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make UmbrellaException a bit more convenient to read, and test it. (issue1532803)

[rjrjr]

http://gwt-code-reviews.appspot.com/1532803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make UmbrellaException a bit more convenient to read, and test it. (issue1532803)

[cromwellian]

http://gwt-code-reviews.appspot.com/1532803/diff/1/user/src/com/google/web/bindery/event/shared/UmbrellaException.java
File user/src/com/google/web/bindery/event/shared/UmbrellaException.java
(right):

http://gwt-code-reviews.appspot.com/1532803/diff/1/user/src/com/google/web/bindery/event/shared/UmbrellaException.java#newcode53
user/src/com/google/web/bindery/event/shared/UmbrellaException.java:53:
return causes.size() == 1 ? ONE + message : MULTIPLE + message;
Couldn't we tack on the rest of the exception messages here when there's
multiple instead of just the first?

http://gwt-code-reviews.appspot.com/1532803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10580 committed - Public (emmanu...@google.com):...

[codesite-noreply]

Revision: 10580
Author:   rj...@google.com
Date: Thu Aug 25 12:59:55 2011
Log:  Public (emmanu...@google.com):
Fix exception exception reporting.

Now consistent with all other usages of UncaughtExceptionHandler:
com/google/gwt/core/client/impl/Impl.java:214
com/google/gwt/core/client/impl/AsyncFragmentLoader.java:578
com/google/gwt/storage/client/StorageImpl.java:59
com/google/gwt/user/client/impl/AsyncProxyBase.java:110

Review at http://gwt-code-reviews.appspot.com/1529806

http://code.google.com/p/google-web-toolkit/source/detail?r=10580

Modified:
 /trunk/user/src/com/google/gwt/core/client/impl/SchedulerImpl.java

===
--- /trunk/user/src/com/google/gwt/core/client/impl/SchedulerImpl.java	Mon  
Mar 21 12:22:19 2011
+++ /trunk/user/src/com/google/gwt/core/client/impl/SchedulerImpl.java	Thu  
Aug 25 12:59:55 2011

@@ -227,7 +227,7 @@
 } else {
   t.executeScheduled();
 }
-  } catch (RuntimeException e) {
+  } catch (Throwable e) {
 if (GWT.getUncaughtExceptionHandler() != null) {
   GWT.getUncaughtExceptionHandler().onUncaughtException(e);
 }

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Make UmbrellaException a bit more convenient to read, and test it. (issue1532803)

[rjrjr]

Reviewers: cromwellian,

Description:
Make UmbrellaException a bit more convenient to read, and test it.


Please review this at http://gwt-code-reviews.appspot.com/1532803/

Affected files:
  M user/src/com/google/web/bindery/event/shared/UmbrellaException.java
  A user/test/com/google/web/bindery/event/shared/UmbrellaExceptionTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10579 committed - Another attempt to placate IE. Think I rant the tests right this time.

[codesite-noreply]

Revision: 10579
Author:   rj...@google.com
Date: Thu Aug 25 12:26:31 2011
Log:  Another attempt to placate IE. Think I rant the tests right this  
time.


http://code.google.com/p/google-web-toolkit/source/detail?r=10579

Modified:
  
/trunk/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuilderSafeUriIntegrationTest.Renderable.ui.xml
  
/trunk/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuilderSafeUriIntegrationTest.java
  
/trunk/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuilderSafeUriIntegrationTest.ui.xml
  
/trunk/user/test/com/google/gwt/uibinder/test/client/SafeUriIntegrationTest.java


===
---  
/trunk/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuilderSafeUriIntegrationTest.Renderable.ui.xml	 
Thu Aug 18 06:20:28 2011
+++  
/trunk/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuilderSafeUriIntegrationTest.Renderable.ui.xml	 
Thu Aug 25 12:26:31 2011

@@ -21,6 +21,7 @@

   JavaScript  
anchor from SafeUri |
   JavaScript  
anchor from String |
+  JavaScript anchor from  
String |
   Http anchor from  
String |


   href='http://www.google.com/images/logo_sm.gif'>inline http anchor |

===
---  
/trunk/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuilderSafeUriIntegrationTest.java	 
Wed Aug 24 18:17:39 2011
+++  
/trunk/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuilderSafeUriIntegrationTest.java	 
Thu Aug 25 12:26:31 2011

@@ -36,6 +36,8 @@
 AnchorElement getJsAnchorFromSafeUri(Element ancestor);

 AnchorElement getJsAnchorFromString(Element ancestor);
+
+AnchorElement getJsAnchorFromStringControl(Element ancestor);

 AnchorElement getHttpAnchorFromString(Element ancestor);

@@ -59,6 +61,8 @@
 @UiField
 AnchorElement jsAnchorFromString;
 @UiField
+AnchorElement jsAnchorFromStringControl;
+@UiField
 AnchorElement httpAnchorFromString;
 @UiField
 AnchorElement inlineHttpAnchor;
@@ -90,8 +94,7 @@
 try {
   RootPanel.get().add(ui);
   assertEquals(values.anUnsafeUri(), ui.jsAnchorFromSafeUri.getHref());
-  AnchorElement anchor = expectedEscapedAnchor();
-  assertEquals(anchor.getHref(), ui.jsAnchorFromString.getHref());
+  assertEquals(ui.jsAnchorFromString.getHref(),  
ui.jsAnchorFromString.getHref());
   assertEquals("http://www.google.com/images/logo_sm.gif";,  
ui.inlineHttpAnchor.getHref());
   assertEquals("javascript:void(0)",  
ui.inlineJavascriptAnchor.getHref());

   assertEquals(values.aSelector() + values.aGifPath(),
@@ -116,8 +119,7 @@
 try {
   assertEquals(values.anUnsafeUri(),  
r.getJsAnchorFromSafeUri(e).getHref());


-  AnchorElement anchor = expectedEscapedAnchor();
-  assertEquals(anchor.getHref(), r.getJsAnchorFromString(e).getHref());
+  assertEquals(r.getJsAnchorFromStringControl(e).getHref(),  
r.getJsAnchorFromString(e).getHref());


   assertEquals("http://www.google.com/images/logo_sm.gif";,  
r.getInlineHttpAnchor(e).getHref());
   assertEquals("javascript:void(0)",  
r.getInlineJavascriptAnchor(e).getHref());

===
---  
/trunk/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuilderSafeUriIntegrationTest.ui.xml	 
Thu Aug 18 06:20:28 2011
+++  
/trunk/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuilderSafeUriIntegrationTest.ui.xml	 
Thu Aug 25 12:26:31 2011

@@ -16,6 +16,7 @@
   
 JavaScript  
anchor from SafeUri |
 href='{values.anUnsafeUri}'>JavaScript anchor from String |
+JavaScript anchor  
from String |
 Http anchor  
from String |


 href='http://www.google.com/images/logo_sm.gif'>inline http anchor |

===
---  
/trunk/user/test/com/google/gwt/uibinder/test/client/SafeUriIntegrationTest.java	 
Wed Aug 24 18:17:39 2011
+++  
/trunk/user/test/com/google/gwt/uibinder/test/client/SafeUriIntegrationTest.java	 
Thu Aug 25 12:26:31 2011

@@ -69,7 +69,7 @@
 BinderUi ui = new BinderUi();

 assertEquals(values.anUnsafeUri(), ui.jsAnchorFromSafeUri.getHref());
-AnchorElement anchor = expectedEscapedAnchor();
+AnchorElement anchor = UiBinderUtil.fromHtml("href='#'>snot").cast();

 assertEquals(anchor.getHref(), ui.jsAnchorFromString.getHref());
 assertEquals("http://www.google.com/images/logo_sm.gif";,  
ui.inlineHttpAnchor.getHref());
 assertEquals("javascript:void(0)",  
ui.inlineJavascriptAnchor.getHref());

@@ -79,9 +79,4 @@
 assertEquals("http://www.google.com/images/logo_sm.gif";,  
ui.inlineHttpAnchorObj.uri.asString());
 assertEquals("javascript:void(0)",  
ui.inlineJavascriptAnchorObj.uri.asString());

   }
-
-  protected AnchorElement expectedEscapedAnchor() {
-AnchorElement anchor = UiBinderUtil.fromHtml("href='#'>snot").cast();

-return anchor;
-  }
-}
+}

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10578 committed - Save the factory and options in the ValidatorContext...

[codesite-noreply]

Revision: 10578
Author:   ncha...@google.com
Date: Thu Aug 25 12:18:37 2011
Log:  Save the factory and options in the ValidatorContext
Add test for GwtValidatorContext.
Review at http://gwt-code-reviews.appspot.com/1523806

Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10578

Added:
  
/trunk/user/test/com/google/gwt/validation/client/GwtValidatorContextTest.java

Modified:
 /trunk/user/src/com/google/gwt/validation/Validation.gwt.xml
  
/trunk/user/src/com/google/gwt/validation/client/AbstractGwtValidatorFactory.java

 /trunk/user/src/com/google/gwt/validation/client/GwtValidatorContext.java
  
/trunk/user/src/com/google/gwt/validation/client/impl/AbstractGwtValidator.java

 /trunk/user/test/com/google/gwt/validation/ValidationClientGwtSuite.java

===
--- /dev/null
+++  
/trunk/user/test/com/google/gwt/validation/client/GwtValidatorContextTest.java	 
Thu Aug 25 12:18:37 2011

@@ -0,0 +1,163 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package com.google.gwt.validation.client;
+
+import com.google.gwt.validation.client.impl.AbstractGwtValidator;
+import com.google.gwt.validation.client.impl.GwtValidationContext;
+
+import java.util.Set;
+
+import javax.validation.ConstraintValidatorFactory;
+import javax.validation.ConstraintViolation;
+import javax.validation.MessageInterpolator;
+import javax.validation.TraversableResolver;
+import javax.validation.ValidationException;
+import javax.validation.ValidatorContext;
+import javax.validation.ValidatorFactory;
+import javax.validation.metadata.BeanDescriptor;
+
+/**
+ * Tests for {@link GwtValidatorContext}.
+ */
+public class GwtValidatorContextTest extends ValidationClientGwtTestCase {
+
+  private final class DummyGwtValidatorFactory extends
+  AbstractGwtValidatorFactory {
+@Override
+public AbstractGwtValidator createValidator() {
+  return new DummyValidator();
+}
+  }
+
+  private static class DummyValidator extends AbstractGwtValidator {
+@Override
+public BeanDescriptor getConstraintsForClass(Class clazz) {
+  throw new UnsupportedOperationException();
+}
+
+@Override
+public  Set> validate(
+GwtValidationContext context, Object object, Class... groups)
+throws ValidationException {
+  throw new UnsupportedOperationException();
+}
+
+@Override
+public  Set> validate(T object,
+Class... groups) {
+  throw new UnsupportedOperationException();
+}
+
+@Override
+public  Set> validateProperty(T object,
+String propertyName, Class... groups) {
+  throw new UnsupportedOperationException();
+}
+
+@Override
+public  Set> validateValue(Class beanType,
+String propertyName, Object value, Class... groups) {
+  throw new UnsupportedOperationException();
+}
+
+@Override
+protected ConstraintValidatorFactory getConstraintValidatorFactory() {
+  return super.getConstraintValidatorFactory();
+}
+
+@Override
+protected MessageInterpolator getMessageInterpolator() {
+  return super.getMessageInterpolator();
+}
+
+@Override
+protected TraversableResolver getTraversableResolver() {
+  return super.getTraversableResolver();
+}
+  }
+
+  private ValidatorFactory validatorFactory;
+  private ValidatorContext validatorContext;
+
+  public void testCustom() throws Exception {
+final TraversableResolver traversableResolver = new  
GwtTraversableResolver();
+final ConstraintValidatorFactory constraintValidatorFactory = new  
GwtConstraintValidatorFactory();
+final MessageInterpolator messageInterpolator = new  
GwtMessageInterpolator();

+
+validatorContext.constraintValidatorFactory(constraintValidatorFactory)
+.messageInterpolator(messageInterpolator)
+.traversableResolver(traversableResolver);
+
+assertContext(traversableResolver, constraintValidatorFactory,
+messageInterpolator);
+  }
+
+  public void testDefault() throws Exception {
+assertContext(validatorFactory.getTraversableResolver(), //
+validatorFactory.getConstraintValidatorFactory(), //
+validatorFactory.getMessageInterpolator());
+  }
+
+  public void testNull() throws Exception {
+validatorContext.constraintValidatorFactory(null) //
+.messageInterpolator(null) //
+.traversableResolver(null);
+
+

Re: [gwt-contrib] maven source jars

[Thomas Broyer]

How about a new "dist-maven" ant target that would create a "maven bundle" 
(folder with the JARs and POMs laid out just like in a Maven repository)?
You would then run "ant -Dgwt.version=2.4.0 dist dist-maven" [1] instead of 
just "ant dist" to build a release, and the generated maven bundle would be 
ready to deploy to Maven Central (well, I guess, I don't know how you deploy 
things there). It makes installing locally easy as you just copy the whole 
thing to your ~/.m2/repository/, and easy to deploy to your enterprise 
repository (at least Artifactory makes it easy: just zip the bundle and 
upload it).
Such a target could then reuse the local ant variables of each projects, 
instead of post-processing the SDK JARs (removing the META-INF/INDEX.LIST, 
etc.)

David, could you send us (Stephen and me) your scripts so we could work 
together making this real? (if you're OK with this, Stephen)

[1] Ideally, I would add a -Dgwt.maven-version to make it possible to use 
2.4-SNAPSHOT or 2.4-atolcd-r10556 kind of versions, as advised by Sonatype: 
http://www.sonatype.com/people/2009/01/best-practices-for-releasing-with-3rd-party-snapshot-dependencies/
So you'd use "ant -Dgwt.version=2.4.0 -Dgwt.maven-version=2.4-atolcd-r10556 
dist-maven"

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10577 committed - Address RunStyle TODO...

[codesite-noreply]

Revision: 10577
Author:   stephen.haber...@gmail.com
Date: Thu Aug 25 11:38:49 2011
Log:  Address RunStyle TODO

Review at: http://gwt-code-reviews.appspot.com/1529805/

http://code.google.com/p/google-web-toolkit/source/detail?r=10577

Modified:
 /trunk/user/src/com/google/gwt/junit/JUnitShell.java
 /trunk/user/src/com/google/gwt/junit/RunStyle.java
 /trunk/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java

===
--- /trunk/user/src/com/google/gwt/junit/JUnitShell.java	Tue Jun 28  
02:20:50 2011
+++ /trunk/user/src/com/google/gwt/junit/JUnitShell.java	Thu Aug 25  
11:38:49 2011

@@ -74,6 +74,7 @@
 import java.net.UnknownHostException;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.EnumSet;
 import java.util.HashMap;
 import java.util.Map;
@@ -1220,11 +1221,7 @@
   }

   private boolean mustNotExecuteTest(Set bannedPlatforms) {
-// TODO (amitmanjhi): Remove this hard-coding. A RunStyle somehow  
needs to

-// specify how it interacts with the platforms.
-if (runStyle instanceof RunStyleHtmlUnit
-&& (bannedPlatforms.contains(Platform.HtmlUnitUnknown)
-|| bannedPlatforms.contains(Platform.HtmlUnitLayout) ||  
bannedPlatforms.contains(Platform.HtmlUnitBug))) {

+if (!Collections.disjoint(bannedPlatforms, runStyle.getPlatforms())) {
   return true;
 }

===
--- /trunk/user/src/com/google/gwt/junit/RunStyle.java	Thu Dec 16 11:33:51  
2010
+++ /trunk/user/src/com/google/gwt/junit/RunStyle.java	Thu Aug 25 11:38:49  
2011

@@ -20,6 +20,8 @@

 import java.net.InetAddress;
 import java.net.UnknownHostException;
+import java.util.Collections;
+import java.util.Set;

 /**
  * An abstract class that handles the details of launching a browser.
@@ -67,6 +69,13 @@
   throw new RuntimeException("Unable to determine my ip address", e);
 }
   }
+
+  /**
+   * Returns the platforms specific to this run style.
+   */
+  public Set getPlatforms() {
+return Collections.emptySet();
+  }

   /**
* Returns the number of times this test should be tried to run. A test
===
--- /trunk/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java	Tue Apr 26  
08:02:24 2011
+++ /trunk/user/src/com/google/gwt/junit/RunStyleHtmlUnit.java	Thu Aug 25  
11:38:49 2011

@@ -17,6 +17,7 @@

 import com.google.gwt.core.ext.TreeLogger;
 import com.google.gwt.dev.shell.HostedModePluginObject;
+import com.google.gwt.thirdparty.guava.common.collect.ImmutableSet;

 import com.gargoylesoftware.htmlunit.AlertHandler;
 import com.gargoylesoftware.htmlunit.BrowserVersion;
@@ -180,6 +181,9 @@
*/
   private static final int DEFAULT_TRIES = 1;

+  private static final Set PLATFORMS =  
ImmutableSet.of(Platform.HtmlUnitBug,

+  Platform.HtmlUnitLayout, Platform.HtmlUnitUnknown);
+
   /**
* Returns the list of browsers Htmlunit emulates as a comma separated  
string.

*/
@@ -215,6 +219,11 @@
   public RunStyleHtmlUnit(JUnitShell shell) {
 super(shell);
   }
+
+  @Override
+  public Set getPlatforms() {
+return PLATFORMS;
+  }

   @Override
   public int initialize(String args) {

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Public (emmanu...@google.com): (issue1529806)

[rjrjr]

Reviewers: rjrjr,

Description:
Public (emmanu...@google.com):
Fix exception exception reporting.

Now consistent with all other usages of UncaughtExceptionHandler:
com/google/gwt/core/client/impl/Impl.java:214
com/google/gwt/core/client/impl/AsyncFragmentLoader.java:578
com/google/gwt/storage/client/StorageImpl.java:59
com/google/gwt/user/client/impl/AsyncProxyBase.java:110


Please review this at http://gwt-code-reviews.appspot.com/1529806/

Affected files:
  M user/src/com/google/gwt/core/client/impl/SchedulerImpl.java


Index: user/src/com/google/gwt/core/client/impl/SchedulerImpl.java
===
--- user/src/com/google/gwt/core/client/impl/SchedulerImpl.java	(revision  
10571)
+++ user/src/com/google/gwt/core/client/impl/SchedulerImpl.java	(working  
copy)

@@ -227,7 +227,7 @@
 } else {
   t.executeScheduled();
 }
-  } catch (RuntimeException e) {
+  } catch (Throwable e) {
 if (GWT.getUncaughtExceptionHandler() != null) {
   GWT.getUncaughtExceptionHandler().onUncaughtException(e);
 }


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1528806)

[stephen . haberman]

General question... can you confirm that these fields are optimized

out if

Boolean class is referenced but TYPE field is not?


I confirmed that using Boolean.TRUE/FALSE in an app, but not
Boolean.TYPE, does drop the boolean.class literal.

http://gwt-code-reviews.appspot.com/1528806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1528806)

[stephen . haberman]

http://gwt-code-reviews.appspot.com/1528806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10575 committed - Add missing Linux 32 bit xulrunner libraries for Gecko6

[codesite-noreply]

Revision: 10575
Author:   acle...@google.com
Date: Thu Aug 25 12:50:11 2011
Log:  Add missing Linux 32 bit xulrunner libraries for Gecko6

http://code.google.com/p/google-web-toolkit/source/detail?r=10575

Added:
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libmozalloc.so
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libnspr4.so
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libplc4.so
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libplds4.so
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libxpcom.so
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libxpcomglue_s.a
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libxul.so

===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libmozalloc.so	 
Thu Aug 25 12:50:11 2011

Binary file, no diff available.
===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libnspr4.so	Thu  
Aug 25 12:50:11 2011

Binary file, no diff available.
===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libplc4.so	Thu  
Aug 25 12:50:11 2011

Binary file, no diff available.
===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libplds4.so	Thu  
Aug 25 12:50:11 2011

Binary file, no diff available.
===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libxpcom.so	Thu  
Aug 25 12:50:11 2011

Binary file, no diff available.
===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libxpcomglue_s.a	 
Thu Aug 25 12:50:11 2011

Binary file, no diff available.
===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libxul.so	Thu  
Aug 25 12:50:11 2011

File is too large to display a diff.

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10574 committed - Adds missing xulrunner library to Geck6

[codesite-noreply]

Revision: 10574
Author:   acle...@google.com
Date: Thu Aug 25 12:37:41 2011
Log:  Adds missing xulrunner library to Geck6

http://code.google.com/p/google-web-toolkit/source/detail?r=10574

Added:
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libmozalloc.so
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libnspr4.so
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libplc4.so
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libplds4.so
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libxpcom.so
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libxpcomglue_s.a
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libxul.so

===
--- /dev/null   
+++  
/plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libmozalloc.so	 
Thu Aug 25 12:37:41 2011

Binary file, no diff available.
===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libnspr4.so	 
Thu Aug 25 12:37:41 2011

Binary file, no diff available.
===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libplc4.so	 
Thu Aug 25 12:37:41 2011

Binary file, no diff available.
===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libplds4.so	 
Thu Aug 25 12:37:41 2011

Binary file, no diff available.
===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libxpcom.so	 
Thu Aug 25 12:37:41 2011

Binary file, no diff available.
===
--- /dev/null   
+++  
/plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libxpcomglue_s.a	 
Thu Aug 25 12:37:41 2011

File is too large to display a diff.
===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libxul.so	Thu  
Aug 25 12:37:41 2011

File is too large to display a diff.

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10573 committed - Add missing libxpcomglue_s.a for Geck6 Darwin Xulrunner

[codesite-noreply]

Revision: 10573
Author:   acle...@google.com
Date: Thu Aug 25 12:10:19 2011
Log:  Add missing libxpcomglue_s.a for Geck6 Darwin Xulrunner

http://code.google.com/p/google-web-toolkit/source/detail?r=10573

Added:
 /plugin-sdks/gecko-sdks/gecko-6.0.0/Darwin-gcc3/lib/libxpcomglue_s.a

===
--- /dev/null   
+++ /plugin-sdks/gecko-sdks/gecko-6.0.0/Darwin-gcc3/lib/libxpcomglue_s.a	 
Thu Aug 25 12:10:19 2011

File is too large to display a diff.

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1528806)

[stephen . haberman]

http://gwt-code-reviews.appspot.com/1528806/diff/1/user/super/com/google/gwt/emul/java/lang/Boolean.java
File user/super/com/google/gwt/emul/java/lang/Boolean.java (right):

http://gwt-code-reviews.appspot.com/1528806/diff/1/user/super/com/google/gwt/emul/java/lang/Boolean.java#newcode30
user/super/com/google/gwt/emul/java/lang/Boolean.java:30: public static
Boolean TRUE = new Boolean(true);
On 2011/08/25 18:37:20, scottb wrote:

Unrelated: shouldn't these be final?


I was wondering about that as well; I can add that.

http://gwt-code-reviews.appspot.com/1528806/diff/1/user/super/com/google/gwt/emul/java/lang/Boolean.java#newcode34
user/super/com/google/gwt/emul/java/lang/Boolean.java:34: public static
final Class TYPE = boolean.class;
On 2011/08/25 18:37:20, scottb wrote:

General question... can you confirm that these fields are optimized

out if

Boolean class is referenced but TYPE field is not?


Sure.

http://gwt-code-reviews.appspot.com/1528806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding some extra capabilities to CountingEventBus so that we can reduce the boilerplate involve... (issue1526803)

[skybrian]

LGTM


http://gwt-code-reviews.appspot.com/1526803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] maven source jars

[Ray Ryan]

Stephen, if you're game to do the research and the work, we're certainly
happy to have it done. Thanks either way.

On Wed Aug 24 12:39:51 GMT-700 2011, Stephen Haberman wrote:

>
> > Hm, perhaps a few. I saw instructions on patching emma; nothing else
> > is leaping out at me.
>
> Okay, there are patch files for json and streamhtmlparser. The latter is
> rebased. Leaving anything that is rebased or patched in the jar seems
> fine to me, since it's only a few.
>
> (I'm replying to myself, but I sent my previous message from the
> wrong email address, so it is probably moderated/dropped. Here's
> the text in case my previous message never shows up:)
>
> Taking gwt-dev-nodeps further, it looks like most of the deps come from
> bundling tomcat and htmlunit. Neither of which I use. I think it would
> be fairly easily, at least from a packaging perspective, to make
> gwt-dev-nodeps, gwt-tomcat, and gwt-htmlunit jars, none of which have
> their dependencies in them, but instead pulled in however projects
> otherwise manage transitive dependencies (poms/what have you).
>
> If I got a gwt-dev-nodeps/gwt-tomcat/gwt-htmlunit build working, would
> anyone be interested in that?
>
> - Stephen
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10572 committed - Adding Richard Kolkovich to the CLA Signers list. CLA signed and on fi...

[codesite-noreply]

Revision: 10572
Author:   gwt.mirror...@gmail.com
Date: Thu Aug 25 08:22:19 2011
Log:  Adding Richard Kolkovich to the CLA Signers list. CLA signed and  
on file.

http://code.google.com/p/google-web-toolkit/source/detail?r=10572

Modified:
 /CLA-SIGNERS

===
--- /CLA-SIGNERSTue Apr 19 07:26:05 2011
+++ /CLA-SIGNERSThu Aug 25 08:22:19 2011
@@ -35,4 +35,4 @@
 stephen.haber...@gmail.com (Stephen Haberman)
 sven.brun...@googlemail.com (Sven Brunken)
 t.bro...@gmail.com (Thomas Broyer)
-
+rich...@sigil.org (Richard Kolkovich)

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Save the factory and options in the ValidatorContext (issue1523806)

[rchandia]

On 2011/08/24 19:03:45, Nick Chalko wrote:

LGTM

http://gwt-code-reviews.appspot.com/1523806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors