date:20111027

Re: [gwt-contrib] Announce: GwtQuery 1.1.0

2011-10-27 Thread Ray Cromwell

Awesome job Manuel, taking this project from a proof of concept to a
rock solid library!

-Ray


On Wed, Oct 26, 2011 at 10:38 AM, Manuel Carrasco Moñino
 wrote:
> The GQuery team is proud to announce the version 1.1.0 of the library.
>
> We have been working hard in order to fix many issues and to achieve a
> closed jQuery API.
>
> The new release includes new features like the jQuery Ajax API, Data
> binding to easily manage json and xml data, better interaction with
> gwt widgets, and improved documentation.
>
> You can see the full list of features in the presentation given in The
> RivieraDev last week in France [1] or taking a look to the project
> wiki pages [2]
>
> [1] 
> http://www.slideshare.net/dodotis/gquery-a-jquery-clone-for-gwt-rivieradev-2011
> [2] http://code.google.com/p/gwtquery/w/list
>
>
> Thanks so much to the people sending issues, testing, and using the library.
>
> - GQuery Team
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Make form event getTypes public. (issue1582803)

2011-10-27 Thread Stephen Haberman


> Sadly, Ray has left!

:-(

> You can definitely still assign reviews to whomever you think is most
> appropriate, but add me to the review if you're not getting a
> response, and I'll make sure it gets some attention.

That's great, thanks, Rajeev.

I have a few that have been pending; might send an email about them to
see if they can get to the right people. Some of them are pretty
trivial, so are perhaps more annoying than they are worth. But I think
would be nice to see go in. I'll do that soon.

- Stephen

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Reroll of r10726 (issue1578809)

2011-10-27 Thread rchandia


Reviewers: rdayal,

Description:
Reroll of r10726

*** Original change description ***

Change default of UiBinder.useLazyWidgetBuilders to true, in
preparation for deleting the old code.

Review by: rda...@google.com

Please review this at http://gwt-code-reviews.appspot.com/1578809/

Affected files:
  M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
  M user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
  M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java


Index: user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
===
--- user/src/com/google/gwt/uibinder/UiBinder.gwt.xml   (revision 10728)
+++ user/src/com/google/gwt/uibinder/UiBinder.gwt.xml   (working copy)
@@ -27,11 +27,11 @@
   is-multi-valued="false"/>
   value="true"/>


-  
+  
   is-multi-valued="false"/>
-  value="false"/>
+  value="true"/>


   
 class="com.google.gwt.uibinder.client.UiRenderer"/>

Index: user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java	 
(revision 10728)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java	(working  
copy)

@@ -52,6 +52,7 @@
   private static final String LAZY_WIDGET_BUILDERS_PROPERTY  
= "UiBinder.useLazyWidgetBuilders";


   private static boolean gaveSafeHtmlWarning;
+  private static boolean gaveLazyBuildersWarning;

   /**
* Given a UiBinder interface, return the path to its ui.xml file,  
suitable

@@ -212,7 +213,14 @@
   }

   private Boolean useLazyWidgetBuilders(MortalLogger logger,  
PropertyOracle propertyOracle) {
-return extractConfigProperty(logger, propertyOracle,  
LAZY_WIDGET_BUILDERS_PROPERTY, false);
+Boolean rtn = extractConfigProperty(logger, propertyOracle,  
LAZY_WIDGET_BUILDERS_PROPERTY, true);

+if (!gaveLazyBuildersWarning && !rtn) {
+  logger.warn("Configuration property %s is false. Deprecated code  
generation is in play. " +

+  "This property will soon become a no-op.",
+  LAZY_WIDGET_BUILDERS_PROPERTY);
+  gaveLazyBuildersWarning = true;
+}
+return rtn;
   }

   private Boolean useSafeHtmlTemplates(MortalLogger logger, PropertyOracle  
propertyOracle) {

@@ -221,7 +229,8 @@

 if (!gaveSafeHtmlWarning && !rtn) {
   logger.warn("Configuration property %s is false! UiBinder SafeHtml  
integration is off, "
-  + "leaving your users more vulnerable to cross-site scripting  
attacks.",
+  + "leaving your users more vulnerable to cross-site scripting  
attacks. This property " +
+  "will soon become a no-op, and SafeHtml integration will always  
be on.",

   XSS_SAFE_CONFIG_PROPERTY);
   gaveSafeHtmlWarning = true;
 }
Index: user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java	(revision  
10728)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java	(working  
copy)

@@ -1006,7 +1006,7 @@
*/
   public String tokenForSafeUriExpression(XMLElement source, String  
expression) {

 if (!useSafeHtmlTemplates) {
-  return tokenForStringExpression(source, expression + ".asString()");
+  return tokenForStringExpression(source, expression);
 }

 htmlTemplates.noteUri(expression);


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixing a bug in HasDataPresenter where it does not pass the complete list of modified rows if a ... (issue1583805)

2011-10-27 Thread jlabanca


Reviewers: devint,

Description:
Fixing a bug in HasDataPresenter where it does not pass the complete
list of modified rows if a pending state is detecting while we are
resolving the current state.  We were leaving off rows that were
modified, as well as the keyboard selected rows.  By passing all of
these rows to the recursive call to resolvePendingState(), we ensure
that all modified rows are updated.

Review by: dev...@google.com

Please review this at http://gwt-code-reviews.appspot.com/1583805/

Affected files:
  M user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java


Index: user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java
===
--- user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java	 
(revision 10728)
+++ user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java	 
(working copy)

@@ -1056,7 +1056,7 @@
* Resolve the pending state and push updates to the view.
*
* @param modifiedRows the modified rows that need to be updated, or  
null if

-   *  none. The modified rows may be mutated.
+   *none. The modified rows may be mutated.
* @return true if the state changed, false if not
*/
   private boolean resolvePendingState(JsArrayInteger modifiedRows) {
@@ -1247,24 +1247,6 @@
   throw e;
 }

-/*
- * We called methods in user code that could modify the view, so early  
exit

- * if there is a new pending state waiting to be resolved.
- */
-if (pendingState != null) {
-  isResolvingState = false;
-  // Do not reset pendingStateLoop, or we will not detect the infinite  
loop.

-
-  /*
-   * Try to resolve state again. If we are successful, then the  
modified
-   * rows will be redrawn. If we are not successful, then we still  
need to

-   * redraw the modified rows.
-   */
-  if (resolvePendingState(modifiedRows)) {
-return true;
-  }
-}
-
 // Add the replaced ranges as modified rows.
 boolean replacedEmptyRange = false;
 for (Range replacedRange : pending.replacedRanges) {
@@ -1283,6 +1265,31 @@
 if (modifiedRows.length() > 0 && keyboardRowChanged) {
   modifiedRows.push(oldState.getKeyboardSelectedRow());
   modifiedRows.push(pending.keyboardSelectedRow);
+}
+
+/*
+ * We called methods in user code that could modify the view, so early  
exit

+ * if there is a new pending state waiting to be resolved.
+ */
+if (pendingState != null) {
+  isResolvingState = false;
+  // Do not reset pendingStateLoop, or we will not detect the infinite  
loop.

+
+  /*
+   * Add the keyboard selected rows to the modified rows so they can be
+   * re-rendered in the new state.
+   */
+  modifiedRows.push(oldState.getKeyboardSelectedRow());
+  modifiedRows.push(pending.keyboardSelectedRow);
+
+  /*
+   * Try to resolve state again. If we are successful, then the  
modified
+   * rows will be redrawn. If we are not successful, then we still  
need to

+   * redraw the modified rows.
+   */
+  if (resolvePendingState(modifiedRows)) {
+return true;
+  }
 }

 // Calculate the modified ranges.


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Mofifying HasDataPresenter to be more resilient to state changes while it is resolving state cha... (issue1583804)

2011-10-27 Thread jlabanca


committed as r10728

http://gwt-code-reviews.appspot.com/1583804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Mofifying HasDataPresenter to be more resilient to state changes while it is resolving state cha... (issue1583804)

2011-10-27 Thread jlabanca


Reviewers: dcavalcanti_google.com,

Description:
Mofifying HasDataPresenter to be more resilient to state changes while
it is resolving state changes.  For example, if user code triggers a
SelectionChangeEvent while selection is being resolved, we can handle
that.

Review by: dcavalca...@google.com

Please review this at http://gwt-code-reviews.appspot.com/1583804/

Affected files:
  M user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Make form event getTypes public. (issue1582803)

2011-10-27 Thread Rajeev Dayal

On Thu, Oct 27, 2011 at 3:15 PM,  wrote:

>
>  LGTM
>>
>
> Thanks.
>
>
>  (as a side note, I always wondered why these events are not in
>>
> com.google.gwt.event.dom; I believe we could add them there and have the
> existing ones extend the new ones)
>
> Good point, I didn't think about that. I'll keep that in mind but leave
> it for another CL for now.
>
>
>  Oh, and BTW, rjrjr is no longer a Googler; I wonder who to assign this
>>
> CL to;
>
>> jgw? jlabanca? fredsa?
>>
>
> Crazy; that is news to me. I found his G+ post--and also saw your
> comment about the GWT team changing. I'd been assigning reviews to some
> of those people.
>
> Dunno, should ask on gwt-contrib, I guess.


Sadly, Ray has left!

You can definitely still assign reviews to whomever you think is most
appropriate, but add me to the review if you're not getting a response, and
I'll make sure it gets some attention.


>
>
> http://gwt-code-reviews.**appspot.com/1582803/
>
> --
> http://groups.google.com/**group/Google-Web-Toolkit-**Contributors
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make form event getTypes public. (issue1582803)

2011-10-27 Thread stephen . haberman




LGTM


Thanks.


(as a side note, I always wondered why these events are not in

com.google.gwt.event.dom; I believe we could add them there and have the
existing ones extend the new ones)

Good point, I didn't think about that. I'll keep that in mind but leave
it for another CL for now.


Oh, and BTW, rjrjr is no longer a Googler; I wonder who to assign this

CL to;

jgw? jlabanca? fredsa?


Crazy; that is news to me. I found his G+ post--and also saw your
comment about the GWT team changing. I'd been assigning reviews to some
of those people.

Dunno, should ask on gwt-contrib, I guess.

http://gwt-code-reviews.appspot.com/1582803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Rollback of r10726. It still causes brackage (issue1577805)

2011-10-27 Thread rchandia


Submitting TBR

http://gwt-code-reviews.appspot.com/1577805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Rollback of r10726. It still causes brackage (issue1577805)

2011-10-27 Thread rchandia


Reviewers: rdayal,

Description:
Rollback of r10726. It still causes brackage

*** Original change description ***

Change default of UiBinder.useLazyWidgetBuilders to true, in
preparation for deleting the old code.


Please review this at http://gwt-code-reviews.appspot.com/1577805/

Affected files:
  M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
  M user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
  M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java


Index: user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
===
--- user/src/com/google/gwt/uibinder/UiBinder.gwt.xml   (revision 10726)
+++ user/src/com/google/gwt/uibinder/UiBinder.gwt.xml   (working copy)
@@ -27,11 +27,11 @@
   is-multi-valued="false"/>
   value="true"/>


-  
+  
   is-multi-valued="false"/>
-  value="true"/>
+  value="false"/>


   
 class="com.google.gwt.uibinder.client.UiRenderer"/>

Index: user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java	 
(revision 10726)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java	(working  
copy)

@@ -52,7 +52,6 @@
   private static final String LAZY_WIDGET_BUILDERS_PROPERTY  
= "UiBinder.useLazyWidgetBuilders";


   private static boolean gaveSafeHtmlWarning;
-  private static boolean gaveLazyBuildersWarning;

   /**
* Given a UiBinder interface, return the path to its ui.xml file,  
suitable

@@ -213,14 +212,7 @@
   }

   private Boolean useLazyWidgetBuilders(MortalLogger logger,  
PropertyOracle propertyOracle) {
-Boolean rtn = extractConfigProperty(logger, propertyOracle,  
LAZY_WIDGET_BUILDERS_PROPERTY, true);

-if (!gaveLazyBuildersWarning && !rtn) {
-  logger.warn("Configuration property %s is false. Deprecated code  
generation is in play. " +

-  "This property will soon become a no-op.",
-  LAZY_WIDGET_BUILDERS_PROPERTY);
-  gaveLazyBuildersWarning = true;
-}
-return rtn;
+return extractConfigProperty(logger, propertyOracle,  
LAZY_WIDGET_BUILDERS_PROPERTY, false);

   }

   private Boolean useSafeHtmlTemplates(MortalLogger logger, PropertyOracle  
propertyOracle) {

@@ -229,8 +221,7 @@

 if (!gaveSafeHtmlWarning && !rtn) {
   logger.warn("Configuration property %s is false! UiBinder SafeHtml  
integration is off, "
-  + "leaving your users more vulnerable to cross-site scripting  
attacks. This property " +
-  "will soon become a no-op, and SafeHtml integration will always  
be on.",
+  + "leaving your users more vulnerable to cross-site scripting  
attacks.",

   XSS_SAFE_CONFIG_PROPERTY);
   gaveSafeHtmlWarning = true;
 }
Index: user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
===
--- user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java	(revision  
10726)
+++ user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java	(working  
copy)

@@ -1006,7 +1006,7 @@
*/
   public String tokenForSafeUriExpression(XMLElement source, String  
expression) {

 if (!useSafeHtmlTemplates) {
-  return tokenForStringExpression(source, expression);
+  return tokenForStringExpression(source, expression + ".asString()");
 }

 htmlTemplates.noteUri(expression);


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: r10697 is back! It was falsely accused last time. Fingers crossed: (issue1578806)

2011-10-27 Thread rchandia


Submitted as r10726

http://gwt-code-reviews.appspot.com/1578806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make form event getTypes public. (issue1582803)

2011-10-27 Thread t . broyer


LGTM

(as a side note, I always wondered why these events are not in
com.google.gwt.event.dom; I believe we could add them there and have the
existing ones extend the new ones)

Oh, and BTW, rjrjr is no longer a Googler; I wonder who to assign this
CL to; jgw? jlabanca? fredsa?


http://gwt-code-reviews.appspot.com/1582803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java
File user/src/com/google/gwt/user/client/ui/FormPanel.java (right):

http://gwt-code-reviews.appspot.com/1582803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java#newcode138
user/src/com/google/gwt/user/client/ui/FormPanel.java:138: private
static Type TYPE = new Type();
Isn't this initialization defeating the lazy-init done in getType() ?
Seems like the right time to fix this.

http://gwt-code-reviews.appspot.com/1582803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Ignore qualified refs with generics (issue1578808)

2011-10-27 Thread stephen . haberman


Reviewers: scottb,


http://gwt-code-reviews.appspot.com/1578808/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1578808/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#newcode110
dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:110:
}
I noticed in the debugger than some of these refs had generics in them,
which as type names are never going to have entries in allValidClasses,
so it seems okay to just ignore them.



Please review this at http://gwt-code-reviews.appspot.com/1578808/

Affected files:
  M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java


Index: dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
diff --git  
a/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java  
b/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
index  
e18682ebae1f92228a8363d61d6f0359b44f5236..645e20945dfa29456491b5dcfa4fb09c057fbfc7  
100644

--- a/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
+++ b/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
@@ -104,6 +104,10 @@ public class CompilationStateBuilder {
  
unresolvedSimple.add(interner.intern(String.valueOf(simpleRef)));

   }
   for (char[][] qualifiedRef :  
cud.compilationResult().qualifiedReferences) {
+// skip refs like  
com.google.gwt.event.shared.GwtEvent.Type

+if (CharOperation.contains('<', qualifiedRef)) {
+  continue;
+}
  
unresolvedQualified.add(interner.intern(CharOperation.toString(qualifiedRef)));

   }
   for (String jsniDep : jsniDeps) {


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Announce: GwtQuery 1.1.0

Re: [gwt-contrib] Re: Make form event getTypes public. (issue1582803)

[gwt-contrib] Reroll of r10726 (issue1578809)

[gwt-contrib] Fixing a bug in HasDataPresenter where it does not pass the complete list of modified rows if a ... (issue1583805)

[gwt-contrib] Re: Mofifying HasDataPresenter to be more resilient to state changes while it is resolving state cha... (issue1583804)

[gwt-contrib] Mofifying HasDataPresenter to be more resilient to state changes while it is resolving state cha... (issue1583804)

Re: [gwt-contrib] Re: Make form event getTypes public. (issue1582803)

[gwt-contrib] Re: Make form event getTypes public. (issue1582803)

[gwt-contrib] Re: Rollback of r10726. It still causes brackage (issue1577805)

[gwt-contrib] Rollback of r10726. It still causes brackage (issue1577805)

[gwt-contrib] Re: r10697 is back! It was falsely accused last time. Fingers crossed: (issue1578806)

[gwt-contrib] Re: Make form event getTypes public. (issue1582803)

[gwt-contrib] Ignore qualified refs with generics (issue1578808)

13 matches

Site Navigation

Mail list logo

Footer information