[gwt-contrib] Maven, Requestfactory and m2e-apt
Hi, I just updated the WorkingWithMaven and RequestFactoryInterfaceValidator wiki pages with simplified configuration for RFIV, taking advantage of the recently released m2e-apt connector from JBoss. The previous versions used a hack to make it working seamlessly with Eclipse, namely to add the folder where the source was generated as a source folder using the build-helper-maven-plugin. Technically this wasn't necessary because the maven-processor-plugin already added it to the Maven project, but M2Eclipse has no knowledge of the maven-processor-plugin so it didn't work, and the build-helper-maven-plugin hack was necessary. Also, the maven-processor-plugin was used in the generate-sources phase so that M2Eclipse would run it on each changed source file, and could later compile the generated source. m2e-apt takes care or configuring Eclipse's JDT APT from the maven-compiler-plugin or maven-processor-plugin configuration in the POM, so we can switch to simply add the RFIV to the maven-compiler-plugin, and m2e-apt will Note that this won't work with pre-1.0 versions of M2Eclipse, so it rules out Galileo (3.5). If that's a problem, we could add back the previous configuration for use with pre-1.0 versions of M2E. Feedback welcome! Pages: http://code.google.com/p/google-web-toolkit/wiki/WorkingWithMaven http://code.google.com/p/google-web-toolkit/wiki/RequestFactoryInterfaceValidation Diff of the changes: http://code.google.com/p/google-web-toolkit/source/detail?r=11019 (RFIV) http://code.google.com/p/google-web-toolkit/source/detail?r=11020 (WorkingWithMaven) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Add HasEnabled to FileUpload. (issue1727805)
Reviewers: rdayal,
Description:
Add HasEnabled to FileUpload.
Repost of 1614808.
Thanks Stephen!
Fixes issues: 5677
Please review this at http://gwt-code-reviews.appspot.com/1727805/
Affected files:
M user/src/com/google/gwt/user/client/ui/FileUpload.java
Index: user/src/com/google/gwt/user/client/ui/FileUpload.java
===
--- user/src/com/google/gwt/user/client/ui/FileUpload.java (revision 11016)
+++ user/src/com/google/gwt/user/client/ui/FileUpload.java (working copy)
@@ -35,7 +35,7 @@
* {@example com.google.gwt.examples.FormPanelExample}
* /p
*/
-public class FileUpload extends Widget implements HasName,
HasChangeHandlers {
+public class FileUpload extends Widget implements HasName,
HasChangeHandlers, HasEnabled {
/**
* Implementation class for {@link FileUpload}.
*/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add HasEnabled to FileUpload. (issue1614808)
LGTM2! Reposting at http://gwt-code-reviews.appspot.com/1727805 http://gwt-code-reviews.appspot.com/1614808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] MenuItem should use ScheduledCommand instead of Command (issue1732803)
Reviewers: rdayal,
Description:
MenuItem should use ScheduledCommand instead of Command
Repost of 1698803
Thanks Patrick!
Please review this at http://gwt-code-reviews.appspot.com/1732803/
Affected files:
M tools/api-checker/config/gwt24_25userApi.conf
M user/src/com/google/gwt/user/client/ui/MenuBar.java
M user/src/com/google/gwt/user/client/ui/MenuItem.java
M user/src/com/google/gwt/user/client/ui/SuggestBox.java
Index: tools/api-checker/config/gwt24_25userApi.conf
===
--- tools/api-checker/config/gwt24_25userApi.conf (revision 11007)
+++ tools/api-checker/config/gwt24_25userApi.conf (working copy)
@@ -195,3 +195,10 @@
# Adding final modifier to static fields Boolean.TRUE/FALSE
java.lang.Boolean::FALSE FINAL_ADDED
java.lang.Boolean::TRUE FINAL_ADDED
+
+# MenuItem is no longer using Command
+com.google.gwt.user.client.ui.MenuBar::addItem(Lcom/google/gwt/safehtml/shared/SafeHtml;Lcom/google/gwt/user/client/Command;)
OVERRIDABLE_METHOD_ARGUMENT_TYPE_CHANGE
+com.google.gwt.user.client.ui.MenuBar::addItem(Ljava/lang/String;Lcom/google/gwt/user/client/Command;)
OVERRIDABLE_METHOD_ARGUMENT_TYPE_CHANGE
+com.google.gwt.user.client.ui.MenuBar::addItem(Ljava/lang/String;ZLcom/google/gwt/user/client/Command;)
OVERRIDABLE_METHOD_ARGUMENT_TYPE_CHANGE
+com.google.gwt.user.client.ui.MenuItem::getCommand()
OVERRIDABLE_METHOD_RETURN_TYPE_CHANGE
+com.google.gwt.user.client.ui.MenuItem::setCommand(Lcom/google/gwt/user/client/Command;)
OVERRIDABLE_METHOD_ARGUMENT_TYPE_CHANGE
Index: user/src/com/google/gwt/user/client/ui/MenuBar.java
===
--- user/src/com/google/gwt/user/client/ui/MenuBar.java (revision 11007)
+++ user/src/com/google/gwt/user/client/ui/MenuBar.java (working copy)
@@ -19,6 +19,7 @@
import com.google.gwt.aria.client.Roles;
import com.google.gwt.core.client.GWT;
import com.google.gwt.core.client.Scheduler;
+import com.google.gwt.core.client.Scheduler.ScheduledCommand;
import com.google.gwt.dom.client.EventTarget;
import com.google.gwt.event.dom.client.BlurEvent;
import com.google.gwt.event.dom.client.BlurHandler;
@@ -32,7 +33,6 @@
import com.google.gwt.resources.client.ImageResource;
import com.google.gwt.resources.client.ImageResource.ImageOptions;
import com.google.gwt.safehtml.shared.SafeHtml;
-import com.google.gwt.user.client.Command;
import com.google.gwt.user.client.DOM;
import com.google.gwt.user.client.Element;
import com.google.gwt.user.client.Event;
@@ -44,7 +44,7 @@
/**
* A standard menu bar widget. A menu bar can contain any number of menu
items,
- * each of which can either fire a {@link
com.google.gwt.user.client.Command} or
+ * each of which can either fire a {@link
com.google.gwt.core.client.Scheduler.ScheduledCommand} or
* open a cascaded menu bar.
*
* p
@@ -285,7 +285,7 @@
* @param cmd the command to be fired
* @return the {@link MenuItem} object created
*/
- public MenuItem addItem(SafeHtml html, Command cmd) {
+ public MenuItem addItem(SafeHtml html, ScheduledCommand cmd) {
return addItem(new MenuItem(html, cmd));
}
@@ -298,7 +298,7 @@
* @param cmd the command to be fired
* @return the {@link MenuItem} object created
*/
- public MenuItem addItem(String text, boolean asHTML, Command cmd) {
+ public MenuItem addItem(String text, boolean asHTML, ScheduledCommand
cmd) {
return addItem(new MenuItem(text, asHTML, cmd));
}
@@ -335,7 +335,7 @@
* @param cmd the command to be fired
* @return the {@link MenuItem} object created
*/
- public MenuItem addItem(String text, Command cmd) {
+ public MenuItem addItem(String text, ScheduledCommand cmd) {
return addItem(new MenuItem(text, cmd));
}
@@ -893,7 +893,7 @@
// Fire the item's command. The command must be fired in the same
event
// loop or popup blockers will prevent popups from opening.
- final Command cmd = item.getCommand();
+ final ScheduledCommand cmd = item.getCommand();
Scheduler.get().scheduleFinally(new Scheduler.ScheduledCommand() {
@Override
public void execute() {
Index: user/src/com/google/gwt/user/client/ui/MenuItem.java
===
--- user/src/com/google/gwt/user/client/ui/MenuItem.java(revision 11007)
+++ user/src/com/google/gwt/user/client/ui/MenuItem.java(working copy)
@@ -16,15 +16,15 @@
package com.google.gwt.user.client.ui;
import com.google.gwt.aria.client.Roles;
+import com.google.gwt.core.client.Scheduler.ScheduledCommand;
import com.google.gwt.safehtml.client.HasSafeHtml;
import com.google.gwt.safehtml.shared.SafeHtml;
-import com.google.gwt.user.client.Command;
import com.google.gwt.user.client.DOM;
/**
* An entry in a
* {@link com.google.gwt.user.client.ui.MenuBar}. Menu items can either
fire a
- * {@link
[gwt-contrib] Rolling back, breaks other projects. (issue1733803)
Reviewers: rdayal,
Description:
Rolling back, breaks other projects.
*** Original change description ***
MenuItem should use ScheduledCommand instead of Command
Repost of 1698803
Thanks Patrick!
Please review this at http://gwt-code-reviews.appspot.com/1733803/
Affected files:
M tools/api-checker/config/gwt24_25userApi.conf
M user/src/com/google/gwt/user/client/ui/MenuBar.java
M user/src/com/google/gwt/user/client/ui/MenuItem.java
M user/src/com/google/gwt/user/client/ui/SuggestBox.java
Index: tools/api-checker/config/gwt24_25userApi.conf
===
--- tools/api-checker/config/gwt24_25userApi.conf (revision 11016)
+++ tools/api-checker/config/gwt24_25userApi.conf (working copy)
@@ -195,10 +195,3 @@
# Adding final modifier to static fields Boolean.TRUE/FALSE
java.lang.Boolean::FALSE FINAL_ADDED
java.lang.Boolean::TRUE FINAL_ADDED
-
-# MenuItem is no longer using Command
-com.google.gwt.user.client.ui.MenuBar::addItem(Lcom/google/gwt/safehtml/shared/SafeHtml;Lcom/google/gwt/user/client/Command;)
OVERRIDABLE_METHOD_ARGUMENT_TYPE_CHANGE
-com.google.gwt.user.client.ui.MenuBar::addItem(Ljava/lang/String;Lcom/google/gwt/user/client/Command;)
OVERRIDABLE_METHOD_ARGUMENT_TYPE_CHANGE
-com.google.gwt.user.client.ui.MenuBar::addItem(Ljava/lang/String;ZLcom/google/gwt/user/client/Command;)
OVERRIDABLE_METHOD_ARGUMENT_TYPE_CHANGE
-com.google.gwt.user.client.ui.MenuItem::getCommand()
OVERRIDABLE_METHOD_RETURN_TYPE_CHANGE
-com.google.gwt.user.client.ui.MenuItem::setCommand(Lcom/google/gwt/user/client/Command;)
OVERRIDABLE_METHOD_ARGUMENT_TYPE_CHANGE
Index: user/src/com/google/gwt/user/client/ui/MenuBar.java
===
--- user/src/com/google/gwt/user/client/ui/MenuBar.java (revision 11016)
+++ user/src/com/google/gwt/user/client/ui/MenuBar.java (working copy)
@@ -19,7 +19,6 @@
import com.google.gwt.aria.client.Roles;
import com.google.gwt.core.client.GWT;
import com.google.gwt.core.client.Scheduler;
-import com.google.gwt.core.client.Scheduler.ScheduledCommand;
import com.google.gwt.dom.client.EventTarget;
import com.google.gwt.event.dom.client.BlurEvent;
import com.google.gwt.event.dom.client.BlurHandler;
@@ -33,6 +32,7 @@
import com.google.gwt.resources.client.ImageResource;
import com.google.gwt.resources.client.ImageResource.ImageOptions;
import com.google.gwt.safehtml.shared.SafeHtml;
+import com.google.gwt.user.client.Command;
import com.google.gwt.user.client.DOM;
import com.google.gwt.user.client.Element;
import com.google.gwt.user.client.Event;
@@ -44,7 +44,7 @@
/**
* A standard menu bar widget. A menu bar can contain any number of menu
items,
- * each of which can either fire a {@link
com.google.gwt.core.client.Scheduler.ScheduledCommand} or
+ * each of which can either fire a {@link
com.google.gwt.user.client.Command} or
* open a cascaded menu bar.
*
* p
@@ -285,7 +285,7 @@
* @param cmd the command to be fired
* @return the {@link MenuItem} object created
*/
- public MenuItem addItem(SafeHtml html, ScheduledCommand cmd) {
+ public MenuItem addItem(SafeHtml html, Command cmd) {
return addItem(new MenuItem(html, cmd));
}
@@ -298,7 +298,7 @@
* @param cmd the command to be fired
* @return the {@link MenuItem} object created
*/
- public MenuItem addItem(String text, boolean asHTML, ScheduledCommand
cmd) {
+ public MenuItem addItem(String text, boolean asHTML, Command cmd) {
return addItem(new MenuItem(text, asHTML, cmd));
}
@@ -335,7 +335,7 @@
* @param cmd the command to be fired
* @return the {@link MenuItem} object created
*/
- public MenuItem addItem(String text, ScheduledCommand cmd) {
+ public MenuItem addItem(String text, Command cmd) {
return addItem(new MenuItem(text, cmd));
}
@@ -893,7 +893,7 @@
// Fire the item's command. The command must be fired in the same
event
// loop or popup blockers will prevent popups from opening.
- final ScheduledCommand cmd = item.getCommand();
+ final Command cmd = item.getCommand();
Scheduler.get().scheduleFinally(new Scheduler.ScheduledCommand() {
@Override
public void execute() {
Index: user/src/com/google/gwt/user/client/ui/MenuItem.java
===
--- user/src/com/google/gwt/user/client/ui/MenuItem.java(revision 11016)
+++ user/src/com/google/gwt/user/client/ui/MenuItem.java(working copy)
@@ -16,15 +16,15 @@
package com.google.gwt.user.client.ui;
import com.google.gwt.aria.client.Roles;
-import com.google.gwt.core.client.Scheduler.ScheduledCommand;
import com.google.gwt.safehtml.client.HasSafeHtml;
import com.google.gwt.safehtml.shared.SafeHtml;
+import com.google.gwt.user.client.Command;
import com.google.gwt.user.client.DOM;
/**
* An entry in a
* {@link
[gwt-contrib] Re: Rolling back, breaks other projects. (issue1733803)
Submitting TBR http://gwt-code-reviews.appspot.com/1733803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add HasEnabled to FileUpload. (issue1614808)
Submitted as r11023 http://gwt-code-reviews.appspot.com/1614808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Add HasEnabled to FileUpload. (issue1727805)
Submitted as r11023 http://gwt-code-reviews.appspot.com/1727805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Integrate SuperDevMode to the build and deploy as Maven artifact (issue1734803)
Reviewers: skybrian, cromwellian,
Description:
Integrate SuperDevMode to the build and deploy as Maven artifact
Please review this at https://gwt-code-reviews.appspot.com/1734803/
Affected files:
M build.xml
M distro-source/build.xml
M maven/lib-gwt.sh
A maven/poms/gwt/gwt-codeserver/pom-template.xml
Index: build.xml
diff --git a/build.xml b/build.xml
index
90376e896443fac51449019262c23890111ba4f3..ad7b34a7e3c3851d8bb87f49a69f5d142c76ff31
100755
--- a/build.xml
+++ b/build.xml
@@ -36,6 +36,7 @@
target name=buildonly
description=[action] Minimal one-platform devel build, without
distro packaging
call-subproject subproject=dev subtarget=build /
+call-subproject subproject=codeserver subtarget=build /
call-subproject subproject=user subtarget=build /
call-subproject subproject=requestfactory subtarget=build /
call-subproject subproject=servlet subtarget=build /
@@ -53,6 +54,12 @@
target name=dev description=[subdir] Builds (or runs ${target} if
set) all the dev libraries
call-subproject subproject=buildtools subtarget=build /
gwt.ant dir=dev /
+gwt.ant dir=dev/codeserver /
+ /target
+
+ target name=codeserver description=[subdir] Builds (or runs
${target} if set) only the SuperDevMode
+call-subproject subproject=dev subtarget=build /
+gwt.ant dir=dev/codeserver /
/target
target name=user description=[subdir] Builds (or runs ${target} if
set) only the user library
@@ -101,6 +108,7 @@
target name=build description=[action] Builds GWT, including
samples, but without distro packaging
call-subproject subproject=dev subtarget=build/
+call-subproject subproject=codeserver subtarget=build/
call-subproject subproject=user subtarget=build/
call-subproject subproject=requestfactory subtarget=build/
call-subproject subproject=servlet subtarget=build/
@@ -112,6 +120,7 @@
target name=checkstyle description=[action] Does static analysis of
GWT source
call-subproject subproject=buildtools subtarget=checkstyle /
call-subproject subproject=dev subtarget=checkstyle /
+call-subproject subproject=codeserver subtarget=checkstyle /
call-subproject subproject=user subtarget=checkstyle /
call-subproject subproject=requestfactory subtarget=checkstyle /
call-subproject subproject=servlet subtarget=checkstyle /
@@ -123,6 +132,7 @@
description=[action] Runs all the GWT tests, including
checkstyle and apicheck
call-subproject subproject=buildtools subtarget=test /
call-subproject subproject=dev subtarget=test /
+call-subproject subproject=codeserver subtarget=test /
call-subproject subproject=user subtarget=test /
call-subproject subproject=requestfactory subtarget=test /
call-subproject subproject=servlet subtarget=test /
Index: distro-source/build.xml
diff --git a/distro-source/build.xml b/distro-source/build.xml
index
5d2303119f4624831a5d2907c5ed0bd235f42fe0..791aef689c1fa7c3d9e220b18ae149ea1ce9d648
100755
--- a/distro-source/build.xml
+++ b/distro-source/build.xml
@@ -22,6 +22,7 @@
zipfileset file=${gwt.build.lib}/gwt-dev.jar
prefix=${project.distname} /
zipfileset file=${gwt.build.lib}/gwt-user.jar
prefix=${project.distname} /
zipfileset file=${gwt.build.lib}/gwt-servlet.jar
prefix=${project.distname} /
+ zipfileset file=${gwt.build.lib}/gwt-codeserver.jar
prefix=${project.distname} /
zipfileset file=${gwt.build.lib}/gwt-servlet-deps.jar
prefix=${project.distname} /
zipfileset file=${gwt.build.lib}/gwt-benchmark-viewer.war
prefix=${project.distname} /
zipfileset file=${gwt.build.lib}/gwt-soyc-vis.jar
prefix=${project.distname} /
Index: maven/lib-gwt.sh
diff --git a/maven/lib-gwt.sh b/maven/lib-gwt.sh
index
330986b464eb051bf485e45558493d2f16cab277..c8f54124c7beaa8da412cf00ffdfbf6464dc5e03
100644
--- a/maven/lib-gwt.sh
+++ b/maven/lib-gwt.sh
@@ -93,7 +93,7 @@ function maven-gwt() {
zip -d $GWT_EXTRACT_DIR/requestfactory-${i}.jar org/json/*
done
- for i in dev user servlet
+ for i in dev user servlet codeserver
do
CUR_FILE=`ls $GWT_EXTRACT_DIR/gwt-${i}.jar`
@@ -122,7 +122,7 @@ function maven-gwt() {
# push parent poms
maven-deploy-file $mavenRepoUrl $mavenRepoId $pomDir/gwt/pom.xml
$pomDir/gwt/pom.xml
- for i in dev user servlet
+ for i in dev user servlet codeserver
do
CUR_FILE=`ls $GWT_EXTRACT_DIR/gwt-${i}.jar`
gwtPomFile=$pomDir/gwt/gwt-$i/pom.xml
Index: maven/poms/gwt/gwt-codeserver/pom-template.xml
diff --git a/maven/poms/gwt/gwt-codeserver/pom-template.xml
b/maven/poms/gwt/gwt-codeserver/pom-template.xml
new file mode 100644
index
..160328fd0689afbd59eb4448d2832e3a4334c28f
--- /dev/null
+++ b/maven/poms/gwt/gwt-codeserver/pom-template.xml
@@ -0,0 +1,23 @@
+?xml version=1.0 encoding=UTF-8?
+project xmlns=http://maven.apache.org/POM/4.0.0;
+
[gwt-contrib] Re: Integrate SuperDevMode to the build and deploy as Maven artifact (issue1734803)
LGTM. Thanks! https://gwt-code-reviews.appspot.com/1734803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fix !important css typo (issue1725806)
Reviewers: rdayal,
Description:
Fix !important css typo
Repost of 1585805.
Thanks Stephen!
Please review this at http://gwt-code-reviews.appspot.com/1725806/
Affected files:
M
dev/core/src/com/google/gwt/core/ext/linker/impl/installLocationIframe.js
Index:
dev/core/src/com/google/gwt/core/ext/linker/impl/installLocationIframe.js
===
---
dev/core/src/com/google/gwt/core/ext/linker/impl/installLocationIframe.js
(revision 11024)
+++
dev/core/src/com/google/gwt/core/ext/linker/impl/installLocationIframe.js
(working copy)
@@ -27,7 +27,8 @@
var scriptFrame = $doc.createElement('iframe');
scriptFrame.src = 'javascript:';
scriptFrame.id = '__MODULE_NAME__';
- scriptFrame.style.cssText = 'position:absolute; width:0; height:0;
border:none; left: -1000px; top: -1000px; !important';
+ scriptFrame.style.cssText = 'position:absolute; width:0; height:0;
border:none; left: -1000px;'
++ ' top: -1000px;';
scriptFrame.tabIndex = -1;
$doc.body.appendChild(scriptFrame);
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix !important css typo (issue1585805)
LGTM. Reposting at http://gwt-code-reviews.appspot.com/1725806 http://gwt-code-reviews.appspot.com/1585805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix !important css typo (issue1585805)
Submitted as r11025 http://gwt-code-reviews.appspot.com/1585805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix !important css typo (issue1725806)
Submitted as r11025 http://gwt-code-reviews.appspot.com/1725806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fix showcase lastNameColumn/ageColumn typo (issue1728804)
Reviewers: rdayal,
Description:
Fix showcase lastNameColumn/ageColumn typo
Repost of 1602803.
Thanks Stephen!
Please review this at http://gwt-code-reviews.appspot.com/1728804/
Affected files:
M
samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwDataGrid.java
Index:
samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwDataGrid.java
===
---
samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwDataGrid.java
(revision 11025)
+++
samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwDataGrid.java
(working copy)
@@ -276,7 +276,7 @@
return object.getAge();
}
};
-lastNameColumn.setSortable(true);
+ageColumn.setSortable(true);
sortHandler.setComparator(ageColumn, new ComparatorContactInfo() {
@Override
public int compare(ContactInfo o1, ContactInfo o2) {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Fix showcase lastNameColumn/ageColumn typo (issue1602803)
LGTM. Reposting at http://gwt-code-reviews.appspot.com/1728804 http://gwt-code-reviews.appspot.com/1602803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix showcase lastNameColumn/ageColumn typo (issue1602803)
Submitted as r11026 http://gwt-code-reviews.appspot.com/1602803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix showcase lastNameColumn/ageColumn typo (issue1728804)
Submitted as r11026 http://gwt-code-reviews.appspot.com/1728804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Checkstyle fixes (issue1565806)
Reviewers: rjrjr, rdayal, rchandia,
Message:
Please keep the license header as it was before.
Done.
Please review this at http://gwt-code-reviews.appspot.com/1565806/
Affected files:
M
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
M dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
M user/src/com/google/gwt/geolocation/client/Position.java
M user/src/com/google/gwt/i18n/shared/AlternateMessageSelector.java
M
user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java
M user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
M
user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java
M user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java
M user/test/com/google/gwt/editor/client/DirtyEditorTest.java
M user/test/com/google/gwt/emultest/java/util/TreeMapTest.java
M user/test/com/google/gwt/user/server/rpc/RPCTypeCheckTest.java
Index:
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
diff --git
a/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
b/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
index
5df3c26269f08649a4de37e9c05aa538b7a78be9..9111d097fb25758db53d3e72f2c00d70abe66554
100644
---
a/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
+++
b/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
@@ -84,7 +84,7 @@ public class StandardPublicResource extends
PublicResource {
try {
return resource.openContents();
} catch (IOException ex) {
- logger.log (TreeLogger.ERROR, Problem reading resource: +
resource.getLocation(), ex);
+ logger.log(TreeLogger.ERROR, Problem reading resource: +
resource.getLocation(), ex);
throw new UnableToCompleteException();
}
}
Index: dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
diff --git a/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
b/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
index
36cb77753045ea98ff722d71bc63bee732a0756d..c3fe75cd64217800ffaf4012adb7019bc21d6438
100644
--- a/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
+++ b/dev/core/src/com/google/gwt/dev/cfg/BindingProperty.java
@@ -179,8 +179,7 @@ public class BindingProperty extends Property {
LinkedListString childList = fallbackValues.get(from);
LinkedHashSetString children = new LinkedHashSetString();
children.addAll(childList);
-while (children != null children.size() 0)
-{
+while (children != null children.size() 0) {
alternates.add(children);
LinkedHashSetString newChildren = new LinkedHashSetString();
for (String child : children) {
Index: user/src/com/google/gwt/geolocation/client/Position.java
diff --git a/user/src/com/google/gwt/geolocation/client/Position.java
b/user/src/com/google/gwt/geolocation/client/Position.java
index
88c51294b4c6f71ed5e731f2e1483e85c0ea6884..477d3b3fbb54a4f1a7127095e3c755e577a12da2
100644
--- a/user/src/com/google/gwt/geolocation/client/Position.java
+++ b/user/src/com/google/gwt/geolocation/client/Position.java
@@ -28,12 +28,12 @@ public interface Position {
/**
* Returns information about the coordinates reported by the browser.
*/
- public Coordinates getCoordinates();
+ Coordinates getCoordinates();
/**
* Returns the time this position was reported by the browser.
*/
- public double getTimestamp();
+ double getTimestamp();
/**
* Represents position reported by the browser.
@@ -44,7 +44,7 @@ public interface Position {
/**
* Returns the estimated accuracy reported by the browser, in meters.
*/
-public double getAccuracy();
+double getAccuracy();
/**
* Returns the altitude reported by the browser, in meters, above the
a
@@ -52,37 +52,37 @@ public interface Position {
* ellipsoid/a, or codenull/code if the browser did not report an
* altitude.
*/
-public Double getAltitude();
+Double getAltitude();
/**
* Returns the estimated accuracy of the altitude reported by the
browser,
* in meters, or codenull/code if the browser did not report an
* accuracy.
*/
-public Double getAltitudeAccuracy();
+Double getAltitudeAccuracy();
/**
* Returns the heading, in degrees from due north, reported by the
browser,
* based on previous calls to get the user's position, or
codenull/code
* if the browser did not report a heading.
*/
-public Double getHeading();
+Double getHeading();
/**
* Returns the decimal latitude reported by the browser.
*/
-public double getLatitude();
+double getLatitude();
/**
* Returns the decimal longitude reported by the browser.
*/
-public double
[gwt-contrib] Re: Add javadocs for ExternalTextResource.getText, fixes #7035 (issue1605803)
Yes, please. The license in particular should stay as it was before. Done. http://gwt-code-reviews.appspot.com/1605803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
