Re: [gwt-contrib] Contributing for University Software Engineering Project
On Sat, Jan 12, 2013 at 5:35 PM, William Thomas wrote: > What we need now is some sort of proof that our fixes, when the time > comes, will be accepted at some point. Is there a place to ask, or a person > to contact, that can let us know that fixes will be accepted? Obviously > this depends on the actual nature of our fixes but for the purpose of this > assignment, it's assumed that we can fix these problems. We are both new to > contributing to open source projects and any information will be helpful to > us. > > This group is a good place to ask, but if you are fixing what is acknowledged as a bug, sign a CLA, and follow the coding standards, I would expect there to be no problem accepting the fix. Note that the 7891 issue was marked as "AsDesigned", so you will probably have some work to do to convince others that it is actually a bug. The other issue is that trunk is currently locked while 2.5.1 is prepared, so if you need to get your work committed before 2.5.1 ships (likely early February) that will be a problem. -- John A. Tamplin -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Contributing for University Software Engineering Project
Hello all, a friend of mine and I are enrolled in a software engineering course at a university for computer science and, for our first project, we must contribute to an open source project. We have chosen GWT for our project, as it's Java-based and we both have experience with that language as well as general web development. For our project we must implement two feature requests or bug fixes, but by Wednesday we need to have those issues chosen and proof that we can build the project from the source code and replicate them. Here are the two issues we have chosen that were able to replicate: http://code.google.com/p/google-web-toolkit/issues/detail?id=7876 http://code.google.com/p/google-web-toolkit/issues/detail?id=7891 What we need now is some sort of proof that our fixes, when the time comes, will be accepted at some point. Is there a place to ask, or a person to contact, that can let us know that fixes will be accepted? Obviously this depends on the actual nature of our fixes but for the purpose of this assignment, it's assumed that we can fix these problems. We are both new to contributing to open source projects and any information will be helpful to us. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] GWT 2.5.1 release - Call for help
Repost from gwt-steering: Hi Everyone, a quick status update. In the last week a lot of patches have been contributed and some have already been submitted. At the beginning of next week I want to close of for any new patches, so that we can finish the work we are started. We are aiming for a code freeze at the 24th of Januar and a release a short time after that. So once again, if you feel strongly that you need to have something included in GWT 2.5.1 now is the time to act. We also have a couple of open issues that we would like to see in GWT 2.5.1, but might not make it (see: https://docs.google.com/spreadsheet/ccc?key=0AuK8EZ6jAAQrdDk1ME1lcmtWOWt3MngxOUlTMGJSVEE ). Feel free to to contribute patches and do code reviews on the issues listed in the document. -Daniel On Saturday, January 12, 2013 4:17:29 PM UTC+1, Thomas Broyer wrote: > > > > On Saturday, January 12, 2013 3:40:42 PM UTC+1, Julien Dramaix wrote: >> >> It would be nice to adapt the following paragraph [1] to explain the >> procedure for submitting code in gerrit. This paragraph is >> still mentioning svn >> >> >> [1] : >> https://developers.google.com/web-toolkit/makinggwtbetter?#submittingpatches >> > > I think the idea was to wait until the move to Git is complete. For now > the Git repo is still a mirror of the SVN repo (git-svn) which is a mirror > of Google's internal Perforce. > To complete the move, we'll rewrite the history to remove all big files > (prebuilt plugins and api-checker reference jars) so all contributors will > have to re-sync their Git repo. > So in the mean time, SVN and Rietveld is still OK, though "deprecated". > >> -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Issue 7112 (issue1649803)
http://gwt-code-reviews.appspot.com/1649803/diff/1/src/test/java/com/google/gwt/junit/client/impl/JUnitHost.java File src/test/java/com/google/gwt/junit/client/impl/JUnitHost.java (right): http://gwt-code-reviews.appspot.com/1649803/diff/1/src/test/java/com/google/gwt/junit/client/impl/JUnitHost.java#newcode152 src/test/java/com/google/gwt/junit/client/impl/JUnitHost.java:152: We're in dev-time code so we can use Guava (the re-packaged one) and it's Objects.equal(a, b) which takes care of nulls. http://gwt-code-reviews.appspot.com/1649803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] GWT 2.5.1 release - Call for help
On Saturday, January 12, 2013 3:40:42 PM UTC+1, Julien Dramaix wrote: > > It would be nice to adapt the following paragraph [1] to explain the > procedure for submitting code in gerrit. This paragraph is > still mentioning svn > > > [1] : > https://developers.google.com/web-toolkit/makinggwtbetter?#submittingpatches > I think the idea was to wait until the move to Git is complete. For now the Git repo is still a mirror of the SVN repo (git-svn) which is a mirror of Google's internal Perforce. To complete the move, we'll rewrite the history to remove all big files (prebuilt plugins and api-checker reference jars) so all contributors will have to re-sync their Git repo. So in the mean time, SVN and Rietveld is still OK, though "deprecated". > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] GWT 2.5.1 release - Call for help
It would be nice to adapt the following paragraph [1] to explain the procedure for submitting code in gerrit. This paragraph is still mentioning svn [1] : https://developers.google.com/web-toolkit/makinggwtbetter?#submittingpatches On Thursday, January 10, 2013 11:12:14 AM UTC+1, Thomas Broyer wrote: > > > > On Thursday, January 10, 2013 5:54:16 AM UTC+1, Andrew Bachmann wrote: >> >> Presumably all issues that are already FixedNotReleased are going to make >> it into 2.5.1? >> > > Yes. We chose to cut 2.5.1 from trunk rather than cherrypicking changes to > releases/2.5. > >> -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Git commit messages
+1 Also, see the Discussion section at http://www.kernel.org/pub/software/scm/git/docs/git-commit.html For issues, Gerrit has a feature where using a specific footer line (a line similar to Change-Id, e.g. "Issue:") allows you to search for reviews by the issue number. But I'm fine with just using "issue " (not capitalized) in the message, something Gerrit, as currently configured, links to the tracker. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
