[gwt-contrib] Change in gwt[master]: Issue 7834 - fix BigDecimal compareTo
Thomas Broyer has posted comments on this change. Change subject: Issue 7834 - fix BigDecimal compareTo .. Patch Set 2: Code-Review+1 SGTM (not sure I understood all the changes though; someone else please have an in-depth look as well) -- To view, visit https://gwt-review.googlesource.com/1660 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9874897f54a9eb6ce15f5b7b6295613800a25b72 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: DateBox (DatePicker) still allows user to choose disabled dates with mouse click (issue1885803)
According to
http://code.google.com/p/google-web-toolkit/issues/detail?id=7919 it
worked the way you describe in GWT 2.4 so let's go ahead and fix this.
Apparently the regression was introduced in
https://code.google.com/p/google-web-toolkit/source/detail?r=11174
Daniel: how's 2.5.1 going? is it too late to put this patch in? it's a
regression so I'd like to see it fixed as early as possible.
http://gwt-code-reviews.appspot.com/1885803/diff/3001/user/src/com/google/gwt/user/datepicker/client/CellGridImpl.java
File user/src/com/google/gwt/user/datepicker/client/CellGridImpl.java
(right):
http://gwt-code-reviews.appspot.com/1885803/diff/3001/user/src/com/google/gwt/user/datepicker/client/CellGridImpl.java#newcode271
user/src/com/google/gwt/user/datepicker/client/CellGridImpl.java:271: if
(!cell.isEnabled()) {
Apparently (form the following lines), this method can be called with
'null'.
Replacing the cell.isEnabled() check with isActive(cell) (which does the
null-check) won't help here as we would return when cell==null,
introducing a change in behavior.
It seems to me like all the calls to setSelected in GWT's codebase (I
suspect Google extend/uses this class internally in their own projects)
but one are guarded by an 'if (isActive(cell))' check, so let's add that
check around the call that's missing it and not change setSelected
behavior's.
http://gwt-code-reviews.appspot.com/1885803/
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Proxy IDs have to be the same for a given proxy in the respo...
Matthew Dempsky has posted comments on this change. Change subject: Proxy IDs have to be the same for a given proxy in the response payload. .. Patch Set 2: Code-Review+1 I don't completely grok this, but the tests and patch look reasonable to me. -- To view, visit https://gwt-review.googlesource.com/1770 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c2ccbcfc67323e9e5cae214b0d101ddfc1a2298 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: fixes ISSUE 7752 added constructor for java.util.logging.Lev...
Matthew Dempsky has posted comments on this change. Change subject: fixes ISSUE 7752 added constructor for java.util.logging.Level gwt emulation to be compatible with JRE .. Patch Set 4: What would happen even those fields doesn't compile out? We are talking about just extra class and two fields in the output, right? I believe so. This looks like it should be the same as it was in 2.4.0, so it shouldn't be a regression from that in terms of output size. -- To view, visit https://gwt-review.googlesource.com/1650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf7297eef0d7e892054baecfe3e1a023001e0325 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Unnur Gretarsdottir unn...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: incremental dev mode
Stephen, I came up with the same idea. We are working on a rather large GWT project, and the speed of dev mode is atrocious (30-45 second refresh on an i7 with 32GB ram). I understand why GWT compiles the way it does for production mode, but it seems it seems incredibly inefficient to have to basically go through the whole refresh every time a relatively small change occurs. I am way over my head when it comes to understanding the compiler, but I was thinking along the lines of something like annotation processors that would essentially generate a whole bunch of code to support dev mode that would prevent having to do all this oracle building each time. Something like this couldn't come fast enough, as far as I'm concerned. Just wanted to voice my agreement and support. If you need a tester, let me know. Josh On Wednesday, December 12, 2012 11:18:15 PM UTC-5, Stephen Haberman wrote: Hey, Since Thomas brought up changes to dev mode, I've been thinking about how to implement an incremental dev mode. After playing with SuperDevMode, it is better (no extensions/etc.), but AFAICT it still starts over from let's build a ResourceOracle, now let's build a TypeOracle, etc. Seems like we should be able to reuse ResourceOracle, TypeOracle, etc., instances across compiles. And really, have the notion of invoking GWT dev mode compiles go away altogether. E.g. hook into Eclipse, and during auto builds have the JS files on disk just magically get updated after each save. I've been spiking an Eclipse plugin, which seems not as hard as I thought it would be, which incrementally generates .jribble files as .java/.class files change, with the idea of not embedding ecj anymore. That's a slightly separate topic though. The only thing that seems impossible with incremental compiles is preserving the semantics that code generators see--currently they are very deterministic/batch, and this would change all of that. But for the better, I think. (It would invert how GWT currently works--it's a batch system that sometimes we force (badly) to be incremental, to being an incremental system which sometimes you could run in batch (on the CLI).) Does this seem terribly egregious? I think if it worked, it would result in dramatic productivity improvements--the goal would be faster than coffeescript (or whatever) compiles, and truly instant refreshes after making changes. - Stephen -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Inline javascript:'' within NamedFrame's internal SafeHtmlTe...
Matthew Dempsky has abandoned this change. Change subject: Inline javascript:'' within NamedFrame's internal SafeHtmlTemplate .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/1800 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic96c36b3f98705fff8a7638c8975901c50856951 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Issue 7112 (issue1649803)
On 2013/01/12 15:35:19, tbroyer wrote: We're in dev-time code so we can use Guava (the re-packaged one) and it's Objects.equal(a, b) which takes care of nulls. I don't think that's true. This code still needs to be translatable to JavaScript to support running tests in production mode, and I don't believe our thirdparty.guava package is available for translation. Maybe in the future we can utilize JDK7's Objects.equals(), but at the moment we have to resort to reimplementing it ourselves here I think. http://gwt-code-reviews.appspot.com/1649803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Issue 7112 (issue1649803)
On 2013/01/28 21:06:02, mdempsky wrote: On 2013/01/12 15:35:19, tbroyer wrote: We're in dev-time code so we can use Guava (the re-packaged one) and it's Objects.equal(a, b) which takes care of nulls. I don't think that's true. This code still needs to be translatable to JavaScript to support running tests in production mode D'oh, you're right indeed! Still, adding a 'private boolean equals(Object x, Object y)' method would make the code easier to read. http://gwt-code-reviews.appspot.com/1649803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] source maps in chrome
Hi, I have the same problem using chrome 25.0.1364.45 beta and gwt 2.5.0. Do we have to use the trunk of gwt for it to work? On Friday, January 25, 2013 3:43:40 AM UTC+1, Brian Slesinsky wrote: I've tried it recently with Chrome 25. You've checked the source maps on checkbox and reloaded the page? On Tuesday, January 22, 2013 1:08:41 PM UTC-8, Daniel Kurka wrote: I can`t seem to get source maps working with Chrome 24. Is it just me or is there still something off? On Friday, November 30, 2012 2:15:31 AM UTC+1, Ray Cromwell wrote: https://gwt-review.googlesource.com/#/c/1300/1 On Wed, Nov 28, 2012 at 11:02 AM, Stephen Haberman ste...@exigencecorp.com wrote: Chrome 24 introduced a bug, I'm working on a fix. Awesome, thanks for the quick reply--I updated the issue appropriately. - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] GWT.RunAsync and JAVA switch
Hello,
The two code structure ensure that the javascript generated by GWT will be
properly splitted ?
GWT.runAsync(new RunAsyncCallback() {
@Override
public void onFailure(Throwable reason) {
...
}
@Override
public void onSuccess() {
switch(value){
case 0: ... ;break;
case 1: ... ;break;
}
or
switch(value){
case 1:
GWT.runAsync(new RunAsyncCallback() {
@Override
public void onFailure(Throwable reason) {
...
}
@Override
public void onSuccess() {
...
}
break;
case 2:
GWT.runAsync(new RunAsyncCallback() {
@Override
public void onFailure(Throwable reason) {
...
}
@Override
public void onSuccess() {
...
}
break;
...
}
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups
Google Web Toolkit Contributors group.
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Proxy IDs have to be the same for a given proxy in the respo...
Thomas Broyer has posted comments on this change.
Change subject: Proxy IDs have to be the same for a given proxy in the
response payload.
..
Patch Set 2:
The problem is that we have 2 ways of identifying an object: using it's
proxy type in both case and either a client ID or server ID.
The client ID is scoped to a RequestContext and only used for a)
EntityProxies created on the client-side (known as ephemeral ID), b)
ValueProxies wherever they come from (ValueProxies don't have IDs, we're
synthetizing ones for cross-reference in the request/response payload). For
EntityProxies originating from the server, only the server ID is ever used
(aka persistent ID).
When persisting an EntityProxy created on the client on the server, it's
then given a server ID (transitions from ephemeral to persistent ID, and
now has both client –so it can be matched back to the proxy on the
client-side– and server –so it can be referenced in subsequent requests–
IDs).
Now to our problem: the SimpleProxyId's hashCode is based on whether it has
a client ID or not: if it has one, it's used as the hashCode, otherwise the
serverId's hashCode is used. So, when we receive
{T:type, S:serverId, C:1} and {T:type, S:serverId},
they're conceptually identical, but technically have different hashCodes.
Because the SimpleProxyId is used as a key to the proxy in a map, those 2
IDs in the same response would map to different proxies (so one of them
won't ever be populated; and because proxies are lazily created,
but finalized only based on a specific list, one of those proxies won't
be finalized either, and will generate a don't cross the streams
exception when used in another RequestContext).
This patch makes sure we'd always use {T:type, S:serverId, C:1}
everywhere in the response payload.
BTW, SimpleProxyId#equals violates the contract, as it's not symmetric.
This is another problem that we hopefully never run into.
--
To view, visit https://gwt-review.googlesource.com/1770
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c2ccbcfc67323e9e5cae214b0d101ddfc1a2298
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Thomas Broyer t.bro...@gmail.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] GWT.RunAsync and JAVA switch
Hi Cédric,
I am not sure I understood your question, but in the first example case 0
and case 1 will be part of the same code fragment (will not be split),
whereas in the second example case 0 and case 1 code may be split.
Roberto Lublinerman | Software Engineer | rlu...@google.com | 408-500-9148
On Sun, Jan 27, 2013 at 4:25 PM, Cédric Barbet cedric.bar...@gmail.comwrote:
Hello,
The two code structure ensure that the javascript generated by GWT will be
properly splitted ?
GWT.runAsync(new RunAsyncCallback() {
@Override
public void onFailure(Throwable reason) {
...
}
@Override
public void onSuccess() {
switch(value){
case 0: ... ;break;
case 1: ... ;break;
}
or
switch(value){
case 1:
GWT.runAsync(new RunAsyncCallback() {
@Override
public void onFailure(Throwable reason) {
...
}
@Override
public void onSuccess() {
...
}
break;
case 2:
GWT.runAsync(new RunAsyncCallback() {
@Override
public void onFailure(Throwable reason) {
...
}
@Override
public void onSuccess() {
...
}
break;
...
}
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups
Google Web Toolkit Contributors group.
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups
Google Web Toolkit Contributors group.
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Updates ICU4J from 4.4.2 to 50.1.1
Hello Andrew Bachmann,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/1700
to look at the new patch set (#3).
Change subject: Updates ICU4J from 4.4.2 to 50.1.1
..
Updates ICU4J from 4.4.2 to 50.1.1
GWT uses ICU4J for formatting dates and times in translated messages.
See com.google.gwt.i18n.rebind.DateTimePatternGenerator.
For example, the token {0,localdatetime:tz=$tz,yMd hms} was previously
rendered as
2/1/2010 7:04:05 PM in English and is now rendered as 2/1/2010, 7:04:05
PM
(with an extra comma). Other major changes to ICU4J since 4.4.2 are
available from
this web page: http://site.icu-project.org/download
Contributed by: j...@jaet.org
Change-Id: I75c9e0e07c4d29a75573701a676a19d6e83b91d9
Review-Link: https://gwt-review.googlesource.com/#/c/1700/
---
M dev/build.xml
M eclipse/external/cldr-tools/.classpath
M eclipse/tools/cldr-import/.classpath
M eclipse/user/.classpath
M user/test/com/google/gwt/i18n/client/I18N2Test.java
5 files changed, 11 insertions(+), 11 deletions(-)
--
To view, visit https://gwt-review.googlesource.com/1700
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75c9e0e07c4d29a75573701a676a19d6e83b91d9
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Andrew Bachmann andrewbachm...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Issue 7834 - fix BigDecimal compareTo
Brian Slesinsky has posted comments on this change.
Change subject: Issue 7834 - fix BigDecimal compareTo
..
Patch Set 2:
(3 comments)
Could you simplify this code? I don't see the bug either.
File user/super/com/google/gwt/emul/java/math/BigDecimal.java
Line 658: } catch (StringIndexOutOfBoundsException e) {
Can this exception happen anymore?
Line 2612: // To skip a possible '+' symbol
update comment
Line 2613: if ((offset last) ((val[offset] == '+') || (val[offset]
== '-'))) {
This code seems overly complicated because after identifying special cases
we're falling through, so the rest of the code still has to deal with them.
It seems like it would be clearer to handle them separately and return
early:
if (offset == last) {
// empty string. What should this do?
return ...
}
if (val[offset] == '+' || val[offset] == '-') {
if (val[offset] == '-') {
unscaledBuffer.append('-');
}
offset++;
if (offset==last) {
// ... just a + or -. Is this a number?
return or throw something
}
if (val[offset] == '+' || val[offset] == '-') {
// extra sign
throw ...
}
}
// skip leading zeros
while (offset last val[offset] == '0') {
offset++;
}
if (offset == last) {
// it's zero.
return ...
}
--
To view, visit https://gwt-review.googlesource.com/1660
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9874897f54a9eb6ce15f5b7b6295613800a25b72
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] source maps in chrome
On Monday, January 28, 2013 9:54:29 AM UTC+1, Gaspard van Ko wrote: Hi, I have the same problem using chrome 25.0.1364.45 beta and gwt 2.5.0. Do we have to use the trunk of gwt for it to work? Yes. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Updates ICU4J from 4.4.2 to 50.1.1
Andrew Bachmann has posted comments on this change. Change subject: Updates ICU4J from 4.4.2 to 50.1.1 .. Patch Set 3: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/1700 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75c9e0e07c4d29a75573701a676a19d6e83b91d9 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Andrew Bachmann andrewbachm...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
