[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...
Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3180 to look at the new patch set (#10). Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 .. adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246 Review-Link: https://gwt-review.googlesource.com/#/c/3180/ --- M user/super/com/google/gwt/emul/java/lang/Byte.java M user/super/com/google/gwt/emul/java/lang/Double.java M user/super/com/google/gwt/emul/java/lang/Float.java M user/super/com/google/gwt/emul/java/lang/Integer.java M user/super/com/google/gwt/emul/java/lang/Long.java M user/super/com/google/gwt/emul/java/lang/Short.java M user/test/com/google/gwt/emultest/java/lang/ByteTest.java M user/test/com/google/gwt/emultest/java/lang/FloatTest.java M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java M user/test/com/google/gwt/emultest/java/lang/LongTest.java M user/test/com/google/gwt/emultest/java/lang/ShortTest.java 11 files changed, 91 insertions(+), 43 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3180 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246 Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...
Daniel Kurka has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
..
Patch Set 9:
(6 comments)
File user/super/com/google/gwt/emul/java/lang/Byte.java
Line 37: return Integer.compare(x, y);
Done
File user/super/com/google/gwt/emul/java/lang/Float.java
Line 37: if (isNaN(x)) {
changed order
File user/super/com/google/gwt/emul/java/lang/Integer.java
Line 61: return signum(x - y);
see:
https://code.google.com/p/google-web-toolkit/issues/detail?id=8185thanks=8185
File user/super/com/google/gwt/emul/java/lang/Short.java
Line 37: return Integer.compare(x, y);
Done
File user/test/com/google/gwt/emultest/java/lang/FloatTest.java
Line 81: }
see:
https://code.google.com/p/google-web-toolkit/issues/detail?id=8185thanks=8185
File user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
Line 120: assertEquals(0, Integer.compare(1, 1));
Let's deal with the corner cases in another CL:
https://code.google.com/p/google-web-toolkit/issues/detail?id=8185
--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...
Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3180 to look at the new patch set (#11). Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 .. adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246 Review-Link: https://gwt-review.googlesource.com/#/c/3180/ --- M user/super/com/google/gwt/emul/java/lang/Byte.java M user/super/com/google/gwt/emul/java/lang/Float.java M user/super/com/google/gwt/emul/java/lang/Integer.java M user/super/com/google/gwt/emul/java/lang/Long.java M user/super/com/google/gwt/emul/java/lang/Short.java M user/test/com/google/gwt/emultest/java/lang/ByteTest.java M user/test/com/google/gwt/emultest/java/lang/FloatTest.java M user/test/com/google/gwt/emultest/java/lang/IntegerTest.java M user/test/com/google/gwt/emultest/java/lang/LongTest.java M user/test/com/google/gwt/emultest/java/lang/ShortTest.java 10 files changed, 83 insertions(+), 35 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3180 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246 Gerrit-PatchSet: 11 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Remove unused, package-private FastStringMap.
Manuel Carrasco Moñino has posted comments on this change. Change subject: Remove unused, package-private FastStringMap. .. Patch Set 1: Code-Review+1 LGTM -- To view, visit https://gwt-review.googlesource.com/3280 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dd9f897a044ba53be5fc74fabb40a382b9ef119 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Work to do for bug 3042
Hi, as I wrote in the issuehttps://code.google.com/p/google-web-toolkit/issues/detail?can=2start=0num=100q=colspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Starsgroupby=sort=id=3042, I am able to do the necessary work for solving it. So, can you guide me about the steps that I need to follow in order to create a patch properly? Would you like to reuse some code of the old patchhttp://gwt-code-reviews.appspot.com/1388802/ ? I am going to contact the creator of it because maybe he continues interested on fixing the issue and rebase the patch with the last code. Of course if there are other issues related to RichTextArea I can solve as well. Thanks in advance, Adolfo. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Work to do for bug 3042
Adolfo, To get the source checked out and compiling follow: http://www.gwtproject.org/makinggwtbetter.html#workingoncode To submit the patch use: http://www.gwtproject.org/makinggwtbetter.html#submittingpatches I recently had to move an old svn patch into gerrit and the following gave a very simple way to apply it http://stackoverflow.com/questions/659467/how-to-apply-svn-diff-to-git just remember to clean up any leftover .orij and .rej files. Cheers, James On 10 June 2013 10:01, Adolfo Panizo adolfo.pan...@gmail.com wrote: Hi, as I wrote in the issuehttps://code.google.com/p/google-web-toolkit/issues/detail?can=2start=0num=100q=colspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Starsgroupby=sort=id=3042, I am able to do the necessary work for solving it. So, can you guide me about the steps that I need to follow in order to create a patch properly? Would you like to reuse some code of the old patchhttp://gwt-code-reviews.appspot.com/1388802/ ? I am going to contact the creator of it because maybe he continues interested on fixing the issue and rebase the patch with the last code. Of course if there are other issues related to RichTextArea I can solve as well. Thanks in advance, Adolfo. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use correct return types for createFooInputBuilder() methods...
Thomas Broyer has posted comments on this change. Change subject: Use correct return types for createFooInputBuilder() methods in HtmlBuilderFactory. Also adjust the return types of affected methods in HtmlBuilderImpl. .. Patch Set 1: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3331 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c8d711a04021deeb83ea8672203c2a36239ccbc Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Tom Wieczorek t...@bibbu.net Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
From the gwtproject Making GWT Better page section Gerrit Setup step 3: Make a change and commit it locally using git (e.g., edit a file foo and then run ?git commit -m ?my first change? foo?). What does foo represent? Thanks, Pat On Mon, May 20, 2013 at 3:18 PM, Thomas Broyer t.bro...@gmail.com wrote: Should be http://gwtproject.org/makinggwtbetter.html On Sunday, May 19, 2013 10:00:01 PM UTC+2, Patrick Tucker wrote: I started from scratch and was able to get it mostly working. Is there a doc that explains the right way to submit a patch? On Friday, May 17, 2013 1:19:33 PM UTC-4, Patrick Tucker wrote: Windows 7 Pro On Friday, May 17, 2013 12:51:47 PM UTC-4, Matthew Dempsky wrote: On Fri, May 17, 2013 at 9:45 AM, Patrick Tucker tuck...@gmail.comwrote: I'm not sure where to find the file that you are referring to, it is not in my eclipse install folder? John was referring to the eclipse directory in the GWT source code tree: https://gwt.**googlesource.com/gwt/+/master/**eclipse/README.txthttps://gwt.googlesource.com/gwt/+/master/eclipse/README.txt I was playing with the settings and tried removing one of the source folders so that I could add it back and got an error saying the file system is read only. Any idea why it would do that? Not sure, that sounds odd to me. Just out of curiosity, what OS are you using? When you prepared the patch from Rietveld, did you checkout the code from Subversion or use the 2.5.1 SDK release zip file? If you were already using Subversion, I would expect using Git shouldn't be any different to setup in Eclipse since the source tree should be the same. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
Hi Patrick, foo is often used as a place holder, so something like: git add foo should mean: git add my_cool_edited_file -Daniel On Mon, Jun 10, 2013 at 3:35 PM, Patrick Tucker tucker...@gmail.com wrote: From the gwtproject Making GWT Better page section Gerrit Setup step 3: Make a change and commit it locally using git (e.g., edit a file foo and then run ?git commit -m ?my first change? foo?). What does foo represent? Thanks, Pat On Mon, May 20, 2013 at 3:18 PM, Thomas Broyer t.bro...@gmail.com wrote: Should be http://gwtproject.org/makinggwtbetter.html On Sunday, May 19, 2013 10:00:01 PM UTC+2, Patrick Tucker wrote: I started from scratch and was able to get it mostly working. Is there a doc that explains the right way to submit a patch? On Friday, May 17, 2013 1:19:33 PM UTC-4, Patrick Tucker wrote: Windows 7 Pro On Friday, May 17, 2013 12:51:47 PM UTC-4, Matthew Dempsky wrote: On Fri, May 17, 2013 at 9:45 AM, Patrick Tucker tuck...@gmail.comwrote: I'm not sure where to find the file that you are referring to, it is not in my eclipse install folder? John was referring to the eclipse directory in the GWT source code tree: https://gwt.**googlesource.com/gwt/+/master/**eclipse/README.txthttps://gwt.googlesource.com/gwt/+/master/eclipse/README.txt I was playing with the settings and tried removing one of the source folders so that I could add it back and got an error saying the file system is read only. Any idea why it would do that? Not sure, that sounds odd to me. Just out of curiosity, what OS are you using? When you prepared the patch from Rietveld, did you checkout the code from Subversion or use the 2.5.1 SDK release zip file? If you were already using Subversion, I would expect using Git shouldn't be any different to setup in Eclipse since the source tree should be the same. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Google Germany GmbH *Dienerstr. 12* *80331 München* Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
Thanks for the quick response, but that doesn't answer my question. I realize foo is a place holder, I'm trying to figure out what it represents. A file, a message to the reviewers, ... I'm trying to figure out what I should replace it with. Thanks again, Pat On Mon, Jun 10, 2013 at 9:54 AM, Daniel Kurka danku...@google.com wrote: Hi Patrick, foo is often used as a place holder, so something like: git add foo should mean: git add my_cool_edited_file -Daniel On Mon, Jun 10, 2013 at 3:35 PM, Patrick Tucker tucker...@gmail.comwrote: From the gwtproject Making GWT Better page section Gerrit Setup step 3: Make a change and commit it locally using git (e.g., edit a file foo and then run ?git commit -m ?my first change? foo?). What does foo represent? Thanks, Pat On Mon, May 20, 2013 at 3:18 PM, Thomas Broyer t.bro...@gmail.comwrote: Should be http://gwtproject.org/makinggwtbetter.html On Sunday, May 19, 2013 10:00:01 PM UTC+2, Patrick Tucker wrote: I started from scratch and was able to get it mostly working. Is there a doc that explains the right way to submit a patch? On Friday, May 17, 2013 1:19:33 PM UTC-4, Patrick Tucker wrote: Windows 7 Pro On Friday, May 17, 2013 12:51:47 PM UTC-4, Matthew Dempsky wrote: On Fri, May 17, 2013 at 9:45 AM, Patrick Tucker tuck...@gmail.comwrote: I'm not sure where to find the file that you are referring to, it is not in my eclipse install folder? John was referring to the eclipse directory in the GWT source code tree: https://gwt.**googlesource.com/gwt/+/master/** eclipse/README.txthttps://gwt.googlesource.com/gwt/+/master/eclipse/README.txt I was playing with the settings and tried removing one of the source folders so that I could add it back and got an error saying the file system is read only. Any idea why it would do that? Not sure, that sounds odd to me. Just out of curiosity, what OS are you using? When you prepared the patch from Rietveld, did you checkout the code from Subversion or use the 2.5.1 SDK release zip file? If you were already using Subversion, I would expect using Git shouldn't be any different to setup in Eclipse since the source tree should be the same. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Google Germany GmbH *Dienerstr. 12* *80331 München* Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to a topic in the Google Groups GWT Contributors group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit-contributors/hJzwtP-zEZw/unsubscribe?hl=en-US . To unsubscribe from this group and all its topics, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
Well I just wasted another few hours this morning trying to figure out how to commit something to this new system. Are these instructions complete?? Currently when I try to do a git push it tells me I have to provide a Change-Id. I copied the hook file to the hooks folder and the message did not go away. The command that GIT tells me to run executes chmod in it, being that I am on a windows machine it obviously fails. The online help page also tells me to execute the same command. I'm at a loss. On Monday, June 10, 2013 10:43:27 AM UTC-4, Patrick Tucker wrote: Thanks for the quick response, but that doesn't answer my question. I realize foo is a place holder, I'm trying to figure out what it represents. A file, a message to the reviewers, ... I'm trying to figure out what I should replace it with. Thanks again, Pat On Mon, Jun 10, 2013 at 9:54 AM, Daniel Kurka danku...@google.com wrote: Hi Patrick, foo is often used as a place holder, so something like: git add foo should mean: git add my_cool_edited_file -Daniel On Mon, Jun 10, 2013 at 3:35 PM, Patrick Tucker tucker...@gmail.comwrote: From the gwtproject Making GWT Better page section Gerrit Setup step 3: Make a change and commit it locally using git (e.g., edit a file foo and then run ?git commit -m ?my first change? foo?). What does foo represent? Thanks, Pat On Mon, May 20, 2013 at 3:18 PM, Thomas Broyer t.bro...@gmail.comwrote: Should be http://gwtproject.org/makinggwtbetter.html On Sunday, May 19, 2013 10:00:01 PM UTC+2, Patrick Tucker wrote: I started from scratch and was able to get it mostly working. Is there a doc that explains the right way to submit a patch? On Friday, May 17, 2013 1:19:33 PM UTC-4, Patrick Tucker wrote: Windows 7 Pro On Friday, May 17, 2013 12:51:47 PM UTC-4, Matthew Dempsky wrote: On Fri, May 17, 2013 at 9:45 AM, Patrick Tucker tuck...@gmail.comwrote: I'm not sure where to find the file that you are referring to, it is not in my eclipse install folder? John was referring to the eclipse directory in the GWT source code tree: https://gwt.**googlesource.com/gwt/+/master/** eclipse/README.txthttps://gwt.googlesource.com/gwt/+/master/eclipse/README.txt I was playing with the settings and tried removing one of the source folders so that I could add it back and got an error saying the file system is read only. Any idea why it would do that? Not sure, that sounds odd to me. Just out of curiosity, what OS are you using? When you prepared the patch from Rietveld, did you checkout the code from Subversion or use the 2.5.1 SDK release zip file? If you were already using Subversion, I would expect using Git shouldn't be any different to setup in Eclipse since the source tree should be the same. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com . For more options, visit https://groups.google.com/groups/opt_out. -- Google Germany GmbH *Dienerstr. 12* *80331 München* Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to a topic in the Google Groups GWT Contributors group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit-contributors/hJzwtP-zEZw/unsubscribe?hl=en-US . To unsubscribe from this group and all its topics, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
On Mon, Jun 10, 2013 at 3:35 PM, Patrick Tucker tucker...@gmail.com wrote: From the gwtproject Making GWT Better page section Gerrit Setup step 3: Make a change and commit it locally using git (e.g., edit a file foo and then run ?git commit -m ?my first change? foo?). What does foo represent? The file(s) you want to commit (automatically does a git add) http://git-scm.com/docs/git-commit -- Thomas Broyer /tɔ.ma.bʁwa.je/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...
John A. Tamplin has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 .. Patch Set 11: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3180 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246 Gerrit-PatchSet: 11 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: code review policy
On Monday, June 10, 2013 5:12:34 AM UTC+2, Stephen Haberman wrote: Hey, I wasn't quite sure, so figured I would ask: what's our policy on who can give +2s? Is it any committer? Technically, yes: https://gwt-review.googlesource.com/#/admin/projects/gwt,access (if you can see it; restricted access) I don't know who exactly is a committer though. Of non-Googlers, at least John (jat) and me. I assume so, but perhaps out of tradition, I've been assuming Googlers would give +2s. Well, and even if we are/have moved past the Google-only phase of GWT, for now/awhile they will still have the most knowledge about the codebase (perhaps sans Thomas). I try to not use +2 too much (or at least not submit reviews) because the CI server currently doesn't run tests against real browsers, and doesn't run tests at all pre submit. Maybe we should do something like OpenStack: http://ci.openstack.org/gerrit.html They have a third category Approved in addition to Verified and CodeReview, when set to approved then the CI server is triggered to do a build, and updates the Verified score. This is so that they can control the charge put on their CI server (only code that looks OK is built; but it's not worth scrutinizing the code if it'd break, so they don't wait the CodeReview+2). I think we could have our first checkstyle check done automatically for all reviews (like today, when it works ;-) ) but only put Verified-1 if it fails, and trigger a full build with tests only with an Approved+1 (or CodeReview+2 if that's easier to setup). Ideally, the build could just run JVM tests, and we (committers) could trigger browser tests (HtmlUnit only, or in real browsers) if needed. But that's not easy to setup (and someone would have to do it), so for now I submit sparingly (unless Googlers tell us to go ahead): for now, tests are run by Google when master is merged on google/pu, and they do reverts when something breaks. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Brian Slesinsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Hi, we had a performance regression reported to us so we rolled this CL back internally. The code where they noticed the regression is a builder class with many instance variables. Apparently the variable's default values were previously initialized on the prototype, so constructing the class was fast. After this change, they're initialized when the constructor is called. In this particular builder it's pointless because it extends Object. So we could put in a check for that, or more generally we could search superclass constructors for virtual methods that might be overridden. If there aren't any, the difference isn't observable and we can initialize fields the faster way. Or if that's too hard, conforming to the spec doesn't seem too important (given that we've lived without it for so many years), so we could just roll this back on trunk. -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: code review policy
I've been giving +2s for stuff I think is ready to commit, but I always assumed that Googlers would have no superpowers here, and that Steering Committee members and other designated people with specialized knowledge could do so as well. Google doesn't automatically import changes without reviewing them, and so our internal heuristic is something like if importing changes from gerrit, if there isn't a +2 from a Google employee, we need to take a deeper look. For example, John giving +2 to I18N or OOPHM changes seems ideal to me. I actually wouldn't feel comfortable giving more than a +1 on I18N unless John was unavailable and it needed to get landed because of a critical issue. On Mon, Jun 10, 2013 at 9:35 AM, Thomas Broyer t.bro...@gmail.com wrote: On Monday, June 10, 2013 5:12:34 AM UTC+2, Stephen Haberman wrote: Hey, I wasn't quite sure, so figured I would ask: what's our policy on who can give +2s? Is it any committer? Technically, yes: https://gwt-review.googlesource.com/#/admin/projects/gwt,access (if you can see it; restricted access) I don't know who exactly is a committer though. Of non-Googlers, at least John (jat) and me. I assume so, but perhaps out of tradition, I've been assuming Googlers would give +2s. Well, and even if we are/have moved past the Google-only phase of GWT, for now/awhile they will still have the most knowledge about the codebase (perhaps sans Thomas). I try to not use +2 too much (or at least not submit reviews) because the CI server currently doesn't run tests against real browsers, and doesn't run tests at all pre submit. Maybe we should do something like OpenStack: http://ci.openstack.org/gerrit.html They have a third category Approved in addition to Verified and CodeReview, when set to approved then the CI server is triggered to do a build, and updates the Verified score. This is so that they can control the charge put on their CI server (only code that looks OK is built; but it's not worth scrutinizing the code if it'd break, so they don't wait the CodeReview+2). I think we could have our first checkstyle check done automatically for all reviews (like today, when it works ;-) ) but only put Verified-1 if it fails, and trigger a full build with tests only with an Approved+1 (or CodeReview+2 if that's easier to setup). Ideally, the build could just run JVM tests, and we (committers) could trigger browser tests (HtmlUnit only, or in real browsers) if needed. But that's not easy to setup (and someone would have to do it), so for now I submit sparingly (unless Googlers tell us to go ahead): for now, tests are run by Google when master is merged on google/pu, and they do reverts when something breaks. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...
Goktug Gokdogan has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 .. Patch Set 11: You said you changed the comparison order in Float but you reverted it back? -- To view, visit https://gwt-review.googlesource.com/3180 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246 Gerrit-PatchSet: 11 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka danku...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)
+mdempsky Hi, I think you're going to have more trouble than most because you're using Windows and that's not so common for GWT development. The code to automatically add the Change-Id line is specific to Unix but you can do it manually by editing the changelist yourself. To fix your most recent commit, run git commit --amend and cut and paste the Change-Id line from the error message to the end of the commit message. (I believe each commit has to have its own Change-Id line and will be reviewed separately? Not sure how that works.) - Brian On Mon, Jun 10, 2013 at 8:17 AM, Patrick Tucker tucker...@gmail.com wrote: Well I just wasted another few hours this morning trying to figure out how to commit something to this new system. Are these instructions complete?? Currently when I try to do a git push it tells me I have to provide a Change-Id. I copied the hook file to the hooks folder and the message did not go away. The command that GIT tells me to run executes chmod in it, being that I am on a windows machine it obviously fails. The online help page also tells me to execute the same command. I'm at a loss. On Monday, June 10, 2013 10:43:27 AM UTC-4, Patrick Tucker wrote: Thanks for the quick response, but that doesn't answer my question. I realize foo is a place holder, I'm trying to figure out what it represents. A file, a message to the reviewers, ... I'm trying to figure out what I should replace it with. Thanks again, Pat On Mon, Jun 10, 2013 at 9:54 AM, Daniel Kurka danku...@google.comwrote: Hi Patrick, foo is often used as a place holder, so something like: git add foo should mean: git add my_cool_edited_file -Daniel On Mon, Jun 10, 2013 at 3:35 PM, Patrick Tucker tucker...@gmail.comwrote: From the gwtproject Making GWT Better page section Gerrit Setup step 3: Make a change and commit it locally using git (e.g., edit a file foo and then run ?git commit -m ?my first change? foo?). What does foo represent? Thanks, Pat On Mon, May 20, 2013 at 3:18 PM, Thomas Broyer t.bro...@gmail.comwrote: Should be http://gwtproject.org/**makinggwtbetter.htmlhttp://gwtproject.org/makinggwtbetter.html On Sunday, May 19, 2013 10:00:01 PM UTC+2, Patrick Tucker wrote: I started from scratch and was able to get it mostly working. Is there a doc that explains the right way to submit a patch? On Friday, May 17, 2013 1:19:33 PM UTC-4, Patrick Tucker wrote: Windows 7 Pro On Friday, May 17, 2013 12:51:47 PM UTC-4, Matthew Dempsky wrote: On Fri, May 17, 2013 at 9:45 AM, Patrick Tucker tuck...@gmail.comwrote: I'm not sure where to find the file that you are referring to, it is not in my eclipse install folder? John was referring to the eclipse directory in the GWT source code tree: https://gwt.**googlesource**.com/gwt/+/master/**eclipse/ **README.txthttps://gwt.googlesource.com/gwt/+/master/eclipse/README.txt I was playing with the settings and tried removing one of the source folders so that I could add it back and got an error saying the file system is read only. Any idea why it would do that? Not sure, that sounds odd to me. Just out of curiosity, what OS are you using? When you prepared the patch from Rietveld, did you checkout the code from Subversion or use the 2.5.1 SDK release zip file? If you were already using Subversion, I would expect using Git shouldn't be any different to setup in Eclipse since the source tree should be the same. -- http://groups.google.com/**group/Google-Web-Toolkit-**Contributorshttp://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-**contributors+unsubscribe@** googlegroups.comgoogle-web-toolkit-contributors%2bunsubscr...@googlegroups.com . For more options, visit https://groups.google.com/**groups/opt_outhttps://groups.google.com/groups/opt_out . -- Google Germany GmbH *Dienerstr. 12* *80331 München* Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens -- http://groups.google.com/**group/Google-Web-Toolkit-**Contributorshttp://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to a topic in the Google Groups GWT Contributors group. To unsubscribe from this topic, visit https://groups.google.com/d/** topic/google-web-toolkit-**contributors/hJzwtP-zEZw/** unsubscribe?hl=en-UShttps://groups.google.com/d/topic/google-web-toolkit-contributors/hJzwtP-zEZw/unsubscribe?hl=en-US . To unsubscribe from this group and all its topics, send an email to google-web-toolkit-**contributors+unsubscribe@**googlegroups.comgoogle-web-toolkit-contributors%2bunsubscr...@googlegroups.com . For more options, visit
[gwt-contrib] Change in gwt[master]: Remove unused, package-private FastStringMap.
Brian Slesinsky has posted comments on this change. Change subject: Remove unused, package-private FastStringMap. .. Patch Set 1: Code-Review+2 Not used in Google code either. -- To view, visit https://gwt-review.googlesource.com/3280 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dd9f897a044ba53be5fc74fabb40a382b9ef119 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3300 to look at the new patch set (#3). Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. FragmentExtractor chooses whether and what part of a defineSeed call to include in a fragment. Previously this logic would only include a defineSeed function in a fragment if the fragment was known to make the particular type in question live. In this usage live means that if you have ALL other fragments loaded then you can not instantiate this type but the moment you additionally load this fragment you become able to instantiate this type. But it is possible that when you have ALL other fragments loaded you can already instantiate this type and so when you load this fragment you do not expand the liveness of this type but you DO suddenly make certain of its constructors accessible that were not previously accessible. In this situation previously logic would still not have included any defineSeed function at all and as a consequence these newly live constructors were never getting their associated castMaps which led to runtime errors when casting an instance that had been created by one of these broken constructors. This CL relaxes the defineSeed inclusion restriction to include fragments that are expanding a type's constructors liveness and not just fragments that expand a type's liveness. Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699 Review-Link: https://gwt-review.googlesource.com/#/c/3300/ --- M dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java M dev/core/src/com/google/gwt/dev/js/ast/JsName.java M dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java A dev/core/test/com/google/gwt/dev/jjs/impl/FragmentExtractorTest.java 4 files changed, 394 insertions(+), 80 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3300 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...
Roberto Lublinerman has posted comments on this change. Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. Patch Set 3: Code-Review+2 LGTM. We probably want to run a global presubmit tonight (or at list for the projects that use runAsyncs, whatever is easier). -- To view, visit https://gwt-review.googlesource.com/3300 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds a module to revert GWT.runAsync to do immediate callbac...
Roberto Lublinerman has posted comments on this change. Change subject: Adds a module to revert GWT.runAsync to do immediate callbacks in consecutive calls. .. Patch Set 1: Code-Review+2 I assume because the new method is in the AsyncFragmentLoader it gets special cased and treated correctly by the cfa. -- To view, visit https://gwt-review.googlesource.com/3310 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3a54663d6d857ca294c99a1a99084328748996d Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes UiHandler method matching in generic classes
Roberto Lublinerman has posted comments on this change. Change subject: Fixes UiHandler method matching in generic classes .. Patch Set 2: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3250 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3121542b6eb4f06f36b88b02006b155422c45726 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes a NPE in RF when returning a null entity while the cli...
Roberto Lublinerman has posted comments on this change. Change subject: Fixes a NPE in RF when returning a null entity while the client used .with(). .. Patch Set 1: Code-Review+2 LGTM. -- To view, visit https://gwt-review.googlesource.com/2570 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07c4b6d94fd063d76f205070047fd5f9e32c190b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds a module to revert GWT.runAsync to do immediate callbac...
Goktug Gokdogan has posted comments on this change. Change subject: Adds a module to revert GWT.runAsync to do immediate callbacks in consecutive calls. .. Patch Set 1: Yes, that's correct :) -- To view, visit https://gwt-review.googlesource.com/3310 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3a54663d6d857ca294c99a1a99084328748996d Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds a module to revert GWT.runAsync to do immediate callbac...
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Adds a module to revert GWT.runAsync to do immediate
callbacks in consecutive calls.
..
Adds a module to revert GWT.runAsync to do immediate callbacks in
consecutive calls.
This is for backward compatibility until a major release. It introduces a
module
that can be inherited by user module to revert back GWT.runAsync to old
behavior.
Change-Id: If3a54663d6d857ca294c99a1a99084328748996d
---
A user/src/com/google/gwt/core/SynchronousFragmentLoadCallback.gwt.xml
M user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
A user/src/com/google/gwt/core/client/impl/OnSuccessExecutor.java
A user/src/com/google/gwt/core/client/impl/SynchronousOnSuccessExecutor.java
M user/test/com/google/gwt/core/client/impl/AsyncFragmentLoaderTest.java
5 files changed, 114 insertions(+), 30 deletions(-)
Approvals:
Roberto Lublinerman: Looks good to me, approved
Leeroy Jenkins: Verified
diff --git
a/user/src/com/google/gwt/core/SynchronousFragmentLoadCallback.gwt.xml
b/user/src/com/google/gwt/core/SynchronousFragmentLoadCallback.gwt.xml
new file mode 100644
index 000..1a37fb2
--- /dev/null
+++ b/user/src/com/google/gwt/core/SynchronousFragmentLoadCallback.gwt.xml
@@ -0,0 +1,24 @@
+!--
--
+!-- Copyright 2013 Google
Inc. --
+!-- Licensed under the Apache License, Version 2.0 (the License);
you--
+!-- may not use this file except in compliance with the License. You
may --
+!-- may obtain a copy of the License
at--
+!--
--
+!--
http://www.apache.org/licenses/LICENSE-2.0 --
+!--
--
+!-- Unless required by applicable law or agreed to in writing,
software--
+!-- distributed under the License is distributed on an AS IS
BASIS, --
+!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
or--
+!-- implied. License for the specific language governing permissions
and --
+!-- limitations under the
License. --
+
+!-- Inheriting this module makes callback executed immediately
if --
+!-- GWT.runAsync is called against already loaded
fragment.--
+
+!-- TODO(goktug): remove after 2.6 is
released --
+
+module
+ replace-with
class=com.google.gwt.core.client.impl.SynchronousOnSuccessExecutor
+when-type-is
class=com.google.gwt.core.client.impl.OnSuccessExecutor/
+ /replace-with
+/module
\ No newline at end of file
diff --git
a/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
b/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
index 77ab67f..d6ac682 100644
--- a/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
+++ b/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
@@ -18,8 +18,6 @@
import com.google.gwt.core.client.GWT;
import com.google.gwt.core.client.JavaScriptObject;
import com.google.gwt.core.client.RunAsyncCallback;
-import com.google.gwt.core.client.Scheduler;
-import com.google.gwt.core.client.Scheduler.ScheduledCommand;
/**
* p
@@ -57,7 +55,7 @@
* been installed, so that {@link AsyncFragmentLoader} can distinguish
* successful from unsuccessful downloads.
*/
- public static interface LoadTerminatedHandler {
+ public interface LoadTerminatedHandler {
void loadTerminated(Throwable reason);
}
@@ -297,12 +295,15 @@
*/
private static AsyncFragmentLoader makeBrowserLoader(int numFragments,
int initialLoad[]) {
if (GWT.isClient()) {
- return new AsyncFragmentLoader(numFragments, initialLoad,
(LoadingStrategy) GWT
- .create(LoadingStrategy.class), (Logger)
GWT.create(Logger.class));
+ return new AsyncFragmentLoader(numFragments, initialLoad,
+ (LoadingStrategy) GWT.create(LoadingStrategy.class), (Logger)
GWT.create(Logger.class),
+ (OnSuccessExecutor) GWT.create(OnSuccessExecutor.class));
} else {
return null;
}
}
+
+ private final OnSuccessExecutor onSuccessExecutor;
/**
* Callbacks indexed by fragment number.
@@ -371,11 +372,12 @@
private final BoundedIntQueue requestedExclusives;
public AsyncFragmentLoader(int numEntries, int[] initialLoadSequence,
- LoadingStrategy loadingStrategy, Logger logger) {
+ LoadingStrategy loadingStrategy, Logger logger, OnSuccessExecutor
executor) {
this.numEntries = numEntries;
this.initialLoadSequence = initialLoadSequence;
this.loadingStrategy = loadingStrategy;
this.logger = logger;
+this.onSuccessExecutor = executor;
[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...
Roberto Lublinerman has posted comments on this change. Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. Patch Set 2: (2 comments) I had too comments here that where not published. File dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java Line 246 Is this no longer valid or was just removed because we normally run the compiler with assertions disabled? Assertions are enabled when running tests so if it still valid that extractStatements is only called once then we should leave the assertion. Line 191:* been made live by the current fragment. It also counts the constructors the references that Remove the between constructor references? -- To view, visit https://gwt-review.googlesource.com/3300 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element
Colin Alworth has posted comments on this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Patch Set 6: Code-Review+1 Nope, we can work with it - a wrapper isn't really an option, since we get real benefit from getting static methods that look like instance ones without the mess of static imports or new-ing up instances that wrap the original elt just long enough to run a method on them and gc them (unless the compiler now can unwrap that single final field and method and treat it as if it were static to begin with?). We used to have a great big flyweight thing going on to avoid the extra object creation, but move to extending Element to avoid that little extra cost... My main point was to bring it up as a point to discuss, to make sure that adding a new final method to a non-final class was deliberate. GXT is happy to plan ahead and remove it before 2.6 lands (and thanks for the heads up on toggleClassName), and move to something else in the meantime, we'd just rather not make a habit of that, cutting new specific gxt minor releases to accommodate specific gwt minor releases, and I'm sure we're not alone in that. -- To view, visit https://gwt-review.googlesource.com/3070 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...
Hello Roberto Lublinerman, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3300 to look at the new patch set (#4). Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. FragmentExtractor chooses whether and what part of a defineSeed call to include in a fragment. Previously this logic would only include a defineSeed function in a fragment if the fragment was known to make the particular type in question live. In this usage live means that if you have ALL other fragments loaded then you can not instantiate this type but the moment you additionally load this fragment you become able to instantiate this type. But it is possible that when you have ALL other fragments loaded you can already instantiate this type and so when you load this fragment you do not expand the liveness of this type but you DO suddenly make certain of its constructors accessible that were not previously accessible. In this situation previously logic would still not have included any defineSeed function at all and as a consequence these newly live constructors were never getting their associated castMaps which led to runtime errors when casting an instance that had been created by one of these broken constructors. This change relaxes the defineSeed inclusion restriction to include fragments that are expanding a type's constructors liveness and not just fragments that expand a type's liveness. Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699 Review-Link: https://gwt-review.googlesource.com/#/c/3300/ --- M dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java M dev/core/src/com/google/gwt/dev/js/ast/JsName.java M dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java A dev/core/test/com/google/gwt/dev/jjs/impl/FragmentExtractorTest.java 4 files changed, 394 insertions(+), 79 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3300 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...
Roberto Lublinerman has posted comments on this change. Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. Patch Set 4: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3300 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc87430b94338d289eae4760a1bef8ad127bd699 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element
Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
..
Patch Set 6:
Unfortunately JSO's doesn't give us much choice on API management so that
make our job harder and also brings the risk to whoever extends it. That is
the reason I am checking if you have other options.
And yes GWT compiler can do pretty amazing stuff when it comes to
de-virtualization, you should give it a try; I would not be surprised if it
can get rid of the middle class.
Also one other option with JSO's is, you can create your own namespace for
the methods with a cast.
e.g.: (sorry for made up class names)
class GxtElement extends Element {
GxtExtensions gxt() { return (GxtExtensions) cast(); }
}
class GxtExtensions {
void methodX();
void methodY();
}
--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Colin Alworth niloc...@gmail.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: fixes a compiler crash when parsing illegal runAsync definit...
Roberto Lublinerman has posted comments on this change. Change subject: fixes a compiler crash when parsing illegal runAsync definitions .. Patch Set 1: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3320 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3feb378a9595e1c3be091b2adf033df9ccae39 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Remove unused, package-private FastStringMap.
Stephen Haberman has submitted this change and it was merged.
Change subject: Remove unused, package-private FastStringMap.
..
Remove unused, package-private FastStringMap.
Change-Id: I8dd9f897a044ba53be5fc74fabb40a382b9ef119
---
D user/src/com/google/gwt/user/client/ui/FastStringMap.java
M user/test/com/google/gwt/user/UiPart1Suite.java
D user/test/com/google/gwt/user/client/ui/FastStringMapTest.java
D user/test/com/google/gwt/user/maptests/FastStringMapTest.java
4 files changed, 0 insertions(+), 426 deletions(-)
Approvals:
Daniel Kurka: Looks good to me, but someone else must approve
Manuel Carrasco Moñino: Looks good to me, but someone else must approve
Leeroy Jenkins: Verified
Brian Slesinsky: Looks good to me, approved
diff --git a/user/src/com/google/gwt/user/client/ui/FastStringMap.java
b/user/src/com/google/gwt/user/client/ui/FastStringMap.java
deleted file mode 100644
index 8538ccc..000
--- a/user/src/com/google/gwt/user/client/ui/FastStringMap.java
+++ /dev/null
@@ -1,291 +0,0 @@
-/*
- * Copyright 2007 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the License); you may
not
- * use this file except in compliance with the License. You may obtain a
copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations
under
- * the License.
- */
-
-package com.google.gwt.user.client.ui;
-
-import com.google.gwt.core.client.JavaScriptObject;
-
-import java.util.AbstractMap;
-import java.util.AbstractSet;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-
-/**
- * Special-case Map implementation which imposes limits on the types of
keys
- * that can be used in return for much faster speed. In specific, only
strings
- * that could be added to a JavaScript object as keys are valid.
- */
-
-class FastStringMapT extends AbstractMapString, T {
- private static class ImplMapEntryT implements Map.EntryString, T {
-
-private String key;
-
-private T value;
-
-ImplMapEntry(String key, T value) {
- this.key = key;
- this.value = value;
-}
-
-@Override
-public boolean equals(Object a) {
- if (a instanceof Map.Entry?, ?) {
-Map.Entry?, ? s = (Map.Entry?, ?) a;
-if (equalsWithNullCheck(key, s.getKey())
- equalsWithNullCheck(value, s.getValue())) {
- return true;
-}
- }
- return false;
-}
-
-// strip prefix from key
-public String getKey() {
- return key;
-}
-
-public T getValue() {
- return value;
-}
-
-@Override
-public int hashCode() {
- int keyHash = 0;
- int valueHash = 0;
- if (key != null) {
-keyHash = key.hashCode();
- }
- if (value != null) {
-valueHash = value.hashCode();
- }
- return keyHash ^ valueHash;
-}
-
-public T setValue(T object) {
- T old = value;
- value = object;
- return old;
-}
-
-private boolean equalsWithNullCheck(Object a, Object b) {
- if (a == b) {
-return true;
- } else if (a == null) {
-return false;
- } else {
-return a.equals(b);
- }
-}
- }
-
- /*
- * Accesses need to be prefixed with ':' to prevent conflict with
built-in
- * JavaScript properties.
- */
- private JavaScriptObject map;
-
- public FastStringMap() {
-init();
- }
-
- @Override
- public void clear() {
-init();
- }
-
- @Override
- public boolean containsKey(Object key) {
-return containsKey(keyMustBeString(key), map);
- }
-
- @Override
- public boolean containsValue(Object arg0) {
-return values().contains(arg0);
- }
-
- @Override
- public SetMap.EntryString, T entrySet() {
-return new AbstractSetMap.EntryString, T() {
-
- @Override
- public boolean contains(Object key) {
-Map.Entry?, ? s = (Map.Entry?, ?) key;
-Object value = get(s.getKey());
-if (value == null) {
- return value == s.getValue();
-} else {
- return value.equals(s.getValue());
-}
- }
-
- @Override
- public IteratorMap.EntryString, T iterator() {
-
-IteratorMap.EntryString, T custom = new
IteratorMap.EntryString, T() {
- IteratorString keys = keySet().iterator();
-
- public boolean hasNext() {
-return keys.hasNext();
- }
-
- public Map.EntryString, T next() {
-String key = keys.next();
-return new ImplMapEntryT(key, get(key));
- }
-
-
[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.
Stephen Haberman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Huh. I knew this correct way was slower but I'm surprised it actually showed up as a performance regression. I agree looking for Object or super-cstrs with virtual calls is a good approach for keeping the old behavior. I can play with those. I'm more curious about what we should do now in master--revert this commit there as well, with the idea that we can re-commit it when it has the optimization in place? Alternatively, we could leave it in master, and make a separate CL to add the optimization, but then you guys will have to un-revert it for the optimization-only CL to apply cleanly. Seems cleaner to revert it from master for now? -- To view, visit https://gwt-review.googlesource.com/3030 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918 Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element
Colin Alworth has posted comments on this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Patch Set 6: Thanks Goktug - one of the distinct advantages of extending Element is that we can subclass UiObject.getElement and already have access to the methods we want, and on the other side the subclass can invoke Element methods (without the pretend-jso-cast). As I understand it, from your example, GxtElement is superfluous - we'd need to .cast() to GxtElement to even get the .cast() method to get GxtExtensions ;). (wrapping up, as Andrey's code review probably isn't the place...) W.R.T. devirtualization, that doesn't quite go far enough - constructors do not go away, and the this$static is still needed, even though it is only to grab the one field inside it. And while v8 might do the alias analysis and drop the ctor, I'm all by certain that IE6-9 don't (and 10 would be a guess). -- To view, visit https://gwt-review.googlesource.com/3070 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Stephen Haberman stephen.haber...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
