Brian Slesinsky has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
......................................................................
Patch Set 9:
Hi, we had a performance regression reported to us so we rolled this CL
back internally.
The code where they noticed the regression is a builder class with many
instance variables. Apparently the variable's default values were
previously initialized on the prototype, so constructing the class was
fast. After this change, they're initialized when the constructor is called.
In this particular builder it's pointless because it extends Object. So we
could put in a check for that, or more generally we could search superclass
constructors for virtual methods that might be overridden. If there aren't
any, the difference isn't observable and we can initialize fields the
faster way.
Or if that's too hard, conforming to the spec doesn't seem too important
(given that we've lived without it for so many years), so we could just
roll this back on trunk.
--
To view, visit https://gwt-review.googlesource.com/3030
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <stephen.haber...@gmail.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Stephen Haberman <stephen.haber...@gmail.com>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
