[gwt-contrib] Change in gwt[master]: adds regression testing against future changes that might ac...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3590 to look at the new patch set (#5). Change subject: adds regression testing against future changes that might accidentally push all fragment code into the leftover fragment .. adds regression testing against future changes that might accidentally push all fragment code into the leftover fragment Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335 Review-Link: https://gwt-review.googlesource.com/#/c/3590/ --- M user/src/com/google/gwt/core/client/impl/LoadingStrategyBase.java M user/src/com/google/gwt/core/client/impl/XhrLoadingStrategy.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/RunAsyncContent.gwt.xml A user/test/com/google/gwt/dev/jjs/test/LoggingXhrLoadingStrategy.java A user/test/com/google/gwt/dev/jjs/test/RunAsyncContentTest.java 6 files changed, 200 insertions(+), 3 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3590 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adds regression testing against future changes that might ac...
John Stalcup has posted comments on this change.
Change subject: adds regression testing against future changes that might
accidentally push all fragment code into the leftover fragment
..
Patch Set 4:
(4 comments)
File user/src/com/google/gwt/core/client/impl/XhrLoadingStrategy.java
Line 32: protected class XhrDownloadStrategy implements DownloadStrategy {
Done
File user/test/com/google/gwt/dev/jjs/test/RunAsyncContentTest.java
Line 44: public void onFailure(Throwable caught) {}
Done
Line 55: public void testUniqueContentRegular() {
Done
File user/test/com/google/gwt/dev/jjs/test/RunAsyncFailureTest.java
Line 250: }
Done
--
To view, visit https://gwt-review.googlesource.com/3590
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Stalcup
Gerrit-Reviewer: Goktug Gokdogan
Gerrit-Reviewer: John Stalcup
Gerrit-Reviewer: Leeroy Jenkins
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.
Roberto Lublinerman has posted comments on this change. Change subject: Optimize initializing fields at the top scope. .. Patch Set 3: (1 comment) File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java Line 2342: canObserveSubclassFields.add(currentClass); I still think we need to ignore calls to constructors of this class or super constructors and also $init. IRC most constructors will include either of these calls. We can also safely ignore parameterless static calls (and that would include the $clinit that is inserted by the inliner) that are also pretty common in constructors. -- To view, visit https://gwt-review.googlesource.com/3440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97a06eb36396a8b8659ce9a025b21a9cf93d0500 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Stephen Haberman Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Google GWT team meeting notes for June 26th
Hi, in the interest of increased transparency, I'm going to start posting notes from GWT team meetings at Google. I'm not sure if we'll keep this up but we'll see how it goes. (My apologies in advance for any errors.) June 26, 2013 - Discussed goals for the next quarter. Of interest to the community: - Improving GWT compiler speed is important as usual. - Improve Super Dev Mode usability to improve internal adoption. In particular, figure out IDE integration. - Finish moving documentation to gwtproject.org and redirect from developers.google.com - Discussed what we should do with GWT designer documentation. The GWT designer is currently not being maintained. No resolution yet. - Discussed how to make mgwt available within Google. - Discussed community outreach, possibly by having public Hangouts and/or posting on YouTube. Still in progress. For now, Brian will write up meeting notes. - Gardening: new process seemed to work well. Matthew talked about automating it. - Talked about adding an end-to-end test for split points. Requires infrastructure. - Daniel: javadoc regenerated and moved to gwtproject.org to fix a security issue. - We discussed updating Google's internal widgets and widget architecture. Long term, one idea is to support web components written in JavaScript and come up with an improvement on JSNI and JavaScriptObjects to allow this. Goktug and Roberto have an idea they think will work. Short term unclear. Being able to consume GSS would help. Needs more discussion. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Google GWT team meeting notes for June 26th
Thanks for sharing! 2013/6/27 Brian Slesinsky > Hi, in the interest of increased transparency, I'm going to start posting > notes from GWT team meetings at Google. I'm not sure if we'll keep this up > but we'll see how it goes. (My apologies in advance for any errors.) > > June 26, 2013 > > - Discussed goals for the next quarter. Of interest to the community: > - Improving GWT compiler speed is important as usual. > - Improve Super Dev Mode usability to improve internal adoption. In > particular, figure out IDE integration. > - Finish moving documentation to gwtproject.org and redirect from > developers.google.com > - Discussed what we should do with GWT designer documentation. The GWT > designer is currently not being maintained. No resolution yet. > - Discussed how to make mgwt available within Google. > - Discussed community outreach, possibly by having public Hangouts and/or > posting on YouTube. Still in progress. For now, Brian will write up meeting > notes. > - Gardening: new process seemed to work well. Matthew talked about > automating it. > - Talked about adding an end-to-end test for split points. Requires > infrastructure. > - Daniel: javadoc regenerated and moved to gwtproject.org to fix a > security issue. > - We discussed updating Google's internal widgets and widget architecture. > Long term, one idea is to support web components written in JavaScript and > come up with an improvement on JSNI and JavaScriptObjects to allow this. > Goktug and Roberto have an idea they think will work. Short term unclear. > Being able to consume GSS would help. Needs more discussion. > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > --- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.
Brian Slesinsky has posted comments on this change. Change subject: Optimize initializing fields at the top scope. .. Patch Set 3: (2 comments) File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java Line 2342: canObserveSubclassFields.add(currentClass); Parameterless static calls seem safe, but for constructors, it seems like we have to visit them to know whether they're safe? Perhaps we could construct a set of locally-safe constructors and a constructor call graph, which can be used to calculate the transitive closure. It should be linear for constructor calls. Line 2498:* Classes that could potentially see uninitialized values for fields that are ininitialized in sp: "initialized" -- To view, visit https://gwt-review.googlesource.com/3440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97a06eb36396a8b8659ce9a025b21a9cf93d0500 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Stephen Haberman Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adds regression testing against future changes that might ac...
Roberto Lublinerman has posted comments on this change. Change subject: adds regression testing against future changes that might accidentally push all fragment code into the leftover fragment .. Patch Set 5: Code-Review+1 (1 comment) File user/test/com/google/gwt/dev/jjs/test/RunAsyncContentTest.java Line 66: String sharedContent = "Same String in multiple fragments."; I suppose that string interning will realize that the two strings are the same, but would it better be a final field (maybe static) in the class? -- To view, visit https://gwt-review.googlesource.com/3590 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Roberto Lublinerman Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adds regression testing against future changes that might ac...
Goktug Gokdogan has posted comments on this change. Change subject: adds regression testing against future changes that might accidentally push all fragment code into the leftover fragment .. Patch Set 5: Code-Review+2 (3 comments) Commit Message Line 7: adds regression testing against future changes that might accidentally push all fragment code into the leftover fragment Can you use a shorter first line if possible? If you can't, then can you wrap the line? File user/src/com/google/gwt/core/client/impl/LoadingStrategyBase.java Line 114: nit: spaces File user/test/com/google/gwt/dev/jjs/test/LoggingXhrLoadingStrategy.java Line 49: super.tryDownload(new com.google.gwt.core.client.impl.LoadingStrategyBase.RequestData( I guess you don't need to use FQN. -- To view, visit https://gwt-review.googlesource.com/3590 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Roberto Lublinerman Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.
Stephen Haberman has posted comments on this change. Change subject: Optimize initializing fields at the top scope. .. Patch Set 3: (1 comment) File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java Line 2342: canObserveSubclassFields.add(currentClass); Roberto: Ignoring calls to cstrs of this/super makes sense--they will get their own endVisit checks. $init I will look in to. Ignoring 0-arg static calls makes sense too. Brian: I believe what Roberto is saying is that the other cstr calls will have their contents checked by their own visit(JConstructor)/endVisit(JMethodCall)s, so if we see a method call from 1 cstr to another cstr in the same class, we can assume it will get checked later, and the cstr->cstr call itself doesn't mean we have to mark the currentClass as observing subclass fields. -- To view, visit https://gwt-review.googlesource.com/3440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97a06eb36396a8b8659ce9a025b21a9cf93d0500 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Stephen Haberman Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adds regression testing against future changes that might ac...
Matthew Dempsky has posted comments on this change. Change subject: adds regression testing against future changes that might accidentally push all fragment code into the leftover fragment .. Patch Set 5: (1 comment) Commit Message Line 7: adds regression testing against future changes that might accidentally push all fragment code into the leftover fragment I'd recommend something like: Add regression test for fragment splitting This adds a test to verify that future changes don't accidentally push *all* code into the leftover fragment. -- To view, visit https://gwt-review.googlesource.com/3590 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Roberto Lublinerman Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds a regression test for fragment splitting
Hello Roberto Lublinerman, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3590 to look at the new patch set (#6). Change subject: Adds a regression test for fragment splitting .. Adds a regression test for fragment splitting Test to verifies that future changes don't accidentally push *all* code into the leftover fragment. Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335 Review-Link: https://gwt-review.googlesource.com/#/c/3590/ --- M user/src/com/google/gwt/core/client/impl/LoadingStrategyBase.java M user/src/com/google/gwt/core/client/impl/XhrLoadingStrategy.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/RunAsyncContent.gwt.xml A user/test/com/google/gwt/dev/jjs/test/LoggingXhrLoadingStrategy.java A user/test/com/google/gwt/dev/jjs/test/RunAsyncContentTest.java 6 files changed, 200 insertions(+), 3 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3590 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335 Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Roberto Lublinerman -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds a regression test for fragment splitting
John Stalcup has posted comments on this change. Change subject: Adds a regression test for fragment splitting .. Patch Set 5: (5 comments) Commit Message Line 7: adds regression testing against future changes that might accidentally push all fragment code into the leftover fragment Done Line 7: adds regression testing against future changes that might accidentally push all fragment code into the leftover fragment Done File user/src/com/google/gwt/core/client/impl/LoadingStrategyBase.java Line 114: i'm being consistent with the file. do you want me to: 1. reformat the whole file, 2. be different from the rest of the file, or 3. be consistent with the file? File user/test/com/google/gwt/dev/jjs/test/LoggingXhrLoadingStrategy.java Line 49: super.tryDownload(new com.google.gwt.core.client.impl.LoadingStrategyBase.RequestData( it was conflicting with com.google.web.bindery.requestfactory.shared.impl.RequestData and something to do with the class hierarchy (before the most recent change you requested) was making the wrong one resolve first and organize import fail repeatedly seems to be working correctly now. i've removed the FQN File user/test/com/google/gwt/dev/jjs/test/RunAsyncContentTest.java Line 66: String sharedContent = "Same String in multiple fragments."; it can't be that, because then it ends up in the initial fragment (i tried it that way first). also i can't check for the existence of a class or field because the names are obfuscated randomly. i think we're kind of stuck with this shared interned String -- To view, visit https://gwt-review.googlesource.com/3590 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Roberto Lublinerman Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds a regression test for fragment splitting
Matthew Dempsky has posted comments on this change. Change subject: Adds a regression test for fragment splitting .. Patch Set 6: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/3590 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335 Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Roberto Lublinerman Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds a regression test for fragment splitting
Goktug Gokdogan has posted comments on this change. Change subject: Adds a regression test for fragment splitting .. Patch Set 6: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3590 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335 Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Roberto Lublinerman Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds a regression test for fragment splitting
Goktug Gokdogan has posted comments on this change. Change subject: Adds a regression test for fragment splitting .. Patch Set 5: (1 comment) File user/src/com/google/gwt/core/client/impl/LoadingStrategyBase.java Line 114: Feel free to do what you think is the best fit. (I personally avoid adding new spaces but if that is already the case for the rest I think you can choose keep it consistent with rest of the file.) -- To view, visit https://gwt-review.googlesource.com/3590 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34d21081ea4e90b95f5b2d77a7a647e388e25335 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Roberto Lublinerman Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Move StackTraceDeobfuscator from core.server.impl to core.se...
Goktug Gokdogan has posted comments on this change. Change subject: Move StackTraceDeobfuscator from core.server.impl to core.server. .. Patch Set 2: Pinging just in case if you have forgot about this patch; otherwise please ignore. -- To view, visit https://gwt-review.googlesource.com/3512 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic84f3b2210e3c40f0f7dc41bdeea9d13bf1a4dc6 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Move StackTraceDeobfuscator from core.server.impl to core.se...
Brian Slesinsky has posted comments on this change. Change subject: Move StackTraceDeobfuscator from core.server.impl to core.server. .. Patch Set 2: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3512 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic84f3b2210e3c40f0f7dc41bdeea9d13bf1a4dc6 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Super Dev Mode: deemphasize unused Java lines in codeserver'...
Brian Slesinsky has uploaded a new change for review.
https://gwt-review.googlesource.com/3600
Change subject: Super Dev Mode: deemphasize unused Java lines in
codeserver's UI
..
Super Dev Mode: deemphasize unused Java lines in codeserver's UI
Modified the code server to render Java files as HTML when browsing
interactively. (JavaScript debuggers continue to load the plain text.)
In the HTML, lines that make no contribution to the JavaScript according
to the source map are greyed out.
This implementation is pretty inefficient since we parse the entire
source map on every html page load, but it seems to suffice.
Change-Id: Id16bcd2287630cebf7afb8bbbe0a198b28f5ada9
---
M dev/codeserver/java/com/google/gwt/dev/codeserver/HtmlWriter.java
A dev/codeserver/java/com/google/gwt/dev/codeserver/ReverseSourceMap.java
M dev/codeserver/java/com/google/gwt/dev/codeserver/SourceHandler.java
M dev/codeserver/java/com/google/gwt/dev/codeserver/SourceMap.java
4 files changed, 125 insertions(+), 15 deletions(-)
diff --git
a/dev/codeserver/java/com/google/gwt/dev/codeserver/HtmlWriter.java
b/dev/codeserver/java/com/google/gwt/dev/codeserver/HtmlWriter.java
index 7cde2c4..ddf7db4 100644
--- a/dev/codeserver/java/com/google/gwt/dev/codeserver/HtmlWriter.java
+++ b/dev/codeserver/java/com/google/gwt/dev/codeserver/HtmlWriter.java
@@ -17,10 +17,12 @@
class HtmlWriter {
private static final Set ALLOWED_TAGS =
Collections.unmodifiableSet(new HashSet(Arrays.asList(
- "html", "head", "title", "style", "body", "pre", "span", "h1", "h2",
"a",
+ "html", "head", "title", "style",
+ "body", "h1", "h2", "h3", "h4", "h5", "h6", "a", "pre", "span",
"table", "tr", "td")));
private static final Set ALLOWED_ATTS =
- Collections.unmodifiableSet(new
HashSet(Arrays.asList("class=", "href=")));
+ Collections.unmodifiableSet(new HashSet(Arrays.asList(
+ "class=", "href=")));
private final Writer out;
diff --git
a/dev/codeserver/java/com/google/gwt/dev/codeserver/ReverseSourceMap.java
b/dev/codeserver/java/com/google/gwt/dev/codeserver/ReverseSourceMap.java
new file mode 100644
index 000..d82b3e1
--- /dev/null
+++
b/dev/codeserver/java/com/google/gwt/dev/codeserver/ReverseSourceMap.java
@@ -0,0 +1,42 @@
+package com.google.gwt.dev.codeserver;
+
+import com.google.gwt.core.ext.TreeLogger;
+import com.google.gwt.dev.util.Util;
+import com.google.gwt.thirdparty.debugging.sourcemap.SourceMapConsumerV3;
+import
com.google.gwt.thirdparty.debugging.sourcemap.SourceMapParseException;
+
+/**
+ * A mapping from Java lines to JavaScript.
+ */
+class ReverseSourceMap {
+ private final SourceMapConsumerV3 consumer;
+
+ ReverseSourceMap(SourceMapConsumerV3 consumer) {
+this.consumer = consumer;
+ }
+
+ /**
+ * Reads a source map from disk and parses it into an in-memory
representation.
+ * If it can't be loaded, logs an error and returns null.
+ */
+ static ReverseSourceMap load(TreeLogger logger, ModuleState moduleState)
{
+SourceMapConsumerV3 consumer = new SourceMapConsumerV3();
+String unparsed = Util.readFileAsString(moduleState.findSourceMap());
+try {
+ consumer.parse(unparsed);
+ return new ReverseSourceMap(consumer);
+} catch (SourceMapParseException e) {
+ logger.log(TreeLogger.WARN, "can't parse source map", e);
+ return null;
+}
+ }
+
+ /**
+ * Returns true if the given line in a Java file has any corresponding
JavaScript in
+ * the GWT compiler's output.
+ */
+ boolean appearsInJavaScript(String filename, int lineNumber) {
+// TODO: getReverseMapping() seems to be off by one (lines numbered
from zero). Why?
+return !consumer.getReverseMapping(filename, lineNumber - 1,
-1).isEmpty();
+ }
+}
diff --git
a/dev/codeserver/java/com/google/gwt/dev/codeserver/SourceHandler.java
b/dev/codeserver/java/com/google/gwt/dev/codeserver/SourceHandler.java
index e24755a..d82c804 100644
--- a/dev/codeserver/java/com/google/gwt/dev/codeserver/SourceHandler.java
+++ b/dev/codeserver/java/com/google/gwt/dev/codeserver/SourceHandler.java
@@ -20,8 +20,11 @@
import com.google.gwt.dev.json.JsonArray;
import com.google.gwt.dev.json.JsonObject;
+import java.io.BufferedReader;
+import java.io.File;
import java.io.IOException;
import java.io.InputStream;
+import java.io.InputStreamReader;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
@@ -83,7 +86,7 @@
sendSourceMap(moduleName, request, response);
} else if (rest.endsWith(".java")) {
- sendSourceFile(moduleName, rest, response);
+ sendSourceFile(moduleName, rest, request.getQueryString(), response);
} else {
response.sendError(HttpServletResponse.SC_NOT_FOUND);
@@ -106,8 +109,7 @@
private void sendSourceMap(String moduleName, HttpServletRequest request,
HttpSer
[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3440 to look at the new patch set (#4). Change subject: Optimize initializing fields at the top scope. .. Optimize initializing fields at the top scope. Change-Id: I97a06eb36396a8b8659ce9a025b21a9cf93d0500 --- M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java 1 file changed, 111 insertions(+), 3 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I97a06eb36396a8b8659ce9a025b21a9cf93d0500 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Stephen Haberman -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.
Stephen Haberman has posted comments on this change. Change subject: Optimize initializing fields at the top scope. .. Patch Set 3: (2 comments) File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java Line 2342: canObserveSubclassFields.add(currentClass); Okay, so I implemented a very naive way of checking if "this" could escape via static method or other-instance instance method parameters: just looking at the type signatures. It seems effective, as after also ignoring $init (which was showing up with the name "$$init") and ignoring super/this cstr calls, when running the test only 3 classes are being nominated for the correct/slow non-top level field init: Throwable, http.client.Request, and FieldInitOrderBase (the reproduction of the original issue). All of these nominations seem right, as, inspecting their cstrs, there is polymorphic dispatch to the current instance in each of them. So I think this is pretty good. Line 2498:* Classes that could potentially see uninitialized values for fields that are ininitialized in Done -- To view, visit https://gwt-review.googlesource.com/3440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97a06eb36396a8b8659ce9a025b21a9cf93d0500 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Stephen Haberman Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3440 to look at the new patch set (#5). Change subject: Optimize initializing fields at the top scope. .. Optimize initializing fields at the top scope. Change-Id: I97a06eb36396a8b8659ce9a025b21a9cf93d0500 --- M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java 1 file changed, 110 insertions(+), 3 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I97a06eb36396a8b8659ce9a025b21a9cf93d0500 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Stephen Haberman -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.
Stephen Haberman has posted comments on this change. Change subject: Optimize initializing fields at the top scope. .. Patch Set 5: Tweaked some comments. -- To view, visit https://gwt-review.googlesource.com/3440 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97a06eb36396a8b8659ce9a025b21a9cf93d0500 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Stephen Haberman Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Roberto Lublinerman Gerrit-Reviewer: Stephen Haberman Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Google GWT team meeting notes for June 26th
Thank you. Regards, Matic -- GWT stuff twitter - http://twitter.com/#!/gwtstuff On Thursday, June 27, 2013 8:40:39 PM UTC+2, Brian Slesinsky wrote: > > Hi, in the interest of increased transparency, I'm going to start posting > notes from GWT team meetings at Google. I'm not sure if we'll keep this up > but we'll see how it goes. (My apologies in advance for any errors.) > > June 26, 2013 > > - Discussed goals for the next quarter. Of interest to the community: > - Improving GWT compiler speed is important as usual. > - Improve Super Dev Mode usability to improve internal adoption. In > particular, figure out IDE integration. > - Finish moving documentation to gwtproject.org and redirect from > developers.google.com > - Discussed what we should do with GWT designer documentation. The GWT > designer is currently not being maintained. No resolution yet. > - Discussed how to make mgwt available within Google. > - Discussed community outreach, possibly by having public Hangouts and/or > posting on YouTube. Still in progress. For now, Brian will write up meeting > notes. > - Gardening: new process seemed to work well. Matthew talked about > automating it. > - Talked about adding an end-to-end test for split points. Requires > infrastructure. > - Daniel: javadoc regenerated and moved to gwtproject.org to fix a > security issue. > - We discussed updating Google's internal widgets and widget architecture. > Long term, one idea is to support web components written in JavaScript and > come up with an improvement on JSNI and JavaScriptObjects to allow this. > Goktug and Roberto have an idea they think will work. Short term unclear. > Being able to consume GSS would help. Needs more discussion. > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
