Re: [gwt-contrib] String concatenation

[Julien Dramaix]

Thanks John for the clarification.


On Thu, Oct 31, 2013 at 7:28 PM, John Stalcup  wrote:

> That comment is from the original version of the file committed in 2009.
> None of the original members from that time are still on the project. So
> here's an educated guess.
>
> As John Tamplin said, repeated string concatenation will make some part of
> the AST tree particularly deep and since our visitor passes (which we use
> for optimization and java->javascript semantic transformation) work by
> walking the AST tree with recursive function calls. Getting to the tip of
> that long string concatenation  chain will require a lot of recursion, and
> it might be enough to run out of stack space.
>
> Most JVMs will run out of stack space after about 1000 recursions. I
> believe each AST node traversal costs us 2-3 function calls of stack depth
> (some combination of accept(), traverse() and visit()) and each extra
> concatenation is 2 AST nodes (1 for the "+" and one for the "string") so
> somewhere around 166-250 consecutive string concatenations will be enough
> to overflow the stack.
>
> So yes, it's probably still a good idea for your generator to go out of
> it's way to limit consecutive string concatenations in its output.
>
>
>
> On Thu, Oct 31, 2013 at 1:59 AM, Julien Dramaix 
> wrote:
>
>> Yep sorry it is in CssResourceGenerator line 266
>> And there is a TODO at line 347 : TODO: Fix the compiler to better handle
>> arbitrarily long concatenation expressions.
>>
>> So I was just wondering if something was done or not.
>>
>>
>> On Wednesday, October 30, 2013 9:23:02 PM UTC+1, John Stalcup wrote:
>>
>>> oh you mean in CssResourceGenerator.java
>>>
>>> found it, taking a look
>>>
>>>
>>> On Wed, Oct 30, 2013 at 1:22 PM, John Stalcup  wrote:
>>>
 can you link me to that comment? i'm unfamiliar.


 On Wed, Oct 30, 2013 at 1:10 PM, Julien Dramaix 
 wrote:

> Dear GWT lovers,
>
> I have a question for the compiler guys : in the CssResource I see a
> comment mentioning that very large string concatenation expressions using
> '+' cause the GWT compiler to overflow the stack due to deep AST nesting.
> So it's preferable to use intermediate concatenation groupings in order to
> force the AST to be more balanced.
>
> I'm just wondering if this issue is still present with the actual
> version of the compiler or if it was fixed to better handle large
> concatenation ?
>
> Thanks,
>
> Julien
>
> --
> http://groups.google.com/**group/Google-Web-Toolkit-**Contributors
> ---
> You received this message because you are subscribed to the Google
> Groups "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to google-web-toolkit-**contributors+unsubscribe@**
> googlegroups.com.
> For more options, visit 
> https://groups.google.com/**groups/opt_out
> .
>


>>>  --
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "GWT Contributors" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>
>  --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: GPE does not like GWT trunk SDK?

[Jens]

> As for the problem you've noted, I'll fix that up this week and we'll aim 
> to put out a release that works with GWT trunk in the next two weeks.
>

Sounds great. Thanks a lot!

-- J. 

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] String concatenation

[John Stalcup]

That comment is from the original version of the file committed in 2009.
None of the original members from that time are still on the project. So
here's an educated guess.

As John Tamplin said, repeated string concatenation will make some part of
the AST tree particularly deep and since our visitor passes (which we use
for optimization and java->javascript semantic transformation) work by
walking the AST tree with recursive function calls. Getting to the tip of
that long string concatenation  chain will require a lot of recursion, and
it might be enough to run out of stack space.

Most JVMs will run out of stack space after about 1000 recursions. I
believe each AST node traversal costs us 2-3 function calls of stack depth
(some combination of accept(), traverse() and visit()) and each extra
concatenation is 2 AST nodes (1 for the "+" and one for the "string") so
somewhere around 166-250 consecutive string concatenations will be enough
to overflow the stack.

So yes, it's probably still a good idea for your generator to go out of
it's way to limit consecutive string concatenations in its output.



On Thu, Oct 31, 2013 at 1:59 AM, Julien Dramaix wrote:

> Yep sorry it is in CssResourceGenerator line 266
> And there is a TODO at line 347 : TODO: Fix the compiler to better handle
> arbitrarily long concatenation expressions.
>
> So I was just wondering if something was done or not.
>
>
> On Wednesday, October 30, 2013 9:23:02 PM UTC+1, John Stalcup wrote:
>
>> oh you mean in CssResourceGenerator.java
>>
>> found it, taking a look
>>
>>
>> On Wed, Oct 30, 2013 at 1:22 PM, John Stalcup  wrote:
>>
>>> can you link me to that comment? i'm unfamiliar.
>>>
>>>
>>> On Wed, Oct 30, 2013 at 1:10 PM, Julien Dramaix wrote:
>>>
 Dear GWT lovers,

 I have a question for the compiler guys : in the CssResource I see a
 comment mentioning that very large string concatenation expressions using
 '+' cause the GWT compiler to overflow the stack due to deep AST nesting.
 So it's preferable to use intermediate concatenation groupings in order to
 force the AST to be more balanced.

 I'm just wondering if this issue is still present with the actual
 version of the compiler or if it was fixed to better handle large
 concatenation ?

 Thanks,

 Julien

 --
 http://groups.google.com/**group/Google-Web-Toolkit-**Contributors
 ---
 You received this message because you are subscribed to the Google
 Groups "GWT Contributors" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to google-web-toolkit-**contributors+unsubscribe@**
 googlegroups.com.
 For more options, visit 
 https://groups.google.com/**groups/opt_out
 .

>>>
>>>
>>  --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: GPE does not like GWT trunk SDK?

[Stephen Haberman]

Hi Rajeev,

Good to hear from you.

> We're in the process of moving the GPE source to github (and
> converting the build system to Maven/Tycho so that external
> developers can build it) , which is why that repo hasn't been updated
> in a long time. I'll update the homepage to reflect that.

Sounds like a good plan. Thanks!

- Stephen

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: GPE does not like GWT trunk SDK?

[Rajeev Dayal]

Hey Stephen,

We're in the process of moving the GPE source to github (and converting the
build system to Maven/Tycho so that external developers can build it) ,
which is why that repo hasn't been updated in a long time. I'll update the
homepage to reflect that.

As for the problem you've noted, I'll fix that up this week and we'll aim
to put out a release that works with GWT trunk in the next two weeks.


Thanks,
Rajeev


On Wed, Oct 30, 2013 at 2:41 PM, Stephen Haberman
wrote:

>
> I was going to ask how active the GPE project is...is the last commit
> really from October 2012?
>
> https://code.google.com/p/google-plugin-for-eclipse/source/list
>
> That doesn't seem right, but AFAICT there isn't another source repo?
>
> https://developers.google.com/eclipse/community
>
> - Stephen
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
> ---
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] Re: Next GWT Contributor Hangout

[Matthew Dempsky]

On Thu, Oct 31, 2013 at 7:32 AM, Paul Stockley  wrote:

> When will the video be posted. Thx
>

Sorry, we weren't able to record this meeting due to technical
difficulties. :(

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Re: Next GWT Contributor Hangout

[Paul Stockley]

When will the video be posted. Thx

On Friday, October 25, 2013 5:08:19 PM UTC-4, Bhaskar Janakiraman wrote:
>
> The next GWT contributors hangout will be on Wednesday, Oct 30, 10.45 - 
> 11.30am PST. 
>
> We are making a change to the hangout sessions: it will be a regular 
> hangout and not a hangout-on-air, but we will record the session and upload 
> the video. Reasons for this:
> 1. Improved audio quality with regular hangout.
> 2. In the last couple of sessions, we only had 2-3 people who were 
> watching it live. 
>
> The video will be accessible from the GWT G+ 
> page
> .
>
> As before, if you want to participate in person in the hangout, please 
> send me your email address (to: bjanakiraman at google.com)  and I will 
> invite you to the hangout (limit of 10 remote participants). 
> Agenda:
>
> - GWT 2.6, status, patches in progress
> - Update on modular compilation and other on-going efforts. 
>
> Thanks,
> Bhaskar
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [gwt-contrib] String concatenation

[Julien Dramaix]

Yep sorry it is in CssResourceGenerator line 266
And there is a TODO at line 347 : TODO: Fix the compiler to better handle 
arbitrarily long concatenation expressions.

So I was just wondering if something was done or not.

On Wednesday, October 30, 2013 9:23:02 PM UTC+1, John Stalcup wrote:
>
> oh you mean in CssResourceGenerator.java
>
> found it, taking a look
>
>
> On Wed, Oct 30, 2013 at 1:22 PM, John Stalcup 
> > wrote:
>
>> can you link me to that comment? i'm unfamiliar.
>>
>>
>> On Wed, Oct 30, 2013 at 1:10 PM, Julien Dramaix 
>> 
>> > wrote:
>>
>>> Dear GWT lovers,
>>>
>>> I have a question for the compiler guys : in the CssResource I see a 
>>> comment mentioning that very large string concatenation expressions using 
>>> '+' cause the GWT compiler to overflow the stack due to deep AST nesting. 
>>> So it's preferable to use intermediate concatenation groupings in order to 
>>> force the AST to be more balanced. 
>>>
>>> I'm just wondering if this issue is still present with the actual 
>>> version of the compiler or if it was fixed to better handle large 
>>> concatenation ?
>>>
>>> Thanks,
>>>
>>> Julien
>>>
>>> -- 
>>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>>> --- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "GWT Contributors" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to 
>>> google-web-toolkit-contributors+unsubscr...@googlegroups.com
>>> .
>>> For more options, visit https://groups.google.com/groups/opt_out.
>>>
>>
>>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] GWT 2.6.0 will be still Ant based or already Gradle bases? (for OSGI-fy GWT)

[Cristiano]

Hi All,

I would like to know if the plan for 2.6.0 is to still use Ant or release 
it already from Gradle.

I ask this because I would to check the feasibility of OSGIfy the 
GWT-Servlet jar.
Having an OSGi compliant GWT-Servlet should make it easier to use GWT on 
OSGi containers (I suppose it is enough to OSGIfy GWT-Servlet as it is the 
only Jar I expect to to on the server side).

Some background information:
OSGI-fization takes place by modify the META-INF/MANIFEST.MF file of the 
Jar and adding new headers that allow the jar to be used more "friendly" in 
an OSGi environment.

This modification is mostly transparent, many much jar lbraries you are 
using are already OSGIfied or exist in an OSGIfied version (one example 
among all: the org.eclipse.jdt.core_3.8.3.v20130121-145325.jar that is in 
GWT-Tools is OSGIfied).

The best way to OSGIfy a Jar is to use the BND tool at build time, which 
automates most of the process of creating OSGI headers.
BND tool can be invoked with ant task (http://www.aqute.biz/Bnd/Ant) or 
with the maven-bundle-plugin 
(http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html) or 
I see it exists also a Gradle OSGI plugin 
(http://www.gradle.org/docs/current/userguide/osgi_plugin.html).


In the end, I would like to know if it is best to focus on trying the BND 
Ant Task or the Gradle OSGI Plugin. 

Thank you,
Cristiano

P.S. On maven central repo it exists an OSGIfied version of GWT:
org.apache.servicemix.bundles/org.apache.servicemix.bundles.gwt-user/2.4.0_1 
org.apache.servicemix.bundles/org.apache.servicemix.bundles.gwt-dev/2.4.0_1
which they old (linked to gwt 2.4.0) and not optimal as exactly the 
gwt-servlet jar is missing! 

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.