[gwt-contrib] Change in gwt[master]: Reduce ClassSourceFileComposer memory and time complexity to...
Matthew Dempsky has abandoned this change. Change subject: Reduce ClassSourceFileComposer memory and time complexity to O(N) .. Abandoned Submitted. -- To view, visit https://gwt-review.googlesource.com/2460 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I30301a58bad0244a41b08fb534c4cb18b90c9494 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Reduce ClassSourceFileComposer memory and time complexity to...
Matthew Dempsky has posted comments on this change. Change subject: Reduce ClassSourceFileComposer memory and time complexity to O(N) .. Patch Set 2: (1 comment) File user/src/com/google/gwt/user/rebind/ClassSourceFileComposer.java Line 163: printWriter.print(s.substring(pos, nl + 1)); Done. I decided to use write() since that's the more primitive method (at least in OpenJDK's implementation), so it might actually avoid a substring() call. However, write()'s second integer argument is a length field, not an end position like substring() and append(), so an extra subtraction is required. -- To view, visit https://gwt-review.googlesource.com/2460 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30301a58bad0244a41b08fb534c4cb18b90c9494 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Reduce ClassSourceFileComposer memory and time complexity to...
Matthew Dempsky has uploaded a new patch set (#4). Change subject: Reduce ClassSourceFileComposer memory and time complexity to O(N) .. Reduce ClassSourceFileComposer memory and time complexity to O(N) For long strings with lots of newlines, the current recursive algorithm results in a bunch of nested call frames, each keeping a large portion of the original string in memory. Switching to an iterative algorithm avoids keeping more than one or two copies of the input string alive in memory at a time. Change-Id: I30301a58bad0244a41b08fb534c4cb18b90c9494 Review-Link: https://gwt-review.googlesource.com/#/c/2460/ --- M user/src/com/google/gwt/user/rebind/ClassSourceFileComposer.java 1 file changed, 25 insertions(+), 22 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2460 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I30301a58bad0244a41b08fb534c4cb18b90c9494 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Reduce ClassSourceFileComposer memory and time complexity to...
Matthew Dempsky has uploaded a new patch set (#3). Change subject: Reduce ClassSourceFileComposer memory and time complexity to O(N) .. Reduce ClassSourceFileComposer memory and time complexity to O(N) For long strings with lots of newlines, the current recursive algorithm results in a bunch of nested call frames, each keeping a large portion of the original string in memory. Switching to an iterative algorithm avoids keeping more than one or two copies of the input string alive in memory at a time. Change-Id: I30301a58bad0244a41b08fb534c4cb18b90c9494 Review-Link: https://gwt-review.googlesource.com/#/c/2460/ --- M user/src/com/google/gwt/user/rebind/ClassSourceFileComposer.java 1 file changed, 25 insertions(+), 22 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2460 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I30301a58bad0244a41b08fb534c4cb18b90c9494 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Reduce ClassSourceFileComposer memory and time complexity to...
Thomas Broyer has posted comments on this change.
Change subject: Reduce ClassSourceFileComposer memory and time complexity
to O(N)
..
Patch Set 2: Code-Review+1
(1 comment)
I'm fine with pushing the fix of print("foo\n") to a separate change.
File user/src/com/google/gwt/user/rebind/ClassSourceFileComposer.java
Line 163: printWriter.print(s.substring(pos, nl + 1));
Nit: how about:
printWriter.append(s, pos, nl + 1);
or
printWriter.write(s, pos, nl + 1);
I wouldn't count on any gain cpu/memory-wise but I find them slightly more
readable.
--
To view, visit https://gwt-review.googlesource.com/2460
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30301a58bad0244a41b08fb534c4cb18b90c9494
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Matthew Dempsky
Gerrit-Reviewer: Matthew Dempsky
Gerrit-Reviewer: Thomas Broyer
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Reduce ClassSourceFileComposer memory and time complexity to...
Matthew Dempsky has uploaded a new patch set (#2). Change subject: Reduce ClassSourceFileComposer memory and time complexity to O(N) .. Reduce ClassSourceFileComposer memory and time complexity to O(N) For long strings with lots of newlines, the current recursive algorithm results in a bunch of nested call frames, each keeping a large portion of the original string in memory. Switching to an iterative algorithm avoids keeping more than one or two copies of the input string alive in memory at a time. Change-Id: I30301a58bad0244a41b08fb534c4cb18b90c9494 Review-Link: https://gwt-review.googlesource.com/#/c/2460/ --- M user/src/com/google/gwt/user/rebind/ClassSourceFileComposer.java 1 file changed, 25 insertions(+), 22 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2460 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I30301a58bad0244a41b08fb534c4cb18b90c9494 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
