[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Goktug Gokdogan has abandoned this change. Change subject: Verify that Timer has not been canceled before firing .. Abandoned Submitted. Thanks! -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has posted comments on this change. Change subject: Verify that Timer has not been canceled before firing .. Patch Set 4: What is the status of this? Is something still needed from me to get this submitted? -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Matthew Dempsky has posted comments on this change. Change subject: Verify that Timer has not been canceled before firing .. Patch Set 4: Most of Google's GWT team is out-of-office today, but we should be able to submit this on Monday. -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has uploaded a new patch set (#3). Change subject: Verify that Timer has not been canceled before firing .. Verify that Timer has not been canceled before firing * cancelTimeout is not always effective with older versions of IE * Add cancelCounter that is updated when canceling and verified when firing * Fixes Issue 8101 Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 --- M user/src/com/google/gwt/user/client/Timer.java A user/test/com/google/gwt/user/client/TimerCancelTest.java 2 files changed, 137 insertions(+), 7 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has uploaded a new patch set (#4). Change subject: Verify that Timer has not been canceled before firing .. Verify that Timer has not been canceled before firing * cancelTimeout is not always effective with older versions of IE * Add cancelCounter that is updated when canceling and verified when firing * Fixes Issue 8101 Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 --- M user/src/com/google/gwt/user/client/Timer.java M user/test/com/google/gwt/user/MiscSuite.java A user/test/com/google/gwt/user/client/TimerCancelTest.java 3 files changed, 143 insertions(+), 7 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has abandoned this change. Change subject: Verify that Timer has not been canceled before firing .. Abandoned Submission to google-web-toolkit-contributors failed because my account was not a member of that group. Abandoning this and submitting the ticket again now that I have joined the group to make sure everything gets properly registered. -- To view, visit https://gwt-review.googlesource.com/2510 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I68fbe0896dc9d494bbdb86fd2220d4b8a3710420 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has uploaded a new patch set (#2). Change subject: Verify that Timer has not been canceled before firing .. Verify that Timer has not been canceled before firing * cancelTimeout is not always effective with older versions of IE * Add cancelCounter that is updated when canceling and verified when firing * Fixes Issue 8101 Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 --- M user/src/com/google/gwt/user/client/Timer.java A user/test/com/google/gwt/user/client/TimerCancelTest.java 2 files changed, 117 insertions(+), 7 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has posted comments on this change. Change subject: Verify that Timer has not been canceled before firing .. Patch Set 2: Whitespace nits resolved. Where can I find instructions for how to configure Eclipse to not automatically add that whitespace back when formatting the code using the formatter settings included with the project? -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Leif Åstrand has posted comments on this change. Change subject: Verify that Timer has not been canceled before firing .. Patch Set 3: But the problem is not so much about whether those spaces are there or not, but more about including only the relevant changes in the patch (i.e. git add -p vs. git add). Does not help when the extra spaces are in lines added by the patch. -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Goktug Gokdogan has posted comments on this change. Change subject: Verify that Timer has not been canceled before firing .. Patch Set 4: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Daniel Kurka has posted comments on this change. Change subject: Verify that Timer has not been canceled before firing .. Patch Set 1: Code-Review+1 (4 comments) small nits, see comments File user/src/com/google/gwt/user/client/Timer.java Line 143:* nit white space File user/test/com/google/gwt/user/client/TimerCancelTest.java Line 3: * nit: whitespace Line 6: * nit: whitespace Line 8: * nit: whitespace -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Thomas Broyer has posted comments on this change.
Change subject: Verify that Timer has not been canceled before firing
..
Patch Set 2:
(3 comments)
Where can I find instructions for how to configure Eclipse
to not automatically add that whitespace back when
formatting the code using the formatter settings included
with the project?
No idea. AFAIK, Eclipse and IntelliJ IDEA insist in using 2 distinct rules.
But the problem is not so much about whether those spaces are there or not,
but more about including only the relevant changes in the patch (i.e. git
add -p vs. git add).
File user/test/com/google/gwt/user/client/TimerCancelTest.java
Line 29: private int timerCount;
This field should live in the CountingTimer, which could thus become a
static nested class, and removes the need for the gwtSetUp (which is
probably not needed anyway, even in the current configuration).
Line 51: // Busy wait so that both timers will be added to the event
loop queue the next time it is
Is this really needed? If so, can you please add a comment somewhere
explaining exactly the conditions the issue manifests itself?
Line 97: public String getModuleName() {
Move at the top of the class.
--
To view, visit https://gwt-review.googlesource.com/2511
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Leif Åstrand l...@vaadin.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Leif Åstrand l...@vaadin.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Matthew Dempsky has posted comments on this change. Change subject: Verify that Timer has not been canceled before firing .. Patch Set 1: FYI, no need to abandon. That error message was just for posting the message to the mailing list. -- To view, visit https://gwt-review.googlesource.com/2510 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68fbe0896dc9d494bbdb86fd2220d4b8a3710420 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Matthew Dempsky has posted comments on this change.
Change subject: Verify that Timer has not been canceled before firing
..
Patch Set 3:
(2 comments)
File user/src/com/google/gwt/user/client/Timer.java
Line 52: private static native void clearInterval(int id) /*-{
I know this is pre-existing, but why are these methods native? Can we
change them to be Java calls to Impl.clearInterval and Impl.clearTimeout?
File user/test/com/google/gwt/user/client/TimerCancelTest.java
Line 20: public class TimerCancelTest extends GWTTestCase {
You'll need to add this Test class to a test suite for it to run. I'd pick
MiscSuite arbitrarily, since there doesn't seem to be a more appropriate
one.
--
To view, visit https://gwt-review.googlesource.com/2511
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Leif Åstrand l...@vaadin.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Leif Åstrand l...@vaadin.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Goktug Gokdogan has posted comments on this change.
Change subject: Verify that Timer has not been canceled before firing
..
Patch Set 3:
(2 comments)
File user/src/com/google/gwt/user/client/Timer.java
Line 52: private static native void clearInterval(int id) /*-{
According to history, converted from @wnd recently. I can't see any reason.
Line 88: private int cancelCounter = 0;
Can you put a short description? Something like:
// To workaround clearTimeout bug in IE:
https://code.google.com/p/google-web-toolkit/issues/detail?id=8101
--
To view, visit https://gwt-review.googlesource.com/2511
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Leif Åstrand l...@vaadin.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Leif Åstrand l...@vaadin.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Verify that Timer has not been canceled before firing
Brian Slesinsky has posted comments on this change. Change subject: Verify that Timer has not been canceled before firing .. Patch Set 3: To be specific, it was changed as part of Ray's massive patch to support module unloading, so added Ray as a reviewer. -- To view, visit https://gwt-review.googlesource.com/2511 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac16598bef878ed756f2fe0dc696166f2a3d504 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leif Åstrand l...@vaadin.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
