[gwt-contrib] Re: [google-web-toolkit commit] r5537 - Ant rework for speed:
Thanks. Submit @r5563; as usual, shout if there are other problems. This should have accelerated the dist-dev case (by not needing tools), but is really a bugfix patch. On Tue, Jun 16, 2009 at 10:27 AM, BobV wrote: > On Tue, Jun 16, 2009 at 12:46 AM, Freeland Abbott > wrote: > > Ping. Bob, I think you had special interest in this one. ;-) > > ant clear dist-dev && cd user && ant test > > does the right thing. > > LGTM. > > -- > Bob Vawter > Google Web Toolkit Team > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: [google-web-toolkit commit] r5537 - Ant rework for speed:
On Tue, Jun 16, 2009 at 12:46 AM, Freeland Abbott wrote: > Ping. Bob, I think you had special interest in this one. ;-) ant clear dist-dev && cd user && ant test does the right thing. LGTM. -- Bob Vawter Google Web Toolkit Team --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: [google-web-toolkit commit] r5537 - Ant rework for speed:
Ping. Bob, I think you had special interest in this one. ;-) On Mon, Jun 15, 2009 at 1:27 PM, Freeland Abbott wrote: > Bob notes that dist-dev doesn't need (and thus shouldn't have) its > dependency on tools. I take that as tacit agreement that dist-dev can be > the "minimally build everything for test execution" name. > > > > On Mon, Jun 15, 2009 at 11:53 AM, Freeland Abbott wrote: > >> Bob, John, can you review? This doesn't address the "buildonly or >> dist-dev as precursor to user/test" question, but I think addresses Thomas' >> and Bob's other issue. >> >> >> >> >> On Mon, Jun 15, 2009 at 11:47 AM, Freeland Abbott wrote: >> >>> +GWTC >>> >>> With regard to the Mac looking for gwt-dev-linux, since I don't literally >>> see a build-dev target, what's the chain above the line you cited? I >>> thought my fixes to in e.g. user/build.xml line 47 >>> addressed that, and I see I missed some (in doc, samples, and soyc-vis... >>> only the last of which is likely to be stopping you, though). >>> >>> >>> With regard to using buildonly as precursor to tests, I think you want to >>> the target dist-dev, though I'm open to suggestions for how this "should" >>> work. It used to be that: >>> >>>1. we had both "build" and "dist," as separate targets (unchanged), >>>2. tests effectively require a distribution to run in (unchanged), >>>3. we had "buildonly," but did not have "dist-dev," so the two were >>>blurred explicitly (changed), >>>4. "build" depended, by way of "-do," on "dist," which I found >>>confusingly backwards (changed), >>>5. top-level "test" depended on "build", which depended on "dist" as >>>above (changed to depend on "dist-one," but should probably be dist-dev >>>instead now that it exists), >>>6. "build" was the default target, which as above worked because it >>>ran "dist" as a dependency (changed; "dist" is project default target, >>> and >>>depends on build). >>> >>> Solutions: >>> >>>1. Do we want buildonly to imply dist-dev? Do we want build to imply >>>dist? My intuition is no, that if separate, build builds and dist >>> packages >>>and dist needs build (but not vice-versa). That is semantic a change >>> from >>>before, though. >>>2. If not, then we want to retrain ourselves to use dist-dev at least >>>once, to get the distro set, even if you then use buildonly after that to >>>refresh sources? >>> >>> >>> >>> >>> On Mon, Jun 15, 2009 at 11:10 AM, Freeland Abbott wrote: >>> Thanks, I'll revisit. On Mon, Jun 15, 2009 at 10:43 AM, BobV wrote: > > This no longer correctly works on mac platform. > > ant buildonly && cd user && ant test > /Users/bob/gwt/trunk/common.ant.xml:299: GWT must be built before > performing any tests. This can be fixed by running ant in the > /Users/bob/gwt/trunk directory. > > > also, the ant build-dev target fails: > /Users/bob/gwt/trunk/common.ant.xml:299: Cannot find dependency > /Users/bob/gwt/trunk/build/lib/gwt-dev-linux.jar > > > -- > Bob Vawter > Google Web Toolkit Team > >>> >> > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: [google-web-toolkit commit] r5537 - Ant rework for speed:
Bob notes that dist-dev doesn't need (and thus shouldn't have) its
dependency on tools. I take that as tacit agreement that dist-dev can be
the "minimally build everything for test execution" name.
On Mon, Jun 15, 2009 at 11:53 AM, Freeland Abbott wrote:
> Bob, John, can you review? This doesn't address the "buildonly or dist-dev
> as precursor to user/test" question, but I think addresses Thomas' and Bob's
> other issue.
>
>
>
>
> On Mon, Jun 15, 2009 at 11:47 AM, Freeland Abbott wrote:
>
>> +GWTC
>>
>> With regard to the Mac looking for gwt-dev-linux, since I don't literally
>> see a build-dev target, what's the chain above the line you cited? I
>> thought my fixes to in e.g. user/build.xml line 47
>> addressed that, and I see I missed some (in doc, samples, and soyc-vis...
>> only the last of which is likely to be stopping you, though).
>>
>>
>> With regard to using buildonly as precursor to tests, I think you want to
>> the target dist-dev, though I'm open to suggestions for how this "should"
>> work. It used to be that:
>>
>>1. we had both "build" and "dist," as separate targets (unchanged),
>>2. tests effectively require a distribution to run in (unchanged),
>>3. we had "buildonly," but did not have "dist-dev," so the two were
>>blurred explicitly (changed),
>>4. "build" depended, by way of "-do," on "dist," which I found
>>confusingly backwards (changed),
>>5. top-level "test" depended on "build", which depended on "dist" as
>>above (changed to depend on "dist-one," but should probably be dist-dev
>>instead now that it exists),
>>6. "build" was the default target, which as above worked because it
>>ran "dist" as a dependency (changed; "dist" is project default target, and
>>depends on build).
>>
>> Solutions:
>>
>>1. Do we want buildonly to imply dist-dev? Do we want build to imply
>>dist? My intuition is no, that if separate, build builds and dist
>> packages
>>and dist needs build (but not vice-versa). That is semantic a change from
>>before, though.
>>2. If not, then we want to retrain ourselves to use dist-dev at least
>>once, to get the distro set, even if you then use buildonly after that to
>>refresh sources?
>>
>>
>>
>>
>> On Mon, Jun 15, 2009 at 11:10 AM, Freeland Abbott wrote:
>>
>>> Thanks, I'll revisit.
>>>
>>>
>>>
>>> On Mon, Jun 15, 2009 at 10:43 AM, BobV wrote:
>>>
This no longer correctly works on mac platform.
ant buildonly && cd user && ant test
/Users/bob/gwt/trunk/common.ant.xml:299: GWT must be built before
performing any tests. This can be fixed by running ant in the
/Users/bob/gwt/trunk directory.
also, the ant build-dev target fails:
/Users/bob/gwt/trunk/common.ant.xml:299: Cannot find dependency
/Users/bob/gwt/trunk/build/lib/gwt-dev-linux.jar
--
Bob Vawter
Google Web Toolkit Team
>>>
>>>
>>
>
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Index: build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java
===
--- build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java (revision 5558)
+++ build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java (working copy)
@@ -116,8 +116,12 @@
@Override
public void addToZip(ZipOutputStream out, String path) throws IOException {
FileInputStream inStream = new FileInputStream(tmpFile);
- doZipFile(inStream, out, path, timestamp, archive, mode);
- tmpFile.delete();
+ try {
+doZipFile(inStream, out, path, timestamp, archive, mode);
+tmpFile.delete();
+ } finally {
+inStream.close();
+ }
}
}
Index: build.xml
===
--- build.xml (revision 5558)
+++ build.xml (working copy)
@@ -35,7 +35,7 @@
-
+
@@ -93,7 +93,7 @@
-
+
Index: tools/api-checker/build.xml
===
--- tools/api-checker/build.xml (revision 5558)
+++ tools/api-checker/build.xml (working copy)
@@ -7,7 +7,7 @@
-
+
Index: tools/soyc-vis/build.xml
===
--- tools/soyc-vis/build.xml (revision 5558)
+++ tools/soyc-vis/build.xml (working copy)
@@ -7,7 +7,7 @@
-
+
@@ -41,4 +41,4 @@
-
\ No newline at end of file
+
Index: samples/common.ant.xml
===
--- samples/common.ant.xml (revision 5558)
+++ samples/common.ant.xml (working copy)
@@ -16,7 +16,7 @@
-
+
Index: doc/build.xml
==
[gwt-contrib] Re: [google-web-toolkit commit] r5537 - Ant rework for speed:
Bob, John, can you review? This doesn't address the "buildonly or dist-dev
as precursor to user/test" question, but I think addresses Thomas' and Bob's
other issue.
On Mon, Jun 15, 2009 at 11:47 AM, Freeland Abbott wrote:
> +GWTC
>
> With regard to the Mac looking for gwt-dev-linux, since I don't literally
> see a build-dev target, what's the chain above the line you cited? I
> thought my fixes to in e.g. user/build.xml line 47
> addressed that, and I see I missed some (in doc, samples, and soyc-vis...
> only the last of which is likely to be stopping you, though).
>
>
> With regard to using buildonly as precursor to tests, I think you want to
> the target dist-dev, though I'm open to suggestions for how this "should"
> work. It used to be that:
>
>1. we had both "build" and "dist," as separate targets (unchanged),
>2. tests effectively require a distribution to run in (unchanged),
>3. we had "buildonly," but did not have "dist-dev," so the two were
>blurred explicitly (changed),
>4. "build" depended, by way of "-do," on "dist," which I found
>confusingly backwards (changed),
>5. top-level "test" depended on "build", which depended on "dist" as
>above (changed to depend on "dist-one," but should probably be dist-dev
>instead now that it exists),
>6. "build" was the default target, which as above worked because it ran
>"dist" as a dependency (changed; "dist" is project default target, and
>depends on build).
>
> Solutions:
>
>1. Do we want buildonly to imply dist-dev? Do we want build to imply
>dist? My intuition is no, that if separate, build builds and dist packages
>and dist needs build (but not vice-versa). That is semantic a change from
>before, though.
>2. If not, then we want to retrain ourselves to use dist-dev at least
>once, to get the distro set, even if you then use buildonly after that to
>refresh sources?
>
>
>
>
> On Mon, Jun 15, 2009 at 11:10 AM, Freeland Abbott wrote:
>
>> Thanks, I'll revisit.
>>
>>
>>
>> On Mon, Jun 15, 2009 at 10:43 AM, BobV wrote:
>>
>>>
>>> This no longer correctly works on mac platform.
>>>
>>> ant buildonly && cd user && ant test
>>> /Users/bob/gwt/trunk/common.ant.xml:299: GWT must be built before
>>> performing any tests. This can be fixed by running ant in the
>>> /Users/bob/gwt/trunk directory.
>>>
>>>
>>> also, the ant build-dev target fails:
>>> /Users/bob/gwt/trunk/common.ant.xml:299: Cannot find dependency
>>> /Users/bob/gwt/trunk/build/lib/gwt-dev-linux.jar
>>>
>>>
>>> --
>>> Bob Vawter
>>> Google Web Toolkit Team
>>>
>>
>>
>
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Index: build.xml
===
--- build.xml (revision 5557)
+++ build.xml (working copy)
@@ -93,7 +93,7 @@
-
+
Index: build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java
===
--- build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java (revision 5557)
+++ build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java (working copy)
@@ -116,8 +116,12 @@
@Override
public void addToZip(ZipOutputStream out, String path) throws IOException {
FileInputStream inStream = new FileInputStream(tmpFile);
- doZipFile(inStream, out, path, timestamp, archive, mode);
- tmpFile.delete();
+ try {
+doZipFile(inStream, out, path, timestamp, archive, mode);
+tmpFile.delete();
+ } finally {
+inStream.close();
+ }
}
}
Index: tools/api-checker/build.xml
===
--- tools/api-checker/build.xml (revision 5557)
+++ tools/api-checker/build.xml (working copy)
@@ -7,7 +7,7 @@
-
+
Index: tools/soyc-vis/build.xml
===
--- tools/soyc-vis/build.xml (revision 5557)
+++ tools/soyc-vis/build.xml (working copy)
@@ -7,7 +7,7 @@
-
+
@@ -41,4 +41,4 @@
-
\ No newline at end of file
+
Index: samples/common.ant.xml
===
--- samples/common.ant.xml (revision 5557)
+++ samples/common.ant.xml (working copy)
@@ -16,7 +16,7 @@
-
+
Index: doc/build.xml
===
--- doc/build.xml (revision 5557)
+++ doc/build.xml (working copy)
@@ -7,7 +7,7 @@
-
+
[gwt-contrib] Re: [google-web-toolkit commit] r5537 - Ant rework for speed:
+GWTC With regard to the Mac looking for gwt-dev-linux, since I don't literally see a build-dev target, what's the chain above the line you cited? I thought my fixes to in e.g. user/build.xml line 47 addressed that, and I see I missed some (in doc, samples, and soyc-vis... only the last of which is likely to be stopping you, though). With regard to using buildonly as precursor to tests, I think you want to the target dist-dev, though I'm open to suggestions for how this "should" work. It used to be that: 1. we had both "build" and "dist," as separate targets (unchanged), 2. tests effectively require a distribution to run in (unchanged), 3. we had "buildonly," but did not have "dist-dev," so the two were blurred explicitly (changed), 4. "build" depended, by way of "-do," on "dist," which I found confusingly backwards (changed), 5. top-level "test" depended on "build", which depended on "dist" as above (changed to depend on "dist-one," but should probably be dist-dev instead now that it exists), 6. "build" was the default target, which as above worked because it ran "dist" as a dependency (changed; "dist" is project default target, and depends on build). Solutions: 1. Do we want buildonly to imply dist-dev? Do we want build to imply dist? My intuition is no, that if separate, build builds and dist packages and dist needs build (but not vice-versa). That is semantic a change from before, though. 2. If not, then we want to retrain ourselves to use dist-dev at least once, to get the distro set, even if you then use buildonly after that to refresh sources? On Mon, Jun 15, 2009 at 11:10 AM, Freeland Abbott wrote: > Thanks, I'll revisit. > > > > On Mon, Jun 15, 2009 at 10:43 AM, BobV wrote: > >> >> This no longer correctly works on mac platform. >> >> ant buildonly && cd user && ant test >> /Users/bob/gwt/trunk/common.ant.xml:299: GWT must be built before >> performing any tests. This can be fixed by running ant in the >> /Users/bob/gwt/trunk directory. >> >> >> also, the ant build-dev target fails: >> /Users/bob/gwt/trunk/common.ant.xml:299: Cannot find dependency >> /Users/bob/gwt/trunk/build/lib/gwt-dev-linux.jar >> >> >> -- >> Bob Vawter >> Google Web Toolkit Team >> > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: [google-web-toolkit commit] r5537 - Ant rework for speed:
Well, if we get an exception, the train is coming to a halt anyway. But yes, it's a good suggestion. On Mon, Jun 15, 2009 at 11:33 AM, John Tamplin wrote: > On Mon, Jun 15, 2009 at 11:29 AM, Freeland Abbott wrote: > >> LGTM; I'll submit it shortly. > > > Don't you need try/finally to make sure it is cleaned up in the event of an > exception? > > -- > John A. Tamplin > Software Engineer (GWT), Google > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: [google-web-toolkit commit] r5537 - Ant rework for speed:
On Mon, Jun 15, 2009 at 11:29 AM, Freeland Abbott wrote: > LGTM; I'll submit it shortly. Don't you need try/finally to make sure it is cleaned up in the event of an exception? -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: [google-web-toolkit commit] r5537 - Ant rework for speed:
LGTM; I'll submit it shortly. On Fri, Jun 12, 2009 at 7:43 AM, Thomas Matthijs wrote: > > Hey, > > Running out of FD's since this patch on a clean build, not sure if its > correct but: > > Index: > build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java > === > --- build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java > (revision 5548) > +++ build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java > (working copy) > @@ -118,6 +118,7 @@ > FileInputStream inStream = new FileInputStream(tmpFile); > doZipFile(inStream, out, path, timestamp, archive, mode); > tmpFile.delete(); > + inStream.close(); > } > } > > > > --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: [google-web-toolkit commit] r5537 - Ant rework for speed:
Hey, Running out of FD's since this patch on a clean build, not sure if its correct but: Index: build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java === --- build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java (revision 5548) +++ build-tools/ant-gwt/src/com/google/gwt/ant/taskdefs/LatestTimeJar.java (working copy) @@ -118,6 +118,7 @@ FileInputStream inStream = new FileInputStream(tmpFile); doZipFile(inStream, out, path, timestamp, archive, mode); tmpFile.delete(); + inStream.close(); } } --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
