[gwt-contrib] Re: - Extended the a11y role API with methods that have UIObject parameter. (issue1828804)
Hmm. If it were named "HasAriaElement", then it would make sense that not all widgets implement it. Only those that need to be customized for proper Aria support would have it. http://gwt-code-reviews.appspot.com/1828804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: - Extended the a11y role API with methods that have UIObject parameter. (issue1828804)
On 2012/09/12 19:18:12, skybrian wrote: We've decided against this change for now (increases the size of the API too much). A HasElement interface sounds somewhat reasonable but we can add that later if needed. I suppose if Element implemented HasElement, returning itself, we could avoid doubling the number of methods, but this seems overly tricky when calling getElement() yourself isn't hard. Plus: some widgets already have ARIA roles. So maybe a better long-term solution would be to add methods on "generic" widgets to allow one to set a role for it (e.g. setWidgetRole(Widget, Role) on DockLayoutPanel, setRole(Role) on SimplePanel, etc.), so that those widgets with already-specified roles (e.g. Tree/CellTree, CellTable, TabPanel, etc.) cannot be given a new role without some "trickery" (at the very least a call to getElement(), which is a generally-understood signal that "from now one, if something break, blame yourself"). http://gwt-code-reviews.appspot.com/1828804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: - Extended the a11y role API with methods that have UIObject parameter. (issue1828804)
We've decided against this change for now (increases the size of the API too much). A HasElement interface sounds somewhat reasonable but we can add that later if needed. I suppose if Element implemented HasElement, returning itself, we could avoid doubling the number of methods, but this seems overly tricky when calling getElement() yourself isn't hard. http://gwt-code-reviews.appspot.com/1828804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: - Extended the a11y role API with methods that have UIObject parameter. (issue1828804)
I haven't looked at the changes (from the description, they should be simple and straightforward) but what bothers me is that it introduces a cyclic dependency: c.g.g.user depends on c.g.g.aria which now also depends on c.g.g.user. Also, that dependency isn't reflected in the .gwt.xml (so one could say it's not really a cyclic dependency, but then you'll have "source code not found for UIObject" if you don't use c.g.g.user in your app). I think we should rather introduce an HasElement interface (e.g. in c.g.g.dom) that UIObject would implement. http://gwt-code-reviews.appspot.com/1828804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
