[gwt-contrib] Re: Basic MessageIntrpolation. (issue1230801)

2010-12-20 Thread rchandia 


http://gwt-code-reviews.appspot.com/1230801/diff/1/3
File samples/validation/ValidationMesssges-i18n (right):

http://gwt-code-reviews.appspot.com/1230801/diff/1/3#newcode1
samples/validation/ValidationMesssges-i18n:1: #!/bin/sh
I think this file does not need to be committed.

http://gwt-code-reviews.appspot.com/1230801/diff/1/4
File
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml
(right):

http://gwt-code-reviews.appspot.com/1230801/diff/1/4#newcode27
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:27:
!-- Specify the Validator for the Validaiton bootstrap to use. --
Validaiton - Validation

http://gwt-code-reviews.appspot.com/1230801/diff/1/4#newcode33
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:33:
!-- TODO(nchalko) figure out how to make this a attribute of the
GwtValidtion
GwtValidtion - GwtValidation

http://gwt-code-reviews.appspot.com/1230801/diff/1/4#newcode35
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:35:
!--  specify the ValidaitonMessageResolver to use for your custom
validation messages --
ValidaitonMessageResolver - ValidationMessageResolver

http://gwt-code-reviews.appspot.com/1230801/diff/1/14
File
samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/TckTest.gwt.xml
(right):

http://gwt-code-reviews.appspot.com/1230801/diff/1/14#newcode23
samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/TckTest.gwt.xml:23:
exclude name=*GwtSuite.java /
The approach commonly used in trunk/user has been to move Suites up a
folder and thus to completely move them out of the GWT module.

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4047
File
user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
(right):

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4047#newcode118
user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java:118:
} while (!step1message.equals(resolvedMessage));
It would seem that message interpolation may never halt if message
expansion defines a loop (i.e. a message expands itself or they form a
loop). Is there logic elsewhere checking/preventing such a situation?

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4047#newcode120
user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java:120:
// Step2 Replace message parameter using teh default provider messages.
the

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4057
File user/src/com/google/gwt/validation/rebind/ValidatorCreator.java
(right):

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4057#newcode118
user/src/com/google/gwt/validation/rebind/ValidatorCreator.java:118: //
getMessageIntorpolator());
getMessageIntorpolator - getMessageInterpolator

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4069
File
user/test/com/google/gwt/validation/client/BaseMessageInterpolatorTest.java
(right):

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4069#newcode60
user/test/com/google/gwt/validation/client/BaseMessageInterpolatorTest.java:60:
defaultMap.put(integer, Integer.valueOf(1));
This is not used. Missing a test?

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4072
File user/test/com/google/gwt/validation/client/ValidationTest.gwt.xml
(right):

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4072#newcode21
user/test/com/google/gwt/validation/client/ValidationTest.gwt.xml:21:
source path=
Tests in user/ place the suites in the parent folder to avoid includes
and excludes files.

http://gwt-code-reviews.appspot.com/1230801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Basic MessageIntrpolation. (issue1230801)

2010-12-20 Thread nchalko 


http://gwt-code-reviews.appspot.com/1230801/diff/3001/4047
File
user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java
(right):

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4047#newcode118
user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java:118:
} while (!step1message.equals(resolvedMessage));
You are right, this could loop forever.  Adding a TODO.

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4047#newcode120
user/src/com/google/gwt/validation/client/BaseMessageInterpolator.java:120:
// Step2 Replace message parameter using teh default provider messages.
On 2010/12/20 19:10:53, rchandia wrote:

the


Done.

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4057
File user/src/com/google/gwt/validation/rebind/ValidatorCreator.java
(right):

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4057#newcode118
user/src/com/google/gwt/validation/rebind/ValidatorCreator.java:118: //
getMessageIntorpolator());
On 2010/12/20 19:10:53, rchandia wrote:

getMessageIntorpolator - getMessageInterpolator


Done.

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4069
File
user/test/com/google/gwt/validation/client/BaseMessageInterpolatorTest.java
(right):

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4069#newcode60
user/test/com/google/gwt/validation/client/BaseMessageInterpolatorTest.java:60:
defaultMap.put(integer, Integer.valueOf(1));
Added test.

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4072
File user/test/com/google/gwt/validation/client/ValidationTest.gwt.xml
(right):

http://gwt-code-reviews.appspot.com/1230801/diff/3001/4072#newcode21
user/test/com/google/gwt/validation/client/ValidationTest.gwt.xml:21:
source path=
On 2010/12/20 19:10:53, rchandia wrote:

Tests in user/ place the suites in the parent folder to avoid includes

and

excludes files.


Done.

http://gwt-code-reviews.appspot.com/1230801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Basic MessageIntrpolation. (issue1230801)

2010-12-20 Thread nchalko 

http://gwt-code-reviews.appspot.com/1230801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Basic MessageIntrpolation. (issue1230801)

2010-12-20 Thread rchandia 

Patch set 1 contains a number of unreplied comments.

On 2010/12/20 20:41:11, Nick Chalko wrote:




http://gwt-code-reviews.appspot.com/1230801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Basic MessageIntrpolation. (issue1230801)

2010-12-20 Thread Nick Chalko 
I see where I missed those.   Working on them now.

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Basic MessageIntrpolation. (issue1230801)

2010-12-20 Thread nchalko 


http://gwt-code-reviews.appspot.com/1230801/diff/1/3
File samples/validation/ValidationMesssges-i18n (right):

http://gwt-code-reviews.appspot.com/1230801/diff/1/3#newcode1
samples/validation/ValidationMesssges-i18n:1: #!/bin/sh
On 2010/12/20 19:10:53, rchandia wrote:

I think this file does not need to be committed.


Done.

http://gwt-code-reviews.appspot.com/1230801/diff/1/4
File
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml
(right):

http://gwt-code-reviews.appspot.com/1230801/diff/1/4#newcode27
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:27:
!-- Specify the Validator for the Validaiton bootstrap to use. --
On 2010/12/20 19:10:53, rchandia wrote:

Validaiton - Validation


Done.

http://gwt-code-reviews.appspot.com/1230801/diff/1/4#newcode33
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:33:
!-- TODO(nchalko) figure out how to make this a attribute of the
GwtValidtion
On 2010/12/20 19:10:53, rchandia wrote:

GwtValidtion - GwtValidation


Done.

http://gwt-code-reviews.appspot.com/1230801/diff/1/4#newcode35
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:35:
!--  specify the ValidaitonMessageResolver to use for your custom
validation messages --
On 2010/12/20 19:10:53, rchandia wrote:

ValidaitonMessageResolver - ValidationMessageResolver


Done.

http://gwt-code-reviews.appspot.com/1230801/diff/1/14
File
samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/TckTest.gwt.xml
(right):

http://gwt-code-reviews.appspot.com/1230801/diff/1/14#newcode23
samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/TckTest.gwt.xml:23:
exclude name=*GwtSuite.java /
On 2010/12/20 19:10:53, rchandia wrote:

The approach commonly used in trunk/user has been to move Suites up a

folder and

thus to completely move them out of the GWT module.


I have a larger test re-factoring coming,  I will move the suites then.

http://gwt-code-reviews.appspot.com/1230801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Basic MessageIntrpolation. (issue1230801)

2010-12-20 Thread nchalko 

http://gwt-code-reviews.appspot.com/1230801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Basic MessageIntrpolation. (issue1230801)

2010-12-20 Thread rchandia 

LGTM
On 2010/12/20 22:10:00, Nick Chalko wrote:




http://gwt-code-reviews.appspot.com/1230801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Basic MessageIntrpolation. (issue1230801)

2010-12-17 Thread nchalko 

http://gwt-code-reviews.appspot.com/1230801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors