[gwt-contrib] Re: Hello DialogBoxParser

[rjrjr]

Actually, re: building the mocks out of class literals: No. I had it
working with literals originally and then I took them away. The test ran
twice as fast (!), presumably because of all the class init code that
didn't run.

Note also that the mock resources are very low fidelity, not even
matching the exact class hierarchy in some cases. There is no benefit to
over engineering this.

http://gwt-code-reviews.appspot.com/97806

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Hello DialogBoxParser

[rjrjr]

http://gwt-code-reviews.appspot.com/97806/diff/1001/56
File user/src/com/google/gwt/uibinder/rebind/XMLElement.java (right):

http://gwt-code-reviews.appspot.com/97806/diff/1001/56#newcode50
Line 50: @SuppressWarnings("deprecation")
On 2009/11/09 18:33:27, bobv wrote:
> This is a big class.

Done.

http://gwt-code-reviews.appspot.com/97806/diff/1001/62
File
user/test/com/google/gwt/uibinder/elementparsers/UiJavaResources.java
(right):

http://gwt-code-reviews.appspot.com/97806/diff/1001/62#newcode30
Line 30: public static final MockJavaResource DIALOG_BOX = new
MockJavaResource(
Agree in theory, but following existing precedent. Not for this patch.

http://gwt-code-reviews.appspot.com/97806/diff/1001/66
File user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
(right):

http://gwt-code-reviews.appspot.com/97806/diff/1001/66#newcode261
Line 261: The pig's in a hurry
Yes, this is bad markup, exposed by the new stricter behavior in
HtmlInterpreter

http://gwt-code-reviews.appspot.com/97806

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Hello DialogBoxParser

[rjrjr]

Reviewers: bobv,

Message:
Nits addressed, committed tr...@6774, 2.0 soon.

Description:
DialogBox is weird--it implements both HasHTML and HasWidgets. This
confuses the bejeebers out of UiBinder and leads it to generate bad
code, so a custom parser is required. I took this excuse to generalize
the mock UiBinderWriter work I did yesterday for
DockLayoutPanelParserTest.

I also found some low hanging fruit in XMLElement to allow it to fail
when there are stray bits of text or widgets in places they shouldn't
be. Previously this would result in quietly dropped text, or in things
like  showing up the rendered DOM, sometimes even user
visible.

Please review this at http://gwt-code-reviews.appspot.com/97806

Affected files:
   M user/src/com/google/gwt/uibinder/elementparsers/CustomButtonParser.java
   A user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
   M user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java
   M user/src/com/google/gwt/uibinder/rebind/FieldWriterOfExistingType.java
   M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
   M user/src/com/google/gwt/uibinder/rebind/XMLElement.java
   M user/test/com/google/gwt/uibinder/UiBinderJreSuite.java
   A  
user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java
   M  
user/test/com/google/gwt/uibinder/elementparsers/DockLayoutPanelParserTest.java
   A  
user/test/com/google/gwt/uibinder/elementparsers/ElementParserTester.java
   A user/test/com/google/gwt/uibinder/elementparsers/MockUiBinderWriter.java
   A user/test/com/google/gwt/uibinder/elementparsers/UiJavaResources.java
   A user/test/com/google/gwt/uibinder/rebind/MockMortalLogger.java
   M user/test/com/google/gwt/uibinder/rebind/XMLElementTest.java
   M user/test/com/google/gwt/uibinder/test/UiJavaResources.java
   M user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml



--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---