[gwt-contrib] Re: Introduces expenses scaffolding app, ExpensesScaffold, complete with

2010-03-17 Thread rjrjr 

Actually, as we just discussed, we probably need both apps. The new one
is what could be reasonably generated by default, while the old one is
more the shape of what you'd build yourself.

http://gwt-code-reviews.appspot.com/209802

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces expenses scaffolding app, ExpensesScaffold, complete with

2010-03-17 Thread rjrjr 

Will do on the checkstyle front.

Yes, we can get rid of the other app. I left it around so that I could
start from a clean slate, and so that I didn't interfere with your work.
Shall I delete it now?

http://gwt-code-reviews.appspot.com/209802

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces expenses scaffolding app, ExpensesScaffold, complete with

2010-03-17 Thread Amit Manjhi 
Followup question.

- Is Expenses.gwt.xml necessary with the introduction of
ExpensesScaffolding.xml? Can the Expenses.java functionality be moved into
ExpensesScaffolding.java?


On Wed, Mar 17, 2010 at 11:14 AM,  wrote:

> Additional checkstyle problems (Eclipse output). Please run checkstyle
> :)
>
> Description ResourcePathLocationType
> forProperties is not
> alphabetical.   EntityListRequest.java
>  Bikeshed/src/com/google/gwt/requestfactory/shared   line
> 35  Checkstyle Problem
> getDetailsPlaceFor is not
> alphabetical.   Places.java
> Bikeshed/src/com/google/gwt/sample/expenses/client/placeline
> 34  Checkstyle Problem
> Line does not match expected header line of
> '/\*'.  ExpensesScaffold.java
> Bikeshed/src/com/google/gwt/sample/expenses/client  line
> 1   Checkstyle Problem
> Line does not match expected header line of
> '/\*'.  ListRequester.java
>  Bikeshed/src/com/google/gwt/sample/expenses/client  line
> 1   Checkstyle Problem
> Line matches the illegal pattern 'newline before
> }'. ListRequester.java
>  Bikeshed/src/com/google/gwt/sample/expenses/client  line
> 45  Checkstyle Problem
>
>
> http://gwt-code-reviews.appspot.com/209802/diff/1/16
> File
>
>
> bikeshed/src/com/google/gwt/sample/expenses/client/ExpensesScaffoldShell.java
> (right):
>
> http://gwt-code-reviews.appspot.com/209802/diff/1/16#newcode32
> Line 32: interface Binder extends UiBinder ExpensesScaffoldShell> {}
> checkstyle. "{" is not followed by whitespace.
>
> http://gwt-code-reviews.appspot.com/209802/diff/1/24
> File
>
> bikeshed/src/com/google/gwt/sample/expenses/client/place/EntityPlace.java
> (right):
>
> http://gwt-code-reviews.appspot.com/209802/diff/1/24#newcode45
> Line 45: if (this == obj)
> checkstyle: not alphabetical
>
> http://gwt-code-reviews.appspot.com/209802/diff/1/34
> File
>
> bikeshed/src/com/google/gwt/sample/expenses/server/domain/Storage.java
> (right):
>
> http://gwt-code-reviews.appspot.com/209802/diff/1/34#newcode145
> Line 145: synchronized List findAllReports() {
> checkstyle: findAllReports is not alphabetical
>
> http://gwt-code-reviews.appspot.com/209802/diff/1/42
> File bikeshed/src/com/google/gwt/user/client/ui/ValueListBox.java
> (right):
>
> http://gwt-code-reviews.appspot.com/209802/diff/1/42#newcode87
> Line 87: public HandlerRegistration
> addValueChangeHandler(ValueChangeHandler handler) {
> checkstyle: method is not alphabetical.
>
>
> http://gwt-code-reviews.appspot.com/209802
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduces expenses scaffolding app, ExpensesScaffold, complete with

2010-03-17 Thread amitmanjhi 

Additional checkstyle problems (Eclipse output). Please run checkstyle
:)

Description ResourcePathLocationType
forProperties is not
alphabetical.	EntityListRequest.java	 
Bikeshed/src/com/google/gwt/requestfactory/shared	line

35  Checkstyle Problem
getDetailsPlaceFor is not
alphabetical.	Places.java	 
Bikeshed/src/com/google/gwt/sample/expenses/client/place	line

34  Checkstyle Problem
Line does not match expected header line of
'/\*'.	ExpensesScaffold.java	 
Bikeshed/src/com/google/gwt/sample/expenses/client	line

1   Checkstyle Problem
Line does not match expected header line of
'/\*'.	ListRequester.java	 
Bikeshed/src/com/google/gwt/sample/expenses/client	line

1   Checkstyle Problem
Line matches the illegal pattern 'newline before
}'.	ListRequester.java	Bikeshed/src/com/google/gwt/sample/expenses/client	 
line

45  Checkstyle Problem


http://gwt-code-reviews.appspot.com/209802/diff/1/16
File
bikeshed/src/com/google/gwt/sample/expenses/client/ExpensesScaffoldShell.java
(right):

http://gwt-code-reviews.appspot.com/209802/diff/1/16#newcode32
Line 32: interface Binder extends UiBinder {}
checkstyle. "{" is not followed by whitespace.

http://gwt-code-reviews.appspot.com/209802/diff/1/24
File
bikeshed/src/com/google/gwt/sample/expenses/client/place/EntityPlace.java
(right):

http://gwt-code-reviews.appspot.com/209802/diff/1/24#newcode45
Line 45: if (this == obj)
checkstyle: not alphabetical

http://gwt-code-reviews.appspot.com/209802/diff/1/34
File
bikeshed/src/com/google/gwt/sample/expenses/server/domain/Storage.java
(right):

http://gwt-code-reviews.appspot.com/209802/diff/1/34#newcode145
Line 145: synchronized List findAllReports() {
checkstyle: findAllReports is not alphabetical

http://gwt-code-reviews.appspot.com/209802/diff/1/42
File bikeshed/src/com/google/gwt/user/client/ui/ValueListBox.java
(right):

http://gwt-code-reviews.appspot.com/209802/diff/1/42#newcode87
Line 87: public HandlerRegistration
addValueChangeHandler(ValueChangeHandler handler) {
checkstyle: method is not alphabetical.

http://gwt-code-reviews.appspot.com/209802

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors