[gwt-contrib] Re: Make form event getTypes public. (issue1582803)

[rdayal]

Submitted.

http://gwt-code-reviews.appspot.com/1582803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make form event getTypes public. (issue1582803)

[rdayal]

http://gwt-code-reviews.appspot.com/1582803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java
File user/src/com/google/gwt/user/client/ui/FormPanel.java (right):

http://gwt-code-reviews.appspot.com/1582803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java#newcode138
user/src/com/google/gwt/user/client/ui/FormPanel.java:138: private
static TypeSubmitHandler TYPE = new TypeSubmitHandler();
On 2011/10/27 08:29:36, tbroyer wrote:

Isn't this initialization defeating the lazy-init done in getType() ?
Seems like the right time to fix this.

Agreed - Stephen?

http://gwt-code-reviews.appspot.com/1582803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make form event getTypes public. (issue1582803)

[t . broyer]

LGTM

(as a side note, I always wondered why these events are not in
com.google.gwt.event.dom; I believe we could add them there and have the
existing ones extend the new ones)

Oh, and BTW, rjrjr is no longer a Googler; I wonder who to assign this
CL to; jgw? jlabanca? fredsa?


http://gwt-code-reviews.appspot.com/1582803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java
File user/src/com/google/gwt/user/client/ui/FormPanel.java (right):

http://gwt-code-reviews.appspot.com/1582803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java#newcode138
user/src/com/google/gwt/user/client/ui/FormPanel.java:138: private
static TypeSubmitHandler TYPE = new TypeSubmitHandler();
Isn't this initialization defeating the lazy-init done in getType() ?
Seems like the right time to fix this.

http://gwt-code-reviews.appspot.com/1582803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Make form event getTypes public. (issue1582803)

[Stephen Haberman]

 Sadly, Ray has left!

:-(

 You can definitely still assign reviews to whomever you think is most
 appropriate, but add me to the review if you're not getting a
 response, and I'll make sure it gets some attention.

That's great, thanks, Rajeev.

I have a few that have been pending; might send an email about them to
see if they can get to the right people. Some of them are pretty
trivial, so are perhaps more annoying than they are worth. But I think
would be nice to see go in. I'll do that soon.

- Stephen

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make form event getTypes public. (issue1582803)

[stephen . haberman]

http://gwt-code-reviews.appspot.com/1582803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java
File user/src/com/google/gwt/user/client/ui/FormPanel.java (left):

http://gwt-code-reviews.appspot.com/1582803/diff/1/user/src/com/google/gwt/user/client/ui/FormPanel.java#oldcode98
user/src/com/google/gwt/user/client/ui/FormPanel.java:98: return TYPE;
This was returning null if I instantiated an event and called
getAssociatedType before getType was called. I'm not sure if this was a
purposeful optimization, but it seems safer to use getType.

http://gwt-code-reviews.appspot.com/1582803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors