[gwt-contrib] Re: Public: GWT emulation for the normal Validation Bootstrap. (issue1208801)
http://gwt-code-reviews.appspot.com/1208801/diff/3001/4002 File samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4002#newcode34 samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java:34: * Validator marker for the Valiation Sample project. Only the classes listed On 2010/12/14 20:52:46, rchandia wrote: Validation Done. http://gwt-code-reviews.appspot.com/1208801/diff/3001/4005 File samples/validationtck/src/org/hibernate/jsr303/tck/super/org/hibernate/jsr303/tck/common/TCKValidationProvider.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4005#newcode35 samples/validationtck/src/org/hibernate/jsr303/tck/super/org/hibernate/jsr303/tck/common/TCKValidationProvider.java:35: * Meved cast call. On 2010/12/14 20:52:46, rchandia wrote: Moved Done. http://gwt-code-reviews.appspot.com/1208801/diff/3001/4019 File user/src/com/google/gwt/validation/client/GwtValidationProviderResolver.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4019#newcode34 user/src/com/google/gwt/validation/client/GwtValidationProviderResolver.java:34: private final List> defaultList; On 2010/12/14 20:52:46, rchandia wrote: Would it be better to make this static? Done. http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022 File user/src/com/google/gwt/validation/client/Validation.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022#newcode197 user/src/com/google/gwt/validation/client/Validation.java:197: * defined, use the default ValidationProviderResolver On 2010/12/14 20:52:46, rchandia wrote: Is the Javadoc in this class still accurate? Yes in that I will allow this. Unsure if it is fully implemented. http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022#newcode212 user/src/com/google/gwt/validation/client/Validation.java:212: * default Bean Validation provider and following the XML configuration. On 2010/12/14 20:52:46, rchandia wrote: GWT does not use XML config, right? Done. http://gwt-code-reviews.appspot.com/1208801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Public: GWT emulation for the normal Validation Bootstrap. (issue1208801)
LGTM. With JavaDoc nits. http://gwt-code-reviews.appspot.com/1208801/diff/3001/4002 File samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4002#newcode34 samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java:34: * Validator marker for the Valiation Sample project. Only the classes listed Validation http://gwt-code-reviews.appspot.com/1208801/diff/3001/4005 File samples/validationtck/src/org/hibernate/jsr303/tck/super/org/hibernate/jsr303/tck/common/TCKValidationProvider.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4005#newcode35 samples/validationtck/src/org/hibernate/jsr303/tck/super/org/hibernate/jsr303/tck/common/TCKValidationProvider.java:35: * Meved cast call. Moved http://gwt-code-reviews.appspot.com/1208801/diff/3001/4019 File user/src/com/google/gwt/validation/client/GwtValidationProviderResolver.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4019#newcode34 user/src/com/google/gwt/validation/client/GwtValidationProviderResolver.java:34: private final List> defaultList; Would it be better to make this static? http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022 File user/src/com/google/gwt/validation/client/Validation.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022#newcode197 user/src/com/google/gwt/validation/client/Validation.java:197: * defined, use the default ValidationProviderResolver Is the Javadoc in this class still accurate? http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022#newcode212 user/src/com/google/gwt/validation/client/Validation.java:212: * default Bean Validation provider and following the XML configuration. GWT does not use XML config, right? http://gwt-code-reviews.appspot.com/1208801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Public: GWT emulation for the normal Validation Bootstrap. (issue1208801)
http://gwt-code-reviews.appspot.com/1208801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
