[gwt-contrib] Re: Restore UiBinder's JRE tests

2009-10-06 Thread rjrjr

Submitted with appropriate build.xml entries after offline chat
w/Freeland.

Committed r6305


http://gwt-code-reviews.appspot.com/72805

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Restore UiBinder's JRE tests

2009-10-01 Thread fabbott

LGTM.  I'm a bit hesitant about die == UnableToCompleteException in
TreeLogger in general, but have no issues with it here.

(As an example, I'm not sure that's the right exception to throw for an
issue early in starting hosted mode shell,  although it's maybe not
clearly the wrong exception either.)

http://gwt-code-reviews.appspot.com/72805

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Restore UiBinder's JRE tests

2009-10-01 Thread Freeland Abbott
Ah, sorry.  Depending on exactly when you need it, you want the classpath
element of the compile.tests task around line 75, the defined
path test.extraclasspaths around line 35; you might also consider compile
task, circa line 45, though I think you shouldn't need that.  Generally,
searching for classpath in the build.xml should get you to suspicious
areas to think about, but I think those are the key two.

On Thu, Oct 1, 2009 at 5:10 PM, Ray Ryan rj...@google.com wrote:

 Thanks.

 I still need an answer to my actual question, though:

 See the classpath changes to eclipse/user/.classpath? Where do I make
 the same changes to user/build.xml?

 On Thu, Oct 1, 2009 at 12:41 PM,  fabb...@google.com wrote:
  LGTM.  I'm a bit hesitant about die == UnableToCompleteException in
  TreeLogger in general, but have no issues with it here.
 
  (As an example, I'm not sure that's the right exception to throw for an
  issue early in starting hosted mode shell,  although it's maybe not
  clearly the wrong exception either.)
 
  http://gwt-code-reviews.appspot.com/72805
 


--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---



[gwt-contrib] Re: Restore UiBinder's JRE tests

2009-09-30 Thread rjrjr

ping

http://gwt-code-reviews.appspot.com/72805

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---