[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode
My 2 c€nts.
Overall, it leads to reworking the patch as an:
if (method is GET (or HEAD)) {
if (url contains .nocache.) {
set no-cache headers
} else if (url contains .cache.) {
set forever-cache headers
}
}
// otherwise (non-GET/HEAD, or non-nocache/cache URL), just do nothing
regarding caching (or at least fallback to default)
An application developer can use the following in its web.xml to change
the default behavior for static files (and cache them for 60 seconds):
context-param
param-nameorg.mortbay.jetty.servlet.Default.cacheControl/param-name
param-valuemax-age=60,public/param-value
/context-param
http://gwt-code-reviews.appspot.com/56807/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java
(right):
http://gwt-code-reviews.appspot.com/56807/diff/1/2#newcode450
Line 450: // to be safe, mark all non-GETs as non-cacheable
Er, responses to non-GET/HEAD requests *are* non-cacheable by default
(as a consequence of the write-through mandatory constraint from HTTP
http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.11 ), so
this is useless IMO.
http://gwt-code-reviews.appspot.com/56807/diff/1/2#newcode471
Line 471: // everything else gets public caching for 60 seconds
Why? why not (again) rely on the default caching behavior?
http://gwt-code-reviews.appspot.com/56807
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode
If Bob and Kelly haven't objected to this by, say, lunch time tomorrow, can we get it submitted? This issue continues to bite people, and it would be nice to see it fixed before MS1 freezes RSN. http://gwt-code-reviews.appspot.com/56807 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode
[+Miguel] On that note: what about adding some nice defaults to appengine-web.xml as discussed here: http://code.google.com/p/google-web-toolkit/issues/detail?id=3592 This would be for project with both App Engine and GWT support. Fred On Mon, Sep 21, 2009 at 3:20 PM, rj...@google.com wrote: If Bob and Kelly haven't objected to this by, say, lunch time tomorrow, can we get it submitted? This issue continues to bite people, and it would be nice to see it fixed before MS1 freezes RSN. http://gwt-code-reviews.appspot.com/56807 -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode
Can we move that conversation to another patch? On Mon, Sep 21, 2009 at 5:25 PM, Fred Sauer fre...@gmail.com wrote: [+Miguel] On that note: what about adding some nice defaults to appengine-web.xml as discussed here: http://code.google.com/p/google-web-toolkit/issues/detail?id=3592 This would be for project with both App Engine and GWT support. Fred On Mon, Sep 21, 2009 at 3:20 PM, rj...@google.com wrote: If Bob and Kelly haven't objected to this by, say, lunch time tomorrow, can we get it submitted? This issue continues to bite people, and it would be nice to see it fixed before MS1 freezes RSN. http://gwt-code-reviews.appspot.com/56807 -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode
Absolutely. Separate subject. Separate issue (in fact it's issue 3592). I just wanted to call it out here since there seem to be 'interested parties' on this thread. On Mon, Sep 21, 2009 at 5:30 PM, Ray Ryan rj...@google.com wrote: Can we move that conversation to another patch? On Mon, Sep 21, 2009 at 5:25 PM, Fred Sauer fre...@gmail.com wrote: [+Miguel] On that note: what about adding some nice defaults to appengine-web.xml as discussed here: http://code.google.com/p/google-web-toolkit/issues/detail?id=3592 This would be for project with both App Engine and GWT support. Fred On Mon, Sep 21, 2009 at 3:20 PM, rj...@google.com wrote: If Bob and Kelly haven't objected to this by, say, lunch time tomorrow, can we get it submitted? This issue continues to bite people, and it would be nice to see it fixed before MS1 freezes RSN. http://gwt-code-reviews.appspot.com/56807 -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode
http://gwt-code-reviews.appspot.com/56807/diff/1/2 File dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java (right): http://gwt-code-reviews.appspot.com/56807/diff/1/2#newcode450 Line 450: // to be safe, mark all non-GETs as non-cacheable On 2009/09/21 22:24:17, bobv wrote: What about HEAD? I don't think it would hurt to cache it, but it is very small anyway. http://gwt-code-reviews.appspot.com/56807 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode
Does this address issue 3682? http://code.google.com/p/google-web-toolkit/issues/detail?id=3682 http://gwt-code-reviews.appspot.com/56807 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode
I think so, I reassigned that bug to jat for that reason. On Tue, Aug 11, 2009 at 4:27 PM, fre...@gmail.com wrote: Does this address issue 3682? http://code.google.com/p/google-web-toolkit/issues/detail?id=3682 http://gwt-code-reviews.appspot.com/56807 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode
Adding potential second eyeball reviewers. http://gwt-code-reviews.appspot.com/56807 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode
LGTM, but we should probably get a thumbs-up from at least one other interested person. http://gwt-code-reviews.appspot.com/56807 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode
On Fri, Aug 7, 2009 at 4:46 PM, sco...@google.com wrote: LGTM, but we should probably get a thumbs-up from at least one other interested person. http://gwt-code-reviews.appspot.com/56807 Suggestion of that person? -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Set cache headers properly in embedded Jetty for hosted mode
Bob? Kelly? On Fri, Aug 7, 2009 at 4:56 PM, John Tamplin j...@google.com wrote: On Fri, Aug 7, 2009 at 4:46 PM, sco...@google.com wrote: LGTM, but we should probably get a thumbs-up from at least one other interested person. http://gwt-code-reviews.appspot.com/56807 Suggestion of that person? -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
