[gwt-contrib] Re: Working CodeSplitter2. (issue1631803)

2012-02-02 Thread acleung 

http://gwt-code-reviews.appspot.com/1631803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Working CodeSplitter2. (issue1631803)

2012-02-01 Thread cromwellian 


http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java
File dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java (right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java#newcode449
dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java:449: protected
boolean replaces(JMethod originalMethod) {
?

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java (right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java#newcode50
dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java:50: public static
int[] splitPointToFragmentMap = null;
I don't think this needs to be static does it? JProgram is usually
passed around as an instance.

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JType.java
File dev/core/src/com/google/gwt/dev/jjs/ast/JType.java (right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/ast/JType.java#newcode86
dev/core/src/com/google/gwt/dev/jjs/ast/JType.java:86: protected boolean
replaces(JType originalType) {
Why changed to protected?

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java#newcode83
dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java:83:
whitespace, revert?

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java
(right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java#newcode87
dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:87:
import com.google.gwt.dev.jjs.ast.JNumericEntry;
Where is JNumericEntity/JsNumberEntity? Forgot to add to patch?

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/MakeCallsStatic.java
File dev/core/src/com/google/gwt/dev/jjs/impl/MakeCallsStatic.java
(right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/MakeCallsStatic.java#newcode219
dev/core/src/com/google/gwt/dev/jjs/impl/MakeCallsStatic.java:219:
whitespace

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
File dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java
(right):

http://gwt-code-reviews.appspot.com/1631803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java#newcode192
dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java:192:
//newCall.addArg(program.getLiteralInt(splitPoint));
remove commented out code or does this need to special case if the old
codesplitter is still one??

http://gwt-code-reviews.appspot.com/1631803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Working CodeSplitter2. (issue1631803)

2012-01-30 Thread Alan Leung 
Hey Ray, how do you feel about the CL at a higher level?

I'd like to check this in sometimes this week so internal teams can
experiment with it.

This should not break anyone who doesn't have -XfragmentMerge anyways.

-Alan

On Wed, Jan 25, 2012 at 4:00 PM, acle...@google.com wrote:

 Reviewers: cromwellian,

 Description:
 Working CodeSplitter2.
 -With this the people should be able to test the new CodeSplitter.
 -It is protected by a -XfragmentMerge flag, it will not break anyone.
 -While it is working in lots of internal projects, there are still room
 for improvement. There are enough todo's in places where work is needed.


 Please review this at 
 http://gwt-code-reviews.**appspot.com/1631803/http://gwt-code-reviews.appspot.com/1631803/

 Affected files:
  M dev/core/src/com/google/gwt/**dev/Link.java
  M dev/core/src/com/google/gwt/**dev/**PrecompileTaskArgProcessor.**java
  M dev/core/src/com/google/gwt/**dev/PrecompileTaskOptionsImpl.**java
  M dev/core/src/com/google/gwt/**dev/jjs/JJSOptions.java
  M dev/core/src/com/google/gwt/**dev/jjs/JJSOptionsImpl.java
  M dev/core/src/com/google/gwt/**dev/jjs/**JavaToJavaScriptCompiler.java
  M dev/core/src/com/google/gwt/**dev/jjs/ast/JMethod.java
  M dev/core/src/com/google/gwt/**dev/jjs/ast/JProgram.java
  M dev/core/src/com/google/gwt/**dev/jjs/ast/JType.java
  M dev/core/src/com/google/gwt/**dev/jjs/ast/JVisitor.java
  M dev/core/src/com/google/gwt/**dev/jjs/impl/**
 CloneExpressionVisitor.java
  M dev/core/src/com/google/gwt/**dev/jjs/impl/CodeSplitter2.**java
  M dev/core/src/com/google/gwt/**dev/jjs/impl/**ControlFlowAnalyzer.java
  M dev/core/src/com/google/gwt/**dev/jjs/impl/**GenerateJavaScriptAST.java
  M dev/core/src/com/google/gwt/**dev/jjs/impl/MakeCallsStatic.**java
  M dev/core/src/com/google/gwt/**dev/jjs/impl/ReplaceRunAsyncs.**java
  M dev/core/src/com/google/gwt/**dev/js/JsHoister.java
  M dev/core/src/com/google/gwt/**dev/js/**JsToStringGenerationVisitor.**
 java
  M dev/core/src/com/google/gwt/**dev/js/ast/JsVisitor.java
  A dev/core/src/com/google/gwt/**dev/util/arg/**
 ArgHandlerFragmentMerge.java
  A dev/core/src/com/google/gwt/**dev/util/arg/**OptionFragmentsMerge.java




-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors