Re: [PATCH 3/3] keccak: Disable acceleration with SSE asm
On Fri, May 17, 2024 at 02:24:50PM +0300, Vladimir 'phcoder' Serbinenko wrote: > Le ven. 17 mai 2024, 14:15, Daniel Kiper a écrit : > Why is this patch needed? Should not we disable SSE using compiler > flags? > We do but the code in question uses SSE on every x64 platform. So we need to > disable this acceleration. At least for now. If we want to enable SSE (maybe > we > should) we can revisit this but this is a separate discussion and separate > patchset Please explain the problem with SSE in the commit message. Otherwise we will shortly forget why it has been disabled. Additionally, I think all libgcrypt patches like this one should land in the grub-core/lib/libgcrypt-patches and be applied during bootstrap or so. This will make us in line with gnulib and gettext patching mechanism. Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 3/3] keccak: Disable acceleration with SSE asm
Le ven. 17 mai 2024, 14:15, Daniel Kiper a écrit :
> Why is this patch needed? Should not we disable SSE using compiler flags?
>
We do but the code in question uses SSE on every x64 platform. So we need
to disable this acceleration. At least for now. If we want to enable SSE
(maybe we should) we can revisit this but this is a separate discussion and
separate patchset
>
> Daniel
>
> On Thu, May 16, 2024 at 09:27:43PM +0300, Vladimir Serbinenko wrote:
> > ---
> > grub-core/lib/libgcrypt/cipher/keccak.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/grub-core/lib/libgcrypt/cipher/keccak.c
> b/grub-core/lib/libgcrypt/cipher/keccak.c
> > index 11e64b3e7..8b570263b 100644
> > --- a/grub-core/lib/libgcrypt/cipher/keccak.c
> > +++ b/grub-core/lib/libgcrypt/cipher/keccak.c
> > @@ -251,7 +251,7 @@ keccak_absorb_lane32bi(u32 *lane, u32 x0, u32 x1)
> > /* Construct generic 64-bit implementation. */
> > #ifdef USE_64BIT
> >
> > -#if __GNUC__ >= 4 && defined(__x86_64__)
> > +#if __GNUC__ >= 4 && defined(__x86_64__) && 0
> >
> > static inline void absorb_lanes64_8(u64 *dst, const byte *in)
> > {
>
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH 3/3] keccak: Disable acceleration with SSE asm
Why is this patch needed? Should not we disable SSE using compiler flags?
Daniel
On Thu, May 16, 2024 at 09:27:43PM +0300, Vladimir Serbinenko wrote:
> ---
> grub-core/lib/libgcrypt/cipher/keccak.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/lib/libgcrypt/cipher/keccak.c
> b/grub-core/lib/libgcrypt/cipher/keccak.c
> index 11e64b3e7..8b570263b 100644
> --- a/grub-core/lib/libgcrypt/cipher/keccak.c
> +++ b/grub-core/lib/libgcrypt/cipher/keccak.c
> @@ -251,7 +251,7 @@ keccak_absorb_lane32bi(u32 *lane, u32 x0, u32 x1)
> /* Construct generic 64-bit implementation. */
> #ifdef USE_64BIT
>
> -#if __GNUC__ >= 4 && defined(__x86_64__)
> +#if __GNUC__ >= 4 && defined(__x86_64__) && 0
>
> static inline void absorb_lanes64_8(u64 *dst, const byte *in)
> {
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
