Re: [PATCH] gnu: Add ldc-1.1.0-beta4
> Hmm, you added gdb to the native-inputs but commented out the gdb invocations > later? Why? I've gone and looked at this, and noted that not all the gdb invocations have been commented out, just the one requiring dmd-testsuite/runnable/gdb15729 which fails with "Error: No such file or directory" The only other part in the dmd-testsuite that's deactivated is the call "enforce(match(..." in dmd-testsuite/d_do_test.d which was also failing. All other invocations to gdb and calls to "enforce()" seem to be working fine. The annoying thing about these tests is, if you go and build them in the directory retained with 'guix build --keep-failed' these tests pass with no problem, but fail when you use 'guix build ...' -- Frederick M. Muriithi
Re: [PATCH] gnu: Add ldc-1.1.0-beta4
On Wed, 4 Jan 2017 18:53:47 +0300 Frederick Muriithi wrote: > I tried that, but since dmd2/root/port.c file no longer exists, the > 'patch-dmd2 step causes the build to fail. That's the reason I decided > to just add the same things again, but without the 'patch-dmd2 step Ah, okay. I have no complaints about doing it like that then. Please add a comment to the source code stating that.
Re: [PATCH] gnu: Add ldc-1.1.0-beta4
> Hmm, my understanding of how the package definitions work might be > incomplete: It seemed to me like after you inherited, from a package, > and then added a definition in any of the variables, the new variables > would NOT add to the values of the older ones but rather, they would > completely overwrite the older one. Yes. I mean you can leave the whole "(arguments ...)" form off.
Re: [PATCH] gnu: Add ldc-1.1.0-beta4
On Wed, Jan 4, 2017 at 6:46 PM, Danny Milosavljevic wrote: >> Hmm, my understanding of how the package definitions work might be >> incomplete: It seemed to me like after you inherited, from a package, >> and then added a definition in any of the variables, the new variables >> would NOT add to the values of the older ones but rather, they would >> completely overwrite the older one. > > Yes. I mean you can leave the whole "(arguments ...)" form off. I tried that, but since dmd2/root/port.c file no longer exists, the 'patch-dmd2 step causes the build to fail. That's the reason I decided to just add the same things again, but without the 'patch-dmd2 step -- Frederick M. Muriithi
Re: [PATCH] gnu: Add ldc-1.1.0-beta4
On Wed, Jan 4, 2017 at 5:52 PM, Danny Milosavljevic wrote: > Hi, > > On Wed, 4 Jan 2017 17:01:14 +0300 > Frederick Muriithi wrote: > >> Added ldc-1.1.0-beta4 since all other beta versions from there seem to >> reuse the same phobos, druntime and dmd-testsuite. > > Thanks for the patch! > > Hmm, you added gdb to the native-inputs but commented out the gdb invocations > later? Why? > I worked through the definition at the beginning adding required packages, then when builds were successful, but tests were failing, I went through the tests trying to figure out where the issues were, and fixing them. For the gdb invocations, the error message kept pointing to the Makefile as where the issue was, so I tried to go as close to the error as I could with my current knowledge. I think that's only one of a number of invocations, but I might be wrong. > Also, could you ask upsteam whether they add a version flag (or something) > for the http tests? So it can be enabled/disabled without huge patches in the > future... > Cool. I will. > Also, why did you comment out unzip? You can add "unzip" to native-inputs. > Hmmm, it never occurred to me that the issue causing the zip tests to fail was that unzip was missing. The error messages in the failing tests did not point to that. I will fix this > Also, why do you add another "patch-phobos" phase? I think the one in ldc, > from which you inherit, does the same, no? > Hmm, my understanding of how the package definitions work might be incomplete: It seemed to me like after you inherited, from a package, and then added a definition in any of the variables, the new variables would NOT add to the values of the older ones but rather, they would completely overwrite the older one. I will give it one more whirl. > I think I had the same problem with tzNames before. I think one of the > functions there doesn't interpret its argument as a relative path if it > contains a slash anywhere, ruining your /gnu/store prefix or something. > Please look into it. Cool. Let me work on those items, and maybe submit a better patch later -- Frederick M. Muriithi
Re: [PATCH] gnu: Add ldc-1.1.0-beta4
Hi, On Wed, 4 Jan 2017 17:01:14 +0300 Frederick Muriithi wrote: > Added ldc-1.1.0-beta4 since all other beta versions from there seem to > reuse the same phobos, druntime and dmd-testsuite. Thanks for the patch! Hmm, you added gdb to the native-inputs but commented out the gdb invocations later? Why? Also, could you ask upsteam whether they add a version flag (or something) for the http tests? So it can be enabled/disabled without huge patches in the future... Also, why did you comment out unzip? You can add "unzip" to native-inputs. Also, why do you add another "patch-phobos" phase? I think the one in ldc, from which you inherit, does the same, no? I think I had the same problem with tzNames before. I think one of the functions there doesn't interpret its argument as a relative path if it contains a slash anywhere, ruining your /gnu/store prefix or something. Please look into it.
Re: [PATCH] gnu: Add ldc-1.1.0-beta4
Great work Fred! On Wed, Jan 04, 2017 at 05:01:14PM +0300, Frederick Muriithi wrote: > Added ldc-1.1.0-beta4 since all other beta versions from there seem to > reuse the same phobos, druntime and dmd-testsuite. Yes, they do. I have been using your package (w.o. test patches, i.e., test? f) to build beta6 and it works a charm. The new ldc D compiler is great and I am using it every day. Note to others, we still need ldc 0.17.2 in Guix because the ldc 1.1.x compilers are written in D and we need to bootstrap from the last C version. Pj.