Re: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs
Hi Alexander, On Tue, Oct 17, 2023 at 05:38:45PM +, Stephan, Alexander wrote: > Hi Willy, > > Do you know whether this can/will make it to the next release? It would be > crucial for us to know. I sincerely want it to, but the last annoyance around H2 etc derailed our activities a bit and I'm still trying to catch up on plenty of things that others depend on :-/ I'm still having your series in my todo-list and do intend to review it. I also know that if tiny adaptations were needed you don't mind so we'd save a round trip anyway. I'll keep you updated, just trying to do my best :-( Willy
RE: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs
Hi Willy, Do you know whether this can/will make it to the next release? It would be crucial for us to know. Best, Alexander -Original Message- From: Willy Tarreau Sent: Thursday, October 5, 2023 2:42 PM To: Stephan, Alexander Cc: haproxy@formilux.org Subject: Re: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs Hi Alexander, On Thu, Oct 05, 2023 at 11:13:16AM +, Stephan, Alexander wrote: > Hi Willy, > > Ah, what a pity. Anyway, I sent them again with you in CC. Does it look > alright now? Yep, received both ways this time, thank you! Willy
Re: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs
Hi Alexander, On Thu, Oct 05, 2023 at 11:13:16AM +, Stephan, Alexander wrote: > Hi Willy, > > Ah, what a pity. Anyway, I sent them again with you in CC. Does it look > alright now? Yep, received both ways this time, thank you! Willy
RE: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs
Hi Willy, Ah, what a pity. Anyway, I sent them again with you in CC. Does it look alright now? Best, Alexander -Original Message- From: Willy Tarreau Sent: Wednesday, October 4, 2023 3:21 PM To: Stephan, Alexander Cc: haproxy@formilux.org Subject: Re: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs Hi Alexander, On Wed, Oct 04, 2023 at 12:56:07PM +, Stephan, Alexander wrote: > Can you find them if you search for the text that is shown in the archive? Not at all, not even in the spam logs :-( Please note that we've had a short outage from an haproxy core filling the whole FS ~10 days ago, I don't know if that could have matched, but in any case at least you should have received a delivery error. > If not, I can of course send them again. Yes please do and CC me so that I know when they're sent and can compare if I continue not to see them on the ML. Thank you! Willy
Re: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs
Hi Alexander, On Wed, Oct 04, 2023 at 12:56:07PM +, Stephan, Alexander wrote: > Can you find them if you search for the text that is shown in the archive? Not at all, not even in the spam logs :-( Please note that we've had a short outage from an haproxy core filling the whole FS ~10 days ago, I don't know if that could have matched, but in any case at least you should have received a delivery error. > If not, I can of course send them again. Yes please do and CC me so that I know when they're sent and can compare if I continue not to see them on the ML. Thank you! Willy
RE: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs
Hi Willy, Maybe it is because I replied to cover letter and not to the individual patches? This time, I sent them as separate mails, with no attachment. The patches should be responses to the cover letter I replied to in the previous mail. Here are the links to the patches again: [PATCH 1/4] MEDIUM: server: Parse generic type-value pairs as proxy-v2-options: https://www.mail-archive.com/haproxy@formilux.org/msg44023.html [PATCH 2/4] MEDIUM: connection: Send out generically allocated proxy-v2-options: https://www.mail-archive.com/haproxy@formilux.org/msg44024.html [PATCH 3/4] LOW: connection: Add TLV update function: https://www.mail-archive.com/haproxy@formilux.org/msg44025.html [PATCH 4/4] MEDIUM: tcp-act: Add new set-tlv TCP action for PPv2 TLVs: https://www.mail-archive.com/haproxy@formilux.org/msg44026.html Can you find them if you search for the text that is shown in the archive? If not, I can of course send them again. Best, Alexander -Original Message- From: Willy Tarreau Sent: Tuesday, October 3, 2023 11:27 AM To: Stephan, Alexander Cc: haproxy@formilux.org Subject: Re: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs Hi Alexander, On Mon, Oct 02, 2023 at 10:22:17AM +, Stephan, Alexander wrote: > Hi, > > I am back from my vacation and I wanted to ask whether somebody has had the > chance to look at this. > A short ACK that the changes will be reviewed would be much appreciated. I'm sorry but I can't find any trace of the original. Could you please resend it ? thank you! Willy
Re: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs
Hi Alexander, On Mon, Oct 02, 2023 at 10:22:17AM +, Stephan, Alexander wrote: > Hi, > > I am back from my vacation and I wanted to ask whether somebody has had the > chance to look at this. > A short ACK that the changes will be reviewed would be much appreciated. I'm sorry but I can't find any trace of the original. Could you please resend it ? thank you! Willy
RE: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs
Hi, I am back from my vacation and I wanted to ask whether somebody has had the chance to look at this. A short ACK that the changes will be reviewed would be much appreciated. Best, Alexander SAP SE Germany From: Stephan, Alexander Sent: Friday, September 15, 2023 6:39 PM To: haproxy@formilux.org Cc: Menges, Christian Norbert Subject: [PATCH 0/4] Support server-side sending and forwarding of arbitrary PPv2 TLVs Hi all, As a follow-up to my last patches that allow to fetch any TLV in the frontend, I have also implemented similar functionality in the backend that allows to send out TLVs of any type. This is an addition to the existing proxy-protocol-v2-option constants like crc32c. Unlike the pre-defined TLVs, generic TLVs, indicated by their type number, have a common behavior. I think the test I've added as well as the documentation should explain best how it works in more detail. To update TLVs in-place in a connection, before forwarding, I have also added a corresponding TCP action. PPv2 is not quite TCP level, but it seems like the best fit. I am very interested in what you think about the changes. Essentially, these are two commits split into four, for easier review (split by component). I will be on vacation the next two weeks, but my colleague Christian Menges will jump in during that time and address your feedback. Thanks and Best, Alexander SAP SE Germany --- Alexander Stephan (4): MEDIUM: server: Parse generic type-value pairs as proxy-v2-options MEDIUM: connection: Send out generically allocated proxy-v2-options LOW: connection: Add TLV update function MEDIUM: tcp-act: Add new set-tlv TCP action for PPv2 TLVs doc/configuration.txt | 43 +++ include/haproxy/connection.h | 73 +++ include/haproxy/server-t.h| 10 ++ .../proxy_protocol_send_generic.vtc | 66 ++ src/connection.c | 51 +++- src/server.c | 76 ++- src/tcp_act.c | 120 -- 7 files changed, 417 insertions(+), 22 deletions(-) create mode 100644 reg-tests/connection/proxy_protocol_send_generic.vtc -- 2.35.3
