date:20111006


 [ 
https://issues.apache.org/jira/browse/HDFS-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aaron T. Myers updated HDFS-2408:
-

Status: Patch Available  (was: Open)

The patch looks good to me. Marking as patch available on Stack's behalf so 
Jenkins gives it a spin.

+1 pending clean Jenkins results.

 DFSClient#getNumCurrentReplicas is package private in 205 but public in 
 branch-0.20-append
 --

 Key: HDFS-2408
 URL: https://issues.apache.org/jira/browse/HDFS-2408
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: hdfs client
Affects Versions: 0.20.205.1
Reporter: stack
Assignee: stack
 Attachments: hdfs-2408.txt


 The below commit broke hdfs-826 for hbase in 205 rc1.  It changes the 
 accessiblity from public to package private on getNumCurrentReplicas and now 
 current shipping hbase's at least cannot get at this method.
 {code}
 Revision 1174483 - (view) (download) (annotate) - [select for diffs] 
 Modified Fri Sep 23 01:30:18 2011 UTC (13 days, 4 hours ago) by szetszwo 
 File length: 136876 byte(s) 
 Diff to previous 1174479 (colored)
 svn merge -c 1171137 from branch-0.20-security for HDFS-2333.
 {code}
 Here is diff between above change and one just previous:
 http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-205/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java?view=diffr1=1174479r2=1174483diff_format=u
 This is a critical facility for us.
 It seems like making this one method public again is all thats needed.  I can 
 make a patch like the below:
 diff --git a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java 
 b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 index b9cb053..39955c9 100644
 --- a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 +++ b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 @@ -3569,7 +3569,7 @@ public class DFSClient implements FSConstants, 
 java.io.Closeable {
   * block is not yet allocated, then this API will return 0 because there 
 are
   * no replicas in the pipeline.
   */
 -int getNumCurrentReplicas() throws IOException {
 +public int getNumCurrentReplicas() throws IOException {
synchronized(dataQueue) {
  if (nodes == null) {
return blockReplication;
 Can we get this into RC2?
 Thanks,
 St.Ack

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2408) DFSClient#getNumCurrentReplicas is package private in 205 but public in branch-0.20-append

2011-10-06 Thread Aaron T. Myers (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121759#comment-13121759
 ] 

Aaron T. Myers commented on HDFS-2408:
--

D'oh! I forgot that Jenkins isn't going to be able to apply the patch since the 
patch is for 0.20-security. :)

Regardless, the patch is trivial. I'll commit it tomorrow unless there are any 
objections in the mean time.

 DFSClient#getNumCurrentReplicas is package private in 205 but public in 
 branch-0.20-append
 --

 Key: HDFS-2408
 URL: https://issues.apache.org/jira/browse/HDFS-2408
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: hdfs client
Affects Versions: 0.20.205.1
Reporter: stack
Assignee: stack
 Attachments: hdfs-2408.txt


 The below commit broke hdfs-826 for hbase in 205 rc1.  It changes the 
 accessiblity from public to package private on getNumCurrentReplicas and now 
 current shipping hbase's at least cannot get at this method.
 {code}
 Revision 1174483 - (view) (download) (annotate) - [select for diffs] 
 Modified Fri Sep 23 01:30:18 2011 UTC (13 days, 4 hours ago) by szetszwo 
 File length: 136876 byte(s) 
 Diff to previous 1174479 (colored)
 svn merge -c 1171137 from branch-0.20-security for HDFS-2333.
 {code}
 Here is diff between above change and one just previous:
 http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-205/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java?view=diffr1=1174479r2=1174483diff_format=u
 This is a critical facility for us.
 It seems like making this one method public again is all thats needed.  I can 
 make a patch like the below:
 diff --git a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java 
 b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 index b9cb053..39955c9 100644
 --- a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 +++ b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 @@ -3569,7 +3569,7 @@ public class DFSClient implements FSConstants, 
 java.io.Closeable {
   * block is not yet allocated, then this API will return 0 because there 
 are
   * no replicas in the pipeline.
   */
 -int getNumCurrentReplicas() throws IOException {
 +public int getNumCurrentReplicas() throws IOException {
synchronized(dataQueue) {
  if (nodes == null) {
return blockReplication;
 Can we get this into RC2?
 Thanks,
 St.Ack

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2408) DFSClient#getNumCurrentReplicas is package private in 205 but public in branch-0.20-append

2011-10-06 Thread Suresh Srinivas (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121760#comment-13121760
 ] 

Suresh Srinivas commented on HDFS-2408:
---

Aaron, this is 205 patch. Are you starting Jenkins pre-commit build?

 DFSClient#getNumCurrentReplicas is package private in 205 but public in 
 branch-0.20-append
 --

 Key: HDFS-2408
 URL: https://issues.apache.org/jira/browse/HDFS-2408
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: hdfs client
Affects Versions: 0.20.205.1
Reporter: stack
Assignee: stack
 Attachments: hdfs-2408.txt


 The below commit broke hdfs-826 for hbase in 205 rc1.  It changes the 
 accessiblity from public to package private on getNumCurrentReplicas and now 
 current shipping hbase's at least cannot get at this method.
 {code}
 Revision 1174483 - (view) (download) (annotate) - [select for diffs] 
 Modified Fri Sep 23 01:30:18 2011 UTC (13 days, 4 hours ago) by szetszwo 
 File length: 136876 byte(s) 
 Diff to previous 1174479 (colored)
 svn merge -c 1171137 from branch-0.20-security for HDFS-2333.
 {code}
 Here is diff between above change and one just previous:
 http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-205/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java?view=diffr1=1174479r2=1174483diff_format=u
 This is a critical facility for us.
 It seems like making this one method public again is all thats needed.  I can 
 make a patch like the below:
 diff --git a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java 
 b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 index b9cb053..39955c9 100644
 --- a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 +++ b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 @@ -3569,7 +3569,7 @@ public class DFSClient implements FSConstants, 
 java.io.Closeable {
   * block is not yet allocated, then this API will return 0 because there 
 are
   * no replicas in the pipeline.
   */
 -int getNumCurrentReplicas() throws IOException {
 +public int getNumCurrentReplicas() throws IOException {
synchronized(dataQueue) {
  if (nodes == null) {
return blockReplication;
 Can we get this into RC2?
 Thanks,
 St.Ack

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2408) DFSClient#getNumCurrentReplicas is package private in 205 but public in branch-0.20-append

2011-10-06 Thread Suresh Srinivas (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121761#comment-13121761
 ] 

Suresh Srinivas commented on HDFS-2408:
---

Can you please commit this at the earlier. I can do that if you are busy. This 
will help get rc2 out sooner.

 DFSClient#getNumCurrentReplicas is package private in 205 but public in 
 branch-0.20-append
 --

 Key: HDFS-2408
 URL: https://issues.apache.org/jira/browse/HDFS-2408
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: hdfs client
Affects Versions: 0.20.205.1
Reporter: stack
Assignee: stack
 Attachments: hdfs-2408.txt


 The below commit broke hdfs-826 for hbase in 205 rc1.  It changes the 
 accessiblity from public to package private on getNumCurrentReplicas and now 
 current shipping hbase's at least cannot get at this method.
 {code}
 Revision 1174483 - (view) (download) (annotate) - [select for diffs] 
 Modified Fri Sep 23 01:30:18 2011 UTC (13 days, 4 hours ago) by szetszwo 
 File length: 136876 byte(s) 
 Diff to previous 1174479 (colored)
 svn merge -c 1171137 from branch-0.20-security for HDFS-2333.
 {code}
 Here is diff between above change and one just previous:
 http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-205/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java?view=diffr1=1174479r2=1174483diff_format=u
 This is a critical facility for us.
 It seems like making this one method public again is all thats needed.  I can 
 make a patch like the below:
 diff --git a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java 
 b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 index b9cb053..39955c9 100644
 --- a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 +++ b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 @@ -3569,7 +3569,7 @@ public class DFSClient implements FSConstants, 
 java.io.Closeable {
   * block is not yet allocated, then this API will return 0 because there 
 are
   * no replicas in the pipeline.
   */
 -int getNumCurrentReplicas() throws IOException {
 +public int getNumCurrentReplicas() throws IOException {
synchronized(dataQueue) {
  if (nodes == null) {
return blockReplication;
 Can we get this into RC2?
 Thanks,
 St.Ack

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2408) DFSClient#getNumCurrentReplicas is package private in 205 but public in branch-0.20-append


 [ 
https://issues.apache.org/jira/browse/HDFS-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-2408:
--

Priority: Blocker  (was: Major)

 DFSClient#getNumCurrentReplicas is package private in 205 but public in 
 branch-0.20-append
 --

 Key: HDFS-2408
 URL: https://issues.apache.org/jira/browse/HDFS-2408
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: hdfs client
Affects Versions: 0.20.205.1
Reporter: stack
Assignee: stack
Priority: Blocker
 Attachments: hdfs-2408.txt


 The below commit broke hdfs-826 for hbase in 205 rc1.  It changes the 
 accessiblity from public to package private on getNumCurrentReplicas and now 
 current shipping hbase's at least cannot get at this method.
 {code}
 Revision 1174483 - (view) (download) (annotate) - [select for diffs] 
 Modified Fri Sep 23 01:30:18 2011 UTC (13 days, 4 hours ago) by szetszwo 
 File length: 136876 byte(s) 
 Diff to previous 1174479 (colored)
 svn merge -c 1171137 from branch-0.20-security for HDFS-2333.
 {code}
 Here is diff between above change and one just previous:
 http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-205/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java?view=diffr1=1174479r2=1174483diff_format=u
 This is a critical facility for us.
 It seems like making this one method public again is all thats needed.  I can 
 make a patch like the below:
 diff --git a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java 
 b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 index b9cb053..39955c9 100644
 --- a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 +++ b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 @@ -3569,7 +3569,7 @@ public class DFSClient implements FSConstants, 
 java.io.Closeable {
   * block is not yet allocated, then this API will return 0 because there 
 are
   * no replicas in the pipeline.
   */
 -int getNumCurrentReplicas() throws IOException {
 +public int getNumCurrentReplicas() throws IOException {
synchronized(dataQueue) {
  if (nodes == null) {
return blockReplication;
 Can we get this into RC2?
 Thanks,
 St.Ack

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2408) DFSClient#getNumCurrentReplicas is package private in 205 but public in branch-0.20-append


[ 
https://issues.apache.org/jira/browse/HDFS-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121764#comment-13121764
 ] 

Hadoop QA commented on HDFS-2408:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12497951/hdfs-2408.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1343//console

This message is automatically generated.

 DFSClient#getNumCurrentReplicas is package private in 205 but public in 
 branch-0.20-append
 --

 Key: HDFS-2408
 URL: https://issues.apache.org/jira/browse/HDFS-2408
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: hdfs client
Affects Versions: 0.20.205.1
Reporter: stack
Assignee: stack
Priority: Blocker
 Attachments: hdfs-2408.txt


 The below commit broke hdfs-826 for hbase in 205 rc1.  It changes the 
 accessiblity from public to package private on getNumCurrentReplicas and now 
 current shipping hbase's at least cannot get at this method.
 {code}
 Revision 1174483 - (view) (download) (annotate) - [select for diffs] 
 Modified Fri Sep 23 01:30:18 2011 UTC (13 days, 4 hours ago) by szetszwo 
 File length: 136876 byte(s) 
 Diff to previous 1174479 (colored)
 svn merge -c 1171137 from branch-0.20-security for HDFS-2333.
 {code}
 Here is diff between above change and one just previous:
 http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-205/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java?view=diffr1=1174479r2=1174483diff_format=u
 This is a critical facility for us.
 It seems like making this one method public again is all thats needed.  I can 
 make a patch like the below:
 diff --git a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java 
 b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 index b9cb053..39955c9 100644
 --- a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 +++ b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 @@ -3569,7 +3569,7 @@ public class DFSClient implements FSConstants, 
 java.io.Closeable {
   * block is not yet allocated, then this API will return 0 because there 
 are
   * no replicas in the pipeline.
   */
 -int getNumCurrentReplicas() throws IOException {
 +public int getNumCurrentReplicas() throws IOException {
synchronized(dataQueue) {
  if (nodes == null) {
return blockReplication;
 Can we get this into RC2?
 Thanks,
 St.Ack

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2408) DFSClient#getNumCurrentReplicas is package private in 205 but public in branch-0.20-append


 [ 
https://issues.apache.org/jira/browse/HDFS-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aaron T. Myers updated HDFS-2408:
-

   Resolution: Fixed
Fix Version/s: 0.20.206.0
   0.20.205.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Thanks Suresh. I've just committed this to branch-0.20-security and 
branch-0.20-security-205.

 DFSClient#getNumCurrentReplicas is package private in 205 but public in 
 branch-0.20-append
 --

 Key: HDFS-2408
 URL: https://issues.apache.org/jira/browse/HDFS-2408
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: hdfs client
Affects Versions: 0.20.205.1
Reporter: stack
Assignee: stack
Priority: Blocker
 Fix For: 0.20.205.0, 0.20.206.0

 Attachments: hdfs-2408.txt


 The below commit broke hdfs-826 for hbase in 205 rc1.  It changes the 
 accessiblity from public to package private on getNumCurrentReplicas and now 
 current shipping hbase's at least cannot get at this method.
 {code}
 Revision 1174483 - (view) (download) (annotate) - [select for diffs] 
 Modified Fri Sep 23 01:30:18 2011 UTC (13 days, 4 hours ago) by szetszwo 
 File length: 136876 byte(s) 
 Diff to previous 1174479 (colored)
 svn merge -c 1171137 from branch-0.20-security for HDFS-2333.
 {code}
 Here is diff between above change and one just previous:
 http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-205/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java?view=diffr1=1174479r2=1174483diff_format=u
 This is a critical facility for us.
 It seems like making this one method public again is all thats needed.  I can 
 make a patch like the below:
 diff --git a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java 
 b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 index b9cb053..39955c9 100644
 --- a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 +++ b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 @@ -3569,7 +3569,7 @@ public class DFSClient implements FSConstants, 
 java.io.Closeable {
   * block is not yet allocated, then this API will return 0 because there 
 are
   * no replicas in the pipeline.
   */
 -int getNumCurrentReplicas() throws IOException {
 +public int getNumCurrentReplicas() throws IOException {
synchronized(dataQueue) {
  if (nodes == null) {
return blockReplication;
 Can we get this into RC2?
 Thanks,
 St.Ack

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby


 [ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-2301:
--

Attachment: HDFS-2301.txt

New patch addresses some of the comment. See review board for my responses to 
other comments. BTW, how does the comments I posted on review board make it to 
jira?

 Start/stop appropriate namenode internal services during transition to active 
 and standby
 -

 Key: HDFS-2301
 URL: https://issues.apache.org/jira/browse/HDFS-2301
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: name-node
Affects Versions: HA branch (HDFS-1623)
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
 Fix For: HA branch (HDFS-1623)

 Attachments: HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt


 These changes are related to HDFS-1974 which introduced active and standby 
 states. This jira will address starting and stopping appropriate NN services 
 when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby


 [ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-2301:
--

Attachment: HDFS-2301.txt

New patch with missing files included.

 Start/stop appropriate namenode internal services during transition to active 
 and standby
 -

 Key: HDFS-2301
 URL: https://issues.apache.org/jira/browse/HDFS-2301
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: name-node
Affects Versions: HA branch (HDFS-1623)
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
 Fix For: HA branch (HDFS-1623)

 Attachments: HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt, 
 HDFS-2301.txt


 These changes are related to HDFS-1974 which introduced active and standby 
 states. This jira will address starting and stopping appropriate NN services 
 when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2231) Configuration changes for HA namenode


 [ 
https://issues.apache.org/jira/browse/HDFS-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-2231:
--

Attachment: HDFS-2231.txt

bq. Why remove DFSUtil.getNameServiceIdKey
With federation there was only one suffix possible to key. With HA, it is 
combination of service ID and namenode Id. With that, just getNameServiceIdKey 
no longer makes sense. Hence the method is removed.

bq. as not all users will know who Suresh is.
With log messages like that, that was exactly the problem I was trying to 
address :-)

 Configuration changes for HA namenode
 -

 Key: HDFS-2231
 URL: https://issues.apache.org/jira/browse/HDFS-2231
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
 Fix For: HA branch (HDFS-1623)

 Attachments: HDFS-2231.txt, HDFS-2231.txt


 This jira tracks the changes required for configuring HA setup for namenodes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby

2011-10-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121775#comment-13121775
 ] 

Todd Lipcon commented on HDFS-2301:
---

Did you click on Publish on review board? I don't see your responses there. 
Once you publish, it will copy to JIRA and email.

 Start/stop appropriate namenode internal services during transition to active 
 and standby
 -

 Key: HDFS-2301
 URL: https://issues.apache.org/jira/browse/HDFS-2301
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: name-node
Affects Versions: HA branch (HDFS-1623)
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
 Fix For: HA branch (HDFS-1623)

 Attachments: HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt, 
 HDFS-2301.txt


 These changes are related to HDFS-1974 which introduced active and standby 
 states. This jira will address starting and stopping appropriate NN services 
 when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby


[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121781#comment-13121781
 ] 

jirapos...@reviews.apache.org commented on HDFS-2301:
-



bq.  On 2011-10-03 18:58:13, Todd Lipcon wrote:
bq.   just a few nits, mostly looks good. A few questions I have that aren't 
directly related to this patch:
bq.   - is SafeMode now a replicated thing, or does each NN separately enter 
safemode? I think the latter, right?
bq.   - when transitioning between states, what happens if the enterState 
fails for the new state? The state variable will then indicate it's in that 
state, when in fact it's in no state at all. How do we recover from that? We 
need some kind of rollback? (eg if you're in standby and try to transition to 
active, but find that you can't take a lock in ZK)

bq.  is SafeMode now a replicated thing, or does each NN separately enter 
safemode? I think the latter, right?
Safemode is the state of namespace(FSNamesystem), unlike active, standby which 
are the states of the namenode. Each NN separately enters safemode.

bq.  when transitioning between states, what happens if the enterState fails 
for the new state? The state variable will then indicate it's in that state, 
when in fact it's in no state at all. How do we recover from that? We need some 
kind of rollback? (eg if you're in standby and try to transition to active, but 
find that you can't take a lock in ZK)
This is tricky. Say enterState fails to start services because of some namenode 
process related issues. Then most likely rolling back to previous state, and 
starting services relevant to previous states will also fail. The particular 
example you are bringing up related to ZK, I think failover controller is the 
one that deals with ZK and not namenode.

I can think of two solutions: namenode shutsdown when this happens (as done 
during startup) or move to a failed state.


bq.  On 2011-10-03 18:58:13, Todd Lipcon wrote:
bq.   
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java,
 line 464
bq.   https://reviews.apache.org/r/2150/diff/1/?file=47529#file47529line464
bq.  
bq.   any reason that you switched the order of startHttpServer to the end 
of this function? I don't think it's a big deal, but there's some possibility 
the service plugins may want to do something with the http server, which 
wouldn't be started yet.

No particular reason. Not sure who uses ServicePlugins. But the description 
says it is RPC related. But will move it back up.


- Suresh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2150/#review2277
---


On 2011-10-03 18:36:41, Todd Lipcon wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2150/
bq.  ---
bq.  
bq.  (Updated 2011-10-03 18:36:41)
bq.  
bq.  
bq.  Review request for hadoop-hdfs and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Uploading Suresh's patch to reviewboard 
(https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from 
29/Sep/11 00:56)
bq.  
bq.  
bq.  This addresses bug HDFS-2301.
bq.  https://issues.apache.org/jira/browse/HDFS-2301
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
 1177130 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
 1177130 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
 1177130 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java
 1177128 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAContext.java
 PRE-CREATION 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAState.java
 1177128 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyState.java
 1177128 
bq.  
bq.  Diff: https://reviews.apache.org/r/2150/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Todd
bq.  
bq.



 Start/stop appropriate namenode internal services during transition to active 
 and standby
 -

 Key: HDFS-2301

[jira] [Commented] (HDFS-2407) getServerDefaults and getStats don't check operation category

2011-10-06 Thread Suresh Srinivas (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121782#comment-13121782
 ] 

Suresh Srinivas commented on HDFS-2407:
---

+1 for the patch.

 getServerDefaults and getStats don't check operation category
 -

 Key: HDFS-2407
 URL: https://issues.apache.org/jira/browse/HDFS-2407
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: name-node
Affects Versions: HA branch (HDFS-1623)
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
 Fix For: HA branch (HDFS-1623)

 Attachments: HDFS-2407-HDFS-1623.patch


 They should both check for {{OperationCategory.READ}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1973) HA: HDFS clients must handle namenode failover and switch over to the new active namenode.

2011-10-06 Thread Tsz Wo (Nicholas), SZE (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HDFS-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121784#comment-13121784
]

Hadoop QA commented on HDFS-1973:
-

-1 overall. Here are the results of testing the latest attachment

http://issues.apache.org/jira/secure/attachment/12497950/HDFS-1973-HDFS-1623.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 2 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 core tests. The patch passed unit tests in .

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1342//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1342//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1342//console

This message is automatically generated.

HA: HDFS clients must handle namenode failover and switch over to the new
active namenode.
--

Key: HDFS-1973
URL: https://issues.apache.org/jira/browse/HDFS-1973
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Suresh Srinivas
Assignee: Aaron T. Myers
Attachments: HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch,
HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch,
HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch, hdfs-1973.0.patch

During failover, a client must detect the current active namenode failure and
switch over to the new active namenode. The switch over might make use of IP
failover or some thing more elaborate such as zookeeper to discover the new
active.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2209) MiniDFS cluster improvements

2011-10-06 Thread Steve Loughran (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HDFS-2209:
-

Target Version/s: 0.23.0, 0.24.0  (was: 0.24.0, 0.23.0)
  Status: Open  (was: Patch Available)

 MiniDFS cluster improvements
 

 Key: HDFS-2209
 URL: https://issues.apache.org/jira/browse/HDFS-2209
 Project: Hadoop HDFS
  Issue Type: Improvement
  Components: test
Affects Versions: 0.20.203.0
Reporter: Steve Loughran
Assignee: Steve Loughran
Priority: Minor
 Fix For: 0.24.0

 Attachments: HDFS-2209.patch, HDFS-2209.patch, HDFS-2209.patch, 
 HDFS-2209.patch

   Original Estimate: 1h
  Time Spent: 1.5h
  Remaining Estimate: 2h

 I've been deploying MiniDFSCluster for some testing, and while using 
 it/looking through the code I made some notes of where there are issues and 
 improvement opportunities. This is mostly minor as its a test tool, but a 
 risk of synchronization problems is there and does need addressing; the rest 
 are all feature creep. 
 Field {{nameNode}} should be marked as volatile as the shutdown operation can 
 be in a different thread than startup. Best of all, 
 add synchronized methods to set and get the field, as well as shutdown.
 The data dir is set from from System Properties.
 {code}
 base_dir = new File(System.getProperty(test.build.data, 
 build/test/data), dfs/);
 data_dir = new File(base_dir, data);
 {code}
 This is done in {{formatDataNodeDirs()}} {{corruptBlockOnDataNode()}} and  
 the constructor.
 Improvement: have a test property in the conf file, and only read the system 
 property if this is unset. This will enable
  multiple MiniDFSClusters to come up in the same JVM, and handle 
 shutdown/startup race conditions better, and avoid the
  java.io.IOException: Cannot lock storage build/test/data/dfs/name1. The 
 directory is already locked. messages
 Messages should log to the commons logging and not {{System.err}} and 
 {{System.out}}. This enables containers to catch and stream better, 
 and include more diagnostics such as timestamp and thread Id
 Class could benefit from a method to return the FS URI, rather than just the 
 FS. This currently has to be worked around with some tricks involving a 
 cached configuration
 {{waitActive()}} could get confused if localhost maps to an IPv6 address. 
 Better to ask for 127.0.0.1 as the hostname; Junit
 test runs may need to be set up to force in IPv4 too.
 {{injectBlocks}} has a spelling error in the IOException, 
 SumulatedFSDataset is the correct spelling

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2209) MiniDFS cluster improvements

2011-10-06 Thread Steve Loughran (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Loughran updated HDFS-2209:
-

Target Version/s: 0.23.0, 0.24.0  (was: 0.24.0, 0.23.0)
  Status: Patch Available  (was: Open)

resubmit now that HDFS-2298 is in trunk

 MiniDFS cluster improvements
 

 Key: HDFS-2209
 URL: https://issues.apache.org/jira/browse/HDFS-2209
 Project: Hadoop HDFS
  Issue Type: Improvement
  Components: test
Affects Versions: 0.20.203.0
Reporter: Steve Loughran
Assignee: Steve Loughran
Priority: Minor
 Fix For: 0.24.0

 Attachments: HDFS-2209.patch, HDFS-2209.patch, HDFS-2209.patch, 
 HDFS-2209.patch

   Original Estimate: 1h
  Time Spent: 1.5h
  Remaining Estimate: 2h

 I've been deploying MiniDFSCluster for some testing, and while using 
 it/looking through the code I made some notes of where there are issues and 
 improvement opportunities. This is mostly minor as its a test tool, but a 
 risk of synchronization problems is there and does need addressing; the rest 
 are all feature creep. 
 Field {{nameNode}} should be marked as volatile as the shutdown operation can 
 be in a different thread than startup. Best of all, 
 add synchronized methods to set and get the field, as well as shutdown.
 The data dir is set from from System Properties.
 {code}
 base_dir = new File(System.getProperty(test.build.data, 
 build/test/data), dfs/);
 data_dir = new File(base_dir, data);
 {code}
 This is done in {{formatDataNodeDirs()}} {{corruptBlockOnDataNode()}} and  
 the constructor.
 Improvement: have a test property in the conf file, and only read the system 
 property if this is unset. This will enable
  multiple MiniDFSClusters to come up in the same JVM, and handle 
 shutdown/startup race conditions better, and avoid the
  java.io.IOException: Cannot lock storage build/test/data/dfs/name1. The 
 directory is already locked. messages
 Messages should log to the commons logging and not {{System.err}} and 
 {{System.out}}. This enables containers to catch and stream better, 
 and include more diagnostics such as timestamp and thread Id
 Class could benefit from a method to return the FS URI, rather than just the 
 FS. This currently has to be worked around with some tricks involving a 
 cached configuration
 {{waitActive()}} could get confused if localhost maps to an IPv6 address. 
 Better to ask for 127.0.0.1 as the hostname; Junit
 test runs may need to be set up to force in IPv4 too.
 {{injectBlocks}} has a spelling error in the IOException, 
 SumulatedFSDataset is the correct spelling

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2404) webhdfs liststatus json response is not correct


[ 
https://issues.apache.org/jira/browse/HDFS-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121893#comment-13121893
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-2404:
--

The patch for trunk (HDFS-2404.txt) does not contain the WebHdfsFileSystem 
changes.

 webhdfs liststatus json response is not correct
 ---

 Key: HDFS-2404
 URL: https://issues.apache.org/jira/browse/HDFS-2404
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0
Reporter: Arpit Gupta
Assignee: Suresh Srinivas
 Attachments: HDFS-2404.20.txt, HDFS-2404.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2404) webhdfs liststatus json response is not correct

2011-10-06 Thread Tsz Wo (Nicholas), SZE (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121908#comment-13121908
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-2404:
--

+1 for the 0.20s patch.

 webhdfs liststatus json response is not correct
 ---

 Key: HDFS-2404
 URL: https://issues.apache.org/jira/browse/HDFS-2404
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0
Reporter: Arpit Gupta
Assignee: Suresh Srinivas
 Attachments: HDFS-2404.20.txt, HDFS-2404.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2385) Support delegation token renewal in webhdfs

2011-10-06 Thread Daryn Sharp (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121965#comment-13121965
 ] 

Daryn Sharp commented on HDFS-2385:
---

Patch looks good, but on further inspection, I'd suggest the following so it 
can be implemented in a simpler/cleaner fashion:
* removing {{getUri()}} since super does the same thing
* allowing hftp specific to leak into {{DelegationTokenSelector}} feels a bit 
odd
*# could rename {{selectHftpDelegationToken}} to a more generic 
{{selectDelegationToken}}
*# move the hftp token selector back into {{HftpFileSystem}} as 
{{selectDelegationToken}}
*# split the couple of lines for webhdfs token selection into 
{{selectDelegationToken}}
*# at this point {{WebHdfsFileSystem.initialize()}} really is a copy-n-paste of 
the super method, so it can call super and then set {{workingDir}}

 Support delegation token renewal in webhdfs
 ---

 Key: HDFS-2385
 URL: https://issues.apache.org/jira/browse/HDFS-2385
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
 Fix For: 0.20.205.0, 0.20.206.0

 Attachments: h2358_20111001_0.20s.patch, h2385_20111004_0.20s.patch, 
 h2385_20111004b_0.20s.patch, h2385_20111004b_amendment2_0.20s.patch, 
 h2385_20111004b_amendment_0.20s.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2385) Support delegation token renewal in webhdfs

2011-10-06 Thread Tsz Wo (Nicholas), SZE (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121985#comment-13121985
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-2385:
--

Hi Daryn, WebHdfsFileSystem does not extend HftpFileSystem anymore.  So, it 
cannot use the super methods.

 Support delegation token renewal in webhdfs
 ---

 Key: HDFS-2385
 URL: https://issues.apache.org/jira/browse/HDFS-2385
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
 Fix For: 0.20.205.0, 0.20.206.0

 Attachments: h2358_20111001_0.20s.patch, h2385_20111004_0.20s.patch, 
 h2385_20111004b_0.20s.patch, h2385_20111004b_amendment2_0.20s.patch, 
 h2385_20111004b_amendment_0.20s.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2385) Support delegation token renewal in webhdfs

2011-10-06 Thread Daryn Sharp (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122005#comment-13122005
 ] 

Daryn Sharp commented on HDFS-2385:
---

+1 Oh, I missed that in the patch.

 Support delegation token renewal in webhdfs
 ---

 Key: HDFS-2385
 URL: https://issues.apache.org/jira/browse/HDFS-2385
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
 Fix For: 0.20.205.0, 0.20.206.0

 Attachments: h2358_20111001_0.20s.patch, h2385_20111004_0.20s.patch, 
 h2385_20111004b_0.20s.patch, h2385_20111004b_amendment2_0.20s.patch, 
 h2385_20111004b_amendment_0.20s.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Work started] (HDFS-2407) getServerDefaults and getStats don't check operation category

2011-10-06 Thread Aaron T. Myers (Work started) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HDFS-2407 started by Aaron T. Myers.

 getServerDefaults and getStats don't check operation category
 -

 Key: HDFS-2407
 URL: https://issues.apache.org/jira/browse/HDFS-2407
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: name-node
Affects Versions: HA branch (HDFS-1623)
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
 Fix For: HA branch (HDFS-1623)

 Attachments: HDFS-2407-HDFS-1623.patch


 They should both check for {{OperationCategory.READ}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2334) Add Closeable to JournalManager

2011-10-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122071#comment-13122071
 ] 

jirapos...@reviews.apache.org commented on HDFS-2334:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2247/
---

Review request for hadoop-hdfs.


Summary
---

A JournalManager may take hold of resources for the duration of their lifetime. 
This isn't the case at the moment for FileJournalManager, but 
BookKeeperJournalManager will, and it's conceivable that FileJournalManager 
could take a lock on a directory etc.

This JIRA is to add Closeable to JournalManager so that these resources can be 
cleaned up when FSEditLog is closed.


This addresses bug HDFS-2334.
http://issues.apache.org/jira/browse/HDFS-2334


Diffs
-

  
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupJournalManager.java
 6976620 
  
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
 4a41a2c 
  
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileJournalManager.java
 8cfc975 
  
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalManager.java
 0bb7b0f 
  
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalSet.java
 0d6bc74 

Diff: https://reviews.apache.org/r/2247/diff


Testing
---


Thanks,

Ivan



 Add Closeable to JournalManager
 ---

 Key: HDFS-2334
 URL: https://issues.apache.org/jira/browse/HDFS-2334
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Ivan Kelly
Assignee: Ivan Kelly
 Fix For: 0.23.0

 Attachments: HDFS-2334.diff, HDFS-2334.diff


 A JournalManager may take hold of resources for the duration of their 
 lifetime. This isn't the case at the moment for FileJournalManager, but 
 BookKeeperJournalManager will, and it's conceivable that FileJournalManager 
 could take a lock on a directory etc. 
 This JIRA is to add Closeable to JournalManager so that these resources can 
 be cleaned up when FSEditLog is closed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2181) Seperate HDFS wire protocol data types


[ 
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122072#comment-13122072
 ] 

Todd Lipcon commented on HDFS-2181:
---

Thanks, makes sense. Let me do a quick review pass through the latest revision.

 Seperate HDFS wire protocol data types
 --

 Key: HDFS-2181
 URL: https://issues.apache.org/jira/browse/HDFS-2181
 Project: Hadoop HDFS
  Issue Type: Improvement
Reporter: Sanjay Radia
Assignee: Sanjay Radia
 Attachments: separateDataType1.patch, separateDataType10.patch, 
 separateDataType11.patch, separateDataType12.patch, separateDataType13.patch, 
 separateDataType14.patch, separateDataType16.patch, separateDataType19.patch, 
 separateDataType2.patch, separateDataType6.patch, separateDataType7.patch, 
 separateDataType8.patch, separateDataType9.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2408) DFSClient#getNumCurrentReplicas is package private in 205 but public in branch-0.20-append

2011-10-06 Thread Matt Foley (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Foley updated HDFS-2408:
-

Fix Version/s: (was: 0.20.206.0)

Thanks, stack, for the good catch, and aaron thanks for the fast review.  This 
will go in 0.20.205.0-rc2.

 DFSClient#getNumCurrentReplicas is package private in 205 but public in 
 branch-0.20-append
 --

 Key: HDFS-2408
 URL: https://issues.apache.org/jira/browse/HDFS-2408
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: hdfs client
Affects Versions: 0.20.205.1
Reporter: stack
Assignee: stack
Priority: Blocker
 Fix For: 0.20.205.0

 Attachments: hdfs-2408.txt


 The below commit broke hdfs-826 for hbase in 205 rc1.  It changes the 
 accessiblity from public to package private on getNumCurrentReplicas and now 
 current shipping hbase's at least cannot get at this method.
 {code}
 Revision 1174483 - (view) (download) (annotate) - [select for diffs] 
 Modified Fri Sep 23 01:30:18 2011 UTC (13 days, 4 hours ago) by szetszwo 
 File length: 136876 byte(s) 
 Diff to previous 1174479 (colored)
 svn merge -c 1171137 from branch-0.20-security for HDFS-2333.
 {code}
 Here is diff between above change and one just previous:
 http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-205/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java?view=diffr1=1174479r2=1174483diff_format=u
 This is a critical facility for us.
 It seems like making this one method public again is all thats needed.  I can 
 make a patch like the below:
 diff --git a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java 
 b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 index b9cb053..39955c9 100644
 --- a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 +++ b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
 @@ -3569,7 +3569,7 @@ public class DFSClient implements FSConstants, 
 java.io.Closeable {
   * block is not yet allocated, then this API will return 0 because there 
 are
   * no replicas in the pipeline.
   */
 -int getNumCurrentReplicas() throws IOException {
 +public int getNumCurrentReplicas() throws IOException {
synchronized(dataQueue) {
  if (nodes == null) {
return blockReplication;
 Can we get this into RC2?
 Thanks,
 St.Ack

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2181) Seperate HDFS wire protocol data types


[ 
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122082#comment-13122082
 ] 

Todd Lipcon commented on HDFS-2181:
---

- The javadoc for closeConnectionToNamenode has some strange 
formatting/indentation. Small typo: orcreated
- Can you use IOUtils.closeStream there? Or at least log the exception if 
there's a problem.
- Can we rename ClientDatanodeProtocolTranslator to 
R23ClientDatanodeProtocolTranslator, etc?
- Until  version 69, this class ClientProtocol servers as both has an extra 
space between Until and version, and should be serves as both not 
servers as both

- in AdminStates.fromValue, if the value isn't in the enum, returning NORMAL 
seems incorrect - maybe it should throw an exception or return a new UNKNOWN 
value?
- the class name ClientNamenodeProtocolWritable implies that this class is a 
writable, when in fact it's an interface... maybe rename to 
ClientNamenodeWritableWireProtocol? or just ClientNamenodeWireProtocol? 
Elsewhere we have the strong convention that *Writable implements Writable

after fixing those, +1 from me

 Seperate HDFS wire protocol data types
 --

 Key: HDFS-2181
 URL: https://issues.apache.org/jira/browse/HDFS-2181
 Project: Hadoop HDFS
  Issue Type: Improvement
Reporter: Sanjay Radia
Assignee: Sanjay Radia
 Attachments: separateDataType1.patch, separateDataType10.patch, 
 separateDataType11.patch, separateDataType12.patch, separateDataType13.patch, 
 separateDataType14.patch, separateDataType16.patch, separateDataType19.patch, 
 separateDataType2.patch, separateDataType6.patch, separateDataType7.patch, 
 separateDataType8.patch, separateDataType9.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2385) Support delegation token renewal in webhdfs

2011-10-06 Thread Matt Foley (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122084#comment-13122084
 ] 

Matt Foley commented on HDFS-2385:
--

This needs to go in 0.20-security-205 also, doesn't it?
So far the amendment has only been committed to 0.20-security.

 Support delegation token renewal in webhdfs
 ---

 Key: HDFS-2385
 URL: https://issues.apache.org/jira/browse/HDFS-2385
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
 Fix For: 0.20.205.0, 0.20.206.0

 Attachments: h2358_20111001_0.20s.patch, h2385_20111004_0.20s.patch, 
 h2385_20111004b_0.20s.patch, h2385_20111004b_amendment2_0.20s.patch, 
 h2385_20111004b_amendment_0.20s.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HDFS-2385) Support delegation token renewal in webhdfs

2011-10-06 Thread Matt Foley (Resolved) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Foley resolved HDFS-2385.
--

   Resolution: Fixed
Fix Version/s: (was: 0.20.206.0)

Merged to 0.20.205.  Thanks, Nicholas!

 Support delegation token renewal in webhdfs
 ---

 Key: HDFS-2385
 URL: https://issues.apache.org/jira/browse/HDFS-2385
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
 Fix For: 0.20.205.0

 Attachments: h2358_20111001_0.20s.patch, h2385_20111004_0.20s.patch, 
 h2385_20111004b_0.20s.patch, h2385_20111004b_amendment2_0.20s.patch, 
 h2385_20111004b_amendment_0.20s.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HDFS-2404) webhdfs liststatus json response is not correct

2011-10-06 Thread Matt Foley (Resolved) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Foley resolved HDFS-2404.
--

   Resolution: Fixed
Fix Version/s: 0.20.205.0

Committed to 0.20-sec and 0.20.205.  Thanks Suresh!  And thanks, Nicholas, for 
the review.

 webhdfs liststatus json response is not correct
 ---

 Key: HDFS-2404
 URL: https://issues.apache.org/jira/browse/HDFS-2404
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0
Reporter: Arpit Gupta
Assignee: Suresh Srinivas
 Fix For: 0.20.205.0

 Attachments: HDFS-2404.20.txt, HDFS-2404.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HDFS-2409) _HOST in dfs.web.authentication.kerberos.principal.

2011-10-06 Thread Jitendra Nath Pandey (Created) (JIRA)

_HOST in dfs.web.authentication.kerberos.principal.
---

 Key: HDFS-2409
 URL: https://issues.apache.org/jira/browse/HDFS-2409
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey


This is HDFS part of HADOOP-7721. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2409) _HOST in dfs.web.authentication.kerberos.principal.

2011-10-06 Thread Jitendra Nath Pandey (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jitendra Nath Pandey updated HDFS-2409:
---

Attachment: HDFS-2409-trunk.patch

Patch uploaded.

 _HOST in dfs.web.authentication.kerberos.principal.
 ---

 Key: HDFS-2409
 URL: https://issues.apache.org/jira/browse/HDFS-2409
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
 Attachments: HDFS-2409-trunk.patch


 This is HDFS part of HADOOP-7721. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2409) _HOST in dfs.web.authentication.kerberos.principal.

2011-10-06 Thread Jitendra Nath Pandey (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jitendra Nath Pandey updated HDFS-2409:
---

Status: Patch Available  (was: Open)

 _HOST in dfs.web.authentication.kerberos.principal.
 ---

 Key: HDFS-2409
 URL: https://issues.apache.org/jira/browse/HDFS-2409
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
 Attachments: HDFS-2409-trunk.patch


 This is HDFS part of HADOOP-7721. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2404) webhdfs liststatus json response is not correct

2011-10-06 Thread Matt Foley (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Foley updated HDFS-2404:
-

 Target Version/s: 0.20.205.0, 0.23.0  (was: 0.20.205.0)
Affects Version/s: 0.23.0

 webhdfs liststatus json response is not correct
 ---

 Key: HDFS-2404
 URL: https://issues.apache.org/jira/browse/HDFS-2404
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0, 0.23.0
Reporter: Arpit Gupta
Assignee: Suresh Srinivas
 Fix For: 0.20.205.0

 Attachments: HDFS-2404.20.txt, HDFS-2404.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (HDFS-2404) webhdfs liststatus json response is not correct

2011-10-06 Thread Matt Foley (Reopened) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Foley reopened HDFS-2404:
--


Reopened for trunk fix.

 webhdfs liststatus json response is not correct
 ---

 Key: HDFS-2404
 URL: https://issues.apache.org/jira/browse/HDFS-2404
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0, 0.23.0
Reporter: Arpit Gupta
Assignee: Suresh Srinivas
 Fix For: 0.20.205.0

 Attachments: HDFS-2404.20.txt, HDFS-2404.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2396) dfs -tail command with an hftp source fails with a cant seek error

2011-10-06 Thread Matt Foley (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122142#comment-13122142
 ] 

Matt Foley commented on HDFS-2396:
--

This behavior is expected for hftp, although -tail should work for webhdfs.
Please re-test on 204 to confirm that it didn't work in hftp on 204 either.

 dfs -tail command with an hftp source fails with a cant seek error
 --

 Key: HDFS-2396
 URL: https://issues.apache.org/jira/browse/HDFS-2396
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0
Reporter: Arpit Gupta



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2404) webhdfs liststatus json response is not correct


 [ 
https://issues.apache.org/jira/browse/HDFS-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-2404:
--

Attachment: HDFS-2404.txt

Updated patch for trunk.

 webhdfs liststatus json response is not correct
 ---

 Key: HDFS-2404
 URL: https://issues.apache.org/jira/browse/HDFS-2404
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0, 0.23.0
Reporter: Arpit Gupta
Assignee: Suresh Srinivas
 Fix For: 0.20.205.0

 Attachments: HDFS-2404.20.txt, HDFS-2404.txt, HDFS-2404.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-1973) HA: HDFS clients must handle namenode failover and switch over to the new active namenode.


 [ 
https://issues.apache.org/jira/browse/HDFS-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aaron T. Myers updated HDFS-1973:
-

Attachment: HDFS-1973-HDFS-1623.patch

Trivial change from the last patch to get rid of the *new* findbugs warning.

Third time's a charm? :)

 HA: HDFS clients must handle namenode failover and switch over to the new 
 active namenode.
 --

 Key: HDFS-1973
 URL: https://issues.apache.org/jira/browse/HDFS-1973
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Suresh Srinivas
Assignee: Aaron T. Myers
 Attachments: HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch, 
 HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch, 
 HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch, 
 HDFS-1973-HDFS-1623.patch, hdfs-1973.0.patch


 During failover, a client must detect the current active namenode failure and 
 switch over to the new active namenode. The switch over might make use of IP 
 failover or some thing more elaborate such as zookeeper to discover the new 
 active.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2404) webhdfs liststatus json response is not correct


 [ 
https://issues.apache.org/jira/browse/HDFS-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-2404:
--

Target Version/s: 0.20.205.0, 0.23.0  (was: 0.23.0, 0.20.205.0)
  Status: Patch Available  (was: Reopened)

 webhdfs liststatus json response is not correct
 ---

 Key: HDFS-2404
 URL: https://issues.apache.org/jira/browse/HDFS-2404
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0, 0.23.0
Reporter: Arpit Gupta
Assignee: Suresh Srinivas
 Fix For: 0.20.205.0

 Attachments: HDFS-2404.20.txt, HDFS-2404.txt, HDFS-2404.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2396) dfs -tail command with an hftp source fails with a cant seek error

2011-10-06 Thread Rajit Saha (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122164#comment-13122164
 ] 

Rajit Saha commented on HDFS-2396:
--

in 204 -tail with hftp does not work

 dfs -tail command with an hftp source fails with a cant seek error
 --

 Key: HDFS-2396
 URL: https://issues.apache.org/jira/browse/HDFS-2396
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0
Reporter: Arpit Gupta



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2396) dfs -tail command with an hftp source fails with a cant seek error

2011-10-06 Thread Arpit Gupta (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122174#comment-13122174
 ] 

Arpit Gupta commented on HDFS-2396:
---

Thanks Rajit, i have tested webhdfs with tail and it worked in 205.

 dfs -tail command with an hftp source fails with a cant seek error
 --

 Key: HDFS-2396
 URL: https://issues.apache.org/jira/browse/HDFS-2396
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0
Reporter: Arpit Gupta



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2322) the build fails in Windows because commons-daemon TAR cannot be fetched

2011-10-06 Thread Alejandro Abdelnur (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122202#comment-13122202
 ] 

Alejandro Abdelnur commented on HDFS-2322:
--

patch still applies cleanly

 the build fails in Windows because commons-daemon TAR cannot be fetched
 ---

 Key: HDFS-2322
 URL: https://issues.apache.org/jira/browse/HDFS-2322
 Project: Hadoop HDFS
  Issue Type: Bug
  Components: build
Affects Versions: 0.23.0, 0.24.0
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
 Fix For: 0.23.0, 0.24.0

 Attachments: HDFS-2322v1.patch


 For windows there is no commons-daemon TAR but a ZIP, plus the name follows a 
 different convention. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2294) Download of commons-daemon TAR should not be under target

2011-10-06 Thread Alejandro Abdelnur (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HDFS-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122211#comment-13122211
]

Alejandro Abdelnur commented on HDFS-2294:
--

patch still applies cleanly.

Download of commons-daemon TAR should not be under target
-

Key: HDFS-2294
URL: https://issues.apache.org/jira/browse/HDFS-2294
Project: Hadoop HDFS
Issue Type: Improvement
Components: build
Affects Versions: 0.23.0, 0.24.0
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
Fix For: 0.23.0, 0.24.0

Attachments: HDFS-2289.patch

Committed HDFS-2289 downloads commons-daemon TAR in the hadoop-hdfs/target/,
earlier patches for HDFS-2289 were using hadoop-hdfs/download/ as the
location for the download.
The motivation not to use the 'target/' directory is that on every clean
build the TAR will be downloaded from Apache archives. Using a 'download'
directory this happens once per workspace.
The patch was also adding the 'download/' directory to the .gitignore file
(it should also be svn ignored).
Besides downloading it only once, it allows to do a clean build in
disconnected mode.
IMO, the later is a nice developer capability.

[jira] [Updated] (HDFS-2181) Seperate HDFS wire protocol data types


 [ 
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sanjay Radia updated HDFS-2181:
---

Attachment: separateDataType20.patch

Addressed todd's last feedback

 Seperate HDFS wire protocol data types
 --

 Key: HDFS-2181
 URL: https://issues.apache.org/jira/browse/HDFS-2181
 Project: Hadoop HDFS
  Issue Type: Improvement
Reporter: Sanjay Radia
Assignee: Sanjay Radia
 Attachments: separateDataType1.patch, separateDataType10.patch, 
 separateDataType11.patch, separateDataType12.patch, separateDataType13.patch, 
 separateDataType14.patch, separateDataType16.patch, separateDataType19.patch, 
 separateDataType2.patch, separateDataType20.patch, separateDataType6.patch, 
 separateDataType7.patch, separateDataType8.patch, separateDataType9.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2181) Seperate HDFS wire protocol data types


 [ 
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sanjay Radia updated HDFS-2181:
---

Status: Open  (was: Patch Available)

 Seperate HDFS wire protocol data types
 --

 Key: HDFS-2181
 URL: https://issues.apache.org/jira/browse/HDFS-2181
 Project: Hadoop HDFS
  Issue Type: Improvement
Reporter: Sanjay Radia
Assignee: Sanjay Radia
 Attachments: separateDataType1.patch, separateDataType10.patch, 
 separateDataType11.patch, separateDataType12.patch, separateDataType13.patch, 
 separateDataType14.patch, separateDataType16.patch, separateDataType19.patch, 
 separateDataType2.patch, separateDataType20.patch, separateDataType6.patch, 
 separateDataType7.patch, separateDataType8.patch, separateDataType9.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2181) Seperate HDFS wire protocol data types


 [ 
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sanjay Radia updated HDFS-2181:
---

Status: Patch Available  (was: Open)

 Seperate HDFS wire protocol data types
 --

 Key: HDFS-2181
 URL: https://issues.apache.org/jira/browse/HDFS-2181
 Project: Hadoop HDFS
  Issue Type: Improvement
Reporter: Sanjay Radia
Assignee: Sanjay Radia
 Attachments: separateDataType1.patch, separateDataType10.patch, 
 separateDataType11.patch, separateDataType12.patch, separateDataType13.patch, 
 separateDataType14.patch, separateDataType16.patch, separateDataType19.patch, 
 separateDataType2.patch, separateDataType20.patch, separateDataType6.patch, 
 separateDataType7.patch, separateDataType8.patch, separateDataType9.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2409) _HOST in dfs.web.authentication.kerberos.principal.

2011-10-06 Thread Tsz Wo (Nicholas), SZE (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HDFS-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122250#comment-13122250
]

Hadoop QA commented on HDFS-2409:
-

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12498039/HDFS-2409-trunk.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 2 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 core tests. The patch passed unit tests in .

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1344//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1344//console

This message is automatically generated.

_HOST in dfs.web.authentication.kerberos.principal.
---

Key: HDFS-2409
URL: https://issues.apache.org/jira/browse/HDFS-2409
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
Attachments: HDFS-2409-trunk.patch

This is HDFS part of HADOOP-7721.

[jira] [Commented] (HDFS-2294) Download of commons-daemon TAR should not be under target

2011-10-06 Thread Aaron T. Myers (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HDFS-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122269#comment-13122269
]

Aaron T. Myers commented on HDFS-2294:
--

+1, the patch looks good to me. I applied the patch, ran {{`mvn clean package
-DskipTests'}}, and confirmed that commons-daemon is now downloaded to a
directory outside of the {{target/}} directory.

Download of commons-daemon TAR should not be under target
-

Attachments: HDFS-2289.patch

[jira] [Commented] (HDFS-2404) webhdfs liststatus json response is not correct


[ 
https://issues.apache.org/jira/browse/HDFS-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122284#comment-13122284
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-2404:
--

The new trunk patch does not have the following in WebHdfsFileSystem.java
{code}
-HdfsFileStatus[].class.getSimpleName());
+HdfsFileStatus.class.getSimpleName());
{code}

 webhdfs liststatus json response is not correct
 ---

 Key: HDFS-2404
 URL: https://issues.apache.org/jira/browse/HDFS-2404
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0, 0.23.0
Reporter: Arpit Gupta
Assignee: Suresh Srinivas
 Fix For: 0.20.205.0

 Attachments: HDFS-2404.20.txt, HDFS-2404.txt, HDFS-2404.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2403) The renewer in NamenodeWebHdfsMethods.generateDelegationToken(..) is not used

2011-10-06 Thread Tsz Wo (Nicholas), SZE (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-2403:
-

Target Version/s: 0.20.205.0

 The renewer in NamenodeWebHdfsMethods.generateDelegationToken(..) is not used
 -

 Key: HDFS-2403
 URL: https://issues.apache.org/jira/browse/HDFS-2403
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
 Attachments: h2403_20111005.patch, h2403_20111005_0.20.patch


 Below are some suggestions from Suresh.
 # renewer not used in #generateDelegationToken
 # put() does not use InputStream in and should not throw URISyntaxException
 # post() does not use InputStream in and should not throw URISyntaxException
 # get() should not throw URISyntaxException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2404) webhdfs liststatus json response is not correct

2011-10-06 Thread Tsz Wo (Nicholas), SZE (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HDFS-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122286#comment-13122286
]

Hadoop QA commented on HDFS-2404:
-

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12498049/HDFS-2404.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract
org.apache.hadoop.hdfs.web.TestFSMainOperationsWebHdfs

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1345//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1345//console

This message is automatically generated.

webhdfs liststatus json response is not correct
---

Key: HDFS-2404
URL: https://issues.apache.org/jira/browse/HDFS-2404
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.20.205.0, 0.23.0
Reporter: Arpit Gupta
Assignee: Suresh Srinivas
Fix For: 0.20.205.0

Attachments: HDFS-2404.20.txt, HDFS-2404.txt, HDFS-2404.txt

[jira] [Commented] (HDFS-2409) _HOST in dfs.web.authentication.kerberos.principal.


[ 
https://issues.apache.org/jira/browse/HDFS-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122290#comment-13122290
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-2409:
--

+1 patch looks good.

 _HOST in dfs.web.authentication.kerberos.principal.
 ---

 Key: HDFS-2409
 URL: https://issues.apache.org/jira/browse/HDFS-2409
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
 Attachments: HDFS-2409-trunk.patch


 This is HDFS part of HADOOP-7721. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-28) On Namenode WebUI, sorting of the Datanode info table is not working for some of the columns in the table.

2011-10-06 Thread Michael A. Fiedler (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael A. Fiedler updated HDFS-28:
---

Affects Version/s: 0.20.2

 On Namenode WebUI, sorting of the Datanode info table is not working for some 
 of the columns in the table.
 --

 Key: HDFS-28
 URL: https://issues.apache.org/jira/browse/HDFS-28
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.2
Reporter: Suresh Srinivas

 In WebUI on Namenode, the information related to the cluster is shown. The 
 information related to the over all cluster and Datanodes is shown.
 Currently, the sorting of the table for Datanode information (done by 
 clicking the column header) for Present Capacity, Blocks and Remaining 
 columns is not working.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (HDFS-2385) Support delegation token renewal in webhdfs

2011-10-06 Thread Tsz Wo (Nicholas), SZE (Reopened) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE reopened HDFS-2385:
--


Thanks Matt for merging this to 205.

Reopen since trunk still needs a patch.

 Support delegation token renewal in webhdfs
 ---

 Key: HDFS-2385
 URL: https://issues.apache.org/jira/browse/HDFS-2385
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
 Fix For: 0.20.205.0

 Attachments: h2358_20111001_0.20s.patch, h2385_20111004_0.20s.patch, 
 h2385_20111004b_0.20s.patch, h2385_20111004b_amendment2_0.20s.patch, 
 h2385_20111004b_amendment_0.20s.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2403) The renewer in NamenodeWebHdfsMethods.generateDelegationToken(..) is not used

2011-10-06 Thread Suresh Srinivas (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122298#comment-13122298
 ] 

Suresh Srinivas commented on HDFS-2403:
---

+1 for the patch

 The renewer in NamenodeWebHdfsMethods.generateDelegationToken(..) is not used
 -

 Key: HDFS-2403
 URL: https://issues.apache.org/jira/browse/HDFS-2403
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
 Attachments: h2403_20111005.patch, h2403_20111005_0.20.patch


 Below are some suggestions from Suresh.
 # renewer not used in #generateDelegationToken
 # put() does not use InputStream in and should not throw URISyntaxException
 # post() does not use InputStream in and should not throw URISyntaxException
 # get() should not throw URISyntaxException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2393) Mark appropriate methods of ClientProtocol with the idempotent annotation

[
https://issues.apache.org/jira/browse/HDFS-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122303#comment-13122303
]

Todd Lipcon commented on HDFS-2393:
---

I agree with your assessment of the write ops. The three you weren't sure about
I think are all idempotent:
- getAdditionalDatanode just picks a datanode and doesn't modify any state.
It's probably marked WRITE since it's used by the file write path.
- If recoverLease is retried after a success, it will return an error code that
the lease is already recovered. This is already possible if the lease expires
just before the caller calls recoverLease. So callers already need to know how
to deal with that case regardless of failover/HA.
- updateBlockForPipeline will allocate a new generation stamp if it's called a
second time, but that's OK - we just need to make sure genstamps increase, not
that they increase exactly once.

As for the administrative ones:
- setSafeMode, saveNamespace, restoreFailedStorage, refreshNodes, and metaSave
are all under the scope of one NN (even in an HA setup). That is to say, they
would be targeted at a specific IP, not at a logical cluster, I believe.
- haven't thought much about upgrade yet. I don't know those code paths well.
Let's mark those TODO
- setBalancerBandwidth seems like a hack that shouldn't really be part of RPC
anyway. Let's ignore this one for now too.

Mark appropriate methods of ClientProtocol with the idempotent annotation
-

Key: HDFS-2393
URL: https://issues.apache.org/jira/browse/HDFS-2393
Project: Hadoop HDFS
Issue Type: Sub-task
Components: hdfs client
Affects Versions: HA branch (HDFS-1623)
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
Fix For: HA branch (HDFS-1623)

HDFS-1973 will make the {{DFSClient}} take advantage of the annotation. This
JIRA is to identify which methods can be marked as idempotent.

[jira] [Updated] (HDFS-2409) _HOST in dfs.web.authentication.kerberos.principal.

2011-10-06 Thread Jitendra Nath Pandey (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jitendra Nath Pandey updated HDFS-2409:
---

   Resolution: Fixed
Fix Version/s: 0.24.0
   Status: Resolved  (was: Patch Available)

Committed to trunk.

 _HOST in dfs.web.authentication.kerberos.principal.
 ---

 Key: HDFS-2409
 URL: https://issues.apache.org/jira/browse/HDFS-2409
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
 Fix For: 0.24.0

 Attachments: HDFS-2409-trunk.patch


 This is HDFS part of HADOOP-7721. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2409) _HOST in dfs.web.authentication.kerberos.principal.

2011-10-06 Thread Jitendra Nath Pandey (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jitendra Nath Pandey updated HDFS-2409:
---

Hadoop Flags: Reviewed

 _HOST in dfs.web.authentication.kerberos.principal.
 ---

 Key: HDFS-2409
 URL: https://issues.apache.org/jira/browse/HDFS-2409
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
 Fix For: 0.24.0

 Attachments: HDFS-2409-trunk.patch


 This is HDFS part of HADOOP-7721. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2181) Seperate HDFS wire protocol data types

[
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122321#comment-13122321
]

Hadoop QA commented on HDFS-2181:
-

+1 overall. Here are the results of testing the latest attachment

http://issues.apache.org/jira/secure/attachment/12498060/separateDataType20.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 core tests. The patch passed unit tests in .

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1347//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1347//console

This message is automatically generated.

Seperate HDFS wire protocol data types
--

Key: HDFS-2181
URL: https://issues.apache.org/jira/browse/HDFS-2181
Project: Hadoop HDFS
Issue Type: Improvement
Reporter: Sanjay Radia
Assignee: Sanjay Radia
Attachments: separateDataType1.patch, separateDataType10.patch,
separateDataType11.patch, separateDataType12.patch, separateDataType13.patch,
separateDataType14.patch, separateDataType16.patch, separateDataType19.patch,
separateDataType2.patch, separateDataType20.patch, separateDataType6.patch,
separateDataType7.patch, separateDataType8.patch, separateDataType9.patch

[jira] [Updated] (HDFS-2181) Separate HDFS Client wire protocol data types


 [ 
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sanjay Radia updated HDFS-2181:
---

Summary: Separate HDFS Client wire protocol data types  (was: Seperate HDFS 
wire protocol data types)

 Separate HDFS Client wire protocol data types
 -

 Key: HDFS-2181
 URL: https://issues.apache.org/jira/browse/HDFS-2181
 Project: Hadoop HDFS
  Issue Type: Improvement
Reporter: Sanjay Radia
Assignee: Sanjay Radia
 Attachments: separateDataType1.patch, separateDataType10.patch, 
 separateDataType11.patch, separateDataType12.patch, separateDataType13.patch, 
 separateDataType14.patch, separateDataType16.patch, separateDataType19.patch, 
 separateDataType2.patch, separateDataType20.patch, separateDataType6.patch, 
 separateDataType7.patch, separateDataType8.patch, separateDataType9.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2403) The renewer in NamenodeWebHdfsMethods.generateDelegationToken(..) is not used

2011-10-06 Thread Jitendra Nath Pandey (Resolved) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122327#comment-13122327
 ] 

Hudson commented on HDFS-2403:
--

Integrated in Hadoop-Mapreduce-trunk-Commit #1042 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1042/])
HDFS-2403. NamenodeWebHdfsMethods.generateDelegationToken(..) does not use 
the renewer parameter.

szetszwo : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179856
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java


 The renewer in NamenodeWebHdfsMethods.generateDelegationToken(..) is not used
 -

 Key: HDFS-2403
 URL: https://issues.apache.org/jira/browse/HDFS-2403
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
 Attachments: h2403_20111005.patch, h2403_20111005_0.20.patch


 Below are some suggestions from Suresh.
 # renewer not used in #generateDelegationToken
 # put() does not use InputStream in and should not throw URISyntaxException
 # post() does not use InputStream in and should not throw URISyntaxException
 # get() should not throw URISyntaxException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HDFS-2405) hadoop dfs command with webhdfs fails on secure hadoop


 [ 
https://issues.apache.org/jira/browse/HDFS-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jitendra Nath Pandey resolved HDFS-2405.


   Resolution: Fixed
Fix Version/s: 0.24.0
   0.20.205.0

Fixed as part of HADOOP-7721 and HDFS-2409.

 hadoop dfs command with webhdfs fails on secure hadoop
 --

 Key: HDFS-2405
 URL: https://issues.apache.org/jira/browse/HDFS-2405
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0
Reporter: Arpit Gupta
Assignee: Jitendra Nath Pandey
Priority: Critical
 Fix For: 0.20.205.0, 0.24.0




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2181) Separate HDFS Client wire protocol data types


 [ 
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sanjay Radia updated HDFS-2181:
---

Resolution: Fixed
Status: Resolved  (was: Patch Available)

 Separate HDFS Client wire protocol data types
 -

 Key: HDFS-2181
 URL: https://issues.apache.org/jira/browse/HDFS-2181
 Project: Hadoop HDFS
  Issue Type: Improvement
Reporter: Sanjay Radia
Assignee: Sanjay Radia
 Attachments: separateDataType1.patch, separateDataType10.patch, 
 separateDataType11.patch, separateDataType12.patch, separateDataType13.patch, 
 separateDataType14.patch, separateDataType16.patch, separateDataType19.patch, 
 separateDataType2.patch, separateDataType20.patch, separateDataType6.patch, 
 separateDataType7.patch, separateDataType8.patch, separateDataType9.patch




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2409) _HOST in dfs.web.authentication.kerberos.principal.


[ 
https://issues.apache.org/jira/browse/HDFS-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122346#comment-13122346
 ] 

Hudson commented on HDFS-2409:
--

Integrated in Hadoop-Mapreduce-trunk-Commit #1043 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1043/])
HDFS-2409. _HOST in dfs.web.authentication.kerberos.principal. Incorporates 
HDFS-2405 as well.

jitendra : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179861
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/AuthFilter.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserProvider.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestAuthFilter.java


 _HOST in dfs.web.authentication.kerberos.principal.
 ---

 Key: HDFS-2409
 URL: https://issues.apache.org/jira/browse/HDFS-2409
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
 Fix For: 0.24.0

 Attachments: HDFS-2409-trunk.patch


 This is HDFS part of HADOOP-7721. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2405) hadoop dfs command with webhdfs fails on secure hadoop


[ 
https://issues.apache.org/jira/browse/HDFS-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122348#comment-13122348
 ] 

Hudson commented on HDFS-2405:
--

Integrated in Hadoop-Mapreduce-trunk-Commit #1043 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1043/])
HDFS-2409. _HOST in dfs.web.authentication.kerberos.principal. Incorporates 
HDFS-2405 as well.

jitendra : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179861
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/AuthFilter.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserProvider.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestAuthFilter.java


 hadoop dfs command with webhdfs fails on secure hadoop
 --

 Key: HDFS-2405
 URL: https://issues.apache.org/jira/browse/HDFS-2405
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0
Reporter: Arpit Gupta
Assignee: Jitendra Nath Pandey
Priority: Critical
 Fix For: 0.20.205.0, 0.24.0




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2393) Mark appropriate methods of ClientProtocol with the idempotent annotation


 [ 
https://issues.apache.org/jira/browse/HDFS-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aaron T. Myers updated HDFS-2393:
-

Status: Patch Available  (was: Open)

 Mark appropriate methods of ClientProtocol with the idempotent annotation
 -

 Key: HDFS-2393
 URL: https://issues.apache.org/jira/browse/HDFS-2393
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: hdfs client
Affects Versions: HA branch (HDFS-1623)
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
 Fix For: HA branch (HDFS-1623)

 Attachments: HDFS-2393-HDFS-1623.patch


 HDFS-1973 will make the {{DFSClient}} take advantage of the annotation. This 
 JIRA is to identify which methods can be marked as idempotent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2393) Mark appropriate methods of ClientProtocol with the idempotent annotation


 [ 
https://issues.apache.org/jira/browse/HDFS-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aaron T. Myers updated HDFS-2393:
-

Attachment: HDFS-2393-HDFS-1623.patch

Thanks a lot for the review, Todd. Here's a patch which implements what we've 
discussed here.

I added three TODOs for the upgrade-related operations and the 
{{setBalancerBandwidth}} op. I agree with your analysis regarding the 
administrative ops, so I deliberately left those as non-idempotent.

 Mark appropriate methods of ClientProtocol with the idempotent annotation
 -

 Key: HDFS-2393
 URL: https://issues.apache.org/jira/browse/HDFS-2393
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: hdfs client
Affects Versions: HA branch (HDFS-1623)
Reporter: Aaron T. Myers
Assignee: Aaron T. Myers
 Fix For: HA branch (HDFS-1623)

 Attachments: HDFS-2393-HDFS-1623.patch


 HDFS-1973 will make the {{DFSClient}} take advantage of the annotation. This 
 JIRA is to identify which methods can be marked as idempotent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HDFS-2410) Further clanup hardcoded configuration keys

2011-10-06 Thread Suresh Srinivas (Created) (JIRA)

Further clanup hardcoded configuration keys
---

 Key: HDFS-2410
 URL: https://issues.apache.org/jira/browse/HDFS-2410
 Project: Hadoop HDFS
  Issue Type: Improvement
  Components: data-node, name-node, test
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Priority: Minor


HDFS code is littered with hardcoded config key names. This jira changes to use 
DFSConfigKeys constants.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2410) Further clanup hardcoded configuration keys


 [ 
https://issues.apache.org/jira/browse/HDFS-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-2410:
--

Attachment: HDFS-2410.txt

 Further clanup hardcoded configuration keys
 ---

 Key: HDFS-2410
 URL: https://issues.apache.org/jira/browse/HDFS-2410
 Project: Hadoop HDFS
  Issue Type: Improvement
  Components: data-node, name-node, test
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Priority: Minor
 Attachments: HDFS-2410.txt


 HDFS code is littered with hardcoded config key names. This jira changes to 
 use DFSConfigKeys constants.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2410) Further clanup hardcoded configuration keys


 [ 
https://issues.apache.org/jira/browse/HDFS-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-2410:
--

Status: Patch Available  (was: Open)

 Further clanup hardcoded configuration keys
 ---

 Key: HDFS-2410
 URL: https://issues.apache.org/jira/browse/HDFS-2410
 Project: Hadoop HDFS
  Issue Type: Improvement
  Components: data-node, name-node, test
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Priority: Minor
 Attachments: HDFS-2410.txt


 HDFS code is littered with hardcoded config key names. This jira changes to 
 use DFSConfigKeys constants.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2181) Separate HDFS Client wire protocol data types


[ 
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122362#comment-13122362
 ] 

Hudson commented on HDFS-2181:
--

Integrated in Hadoop-Mapreduce-trunk-Commit #1044 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1044/])
HDFS-2181 Separate HDFS Client wire protocol data types (sanjay)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179877
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsFileStatus.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlock.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolProtocolBuffers
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolProtocolBuffers/overview.html
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientDatanodeProtocolServerSideTranslatorR23.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientDatanodeProtocolTranslatorR23.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientDatanodeWireProtocol.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeProtocolServerSideTranslatorR23.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeProtocolTranslatorR23.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeWireProtocol.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ContentSummaryWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/CorruptFileBlocksWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/DatanodeIDWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/DatanodeInfoWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/DirectoryListingWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ExtendedBlockWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/FsPermissionWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/FsServerDefaultsWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/HdfsFileStatusWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/HdfsLocatedFileStatusWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/LocatedBlockWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/LocatedBlocksWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ProtocolSignatureWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/TokenWritable.java
*

[jira] [Updated] (HDFS-2403) The renewer in NamenodeWebHdfsMethods.generateDelegationToken(..) is not used

2011-10-06 Thread Matt Foley (Updated) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Foley updated HDFS-2403:
-

Target Version/s: 0.20.205.1  (was: 0.20.205.0)

 The renewer in NamenodeWebHdfsMethods.generateDelegationToken(..) is not used
 -

 Key: HDFS-2403
 URL: https://issues.apache.org/jira/browse/HDFS-2403
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
 Attachments: h2403_20111005.patch, h2403_20111005_0.20.patch


 Below are some suggestions from Suresh.
 # renewer not used in #generateDelegationToken
 # put() does not use InputStream in and should not throw URISyntaxException
 # post() does not use InputStream in and should not throw URISyntaxException
 # get() should not throw URISyntaxException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-2404) webhdfs liststatus json response is not correct

2011-10-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suresh Srinivas updated HDFS-2404:
--

Attachment: HDFS-2404.txt

Updated patch.

 webhdfs liststatus json response is not correct
 ---

 Key: HDFS-2404
 URL: https://issues.apache.org/jira/browse/HDFS-2404
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0, 0.23.0
Reporter: Arpit Gupta
Assignee: Suresh Srinivas
 Fix For: 0.20.205.0

 Attachments: HDFS-2404.20.txt, HDFS-2404.txt, HDFS-2404.txt, 
 HDFS-2404.txt




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby

[
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122380#comment-13122380
]

jirapos...@reviews.apache.org commented on HDFS-2301:
-

bq. On 2011-10-03 18:58:13, Todd Lipcon wrote:
bq. just a few nits, mostly looks good. A few questions I have that aren't
directly related to this patch:
bq. - is SafeMode now a replicated thing, or does each NN separately enter
safemode? I think the latter, right?
bq. - when transitioning between states, what happens if the enterState
fails for the new state? The state variable will then indicate it's in that
state, when in fact it's in no state at all. How do we recover from that? We
need some kind of rollback? (eg if you're in standby and try to transition to
active, but find that you can't take a lock in ZK)
bq.
bq. Suresh Srinivas wrote:
bq. is SafeMode now a replicated thing, or does each NN separately enter
safemode? I think the latter, right?
bq. Safemode is the state of namespace(FSNamesystem), unlike active,
standby which are the states of the namenode. Each NN separately enters
safemode.
bq.
bq. when transitioning between states, what happens if the enterState
fails for the new state? The state variable will then indicate it's in that
state, when in fact it's in no state at all. How do we recover from that? We
need some kind of rollback? (eg if you're in standby and try to transition to
active, but find that you can't take a lock in ZK)
bq. This is tricky. Say enterState fails to start services because of some
namenode process related issues. Then most likely rolling back to previous
state, and starting services relevant to previous states will also fail. The
particular example you are bringing up related to ZK, I think failover
controller is the one that deals with ZK and not namenode.
bq.
bq. I can think of two solutions: namenode shutsdown when this happens (as
done during startup) or move to a failed state.

Let's just add a TODO for now that we need to consider these situations in a
test plan. I imagine the most likely real scenario is that you try to do a
failover, but for some reason the standby has an IO problem trying to read the
latest logs from the primary (eg maybe the primary barfed some bad data into
the edit logs as it crashed, or maybe the primary crashed because the shared
storage caught on fire).

bq. On 2011-10-03 18:58:13, Todd Lipcon wrote:
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java,
line 464
bq. https://reviews.apache.org/r/2150/diff/1/?file=47529#file47529line464
bq.
bq. any reason that you switched the order of startHttpServer to the end
of this function? I don't think it's a big deal, but there's some possibility
the service plugins may want to do something with the http server, which
wouldn't be started yet.
bq.
bq. Suresh Srinivas wrote:
bq. No particular reason. Not sure who uses ServicePlugins. But the
description says it is RPC related. But will move it back up.

Hue currently uses service plugins to expose a Thrift interface. But with
Sanjay's recent work on protocol adapters, this may be largely unnecessary in
the future. Nonetheless, we should leave it around :)

- Todd

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2150/#review2277
---

On 2011-10-03 18:36:41, Todd Lipcon wrote:
bq.
bq. ---
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2150/
bq. ---
bq.
bq. (Updated 2011-10-03 18:36:41)
bq.
bq.
bq. Review request for hadoop-hdfs and Todd Lipcon.
bq.
bq.
bq. Summary
bq. ---
bq.
bq. Uploading Suresh's patch to reviewboard
(https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from
29/Sep/11 00:56)
bq.
bq.
bq. This addresses bug HDFS-2301.
bq. https://issues.apache.org/jira/browse/HDFS-2301
bq.
bq.
bq. Diffs
bq. -
bq.
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
1177130
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
1177130
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
1177130
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java
1177128
bq.

[jira] [Commented] (HDFS-1973) HA: HDFS clients must handle namenode failover and switch over to the new active namenode.

[
https://issues.apache.org/jira/browse/HDFS-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122381#comment-13122381
]

Hadoop QA commented on HDFS-1973:
-

+1 overall. Here are the results of testing the latest attachment

http://issues.apache.org/jira/secure/attachment/12498050/HDFS-1973-HDFS-1623.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 2 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 core tests. The patch passed unit tests in .

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1346//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1346//console

This message is automatically generated.

HA: HDFS clients must handle namenode failover and switch over to the new
active namenode.
--

[jira] [Commented] (HDFS-2403) The renewer in NamenodeWebHdfsMethods.generateDelegationToken(..) is not used


[ 
https://issues.apache.org/jira/browse/HDFS-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122386#comment-13122386
 ] 

Hudson commented on HDFS-2403:
--

Integrated in Hadoop-Hdfs-trunk-Commit #1104 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1104/])
HDFS-2403. NamenodeWebHdfsMethods.generateDelegationToken(..) does not use 
the renewer parameter.

szetszwo : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179856
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java


 The renewer in NamenodeWebHdfsMethods.generateDelegationToken(..) is not used
 -

 Key: HDFS-2403
 URL: https://issues.apache.org/jira/browse/HDFS-2403
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
 Attachments: h2403_20111005.patch, h2403_20111005_0.20.patch


 Below are some suggestions from Suresh.
 # renewer not used in #generateDelegationToken
 # put() does not use InputStream in and should not throw URISyntaxException
 # post() does not use InputStream in and should not throw URISyntaxException
 # get() should not throw URISyntaxException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2405) hadoop dfs command with webhdfs fails on secure hadoop


[ 
https://issues.apache.org/jira/browse/HDFS-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122388#comment-13122388
 ] 

Hudson commented on HDFS-2405:
--

Integrated in Hadoop-Hdfs-trunk-Commit #1104 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1104/])
HDFS-2409. _HOST in dfs.web.authentication.kerberos.principal. Incorporates 
HDFS-2405 as well.

jitendra : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179861
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/AuthFilter.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserProvider.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestAuthFilter.java


 hadoop dfs command with webhdfs fails on secure hadoop
 --

 Key: HDFS-2405
 URL: https://issues.apache.org/jira/browse/HDFS-2405
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0
Reporter: Arpit Gupta
Assignee: Jitendra Nath Pandey
Priority: Critical
 Fix For: 0.20.205.0, 0.24.0




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2409) _HOST in dfs.web.authentication.kerberos.principal.


[ 
https://issues.apache.org/jira/browse/HDFS-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122385#comment-13122385
 ] 

Hudson commented on HDFS-2409:
--

Integrated in Hadoop-Hdfs-trunk-Commit #1104 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1104/])
HDFS-2409. _HOST in dfs.web.authentication.kerberos.principal. Incorporates 
HDFS-2405 as well.

jitendra : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179861
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/AuthFilter.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserProvider.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestAuthFilter.java


 _HOST in dfs.web.authentication.kerberos.principal.
 ---

 Key: HDFS-2409
 URL: https://issues.apache.org/jira/browse/HDFS-2409
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
 Fix For: 0.24.0

 Attachments: HDFS-2409-trunk.patch


 This is HDFS part of HADOOP-7721. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2181) Separate HDFS Client wire protocol data types


[ 
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122384#comment-13122384
 ] 

Hudson commented on HDFS-2181:
--

Integrated in Hadoop-Hdfs-trunk-Commit #1104 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1104/])
HDFS-2181 Separate HDFS Client wire protocol data types (sanjay)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179877
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsFileStatus.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlock.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolProtocolBuffers
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolProtocolBuffers/overview.html
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientDatanodeProtocolServerSideTranslatorR23.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientDatanodeProtocolTranslatorR23.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientDatanodeWireProtocol.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeProtocolServerSideTranslatorR23.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeProtocolTranslatorR23.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeWireProtocol.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ContentSummaryWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/CorruptFileBlocksWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/DatanodeIDWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/DatanodeInfoWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/DirectoryListingWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ExtendedBlockWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/FsPermissionWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/FsServerDefaultsWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/HdfsFileStatusWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/HdfsLocatedFileStatusWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/LocatedBlockWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/LocatedBlocksWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ProtocolSignatureWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/TokenWritable.java
*

[jira] [Commented] (HDFS-2409) _HOST in dfs.web.authentication.kerberos.principal.


[ 
https://issues.apache.org/jira/browse/HDFS-2409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122392#comment-13122392
 ] 

Hudson commented on HDFS-2409:
--

Integrated in Hadoop-Common-trunk-Commit #1026 (See 
[https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1026/])
HDFS-2409. _HOST in dfs.web.authentication.kerberos.principal. Incorporates 
HDFS-2405 as well.

jitendra : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179861
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/AuthFilter.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserProvider.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestAuthFilter.java


 _HOST in dfs.web.authentication.kerberos.principal.
 ---

 Key: HDFS-2409
 URL: https://issues.apache.org/jira/browse/HDFS-2409
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
 Fix For: 0.24.0

 Attachments: HDFS-2409-trunk.patch


 This is HDFS part of HADOOP-7721. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2405) hadoop dfs command with webhdfs fails on secure hadoop


[ 
https://issues.apache.org/jira/browse/HDFS-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122395#comment-13122395
 ] 

Hudson commented on HDFS-2405:
--

Integrated in Hadoop-Common-trunk-Commit #1026 (See 
[https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1026/])
HDFS-2409. _HOST in dfs.web.authentication.kerberos.principal. Incorporates 
HDFS-2405 as well.

jitendra : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179861
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/AuthFilter.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/UserProvider.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestAuthFilter.java


 hadoop dfs command with webhdfs fails on secure hadoop
 --

 Key: HDFS-2405
 URL: https://issues.apache.org/jira/browse/HDFS-2405
 Project: Hadoop HDFS
  Issue Type: Bug
Affects Versions: 0.20.205.0
Reporter: Arpit Gupta
Assignee: Jitendra Nath Pandey
Priority: Critical
 Fix For: 0.20.205.0, 0.24.0




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2181) Separate HDFS Client wire protocol data types


[ 
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122391#comment-13122391
 ] 

Hudson commented on HDFS-2181:
--

Integrated in Hadoop-Common-trunk-Commit #1026 (See 
[https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1026/])
HDFS-2181 Separate HDFS Client wire protocol data types (sanjay)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179877
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsFileStatus.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlock.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolProtocolBuffers
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolProtocolBuffers/overview.html
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientDatanodeProtocolServerSideTranslatorR23.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientDatanodeProtocolTranslatorR23.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientDatanodeWireProtocol.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeProtocolServerSideTranslatorR23.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeProtocolTranslatorR23.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ClientNamenodeWireProtocol.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ContentSummaryWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/CorruptFileBlocksWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/DatanodeIDWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/DatanodeInfoWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/DirectoryListingWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ExtendedBlockWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/FsPermissionWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/FsServerDefaultsWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/HdfsFileStatusWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/HdfsLocatedFileStatusWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/LocatedBlockWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/LocatedBlocksWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/ProtocolSignatureWritable.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolR23Compatible/TokenWritable.java
*

[jira] [Commented] (HDFS-2403) The renewer in NamenodeWebHdfsMethods.generateDelegationToken(..) is not used


[ 
https://issues.apache.org/jira/browse/HDFS-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122393#comment-13122393
 ] 

Hudson commented on HDFS-2403:
--

Integrated in Hadoop-Common-trunk-Commit #1026 (See 
[https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1026/])
HDFS-2403. NamenodeWebHdfsMethods.generateDelegationToken(..) does not use 
the renewer parameter.

szetszwo : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179856
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java


 The renewer in NamenodeWebHdfsMethods.generateDelegationToken(..) is not used
 -

 Key: HDFS-2403
 URL: https://issues.apache.org/jira/browse/HDFS-2403
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
 Attachments: h2403_20111005.patch, h2403_20111005_0.20.patch


 Below are some suggestions from Suresh.
 # renewer not used in #generateDelegationToken
 # put() does not use InputStream in and should not throw URISyntaxException
 # post() does not use InputStream in and should not throw URISyntaxException
 # get() should not throw URISyntaxException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1973) HA: HDFS clients must handle namenode failover and switch over to the new active namenode.

2011-10-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HDFS-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122403#comment-13122403
 ] 

Todd Lipcon commented on HDFS-1973:
---

+1 lgtm

 HA: HDFS clients must handle namenode failover and switch over to the new 
 active namenode.
 --

 Key: HDFS-1973
 URL: https://issues.apache.org/jira/browse/HDFS-1973
 Project: Hadoop HDFS
  Issue Type: Sub-task
Reporter: Suresh Srinivas
Assignee: Aaron T. Myers
 Attachments: HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch, 
 HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch, 
 HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch, 
 HDFS-1973-HDFS-1623.patch, hdfs-1973.0.patch


 During failover, a client must detect the current active namenode failure and 
 switch over to the new active namenode. The switch over might make use of IP 
 failover or some thing more elaborate such as zookeeper to discover the new 
 active.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2294) Download of commons-daemon TAR should not be under target

2011-10-06 Thread Alejandro Abdelnur (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HDFS-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122405#comment-13122405
]

Alejandro Abdelnur commented on HDFS-2294:
--

committed to trunk, in a few days it will be committed to 0.23 in a combo with
other maven related patches.

Download of commons-daemon TAR should not be under target
-

Attachments: HDFS-2289.patch

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby


[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122406#comment-13122406
 ] 

jirapos...@reviews.apache.org commented on HDFS-2301:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2150/
---

(Updated 2011-10-06 23:25:18.391776)


Review request for hadoop-hdfs and Todd Lipcon.


Changes
---

updating reviewboard patch to Suresh's new revision


Summary
---

Uploading Suresh's patch to reviewboard 
(https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from 
29/Sep/11 00:56)


This addresses bug HDFS-2301.
https://issues.apache.org/jira/browse/HDFS-2301


Diffs (updated)
-

  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
 PRE-CREATION 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
 1179521 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
 1179521 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
 1179521 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java
 1179521 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAContext.java
 PRE-CREATION 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAState.java
 1179521 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyState.java
 1179521 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHAUtil.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/2150/diff


Testing
---


Thanks,

Todd



 Start/stop appropriate namenode internal services during transition to active 
 and standby
 -

 Key: HDFS-2301
 URL: https://issues.apache.org/jira/browse/HDFS-2301
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: name-node
Affects Versions: HA branch (HDFS-1623)
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
 Fix For: HA branch (HDFS-1623)

 Attachments: HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt, 
 HDFS-2301.txt


 These changes are related to HDFS-1974 which introduced active and standby 
 states. This jira will address starting and stopping appropriate NN services 
 when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-1973) HA: HDFS clients must handle namenode failover and switch over to the new active namenode.

[
https://issues.apache.org/jira/browse/HDFS-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Aaron T. Myers updated HDFS-1973:
-

Resolution: Fixed
Fix Version/s: HA branch (HDFS-1623)
Target Version/s: HA branch (HDFS-1623)
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)

Thanks a lot for the several reviews, Todd. I've just committed this to the HA
branch.

HA: HDFS clients must handle namenode failover and switch over to the new
active namenode.
--

Key: HDFS-1973
URL: https://issues.apache.org/jira/browse/HDFS-1973
Project: Hadoop HDFS
Issue Type: Sub-task
Affects Versions: HA branch (HDFS-1623)
Reporter: Suresh Srinivas
Assignee: Aaron T. Myers
Fix For: HA branch (HDFS-1623)

Attachments: HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch,
HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch,
HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch,
HDFS-1973-HDFS-1623.patch, hdfs-1973.0.patch

[jira] [Updated] (HDFS-1973) HA: HDFS clients must handle namenode failover and switch over to the new active namenode.

2011-10-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


 [ 
https://issues.apache.org/jira/browse/HDFS-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aaron T. Myers updated HDFS-1973:
-

Affects Version/s: HA branch (HDFS-1623)

 HA: HDFS clients must handle namenode failover and switch over to the new 
 active namenode.
 --

 Key: HDFS-1973
 URL: https://issues.apache.org/jira/browse/HDFS-1973
 Project: Hadoop HDFS
  Issue Type: Sub-task
Affects Versions: HA branch (HDFS-1623)
Reporter: Suresh Srinivas
Assignee: Aaron T. Myers
 Fix For: HA branch (HDFS-1623)

 Attachments: HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch, 
 HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch, 
 HDFS-1973-HDFS-1623.patch, HDFS-1973-HDFS-1623.patch, 
 HDFS-1973-HDFS-1623.patch, hdfs-1973.0.patch


 During failover, a client must detect the current active namenode failure and 
 switch over to the new active namenode. The switch over might make use of IP 
 failover or some thing more elaborate such as zookeeper to discover the new 
 active.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby


[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122416#comment-13122416
 ] 

jirapos...@reviews.apache.org commented on HDFS-2301:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2150/#review2422
---



branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
https://reviews.apache.org/r/2150/#comment5514

perhaps should be abstract since it won't ever be instantiated?

these functions are meant only for the server side, right? Otherwise they 
should all take an authority, and look at configs prefixed/suffixed with that 
authority?

let me jump over to HDFS-2231 and try to review that first.. having a hard 
time following this.



branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
https://reviews.apache.org/r/2150/#comment5515

!collection.isEmpty()



branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
https://reviews.apache.org/r/2150/#comment5516

long line



branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
https://reviews.apache.org/r/2150/#comment5518

strange formatting



branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
https://reviews.apache.org/r/2150/#comment5517

so this patch now depends on HDFS-2231 (Conf changes for HA NN), right?


- Todd


On 2011-10-06 23:25:18, Todd Lipcon wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2150/
bq.  ---
bq.  
bq.  (Updated 2011-10-06 23:25:18)
bq.  
bq.  
bq.  Review request for hadoop-hdfs and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Uploading Suresh's patch to reviewboard 
(https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from 
29/Sep/11 00:56)
bq.  
bq.  
bq.  This addresses bug HDFS-2301.
bq.  https://issues.apache.org/jira/browse/HDFS-2301
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
 PRE-CREATION 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAContext.java
 PRE-CREATION 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAState.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyState.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHAUtil.java
 PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/2150/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Todd
bq.  
bq.



 Start/stop appropriate namenode internal services during transition to active 
 and standby
 -

 Key: HDFS-2301
 URL: https://issues.apache.org/jira/browse/HDFS-2301
 Project: Hadoop HDFS
  Issue Type: Sub-task
  Components: name-node
Affects Versions: HA branch (HDFS-1623)
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
 Fix For: HA branch (HDFS-1623)

 Attachments: HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt, 
 HDFS-2301.txt


 These changes are related to HDFS-1974 which introduced active and standby 
 states. This jira will address starting and stopping appropriate NN services 
 when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see:

[jira] [Commented] (HDFS-2294) Download of commons-daemon TAR should not be under target


[ 
https://issues.apache.org/jira/browse/HDFS-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122419#comment-13122419
 ] 

Hudson commented on HDFS-2294:
--

Integrated in Hadoop-Mapreduce-trunk-Commit #1045 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1045/])
HDFS-2294. Download of commons-daemon TAR should not be under target (tucu)

tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179894
Files : 
* /hadoop/common/trunk/.gitignore
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml


 Download of commons-daemon TAR should not be under target
 -

 Key: HDFS-2294
 URL: https://issues.apache.org/jira/browse/HDFS-2294
 Project: Hadoop HDFS
  Issue Type: Improvement
  Components: build
Affects Versions: 0.23.0, 0.24.0
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
 Fix For: 0.23.0, 0.24.0

 Attachments: HDFS-2289.patch


 Committed HDFS-2289 downloads commons-daemon TAR in the hadoop-hdfs/target/, 
 earlier patches for HDFS-2289 were using hadoop-hdfs/download/ as the 
 location for the download.
 The motivation not to use the 'target/' directory is that on every clean 
 build the TAR will be downloaded from Apache archives. Using a 'download' 
 directory this happens once per workspace.
 The patch was also adding the 'download/' directory to the .gitignore file 
 (it should also be svn ignored).
 Besides downloading it only once, it allows to do a clean build in 
 disconnected mode.
 IMO, the later is a nice developer capability.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2410) Further clanup hardcoded configuration keys

[
https://issues.apache.org/jira/browse/HDFS-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122437#comment-13122437
]

Hadoop QA commented on HDFS-2410:
-

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12498082/HDFS-2410.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 156 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 core tests. The patch passed unit tests in .

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1348//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1348//console

This message is automatically generated.

Further clanup hardcoded configuration keys
---

Key: HDFS-2410
URL: https://issues.apache.org/jira/browse/HDFS-2410
Project: Hadoop HDFS
Issue Type: Improvement
Components: data-node, name-node, test
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Priority: Minor
Attachments: HDFS-2410.txt

HDFS code is littered with hardcoded config key names. This jira changes to
use DFSConfigKeys constants.

[jira] [Commented] (HDFS-2404) webhdfs liststatus json response is not correct

[
https://issues.apache.org/jira/browse/HDFS-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122440#comment-13122440
]

Hadoop QA commented on HDFS-2404:
-

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12498085/HDFS-2404.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 core tests. The patch passed unit tests in .

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1349//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1349//console

This message is automatically generated.

webhdfs liststatus json response is not correct
---

Attachments: HDFS-2404.20.txt, HDFS-2404.txt, HDFS-2404.txt,
HDFS-2404.txt

[jira] [Commented] (HDFS-2294) Download of commons-daemon TAR should not be under target


[ 
https://issues.apache.org/jira/browse/HDFS-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122442#comment-13122442
 ] 

Hudson commented on HDFS-2294:
--

Integrated in Hadoop-Common-trunk-Commit #1027 (See 
[https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1027/])
HDFS-2294. Download of commons-daemon TAR should not be under target (tucu)

tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179894
Files : 
* /hadoop/common/trunk/.gitignore
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml


 Download of commons-daemon TAR should not be under target
 -

 Key: HDFS-2294
 URL: https://issues.apache.org/jira/browse/HDFS-2294
 Project: Hadoop HDFS
  Issue Type: Improvement
  Components: build
Affects Versions: 0.23.0, 0.24.0
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
 Fix For: 0.23.0, 0.24.0

 Attachments: HDFS-2289.patch


 Committed HDFS-2289 downloads commons-daemon TAR in the hadoop-hdfs/target/, 
 earlier patches for HDFS-2289 were using hadoop-hdfs/download/ as the 
 location for the download.
 The motivation not to use the 'target/' directory is that on every clean 
 build the TAR will be downloaded from Apache archives. Using a 'download' 
 directory this happens once per workspace.
 The patch was also adding the 'download/' directory to the .gitignore file 
 (it should also be svn ignored).
 Besides downloading it only once, it allows to do a clean build in 
 disconnected mode.
 IMO, the later is a nice developer capability.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2294) Download of commons-daemon TAR should not be under target


[ 
https://issues.apache.org/jira/browse/HDFS-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122444#comment-13122444
 ] 

Hudson commented on HDFS-2294:
--

Integrated in Hadoop-Hdfs-trunk-Commit #1105 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1105/])
HDFS-2294. Download of commons-daemon TAR should not be under target (tucu)

tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1179894
Files : 
* /hadoop/common/trunk/.gitignore
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml


 Download of commons-daemon TAR should not be under target
 -

 Key: HDFS-2294
 URL: https://issues.apache.org/jira/browse/HDFS-2294
 Project: Hadoop HDFS
  Issue Type: Improvement
  Components: build
Affects Versions: 0.23.0, 0.24.0
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
 Fix For: 0.23.0, 0.24.0

 Attachments: HDFS-2289.patch


 Committed HDFS-2289 downloads commons-daemon TAR in the hadoop-hdfs/target/, 
 earlier patches for HDFS-2289 were using hadoop-hdfs/download/ as the 
 location for the download.
 The motivation not to use the 'target/' directory is that on every clean 
 build the TAR will be downloaded from Apache archives. Using a 'download' 
 directory this happens once per workspace.
 The patch was also adding the 'download/' directory to the .gitignore file 
 (it should also be svn ignored).
 Besides downloading it only once, it allows to do a clean build in 
 disconnected mode.
 IMO, the later is a nice developer capability.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2393) Mark appropriate methods of ClientProtocol with the idempotent annotation