[jira] [Commented] (HDFS-17261) RBF: Fix getFileInfo return wrong path when get mountTable path which multi-level
[
https://issues.apache.org/jira/browse/HDFS-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788955#comment-17788955
]
ASF GitHub Bot commented on HDFS-17261:
---
LiuGuH commented on code in PR #6288:
URL: https://github.com/apache/hadoop/pull/6288#discussion_r1402864449
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##
@@ -2188,11 +2188,12 @@ private static FsPermission getParentPermission(final
FsPermission mask) {
* @param name Name of the mount point.
* @param childrenNum Number of children.
* @param date Map with the dates.
+ * @param setPath if true should set path in HdfsFileStatus
* @return New HDFS file status representing a mount point.
*/
@VisibleForTesting
HdfsFileStatus getMountPointStatus(
- String name, int childrenNum, long date) {
+ String name, int childrenNum, long date, boolean setPath) {
Review Comment:
Sorry , I don't understand how to implements it without add a boolean
argument in getMountPointStatus(). Any example for this,Thanks
> RBF: Fix getFileInfo return wrong path when get mountTable path which
> multi-level
> -
>
> Key: HDFS-17261
> URL: https://issues.apache.org/jira/browse/HDFS-17261
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: liuguanghua
>Priority: Minor
> Labels: pull-request-available
>
> With DFSRouter, Suppose there are two nameservices ： ns0，ns1
> # Add mountTable /testgetfileinfo/ns1/dir -> (ns1 ->
> /testgetfileinfo/ns1/dir)
> # hdfs client via DFSRouter accesses a directory： hdfs dfs -ls -d
> /testgetfileinfo
> # it will return worng path : /testgetfileinfo/testgetfileinfo
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17261) RBF: Fix getFileInfo return wrong path when get mountTable path which multi-level
[
https://issues.apache.org/jira/browse/HDFS-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788954#comment-17788954
]
ASF GitHub Bot commented on HDFS-17261:
---
LiuGuH commented on code in PR #6288:
URL: https://github.com/apache/hadoop/pull/6288#discussion_r1402864449
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##
@@ -2188,11 +2188,12 @@ private static FsPermission getParentPermission(final
FsPermission mask) {
* @param name Name of the mount point.
* @param childrenNum Number of children.
* @param date Map with the dates.
+ * @param setPath if true should set path in HdfsFileStatus
* @return New HDFS file status representing a mount point.
*/
@VisibleForTesting
HdfsFileStatus getMountPointStatus(
- String name, int childrenNum, long date) {
+ String name, int childrenNum, long date, boolean setPath) {
Review Comment:
I don't understand how to implements it without add a boolean argument in
getMountPointStatus().
> RBF: Fix getFileInfo return wrong path when get mountTable path which
> multi-level
> -
>
> Key: HDFS-17261
> URL: https://issues.apache.org/jira/browse/HDFS-17261
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: liuguanghua
>Priority: Minor
> Labels: pull-request-available
>
> With DFSRouter, Suppose there are two nameservices ： ns0，ns1
> # Add mountTable /testgetfileinfo/ns1/dir -> (ns1 ->
> /testgetfileinfo/ns1/dir)
> # hdfs client via DFSRouter accesses a directory： hdfs dfs -ls -d
> /testgetfileinfo
> # it will return worng path : /testgetfileinfo/testgetfileinfo
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17263) RBF: Fix client ls trash path cannot get except default nameservices trash path
[
https://issues.apache.org/jira/browse/HDFS-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788951#comment-17788951
]
ASF GitHub Bot commented on HDFS-17263:
---
LiuGuH commented on code in PR #6291:
URL: https://github.com/apache/hadoop/pull/6291#discussion_r1402860528
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java:
##
@@ -357,7 +357,7 @@ public void refreshEntries(final Collection
entries) {
@VisibleForTesting
public static boolean isTrashPath(String path) throws IOException {
Pattern pattern = Pattern.compile(
-"^" + getTrashRoot() + TRASH_PATTERN + "/");
+"^" + getTrashRoot() + TRASH_PATTERN);
Review Comment:
Fox example , If we don't remove / , client executes command: ls
/user/*/.Trash/Current, it will only return the defalut nameservice trash
path.
The test case is in
org.apache.hadoop.hdfs.server.federation.router.TestRouterTrash#testMultipleMountPoint
,
` FileStatus[] fileStatuses = fs.listStatus(new
Path("/user/test-trash/.Trash/Current/"));
assertEquals(3, fileStatuses.length);`
If we don't remove / , fileStatuses.length will be 1.
Thanks.
> RBF: Fix client ls trash path cannot get except default nameservices trash
> path
> ---
>
> Key: HDFS-17263
> URL: https://issues.apache.org/jira/browse/HDFS-17263
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: liuguanghua
>Priority: Major
> Labels: pull-request-available
>
> With HDFS-16024, we can rename data to the Trash should be based on src
> locations. That is great for my useage. After a period of use, I found this
> cause a issue.
> There are two nameservices ns0 ns1, and ns0 is the default nameservice.
> (1) Add moutTable
> /home/data -> (ns0, /home/data)
> /data1/test1 -> (ns1, /data1/test1 )
> /data2/test2 -> (ns1, /data2/test2 )
> (2)mv file to trash
> ns0: /user/test-user/.Trash/Current/home/data/file1
> ns1: /user/test-user/.Trash/Current/data1/test1/file1
> (3) client via DFSRouter ls will not see
> /user/test-user/.Trash/Current/data1
> (4) client ls /user/test-user/.Trash/Current/data2/test2 will return
> exception .
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17262) Transfer rate metric warning log is too verbose
[ https://issues.apache.org/jira/browse/HDFS-17262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788918#comment-17788918 ] ASF GitHub Bot commented on HDFS-17262: --- xinglin commented on PR #6290: URL: https://github.com/apache/hadoop/pull/6290#issuecomment-1823610335 TestDirectoryScanner unit test is failing non-deterministically (For example, it happened in https://github.com/apache/hadoop/pull/6266 as well). Besides, we did not touch anything specific to hdfs. It shouldn't be a concern for this PR. @goiri / @ZanderXu / @bbeaudreault can you give a look? > Transfer rate metric warning log is too verbose > --- > > Key: HDFS-17262 > URL: https://issues.apache.org/jira/browse/HDFS-17262 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Bryan Beaudreault >Assignee: Xing Lin >Priority: Major > Labels: pull-request-available > > HDFS-16917 added a LOG.warn when passed duration is 0. The unit for duration > is millis, and its very possible for a read to take less than a millisecond > when considering local TCP connection. We are seeing this spam multiple times > per millisecond. There's another report on the PR for HDFS-16917. > Please downgrade to debug or remove the log -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17262) Transfer rate metric warning log is too verbose
[
https://issues.apache.org/jira/browse/HDFS-17262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788907#comment-17788907
]
ASF GitHub Bot commented on HDFS-17262:
---
hadoop-yetus commented on PR #6290:
URL: https://github.com/apache/hadoop/pull/6290#issuecomment-1823534623
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 19s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 32m 26s | | trunk passed |
| +1 :green_heart: | compile | 0m 44s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 0m 38s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | checkstyle | 0m 36s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 45s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 41s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 1m 6s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 1m 42s | | trunk passed |
| +1 :green_heart: | shadedclient | 20m 13s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 38s | | the patch passed |
| +1 :green_heart: | compile | 0m 35s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 0m 35s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 29s | |
hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 126 unchanged - 2
fixed = 126 total (was 128) |
| +1 :green_heart: | mvnsite | 0m 35s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 32s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 58s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 1m 42s | | the patch passed |
| +1 :green_heart: | shadedclient | 20m 17s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 185m 24s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6290/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 27s | | The patch does not
generate ASF License warnings. |
| | | 271m 46s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.hdfs.server.datanode.TestDirectoryScanner |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6290/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6290 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 395ae33fbf1a 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2
15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 2dcde2dd7553b27e13d42c3322181b54f3a7f2bf |
| Default Java | Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6290/2/testReport/ |
| Max. process+thread count | 3886 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoo
[jira] [Commented] (HDFS-17261) RBF: Fix getFileInfo return wrong path when get mountTable path which multi-level
[
https://issues.apache.org/jira/browse/HDFS-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788870#comment-17788870
]
ASF GitHub Bot commented on HDFS-17261:
---
goiri commented on code in PR #6288:
URL: https://github.com/apache/hadoop/pull/6288#discussion_r1402611938
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##
@@ -2188,11 +2188,12 @@ private static FsPermission getParentPermission(final
FsPermission mask) {
* @param name Name of the mount point.
* @param childrenNum Number of children.
* @param date Map with the dates.
+ * @param setPath if true should set path in HdfsFileStatus
* @return New HDFS file status representing a mount point.
*/
@VisibleForTesting
HdfsFileStatus getMountPointStatus(
- String name, int childrenNum, long date) {
+ String name, int childrenNum, long date, boolean setPath) {
Review Comment:
We should leave false or true as default.
> RBF: Fix getFileInfo return wrong path when get mountTable path which
> multi-level
> -
>
> Key: HDFS-17261
> URL: https://issues.apache.org/jira/browse/HDFS-17261
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: liuguanghua
>Priority: Minor
> Labels: pull-request-available
>
> With DFSRouter, Suppose there are two nameservices ： ns0，ns1
> # Add mountTable /testgetfileinfo/ns1/dir -> (ns1 ->
> /testgetfileinfo/ns1/dir)
> # hdfs client via DFSRouter accesses a directory： hdfs dfs -ls -d
> /testgetfileinfo
> # it will return worng path : /testgetfileinfo/testgetfileinfo
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-17263) RBF: Fix client ls trash path cannot get except default nameservices trash path
[ https://issues.apache.org/jira/browse/HDFS-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Íñigo Goiri updated HDFS-17263: --- Summary: RBF: Fix client ls trash path cannot get except default nameservices trash path (was: [RBF] Fix client ls trash path cannot get except default nameservices trash path) > RBF: Fix client ls trash path cannot get except default nameservices trash > path > --- > > Key: HDFS-17263 > URL: https://issues.apache.org/jira/browse/HDFS-17263 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: liuguanghua >Priority: Major > Labels: pull-request-available > > With HDFS-16024, we can rename data to the Trash should be based on src > locations. That is great for my useage. After a period of use, I found this > cause a issue. > There are two nameservices ns0 ns1, and ns0 is the default nameservice. > (1) Add moutTable > /home/data -> (ns0, /home/data) > /data1/test1 -> (ns1, /data1/test1 ) > /data2/test2 -> (ns1, /data2/test2 ) > (2)mv file to trash > ns0: /user/test-user/.Trash/Current/home/data/file1 > ns1: /user/test-user/.Trash/Current/data1/test1/file1 > (3) client via DFSRouter ls will not see > /user/test-user/.Trash/Current/data1 > (4) client ls /user/test-user/.Trash/Current/data2/test2 will return > exception . > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-17261) RBF: Fix getFileInfo return wrong path when get mountTable path which multi-level
[ https://issues.apache.org/jira/browse/HDFS-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Íñigo Goiri updated HDFS-17261: --- Summary: RBF: Fix getFileInfo return wrong path when get mountTable path which multi-level (was: Fix getFileInfo return wrong path when get mountTable path which multi-level) > RBF: Fix getFileInfo return wrong path when get mountTable path which > multi-level > - > > Key: HDFS-17261 > URL: https://issues.apache.org/jira/browse/HDFS-17261 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: liuguanghua >Priority: Minor > Labels: pull-request-available > > With DFSRouter, Suppose there are two nameservices ： ns0，ns1 > # Add mountTable /testgetfileinfo/ns1/dir -> (ns1 -> > /testgetfileinfo/ns1/dir) > # hdfs client via DFSRouter accesses a directory： hdfs dfs -ls -d > /testgetfileinfo > # it will return worng path : /testgetfileinfo/testgetfileinfo > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Created] (HDFS-17264) GetJournalEditServlet should check requestor principal against NameNode principal pattern
Charles Connell created HDFS-17264: -- Summary: GetJournalEditServlet should check requestor principal against NameNode principal pattern Key: HDFS-17264 URL: https://issues.apache.org/jira/browse/HDFS-17264 Project: Hadoop HDFS Issue Type: Improvement Components: journal-node Reporter: Charles Connell At my employer (HubSpot), we found it difficult to provide our JournalNodes with configurations that enumerate the exact principals that their counterpart NameNodes will have. Many situations in Hadoop that check requestor principal names allow a glob pattern so that exact names do not need to be known ahead of time. We applied [a similar logic|https://github.com/HubSpot/hadoop/pull/20/] in GetJournalEditServlet successfully. I'd like to contribute this change upstream. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17263) [RBF] Fix client ls trash path cannot get except default nameservices trash path
[
https://issues.apache.org/jira/browse/HDFS-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788735#comment-17788735
]
ASF GitHub Bot commented on HDFS-17263:
---
slfan1989 commented on code in PR #6291:
URL: https://github.com/apache/hadoop/pull/6291#discussion_r1401902539
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java:
##
@@ -357,7 +357,7 @@ public void refreshEntries(final Collection
entries) {
@VisibleForTesting
public static boolean isTrashPath(String path) throws IOException {
Pattern pattern = Pattern.compile(
-"^" + getTrashRoot() + TRASH_PATTERN + "/");
+"^" + getTrashRoot() + TRASH_PATTERN);
Review Comment:
Why do we need to remove `/` ?
> [RBF] Fix client ls trash path cannot get except default nameservices trash
> path
>
>
> Key: HDFS-17263
> URL: https://issues.apache.org/jira/browse/HDFS-17263
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: liuguanghua
>Priority: Major
> Labels: pull-request-available
>
> With HDFS-16024, we can rename data to the Trash should be based on src
> locations. That is great for my useage. After a period of use, I found this
> cause a issue.
> There are two nameservices ns0 ns1, and ns0 is the default nameservice.
> (1) Add moutTable
> /home/data -> (ns0, /home/data)
> /data1/test1 -> (ns1, /data1/test1 )
> /data2/test2 -> (ns1, /data2/test2 )
> (2)mv file to trash
> ns0: /user/test-user/.Trash/Current/home/data/file1
> ns1: /user/test-user/.Trash/Current/data1/test1/file1
> (3) client via DFSRouter ls will not see
> /user/test-user/.Trash/Current/data1
> (4) client ls /user/test-user/.Trash/Current/data2/test2 will return
> exception .
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17233) The conf dfs.datanode.lifeline.interval.seconds is not considering time unit seconds
[
https://issues.apache.org/jira/browse/HDFS-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788713#comment-17788713
]
ASF GitHub Bot commented on HDFS-17233:
---
eshwitha commented on PR #6286:
URL: https://github.com/apache/hadoop/pull/6286#issuecomment-1822495298
The above failure tests are not related to the changes made.
They are passing in my local environment.
> The conf dfs.datanode.lifeline.interval.seconds is not considering time unit
> seconds
>
>
> Key: HDFS-17233
> URL: https://issues.apache.org/jira/browse/HDFS-17233
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
>Reporter: Hemanth Boyina
>Assignee: Palakur Eshwitha Sai
>Priority: Major
> Labels: pull-request-available
>
> {code:java}
> long confLifelineIntervalMs =
> getConf().getLong(DFS_DATANODE_LIFELINE_INTERVAL_SECONDS_KEY,
> 3 * getConf().getTimeDuration(DFS_HEARTBEAT_INTERVAL_KEY,
> DFS_HEARTBEAT_INTERVAL_DEFAULT, TimeUnit.SECONDS,
> TimeUnit.MILLISECONDS)); {code}
> if we configure DFS_DATANODE_LIFELINE_INTERVAL_SECONDS_KEY, the value is not
> converting to Ms.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17263) [RBF] Fix client ls trash path cannot get except default nameservices trash path
[
https://issues.apache.org/jira/browse/HDFS-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788696#comment-17788696
]
ASF GitHub Bot commented on HDFS-17263:
---
hadoop-yetus commented on PR #6291:
URL: https://github.com/apache/hadoop/pull/6291#issuecomment-1822446504
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 20s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 31m 24s | | trunk passed |
| +1 :green_heart: | compile | 0m 22s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | compile | 0m 19s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | checkstyle | 0m 18s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 28s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 27s | | trunk passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 18s | | trunk passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 0m 49s | | trunk passed |
| +1 :green_heart: | shadedclient | 19m 18s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 17s | | the patch passed |
| +1 :green_heart: | compile | 0m 19s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javac | 0m 19s | | the patch passed |
| +1 :green_heart: | compile | 0m 18s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | javac | 0m 18s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 12s |
[/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6291/1/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt)
| hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 2 new + 3
unchanged - 0 fixed = 5 total (was 3) |
| +1 :green_heart: | mvnsite | 0m 19s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 17s | | the patch passed with JDK
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 |
| +1 :green_heart: | javadoc | 0m 17s | | the patch passed with JDK
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| +1 :green_heart: | spotbugs | 0m 50s | | the patch passed |
| +1 :green_heart: | shadedclient | 19m 31s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 19m 6s | | hadoop-hdfs-rbf in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 23s | | The patch does not
generate ASF License warnings. |
| | | 97m 58s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6291/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/6291 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 9a3dae1b6386 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2
15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / aee72cfd8bdcf3374e22db26606a4b32320668cd |
| Default Java | Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_382-8u382-ga-1~20.04.1-b05 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6291/1/testReport/ |
| Max. process+thread count | 2613 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U:
hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output |
https://ci-hadoop.ap
[jira] [Commented] (HDFS-17263) [RBF] Fix client ls trash path cannot get except default nameservices trash path
[ https://issues.apache.org/jira/browse/HDFS-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788670#comment-17788670 ] ASF GitHub Bot commented on HDFS-17263: --- LiuGuH commented on PR #6291: URL: https://github.com/apache/hadoop/pull/6291#issuecomment-1822312358 @zhuxiangyi @ferhui @goiri ， Do you have time to review this？ Thanks > [RBF] Fix client ls trash path cannot get except default nameservices trash > path > > > Key: HDFS-17263 > URL: https://issues.apache.org/jira/browse/HDFS-17263 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: liuguanghua >Priority: Major > Labels: pull-request-available > > With HDFS-16024, we can rename data to the Trash should be based on src > locations. That is great for my useage. After a period of use, I found this > cause a issue. > There are two nameservices ns0 ns1, and ns0 is the default nameservice. > (1) Add moutTable > /home/data -> (ns0, /home/data) > /data1/test1 -> (ns1, /data1/test1 ) > /data2/test2 -> (ns1, /data2/test2 ) > (2)mv file to trash > ns0: /user/test-user/.Trash/Current/home/data/file1 > ns1: /user/test-user/.Trash/Current/data1/test1/file1 > (3) client via DFSRouter ls will not see > /user/test-user/.Trash/Current/data1 > (4) client ls /user/test-user/.Trash/Current/data2/test2 will return > exception . > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-17263) [RBF] Fix client ls trash path cannot get except default nameservices trash path
[ https://issues.apache.org/jira/browse/HDFS-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788668#comment-17788668 ] ASF GitHub Bot commented on HDFS-17263: --- LiuGuH opened a new pull request, #6291: URL: https://github.com/apache/hadoop/pull/6291 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17263 > [RBF] Fix client ls trash path cannot get except default nameservices trash > path > > > Key: HDFS-17263 > URL: https://issues.apache.org/jira/browse/HDFS-17263 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: liuguanghua >Priority: Major > > With HDFS-16024, we can rename data to the Trash should be based on src > locations. That is great for my useage. After a period of use, I found this > cause a issue. > There are two nameservices ns0 ns1, and ns0 is the default nameservice. > (1) Add moutTable > /home/data -> (ns0, /home/data) > /data1/test1 -> (ns1, /data1/test1 ) > /data2/test2 -> (ns1, /data2/test2 ) > (2)mv file to trash > ns0: /user/test-user/.Trash/Current/home/data/file1 > ns1: /user/test-user/.Trash/Current/data1/test1/file1 > (3) client via DFSRouter ls will not see > /user/test-user/.Trash/Current/data1 > (4) client ls /user/test-user/.Trash/Current/data2/test2 will return > exception . > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-17263) [RBF] Fix client ls trash path cannot get except default nameservices trash path
[ https://issues.apache.org/jira/browse/HDFS-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDFS-17263: -- Labels: pull-request-available (was: ) > [RBF] Fix client ls trash path cannot get except default nameservices trash > path > > > Key: HDFS-17263 > URL: https://issues.apache.org/jira/browse/HDFS-17263 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: liuguanghua >Priority: Major > Labels: pull-request-available > > With HDFS-16024, we can rename data to the Trash should be based on src > locations. That is great for my useage. After a period of use, I found this > cause a issue. > There are two nameservices ns0 ns1, and ns0 is the default nameservice. > (1) Add moutTable > /home/data -> (ns0, /home/data) > /data1/test1 -> (ns1, /data1/test1 ) > /data2/test2 -> (ns1, /data2/test2 ) > (2)mv file to trash > ns0: /user/test-user/.Trash/Current/home/data/file1 > ns1: /user/test-user/.Trash/Current/data1/test1/file1 > (3) client via DFSRouter ls will not see > /user/test-user/.Trash/Current/data1 > (4) client ls /user/test-user/.Trash/Current/data2/test2 will return > exception . > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Created] (HDFS-17263) [RBF] Fix client ls trash path cannot get except default nameservices trash path
liuguanghua created HDFS-17263: -- Summary: [RBF] Fix client ls trash path cannot get except default nameservices trash path Key: HDFS-17263 URL: https://issues.apache.org/jira/browse/HDFS-17263 Project: Hadoop HDFS Issue Type: Improvement Reporter: liuguanghua With HDFS-16024, we can rename data to the Trash should be based on src locations. That is great for my useage. After a period of use, I found this cause a issue. There are two nameservices ns0 ns1, and ns0 is the default nameservice. (1) Add moutTable /home/data -> (ns0, /home/data) /data1/test1 -> (ns1, /data1/test1 ) /data2/test2 -> (ns1, /data2/test2 ) (2)mv file to trash ns0: /user/test-user/.Trash/Current/home/data/file1 ns1: /user/test-user/.Trash/Current/data1/test1/file1 (3) client via DFSRouter ls will not see /user/test-user/.Trash/Current/data1 (4) client ls /user/test-user/.Trash/Current/data2/test2 will return exception . -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
