[jira] [Commented] (HDFS-11496) Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to shading
[
https://issues.apache.org/jira/browse/HDFS-11496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450602#comment-16450602
]
Hudson commented on HDFS-11496:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14057/])
HDFS-11496. Ozone: Merge with trunk needed a ignore duplicate entry in
(aengineer: rev 36b20e9fbf98412b3625a3f3b31b8ea0ca3b72bd)
* (edit) hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
* (edit) hadoop-hdfs-project/hadoop-hdfs/pom.xml
> Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to
> shading
> --
>
> Key: HDFS-11496
> URL: https://issues.apache.org/jira/browse/HDFS-11496
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Fix For: HDFS-7240
>
> Attachments: HDFS-11496-HDFS-7240.20170321.patch
>
>
> The trunk merge needed a hack in the
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml to ignore
> netty files. Not sure that is the right thing to do, so tracking here if we
> need to revert this change before we merge.
> {code}
> ~/a/hadoop> git diff
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> modified: hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> @ pom.xml:106 @
> *
>
>
>
>
>
>
>
>
>
>
> io.netty
> netty
> *
>
>
>
>
>
> {code}
> [~andrew.wang] or [~busbey] Would one of you care to comment if this is the
> right thing to do ? Thanks in advance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11496) Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to shading
[
https://issues.apache.org/jira/browse/HDFS-11496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935482#comment-15935482
]
Tsz Wo Nicholas Sze commented on HDFS-11496:
Thanks [~anu]!
> Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to
> shading
> --
>
> Key: HDFS-11496
> URL: https://issues.apache.org/jira/browse/HDFS-11496
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Tsz Wo Nicholas Sze
> Fix For: HDFS-7240
>
> Attachments: HDFS-11496-HDFS-7240.20170321.patch
>
>
> The trunk merge needed a hack in the
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml to ignore
> netty files. Not sure that is the right thing to do, so tracking here if we
> need to revert this change before we merge.
> {code}
> ~/a/hadoop> git diff
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> modified: hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> @ pom.xml:106 @
> *
>
>
>
>
>
>
>
>
>
>
> io.netty
> netty
> *
>
>
>
>
>
> {code}
> [~andrew.wang] or [~busbey] Would one of you care to comment if this is the
> right thing to do ? Thanks in advance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11496) Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to shading
[
https://issues.apache.org/jira/browse/HDFS-11496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935372#comment-15935372
]
Hadoop QA commented on HDFS-11496:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
43s{color} | {color:green} HDFS-7240 passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 6m
46s{color} | {color:red} root in HDFS-7240 failed. {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
28s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
45s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
21s{color} | {color:green} HDFS-7240 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
7s{color} | {color:red} hadoop-client-check-test-invariants in the patch
failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 6m
32s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 6m 32s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m
21s{color} | {color:red} hadoop-client-check-test-invariants in the patch
failed. {color} |
| {color:red}-1{color} | {color:red} mvneclipse {color} | {color:red} 0m
20s{color} | {color:red} hadoop-client-check-test-invariants in the patch
failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
20s{color} | {color:red} hadoop-client-check-test-invariants in the patch
failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 67m 11s{color}
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 19s{color}
| {color:red} hadoop-client-check-test-invariants in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
41s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}104m 35s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.web.TestWebHDFS |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HDFS-11496 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12859778/HDFS-11496-HDFS-7240.20170321.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit xml |
| uname | Linux e02e4a914917 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6
15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | HDFS-7240 / 6b5dee9 |
| Default Java | 1.8.0_121 |
| compile |
https://builds.apache.org/job/PreCommit-HDFS-Build/18787/artifact/patchprocess/branch-compile-root.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HDFS-Build/18787/artifact/patchprocess/patch-mvninstall-hadoop-client-modules_hadoop-client-check-test-invariants.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HDFS-Build/18787/artifact/patchprocess/patch-compile-root.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HDFS-Build/18787/artifact/patchprocess/patch-compile-root.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HDFS-Build/18787/arti
[jira] [Commented] (HDFS-11496) Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to shading
[
https://issues.apache.org/jira/browse/HDFS-11496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935187#comment-15935187
]
Anu Engineer commented on HDFS-11496:
-
[~szetszwo] Thanks for taking care of this. I applied the patch and was able to
build locally using this command *mvn clean install -DskipTests=true
-Dmaven.javadoc.skip=true*.
+1, pending jenkins.
> Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to
> shading
> --
>
> Key: HDFS-11496
> URL: https://issues.apache.org/jira/browse/HDFS-11496
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>Assignee: Tsz Wo Nicholas Sze
> Attachments: HDFS-11496-HDFS-7240.20170321.patch
>
>
> The trunk merge needed a hack in the
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml to ignore
> netty files. Not sure that is the right thing to do, so tracking here if we
> need to revert this change before we merge.
> {code}
> ~/a/hadoop> git diff
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> modified: hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> @ pom.xml:106 @
> *
>
>
>
>
>
>
>
>
>
>
> io.netty
> netty
> *
>
>
>
>
>
> {code}
> [~andrew.wang] or [~busbey] Would one of you care to comment if this is the
> right thing to do ? Thanks in advance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11496) Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to shading
[
https://issues.apache.org/jira/browse/HDFS-11496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898138#comment-15898138
]
Anu Engineer commented on HDFS-11496:
-
[~busbey] That makes sense, I think we did add netty dependency. Thanks for
your suggestions, I will fix this before merging the way you are suggesting.
> Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to
> shading
> --
>
> Key: HDFS-11496
> URL: https://issues.apache.org/jira/browse/HDFS-11496
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>
> The trunk merge needed a hack in the
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml to ignore
> netty files. Not sure that is the right thing to do, so tracking here if we
> need to revert this change before we merge.
> {code}
> ~/a/hadoop> git diff
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> modified: hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> @ pom.xml:106 @
> *
>
>
>
>
>
>
>
>
>
>
> io.netty
> netty
> *
>
>
>
>
>
> {code}
> [~andrew.wang] or [~busbey] Would one of you care to comment if this is the
> right thing to do ? Thanks in advance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11496) Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to shading
[
https://issues.apache.org/jira/browse/HDFS-11496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898103#comment-15898103
]
Sean Busbey commented on HDFS-11496:
I would guess that the Ozone branch added netty as a dependency for something
that is transitively included in minicluster. using maven's dependency tree
should show you where the dependency comes in.
> Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to
> shading
> --
>
> Key: HDFS-11496
> URL: https://issues.apache.org/jira/browse/HDFS-11496
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>
> The trunk merge needed a hack in the
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml to ignore
> netty files. Not sure that is the right thing to do, so tracking here if we
> need to revert this change before we merge.
> {code}
> ~/a/hadoop> git diff
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> modified: hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> @ pom.xml:106 @
> *
>
>
>
>
>
>
>
>
>
>
> io.netty
> netty
> *
>
>
>
>
>
> {code}
> [~andrew.wang] or [~busbey] Would one of you care to comment if this is the
> right thing to do ? Thanks in advance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11496) Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to shading
[
https://issues.apache.org/jira/browse/HDFS-11496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898035#comment-15898035
]
Anu Engineer commented on HDFS-11496:
-
[~busbey] Thanks for your comment. I agree that changing invariants is a bad
idea. That is why I filed this JIRA to get your expert comments. I will try to
fix it the way you are suggesting. Before I do that, I wanted to ask you why
this is not happening in trunk and why this change is needed in Ozone branch,
any guesses to where the root issue might be ?
> Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to
> shading
> --
>
> Key: HDFS-11496
> URL: https://issues.apache.org/jira/browse/HDFS-11496
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>
> The trunk merge needed a hack in the
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml to ignore
> netty files. Not sure that is the right thing to do, so tracking here if we
> need to revert this change before we merge.
> {code}
> ~/a/hadoop> git diff
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> modified: hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> @ pom.xml:106 @
> *
>
>
>
>
>
>
>
>
>
>
> io.netty
> netty
> *
>
>
>
>
>
> {code}
> [~andrew.wang] or [~busbey] Would one of you care to comment if this is the
> right thing to do ? Thanks in advance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11496) Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to shading
[
https://issues.apache.org/jira/browse/HDFS-11496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896391#comment-15896391
]
Sean Busbey commented on HDFS-11496:
Changing the invariants is probably the wrong way to go. A given set of classes
is supposed to be in exactly one of the three shaded artifacts. My guess would
be that netty should be in the runtime artifact. That means you should exclude
its inclusion in the minicluster artifact.
> Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to
> shading
> --
>
> Key: HDFS-11496
> URL: https://issues.apache.org/jira/browse/HDFS-11496
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
>Affects Versions: HDFS-7240
>Reporter: Anu Engineer
>
> The trunk merge needed a hack in the
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml to ignore
> netty files. Not sure that is the right thing to do, so tracking here if we
> need to revert this change before we merge.
> {code}
> ~/a/hadoop> git diff
> hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> modified: hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml
> ─
> @ pom.xml:106 @
> *
>
>
>
>
>
>
>
>
>
>
> io.netty
> netty
> *
>
>
>
>
>
> {code}
> [~andrew.wang] or [~busbey] Would one of you care to comment if this is the
> right thing to do ? Thanks in advance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
