[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2018-04-26 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455158#comment-16455158
 ] 

Hudson commented on HDFS-12149:
---

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14070 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14070/])
HDFS-12149. Ozone: RocksDB implementation of ozone metadata store. (omalley: 
rev bbbfc885e788f6964d5e69229d66943bf8a81e7e)
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/utils/MetadataStoreBuilder.java
* (edit) hadoop-hdfs-project/hadoop-hdfs/pom.xml
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/utils/LevelDBStore.java
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/ozone-default.xml
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/TestMetadataStore.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/utils/RocksDBStore.java


> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
>Priority: Major
> Attachments: HDFS-12149-HDFS-7240.001.patch, 
> HDFS-12149-HDFS-7240.002.patch, HDFS-12149-HDFS-7240.003.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2018-04-24 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450907#comment-16450907
 ] 

Hudson commented on HDFS-12149:
---

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/14057/])
HDFS-12149. Ozone: RocksDB implementation of ozone metadata store. (aengineer: 
rev 0edc4c3dd8f6e6adcb57dfb81a891c92e4e183f9)
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/utils/RocksDBStore.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/TestMetadataStore.java
* (edit) hadoop-hdfs-project/hadoop-hdfs/pom.xml
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/utils/LevelDBStore.java
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/ozone-default.xml
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/utils/MetadataStoreBuilder.java


> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
>Priority: Major
> Attachments: HDFS-12149-HDFS-7240.001.patch, 
> HDFS-12149-HDFS-7240.002.patch, HDFS-12149-HDFS-7240.003.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-20 Thread Weiwei Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095702#comment-16095702
 ] 

Weiwei Yang commented on HDFS-12149:


Thanks [~anu] !

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch, 
> HDFS-12149-HDFS-7240.002.patch, HDFS-12149-HDFS-7240.003.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-20 Thread Anu Engineer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095100#comment-16095100
 ] 

Anu Engineer commented on HDFS-12149:
-

+1, I am going to commit this shortly. [~aw] I am presuming that since the pom 
refers to 5.5.5, I am going to presume we are good. Please let me know if you 
have any concerns.


> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch, 
> HDFS-12149-HDFS-7240.002.patch, HDFS-12149-HDFS-7240.003.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-20 Thread Weiwei Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094739#comment-16094739
 ] 

Weiwei Yang commented on HDFS-12149:


The UT failure seems not related, I have opened HDFS-12167 to track that issue.

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch, 
> HDFS-12149-HDFS-7240.002.patch, HDFS-12149-HDFS-7240.003.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-20 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094462#comment-16094462
 ] 

Hadoop QA commented on HDFS-12149:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 
 1s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
50s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
38s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
57s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
51s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
51s{color} | {color:green} HDFS-7240 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 67m 39s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 95m 47s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 |
|   | hadoop.ozone.container.replication.TestContainerReplicationManager |
|   | hadoop.hdfs.server.namenode.ha.TestPipelinesFailover |
|   | hadoop.ozone.container.common.impl.TestContainerPersistence |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12149 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12878114/HDFS-12149-HDFS-7240.003.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  xml  findbugs  checkstyle  |
| uname | Linux 4ffb55bba60e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | HDFS-7240 / b3a7f3b |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/20346/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/20346/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/20346/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> 

[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-20 Thread Weiwei Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094349#comment-16094349
 ] 

Weiwei Yang commented on HDFS-12149:


Hi [~yuanbo]

Thanks for helping to review this. I have fixed the close code as you 
suggesgted.

bq. line 267: I don't have much experience in RocksDB, what if iterator doesn't 
have next or prev?

In rocksDB, we can use next() plus isValid() combination instead, slightly 
different with leveldb.

Thank you.

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch, 
> HDFS-12149-HDFS-7240.002.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-19 Thread Yuanbo Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094153#comment-16094153
 ] 

Yuanbo Liu commented on HDFS-12149:
---

[~cheersyang] Thanks for your patch, these are my comments:
LevelDBStore.java
line 165: use close method instead
{code}
close();

{code}
line 128, check null point before closing db
{code}
if(db != null) {
  db.close();
}
{code}

RocksDBStore.java
line 237: use close method instead
{code}
close();
{code}

line 267: I don't have much experience in RocksDB, what if iterator doesn't 
have next or prev?


> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch, 
> HDFS-12149-HDFS-7240.002.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-19 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094142#comment-16094142
 ] 

Hadoop QA commented on HDFS-12149:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 
27s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
54s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
3s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
54s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
53s{color} | {color:green} HDFS-7240 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 79m 15s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}108m 27s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
hadoop.ozone.container.replication.TestContainerReplicationManager |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010 |
|   | hadoop.hdfs.server.namenode.TestCacheDirectives |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160 |
| Timed out junit tests | 
org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12149 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12878082/HDFS-12149-HDFS-7240.002.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  xml  findbugs  checkstyle  |
| uname | Linux 82e645af1207 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | HDFS-7240 / b3a7f3b |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/20344/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/20344/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/20344/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT   http://yetus.apache.org |


This message was 

[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-19 Thread Weiwei Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094077#comment-16094077
 ] 

Weiwei Yang commented on HDFS-12149:


Hi [~anu], [~aw]

RocksDB 5.5.5 is released, with license updated to apache 2, are we free to go 
with this patch (of course I am going to update the pom to 5.5.5 first :) ) ? 

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-17 Thread Anu Engineer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090943#comment-16090943
 ] 

Anu Engineer commented on HDFS-12149:
-

[~aw] Thanks, We can certainly hold off. Since this is a branch and it will be 
a while before merge or shipping, I thought we can get some testing with this 
commit. I am fine with delaying the commit if you think we should not commit.

I was under the impression that it will matter only when we ship. Since we are 
never going to ship the ozone branch as an Apache Artifact, I was thinking it 
is safe.

[~cheersyang] Let us hold off based on [~aw]'s comment. 

Meanwhile, we can certainly apply this patch privately and test ozone.



> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-17 Thread Weiwei Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090940#comment-16090940
 ] 

Weiwei Yang commented on HDFS-12149:


Ah posted last comment too quick until I see [~aw]'s comment. 

bq. basically saying dont commit new code until we have something we can use.

does it mean once there is a new rocksdb released which has included the 
license update, then we can commit this?

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-17 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090934#comment-16090934
 ] 

Allen Wittenauer commented on HDFS-12149:
-


LEGAL-303 is basically saying dont commit new code until we have something we 
can use.

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-17 Thread Weiwei Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090936#comment-16090936
 ] 

Weiwei Yang commented on HDFS-12149:


Thanks [~anu], sounds good to me. Since it seems no regression is introduced 
with this patch from the UT result, I am going to fix the checksytle issues and 
commit this today. After then, we can do more tests with rocks db. Thanks a lot 
for your quick response.

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-17 Thread Anu Engineer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090929#comment-16090929
 ] 

Anu Engineer commented on HDFS-12149:
-

Let us commit, since the license is a blocker when we merge/ship. So let us get 
some testing done with RocksDB meanwhile.


> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-17 Thread Weiwei Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090926#comment-16090926
 ] 

Weiwei Yang commented on HDFS-12149:


Hi [~anu]

There was a rocksdb build few hours ago 5.5.3 but it seems still uses old 
license, we will need to wait a few more days until the license updates. Do you 
want me to commit this first and open another JIRA to track the version update 
(so we can start to play with rocksdb), or you want me to hold off this patch 
until the new version comes out?

Thank you.

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-17 Thread Anu Engineer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090366#comment-16090366
 ] 

Anu Engineer commented on HDFS-12149:
-

[~vagarychen] Thanks, I am just adding the reference to the Apache v2 license 
pull request for RocksDB in case someone wanted to check.
https://github.com/facebook/rocksdb/commit/3c327ac2d0fd50bbd82fe1f1af5de909dad769e6

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-17 Thread Chen Liang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090351#comment-16090351
 ] 

Chen Liang commented on HDFS-12149:
---

I have filed HDFS-12155 for augmenting debug CLI to be able to dump RocksDB, 
I'll take care of it. Thanks [~anu] for the catch!

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-17 Thread Anu Engineer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090119#comment-16090119
 ] 

Anu Engineer commented on HDFS-12149:
-

[~cheersyang] Thank you for the contribution, I am +1 with these following 
caveats. We should file 2 JIRAs and keep a possible performance issue in mind.

1. Let us make RocksDB the default.
2. Let us file 2 more JIRAs 
 * one to upgrade the RocksDB with the right License. This version does not 
have the right Apache v2 License.
 * We need to make sure the debug CLI that can read and dumb the LevelDB works 
equally well with this Change. please file another JIRA for it.

   3. Both these options might make RocksDB too slow for our use-case.
{code}
writeOptions.setSync(true);
writeOptions.setNoSlowdown(true);
{code}

During the development of CBlock, I had to make LevelDB async to get anywhere 
near performance that I wanted while it was running with SSD. Since we will 
eventually back this information via RAFT we might want to make this async 
calls, but we don't need to change it now.

Same with the setNoSlowDown option, we will leave it in place, but I wonder if 
that is going to work with HDDs with a large number of I/Os. We will have to 
experiment and find out. 

So let us leave these as is, but we should collect data and revisit this at a 
later point.

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-17 Thread Anu Engineer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089979#comment-16089979
 ] 

Anu Engineer commented on HDFS-12149:
-

[~aw] We are switching all LevelDB use in Ozone to RocksDB. I am glad to move 
any other uses in HDFS over too. As for YARN, it might need someone from YARN 
team to take a look at it, But as soon as we merge, we will have RocksDB in the 
trunk.

We are targeting end of this summer for the possible merge.



> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
> Attachments: HDFS-12149-HDFS-7240.001.patch
>
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-17 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089716#comment-16089716
 ] 

Hadoop QA commented on HDFS-12149:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m 
40s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
52s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
38s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
57s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
53s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
50s{color} | {color:green} HDFS-7240 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 35s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch 
generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
48s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 72m 59s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}100m 50s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.server.namenode.ha.TestHASafeMode |
|   | hadoop.ozone.container.replication.TestContainerReplicationManager |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090 |
|   | hadoop.ozone.container.common.TestDatanodeStateMachine |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160 |
| Timed out junit tests | 
org.apache.hadoop.ozone.container.ozoneimpl.TestRatisManager |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12149 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12877552/HDFS-12149-HDFS-7240.001.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  xml  findbugs  checkstyle  |
| uname | Linux e30026a5e884 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | HDFS-7240 / 1bec6a1 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HDFS-Build/20303/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/20303/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
|  Test Results | 

[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-16 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089327#comment-16089327
 ] 

Allen Wittenauer commented on HDFS-12149:
-

FWIW, I'd really like for us to rip LevelDB completely out of Hadoop. It 
absolutely destroys us on portability.  See HADOOP-11790 for more.

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-16 Thread Weiwei Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089218#comment-16089218
 ] 

Weiwei Yang commented on HDFS-12149:


Thanks [~anu] for the message, I will work on this.

bq. I am aware that what we have is a generic plugin layer which can use most 
key value stores, and RocksDB is just a specific instance of it and it is 
trivial for us to revert it, even if it is committed.

That's correct. We will follow Legal team's decision like you mentioned. It is 
trivial to revert this with a simple switch. Thank you.

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-16 Thread Anu Engineer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089216#comment-16089216
 ] 

Anu Engineer commented on HDFS-12149:
-

[~cheersyang] Based on comments in LEGAL-303, I think we are clear to use 
RocksDB. Please go ahead with your patch.

> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-15 Thread Anu Engineer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088817#comment-16088817
 ] 

Anu Engineer commented on HDFS-12149:
-

With that summary, you are free to post any patch you like. Please be aware 
that we will *commit this only after* we have absolute clarity with RocksDB.
I am *hopeful* that with the new license change of RocksDB from Facebook,  we 
are can use RocksDB with Hadoop. I am aware that what we have is a generic 
plugin layer which can use most key value stores, and RocksDB is just a 
specific instance of it and it is trivial for us to revert it, even if it is 
committed.

Please be advised that we will follow whatever Apache Legal team decides, so 
there is a small chance that this change may not be committed into Hadoop.



> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-15 Thread Anu Engineer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088815#comment-16088815
 ] 

Anu Engineer commented on HDFS-12149:
-

[~jnp], [~szetszwo], [~cheersyang], [~xyao], [~msingh], [~nandakumar131], 
[~linyiqun], [~vagarychen], [~yuanbo], [~arpitagarwal]

There is an interesting thread here in the Legal section, which we should be 
aware of before we post this patch which bring in RocksDB dependency.

TL: DR; Due to the RocksDB License change we might be able to use RocksDB. 
Approximately 3 hours ago RocksDB switched over to using Apache 2 License, 
before that RocksDB was declared as *persona non grata* in the Apache world.

Details: In the Apache JIRA LEGAL-303, it was clarified that Facebook uses a 
license -- "Facebook BSD+Patents license". This was deemed to be not suitable 
for use in Apache. 

Facebook also clarified that the intent of this license was to be different 
from Apache license.  
https://issues.apache.org/jira/browse/LEGAL-303?focusedCommentId=16046579=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16046579


Around 12 hours ago (Sat, Jul 15th, 2017)  Chris Mattmann send out a circular 
to all Apache PMCs that RocksDB falls under Category X license, which are 
licenses that cannot be included with Apache products.  This naturally means 
that we cannot commit a change that has a RocksDB dependency.

 Fortunately, around 3 hours ago (Sat, Jul 15th, 2017 7:00 PM), Facebook has 
committed a new license to RocksDB. That is a classic Apache 2 license. So I 
think we are good to use the RocksDB since it is relicensed in Apache (IANAL).

Please be aware that we might have to revert this change if Apache finally 
decides that we cannot use RocksDB.



> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org



[jira] [Commented] (HDFS-12149) Ozone: RocksDB implementation of ozone metadata store

2017-07-15 Thread Anu Engineer (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088807#comment-16088807
 ] 

Anu Engineer commented on HDFS-12149:
-

Hold on, Don't post a patch please.


> Ozone: RocksDB implementation of ozone metadata store
> -
>
> Key: HDFS-12149
> URL: https://issues.apache.org/jira/browse/HDFS-12149
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: ozone
>Reporter: Weiwei Yang
>Assignee: Weiwei Yang
>
> HDFS-12069 added a general interface for ozone metadata store, we already 
> have a leveldb implementation, this JIRA is to track the work of rocksdb 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org