[jira] [Commented] (HDFS-12309) Incorrect null check in the AdminHelper.java
[ https://issues.apache.org/jira/browse/HDFS-12309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686348#comment-16686348 ] Elek, Marton commented on HDFS-12309: - Thank you [~olegd] to post this patch. Unfortunately I found it just now and in the meantime it's fixed in HDFS-13261. Will close this issue as of now. > Incorrect null check in the AdminHelper.java > > > Key: HDFS-12309 > URL: https://issues.apache.org/jira/browse/HDFS-12309 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Oleg Danilov >Priority: Trivial > Attachments: HDFS-12309.patch > > > '!= null' is not required there: > line 147-150: > {code:java} > public HelpCommand(Command[] commands) { > Preconditions.checkNotNull(commands != null); > this.commands = commands; > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-12309) Incorrect null check in the AdminHelper.java
[ https://issues.apache.org/jira/browse/HDFS-12309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129567#comment-16129567 ] Hadoop QA commented on HDFS-12309: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 22s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 58s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 59s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 3s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 1s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 46s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 70m 56s{color} | {color:red} hadoop-hdfs in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}100m 43s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:14b5c93 | | JIRA Issue | HDFS-12309 | | GITHUB PR | https://github.com/apache/hadoop/pull/264 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 283801c82d89 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / de462da | | Default Java | 1.8.0_144 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/PreCommit-HDFS-Build/20726/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/20726/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/20726/console | | Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Incorrect null check in the AdminHelper.java > > > Key: HDFS-12309 > URL: https://issues.apache.org/jira/browse/HDFS-12309 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Oleg Danilov >Priority: Trivial > Attachments: HDFS-12309.patch > > >
[jira] [Commented] (HDFS-12309) Incorrect null check in the AdminHelper.java
[ https://issues.apache.org/jira/browse/HDFS-12309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129414#comment-16129414 ] ASF GitHub Bot commented on HDFS-12309: --- GitHub user dosoft opened a pull request: https://github.com/apache/hadoop/pull/264 HDFS-12309. Fixed incorrect checkNotNull() You can merge this pull request into a Git repository by running: $ git pull https://github.com/dosoft/hadoop HDFS-12309 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/264.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #264 commit cd77a28bb7826d0cc77da365f21cd05f9fade7e0 Author: Oleg DanilovDate: 2017-08-16T21:04:47Z HDFS-12309. Fixed incorrect checkNotNull() > Incorrect null check in the AdminHelper.java > > > Key: HDFS-12309 > URL: https://issues.apache.org/jira/browse/HDFS-12309 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: Oleg Danilov >Priority: Trivial > > '!= null' is not required there: > line 147-150: > {code:java} > public HelpCommand(Command[] commands) { > Preconditions.checkNotNull(commands != null); > this.commands = commands; > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org