[jira] [Commented] (HDFS-1934) Fix NullPointerException when certain File APIs return null
[
https://issues.apache.org/jira/browse/HDFS-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13042361#comment-13042361
]
Matt Foley commented on HDFS-1934:
--
The test failures are unrelated.
+1. Committed to trunk. Thanks Bharath! And thanks to Jakob for reviewing.
Fix NullPointerException when certain File APIs return null
---
Key: HDFS-1934
URL: https://issues.apache.org/jira/browse/HDFS-1934
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
Fix For: 0.23.0
Attachments: HDFS-1934-1.patch, HDFS-1934-2.patch, HDFS-1934-3.patch,
HDFS-1934-4.patch, HDFS-1934-5.patch
While testing Disk Fail Inplace, We encountered the NPE from this part of the
code.
File[] files = dir.listFiles();
for (File f : files) {
...
}
This is kinda of an API issue. When a disk is bad (or name is not a
directory), this API (listFiles, list) return null rather than throwing an
exception. This 'for loop' throws a NPE exception. And same applies to
dir.list() API.
Fix all the places where null condition was not checked.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1934) Fix NullPointerException when certain File APIs return null
[
https://issues.apache.org/jira/browse/HDFS-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13041905#comment-13041905
]
Hadoop QA commented on HDFS-1934:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481005/HDFS-1934-5.patch
against trunk revision 1129942.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
org.apache.hadoop.hdfs.TestDFSUpgradeFromImage
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/669//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/669//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/669//console
This message is automatically generated.
Fix NullPointerException when certain File APIs return null
---
Key: HDFS-1934
URL: https://issues.apache.org/jira/browse/HDFS-1934
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
Fix For: 0.23.0
Attachments: HDFS-1934-1.patch, HDFS-1934-2.patch, HDFS-1934-3.patch,
HDFS-1934-4.patch, HDFS-1934-5.patch
While testing Disk Fail Inplace, We encountered the NPE from this part of the
code.
File[] files = dir.listFiles();
for (File f : files) {
...
}
This is kinda of an API issue. When a disk is bad (or name is not a
directory), this API (listFiles, list) return null rather than throwing an
exception. This 'for loop' throws a NPE exception. And same applies to
dir.list() API.
Fix all the places where null condition was not checked.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1934) Fix NullPointerException when certain File APIs return null
[
https://issues.apache.org/jira/browse/HDFS-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13040121#comment-13040121
]
Bharath Mundlapudi commented on HDFS-1934:
--
Right, this patch is trying to address exactly what you have mentioned.
Fix NullPointerException when certain File APIs return null
---
Key: HDFS-1934
URL: https://issues.apache.org/jira/browse/HDFS-1934
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
Fix For: 0.23.0
Attachments: HDFS-1934-1.patch, HDFS-1934-2.patch, HDFS-1934-3.patch
While testing Disk Fail Inplace, We encountered the NPE from this part of the
code.
File[] files = dir.listFiles();
for (File f : files) {
...
}
This is kinda of an API issue. When a disk is bad (or name is not a
directory), this API (listFiles, list) return null rather than throwing an
exception. This 'for loop' throws a NPE exception. And same applies to
dir.list() API.
Fix all the places where null condition was not checked.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1934) Fix NullPointerException when certain File APIs return null
[
https://issues.apache.org/jira/browse/HDFS-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13040134#comment-13040134
]
Hadoop QA commented on HDFS-1934:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480631/HDFS-1934-3.patch
against trunk revision 1128009.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/642//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/642//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/642//console
This message is automatically generated.
Fix NullPointerException when certain File APIs return null
---
Key: HDFS-1934
URL: https://issues.apache.org/jira/browse/HDFS-1934
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
Fix For: 0.23.0
Attachments: HDFS-1934-1.patch, HDFS-1934-2.patch, HDFS-1934-3.patch
While testing Disk Fail Inplace, We encountered the NPE from this part of the
code.
File[] files = dir.listFiles();
for (File f : files) {
...
}
This is kinda of an API issue. When a disk is bad (or name is not a
directory), this API (listFiles, list) return null rather than throwing an
exception. This 'for loop' throws a NPE exception. And same applies to
dir.list() API.
Fix all the places where null condition was not checked.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1934) Fix NullPointerException when certain File APIs return null
[
https://issues.apache.org/jira/browse/HDFS-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13040361#comment-13040361
]
Matt Foley commented on HDFS-1934:
--
Minor: This is an old idiom: LOG.warn(Exception occured while compiling
report: + StringUtils.stringifyException(ioe));
The preferred form is: LOG.warn(Exception occurred while compiling report: ,
ioe);
All the changes you made look like good catches.
Make that edit and I'll commit.
Fix NullPointerException when certain File APIs return null
---
Key: HDFS-1934
URL: https://issues.apache.org/jira/browse/HDFS-1934
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
Fix For: 0.23.0
Attachments: HDFS-1934-1.patch, HDFS-1934-2.patch, HDFS-1934-3.patch
While testing Disk Fail Inplace, We encountered the NPE from this part of the
code.
File[] files = dir.listFiles();
for (File f : files) {
...
}
This is kinda of an API issue. When a disk is bad (or name is not a
directory), this API (listFiles, list) return null rather than throwing an
exception. This 'for loop' throws a NPE exception. And same applies to
dir.list() API.
Fix all the places where null condition was not checked.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1934) Fix NullPointerException when certain File APIs return null
[
https://issues.apache.org/jira/browse/HDFS-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13039888#comment-13039888
]
Jakob Homan commented on HDFS-1934:
---
This semantic was argued out in HDFS-538, where it was agreed that in general
empty collections or arrays should be returned for directories/whatever with no
contents, exceptions should be thrown for invalid/non-existent requests and
null should never be returned. Glancing at the latest patch, I see some hard
tabs and some odd spacing.
Fix NullPointerException when certain File APIs return null
---
Key: HDFS-1934
URL: https://issues.apache.org/jira/browse/HDFS-1934
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Bharath Mundlapudi
Assignee: Bharath Mundlapudi
Fix For: 0.23.0
Attachments: HDFS-1934-1.patch, HDFS-1934-2.patch
While testing Disk Fail Inplace, We encountered the NPE from this part of the
code.
File[] files = dir.listFiles();
for (File f : files) {
...
}
This is kinda of an API issue. When a disk is bad (or name is not a
directory), this API (listFiles, list) return null rather than throwing an
exception. This 'for loop' throws a NPE exception. And same applies to
dir.list() API.
Fix all the places where null condition was not checked.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
