[jira] [Commented] (HDFS-2109) Store uMask as member variable to DFSClient.Conf
[ https://issues.apache.org/jira/browse/HDFS-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056880#comment-13056880 ] Hadoop QA commented on HDFS-2109: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483894/HDFS-2109-1.patch against trunk revision 1140707. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 32 javac compiler warnings (more than the trunk's current 31 warnings). +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/863//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/863//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/863//console This message is automatically generated. > Store uMask as member variable to DFSClient.Conf > > > Key: HDFS-2109 > URL: https://issues.apache.org/jira/browse/HDFS-2109 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi > Fix For: 0.23.0 > > Attachments: HDFS-2109-1.patch > > > As a part of removing reference to conf in DFSClient, I am proposing > replacing FsPermission.getUMask(conf) everywhere in DFSClient class with > dfsClientConf.uMask by storing uMask as a member variable to DFSClient.Conf. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2109) Store uMask as member variable to DFSClient.Conf
[ https://issues.apache.org/jira/browse/HDFS-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058114#comment-13058114 ] Hadoop QA commented on HDFS-2109: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484829/HDFS-2109-2.patch against trunk revision 1141713. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.namenode.TestStartup org.apache.hadoop.hdfs.TestFileCreationClient +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/874//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/874//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/874//console This message is automatically generated. > Store uMask as member variable to DFSClient.Conf > > > Key: HDFS-2109 > URL: https://issues.apache.org/jira/browse/HDFS-2109 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi > Fix For: 0.23.0 > > Attachments: HDFS-2109-1.patch, HDFS-2109-2.patch > > > As a part of removing reference to conf in DFSClient, I am proposing > replacing FsPermission.getUMask(conf) everywhere in DFSClient class with > dfsClientConf.uMask by storing uMask as a member variable to DFSClient.Conf. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2109) Store uMask as member variable to DFSClient.Conf
[ https://issues.apache.org/jira/browse/HDFS-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058115#comment-13058115 ] Bharath Mundlapudi commented on HDFS-2109: -- Failed tests are not related to this patch. > Store uMask as member variable to DFSClient.Conf > > > Key: HDFS-2109 > URL: https://issues.apache.org/jira/browse/HDFS-2109 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi > Fix For: 0.23.0 > > Attachments: HDFS-2109-1.patch, HDFS-2109-2.patch > > > As a part of removing reference to conf in DFSClient, I am proposing > replacing FsPermission.getUMask(conf) everywhere in DFSClient class with > dfsClientConf.uMask by storing uMask as a member variable to DFSClient.Conf. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2109) Store uMask as member variable to DFSClient.Conf
[ https://issues.apache.org/jira/browse/HDFS-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058153#comment-13058153 ] Hudson commented on HDFS-2109: -- Integrated in Hadoop-Hdfs-trunk-Commit #772 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/772/]) HDFS-2109. Store uMask as member variable to DFSClient.Conf. Contributed by Bharath Mundlapudi szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141767 Files : * /hadoop/common/trunk/hdfs/CHANGES.txt * /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSPermission.java > Store uMask as member variable to DFSClient.Conf > > > Key: HDFS-2109 > URL: https://issues.apache.org/jira/browse/HDFS-2109 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi > Fix For: 0.23.0 > > Attachments: HDFS-2109-1.patch, HDFS-2109-2.patch > > > As a part of removing reference to conf in DFSClient, I am proposing > replacing FsPermission.getUMask(conf) everywhere in DFSClient class with > dfsClientConf.uMask by storing uMask as a member variable to DFSClient.Conf. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2109) Store uMask as member variable to DFSClient.Conf
[ https://issues.apache.org/jira/browse/HDFS-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058533#comment-13058533 ] Hudson commented on HDFS-2109: -- Integrated in Hadoop-Hdfs-trunk #712 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/712/]) HDFS-2109. Store uMask as member variable to DFSClient.Conf. Contributed by Bharath Mundlapudi szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141767 Files : * /hadoop/common/trunk/hdfs/CHANGES.txt * /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/DFSClient.java * /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSPermission.java > Store uMask as member variable to DFSClient.Conf > > > Key: HDFS-2109 > URL: https://issues.apache.org/jira/browse/HDFS-2109 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs client >Affects Versions: 0.23.0 >Reporter: Bharath Mundlapudi >Assignee: Bharath Mundlapudi > Fix For: 0.23.0 > > Attachments: HDFS-2109-1.patch, HDFS-2109-2.patch > > > As a part of removing reference to conf in DFSClient, I am proposing > replacing FsPermission.getUMask(conf) everywhere in DFSClient class with > dfsClientConf.uMask by storing uMask as a member variable to DFSClient.Conf. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
