[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby

2011-10-11 Thread Todd Lipcon (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125337#comment-13125337
 ] 

Todd Lipcon commented on HDFS-2301:
---

Just two nits below. Feel free to just fix these on commit - no need for 
another review. +1.


Some funky indentation here:
+  throw new IOException("Service failed to start", e);
+  }



Better to pass "ie" as the second parameter:
+  LOG.info("Caught interrupted exception " + ie);


> Start/stop appropriate namenode internal services during transition to active 
> and standby
> -
>
> Key: HDFS-2301
> URL: https://issues.apache.org/jira/browse/HDFS-2301
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: name-node
>Affects Versions: HA branch (HDFS-1623)
>Reporter: Suresh Srinivas
>Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt, 
> HDFS-2301.txt, HDFS-2301.txt
>
>
> These changes are related to HDFS-1974 which introduced active and standby 
> states. This jira will address starting and stopping appropriate NN services 
> when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby

2011-10-10 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124246#comment-13124246
 ] 

jirapos...@reviews.apache.org commented on HDFS-2301:
-



bq.  On 2011-10-06 23:37:24, Todd Lipcon wrote:
bq.  > 
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java,
 line 28
bq.  > 
bq.  >
bq.  > perhaps should be abstract since it won't ever be instantiated?
bq.  > 
bq.  > these functions are meant only for the server side, right? Otherwise 
they should all take an authority, and look at configs prefixed/suffixed with 
that authority?
bq.  > 
bq.  > let me jump over to HDFS-2231 and try to review that first.. having 
a hard time following this.

Class has private constructor. I prefer that to abstract class. For some 
reason, I included HAUtil in this patch causing lot of confusion. It belongs to 
2231. So I am attaching a patch without HAUtil changes. Also I will address 
rest of your HAUtil comments in 2231.


- Suresh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2150/#review2422
---


On 2011-10-06 23:25:18, Todd Lipcon wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2150/
bq.  ---
bq.  
bq.  (Updated 2011-10-06 23:25:18)
bq.  
bq.  
bq.  Review request for hadoop-hdfs and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Uploading Suresh's patch to reviewboard 
(https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from 
29/Sep/11 00:56)
bq.  
bq.  
bq.  This addresses bug HDFS-2301.
bq.  https://issues.apache.org/jira/browse/HDFS-2301
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
 PRE-CREATION 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAContext.java
 PRE-CREATION 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAState.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyState.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHAUtil.java
 PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/2150/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Todd
bq.  
bq.



> Start/stop appropriate namenode internal services during transition to active 
> and standby
> -
>
> Key: HDFS-2301
> URL: https://issues.apache.org/jira/browse/HDFS-2301
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: name-node
>Affects Versions: HA branch (HDFS-1623)
>Reporter: Suresh Srinivas
>Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt, 
> HDFS-2301.txt
>
>
> These changes are related to HDFS-1974 which introduced active and standby 
> states. This jira will address starting and stopping appropriate NN services 
> when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby

2011-10-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122416#comment-13122416
 ] 

jirapos...@reviews.apache.org commented on HDFS-2301:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2150/#review2422
---



branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java


perhaps should be abstract since it won't ever be instantiated?

these functions are meant only for the server side, right? Otherwise they 
should all take an authority, and look at configs prefixed/suffixed with that 
authority?

let me jump over to HDFS-2231 and try to review that first.. having a hard 
time following this.



branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java


!collection.isEmpty()



branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java


long line



branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java


strange formatting



branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java


so this patch now depends on HDFS-2231 (Conf changes for HA NN), right?


- Todd


On 2011-10-06 23:25:18, Todd Lipcon wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2150/
bq.  ---
bq.  
bq.  (Updated 2011-10-06 23:25:18)
bq.  
bq.  
bq.  Review request for hadoop-hdfs and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Uploading Suresh's patch to reviewboard 
(https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from 
29/Sep/11 00:56)
bq.  
bq.  
bq.  This addresses bug HDFS-2301.
bq.  https://issues.apache.org/jira/browse/HDFS-2301
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
 PRE-CREATION 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAContext.java
 PRE-CREATION 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAState.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyState.java
 1179521 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHAUtil.java
 PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/2150/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Todd
bq.  
bq.



> Start/stop appropriate namenode internal services during transition to active 
> and standby
> -
>
> Key: HDFS-2301
> URL: https://issues.apache.org/jira/browse/HDFS-2301
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: name-node
>Affects Versions: HA branch (HDFS-1623)
>Reporter: Suresh Srinivas
>Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt, 
> HDFS-2301.txt
>
>
> These changes are related to HDFS-1974 which introduced active and standby 
> states. This jira will address starting and stopping appropriate NN services 
> when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: htt

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby

2011-10-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122406#comment-13122406
 ] 

jirapos...@reviews.apache.org commented on HDFS-2301:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2150/
---

(Updated 2011-10-06 23:25:18.391776)


Review request for hadoop-hdfs and Todd Lipcon.


Changes
---

updating reviewboard patch to Suresh's new revision


Summary
---

Uploading Suresh's patch to reviewboard 
(https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from 
29/Sep/11 00:56)


This addresses bug HDFS-2301.
https://issues.apache.org/jira/browse/HDFS-2301


Diffs (updated)
-

  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
 PRE-CREATION 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
 1179521 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
 1179521 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
 1179521 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java
 1179521 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAContext.java
 PRE-CREATION 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAState.java
 1179521 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyState.java
 1179521 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHAUtil.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/2150/diff


Testing
---


Thanks,

Todd



> Start/stop appropriate namenode internal services during transition to active 
> and standby
> -
>
> Key: HDFS-2301
> URL: https://issues.apache.org/jira/browse/HDFS-2301
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: name-node
>Affects Versions: HA branch (HDFS-1623)
>Reporter: Suresh Srinivas
>Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt, 
> HDFS-2301.txt
>
>
> These changes are related to HDFS-1974 which introduced active and standby 
> states. This jira will address starting and stopping appropriate NN services 
> when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby

2011-10-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122380#comment-13122380
 ] 

jirapos...@reviews.apache.org commented on HDFS-2301:
-



bq.  On 2011-10-03 18:58:13, Todd Lipcon wrote:
bq.  > just a few nits, mostly looks good. A few questions I have that aren't 
directly related to this patch:
bq.  > - is SafeMode now a replicated thing, or does each NN separately enter 
safemode? I think the latter, right?
bq.  > - when transitioning between states, what happens if the "enterState" 
fails for the new state? The state variable will then indicate it's in that 
state, when in fact it's in no state at all. How do we recover from that? We 
need some kind of rollback? (eg if you're in standby and try to transition to 
active, but find that you can't take a lock in ZK)
bq.  
bq.  Suresh Srinivas wrote:
bq.  > is SafeMode now a replicated thing, or does each NN separately enter 
safemode? I think the latter, right?
bq.  Safemode is the state of namespace(FSNamesystem), unlike active, 
standby which are the states of the namenode. Each NN separately enters 
safemode.
bq.  
bq.  > when transitioning between states, what happens if the "enterState" 
fails for the new state? The state variable will then indicate it's in that 
state, when in fact it's in no state at all. How do we recover from that? We 
need some kind of rollback? (eg if you're in standby and try to transition to 
active, but find that you can't take a lock in ZK)
bq.  This is tricky. Say enterState fails to start services because of some 
namenode process related issues. Then most likely rolling back to previous 
state, and starting services relevant to previous states will also fail. The 
particular example you are bringing up related to ZK, I think failover 
controller is the one that deals with ZK and not namenode.
bq.  
bq.  I can think of two solutions: namenode shutsdown when this happens (as 
done during startup) or move to a failed state.

Let's just add a TODO for now that we need to consider these situations in a 
test plan. I imagine the most likely real scenario is that you try to do a 
failover, but for some reason the standby has an IO problem trying to read the 
latest logs from the primary (eg maybe the primary barfed some bad data into 
the edit logs as it crashed, or maybe the primary crashed because the shared 
storage caught on fire).


bq.  On 2011-10-03 18:58:13, Todd Lipcon wrote:
bq.  > 
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java,
 line 464
bq.  > 
bq.  >
bq.  > any reason that you switched the order of startHttpServer to the end 
of this function? I don't think it's a big deal, but there's some possibility 
the service plugins may want to do something with the http server, which 
wouldn't be started yet.
bq.  
bq.  Suresh Srinivas wrote:
bq.  No particular reason. Not sure who uses ServicePlugins. But the 
description says it is RPC related. But will move it back up.

Hue currently uses service plugins to expose a Thrift interface. But with 
Sanjay's recent work on protocol adapters, this may be largely unnecessary in 
the future. Nonetheless, we should leave it around :)


- Todd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2150/#review2277
---


On 2011-10-03 18:36:41, Todd Lipcon wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2150/
bq.  ---
bq.  
bq.  (Updated 2011-10-03 18:36:41)
bq.  
bq.  
bq.  Review request for hadoop-hdfs and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Uploading Suresh's patch to reviewboard 
(https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from 
29/Sep/11 00:56)
bq.  
bq.  
bq.  This addresses bug HDFS-2301.
bq.  https://issues.apache.org/jira/browse/HDFS-2301
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
 1177130 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
 1177130 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
 1177130 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java
 1177128 
bq.
branches/HDFS-1623/hadoop-hdfs-proje

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby

2011-10-06 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121781#comment-13121781
 ] 

jirapos...@reviews.apache.org commented on HDFS-2301:
-



bq.  On 2011-10-03 18:58:13, Todd Lipcon wrote:
bq.  > just a few nits, mostly looks good. A few questions I have that aren't 
directly related to this patch:
bq.  > - is SafeMode now a replicated thing, or does each NN separately enter 
safemode? I think the latter, right?
bq.  > - when transitioning between states, what happens if the "enterState" 
fails for the new state? The state variable will then indicate it's in that 
state, when in fact it's in no state at all. How do we recover from that? We 
need some kind of rollback? (eg if you're in standby and try to transition to 
active, but find that you can't take a lock in ZK)

bq.  is SafeMode now a replicated thing, or does each NN separately enter 
safemode? I think the latter, right?
Safemode is the state of namespace(FSNamesystem), unlike active, standby which 
are the states of the namenode. Each NN separately enters safemode.

bq.  when transitioning between states, what happens if the "enterState" fails 
for the new state? The state variable will then indicate it's in that state, 
when in fact it's in no state at all. How do we recover from that? We need some 
kind of rollback? (eg if you're in standby and try to transition to active, but 
find that you can't take a lock in ZK)
This is tricky. Say enterState fails to start services because of some namenode 
process related issues. Then most likely rolling back to previous state, and 
starting services relevant to previous states will also fail. The particular 
example you are bringing up related to ZK, I think failover controller is the 
one that deals with ZK and not namenode.

I can think of two solutions: namenode shutsdown when this happens (as done 
during startup) or move to a failed state.


bq.  On 2011-10-03 18:58:13, Todd Lipcon wrote:
bq.  > 
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java,
 line 464
bq.  > 
bq.  >
bq.  > any reason that you switched the order of startHttpServer to the end 
of this function? I don't think it's a big deal, but there's some possibility 
the service plugins may want to do something with the http server, which 
wouldn't be started yet.

No particular reason. Not sure who uses ServicePlugins. But the description 
says it is RPC related. But will move it back up.


- Suresh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2150/#review2277
---


On 2011-10-03 18:36:41, Todd Lipcon wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2150/
bq.  ---
bq.  
bq.  (Updated 2011-10-03 18:36:41)
bq.  
bq.  
bq.  Review request for hadoop-hdfs and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Uploading Suresh's patch to reviewboard 
(https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from 
29/Sep/11 00:56)
bq.  
bq.  
bq.  This addresses bug HDFS-2301.
bq.  https://issues.apache.org/jira/browse/HDFS-2301
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
 1177130 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
 1177130 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
 1177130 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java
 1177128 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAContext.java
 PRE-CREATION 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAState.java
 1177128 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyState.java
 1177128 
bq.  
bq.  Diff: https://reviews.apache.org/r/2150/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Todd
bq.  
bq.



> Start/stop appropriate namenode internal services during transition to active 
> and standby
> -
>
> Key

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby

2011-10-06 Thread Todd Lipcon (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121775#comment-13121775
 ] 

Todd Lipcon commented on HDFS-2301:
---

Did you click on "Publish" on review board? I don't see your responses there. 
Once you publish, it will copy to JIRA and email.

> Start/stop appropriate namenode internal services during transition to active 
> and standby
> -
>
> Key: HDFS-2301
> URL: https://issues.apache.org/jira/browse/HDFS-2301
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: name-node
>Affects Versions: HA branch (HDFS-1623)
>Reporter: Suresh Srinivas
>Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt, 
> HDFS-2301.txt
>
>
> These changes are related to HDFS-1974 which introduced active and standby 
> states. This jira will address starting and stopping appropriate NN services 
> when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby

2011-10-03 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119497#comment-13119497
 ] 

jirapos...@reviews.apache.org commented on HDFS-2301:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2150/#review2277
---


just a few nits, mostly looks good. A few questions I have that aren't directly 
related to this patch:
- is SafeMode now a replicated thing, or does each NN separately enter 
safemode? I think the latter, right?
- when transitioning between states, what happens if the "enterState" fails for 
the new state? The state variable will then indicate it's in that state, when 
in fact it's in no state at all. How do we recover from that? We need some kind 
of rollback? (eg if you're in standby and try to transition to active, but find 
that you can't take a lock in ZK)


branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java


typo: secrect



branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java


any reason that you switched the order of startHttpServer to the end of 
this function? I don't think it's a big deal, but there's some possibility the 
service plugins may want to do something with the http server, which wouldn't 
be started yet.



branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java


this should at least be warn, right? and passing e as the second argument 
is better since it shows the trace.


- Todd


On 2011-10-03 18:36:41, Todd Lipcon wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2150/
bq.  ---
bq.  
bq.  (Updated 2011-10-03 18:36:41)
bq.  
bq.  
bq.  Review request for hadoop-hdfs and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Uploading Suresh's patch to reviewboard 
(https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from 
29/Sep/11 00:56)
bq.  
bq.  
bq.  This addresses bug HDFS-2301.
bq.  https://issues.apache.org/jira/browse/HDFS-2301
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
 1177130 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
 1177130 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
 1177130 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java
 1177128 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAContext.java
 PRE-CREATION 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAState.java
 1177128 
bq.
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyState.java
 1177128 
bq.  
bq.  Diff: https://reviews.apache.org/r/2150/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Todd
bq.  
bq.



> Start/stop appropriate namenode internal services during transition to active 
> and standby
> -
>
> Key: HDFS-2301
> URL: https://issues.apache.org/jira/browse/HDFS-2301
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: name-node
>Affects Versions: HA branch (HDFS-1623)
>Reporter: Suresh Srinivas
>Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2301.txt, HDFS-2301.txt
>
>
> These changes are related to HDFS-1974 which introduced active and standby 
> states. This jira will address starting and stopping appropriate NN services 
> when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby

2011-10-03 Thread jirapos...@reviews.apache.org (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119481#comment-13119481
 ] 

jirapos...@reviews.apache.org commented on HDFS-2301:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2150/
---

Review request for hadoop-hdfs and Todd Lipcon.


Summary
---

Uploading Suresh's patch to reviewboard 
(https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt from 
29/Sep/11 00:56)


This addresses bug HDFS-2301.
https://issues.apache.org/jira/browse/HDFS-2301


Diffs
-

  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
 1177130 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
 1177130 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
 1177130 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java
 1177128 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAContext.java
 PRE-CREATION 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAState.java
 1177128 
  
branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyState.java
 1177128 

Diff: https://reviews.apache.org/r/2150/diff


Testing
---


Thanks,

Todd



> Start/stop appropriate namenode internal services during transition to active 
> and standby
> -
>
> Key: HDFS-2301
> URL: https://issues.apache.org/jira/browse/HDFS-2301
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: name-node
>Affects Versions: HA branch (HDFS-1623)
>Reporter: Suresh Srinivas
>Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2301.txt, HDFS-2301.txt
>
>
> These changes are related to HDFS-1974 which introduced active and standby 
> states. This jira will address starting and stopping appropriate NN services 
> when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby

2011-09-28 Thread Suresh Srinivas (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116701#comment-13116701
 ] 

Suresh Srinivas commented on HDFS-2301:
---

Preliminary patch attached...

> Start/stop appropriate namenode internal services during transition to active 
> and standby
> -
>
> Key: HDFS-2301
> URL: https://issues.apache.org/jira/browse/HDFS-2301
> Project: Hadoop HDFS
>  Issue Type: Sub-task
>  Components: name-node
>Affects Versions: HA branch (HDFS-1623)
>Reporter: Suresh Srinivas
>Assignee: Suresh Srinivas
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2301.txt
>
>
> These changes are related to HDFS-1974 which introduced active and standby 
> states. This jira will address starting and stopping appropriate NN services 
> when entering and existing active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira