[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248353#comment-13248353 ] Hudson commented on HDFS-2564: -- Integrated in Hadoop-Mapreduce-trunk #1041 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1041/]) Updated CHANGES.txt to reflect HDFS-2564 merge (Revision 1309488) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309488 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248298#comment-13248298 ] Hudson commented on HDFS-2564: -- Integrated in Hadoop-Hdfs-trunk #1006 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1006/]) Updated CHANGES.txt to reflect HDFS-2564 merge (Revision 1309488) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309488 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246502#comment-13246502 ] Hudson commented on HDFS-2564: -- Integrated in Hadoop-Mapreduce-trunk-Commit #2006 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2006/]) Updated CHANGES.txt to reflect HDFS-2564 merge (Revision 1309488) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309488 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246460#comment-13246460 ] Hudson commented on HDFS-2564: -- Integrated in Hadoop-Common-trunk-Commit #1994 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1994/]) Updated CHANGES.txt to reflect HDFS-2564 merge (Revision 1309488) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309488 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246458#comment-13246458 ] Hudson commented on HDFS-2564: -- Integrated in Hadoop-Hdfs-trunk-Commit #2069 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2069/]) Updated CHANGES.txt to reflect HDFS-2564 merge (Revision 1309488) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309488 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 2.0.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153492#comment-13153492 ] Hudson commented on HDFS-2564: -- Integrated in Hadoop-Mapreduce-trunk #902 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/902/]) HDFS-2564. Cleanup unnecessary exceptions thrown and unnecessary casts. Contributed by Hari Mankude eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203950 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153472#comment-13153472 ] Hudson commented on HDFS-2564: -- Integrated in Hadoop-Hdfs-trunk #868 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/868/]) HDFS-2564. Cleanup unnecessary exceptions thrown and unnecessary casts. Contributed by Hari Mankude eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203950 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153362#comment-13153362 ] Hudson commented on HDFS-2564: -- Integrated in Hadoop-Mapreduce-trunk-Commit #1312 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1312/]) HDFS-2564. Cleanup unnecessary exceptions thrown and unnecessary casts. Contributed by Hari Mankude eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203950 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153359#comment-13153359 ] Hudson commented on HDFS-2564: -- Integrated in Hadoop-Hdfs-trunk-Commit #1360 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1360/]) HDFS-2564. Cleanup unnecessary exceptions thrown and unnecessary casts. Contributed by Hari Mankude eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203950 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153357#comment-13153357 ] Hudson commented on HDFS-2564: -- Integrated in Hadoop-Common-trunk-Commit #1286 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1286/]) HDFS-2564. Cleanup unnecessary exceptions thrown and unnecessary casts. Contributed by Hari Mankude eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203950 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153352#comment-13153352 ] Hadoop QA commented on HDFS-2564: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504325/hadoop-2564.trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1576//console This message is automatically generated. > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[
https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153330#comment-13153330
]
Hari Mankude commented on HDFS-2564:
{quote}
Why not just remove the catch clause entirely from refreshNamenodes? Ie
no need to create a new exception of the same type
{quote}
done. good catch.
{quote}
Why the new null checks for curBlock and descriptors, found a case where
they can be null?
{quote}
compiler warning about null ptr deref.
{quote}
The formatting of getRpcServerAddress should match the previous method (of
the same name)
{quote}
done
> Cleanup unnecessary exceptions thrown and unnecessary casts
> ---
>
> Key: HDFS-2564
> URL: https://issues.apache.org/jira/browse/HDFS-2564
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node, hdfs client, name-node
>Affects Versions: 0.24.0
>Reporter: Hari Mankude
>Assignee: Hari Mankude
>Priority: Minor
> Fix For: 0.24.0
>
> Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch,
> hadoop-2564.trunk.patch
>
>
> Cleaning up some of the java files with unnecessary exceptions and casts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153311#comment-13153311 ] Eli Collins commented on HDFS-2564: --- * Why not just remove the catch clause entirely from refreshNamenodes? Ie no need to create a new exception of the same type * Why the new null checks for curBlock and descriptors, found a case where they can be null? * The formatting of getRpcServerAddress should match the previous method (of the same name) Otherwise looks good. > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153286#comment-13153286 ] Hadoop QA commented on HDFS-2564: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504297/hadoop-2564.trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.TestFileAppend4 +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1574//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1574//console This message is automatically generated. > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, > hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153218#comment-13153218 ] Hadoop QA commented on HDFS-2564: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504288/hadoop-2564.trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed the unit tests build +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1573//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1573//console This message is automatically generated. > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153215#comment-13153215 ] Hari Mankude commented on HDFS-2564: Seperate out hadoop-common files into hdfs-7840 jira so that different projects can be applied. > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153194#comment-13153194 ] Hadoop QA commented on HDFS-2564: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504279/HDFS-2564-1.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1572//console This message is automatically generated. > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564-1.txt, HDFS-2564.txt, HDFS-2564.txt > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153073#comment-13153073 ] Hadoop QA commented on HDFS-2564: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504252/HDFS-2564.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1570//console This message is automatically generated. > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Assignee: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564.txt, HDFS-2564.txt > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2564) Cleanup unnecessary exceptions thrown and unnecessary casts
[ https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153030#comment-13153030 ] Hadoop QA commented on HDFS-2564: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12504240/HDFS-2564.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1569//console This message is automatically generated. > Cleanup unnecessary exceptions thrown and unnecessary casts > --- > > Key: HDFS-2564 > URL: https://issues.apache.org/jira/browse/HDFS-2564 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, hdfs client, name-node >Affects Versions: 0.24.0 >Reporter: Hari Mankude >Priority: Minor > Fix For: 0.24.0 > > Attachments: HDFS-2564.txt > > > Cleaning up some of the java files with unnecessary exceptions and casts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
